Senthil Kumaran added the comment:
Jeff, Thanks for raising this issue. The aspect of skipping localhost for
proxies in urllib2_localnet tests can be handled in a different way as well,
namely by setting the environment varible NO_PROXY to *. By this the
skip_proxies in urllib2 returns True
Serhiy Storchaka added the comment:
Sharing only those tests is not enough. We must revise all tests and extract
common code to the separated class. I think this is too large change and
unrelated to this issue. I will open a new issue for int tests enhancement and
refactoring.
--
Chris Jerdonek added the comment:
It's enough not to make the problem worse, which is why I suggested it and what
I wanted to avoid. If you copy-paste the tests you're adding now, it worsens
the problem and makes it that much more tedious to fix later on (and to
maintain in the meantime).
Charles-François Natali added the comment:
Semantically, but I am told that due to py3k's different file buffering, that
those errors don't percolate through. According to Charles-Francois' post
from apr, 14th:
Note that Python 3.3 doesn't have this problem.
It's not affected by the
Roundup Robot added the comment:
New changeset 6c186caa6285 by Senthil Kumaran in branch '2.7':
Issue #16702: Skip proxies for localhost in urllib2_localnet tests
http://hg.python.org/cpython/rev/6c186caa6285
New changeset 0eccfb237364 by Senthil Kumaran in branch '3.2':
Issue #16702: Skip
Senthil Kumaran added the comment:
Fixed in all branches of CPython. Thanks.
--
assignee: - orsenthil
resolution: - fixed
stage: - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16702
New submission from Serhiy Storchaka:
Int tests should be synchronized between different Python versions. Tests for
int and long should be synchronized in 2.7. Common code for int and long tests
should be shared in 2.7. CPython tests (i.e. small int identity) should be
extracted to separated
Changes by Serhiy Storchaka storch...@gmail.com:
--
dependencies: +Fix int(base=X), int() accepts float number base
nosy: +chris.jerdonek
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16784
Serhiy Storchaka added the comment:
Here is a patches which contains only minimal set of required changes. Other
unrelated changes will be done in issue16784.
--
Added file: http://bugs.python.org/file28439/int_without_x-2.7_3.patch
Added file:
Serhiy Storchaka added the comment:
Let's eat an elephant piece by piece. Only one issue per patch.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16761
___
Kristján Valur Jónsson added the comment:
Ok, I'll have a look.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14574
___
___
Python-bugs-list
Charles-François Natali added the comment:
I'm not sure that a setblocking() method to fileobjects would make much sense,
since non-blocking IO doesn't work with regular files (only pipes, sockets...).
--
nosy: +neologix
___
Python tracker
Chris Jerdonek added the comment:
Yes, it is a better approach. At first glance, the patches look okay to me.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16761
___
Chris Jerdonek added the comment:
Other things that should be done include porting the more comprehensive tests
in a recent changeset from 2.7 to 3.x and refactoring the try-except of one of
the tests as necessary (see the Rietveld comments of issue 16761 for details on
both).
The various
Roundup Robot added the comment:
New changeset 82531b78b719 by Brian Curtin in branch 'default':
Add NEWS entry for fixing #11939
http://hg.python.org/cpython/rev/82531b78b719
--
___
Python tracker rep...@bugs.python.org
Brian Curtin added the comment:
Thanks for the reviews.
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11939
Changes by Christian Heimes li...@cheimes.de:
--
nosy: +christian.heimes
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16769
___
___
New submission from Thorsten Kampe:
The - deprecated - version keyword for argparse.ArgumentParser allowed for
localization of the show program's version number and exit help text for
-v/--version (output of -h/--help)
The new version action for add_argument does not allow this - resulting in
Roundup Robot added the comment:
New changeset 9e980454b85e by Brian Curtin in branch 'default':
Add tests for Issue #10646.
http://hg.python.org/cpython/rev/9e980454b85e
--
nosy: +python-dev
___
Python tracker rep...@bugs.python.org
Roundup Robot added the comment:
New changeset 9e980454b85e by Brian Curtin in branch 'default':
Add tests for Issue #10646.
http://hg.python.org/cpython/rev/9e980454b85e
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11939
Changes by R. David Murray rdmur...@bitdance.com:
--
nosy: +bethard
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16786
___
___
Python-bugs-list
New submission from Charles-François Natali:
As noted in issue #12498, asyncore.dispatcher_with_send only sends 512 bytes at
a time: this is 1/3 of the Ethernet MTU, which reduces greatly the attainable
bandwidth and increases the CPU usage.
Here's a patch bumping it to 8192 (and making it a
Changes by Charles-François Natali neolo...@free.fr:
Added file: http://bugs.python.org/file28443/test_asyncore.py
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16787
___
Charles-François Natali added the comment:
Richard, apart from performance, what's the advantage of this approach over the
fork+exec version?
Because it seems more complicated, and although I didn't have a look a this
last patch, I guess that most of the fork+exec version could be factorized
Changes by Stefan Krah stefan-use...@bytereef.org:
--
nosy: +jkloth
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9709
___
___
Python-bugs-list
Stefan Krah added the comment:
I think this is the same as #9709. Please just reopen if it isn't.
--
nosy: +skrah
resolution: - duplicate
stage: - committed/rejected
status: open - closed
superseder: - test_distutils warning: initfunc exported twice on Windows
Giampaolo Rodola' added the comment:
A couple of years ago I conducted similar tests and it turned out that 64k was
the best compromise:
http://code.google.com/p/pyftpdlib/issues/detail?id=94
Twisted uses 128k.
I'd be for using 64k and also change asynchat.async_chat.ac_*_buffer_size in
Brian Curtin added the comment:
This was fixed as a result of #11939, and I've refactored the tests to add
coverage of hard links in 9e980454b85e.
This was originally a bug report but it requires a 3.4 feature so it can't be
fixed in 3.2 where it originally appeared.
--
resolution:
Richard Oudkerk added the comment:
On 32 bit Unix mmap() will raise ValueError(mmap length is too large) in
Marc's example. This is correct since Python's sequence protocol does not
support indexes larger than sys.maxsize.
But on 32 bit Windows, if length == 0 then the size check always
Serhiy Storchaka added the comment:
Try on Windows:
import os
from os.path import *
samestat(os.stat('.'), os.stat('.'))
Traceback (most recent call last):
File stdin, line 1, in module
NameError: name 'samestat' is not defined
--
___
Python
Changes by Brian Curtin br...@python.org:
--
assignee: brian.curtin
components: Library (Lib), Windows
nosy: brian.curtin
priority: normal
severity: normal
stage: needs patch
status: open
title: Add samestat to Lib/ntpath.py __all__
type: behavior
versions: Python 3.4
New submission from Roundup Robot:
New changeset cc3f7ef1072e by Brian Curtin in branch 'default':
Fix #16788. Add samestat to Lib/ntpath.py
http://hg.python.org/cpython/rev/cc3f7ef1072e
--
nosy: +python-dev
___
Python tracker rep...@bugs.python.org
Changes by Brian Curtin br...@python.org:
--
resolution: - fixed
stage: needs patch - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16788
___
Brian Curtin added the comment:
Separate issue. Fixed in #16788.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11939
___
___
Python-bugs-list
Serhiy Storchaka added the comment:
This change is not backward compatible. Now user can mmap a larger file and
safely access lower 2 GiB. With the patch it will fail.
Unix implementation uses unsafe integer overflow idiom which cause undefined
behavior (Mark, you have the floor).
--
New submission from Dan Kenigsberg:
ftplib, poplib and smtplib modules define a quit function. But when it is
refered by :meth:`quit` in the documentation, a reference to constants.quit is
generated.
The suggested patch spells out the module-specific quit function.
--
assignee:
Changes by Kristján Valur Jónsson krist...@ccpgames.com:
--
versions: +Python 3.2, Python 3.3, Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14574
___
Serhiy Storchaka added the comment:
Why does PyNumber_AsSsize_t() used instead PyLong_AsLongAndOverflow()? The
range of long enough for all valid values of base and code with
PyLong_AsLongAndOverflow() produces better error messages. It looks as a
regression for me.
--
Serhiy Storchaka added the comment:
Should it be backported to 2.7?
--
nosy: +serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3236
___
Roundup Robot added the comment:
New changeset 7e5d7ef4634d by Kristján Valur Jónsson in branch '3.2':
Issue #14574: Ignore socket errors raised when flushing a connection on close.
http://hg.python.org/cpython/rev/7e5d7ef4634d
New changeset 7734c3020a47 by Kristján Valur Jónsson in branch
Kristján Valur Jónsson added the comment:
There, applied the same changes to the 3.x branches.
apparently the DOC folder wasn't branched off for 3.3, or something, at least,
there is no sepatate 3.3 and 'default' version of socketserver.rst. Or maybe
it is just Hg that got the better of me.
Jesús Cea Avión added the comment:
I take care of this.
--
assignee: docs@python - jcea
nosy: +jcea
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16789
___
Richard Oudkerk added the comment:
This change is not backward compatible. Now user can mmap a larger file
and safely access lower 2 GiB. With the patch it will fail.
They should specify length=2GiB-1 if that is what they want.
With length=0 you can only access the lower 2GiB if file_size %
Roundup Robot added the comment:
New changeset 0ffaf1079a7a by Jesus Cea in branch '2.7':
Closes #16789: :meth:`quit` links to constants instead of own module
http://hg.python.org/cpython/rev/0ffaf1079a7a
New changeset 3801ee5d5d73 by Jesus Cea in branch '3.2':
Closes #16789: :meth:`quit` links
Serhiy Storchaka added the comment:
Agree.
Please add the same check for Unix implementation (instead of unsafe overflow
trick).
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16743
___
Jesús Cea Avión added the comment:
Thanks!.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16789
___
___
Python-bugs-list mailing list
Benjamin Peterson added the comment:
Basically, it calls locals() in the function scope, which is undefined behavior.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16781
___
Benjamin Peterson added the comment:
It's only an optimization, so no.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3236
___
___
STINNER Victor added the comment:
Status of the different issues:
#16416, Mac OS X: 3.2, 3.3, 3.4
#16455, FreeBSD and Solaris: 3.4
#16218, set_main_loader: 3.3, 3.4
#16218, test_cmd_line_script: 3.4 (3.3 has an old copy of the test)
#16414, add support.TESTFN_NONASCII: 3.4
#16444, use
Richard Oudkerk added the comment:
New patch with same check for Unix.
--
Added file: http://bugs.python.org/file28446/mmap.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16743
___
Changes by Serhiy Storchaka storch...@gmail.com:
--
resolution: - invalid
status: pending - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16413
___
Serhiy Storchaka added the comment:
Anatoly, if this is good for you, please close the issue.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16599
___
Serhiy Storchaka added the comment:
LGTM. Isn't 2 GiB + 1 bytes mmap file enough for testing?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16743
___
Andrew Svetlov added the comment:
Everything is fine. Close the issue.
--
stage: - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14574
___
Andrew Svetlov added the comment:
Anton, you are free to make that issue and propose a patch :)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15302
___
Andrew Svetlov added the comment:
New patch is LGTM.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15302
___
___
Python-bugs-list mailing list
Andrew Svetlov added the comment:
Chris, would you commit it?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15302
___
___
Python-bugs-list
Richard Oudkerk added the comment:
Isn't 2 GiB + 1 bytes mmap file enough for testing?
Yes.
But creating multigigabyte files is very slow on Windows. On Linux/FreeBSD
test_mmap takes a fraction of a second, whereas on Windows it takes over 2
minutes. (Presumably Linux/FreeBSD is
Chris Jerdonek added the comment:
BTW, maybe someone should create an issue for full tests coverage of regrtest?
I think such an issue would need to be a meta-issue because it is a very large
task (involving many patches) and may never be truly finished.
Chris, would you commit it?
Sure, I
Andrew Svetlov added the comment:
Agree with both points
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15302
___
___
Python-bugs-list mailing
R. David Murray added the comment:
I'm still -0 on making a new file. regrtest will be running as __main__, so I
don't see any reason the test file can't import it to test functions within it.
--
___
Python tracker rep...@bugs.python.org
R. David Murray added the comment:
(I could, of course, be wrong :)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15302
___
___
Benjamin Peterson added the comment:
Yes, please don't make something called regrtestlib.py. Some of us like the
bash completetion to work with on a small prefix. :)
--
nosy: +benjamin.peterson
___
Python tracker rep...@bugs.python.org
Andrew Svetlov added the comment:
Close as out of date. Packaging has been removed from stdlib.
--
nosy: +asvetlov
resolution: - out of date
stage: patch review -
status: open - closed
___
Python tracker rep...@bugs.python.org
Andrew Svetlov added the comment:
Close as out of date since packaging has been removed from stdlib.
--
nosy: +asvetlov
resolution: - out of date
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12944
Chris Jerdonek added the comment:
Benjamin, do you not want a new file at all, or are you just asking for a
different name? regrlib was the previous name unless you have another
suggestion.
--
___
Python tracker rep...@bugs.python.org
Benjamin Peterson added the comment:
I think bitdancer's suggestion of leaving it in regrtest.py is a good one.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15302
___
Roundup Robot added the comment:
New changeset 6a56eaa5e5fb by Andrew Svetlov in branch 'default':
Revert back PyCFunction_New macro. Keep PyCFunction_NewEx usage in python core
modules (#15422)
http://hg.python.org/cpython/rev/6a56eaa5e5fb
--
___
R. David Murray added the comment:
Do you mean that *modifying* locals() in the function scope is undefined
behavior? That makes sense, and is a documented limitation.
So we need to clarify the execfile/exec documentation to note that if called in
anything other than the global scope,
Andrew Svetlov added the comment:
Georg, I've followed your instructions.
Close the issue again.
Thanks for mentorship.
--
resolution: - fixed
stage: - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
Benjamin Peterson added the comment:
The best thing would be if we could kill the default use of locals() and
globals() in execfile, but that's probably Py4 material.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16781
Roundup Robot added the comment:
New changeset 70ea05f762a1 by Andrew Svetlov in branch 'default':
Fix compilation error for #15422
http://hg.python.org/cpython/rev/70ea05f762a1
--
___
Python tracker rep...@bugs.python.org
Roundup Robot added the comment:
New changeset 39be1514c16c by Andrew Svetlov in branch '3.2':
fix test for subprocess (#16644)
http://hg.python.org/cpython/rev/39be1514c16c
New changeset 5d172190c37c by Andrew Svetlov in branch '3.3':
fix test for subprocess (#16644)
Andrew Svetlov added the comment:
Fixed.
Thanks, Serhiy.
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16644
Changes by Richard Oudkerk shibt...@gmail.com:
--
title: mmap accepts files 1 GB, but processes only 1 GB - mmap on Windows
can mishandle files larger than sys.maxsize
type: enhancement - behavior
___
Python tracker rep...@bugs.python.org
Gregory P. Smith added the comment:
I used it because Mark suggested it could have the same behavior as round() and
that is the more abstract API that round uses. Regardless, at this point I've
added tests and tested for the TypeError when a float is passed as well as
testing that the only
Serhiy Storchaka added the comment:
Sorry, I had missed you reuse an existing test. It's right. I think decreasing
file size to 4 GiB + 1 byte will keep the purpose of the test and save a little
time, but this is another issue. Let's go ahead!
--
Terry J. Reedy added the comment:
New data, new thoughts ;-)
I agree that an undocumented discrepancy between Windows and *nix should be
fixed either in doc, code, or both. The fix might be version specific.
If the limit on Windows is less than it should or could be, because of our
code,
Vinay Sajip added the comment:
What about subclassing Logger? Then you could override findCaller() to do
whatever you need, as well as adding a notice() method, for example.
I agree using the source filename isn't ideal, but it's hard to know how people
might arbitrarily wrap logging calls
Changes by Jesús Cea Avión j...@jcea.es:
--
nosy: +jcea
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16743
___
___
Python-bugs-list mailing list
Glynn Clements added the comment:
Subclassing findCaller() is likely to be a bit hairy for the average user, as
it deals with some fairly arcane aspects of Python internals.
As for mechanism, maybe allow functions/methods to be registered with the
logging module, which would store a
Changes by Ned Deily n...@acm.org:
Added file: http://bugs.python.org/file28447/patch_idle_issue_15853.sh
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15853
___
Ned Deily added the comment:
ActiveTcl 8.5.13 has now been released and, per ActiveState's usual practice of
making only the current release and its immediate predecessor publicly
downloadable, the ActiveTcl 8.5.11.1 release is no longer available at the URL
above, as Vance noted. 8.5.13
Ned Deily added the comment:
The problem reported here no longer occurs with Tk 8.5.13. See
http://www.python.org/download/mac/tcltk/ for important information about using
8.5.13, including a workaround patch for Issue15853 until Python 3.3.1, 3.2.4,
and 2.7.4 are released.
--
Chris Jerdonek added the comment:
I'm attaching an updated patch incorporating David and Benjamin's suggestion.
(Thanks a lot for the feedback, by the way.) I also added a test for the help
option and refactored to avoid having to use context managers to check
sys.argv, sys.stderr, etc.
Chris Jerdonek added the comment:
Here is an alternative patch with a cleaner diff (keeping the help-related
strings at the top before the import statements).
--
Added file: http://bugs.python.org/file28449/issue-15302-5.patch
___
Python tracker
Ned Deily added the comment:
Thanks for the additional information. I am now able to reproduce the behavior
you observe when using ActiveTcl 8.5.11.1 and also when using the
Apple-supplied 8.5.9 in OS X 10.8; presumably, it is also an issue with earlier
versions of Cocoa Tk 8.5. The good
Benjamin Peterson added the comment:
I posted some review comments.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15302
___
___
Chris Jerdonek added the comment:
Thanks. I replied.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15302
___
___
Python-bugs-list mailing list
New submission from Chris Jerdonek:
Currently, adding new int() and long() tests that are common to both requires
duplicating the tests in both test_int and test_long, which makes the tests
harder to review and maintain and keep in synch.
Providing a simple way to share tests between test_int
Chris Jerdonek added the comment:
Attaching patch. The tests moved to SharedTestCaseMixin in this patch are
tests that were very recently added (as part of issue 16045) and that are
planned on being added to test_long as part of issue 16784.
--
keywords: +patch
Added file:
Chris Jerdonek added the comment:
I created issue 16790 to allow the sharing of tests between test_int and
test_long in 2.7. I don't think issue 16761 and issue 16772 should be
prerequisites to this issue though because both issues could benefit from issue
16790 being committed first (since
Serhiy Storchaka added the comment:
Why not inherit IntTestCases and LongTest from SharedTestCaseMixin? And looks
as CommonSomeTest naming is more common than SharedSomeTest.
--
components: +Tests -Interpreter Core
nosy: +serhiy.storchaka
stage: - patch review
type: - enhancement
Serhiy Storchaka added the comment:
As Richard explained, this will not break working code, this will break only
broken code. Working limit will not be changed, it's sys.maxsize on all
platforms.
--
___
Python tracker rep...@bugs.python.org
Serhiy Storchaka added the comment:
A large part of IntTestCases.test_basic() and LongTest.test_long() can be
shared, as a number of smaller tests.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16784
Chris Jerdonek added the comment:
Agreed. I just didn't want it to be a requirement of beginning shared tests in
case anyone objects to refactoring existing tests in 2.7 -- as opposed to using
it for the addition of new tests.
--
___
Python
Chris Jerdonek added the comment:
Good point. New patch coming shortly.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16790
___
___
Serhiy Storchaka added the comment:
But you have if (!PyLong_Check(obase)) check before. Only ints acceptable.
The only difference with previous code is that now OverflowError raised for
large bases instead of ValueError. int.__round__ doesn't produce OverflowError.
In any case the final
Chris Jerdonek added the comment:
In any case the final version of those changes should be applied to 3.2 and
3.3 too (if no one objects).
+1
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16772
Chris Jerdonek added the comment:
Note that we need to be more careful about checking for duplicate test names
now.
--
Added file: http://bugs.python.org/file28451/issue-16790-2-27.patch
___
Python tracker rep...@bugs.python.org
1 - 100 of 101 matches
Mail list logo
