Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: docs@python - serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18743
___
Glenn Linderman added the comment:
Paul, is this ready to merge, or are you thinking of more refinements?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14191
___
Ethan Furman added the comment:
Eric, please do not feel your time has been wasted. I greatly appreciate the
knowledge you shared and I learned much.
I feel very strongly that, as much as possible, an Enum should Just Work.
Requiring users to write their own __format__ any time they create
Ethan Furman added the comment:
This patch contains the previous patch, plus a fix and tests for %i, %d, and %u
formatting, and tests only for %f formatting (nothing to fix there, but don't
want it breaking in the future ;) .
--
Added file:
New submission from Kees Bos:
ElementTree.fromstring and cElementTree.fromstring fail on parsing
value]]/value, but do parse value]]gt;/value
$ python
Python 2.7.3 (default, Apr 10 2013, 05:09:49)
[GCC 4.7.2] on linux2
Type help, copyright, credits or license for more information.
from
Charles-François Natali added the comment:
I've just had a quick look at the patch, but from what I can see,
socket.getaddrinfo() will return a raw integer for the family, and not an
AddressFamily instance. That's unfortunate.
--
___
Python tracker
Charles-François Natali added the comment:
I was thinking about dropping the C wrapper from socketmodule.c, and
replacing it with a pure Python implementation (e.g. the one posted by
Richard on python-dev).
What do you think?
--
___
Python tracker
Charles-François Natali added the comment:
Here's an updated patch using the lru_cache decorator.
--
Added file: http://bugs.python.org/file31312/connect_timeout-1.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16463
Charles-François Natali added the comment:
Unfortunately, there's not much we can do about it: if dlsym() fails - which is
the case here either because read() fails with EBADF, or because the file
descriptor now points to another stream (i.e. not libgcc), the libc aborts
(here upon
Roundup Robot added the comment:
New changeset f6034602410c by Christian Heimes in branch 'default':
Issue #18673: Add O_TMPFILE to os module. O_TMPFILE requires Linux kernel
http://hg.python.org/cpython/rev/f6034602410c
New changeset 815b7bb3b08d by Christian Heimes in branch 'default':
Issue
Antoine Pitrou added the comment:
Perhaps the only thing we could do would be try to preload libgcc by calling
one of those APIs at startup? But I'm not sure it's a good idea to add such a
platform-specific hack (for what is arguably an obscure and rare issue).
--
nosy: +pitrou
Christian Heimes added the comment:
I have added O_TMPFILE to the os module.
I like to hold off with the actual use of O_TMPFILE in tempfile until Python
3.5. The feature is too new and I don't have any way to test it. Some people
have reported file system corruption in 3.11-rc4, too.
Changes by STINNER Victor victor.stin...@gmail.com:
--
nosy: +haypo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18748
___
___
Python-bugs-list
Changes by Christian Heimes li...@cheimes.de:
--
status: pending - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18368
___
___
Ezio Melotti added the comment:
it seems try/except is still the best way. :-/
Indeed: http://docs.python.org/dev/glossary#term-eafp
--
nosy: +ezio.melotti
stage: - committed/rejected
___
Python tracker rep...@bugs.python.org
STINNER Victor added the comment:
Maries Ionel Cristian ubuntu 12.04.2
What is the version of your libc library? Try something like dpkg -l libc6.
--
Could this issue be related to this glibc issue?
http://sourceware.org/bugzilla/show_bug.cgi?id=2644
I ran your script on Python 3.4 in a
STINNER Victor added the comment:
Oh ok, I'm able to reproduce the issue with the system Python 3.3:
$ while true; do echo loop; python3.3 bug.py || break; done
loop
...
loop
libgcc_s.so.1 must be installed for pthread_cancel to work
Abandon (core dumped)
--
R. David Murray added the comment:
Hmm. The linked issue says the PyMappingCheck behavior is new in Python3, but
this problem exists in Python2 (back to 2.4 at least) as well. Perhaps it is a
different bug in Python2.
--
___
Python tracker
Eli Bendersky added the comment:
Great catch, Charles-François, thanks. It's actually an interesting example in
favor of the approach - it's very nice to see descriptive family names in the
data returned by getaddrinfo, instead of obtuse numeric values.
The attached patch fixes it in a
R. David Murray added the comment:
Why do you think this is a bug? (You may well be right; I'm not familiar with
the intricacies of XML. But on its face the behavior looks reasonable.)
--
nosy: +r.david.murray
___
Python tracker
Eric V. Smith added the comment:
The code looks basically the same in 2.7, and there PyMapping_Check looks for
__getitem__, so maybe issue 5945 is just incorrect in its analysis.
In any event, I'm not sure this is worth fixing. There are lots of little
corner cases that could be broken.
Eli Bendersky added the comment:
Looks nice:
for t in socket.getaddrinfo('www.google.com', 'http'):
... t
...
(AddressFamily.AF_INET: 2, 1, 6, '', ('74.125.239.112', 80))
(AddressFamily.AF_INET: 2, 2, 17, '', ('74.125.239.112', 80))
(AddressFamily.AF_INET: 2, 1, 6, '', ('74.125.239.116',
New submission from STINNER Victor:
Python 3.4 has a new command line option to run Python in isolated mode: -I.
IMO it would be nice to use this option to make the test suite more independant
of the user configuration and the environment.
Attached patch modifies the test.script_helper module
STINNER Victor added the comment:
The test does now pass with the patch, so I close the issue.
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18296
Eli Bendersky added the comment:
Looks pretty good, Serhiy. I left some comments in Rietveld.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16799
___
New submission from Brett Cannon:
imp._HackedGetData doesn't check if the file it cached from its constructor is
still open or not. Since the path had previously been stored it would make
sense to try re-opening the file if the file object has already been closed.
--
assignee:
Changes by Ethan Furman et...@stoneleaf.us:
--
assignee: - ethan.furman
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18745
___
___
Jesús Cea Avión added the comment:
I confirm this. The patch for 5.3 support created a regression. And, in fact,
it is not working at all (it missed the 5.x libraries anyway).
Reopening the old bug.
In the meantime, please check http://www.jcea.es/programacion/pybsddb.htm
--
Changes by Jesús Cea Avión j...@jcea.es:
--
nosy: +doko
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18734
___
___
Python-bugs-list mailing list
Jesús Cea Avión added the comment:
This patch is incorrect.
It doesn't compile with Berkeley DB 5.x at all, and it doesn't allow to compile
against 4.4-4.9 (previously supported). So currently it is a bit regression.
Check bug #18734.
--
nosy: +Eddie.Stanley
resolution: fixed -
Jesús Cea Avión added the comment:
Note also that reusing my pybsddb project you are dropping support for several
old releases of Berkeley DB that where supported by Python 2.7.4.
If somebody were using it, they are left dead in the water, just because doing
a minor Python upgrade.
New submission from Christian Heimes:
I have seen complains from e.g. Tarek that os.urandom() fails under high load:
https://twitter.com/tarek_ziade/status/362281268215418880
The problem is caused by file descriptor limits. os.urandom() opens
/dev/urandom for every call. How about
STINNER Victor added the comment:
I have seen complains from e.g. Tarek that os.urandom() fails under high
load: https://twitter.com/tarek_ziade/status/362281268215418880
dev_urandom_python() should handle ENFILE and ENOENT differently to raise a
different exception. Or it should always
Serhiy Storchaka added the comment:
Here is a patch. Actually this is a small part of larger problem for which I
will open several separated issues.
--
keywords: +patch
stage: needs patch - patch review
Added file: http://bugs.python.org/file31315/doc_StringIO_refs.patch
Changes by Antoine Pitrou pit...@free.fr:
--
nosy: +christian.heimes
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18618
___
___
Python-bugs-list
Antoine Pitrou added the comment:
I don't think that's bug in os.urandom(). If os.urandom() doesn't fail,
something else will fail soon after.
OTOH, the error is clearly misleading. The NotImplementedError should only be
raised for certain errnos (such as ENOENT, ENODEV, ENXIO and EACCES), not
Charles-François Natali added the comment:
Perhaps the only thing we could do would be try to preload libgcc by
calling one of those APIs at startup?
Yeah, I was thinking about doing this in PyThread_init_thread() but...
But I'm not sure it's a good idea to
add such a platform-specific
Brett Cannon added the comment:
Haven't looked at the patch but the motivation behind it sounds good to me.
--
nosy: +brett.cannon
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18754
___
Jesús Cea Avión added the comment:
Patch is incomplete. I found this error while reading unittest.mock, that you
are not patching.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18743
___
Jesús Cea Avión added the comment:
I agree with Antoine. Exhausting the FDs is not the problem, the problem is the
misleading error.
--
nosy: +jcea
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18756
Christian Heimes added the comment:
For the record PHP has assigned CVE-2013-4248 for the issue.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18709
___
Richard Oudkerk added the comment:
Do you mean you want to use a pure python implementation on Unix?
Then you would have to deal with AF_UNIX (which is the default family for
socketpair() currently). A pure python implementation which deals with AF_UNIX
would have to temporarily create a
Tarek Ziadé added the comment:
If os.urandom() doesn't fail, something else will fail soon after.
the random pool can be exhausted, but this is not soon after I think. In
Linux and Mac OS X, ulimit -n defaults to 512 and 256.
It's very easy to reach that limit if you write a web app that
Tarek Ziadé added the comment:
Can tarek tell us more about its usecases: is he directly calling
os.urandom() or does he use the random module? How many threads?
I was using ws4py inside greenlets. ws4py uses os.urandom() to generate some
keys. So one single thread, many greenlets.
Charles-François Natali added the comment:
If os.urandom() doesn't fail, something else will fail soon after.
the random pool can be exhausted, but this is not soon after I think. In
Linux and Mac OS X, ulimit -n defaults to 512 and 256.
I don't think he's referring to the entropy pool, but
Christian Heimes added the comment:
Tarek Ziadé added the comment:
If os.urandom() doesn't fail, something else will fail soon after.
the random pool can be exhausted, but this is not soon after I think. In
Linux and Mac OS X, ulimit -n defaults to 512 and 256.
It's highly unlikely
Tarek Ziadé added the comment:
What does high load mean?
a web app with a few hundreds concurrent requests.
If you mean many concurrent threads, then you should probably go for
the random module, no?
I use greenlets. But, I don't know - are you suggesting os.urandom() should be
marked in
Charles-François Natali added the comment:
2013/8/16, Tarek Ziadé rep...@bugs.python.org:
I use greenlets. But, I don't know - are you suggesting os.urandom() should
be marked in the documentation as DOES NOT SCALE and I should use another
API ? Which one ?
Well, even with greenlets, I
Tarek Ziadé added the comment:
Well, even with greenlets, I assume you're using at least one FD
(socket) per client, no?
So you can get EMFILE on socket() just as on os.urandom().
I do many calls on urandom() so that's the FD bottleneck.
So os.urandom() isn't your biggest problem here.
Of
Christian Heimes added the comment:
Am 16.08.2013 18:24, schrieb Charles-François Natali:
Well, first we'll have to make the code thread-safe, if we want to
keep a persistent FD open. Which means we'll have to add a lock, which
is likely to reduce concurrency, and overall throughput.
Why
Antoine Pitrou added the comment:
Well, even with greenlets, I assume you're using at least one FD
(socket) per client, no?
So you can get EMFILE on socket() just as on os.urandom().
I do many calls on urandom() so that's the FD bottleneck.
Unless you're doing many calls *in parallel*
Catherine Devlin added the comment:
Attaching new patch incorporating Vajrasky's suggestion
--
Added file: http://bugs.python.org/file31316/test1666318.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1666318
Changes by Ezio Melotti ezio.melo...@gmail.com:
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18706
___
Charles-François Natali added the comment:
I do many calls on urandom() so that's the FD bottleneck.
So os.urandom() isn't your biggest problem here.
Of course it is. But it looks like you know better without having looked at
the code. :)
So please explain me :-)
os.urandom() can only be
Antoine Pitrou added the comment:
Am 16.08.2013 18:24, schrieb Charles-François Natali:
Well, first we'll have to make the code thread-safe, if we want to
keep a persistent FD open. Which means we'll have to add a lock, which
is likely to reduce concurrency, and overall throughput.
Why
Kees Bos added the comment:
I'm not an expert, but from: http://www.w3.org/TR/REC-xml/#NT-AttValue
AttValue ::= '' ([^] | Reference)* '' | ' ([^'] | Reference)*
'
which I read as: Any Reference character is valid, except and , which are
used for escaping and closing the element.
Changes by Antoine Pitrou pit...@free.fr:
--
nosy: +eli.bendersky, scoder
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18753
___
___
Christian Heimes added the comment:
Am 16.08.2013 18:47, schrieb Charles-François Natali:
I don't think it can be fixed. I think Christian's working on a PEP
for random number generators, which would probably make it easier,
although I din't have a look at it.
In the light of the recent
Tarek Ziadé added the comment:
Unless you're doing many calls *in parallel* it's unlikely to be a
bottleneck.
That's what we're saying since message 1. Antoine, allo quoi! :)
os.urandom() is a convenience function, it doesn't have to be extremely
optimized
I suggest that you tell it the
Charles-François Natali added the comment:
Why locking? /dev/urandom is a pseudo char device. You can have multiple
readers on the same fd without any locking.
You must put a lock around the open() call, though, to avoid calling it
several times and losing an fd.
Exactly (unless the FD is
Charles-François Natali added the comment:
In the light of the recent Android issue with PRNGs [1] I don't think
that Python should roll out its own CPRNG. I'd rather use the operation
system's CPRNG or OpenSSL's CPRNG. After all we aren't crypto experts.
I'd rather point my finger to
Antoine Pitrou added the comment:
Attaching a patch to make error reporting better.
--
keywords: +patch
Added file: http://bugs.python.org/file31317/urandom_error.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18756
Tarek Ziadé added the comment:
So please explain me :-).
it sounded like you did not really want any explanation
os.urandom() can only be called by one thread/greenlet at a time.
do you mean that we cannot have two parallel calls of that function ?
e.g. two opened FD at the same time ?
Donald Stufft added the comment:
Just to be explicit, ``open(/dev/urandom)`` only works on POSIX platforms
while ``os.usrandom`` should work on any supported platform that has an OS
level source of randomness. So advocating *for* simply using ``open()`` is
probably a bad idea unless the
Antoine Pitrou added the comment:
Good point, Donald. os.urandom() is the only (simple) way to access the Windows
randomness pool.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18756
___
Changes by Donald Stufft donald.stu...@gmail.com:
--
nosy: +dstufft
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16190
___
___
Python-bugs-list
Antoine Pitrou added the comment:
Done.
--
resolution: - fixed
stage: needs patch - committed/rejected
status: open - closed
versions: -Python 3.2
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16190
Changes by Alex Gaynor alex.gay...@gmail.com:
--
nosy: +alex
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18756
___
___
Python-bugs-list mailing
Roundup Robot added the comment:
New changeset 9df0501fab35 by Antoine Pitrou in branch '3.3':
Issue #16190: fix random module recommendation to use ssl.RAND_bytes().
http://hg.python.org/cpython/rev/9df0501fab35
New changeset 04b50a1eb013 by Antoine Pitrou in branch 'default':
Issue #16190:
Charles-François Natali added the comment:
Attaching a patch to make error reporting better.
Why didn't you include ENODEV?
Apparently it can be reported in some corner cases, e.g. in this patch:
http://lfs-matrix.net/patches/downloads/linux/linux-2.6.14.2-pseudo_random-1.patch
Otherwise,
Antoine Pitrou added the comment:
Why didn't you include ENODEV?
Apparently it can be reported in some corner cases, e.g. in this patch:
http://lfs-matrix.net/patches/downloads/linux/linux-2.6.14.2-pseudo_random-1.patch
That isn't mentioned in the POSIX open() spec:
Donald Stufft added the comment:
Looking at random.SystemRandom it appears it would suffer from the same FD
exhaustion problem.
So as of right now afaik none of the sources of cryptographically secure random
in the python stdlib offer a way to open a persistent FD. The primary question
on my
Roundup Robot added the comment:
New changeset c388e93879c4 by Antoine Pitrou in branch '3.3':
Issue #1666318: Add a test that shutil.copytree() retains directory permissions.
http://hg.python.org/cpython/rev/c388e93879c4
New changeset 8906713d5704 by Antoine Pitrou in branch 'default':
Issue
Antoine Pitrou added the comment:
Patch committed to 3.3 and 3.4. Thank you very much!
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
versions: +Python 3.3
___
Python tracker rep...@bugs.python.org
Antoine Pitrou added the comment:
So as of right now afaik none of the sources of cryptographically
secure random in the python stdlib offer a way to open a persistent
FD. The primary question on my mind is if os.urandom can't be modified
to maintain a persistent FD can Python offer a
Ezio Melotti added the comment:
LGTM.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18701
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Serhiy Storchaka:
Here is a patch which fixes internal references in the documentation of
concurrent modules: threading, multiprocessing, concurrent.futures, subprocess,
queue, and select.
--
assignee: docs@python
components: Documentation
messages: 195378
nosy:
R. David Murray added the comment:
For what it is worth, I am currently writing some email tests and it would
certainly be convenient to have this. Of course I *can* define it locally in
the the test file.
--
___
Python tracker
Ezio Melotti added the comment:
Serhiy, seems you forgot to attach a patch.
--
nosy: +ezio.melotti
type: - enhancement
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18757
___
Antoine Pitrou added the comment:
Attached patch to make os.urandom's fd persistent.
--
type: behavior - resource usage
Added file: http://bugs.python.org/file31318/persistent_urandom_fd.patch
___
Python tracker rep...@bugs.python.org
Antoine Pitrou added the comment:
Updated error handling patch testing for ENODEV.
--
Added file: http://bugs.python.org/file31319/urandom_error2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18756
Changes by Charles-François Natali cf.nat...@gmail.com:
Added file: http://bugs.python.org/file31320/connect_timeout-2.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16463
___
Ezio Melotti added the comment:
Can't this be developed as an external extension?
I don't see a reason to include it in the stdlib, especially if it requires
other dependencies (like the pep8 module).
--
nosy: +ezio.melotti
status: open - pending
Changes by Serhiy Storchaka storch...@gmail.com:
--
stage: - test needed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16799
___
___
Serhiy Storchaka added the comment:
Thank you for the review Eli. Could you please review issue17974 while I will
write tests?
As for a duplication I think about using vars():
def main(tests=None, testdir=None, verbose=0, quiet=False, ...):
return _main(**vars())
def _main(tests,
Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: - serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16799
___
___
Serhiy Storchaka added the comment:
I don't see StringIO in Doc/library/unittest.mock.rst.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18743
___
Serhiy Storchaka added the comment:
Ah, I missed it. Here is completed patch.
--
Added file: http://bugs.python.org/file31321/doc_StringIO_refs_2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18743
Roundup Robot added the comment:
New changeset 6bc88d61f302 by Ezio Melotti in branch '2.7':
#18707: point to Doc/README.txt in the README file. Patch by Madison May.
http://hg.python.org/cpython/rev/6bc88d61f302
New changeset 477a143bfbfd by Ezio Melotti in branch '3.3':
#18707: point to
Serhiy Storchaka added the comment:
Sorry. It is here.
--
keywords: +patch
Added file: http://bugs.python.org/file31322/refs.concurrect.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18757
Ezio Melotti added the comment:
Fixed, thanks for the report and the patch!
--
assignee: docs@python - ezio.melotti
resolution: - fixed
stage: - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
STINNER Victor added the comment:
Why did you remove reference to ssl.RAND_bytes() on Python 3.3 from the notice?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16190
___
Antoine Pitrou added the comment:
As far as I understand, os.urandom() is fine for the task. There's no point in
mentioning ssl.RAND_bytes() just because it exists, IMO.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16190
New submission from Serhiy Storchaka:
This is a meta issue for fixing broken references in the documentation. I will
open a child issues for some groups of modules and finally provide a patch for
rest files.
--
assignee: docs@python
components: Documentation
messages: 195392
nosy:
Changes by Serhiy Storchaka storch...@gmail.com:
--
dependencies: +Fix internal references for concurrent modules, References to
non-existant StringIO module
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18758
Charles-François Natali added the comment:
Updated error handling patch testing for ENODEV.
LGTM, you can apply to 2.7 and 3.x (I just hope all those errnos are
available on every POSIX platform ;-).
--
___
Python tracker rep...@bugs.python.org
Roundup Robot added the comment:
New changeset 193bcc12575d by Antoine Pitrou in branch '3.3':
Issue #18756: Improve error reporting in os.urandom() when the failure is due
to something else than /dev/urandom not existing.
http://hg.python.org/cpython/rev/193bcc12575d
New changeset
Roundup Robot added the comment:
New changeset ec296a36156b by Antoine Pitrou in branch '2.7':
Issue #18756: Improve error reporting in os.urandom() when the failure is due
to something else than /dev/urandom not existing.
http://hg.python.org/cpython/rev/ec296a36156b
--
Antoine Pitrou added the comment:
Ok, committed. We're left with the persistent fd patch for 3.4.
--
stage: needs patch - patch review
versions: -Python 2.7, Python 3.3
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18756
Serhiy Storchaka added the comment:
Besides some nitpicks which I have left on Rietveld the patch LGTM.
I guess the _family_converter idiom will be popular enough. Perhaps we will add
some helper just to the Enum class.
--
___
Python tracker
1 - 100 of 164 matches
Mail list logo
