[issue18808] Thread.join returns before PyThreadState is destroyed

2013-09-06 Thread Antoine Pitrou
Antoine Pitrou added the comment: Le vendredi 06 septembre 2013 à 00:19 +, Tim Peters a écrit : Tim Peters added the comment: So you're not concerned about a now-private API (which used to be advertised), but are concerned about a user mucking with a new private lock in an exceedingly

[issue18934] multiprocessing: use selectors module

2013-09-06 Thread Charles-François Natali
Charles-François Natali added the comment: Richard Oudkerk added the comment: I remember wondering at one time why EPOLLNVAL did not exist, and realizing that closed fds are just silently unregistered by epoll(). Exactly. I guess the issue is that some of the selectors indicate a bad fd

[issue1584] Mac OS X: building with X11 Tkinter

2013-09-06 Thread Roundup Robot
Roundup Robot added the comment: New changeset 0986e4f5750d by Ned Deily in branch 'default': Issue #1584: Provide options to override default search paths for Tcl and Tk http://hg.python.org/cpython/rev/0986e4f5750d -- nosy: +python-dev ___ Python

[issue15663] Investigate providing Tcl/Tk 8.5 with OS X installers

2013-09-06 Thread Roundup Robot
Roundup Robot added the comment: New changeset 985384cd6365 by Ned Deily in branch 'default': Issue #15663: Tcl/Tk 8.5.14 is now included with the OS X 10.6+ http://hg.python.org/cpython/rev/985384cd6365 -- nosy: +python-dev ___ Python tracker

[issue18939] Venv docs regarding original python install

2013-09-06 Thread Vinay Sajip
Vinay Sajip added the comment: The venv documentation does assume that the reader knows what virtual environments are and how they work. More details are available in PEP 405, which is not referenced in this documentation - I will rectify that. --

[issue15663] Investigate providing Tcl/Tk 8.5 with OS X installers

2013-09-06 Thread Ned Deily
Changes by Ned Deily n...@acm.org: -- dependencies: +Mac OS X: building with X11 Tkinter ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15663 ___

[issue18939] Venv docs regarding original python install

2013-09-06 Thread Roundup Robot
Roundup Robot added the comment: New changeset ad09332f856f by Vinay Sajip in branch '3.3': Issue #18939: Updated venv documentation with some clarifications. http://hg.python.org/cpython/rev/ad09332f856f New changeset 408b6b3dcf9a by Vinay Sajip in branch 'default': Closes #18939: Merged

[issue18943] argparse: default args in mutually exclusive groups

2013-09-06 Thread Armin Rigo
New submission from Armin Rigo: In argparse, default arguments have a strange behavior that shows up in mutually exclusive groups: specifying explicitly on the command-line an argument, but giving it its default value, is sometimes equivalent to not specifying the argument at all, and

[issue18943] argparse: default args in mutually exclusive groups

2013-09-06 Thread Armin Rigo
Changes by Armin Rigo ar...@users.sourceforge.net: -- keywords: -patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18943 ___ ___

[issue18943] argparse: default args in mutually exclusive groups

2013-09-06 Thread Armin Rigo
Changes by Armin Rigo ar...@users.sourceforge.net: -- components: +Library (Lib) ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18943 ___ ___

[issue18940] TimedRotatingFileHandler and RotatingFileHandler fail to doRollover if a logger has delay=True and no logs in that time.

2013-09-06 Thread Roundup Robot
Roundup Robot added the comment: New changeset 6a591870017c by Vinay Sajip in branch '2.7': Issue #18940: Handled low-volume logging when delay is True. http://hg.python.org/cpython/rev/6a591870017c New changeset 324774a59256 by Vinay Sajip in branch '3.3': Issue #18940: Handled low-volume

[issue18944] Minor mistake in test_set.py

2013-09-06 Thread Armin Rigo
New submission from Armin Rigo: Found a minor mistake in test_set.py. Patch attached. -- components: Interpreter Core files: test_set.diff keywords: patch messages: 197060 nosy: arigo priority: normal severity: normal status: open title: Minor mistake in test_set.py versions: Python

[issue18941] RotatingFileHandler and TimedRotatingFileHandler do not respect delay on rollover

2013-09-06 Thread Roundup Robot
Roundup Robot added the comment: New changeset 4d45f1ed1179 by Vinay Sajip in branch '2.7': Issue #18941: Respected delay when doing rollover. http://hg.python.org/cpython/rev/4d45f1ed1179 New changeset 0577c9a82c0a by Vinay Sajip in branch '3.3': Issue #18941: Respected delay when doing

[issue18945] Name collision handling in tempfile is not covered by tests

2013-09-06 Thread Vlad Shcherbina
New submission from Vlad Shcherbina: I intend to add test for (existing dir)-(new file) collision in http://bugs.python.org/issue18849, but file-file, file-dir and dir-dir collisions are yet to be covered. -- components: Tests messages: 197062 nosy: vlad priority: normal severity:

[issue18876] Problems with files opened in append mode with io module

2013-09-06 Thread Antoine Pitrou
Antoine Pitrou added the comment: Erik Bray added the comment: Thank you! Has there been a separate issue opened for the BufferedWriter bug or can that be covered by this issue as well? No other issue has been opened as I know of, but indeed it would be clearer to open a separate one.

[issue15663] Investigate providing Tcl/Tk 8.5 with OS X installers

2013-09-06 Thread Ronald Oussoren
Ronald Oussoren added the comment: Great work. Thanks. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15663 ___ ___ Python-bugs-list mailing

[issue18849] Failure to try another name for tempfile when directory with chosen name exists on windows

2013-09-06 Thread Roundup Robot
Roundup Robot added the comment: New changeset 7611e7244bdd by Eli Bendersky in branch '3.3': Issue #18849: Fixed a Windows-specific tempfile bug where collision with an http://hg.python.org/cpython/rev/7611e7244bdd New changeset 035b61b52caa by Eli Bendersky in branch 'default': Issue #18849:

[issue18849] Failure to try another name for tempfile when directory with chosen name exists on windows

2013-09-06 Thread Roundup Robot
Roundup Robot added the comment: New changeset e0037f266d45 by Eli Bendersky in branch '2.7': Close #18849: Fixed a Windows-specific tempfile bug where collision with an http://hg.python.org/cpython/rev/e0037f266d45 -- resolution: - fixed stage: patch review - committed/rejected

[issue18852] site.py does not handle readline.__doc__ being None

2013-09-06 Thread Thomas Heller
Thomas Heller added the comment: I suggest to remove the comment part from the patch and then apply it. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18852 ___

[issue18920] argparse module version action

2013-09-06 Thread Roundup Robot
Roundup Robot added the comment: New changeset ec9a4b77f37b by Eli Bendersky in branch 'default': Issue #18920: argparse's default version action (for -v, --version) should http://hg.python.org/cpython/rev/ec9a4b77f37b -- nosy: +python-dev ___ Python

[issue18920] argparse module version action

2013-09-06 Thread Eli Bendersky
Eli Bendersky added the comment: Thanks, I moved the NEWS entry to the right place. Yes, all tests pass. I'll update whatsnew separately. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18920

[issue18922] Output versions of scripts to stdout

2013-09-06 Thread Roundup Robot
Roundup Robot added the comment: New changeset 587bdb940524 by Eli Bendersky in branch 'default': Update whatsnew/3.4 wrt. --version going to stdout. #18338, #18920, #18922 http://hg.python.org/cpython/rev/587bdb940524 -- ___ Python tracker

[issue18920] argparse module version action

2013-09-06 Thread Roundup Robot
Roundup Robot added the comment: New changeset 587bdb940524 by Eli Bendersky in branch 'default': Update whatsnew/3.4 wrt. --version going to stdout. #18338, #18920, #18922 http://hg.python.org/cpython/rev/587bdb940524 -- ___ Python tracker

[issue18920] argparse module version action

2013-09-06 Thread Eli Bendersky
Changes by Eli Bendersky eli...@gmail.com: -- resolution: - fixed stage: patch review - committed/rejected status: open - closed versions: -Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18920

[issue18338] python --version should send output to STDOUT

2013-09-06 Thread Roundup Robot
Roundup Robot added the comment: New changeset 587bdb940524 by Eli Bendersky in branch 'default': Update whatsnew/3.4 wrt. --version going to stdout. #18338, #18920, #18922 http://hg.python.org/cpython/rev/587bdb940524 -- ___ Python tracker

[issue917120] imaplib: incorrect quoting in commands

2013-09-06 Thread Daniël van Eeden
Changes by Daniël van Eeden launch...@myname.nl: -- nosy: +dveeden ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue917120 ___ ___ Python-bugs-list

[issue18945] Name collision handling in tempfile is not covered by tests

2013-09-06 Thread Eli Bendersky
Changes by Eli Bendersky eli...@gmail.com: -- nosy: +eli.bendersky ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18945 ___ ___ Python-bugs-list

[issue18924] Enum members are easily replaced

2013-09-06 Thread Ethan Furman
Ethan Furman added the comment: In retrospect the read-only properties would not be any more difficult to get around than the __setattr__ solution, and it would conflict with our use of _RouteClassAttributeToGetattr. To properly replace an enum member one has to change two internal data

[issue18924] Enum members are easily replaced

2013-09-06 Thread Roundup Robot
Roundup Robot added the comment: New changeset 1d88d04aade2 by Ethan Furman in branch 'default': Close #18924: Block naive attempts to change an Enum member. http://hg.python.org/cpython/rev/1d88d04aade2 -- nosy: +python-dev resolution: - fixed stage: patch review - committed/rejected

[issue16938] pydoc confused by __dir__

2013-09-06 Thread Armin Rigo
Armin Rigo added the comment: I believe that this describes a problem more general than the problem of Enums from Issue18693: help(x) shouldn't crash in the presence of a __dir__() method that returns unexpected names. -- nosy: +arigo ___ Python

[issue7511] msvc9compiler.py: ValueError when trying to compile with VC Express

2013-09-06 Thread Steve Dower
Steve Dower added the comment: I believe that is all that is missing from the patches I posted, though I'd have thought that having Visual C++ 2010 Express installed would be sufficient without the patch (though you didn't mention C++, so maybe you have a different one?). --

[issue18946] HTMLParser should ignore errors when parsing text in script tags

2013-09-06 Thread James Lu
New submission from James Lu: It will show invalid html inside of script tags, for example, at the learners dictionary: function output_creative (id) { document.write (div id=' + id + ' + scr

[issue18946] HTMLParser should ignore errors when parsing text in script tags

2013-09-06 Thread Ezio Melotti
Ezio Melotti added the comment: This should be fixed in 2.7 and 3.2+. Try with a more recent version of Python and if you still have problems feel free to reopen the issue. -- components: +Library (Lib) resolution: - out of date stage: - committed/rejected status: open - closed type:

[issue18946] HTMLParser should ignore errors when parsing text in script tags

2013-09-06 Thread Ezio Melotti
Ezio Melotti added the comment: What version of Python are you using? -- nosy: +ezio.melotti ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18946 ___

[issue18946] HTMLParser should ignore errors when parsing text in script tags

2013-09-06 Thread James Lu
James Lu added the comment: 2.5, but I don't think the library has changed since. james On Fri, Sep 6, 2013 at 12:29 PM, Ezio Melotti rep...@bugs.python.orgwrote: Ezio Melotti added the comment: What version of Python are you using? -- nosy: +ezio.melotti

[issue18852] site.py does not handle readline.__doc__ being None

2013-09-06 Thread Roundup Robot
Roundup Robot added the comment: New changeset 3070fdd58645 by R David Murray in branch 'default': #18852: Handle readline.__doc__ being None in site.py readline activation. http://hg.python.org/cpython/rev/3070fdd58645 -- nosy: +python-dev ___

[issue18852] site.py does not handle readline.__doc__ being None

2013-09-06 Thread R. David Murray
R. David Murray added the comment: Done. Thanks, Berker. -- resolution: - fixed stage: patch review - committed/rejected status: open - closed type: - behavior ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18852

[issue18944] Minor mistake in test_set.py

2013-09-06 Thread Terry J. Reedy
Terry J. Reedy added the comment: The typo causes 1 test to run 5 times instead of 5 tests 1 each. After fix, all pass on Win7, 3.4.0a1 (where fix is on line 1675 instead of 1618). -- nosy: +rhettinger, terry.reedy ___ Python tracker

[issue18917] python won't display greek characters in apache under windows

2013-09-06 Thread Terry J. Reedy
Changes by Terry J. Reedy tjre...@udel.edu: -- resolution: - works for me stage: - committed/rejected ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18917 ___

[issue18623] Factor out the _SuppressCoreFiles context manager

2013-09-06 Thread Roundup Robot
Roundup Robot added the comment: New changeset 28a1843c0fc1 by Antoine Pitrou in branch 'default': Issue #18623: Factor out the _SuppressCoreFiles context manager into test.support. http://hg.python.org/cpython/rev/28a1843c0fc1 -- nosy: +python-dev

[issue18949] codeop possible flow error

2013-09-06 Thread R. David Murray
R. David Murray added the comment: Why do you think that? Can you provide a test case that fails? -- nosy: +r.david.murray ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18949 ___

[issue18903] IDLE file-completion is case-sensitive in Windows

2013-09-06 Thread Terry J. Reedy
Terry J. Reedy added the comment: This strikes me a sort-of a bug. However, feature vs. bug does not matter for small changes (see PEP434). Is Windows the only case preserving, case insensitive OS? -- nosy: +terry.reedy ___ Python tracker

[issue18934] multiprocessing: use selectors module

2013-09-06 Thread Roundup Robot
Roundup Robot added the comment: New changeset 14972c999e80 by Charles-François Natali in branch 'default': Issue #18934: Relax test_multiprocessing.test_invalid_handles a bit: we just http://hg.python.org/cpython/rev/14972c999e80 -- ___ Python

[issue18623] Factor out the _SuppressCoreFiles context manager

2013-09-06 Thread Antoine Pitrou
Antoine Pitrou added the comment: The explicit 'object' superclass is old-school ;-) Ha. Ok, I've fixed it. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18623 ___

[issue18623] Factor out the _SuppressCoreFiles context manager

2013-09-06 Thread Antoine Pitrou
Antoine Pitrou added the comment: Patch committed, thanks! -- resolution: - fixed stage: commit review - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18623

[issue1625] bz2.BZ2File doesn't support multiple streams

2013-09-06 Thread Darko Veberic
Darko Veberic added the comment: It is interesting, this issue was fixed in boost 4 years ago: https://svn.boost.org/trac/boost/ticket/3853 and a comment from the pbzip2 author suggests that not supporting multiple streams is in violation of the bz2 file format spec. -- nosy:

[issue18947] Bug in module netaddr

2013-09-06 Thread R. David Murray
R. David Murray added the comment: Netaddr is not an stdlib module. Please report the bug to the netaddr maintainers. -- nosy: +r.david.murray resolution: - invalid stage: - committed/rejected status: open - closed versions: +3rd party -Python 2.7

[issue18948] deliberately crashing tests should prevent core dumps

2013-09-06 Thread Antoine Pitrou
New submission from Antoine Pitrou: Here is a (exhaustive?) list of tests which deliberately crash the interpreter: - test_daemon_threads_fatal_error() in test_threading - several fatal error tests in test_faulthandler - test_recursionlimit_fatalerror() in test_sys -

[issue18917] python won't display greek characters in apache under windows

2013-09-06 Thread Terry J. Reedy
Terry J. Reedy added the comment: I believe that this is *the* answer to the issue, so the issue should be closed. -- nosy: +terry.reedy ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18917

[issue18949] codeop possible flow erro

2013-09-06 Thread Wilberto Morales
New submission from Wilberto Morales: I think the way this loop in /Lib/codeop.py is wrong def _maybe_compile(compiler, source, filename, symbol): # Check for source consisting of only blank lines and comments for line in source.split(\n): line = line.strip() if line and

[issue18934] multiprocessing: use selectors module

2013-09-06 Thread Charles-François Natali
Charles-François Natali added the comment: I just realized that using DefaultSelector isn't optimal for Connection: It's fine for forkserver, since it's a long lived process, but for Connection.poll(), this means that it'll use epoll or kqueue: which means allocating a new epoll/kqueue object

[issue18944] Minor mistake in test_set.py

2013-09-06 Thread Tim Peters
Changes by Tim Peters t...@python.org: -- components: +Tests -Interpreter Core ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18944 ___ ___

[issue18623] Factor out the _SuppressCoreFiles context manager

2013-09-06 Thread Charles-François Natali
Charles-François Natali added the comment: Is there anything else that this patch should address? I hoped Charles-François would answer this one, but no, I don't think there's anything left :) Sorry, I had completely forgotten this issue. The only comment I have is this: class

[issue18852] site.py does not handle readline.__doc__ being None

2013-09-06 Thread Antoine Pitrou
Antoine Pitrou added the comment: Thanks David! I had forgotten about the issue. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18852 ___ ___

[issue18949] codeop possible flow error

2013-09-06 Thread Wilberto Morales
Changes by Wilberto Morales wilbertomorales...@gmail.com: -- title: codeop possible flow erro - codeop possible flow error ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18949 ___

[issue18873] Encoding detected in non-comment lines

2013-09-06 Thread Sergey Vishnikin
Sergey Vishnikin added the comment: -cookie_re = re.compile(coding[:=]\s*([-\w.]+)) +cookie_re = re.compile(#[^\r\n]*coding[:=]\s*([-\w.]+)) Regex matches only if the encoding expression is preceded by a comment. -- keywords: +patch nosy: +armicron Added file:

[issue18949] codeop possible flow error

2013-09-06 Thread Wilberto Morales
Wilberto Morales added the comment: I can't provide a example but reading the source comments it seems wrong. 'First, check if the source consists entirely of blank lines and comments; if so, replace it with 'pass', because the built-in parser doesn't always do the right thing for these.' So

[issue18944] Minor mistake in test_set.py

2013-09-06 Thread Armin Rigo
Changes by Armin Rigo ar...@users.sourceforge.net: -- assignee: - tim.peters ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18944 ___ ___

[issue18944] Minor mistake in test_set.py

2013-09-06 Thread Roundup Robot
Roundup Robot added the comment: New changeset b6059bac8a9c by Tim Peters in branch '3.3': Issue 18944: fix a 1-character typo in test_set.py. http://hg.python.org/cpython/rev/b6059bac8a9c New changeset 4b64166d5abb by Tim Peters in branch 'default': Merge 3.3 into default.

[issue18944] Minor mistake in test_set.py

2013-09-06 Thread Tim Peters
Changes by Tim Peters t...@python.org: -- resolution: - fixed stage: - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18944 ___

[issue18947] Bug in module netaddr

2013-09-06 Thread Mikael Ryding
New submission from Mikael Ryding: I found this in the netaddr module when I was trying to get the CIDR from a number of ip/netmask combinations. The expected cidr in the example below should be: 192.1.0.0/23. ip = netaddr.IPNetwork(192.1.1.128, 255.255.254.0) ip.netmask

[issue18917] python won't display greek characters in apache under windows

2013-09-06 Thread Nick
Changes by Nick low...@yahoo.com: -- status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18917 ___ ___ Python-bugs-list mailing

[issue18937] add unittest assertion for logging

2013-09-06 Thread Antoine Pitrou
Antoine Pitrou added the comment: Proposed patch with an assertLogs() method. -- keywords: +patch Added file: http://bugs.python.org/file31630/assertlogs.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18937

[issue18950] Miscellaneous fixes for the sunau module

2013-09-06 Thread Serhiy Storchaka
New submission from Serhiy Storchaka: The proposed patch fixes followed bugs in the sunau module: 1. Au_read.readframes() reads wrong number of frames from multichannel stream. 2. Au_read.readframes() doesn't change current file position. 3. Au_write.writeframesraw() incorrectly updates

[issue18919] Unify audio modules tests

2013-09-06 Thread Serhiy Storchaka
Changes by Serhiy Storchaka storch...@gmail.com: -- dependencies: +Miscellaneous fixes for the sunau module ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18919 ___

[issue18939] Venv docs regarding original python install

2013-09-06 Thread Graham Wideman
Graham Wideman added the comment: @Vinay Sajip Thanks for looking at this issue and adding the link to PEP 405, and your explanation When working... with helpful shebang comments. That said, the combination of PEP 405 and this updated page doesn't clear things up completely. Vinay remarks

[issue18919] Unify audio modules tests

2013-09-06 Thread Serhiy Storchaka
Changes by Serhiy Storchaka storch...@gmail.com: Added file: http://bugs.python.org/file31632/audiotests_2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18919 ___

[issue16938] pydoc confused by __dir__

2013-09-06 Thread Ethan Furman
Ethan Furman added the comment: Crash is probably too strong. help() runs, but doesn't return anything useful. Metaclasses aside, I think the real issue here is objects that don't have __objclass__ defined. __objclass__ has been around for over a decade (see PEP-0252), and with that

[issue4709] Mingw-w64 and python on windows x64

2013-09-06 Thread Alex
Alex added the comment: I want to add that this bug led to bizarre behavior (described here: http://stackoverflow.com/questions/18646694/pass-pointer-from-c-to-python-w-boost-python) when using 64-bit Boost-Python compiled with Mingw-w64 in Windows 7. Boost-Python and programs linked to it

[issue5202] wave.py cannot write wave files into a shell pipeline

2013-09-06 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Oh, I forgot attach a patch. In any case it already slightly outdated. After looking at other audio modules I think David's approach is better. It is also used in the chunk module. Here is updated patch with tests (tests are not final, issue18919 provides

[issue5202] wave.py cannot write wave files into a shell pipeline

2013-09-06 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Oh, I forgot attach a patch. In any case it already slightly outdated. After looking at other audio modules I think David's approach is better. It is also used in the chunk module. Here is updated patch with tests (tests are not final, issue18919 provides

[issue18919] Unify audio modules tests

2013-09-06 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Patch updated. It now contains tests for all supported encoding formats (PCM8-32, u-Law, A-Law). -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18919

[issue5202] wave.py cannot write wave files into a shell pipeline

2013-09-06 Thread Serhiy Storchaka
Changes by Serhiy Storchaka storch...@gmail.com: -- assignee: - serhiy.storchaka stage: needs patch - patch review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5202 ___

[issue18458] libedit history offset workaround

2013-09-06 Thread Ned Deily
Ned Deily added the comment: The original patch missed one spot. Here's an updated version. I'm going to apply this to default (for the imminent 3.4.0a2) in case people start running into this on new versions of OS X. It needs to be backported to 2.7 and 3.3; a test would be nice and it

[issue18939] Venv docs regarding original python install

2013-09-06 Thread R. David Murray
R. David Murray added the comment: You have understood correctly, after reading the now-existing documentation. Do you have a suggestion for how they could be further improved, given that they currently seem to convey accurate information? For the autonomy question, as far as I know the only

[issue18873] Encoding detected in non-comment lines

2013-09-06 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: It will fail on: #coding=0 I'm wondering why findall() is used to match this regexp. -- nosy: +serhiy.storchaka ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18873

[issue16938] pydoc confused by __dir__

2013-09-06 Thread Armin Rigo
Armin Rigo added the comment: The __objclass__ is a workaround. I don't understand your point. I think the original poster is saying that simply putting a __dir__() method on a class can confuse help() more than would be necessary, and if he's correct I agree with him. --

[issue18949] codeop possible flow error

2013-09-06 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I'm not even sure when this else statement is executed. It executed when no breaks were happen. I.e. both variants of code are equivalent besides the fact that variant with else doesn't require named boolean variable. It is a feature of Python syntax.

[issue16938] pydoc confused by __dir__

2013-09-06 Thread Ethan Furman
Ethan Furman added the comment: Ronald said: One possible workaround: assume that the class is the inspected class when a name returned by dir(cls) cannot be found in one of the classes on the mro. At some point will this cause help to display an attribute on the wrong class? --

[issue18458] libedit history offset workaround

2013-09-06 Thread Roundup Robot
Roundup Robot added the comment: New changeset b6b8a2171aa3 by Ned Deily in branch 'default': Issue #18458: Prevent crashes with newer versions of libedit. Its readline http://hg.python.org/cpython/rev/b6b8a2171aa3 -- nosy: +python-dev ___ Python

[issue16938] pydoc confused by __dir__

2013-09-06 Thread Ethan Furman
Ethan Furman added the comment: dir(obj) is only confused if it returns attributes that are not found in obj.__dict__ (aka virtual attributes). For these virtual attributes, setting __objclass__ solves the problem. Armin, when you say it's a workaround do you mean __objclass__ itself, or the

[issue18937] add unittest assertion for logging

2013-09-06 Thread Michael Foord
Michael Foord added the comment: So making assertions about logging is very common, but I *always* do this by just mocking out the logger and making an assertion about the call. It's trivially easy to do. -- ___ Python tracker

[issue18623] Factor out the _SuppressCoreFiles context manager

2013-09-06 Thread Antoine Pitrou
Antoine Pitrou added the comment: Is there anything else that this patch should address? I hoped Charles-François would answer this one, but no, I don't think there's anything left :) Next step (for another issue perhaps) is to actually re-use this context manager in the other tests which

[issue18943] argparse: default args in mutually exclusive groups

2013-09-06 Thread paul j3
paul j3 added the comment: The patch isn't a good unittest case because it produces an Error, not a Failure. It does, though, raise a valid question about how a Mutually_exclusive_group tests for the use of its arguments. As you note, argparse does use the `is` test: `argument_values is not

[issue18937] add unittest assertion for logging

2013-09-06 Thread Antoine Pitrou
Antoine Pitrou added the comment: So making assertions about logging is very common, but I *always* do this by just mocking out the logger and making an assertion about the call. It's trivially easy to do. Only works if you test the exact logger that will be triggered, rather than e.g. a

[issue18937] add unittest assertion for logging

2013-09-06 Thread Michael Foord
Michael Foord added the comment: Do you have a lot of circumstances where you want to test logging but you don't know the specific logger and method called? That's not a situation I've been in. -- ___ Python tracker rep...@bugs.python.org

[issue18937] add unittest assertion for logging

2013-09-06 Thread Antoine Pitrou
Antoine Pitrou added the comment: Do you have a lot of circumstances where you want to test logging but you don't know the specific logger and method called? That's not a situation I've been in. I have a lot of circumstances where I do not *care* about the specific logger (as long as it's

[issue18944] Minor mistake in test_set.py

2013-09-06 Thread Tim Peters
Tim Peters added the comment: The fix is obviously correct ;-) - so what next? Armin Terry, I don't know whether you have commit privileges. If you don't, assign it to me and I'll commit it. Removed 3.5 from the Versions list and added 3.3 and 3.4. -- nosy: +tim.peters versions:

[issue18808] Thread.join returns before PyThreadState is destroyed

2013-09-06 Thread Tim Peters
Tim Peters added the comment: All the timeout args are great! I wish Python had always had them :-) Back to the pain at hand, it's not the number of lines of code that rubs me the wrong way, but the sheer obscurity of it all. This handful of lines is - of necessity - sprayed across two C

[issue18944] Minor mistake in test_set.py

2013-09-06 Thread Terry J. Reedy
Terry J. Reedy added the comment: Just to answer, anyone with Python snake has commit privileges of some sort but may not be setup to commit to cpython. I suspect Armin found this while review the test for pypy. I focus mostly on Idle, but on better days, will do little commits like this.

[issue18944] Minor mistake in test_set.py

2013-09-06 Thread Tim Peters
Tim Peters added the comment: Right, I should have asked specifically about cpython commit privs ;-) Thanks for expounding! -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18944 ___

[issue18943] argparse: default args in mutually exclusive groups

2013-09-06 Thread paul j3
paul j3 added the comment: A further complication on this. With the arguments I defined in the previous post p.parse_args('--foo test --baz 257'.split()) gives the mutually exclusive error message. `sys.argv` does the same. p.parse_args(['--foo', 'test', '--baz', '257']) does not

[issue18937] add unittest assertion for logging

2013-09-06 Thread R. David Murray
R. David Murray added the comment: Exactly. It is the difference between black box testing and white box testing. IMO mock, while a great tool, should be used with caution, because it tends to lead to white box testing. -- ___ Python tracker

[issue18951] In unittest.TestCase.assertRegex change re and regex to r

2013-09-06 Thread py.user
New submission from py.user: there is no direct link to table look under link http://docs.python.org/3/library/unittest.html#unittest.TestCase.assertWarnsRegex -- assignee: docs@python components: Documentation files: issue.diff keywords: patch messages: 197130 nosy: docs@python,

[issue18908] Enum docs: sections leak out

2013-09-06 Thread Roundup Robot
Roundup Robot added the comment: New changeset a55cbaf9a581 by Ethan Furman in branch 'default': Close #18908: Keep Enum docs in their own section. Patch by Elazar Gershuni. http://hg.python.org/cpython/rev/a55cbaf9a581 -- nosy: +python-dev resolution: - fixed stage: patch review -

[issue18952] Fix test.support.open_urlresource (support package regression)

2013-09-06 Thread Zachary Ware
New submission from Zachary Ware: Since test.support was moved into its own package, support.open_urlresource has been unable to work. It expects __file__ dir/data to exist, but since __file__ dir is now Lib/test/support instead of Lib/test, it doesn't unless someone creates it manually.

[issue18952] Fix test.support.open_urlresource (support package regression)

2013-09-06 Thread Zachary Ware
Zachary Ware added the comment: Here's an alternative fix, which just makes open_urlresource look one directory higher than where __file__ lives. -- Added file: http://bugs.python.org/file31638/fix_support_open_urlresource.diff ___ Python tracker

[issue18953] Typo in NEWS about fixed format specifiers for Py_ssize_t in debugging output in the _sre module

2013-09-06 Thread Vajrasky Kok
New submission from Vajrasky Kok: File Misc/NEWS, line 65 66: - Issue #18672: Fixed format specifiers for Py_ssize_t in debugging output in the _sre moduel. moduel = module Related commit: http://hg.python.org/cpython/rev/c41c68a18bb6 -- assignee: docs@python components:

[issue18954] Grammatically incorrect sentences in Python/fileutils.c

2013-09-06 Thread Vajrasky Kok
New submission from Vajrasky Kok: In commit about implementation of the PEP 446: file descriptors and file handles are now created non-inheritable, there are some grammatically incorrect sentences in Python/fileutils.c. Please see the patch for details. Related commit:

[issue18955] Confusing documentation in Lib/importlib/util.py

2013-09-06 Thread Vajrasky Kok
New submission from Vajrasky Kok: In Lib/importlib/util.py, the documentation is confusing me. Line 42 43: If an exception is raised and the decorator created the module it is subsequently removed from sys.modules. Is it supposed to be: If an exception is raised and the

  1   2   >