STINNER Victor added the comment:
I never seen this issue, can we close it?
#7105 has been fixed in Python 3, not in Python 2.7.
--
nosy: +haypo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7060
STINNER Victor added the comment:
What is the status of this issue? Does anyone still want to backport the fix to
Python 2.7?
(I found this issue while searching for test_multiprocessing failures, and I
found #7060 which refers this issue.)
--
nosy: +haypo
Serhiy Storchaka added the comment:
array's constructor interprets its second memoryview argument as an iterable of
integers.
import array
array.array('h', b'abcd')
array('h', [25185, 25699])
array.array('h', memoryview(b'abcd'))
array('h', [97, 98, 99, 100])
array.frombytes() always
STINNER Victor added the comment:
array's constructor interprets its second memoryview argument as an iterable
of integers.
Ok so, so your fix is correct.
First patch fixes only a half of the issue.
test_unseekable_incompleted_write() still failed because array.fromfile()
fails read
STINNER Victor added the comment:
Ok, the test passed with the second fix.
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19634
___
Serhiy Storchaka added the comment:
Why the test succeeded on little endian?
Because array.fromfile() is used only to swap 16- and 32-bit samples on
bigendian platform.
Perhaps we need the byteswap() function in the audioop module.
--
___
Python
STINNER Victor added the comment:
Even with PyTrash_UNWIND_LEVEL in Include/object.h defined to 10 instead of 50,
I cannot reproduce the issue on the 2.7 branch of Mercurial. I guess that the
bug was already fixed in Python 2.7 and this issue has no activity since 3
years, so I'm closing it.
STINNER Victor added the comment:
I didn't see this failure recently. The issue doesn't contain useful
information, and has no activity since more than 1 year, so I'm closing it.
Reopen the issue with more information if it was reproduced recently.
--
nosy: +haypo
resolution: -
STINNER Victor added the comment:
Because array.fromfile() is used only to swap 16- and 32-bit samples on
bigendian platform.
If the file is truncated, why would the test suceed on little endian? The file
doesn't have the same size in bytes? The test doesn't check the number of
frames?
Changes by STINNER Victor victor.stin...@gmail.com:
--
title: test_multiprocessing.test_connection failure -
test_multiprocessing.test_connection failure on Python 2.7
versions: +Python 2.7
___
Python tracker rep...@bugs.python.org
STINNER Victor added the comment:
The initial issue (RuntimeError messages) has been fixed, I'm closing the issue.
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19565
Changes by STINNER Victor victor.stin...@gmail.com:
--
title: test_multiprocessing_spawn hangs - test_context() of
test_multiprocessing_spawn hangs on x86 Gentoo Non-Debug 3.x buildbot
___
Python tracker rep...@bugs.python.org
STINNER Victor added the comment:
If the result of os.read() was stored in a Python daemon thread, the memory
should be released since the following changeset. Can someone check if this
issue still exist?
changeset: 87070:c2a13acd5e2b
user:Victor Stinner victor.stin...@gmail.com
STINNER Victor added the comment:
See issue #12413 which may help to analyze this hang.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19564
___
Tim Golden added the comment:
Thanks, guys; I'm afraid I only watched the stable buildbots when I committed -
the AIX doesn't seem to be included.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19634
STINNER Victor added the comment:
multiprocessing_faulthandler_timeout.patch: Dump the traceback of all Python
threads in a child process if it takes more than 10 minutes to succeed. On the
buildbot, the process hangs more than 1 hour. I guess that 10 minutes in enough
for a single unit test.
STINNER Victor added the comment:
You could use the Py_SAFE_DOWNCAST macro everywhere.
I prefer to store sizes in a size type (Py_ssize_t), and only downcast where it
is really needed, in compiler_addop_i(). So in the future, if someone wants to
support values larger than INT_MAX, only one
New submission from Christian Heimes:
The patch silences three compiler warnings on Win64
--
components: Windows
files: dtoa.patch
keywords: patch
messages: 203264
nosy: christian.heimes, haypo, zach.ware
priority: normal
severity: normal
stage: patch review
status: open
title: dtoa:
Changes by Ezio Melotti ezio.melo...@gmail.com:
--
assignee: - ezio.melotti
versions: +Python 3.4 -Python 3.2
Added file: http://bugs.python.org/file32682/issue2927.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2927
STINNER Victor added the comment:
Your patch implies that the two only supported OSes are Linux and Windows :-)
It more means that Windows memory allocator is different to the one used on all
other operating systems.
Well, if you are not convinced, we can keep the overallocation factor of
STINNER Victor added the comment:
I forgot to mention this issue in the following changesets.
changeset: 87128:f0a7924fac56
user:Victor Stinner victor.stin...@gmail.com
date:Fri Nov 15 23:16:15 2013 +0100
files: Modules/_randommodule.c
description:
Fix compiler warning
Bernt Røskar Brenna added the comment:
I just tested on 3.4a0.
Observed the following changes:
- subprocess_devnull now NEVER fails.
- subprocess_redirfile does not fail as often as before, but still fails.
I changed the number of tasks to 20 and increased max_workers to 5 to get
New submission from Claudiu.Popa:
When issue17087 was accepted, the documentation wasn't changed to reflect the
new changes. The attached patch fixes this, replacing the old _sre.Match
object ... with the deterministic repr of the match object.
--
assignee: docs@python
components:
Bernt Røskar Brenna added the comment:
Increasing max_workers to 5 and running 20 tasks highlighs the 3.3-3.4
difference (code in attached file testscript4.py):
Version: 3.4.0a4 (v3.4.0a4:e245b0d7209b, Oct 20 2013, 19:23:45) [MSC v.1600 32 b
it (Intel)]
Platform: Windows-XP-5.1.2600-SP3
Tasks:
New submission from STINNER Victor:
The definition of a new nametuple creates a large Python script to create the
new type. The code stores the code in a private attribute:
namespace = dict(__name__='namedtuple_%s' % typename)
exec(class_definition, namespace)
result =
STINNER Victor added the comment:
I found this issue while using my tracemalloc module to analyze the memory
consumption of Python. On the Python test suite, the _source attribute is the
5th line allocating the memory memory:
/usr/lib/python3.4/collections/__init__.py: 676.2 kB
--
Changes by Ezio Melotti ezio.melo...@gmail.com:
--
assignee: docs@python - ezio.melotti
nosy: +ezio.melotti
stage: - patch review
type: - enhancement
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19639
Changes by Ezio Melotti ezio.melo...@gmail.com:
--
assignee: - ezio.melotti
resolution: - duplicate
stage: test needed - committed/rejected
status: open - closed
superseder: - expose html.parser.unescape
___
Python tracker rep...@bugs.python.org
Changes by Bernt Røskar Brenna bernt.bre...@gmail.com:
--
versions: +Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19575
___
___
Changes by Christian Heimes li...@cheimes.de:
--
nosy: +christian.heimes
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19640
___
___
Serhiy Storchaka added the comment:
If the file is truncated, why would the test suceed on little endian? The
file doesn't have the same size in bytes? The test doesn't check the number
of frames?
Because this code is not used on little endian. On little endian a data is
read by file's
New submission from Serhiy Storchaka:
The audio modules often need convert between little endian and big endian data.
The array module can be used to byteswap 16- and 32-bit samples, but it can't
help with 24-bit samples. Python implemented function for swapping bytes is not
very efficient.
Changes by Eric V. Smith e...@trueblade.com:
--
nosy: +eric.smith
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19640
___
___
Python-bugs-list
Serhiy Storchaka added the comment:
Updated patch addresses Eric's comment.
--
Added file: http://bugs.python.org/file32687/glob_escape_3.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8402
Richard Oudkerk added the comment:
I don't think the patch to the _test_multiprocessing will work. It defines
cls._Popen but I don't see how that would be used by cls.Pool to start the
processes.
I will have a think about a fix.
--
___
Python
Changes by Ezio Melotti ezio.melo...@gmail.com:
--
dependencies: +expose html.parser.unescape
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13633
___
Changes by Bernt Røskar Brenna bernt.bre...@gmail.com:
--
components: +IO
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19575
___
___
STINNER Victor added the comment:
Ok, this issue is the corner case of the PEP 446:
http://www.python.org/dev/peps/pep-0446/#only-inherit-some-handles-on-windows
The PEP explicitly does nothing for this case. It can change in the future.
Until the point is fixed, you have to use a lock around
Eric V. Smith added the comment:
Looks good to me.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8402
___
___
Python-bugs-list mailing list
Changes by Stefan Krah stefan-use...@bytereef.org:
--
nosy: +mark.dickinson
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19638
___
___
Roundup Robot added the comment:
New changeset 5fda36bff39d by Serhiy Storchaka in branch 'default':
Issue #8402: Added the escape() function to the glob module.
http://hg.python.org/cpython/rev/5fda36bff39d
--
nosy: +python-dev
___
Python tracker
Serhiy Storchaka added the comment:
Thank you Ezio and Eric for your reviews.
--
assignee: - serhiy.storchaka
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
Bernt Røskar Brenna added the comment:
I tested, and locking around the subprocess.Popen call indeed works on Python
3.4.
Thanks!
Do you have any tips on how to accomplish the same thing on Python 3.3 (locking
around Popen did not make any difference on 3.3)?
--
Stefan Krah added the comment:
The leaks still exist here.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13090
___
___
Python-bugs-list mailing
Bernt Røskar Brenna added the comment:
Never mind, I figured it:
On Python 3.3, the combination of locking around Popen and opening the file
that I redirect to using the code below works (code from scons):
def open_noinherit(*args, **kwargs):
fp = open(*args, **kwargs)
New submission from Ivan Radic:
Shutil supports deleting of files and directories but it offers no way to
delete directory content (without deleting directory itself). Shell programming
includes a lot of rm -rf /dir and rm -f /dir/*, and there is no direct
equivalent of these commands in
Changes by Serhiy Storchaka storch...@gmail.com:
--
nosy: +hynek, tarek
versions: -Python 2.7
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19642
___
Serhiy Storchaka added the comment:
Updated patch addresses some Victor's comments. Added optimization for trivial
case byteswap(bytes, 1).
--
Added file: http://bugs.python.org/file32688/audioop_byteswap_2.patch
___
Python tracker
New submission from Ivan Radic:
shutil.rmtree works nice on Windows until it hits file with read only attribute
set. Workaround is to provide a onerror parameter as a function that checks and
removes file attribute before attempting to delete it. Can option to delete
read_only files be
Kristján Valur Jónsson added the comment:
Attached is a version for 2.7
Btw, I think a cleaner way to deal with unpredictable GC runs is to be able to
temporarily disable GC with a context manager.
--
nosy: +kristjan.jonsson
Added file: http://bugs.python.org/file32689/issue7105.patch
Thomas Guettler added the comment:
For Python 2.x there is a backport of the subprocess module of 3.x:
https://pypi.python.org/pypi/subprocess32.
It has the timeout argument for call() and pipe.wait().
--
___
Python tracker rep...@bugs.python.org
Changes by Eric V. Smith e...@trueblade.com:
--
nosy: +eric.smith
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19638
___
___
Python-bugs-list
Bernt Røskar Brenna added the comment:
And here's a function that does not require pywin32:
def open_noinherit_ctypes(*args, **kwargs):
HANDLE_FLAG_INHERIT = 1
import msvcrt
from ctypes import windll, WinError
fp = open(*args, **kwargs)
if not
New submission from Dmitry:
I launch python3 on MacOS X Maverics and do the following things:
a = '12345'
a[:-0]
And the interpreter (application python3) crashes with sigfault. Everything is
OK with python2 on this computer (the same code returnes '') and with the same
version of Python on
Ezio Melotti added the comment:
This is a duplicate of #18458.
--
nosy: +ezio.melotti
resolution: - duplicate
stage: - committed/rejected
status: open - closed
superseder: - interactive interpreter crashes and test_readline fails on OS X
10.9 Mavericks due to libedit update
Martin Panter added the comment:
The ntpath.splitpath() version is easy to get lost in. It would probably help
if you spelt out all the single-letter variable names, and explained that
tri-state root/separator = None/True/False flag. Maybe there is a less
convoluted way to write it too, I
Benjamin Peterson added the comment:
I meant where you added casts, you could use it.
2013/11/18 STINNER Victor rep...@bugs.python.org:
STINNER Victor added the comment:
You could use the Py_SAFE_DOWNCAST macro everywhere.
I prefer to store sizes in a size type (Py_ssize_t), and only
Richard Oudkerk added the comment:
If the result of os.read() was stored in a Python daemon thread, the
memory should be released since the following changeset. Can someone
check if this issue still exist?
If a daemon thread is killed while it is blocking on os.read() then the bytes
STINNER Victor added the comment:
If a daemon thread is killed while it is blocking on os.read()
then the bytes object used as the read buffer will never be decrefed.
Ah yes, so another reason to ensure that daemon threads exit normally at Python
shutdown :-)
--
New submission from Gregory Salvan:
Actually unittest assertions depends on testcase class forcing us to extend it
to add assertions and to use it to make assertions outside tests.
Seeing interests in rethinking the way assertions are done in unittest, this
issue first intent to collect
R. David Murray added the comment:
See also issue 13229.
You can replicate 'rm -f' like this:
for p in glob.glob('/dir/*'):
os.remove(p)
That doesn't seem worth an extra function.
The annoying one to emulate is 'rm -rf /dir/*', because with the current shutil
tools you have to
R. David Murray added the comment:
You are essentially asking that we have an option to make the windows behavior
mirror the posix behavior? (A read only file in a writable directory can be
deleted in posix, since only the directory entry, not the file, is being
deleted.)
That makes some
Tim Golden added the comment:
This, unfortunately, is the classic edge-case where intra-platform consistency
and inter-platform consistency clash.
I (on Windows) would certainly be surprised if a tree delete removed read-only
files without my specifying some kind of override. I understand
Mark Dickinson added the comment:
I don't much like the use of Py_SSIZE_T and Py_SAFE_DOWNCAST here: the dtoa.c
code knows almost nothing about Python.h (aside from right at the top), and I'd
like to keep it that way if possible.
And in fact I'd say that we *shouldn't* be silencing these
Changes by Mark Dickinson dicki...@gmail.com:
--
assignee: - mark.dickinson
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19638
___
___
STINNER Victor added the comment:
I don't much like the use of Py_SSIZE_T and Py_SAFE_DOWNCAST here (...)
And in fact I'd say that we *shouldn't* be silencing these warnings; rather, we
should take them seriously.
So size_t should be used instead (s - s1 is unsigned, s = s1).
--
R. David Murray added the comment:
Well, it would *definitely* need to be a new explicit option whose default
value was the current behavior.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19643
STINNER Victor added the comment:
See also the meta-issue #9566: Compilation warnings under x64 Windows.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19638
___
R. David Murray added the comment:
You should probably start by summarizing the assertThat proposal from issue
18054, which suggested making a separate issue for assertThat.
--
nosy: +r.david.murray
title: Improving unittest assertions - decouple unittest assertions from the
TestCase
STINNER Victor added the comment:
the 5th line allocating the memory memory
oops, the 5th line allocating the *most* memory
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19640
___
Barry A. Warsaw added the comment:
I believe this has been fixed for a while.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9878
___
___
Brett Cannon added the comment:
I've actually started doing this in the PEP 451 repo and it's working out so
far. When that all lands I should have all the loaders ported but not the
finders. If you want, Zachary, you can make the chances in the PEP 451 repo so
you don't have to wonder what
Barry A. Warsaw added the comment:
I also can't reproduce this in Python 3.3 or 3.4 on Trusty Tahr (what will be
Ubuntu 14.04).
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19618
___
Changes by Jeremy Kloth jeremy.kloth+python-trac...@gmail.com:
--
nosy: +jkloth
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19638
___
___
Ivan Radic added the comment:
You are essentially asking that we have an option to make the windows behavior
mirror the posix behavior? (A read only file in a writable directory can be
deleted in posix, since only the directory entry, not the file, is being
deleted.)
Actually, your
Serhiy Storchaka added the comment:
Added examples and Martin's notes to the documentation. ntpath implementation
rewrote with regular expressions (it is now shorter and perhaps more clear).
--
Added file: http://bugs.python.org/file32691/ospath_splitpath_2.patch
Xavier de Gaye added the comment:
A description of what goes wrong when stepping out of the generator
would be helpful.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16596
___
Roundup Robot added the comment:
New changeset 8f770cdb7a19 by Victor Stinner in branch 'default':
Issue #19437: Fix error handling of CDataType_from_buffer()
http://hg.python.org/cpython/rev/8f770cdb7a19
New changeset 556bdd8d0dde by Victor Stinner in branch 'default':
Issue #19437: Fix error
Guido van Rossum added the comment:
Basically the debugger lost control and the program ran to completion after I
hit 'n' that returned from the coroutine.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16596
Zachary Ware added the comment:
I like the idea of a remove_readonly flag. I was going to say that I'm a bit
worried about the fact that shutil.rmtree already has a couple of keyword
arguments, but it's nowhere near what, say, copytree has. Call me +0.75.
--
R. David Murray added the comment:
That's not a good name for the flag. The problem is that 'read-only' means
different things on Windows than it does on Unix. Which is why I suggested
that the flag control whether or not it acts posix like on Windows. So
perhaps 'posix_compat'? That
Tim Golden added the comment:
TBH I'm still fairly -0 and edging towards -0.5. If we didn't already
have two keyword args I might be convinced towards a jfdi=True flag.
But, as the OP described, the current params already allow for a
workaround of sorts and another param of the semantics
Zachary Ware added the comment:
I make no claims of being good at naming things :)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19643
___
___
Serhiy Storchaka added the comment:
Since splitlist() works with Tcl_Obj-s, proposed test should pass.
klappnase, could you please sign a Contributor Licensing Agreement?
http://www.python.org/psf/contrib/contrib-form/
What is your real name? What should I add in the Misc/ACKS file?
Antoine Pitrou added the comment:
Btw, I think a cleaner way to deal with unpredictable GC runs is to be able
to temporarily disable GC with a context manager
Disabling the GC in a library function sounds very ugly to me.
--
___
Python tracker
Roundup Robot added the comment:
New changeset 093b9838a41c by Victor Stinner in branch 'default':
Issue #19581: Change the overallocation factor of _PyUnicodeWriter on Windows
http://hg.python.org/cpython/rev/093b9838a41c
--
nosy: +python-dev
___
Roundup Robot added the comment:
New changeset fc7ceb001eec by Victor Stinner in branch 'default':
Issue #19513: repr(list) now uses the PyUnicodeWriter API, it is faster than
http://hg.python.org/cpython/rev/fc7ceb001eec
--
nosy: +python-dev
___
Changes by STINNER Victor victor.stin...@gmail.com:
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19581
___
STINNER Victor added the comment:
I checked in list_repr_writer-2.patch, thanks Serhiy for your review.
And now the patch for repr(tuple).
Result of bench_tuple_repr.py:
Common platform:
CFLAGS: -Wno-unused-result -Werror=declaration-after-statement -DNDEBUG -g
-fwrapv -O3 -Wall
Changes by STINNER Victor victor.stin...@gmail.com:
Added file: http://bugs.python.org/file32693/bench_tuple_repr.py
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19513
___
New submission from STINNER Victor:
Attached patch modify dict_repr() function to use the _PyUnicodeWriter API
instead of building a list of short strings with PyUnicode_AppendAndDel() and
calling PyUnicode_Join() at the end to join the list. PyUnicode_Append() is
inefficient because it has
Changes by STINNER Victor victor.stin...@gmail.com:
Added file: http://bugs.python.org/file32695/bench_dict_repr.py
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19646
___
Roundup Robot added the comment:
New changeset ead9043f69df by Victor Stinner in branch 'default':
Issue #19513: Simplify list_repr()
http://hg.python.org/cpython/rev/ead9043f69df
--
___
Python tracker rep...@bugs.python.org
STINNER Victor added the comment:
Ok, here is a new version hyper optimized for the final ,) string :-)
--
Added file: http://bugs.python.org/file32696/tuple_repr_writer-2.patch
___
Python tracker rep...@bugs.python.org
New submission from Stefan Holek:
This test passed in Python = 3.3 but fails in 3.4:
def testTestSuiteConsumesTest(self):
class MyTestCase(unittest.TestCase):
def testMethod(self):
pass
test = MyTestCase('testMethod')
suite =
Changes by Antoine Pitrou pit...@free.fr:
--
nosy: +michael.foord
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19647
___
___
Python-bugs-list
Serhiy Storchaka added the comment:
Old version looks better to me (it is simpler and performance of writing final
,) is not worth additional complication).
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19513
Zachary Ware added the comment:
Alright, I'll try to do that later this evening.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19596
___
___
Eric Snow added the comment:
I left a review relative to the use of the _path attribute (which shouldn't be
used).
--
nosy: +eric.snow
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17457
Nick Coghlan added the comment:
Just a heads up - since the two of you appear to have this well in hand,
don't wait for a review from me before committing it. I have plenty of
other things to look at before the beta deadline :)
--
___
Python tracker
1 - 100 of 118 matches
Mail list logo
