New submission from Georg Brandl:
What do you think about this patch?
--
assignee: zach.ware
components: Documentation
files: about.diff
keywords: patch
messages: 208081
nosy: georg.brandl, zach.ware
priority: normal
severity: normal
status: open
title: Doc/about: update a bit
Added
Georg Brandl added the comment:
5735 seems to be correct (see docstring of is_unspecified), although it doesn't
talk about unspecified.
--
nosy: +georg.brandl
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20241
New submission from Serhiy Storchaka:
For unsigned_int, unsigned_long and size_t return converters Argument Clinic
generates a code which compares unsigned integer return_value with signed -1.
--
components: Demos and Tools
messages: 208083
nosy: larry, serhiy.storchaka
priority:
Serhiy Storchaka added the comment:
Patch updated to tip (a little different generated code for Py_buffer).
I don't want to use return converters here because I want to add support for
float32 and float64 in 3.5.
--
___
Python tracker
Changes by Serhiy Storchaka storch...@gmail.com:
Added file: http://bugs.python.org/file33461/audioop_clinic.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20133
___
Serhiy Storchaka added the comment:
Thank you Armin for your report.
--
components: +Library (Lib)
resolution: - fixed
stage: test needed - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
Serhiy Storchaka added the comment:
I'll try, but I'm not sure this is possible. Some used C functions (e.g.
fgets()) returns char* and doesn't work with string containing null bytes. Some
public API (e.g. PyParser_SimpleParseString()) work with null-terminated C
strings.
--
Serhiy Storchaka added the comment:
See also issue13617.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20115
___
___
Python-bugs-list mailing
Changes by Serhiy Storchaka storch...@gmail.com:
--
components: +Interpreter Core
stage: - patch review
type: - enhancement
versions: +Python 3.5 -Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18373
New submission from Vajrasky Kok:
Enable SELinux (by default it is already enabled). Then load tipc module.
# modprobe tipc
Then using whatever account, execute Lib/test/test_socket.py. You'll get:
FAILED (errors=1, skipped=4)
Traceback (most recent call last):
File Lib/test/test_socket.py,
New submission from Ned Deily:
With the updates to the Sphinx toolchain for 3.3 (05e84d3ecd1e) and 3.4
(90cd87f64632), the documentation build for the OS X installer now fails with:
Error: The markupsafe module cannot be found. Did you install Sphinx and its
dependencies correctly?
It
Changes by Mark Dickinson dicki...@gmail.com:
--
nosy: +mark.dickinson, tim.peters
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20247
___
___
Georg Brandl added the comment:
That's unfortunate, thanks for catching that. Of course I had markupsafe
installed for my system Python.
One more reason to switch to virtualenv at some point.
I think we can go back to the old Jinja version -- there haven't been bugs to
my knowledge and
Roundup Robot added the comment:
New changeset 92fe1cd256f1 by Georg Brandl in branch '3.3':
Closes #20258: Sphinx toolchain: move back to Jinja2 2.3.1 with support for
Py2.5.
http://hg.python.org/cpython/rev/92fe1cd256f1
--
nosy: +python-dev
resolution: - fixed
stage: needs patch -
Laurent De Buyst added the comment:
Sorry Michael, I should have read your second comment more closely since you
already pointed out that using a list as default argument is bad.
It is, however, easily fixed by changing to this:
def reset_mock(self, visited=None):
Restore the mock object
Nicola Palumbo added the comment:
I should have read more carefully, too! Thanks to both.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18622
___
R. David Murray added the comment:
It seems fine to me, if docs@ is no longer the best place to start. It might be
better if the tracker link read documentation bugs on the bug tracker. Also,
you could link to the devguide as well as core-mentorship.
--
nosy: +r.david.murray
Laurent De Buyst added the comment:
And here's an actual patch with the corrected code
--
Added file: http://bugs.python.org/file33463/issue18622_2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18622
Changes by Sebastian Rodriguez srodrig...@gmail.com:
--
nosy: +srodriguez
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17140
___
___
Daniel Holth added the comment:
Just mitigating the bug that -bb is not the default...
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18373
___
Roundup Robot added the comment:
New changeset 4f8ad9a4193f by Zachary Ware in branch '3.3':
Issue #20253: Fixed a typo in the ipaddress docs that advertised an
http://hg.python.org/cpython/rev/4f8ad9a4193f
New changeset 2f54b55fcbfa by Zachary Ware in branch 'default':
Closes #20253: Merge
Zachary Ware added the comment:
Thanks for the report!
--
assignee: docs@python - zach.ware
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20253
___
Ethan Furman added the comment:
Depracation warning is in place for 3.4.
When 3.5 is tagged I'll switch it an error.
--
stage: patch review - commit review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19995
New submission from Shelby Spencer:
The problem occurs when you attempt to perform an os.listdir on a directory
that you don't have access to. You should get an exception thrown. Normally
this occurs, however, if you run the following code:
folder = some parent folder that has a child
R. David Murray added the comment:
That's not how Python works. If you print out currentDir, you will see that
os.listdir is never called on the folder for which you do not have permission.
That is, os.walk does indeed catch the listdir error, when *it* does the
listdir, does not try to
New submission from Serhiy Storchaka:
Proposed patch adds support for non-bitwise unsigned integer arguments in
Argument Clinic. I.e. now unsigned_int(bitwise=False) (or just unsigned_int)
converts Python int in range from 0 to UINT_MAX to C unsigned int. Added
support for unsigned_short,
Larry Hastings added the comment:
Very nice! I had an idea to do this in the back of my head too. But my plate
is already full.
I haven't reviewed the patch yet--and I have a huge backlog of reviews already.
But I can give this higher priority if you need it for other patches. When do
Fran Bull added the comment:
I think the sentence either means:
1) The courses of action that defusedxml implements are those recommended for
any server code that parses untrusted XML data.
or
2) Using defused XML is recommended for any server code that parses untrusted
XML data.
And I
Georg Brandl added the comment:
Both your and Berker's (on rietveld) comments sound good.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20255
___
R. David Murray added the comment:
Actually, I think it means that the defusedxml documentation tells you what to
do to protect yourself from various attack vectors, which pretty much amounts
to importing certain functions from defusedxml and using them instead of the
stdlib versions. Your
Serhiy Storchaka added the comment:
Currently these converters are used only in zlib (unsigned int) and select
(unsigned short). But perhaps during conversion to Argument Clinic we will
discover that they are more appropriate than bitwise converters in other
places. So there is no hurry.
New submission from Barry A. Warsaw:
I've been debugging a crash in nose 1.3.0, the root cause of which turned out
to be an instance containing an attribute which itself was an instance of the
following class (boiled down):
class Picky:
def __getstate__(self):
return {}
def
Barry A. Warsaw added the comment:
Hmm, actually, this is a regression in Python 3.4. Let's amend the test class
to include a __getnewargs__():
class Picky(object):
Options container that returns None for all options.
def __getstate__(self):
return {}
def
Changes by Jakub Wilk jw...@jwilk.net:
--
nosy: +jwilk
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1652
___
___
Python-bugs-list mailing list
Zachary Ware added the comment:
Looks good to me, with Berker and David's comments addressed. Here's an
alternate approach I came up with, since about.rst already links to bugs.rst,
which already contains most of what I think we want to get across here. I'm
good with either route, really.
Larry Hastings added the comment:
Dang it, I forgot to add the second patch. Here it is.
--
Added file:
http://bugs.python.org/file33467/larry.support.text_signature.on.more.types.diff.2.txt
___
Python tracker rep...@bugs.python.org
New submission from Serhiy Storchaka:
When ZipFile.debug is not zero, some debugging messages are printed to stdout.
Some of them are for debugging the zipfile module itself. But some are warnings
about user's operation which perhaps make not what the user is expected --
truncating long
Georg Brandl added the comment:
Very nice. Go ahead and commit your version!
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20255
___
___
Serhiy Storchaka added the comment:
Giampaolo, do you want to provide a test?
--
stage: - test needed
type: - behavior
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18695
___
Serhiy Storchaka added the comment:
If no one complain I'll commit last patch tomorrow.
--
assignee: - serhiy.storchaka
stage: - patch review
type: - behavior
versions: +Python 3.4 -Python 3.2
___
Python tracker rep...@bugs.python.org
Serhiy Storchaka added the comment:
locale.normalize() was fixed in issue5815 (and new entry for
'sr_RS.UTF-8@latin' is not needed anymore). Devanagari entries were fixed in
issue20027. In any case thank you Mike for your report and proposed patch.
--
resolution: - duplicate
stage:
Roundup Robot added the comment:
New changeset 74d138cfe564 by Zachary Ware in branch '2.7':
Issue #20255: Update the about and bugs pages.
http://hg.python.org/cpython/rev/74d138cfe564
New changeset 956b8afdaa3e by Zachary Ware in branch '3.3':
Issue #20255: Update the about and bugs pages.
Zachary Ware added the comment:
Done, thanks Georg!
--
resolution: - fixed
stage: - committed/rejected
status: open - closed
type: - enhancement
versions: +Python 2.7, Python 3.3, Python 3.4
___
Python tracker rep...@bugs.python.org
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com:
--
nosy: +Arfrever
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20261
___
Roundup Robot added the comment:
New changeset f35b3a86ade3 by Meador Inge in branch 'default':
Fix minor bug in dict.__contains__ docstring.
http://hg.python.org/cpython/rev/f35b3a86ade3
--
___
Python tracker rep...@bugs.python.org
Larry Hastings added the comment:
Meador Inge: In the future, please create new issues for these sorts of fixes.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16612
___
Meador Inge added the comment:
Will do, but in this case I didn't think a one character diff was worth
it.
--
nosy: +meador.inge
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16612
___
Larry Hastings added the comment:
If it's not worth a new issue, then you can check it in without citing an issue
at all.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16612
___
Changes by Serhiy Storchaka storch...@gmail.com:
--
nosy: +alexandre.vassalotti, pitrou
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20261
___
Larry Hastings added the comment:
Updated the patch. (Diff #2 apparently didn't apply cleanly, so we didn't get
a review link.)
Old-guard core devs: I'm *really* desperate for a review of this patch. You
don't have to review everything thing, just these files:
* Include/object.h
*
Larry Hastings added the comment:
Antoine Pitrou took care of cryptmodule.c.
--
title: Derby #17: Convert 50 sites to Argument Clinic across 14 files - Derby
#17: Convert 49 sites to Argument Clinic across 13 files
___
Python tracker
Changes by Antoine Pitrou pit...@free.fr:
--
nosy: +neologix
versions: +Python 2.7, Python 3.3, Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20247
___
New submission from Ozy:
Not sure if this is a bug. We're experiencing it in v3.3.2 and was discovered
by accident.
It seems to be possible to define python functions (like print or input) as
variables, as if they're not reserved. If you do that, the command
functionality is lost until
R. David Murray added the comment:
Yes, that's the way Python works. In Python3, print became a function and is
no longer a keyword, so yes, it can be shadowed in the local namespace just
like any other Python function.
--
nosy: +r.david.murray
resolution: - invalid
stage: -
Ezio Melotti added the comment:
FTR you can always get it back from builtins.print:
print('test')
test
print = 10
print('test')
Traceback (most recent call last):
File stdin, line 1, in module
TypeError: 'int' object is not callable
import builtins
print = builtins.print
print('test')
Ozy added the comment:
Great, thanks. Didn't know that.
All the best.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20263
___
___
Arfrever Frehtes Taifersar Arahesis added the comment:
When LC_ALL is already set in environment, LC_MESSAGES will not override it.
I suggest to restore LC_ALL=C in place of LC_MESSAGES=C.
--
___
Python tracker rep...@bugs.python.org
Meador Inge added the comment:
Attached is a first cut for sqlite3. It is generally OK, but I have the
following
nits:
* As is probably expected, __init__ and __call__ procs can't be converted.
* sqlite3.Connection.{execute, executemany, executescript} don't use
PyArg_Parse*.
Tim Peters added the comment:
They certainly should _not_ be swapped, as explained clearly in the message
following the one you referenced. For the first half:
if self._lock.acquire(0):
succeeds if and only if the lock is not held by _any_ thread at the time. In
that case, the lock
New submission from Meador Inge:
It has been noted a few times that someone might forget to re-run
clinic.py after updating the argument clinic comments. The attached
patch adds a new check to patchcheck.py to note when files containing
argument clinic comments have been changed. You could
Zachary Ware added the comment:
This could be taken a step further, following the lead of the whitespace fixing
checks and just run clinic on files that need it.
--
nosy: +zach.ware
___
Python tracker rep...@bugs.python.org
Ryan Smith-Roberts added the comment:
Here's the socketmodule patch. I aggressively imported text from the docs for
the docstrings, along with matching parameter names, given how far the old
docstrings have drifted over time. The Windows-specific code is untested, but
otherwise the tests
Larry Hastings added the comment:
The attached patch extends Argument Clinic and the inspect module: now you may
use simple (!) expressions as default values. So for example sys.maxsize - 1
should now work fine.
* Names may be in the current module; as a backup they will also be looked up
New submission from Zachary Ware:
Doc/using/windows still mentions DOS, Windows 3.x, and Python 2.1, and that's
just in the first short section. This is a catch-all issue for making sure
that page is up to date.
--
assignee: docs@python
components: Documentation, Windows
keywords:
Meador Inge added the comment:
LGTM.
I audited the other 'ZipFile.debug' uses and agree that the others are
mainly useful in debugging the zipfile implementation itself.
Since it isn't that critical of a change, the default branch should be
sufficient.
--
nosy: +meador.inge
type: -
New submission from Zachary Ware:
The Python on Windows faq could use some TLC. For instance, cx_Freeze should
be mentioned in the faq about creating an executable (and py2exe should either
mention that it doesn't quite support 3.x yet, or just be removed until it
does), and the embedding
Meador Inge added the comment:
Larry, nice. I am verified that your latest patch fixes my third sqlite3
nit from issue20178.
--
nosy: +meador.inge
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20226
Vajrasky Kok added the comment:
Here is the patch for Modules/resource.c.
However, I can not convert this method signature:
if (!PyArg_ParseTuple(args, _Py_PARSE_PID i|(OO):prlimit,
pid, resource, curobj, maxobj))
_Py_PARSE_PID can be 'i' or 'l' or 'L'.
--
Changes by Vajrasky Kok sky@speaklikeaking.com:
Removed file: http://bugs.python.org/file33474/clinic_codecsmodule.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20185
___
Changes by Vajrasky Kok sky@speaklikeaking.com:
Added file: http://bugs.python.org/file33475/clinic_resource.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20185
___
New submission from Antony Lee:
Essentially, the following fails:
t = tempfile.TemporaryDirectory(dir=.)
os.chdir(some_other_dir)
t.cleanup()
because t.name is a relative path. Resolving the dir argument when the
directory is created should(?) fix the issue.
--
components: Library
Eric Snow added the comment:
This is a duplicate of #16251, no? Pickle looks up dunder ;) methods on
instances rather than on classes, so __getattr__() gets triggered unexpectedly.
I had to work around this in some code of mine by special-casing in
__getattr__() names that start with '_'.
New submission from Larry Hastings:
It was a quick hack: Clinic now has a syntax for cloning an existing
function! The first line of the function block should be
module.class.new_function [as c_basename] = module.class.existing_fn
Hurry up and give me a LGTM so you can use it everywhere!
Georg Brandl added the comment:
Functionality looks good. Implementation I can't say.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20268
___
Larry Hastings added the comment:
Shall I just check it in and fix it if it breaks?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20268
___
___
Georg Brandl added the comment:
Sure!
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20268
___
___
Python-bugs-list mailing list
Unsubscribe:
Roundup Robot added the comment:
New changeset 565773aabafb by Larry Hastings in branch 'default':
Issue #20268: Argument Clinic now supports cloning the parameters
http://hg.python.org/cpython/rev/565773aabafb
--
nosy: +python-dev
___
Python tracker
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com:
--
nosy: +Arfrever
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16251
___
Larry Hastings added the comment:
Begun, the clone war has.
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20268
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com:
--
nosy: +Arfrever
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18695
___
Larry Hastings added the comment:
Zachary: If you refresh your copy of trunk, you can now clone functions. See
the howto for the syntax.
The failure you were seeing was in some code that I just rewrote (see #20226).
I'd be interested if you could apply that patch and try your code again.
Vajrasky Kok added the comment:
Here is the patch for Modules/gcmodule.c.
--
Added file: http://bugs.python.org/file33477/clinic_gc.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20185
82 matches
Mail list logo
