Ent added the comment:
@demian: That's a tall order! :)
I would love to use HTTPStatus but for some reason http/__init__.py is devoid
of code related to it -
https://hg.python.org/cpython/file/31982d70a52a/Lib/http/__init__.py
I wasn't sure why this change was made because it like feels a
Marat Mavlyutov added the comment:
HI!
need that thingie too, did you poke the author?
cant find issue tracker at code.google.com
--
nosy: +Marat.Mavlyutov
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23223
Senthil Kumaran added the comment:
Addressed Berker's review comments.
1) Made the TestServer a Mixin. (Thanks, that's the correct to do).
2) Changed Post to Port.
3) I went with still using a testdomain and port in the constructor. My idea of
the test is to demonstrate that the
Berker Peksag added the comment:
I would love to use HTTPStatus but for some reason http/__init__.py is devoid
of code related to it -
https://hg.python.org/cpython/file/31982d70a52a/Lib/http/__init__.py
See the default branch:
Steve Dower added the comment:
Yeah, that's the sole buildbot currently running VS 2015. I'm expecting to have
more after VS 2015 RC is released, since that will be basically finished.
Until then, I'm also regularly building with the latest internal versions and
tracking issues, but nothing
Demian Brecht added the comment:
Thanks for the work! I'm not sure why the last patch doesn't appear on
Rietveld, so (unfortunately) here's the result of my review. I've only covered
functional aspects in this run at it:
+base_files = ['index.html', 'index.htm']
Can you use index_files?
Martin v. Löwis added the comment:
Ubik: this issue is closed, as we believe that it does not exist anymore. If
you still think there is a bug surrounding mkdtemp, please make a new full bug
report. Structure your report as follows:
1. this is what you did
2. this is what happened
3. this is
Ent added the comment:
@demian: If you don't mind, could you please elaborate a bit more on
`_resolve_path()` you mentioned in the review/comment? Or maybe link me to the
type of behaviour you mentioned? I will accordingly make the changes. As for
self.apply_headers, I will see if I can make
Berker Peksag added the comment:
LGTM.
--
stage: patch review - commit review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23300
___
___
Roundup Robot added the comment:
New changeset 2bc3e839a3a3 by Vinay Sajip in branch '3.4':
Issue #23207: logging.basicConfig() now does additional validation of its
arguments.
https://hg.python.org/cpython/rev/2bc3e839a3a3
New changeset 06ba5e776a6e by Vinay Sajip in branch 'default':
Closes
Juha Lemmetti added the comment:
What You point out is true. However, I saw a bug in code where
RotatingFileHandler was used, and I had to check the operation using a small
test program.
For maxBytes, it is explicitly stated that when the value is 0, rollover never
occurs. It wouldn't hurt
Benjamin Peterson added the comment:
On Fri, Jan 23, 2015, at 15:36, Antoine Pitrou wrote:
Antoine Pitrou added the comment:
Well, sure, but that means you plan to make it available in 3.4.3? Why is
that?
No, I'll apply it to 3.5.
--
___
Demian Brecht added the comment:
@demian: If you don't mind, could you please elaborate a bit more on
`_resolve_path()` you mentioned in the review/comment?
Sure. In your patch, you have redirect_browser (or redirect if you
renamed it), which sounds like it's allowing for a very generic
Antoine Pitrou added the comment:
Why is that 3.4.3?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20188
___
___
Python-bugs-list mailing list
Benjamin Peterson added the comment:
Here you are.
--
keywords: +patch
nosy: +benjamin.peterson
stage: needs patch - patch review
Added file: http://bugs.python.org/file37829/alpn.patch
___
Python tracker rep...@bugs.python.org
Benjamin Peterson added the comment:
Here's the fixed 3.5 patch.
--
Added file: http://bugs.python.org/file37830/alpn.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20188
___
Antoine Pitrou added the comment:
Well, sure, but that means you plan to make it available in 3.4.3? Why is that?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20188
___
Vinay Sajip added the comment:
The behaviour was changed in 3.4 in response to #15776, but the documentation
wasn't updated to match. I will update the docs to remove the reference to the
error.
--
___
Python tracker rep...@bugs.python.org
Vinay Sajip added the comment:
The default parameters for backupCount and maxBytes are both shown as 0.
The first paragraph ends with By default, the file grows indefinitely.
The second paragraph says, If backupCount is non-zero, the system will save
old log files by appending the extensions
Gregory P. Smith added the comment:
I can apply this to subprocess32 but it is going to look much more like:
+#ifndef MS_WINDOWS /* WTF is anyone compiling on Windows? Shouldn't work! */
+# define HAVE_UNISTD_H 1
+#endif
+#ifdef HAVE_UNISTD_H
#include unistd.h
+#endif
The real question is
Benjamin Peterson added the comment:
On Fri, Jan 23, 2015, at 15:33, Antoine Pitrou wrote:
Antoine Pitrou added the comment:
Why is that 3.4.3?
I wrote the patch on the 3.4 branch.
--
___
Python tracker rep...@bugs.python.org
Roundup Robot added the comment:
New changeset a3a44d871d70 by Vinay Sajip in branch 'default':
Closes #23202: pyvenv documentation updated to match its behavior.
https://hg.python.org/cpython/rev/a3a44d871d70
--
nosy: +python-dev
resolution: - fixed
stage: - resolved
status: open -
Changes by Gregory P. Smith g...@krypto.org:
--
assignee: - gregory.p.smith
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23223
___
___
Changes by Gregory P. Smith g...@krypto.org:
--
assignee: gregory.p.smith -
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1060
___
___
Benjamin Peterson added the comment:
update after review comments
--
Added file: http://bugs.python.org/file37831/alpn.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20188
___
Roundup Robot added the comment:
New changeset be9fe0c66075 by Benjamin Peterson in branch 'default':
add support for ALPN (closes #20188)
https://hg.python.org/cpython/rev/be9fe0c66075
New changeset 7ce67d3f0908 by Benjamin Peterson in branch '2.7':
pep 466 backport of alpn (#20188)
Roundup Robot added the comment:
New changeset 0375eb71d75e by Vinay Sajip in branch '2.7':
Issue #23305: clarified RotatingFileHandler documentation.
https://hg.python.org/cpython/rev/0375eb71d75e
New changeset 93888975606b by Vinay Sajip in branch '3.4':
Issue #23305: clarified
Changes by Antoine Pitrou pit...@free.fr:
--
assignee: - benjamin.peterson
stage: patch review - commit review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20188
___
Serhiy Storchaka added the comment:
Good point Josh. Yes, it may slow down other cases, and there is a difference
between sets and dicts.
1. If the key is not contained in the set, then if the first tested entry
table[hash mask] is empty, then the lookup is slowed down by one pointer
STINNER Victor added the comment:
Oh, I didn't know this issue. FYI I modified the subprocess module to use new
specialized OSError exceptions: issue #23234 (changeset 0c5ae257966f).
--
nosy: +haypo
___
Python tracker rep...@bugs.python.org
Gregory P. Smith added the comment:
This bug prevents zipfile's writestr() from writing large data (longer than
UINT_MAX) to a 64-bit zip file.
The zlib.crc32 function which, as written, cannot accept input with a size
larger than an unsigned int.
Ethan Furman added the comment:
Currently the way to add an Enum's members to a module's namespace is:
globals().update(MyEnumeration.__members__)
but that seems quite ugly. Is there anywhere else that the user is required to
use __xxx__ methods for common functionality?
I think a new
Roundup Robot added the comment:
New changeset 8d802fb6ae32 by Ethan Furman in branch 'default':
Issue20284: Implement PEP461
https://hg.python.org/cpython/rev/8d802fb6ae32
--
nosy: +python-dev
___
Python tracker rep...@bugs.python.org
Danny Yoo added the comment:
Unfortunately, fixing just zlib.crc32 isn't quite enough for our purposes. We
still will see OverflowErrow in zipfile if compression is selected.
Demonstration code:
import zipfile
## Possible workaround:
New submission from Danny Yoo:
Reproduction steps:
---
$ python2.7 -c import zlib;zlib.crc32('a'*(131))
Traceback (most recent call last):
File string, line 1, in module
OverflowError: size does not fit in an int
---
We ran into this bug in zlib.crc32 when using zipfile.writestr() with a
Changes by Danny Yoo danny...@google.com:
--
title: zlib.crc32 raises OverflowError at argument-parsing time on large
strings - Within zipfile, use of zlib.crc32 raises OverflowError at
argument-parsing time on large strings
___
Python tracker
Josh Rosenberg added the comment:
Does it slow down other cases? Seems to me like dictionaries would have more
existing key lookups than sets to justify the optimization, since they're
used for attribute lookup and the like, and because you usually want the value
associated with existing
Jim Bridgewater added the comment:
Turns out an outer product of two million element vectors takes up a lot of
memory. Go figure.
--
resolution: - not a bug
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23307
Georg Brandl added the comment:
Well, for such operations (namespace manipulation) __dict__ is also often used,
so I wouldn't say it's too ugly.
--
nosy: +georg.brandl
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23292
New submission from Jim Bridgewater:
python hangs when this script is run and if it is allowed to continue running
OS X produces system out of memory errors
--
files: dome_projection.py
messages: 234593
nosy: jwbwater
priority: normal
severity: normal
status: open
title: python hangs
New submission from David Motlagh:
Hi,
I either found a bug or am doing the steps wrong. Could you please check the
instructions in Section 4.1 to determine if there really is a syntax error?
Thanks,David Motlagh
--
messages: 234596
nosy: Dmot
priority: normal
severity: normal
Michiel de Hoon added the comment:
I am attaching a patch for this bug for Python 2.7.
--
keywords: +patch
nosy: +mdehoon
Added file: http://bugs.python.org/file37832/issue23237.patch
___
Python tracker rep...@bugs.python.org
STINNER Victor added the comment:
The module has been deleted in Python 3.
The compilation of the module was probably disabled on 64-bit because of bugs.
I don't see any bugfix in your patch.
changeset: 6448:b854ca4605e1
branch: legacy-trunk
user:Guido van Rossum
Berker Peksag added the comment:
+class TestServer(TestCase):
This can be a mixin.
+def testHTTPWithConnectHostPost(self):
Post - Port?
+self.conn = httplib.HTTP(host=constructor_host, port=constructor_port)
or to make the test simpler,
self.conn = httplib.HTTP()
Claudiu Popa added the comment:
Thanks, Victor. I thought the same thing, but the file is deleted here already,
here:
https://hg.python.org/cpython/file/981ba93bcbde/Lib/test/test_dbm_dumb.py#l228
--
___
Python tracker rep...@bugs.python.org
Senthil Kumaran added the comment:
Here is the patch to fix this. I have added a test case covering this change.
Please review this and if it is good to go, I will commit it. Thank you.
--
keywords: +patch
stage: needs patch - patch review
Added file:
STINNER Victor added the comment:
+with open(_fname + .dir, 'w') as stream:
+stream.write(content)
I don't see where the created file is deleted. Add something like:
self.addCleanup(support.unlink, _fname + .dir)
--
nosy: +haypo
Changes by Piotr Dobrogost p...@bugs.python.dobrogost.net:
--
nosy: +piotr.dobrogost
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22889
___
___
New submission from Juha Lemmetti:
If RotatingFileHandler is initialized with backupCount 0, the file does not
rotate but grows indefinitely. This is not self-evident from the documentation.
Suggestion: either rotate (discard) the log if backupCount==0 or mention the
current operation the
Changes by Florian Berger fber...@florian-berger.de:
--
nosy: +fberger
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21417
___
___
Changes by Serhiy Storchaka storch...@gmail.com:
--
dependencies: +refactor subprocess: use new OSError exceptions, factorize
stdin.write() code
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16648
Alessio added the comment:
Is anybody working with this case?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11024
___
___
Python-bugs-list
R. David Murray added the comment:
I'm not sure why this issue is still open. It looks like Alexander committed
the fix.
If you are seeing a problem, I think that would be a new bug, and you should
open a new issue giving details on how to reproduce the problem you are seeing.
--
Changes by R. David Murray rdmur...@bitdance.com:
--
versions: +Python 3.5 -Python 3.3
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23305
___
___
Ubik added the comment:
As detailed in this SO question:
http://stackoverflow.com/questions/28101187/deal-with-unicode-usernames-in-python-mkdtemp
I still see the issue in 2.7.8.
I use a unicode prefix and changing this is not an option (editing legacy code
which expects unicode everywhere)
Demian Brecht added the comment:
Other than Berker's comments, LGTM.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23300
___
___
STINNER Victor added the comment:
The best fix is to use Python 3. In 2015, it's maybe time to use Python 3 which
has a very good Unicode support.
--
nosy: +haypo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1681974
Amaury Forgeot d'Arc added the comment:
This change will cause the module to be imported twice:
progname = runpy.run_module(args[0])['__file__']
... and then the runctx() call.
What about something like:
code = runpy.run_module(modname, run_name='__main__')
globs = { 'runpy': runpy,
Roundup Robot added the comment:
New changeset 42971b769c0b by Benjamin Peterson in branch 'default':
http.client: disable Nagle's algorithm (closes #23302)
https://hg.python.org/cpython/rev/42971b769c0b
--
nosy: +python-dev
resolution: - fixed
stage: - resolved
status: open - closed
59 matches
Mail list logo
