New submission from Thomas Kluyver:
I'm pretty sure the distutils docs for Python 3.4 don't need to describe how to
make packages compatible with Python 2.2.3.
I know that these docs are deprecated in favour of the Python packaging guide,
but I still look at them at times, and this is
Berker Peksag added the comment:
I also removed it in my patch for issue 19610.
--
nosy: +berker.peksag
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23682
___
Martin Panter added the comment:
Posting LZMAFile-etc.v5.patch with the following changes:
* Merged with current code
* Changed BZ2File(buffer_size=...) to a keyword-only parameter and restored
previous unused “buffering” parameter. Also changed the LZMAFile parameter to
keyword-only for
Demian Brecht added the comment:
urlsplit(evil.com).netloc
''
urlsplit(evil.com).has_netloc
True
urlunsplit(urlsplit(evil.com)) # Adds “//” back
'evil.com'
RFC 3986, section 3.3:
If a URI contains an authority component, then the path component
must either be empty
R. David Murray added the comment:
No program that I work with (and I use cli all the time) outputs a tab when I
press the tab key. Now, true, I think I had to configure vi so that that was
the case, but nothing else that I remember. Of course, most of those programs
use readline and come
Thomas Kluyver added the comment:
Anything else I should be doing here?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11726
___
___
Shakeel Mohamed added the comment:
Hi, any plans to do this? If not, we can close it.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23542
___
Martin Panter added the comment:
The patch seems sensible. The only behaviour change I can forsee would be the
odd case of http:1234 no longer being parsed like this:
urlsplit(http:1234)
SplitResult(scheme='http', netloc='', path='1234', query='', fragment='')
Instead it would be parsed the
Martin Panter added the comment:
Regarding unparsing of evil.com, see Issue 23505, where the invalid
behaviour is pointed out as a security issue. This was one of the bugs that
motivated me to make this patch. I cannot imagine some existing code (other
than an exploit) that would be
New submission from Robert Collins:
I was timing some cold-cache operations today and had to not use timeit because
I wanted to run some code between statement (flushing caches) that shouldn't be
timed as part of statement. It would be nice, similarly to -s, to be able to
say -i 'something
New submission from Martin Panter:
The documentation for urlsplit() says:
'''
urlparse(urlstring, scheme='', allow_fragments=True)
. . .
If the scheme argument is specified, it gives the default addressing scheme, to
be used only if the URL does not specify one. The default value for this
Martin Panter added the comment:
Thanks for reviewing, Serhiy. I am posting a new patch addressing the comments:
* Removed underscore from method name
* Made separate MockSslTests subclass, using a hacked ssl_context parameter to
bypass the SSL module
* Separated asserts for closed socket and
Samuel Bronson added the comment:
Um ... any progress on reviewing this?
--
nosy: +SamB
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11410
___
Martin Sekera added the comment:
Copy that. Would the patch be acceptable if the '\t' was simply changed to 4
spaces?
To discuss further, it is my opinion that the interpreter should output a \t
character when the TAB key is pressed, as this is the behavior of nearly every
shell and
Changes by Dan Stromberg strom...@gmail.com:
--
nosy: +strombrg
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23397
___
___
Python-bugs-list
Mark Hughes added the comment:
This is also an issue with Python 2.7.9 but not 2.7.8. There were various
cookie related fixes in 2.7.9 which could have revealed this issue. Maybe this
one?
https://hg.python.org/cpython/rev/9e765e65e5cb
--
nosy: +Mark Hughes
Matthias Klose added the comment:
there are two approaches here, one to check in generated files and try to avoid
the rebuild, or completely fix the cross build. I think the patch for the
parallel build just was a bit over-eager
--
___
Python
STINNER Victor added the comment:
using namespace std;
Doing this in a header is ugly.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23644
___
Saimadhav Heblikar added the comment:
http://bugs.python.org/issue5680
Also had submitted a patch for it. Could you post your review there? (I was
learning the CPython style then, so excuse obvious mistakes :) )
--
nosy: +sahutd
___
Python tracker
Changes by Demian Brecht demianbre...@gmail.com:
Added file: http://bugs.python.org/file38509/issue2211_5.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2211
___
Hiroaki Miyajima added the comment:
I've realized that this is a bug of specification of fcntl system call.
I am sorry to bother this site.
--
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23656
Mayank Tripathi added the comment:
Could someone please review the patch. Thanks.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21862
___
___
Matthias Klose added the comment:
reopening, breaks cross builds. I'll have a look
--
resolution: fixed -
status: closed - open
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22359
___
Vedran Čačić added the comment:
Ok, let's say I see your point about breaking existing code (though, I
reiterate, it's _undocumented_ and even examples in the docs all cover only the
obvious case).
Is it _at least_ possible to give .center an (keyword-only if needed) argument
that specifies
STINNER Victor added the comment:
#define _Atomic(T) std::atomicT
This looks better to me :-) Can you please write a patch?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23644
___
Joshua J Cogliati added the comment:
using namespace std;
Doing this in a header is ugly.
If you put it in the:
#ifdef __cplusplus
extern C {
#endif
then it would only apply till the end of the pyatomic header, and not to
anything that includes it. Something like:
#ifdef __cplusplus
Russell Keith-Magee added the comment:
Nick: Finding a way to get on-device test results is next on my TODO list, once
I've got the patch up to date for trunk.
FYI - Updating to trunk is currently blocking on issue22625 (which was
introduced by the fix for issue22359).
I had thought about
Russell Keith-Magee added the comment:
I'm looking into this issue because of issue23670 (iOS support).
Am I correct in assuming that the right fix here is to identify a
$(CC_FOR_BUILD) analog for $(PYTHON_FOR_BUILD) that will identify the build
host's CC, enabling a build-host native
Leonardo Bianconi added the comment:
@haypo
For adding compatibility for atomics based on @Joshua.J.Cogliati change, I
propose:
#ifndef Py_LIMITED_API
#ifndef Py_ATOMIC_H
#define Py_ATOMIC_H
#include dynamic_annotations.h
#include pyconfig.h
#if defined(HAVE_STD_ATOMIC)
#ifdef __cplusplus
R. David Murray added the comment:
Sounds reasonable. Dict and set comprehensions were added later than list
comprehensions, and we probably just didn't notice this needed updating.
Mark's patch, however, is incorrect. Mark: the dict/set literal notation is a
different thing from a
Dan Nawrocki added the comment:
I am using 2.7.5 (RHEL7 and FC20). Indeed, this issue appears fixed in 2.7.7,
by
https://hg.python.org/cpython/diff/44b5ec2f0f5d/Lib/multiprocessing/process.py.
I'm closing as not a bug.
Thanks for the help!
--
resolution: - not a bug
status: open -
New submission from bjshan:
imaplib status failed if the folder name contains whitespace.
For example,
c = IMAP4_SSL('hostname')
c = login(username, password)
c.status('Drafts', '(MESSAGES)')# would succeed
c.status('Apple Mail To Do', '(MESSAGES)') # would fail, error message is:
Tapani Kiiskinen added the comment:
A link to the to the glossary would also be good yes. I was figuring out how
super() works and as you said the doc gave the impression getattr would explain
more but it doesn't. Had to use google to find the glossary entry for MRO which
had the link
Nick Coghlan added the comment:
(Some work on the Buildbot site would still be required, but it would be
triggering a Sauce Labs run rather than managing the mobile hardware directly)
--
___
Python tracker rep...@bugs.python.org
Nick Coghlan added the comment:
Rather than trying to do something ourselves on the mobile testing front, we
may want to instead explore the free-for-open-source-project offering from
Sauce Labs: https://saucelabs.com/opensauce/
Adapting that to run the CPython self-tests as an app might be
Changes by Mark Lawrence breamore...@yahoo.co.uk:
--
keywords: +patch
versions: +Python 3.5
Added file: http://bugs.python.org/file38507/issue23677.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23677
New submission from mogli:
The documentation (https://docs.python.org/2/library/ssl.html) says:
The settings in Python 2.7.9 are: PROTOCOL_SSLv23, OP_NO_SSLv2, and OP_NO_SSLv3
with high encryption cipher suites without RC4
But it still seems to use RC4: https://www.howsmyssl.com/a/check
Also
Roundup Robot added the comment:
New changeset 91fbe0fff882 by Victor Stinner in branch 'default':
Issue #23571: Restore removed assert(!PyErr_Occurred()); in
https://hg.python.org/cpython/rev/91fbe0fff882
--
___
Python tracker rep...@bugs.python.org
Nick Coghlan added the comment:
(Serhiy, did you miss uploading the new patch?)
Regarding the names, we may need to think about the use cases a bit more
explicitly to clarify that in terms of the Python codecs API rather than
expecting folks to understand the underlying representation. In the
Changes by R. David Murray rdmur...@bitdance.com:
--
resolution: - not a bug
stage: - resolved
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23656
___
R. David Murray added the comment:
The Sauce labs option may render this obsolete, but to answer your question,
Russell: our buildbot fleet is distributed in many people's offices, basements,
and occasionally colo racks. The buildbot needs to be on-line 24/7, but it
calls out and does not
Antoine Pitrou added the comment:
The system is rather slow (a shared VPS instance). In the trace you can SIGALRM
is triggered before the first write() call (or so it seems).
--
___
Python tracker rep...@bugs.python.org
STINNER Victor added the comment:
2015-03-16 17:41 GMT+01:00 Antoine Pitrou rep...@bugs.python.org:
Note that PIPE_MAX_SIZE can be large. Perhaps move the memory allocation
(i.e. `item * (support.PIPE_MAX_SIZE // len(item) + 1)`) before the alarm(1)
call?
Good idea, the first strace shows
STINNER Victor added the comment:
Also, I think there another issue in that test. It uses `N =
support.PIPE_MAX_SIZE` but I think you want `N = support.PIPE_MAX_SIZE + 1`
if you want the raw write() to block.
PIPE_MAX_SIZE is much larger than the effictive size of a pipe on
Linux. It's
STINNER Victor added the comment:
You can explicitly disable RC4 if you create a SSLContext and then call
set_ciphers() with the right list of ciphers. See for examples cipher lists of
Python 2.7 (development branch):
https://hg.python.org/cpython/file/0b44c749ae51/Lib/ssl.py#l150
Add :!RC4
Antoine Pitrou added the comment:
Note that PIPE_MAX_SIZE can be large. Perhaps move the memory allocation (i.e.
`item * (support.PIPE_MAX_SIZE // len(item) + 1)`) before the alarm(1) call?
Or what if alarm_interrupt is simply set up to retrigger the signal? e.g.
instead of:
def
STINNER Victor added the comment:
The system is rather slow (a shared VPS instance). In the trace you can
SIGALRM is triggered before the first write() call (or so it seems).
Yep. It remembers me my old idea to make sleep configurable in tests: issue
#20910.
Most of the time, 1 second is
Leonardo Bianconi added the comment:
#define _Atomic(T) std::atomicT
Does not work, since there are definitions like memory_order_relaxed that are
in std.
I tested the other one, and it works fine:
#ifdef __cplusplus
extern C {
#if defined(HAVE_STD_ATOMIC)
using namespace std;
#endif
#endif
Benjamin Peterson added the comment:
RC4 is dropped in the next releases.
--
dependencies: +SSL module should not offer RC4 based cipher suites for clients
by default
nosy: +benjamin.peterson
resolution: - duplicate
status: open - closed
___
Python
Demian Brecht added the comment:
I've done an initial pass in Rietveld and left some comments, mostly around
docs. Here are some additional questions though:
Given has_* flags can be inferred during instantiation of *Result classes, is
there a reason to have them writable, meaning is there a
Roundup Robot added the comment:
New changeset a18f7508649b by Victor Stinner in branch 'default':
Issue #23680: Reduce risk of race condition in check_interrupted_write_retry()
https://hg.python.org/cpython/rev/a18f7508649b
--
nosy: +python-dev
___
Antoine Pitrou added the comment:
Also, I think there another issue in that test. It uses `N =
support.PIPE_MAX_SIZE` but I think you want `N = support.PIPE_MAX_SIZE + 1` if
you want the raw write() to block.
There is another test that can have a race condition: check_interrupted_write().
R. David Murray added the comment:
This is a duplicate of a subset of issue 917120.
--
nosy: +r.david.murray
resolution: - duplicate
stage: - resolved
status: open - closed
superseder: - imaplib: incorrect quoting in commands
___
Python tracker
Changes by R. David Murray rdmur...@bitdance.com:
--
nosy: +bjshan
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue917120
___
___
Python-bugs-list
R. David Murray added the comment:
Backward compatibility does not mean matches the docs, it means if we change
this, someone's existing code is likely to break. That does not prevent us
from making at-the-margin changes in a feature release, but it is still a bar
to be overcome in making
Steve Dower added the comment:
It looks like mmap uses pure Win32 APIs for the Windows implementation, and so
_chsize_s isn't necessary. There is a comment todo: need ... a 'chsize'
analog in the file, but I'm not actually sure what that means.
I've made some minor changes from the review,
New submission from Antoine Pitrou:
Sometimes the test suite freezes in test_interrupted_write_retry_text
(test.test_io.CSignalsTest). Corresponding strace is:
write(1, test_interrupted_write_retry_tex..., 66) = 66
rt_sigaction(SIGALRM, {0x00, [], SA_RESTORER, 0x7fd1ada2d0a0}, {SIG_DFL,
Changes by Antoine Pitrou pit...@free.fr:
--
components: +Tests
type: - behavior
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23680
___
___
STINNER Victor added the comment:
The bug only occurs in Python 3.5, right?
Sometimes the test suite freezes in test_interrupted_write_retry_text
(test.test_io.CSignalsTest).
How do you run the test suite? Is your system heavily loaded? Is it fast?
This is an obvious race condition in the
Changes by R. David Murray rdmur...@bitdance.com:
--
nosy: +alex, dstufft
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23679
___
___
Alex Gaynor added the comment:
I believe RC4 will still be used under 2.7.9 on clients, this is changed for
2.7.10
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23679
___
mogli added the comment:
So it seems the docs are wrong.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23679
___
___
Python-bugs-list mailing
Mark Hughes added the comment:
We experimented with a version of the patch for 2.7.9.
One issue we immediately noticed is that even though disallowed by the spec the
use of commas in cookie values is widespread so we needed to add \, to the
_LEGAL_VALUES_PATT.
--
Roundup Robot added the comment:
New changeset 10acab2d4a88 by Victor Stinner in branch 'default':
Issue #23680: Reduce risk of race condition in check_interrupted_write() of
https://hg.python.org/cpython/rev/10acab2d4a88
--
___
Python tracker
Changes by Brett Cannon br...@python.org:
--
priority: deferred blocker - release blocker
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23681
___
New submission from Brett Cannon:
To help writing Python 2/3 code the -b flag should switch on a warning when
comparing an int to a bytes object in Python 2. This will help when someone
writes something like `b'abcd'[2] == b'c'` and it always returns False thanks
to the indexing returning 99
Benjamin Peterson added the comment:
They're correct for the next release. :(
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23679
___
___
Roundup Robot added the comment:
New changeset e1dfa5f0709f by Benjamin Peterson in branch '2.7':
versionchanged for rc4 removal (closes #23679)
https://hg.python.org/cpython/rev/e1dfa5f0709f
New changeset 2a6a63828a40 by Benjamin Peterson in branch '3.4':
versionchanged for rc4 removal (closes
Ethan Furman added the comment:
Patch adds Enum._convert which is a class method that handles:
- creating the new Enum
- adding the appropriate members
- adding the new Enum to the module's namespace (which is a passed parameter)
- replacing the __reduce_ex__ method to return just the
Changes by Brett Cannon br...@python.org:
--
priority: normal - deferred blocker
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23681
___
___
Changes by Brett Cannon br...@python.org:
--
versions: +Python 3.5 -Python 2.7
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23681
___
___
Serhiy Storchaka added the comment:
6 tests failed:
test_buffer test_poplib test_quopri test_smtpd test_sunau
test_tokenize
And all of them look as bugs.
--
nosy: +serhiy.storchaka
___
Python tracker rep...@bugs.python.org
R. David Murray added the comment:
But the doc explicitly says 2.7.9, so no, they are not correct. There also
should be versionchanged directive, I think.
--
assignee: - docs@python
components: +Documentation
dependencies: -SSL module should not offer RC4 based cipher suites for
Changes by R. David Murray rdmur...@bitdance.com:
--
resolution: duplicate -
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23679
___
___
Berker Peksag added the comment:
[...] fixes existing bugs in the stdlib and tests.
These changes should probably be backported to 3.4.
--
nosy: +berker.peksag
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23681
Berker Peksag added the comment:
Thanks Thomas!
--
resolution: - fixed
stage: commit review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23682
___
Roundup Robot added the comment:
New changeset 910a7a540a31 by Berker Peksag in branch '3.4':
Issue #23682: Delete Python 2.2 mention from distutils documentation.
https://hg.python.org/cpython/rev/910a7a540a31
New changeset 7757e98a9f3b by Berker Peksag in branch 'default':
Issue #23682:
Demian Brecht added the comment:
I avoided making them positional parameters, as they are not part of the
underlying tuple object.
Ignore me, I was off my face and you're absolutely correct.
--
___
Python tracker rep...@bugs.python.org
Paul Moore added the comment:
Updated version of the patch with tests, plus doc update noting that path
objects are explicitly supported.
--
Added file: http://bugs.python.org/file38513/duck_typed_zipapp.patch
___
Python tracker
Martin Panter added the comment:
## Inferring flags ##
The whole reason for the has_netloc etc flags is that I don’t think we can
always infer their values, so we have to explicitly remember them. Consider the
following two URLs, which I think should both have empty “netloc” strings for
Robert Collins added the comment:
Regression fixed AFAICT, please re-open if not.
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17911
___
Changes by Berker Peksag berker.pek...@gmail.com:
--
assignee: docs@python - berker.peksag
stage: - commit review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23682
___
Martin Sekera added the comment:
In the end it doesn't matter what characters end up on the terminal. What
matters is the UX of not having to press backspace several times to unindent.
That's sloppy design.
The issue of forcing a custom indent width on a user who might have their tab
stops
Lennart Regebro added the comment:
FYI me and Berker started over here: https://bitbucket.org/regebro/cpython
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23397
___
Arfrever Frehtes Taifersar Arahesis added the comment:
So use std::memory_order_relaxed, std::memory_order_acquire etc.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23644
___
Serhiy Storchaka added the comment:
Fixed a bug in surrogatepass with translating and added the versionchanged
directive.
--
Added file: http://bugs.python.org/file38504/translate_error_handlers_2.patch
___
Python tracker rep...@bugs.python.org
Lars Gustäbel added the comment:
I agree with David that there is no need for tarfile to be thread-safe. There
is nothing to be gained from distributing one TarFile object among multiple
threads because it operates on a single resource which has to be accessed
sequentially anyway. So, it
Serhiy Storchaka added the comment:
Proposed preliminary patch adds three functions in the codecs module:
convert_surrogates(data, errors) -- handle lone surrogates with specified error
handler.
codecs.convert_surrogates('a\u20ac\udca4', 'backslashreplace')
'a€\\udca4'
Serhiy Storchaka added the comment:
Here is a patch that adds required feature and fixes existing bugs in the
stdlib and tests.
No one of failed tests was false positive.
--
keywords: +patch
stage: test needed - patch review
Added file:
Changes by Claudiu Popa pcmantic...@gmail.com:
--
nosy: +Claudiu.Popa
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23681
___
___
Python-bugs-list
Changes by Ethan Furman et...@stoneleaf.us:
--
nosy: +ethan.furman
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22625
___
___
Python-bugs-list
STINNER Victor added the comment:
I reviewed issue23566_fd_tests.patch .
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23566
___
___
Changes by Serhiy Storchaka storch...@gmail.com:
--
keywords: +patch
Added file: http://bugs.python.org/file38506/codecs_convert_escapes.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18814
Changes by Berker Peksag berker.pek...@gmail.com:
--
stage: commit review - resolved
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23571
___
___
Changes by Serhiy Storchaka storch...@gmail.com:
Added file: http://bugs.python.org/file38505/23668_2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23668
___
STINNER Victor added the comment:
I reviewed 23668_2.patch.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23668
___
___
Python-bugs-list
New submission from Frank Millman:
This is from the documentation at Section 4.6.4. Lists
Lists may be constructed in several ways:
Using a pair of square brackets to denote the empty list: []
Using square brackets, separating items with commas: [a], [a, b, c]
Using a list comprehension: [x
STINNER Victor added the comment:
Lars Gustäbel added the comment:
I agree with David that there is no need for tarfile to be thread-safe. There
is nothing to be gained from distributing one TarFile object among multiple
threads because it operates on a single resource which has to be
Serhiy Storchaka added the comment:
At first glance the patch looks good, but I did not test it. Are there tests
for truncate() with large files ( 4 GiB)?
ftruncate() is used also im mmap.resize(). Do you want to provide a patch also
for mmap?
--
99 matches
Mail list logo
