Serhiy Storchaka added the comment:
Here is a patch that makes bytes formatting raise an OverflowError if integer
argument of %c is out of range.
--
Added file: http://bugs.python.org/file38812/bytes_format_overflow.patch
___
Python tracker
STINNER Victor added the comment:
self.assertRaises(OverflowError, (�*(2**32//12 + 1)).upper)
MemoryError
Hum, even with the PEP 393, this string is still large: 682 MB.
$ python3
Python 3.4.1 (default, Nov 3 2014, 14:38:10)
sys.getsizeof(�*(2**32//12 + 1)) / 1024.**2
Serhiy Storchaka added the comment:
http://buildbot.python.org/all/builders/PPC64%20AIX%203.x/builds/3466/steps/test/logs/stdio
==
ERROR: test_case_operation_overflow (test.test_unicode.UnicodeTest)
STINNER Victor added the comment:
b'%c' is still raising a TypeError. The error message is fine (%c requires
an integer in range(256) or a single byte) but it should be an OverflowError
for backwards compatibility.
I don't understand why you care so much on the exact exception. It doesn't
Roundup Robot added the comment:
New changeset c3e7a670dda2 by Victor Stinner in branch '3.4':
Issue #22351: Fix test_nntplib if the ssl module is missing
https://hg.python.org/cpython/rev/c3e7a670dda2
--
___
Python tracker rep...@bugs.python.org
Serhiy Storchaka added the comment:
It's strange to have � here. Should be ü.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22643
___
___
Serhiy Storchaka added the comment:
Good catch. But may be better to report MockSslTests as skipped instead of
silently omit them.
--
Added file: http://bugs.python.org/file38814/issue22351_skip_MockSslTests.patch
___
Python tracker
Changes by Robert Kuska rku...@gmail.com:
--
nosy: +bkabrda
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23857
___
___
Python-bugs-list mailing
Serhiy Storchaka added the comment:
See the patch.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22351
___
___
Python-bugs-list mailing list
Martin Panter added the comment:
I’m sorry Stefan, I now realize my changes for len(view) were indeed wrong, and
the original was much more correct. I still think the tobytes() and maybe
tolist() documentation could be improved, but that is a separate issue to the
bytes-like definition.
I am
Roundup Robot added the comment:
New changeset 753233baf27e by Victor Stinner in branch 'default':
Issue #23853: Cleanup _ssl.c
https://hg.python.org/cpython/rev/753233baf27e
--
nosy: +python-dev
___
Python tracker rep...@bugs.python.org
Roundup Robot added the comment:
New changeset d976683671ba by Victor Stinner in branch 'default':
Issue #22117: Add a new _PyTime_FromSeconds() function
https://hg.python.org/cpython/rev/d976683671ba
--
___
Python tracker rep...@bugs.python.org
Roundup Robot added the comment:
New changeset 7a9c49885cd3 by Victor Stinner in branch 'default':
Issue #23834: Simplify timeout handling
https://hg.python.org/cpython/rev/7a9c49885cd3
--
___
Python tracker rep...@bugs.python.org
STINNER Victor added the comment:
It's strange to have � here. Should be ü.
Oh right, I saw � in the bug tracker and in the buildbot output. But
it's a web browser issue, if you download the raw buildbout output,
you will see ü. So the string takes less memory (1 byte per
character, not 2).
New submission from Tim Golden:
PCBuild\build.bat takes an argument of -e to pull in external libraries.
Either by accident or by design the main build will run in addition. However if
you'd run pcbuild -e simply to pull in externals, you might not have specified
extra build params, such as
STINNER Victor added the comment:
Serhiy’s patch looks like it should do the trick. Just get rid of the “self”
parameter to make it clearer,
+class MockSslTests(MockSocketTests):
+def nntp_class(self, *pos, **kw):
Hum, you should use the @staticmethod decorator here.
--
Roundup Robot added the comment:
New changeset 7a91363f31e1 by Serhiy Storchaka in branch '3.4':
Issue #22351. MockSslTests tests in test_nntplib now are reported if skipped.
https://hg.python.org/cpython/rev/7a91363f31e1
New changeset c935c1e1d001 by Serhiy Storchaka in branch 'default':
Issue
STINNER Victor added the comment:
Except of the self parameter/@staticmethod and the unrelated SAX changes,
issue22351_skip_MockSslTests.patch looks good to me.
--
resolution: fixed -
status: closed - open
___
Python tracker rep...@bugs.python.org
STINNER Victor added the comment:
This issue is related to the PEP 476 which made the SSL certification checks
mandatory by default.
The PEP contains a section to explain how to opt-out, but the solution is
global:
https://www.python.org/dev/peps/pep-0476/#opting-out
I understand that Robert
Robert Kuska added the comment:
1) patch attached, dunno how I missed it, thank you.
3) I work for Red Hat
additional interest for example here http://seclists.org/oss-sec/2015/q1/785
2) It exists but it is not system wide, I would like to provide users option to
opt-in or opt-out without
Serhiy Storchaka added the comment:
bigimem tests are ran with dummy size = 5147 if dry_run = True (default) and
skipped if dry_run = False. Almost always you need dry_run = False.
The -M option doesn't work with less than 1 GiB.
In this case likely the buildbot had enough memory at the
Nick Coghlan added the comment:
(capturing these details here for now, we should at least have a python-dev
discussion before going ahead with any changes in this area)
The additional background here is that we started looking closely at what would
be involved in applying PEP 476 to systems
Robert Kuska added the comment:
If you mean hack site.py to be sitecustomize I don't find it as a sufficient
solution because users may use their own sitecustomize and this way we would
replace theirs.
Sslcustomize solution could be another option how to handle this but the config
idea
Robert Kuska added the comment:
( ^ I was replying to Victor)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23857
___
___
Python-bugs-list
Martin Panter added the comment:
Serhiy’s patch looks like it should do the trick. Just get rid of the “self”
parameter to make it clearer, and watch out for the stray XML changes!
--
___
Python tracker rep...@bugs.python.org
R. David Murray added the comment:
1) there is no patch attached
2) certificate verification is optional already, is it not? That is, it can be
turned off in your code, it is just on by default.
3) what downstream are you talking about?
Supposing there is sufficient utility here, the level of
STINNER Victor added the comment:
- I've learned that MSG_WAITALL may be unreliable on certain systems, so any
implementation of recvall depending on MSG_WAITALL may inexplicably fail on
such systems
Something else occurred since 5 years: the PEP 475 was accepted, it makes
Python more
Serhiy Storchaka added the comment:
Agree, factory method can be staticmethod.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22351
___
___
Serhiy Storchaka added the comment:
Now you have used time machine in reverse mode.
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22351
___
STINNER Victor added the comment:
2) It exists but it is not system wide,
You can hack site.py to disable SSL checks system-wide. It was also discussed
to support an optional sslcustomize module, but the idea was rejected if I
remember correctly. Anyway, did you read the discussion on the
Martin Panter added the comment:
Sorry, that self parameter is okay. I was just confused because it now means
something different :S
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22351
STINNER Victor added the comment:
Here is a patch to fix the issue: recompute the timeout.
It's unclear to me if we should reset the timeout after each successful
read/write, or if the timeout is global (total duration of the ssl method). I
asked the question on the python-dev mailing list.
Changes by Serhiy Storchaka storch...@gmail.com:
--
keywords: +patch
stage: resolved - patch review
versions: -Python 3.3
Added file:
http://bugs.python.org/file38818/test_case_operation_overflow_memory_error.patch
___
Python tracker
Serhiy Storchaka added the comment:
Perhaps adding bigmemtest is not worth if memory requirements are less than 1
GiB. But I would separate the creating of long tested string and the calling of
case converting method, so we will sure what operation is failed. Proposed
patch skips the test if
STINNER Victor added the comment:
Perhaps adding bigmemtest is not worth if memory requirements are less than 1
GiB.
What is the current limit if you don't pass -M option to regrtest? In
@bigimemtest, I see maxsize = 5147. Is it a number of bytes? 5 kB of memory?
IMO it's interested to use
Nick Coghlan added the comment:
The other goal worth noting here is that we'd like to facilitate easy system
auditing/monitoring such that machines that still have Python certificate
verification off by default can easily be flagged by checks in tools like
Nagios, as well as being easy to
Roundup Robot added the comment:
New changeset c167b9f9aac8 by Victor Stinner in branch '3.4':
Issue #23219: Update asyncio.wait_for() documentation
https://hg.python.org/cpython/rev/c167b9f9aac8
--
___
Python tracker rep...@bugs.python.org
New submission from STINNER Victor:
When wait(fs) is cancelled, futures of fs are not cancelled. This behaviour is
not documented. It should be documented, and a warning should be added to the
Cancellation section:
https://docs.python.org/dev/library/asyncio-dev.html#cancellation
See my
Changes by Steve Dower steve.do...@microsoft.com:
--
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23765
___
___
Ned Deily added the comment:
This is essentially a duplicate of Issue3467 and various other similar issues.
While it may not be easy to justify the special case in setup.py for OS X (the
reason was primarily for OS X installer builds), it would be even harder to
justify adding another
Ned Deily added the comment:
My apologies, I replied a bit too hastily, thinking incorrectly that your
suggested change was just for sqlite3. While the comments above still apply,
there is already an open request for the more general feature (and more) under
Issue21571. So I suggest further
Serhiy Storchaka added the comment:
See also issue18184.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23466
___
___
Python-bugs-list mailing
STINNER Victor added the comment:
Good catch. But may be better to report MockSslTests as skipped instead of
silently omit them.
I don't know how to do that.
--
nosy: +haypo
___
Python tracker rep...@bugs.python.org
New submission from Robert Kuska:
Proposed patch adds possibility to opt-out certificate verification.
Disclaimer: it is just proof of concept as the config value is hard-coded.
How it works?
This patch depends on existence of config file which holds information about
the protocol settings.
Larry Hastings added the comment:
As promised, here's a cleaned-up version of the patch. The taxonomy of objects
now makes sense: a Destination contains a BufferSeries object, rather than
Destinations weirdly supporting __getitem__ to reference different objects.
I tripped over myself a
Changes by Simon Ye sye...@gmail.com:
--
nosy: +yesimon
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21571
___
___
Python-bugs-list mailing list
Cédric Krier added the comment:
Here is a patch that uses getrlimit (that's works on OpenBSD) before using
sysconf.
--
Added file: http://bugs.python.org/file38824/max_fd.patch
___
Python tracker rep...@bugs.python.org
Tim Golden added the comment:
Fair enough
--
resolution: - not a bug
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23856
___
Steve Dower added the comment:
Sorry, _Py_open requires a double encoding (wchar-char-wchar), which is why
I'm not going to use it.
_Py_wfopen takes a mode string rather than _O_* flags, and so implicitly
includes _O_CREAT.
Guessing we should add _Py_wopen?
--
STINNER Victor added the comment:
Sorry, I still fail to see how _Py_open() or _Py_open_noraise() add the O_CREAT
flag: they are thin wrapper to the underyling open() function. I cannot see
O_CREAT in Python/fileutils.c. Could you please show me that the line number
adding O_CREAT implictly?
Larry Hastings added the comment:
Updated patch, removed all references to two-pass. Also realized I needed to
make the default behavior for methoddef_ifndef go to the end. And, finally, I
forgot to merge the only print each #ifndef block once code I wrote before
when I redid the patch, so
Gregory P. Smith added the comment:
I'm not going to bother setting up a VM with an esoteric OS in it myself, if
someone knows the past and current state of various OpenBSD versions and what
to do there, feel free to commit OpenBSD conditional compilation bits as you
see fit to make this do
New submission from Bill Parker:
Hello All,
In reviewing code in directory Python-3.4.3/Modules, file
'mmapmodule', I found a call to 'lseek()' without a check for
a return value of -1, indicating failure. The patch file below
corrects this issue (diff -u format):
--- mmapmodule.c.orig
Cédric Krier added the comment:
Indeed, I think my patch is not right as /dev/fd on OpenBSD is static.
I will continue to investigate.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23852
Larry Hastings added the comment:
I did, I just didn't respond. I'll do that now.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23500
___
___
Changes by Serhiy Storchaka storch...@gmail.com:
--
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23466
___
Demian Brecht added the comment:
@Cory: my own plan was to use your implementation as the baseline and add
server support. If you take a crack at it that would be great!
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23794
Cory Benfield added the comment:
figure out some kind of adapter interface in order to facilitate swapping
between 1.1 and 2 (This can start with a clean HTTP/1.1 interface)
I've been thinking about this a lot with hyper, and I'm about to start work on
it (having just finished an alpha
Cédric Krier added the comment:
The problem comes from safe_get_max_fd which return a too low value because of
a bug in sysconf on OpenBSD [1]:
The value for _SC_STREAM_MAX is a minimum maximum, and required to be the same
as ANSI C's FOPEN_MAX, so the returned value is a ridiculously small
Changes by Cédric Krier cedric.kr...@b2ck.com:
--
type: - behavior
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23852
___
___
Python-bugs-list
Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: - larry
stage: patch review - commit review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23500
___
Ethan Furman added the comment:
Looks good, thanks Serhiy.
--
stage: needs patch - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23466
___
STINNER Victor added the comment:
queue_bug.py: script to reproduce the bug.
I confirm that Queue.get() sometimes looses items when it is cancelled. The
waiter contains the result, but the waiter is lost when get() is cancelled.
Queue.get() waiter got a result, but Queue.get() wakeup is only
Roundup Robot added the comment:
New changeset 313fd1c819c5 by Serhiy Storchaka in branch 'default':
Issue #23466: Raised OverflowError if %c argument is out of range.
https://hg.python.org/cpython/rev/313fd1c819c5
--
___
Python tracker
Demian Brecht added the comment:
+1 to the adding the support for HTTP/2. I would personally like to see a few
things happen before that though (which I've been putting some effort into as i
can)
+ refactor http.client to cleanly separate transport from application protocol
level
+ figure
Serhiy Storchaka added the comment:
Looks as you didn't notice my comments on Rietveld.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23500
___
Serhiy Storchaka added the comment:
larry.ac_multiple_macro_definitions.diff.5.txt LGTM.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23500
___
New submission from Steve Dower:
Currently we initialize stdprinter while initializing and terminate if we can't
access std streams.
We should always write to DebugOutputString on Windows (only does anything if a
debugger is attached) and avoid terminating in this case.
--
Changes by Masayuki Yamamoto light2happy@gmail.com:
--
nosy: +masamoto
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23338
___
___
Changes by Terry J. Reedy tjre...@udel.edu:
--
stage: - test needed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23831
___
___
Python-bugs-list
Changes by Terry J. Reedy tjre...@udel.edu:
--
nosy: +serhiy.storchaka, terry.reedy
versions: +Python 3.5 -Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23831
___
Paul Moore added the comment:
On Windows, subprocess.Popen has to convert an argument list to a command line
(because that's what the OS expects for CreateProcess). It does so internally,
using subprocess.list2cmdline, which follows the quoting rules for the MS C
runtime (because that's what
Serhiy Storchaka added the comment:
Thank you Larry.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23500
___
___
Python-bugs-list mailing list
Terry J. Reedy added the comment:
With 3.4.3, I get the equivalent on Windows (a 'python has stopped working'
box).
--
nosy: +terry.reedy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23815
Serhiy Storchaka added the comment:
I think this is not needed.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23500
___
___
Python-bugs-list
Changes by Terry J. Reedy tjre...@udel.edu:
--
nosy: +terry.reedy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23791
___
___
Python-bugs-list
Roundup Robot added the comment:
New changeset aa88a18a4aa1 by Serhiy Storchaka in branch 'default':
Issue #23501: Argumen Clinic now generates code into separate files by default.
https://hg.python.org/cpython/rev/aa88a18a4aa1
--
nosy: +python-dev
Roundup Robot added the comment:
New changeset e10ad4d4d490 by Serhiy Storchaka in branch 'default':
Issue #23492: Argument Clinic now generates argument parsing code with
https://hg.python.org/cpython/rev/e10ad4d4d490
--
nosy: +python-dev
___
Python
Terry J. Reedy added the comment:
Whatever you do with the other -OO patches, I would prefer that this be applied
to 3.4. The 3.4/3.5 files should be identical.
--
versions: +Python 3.4
___
Python tracker rep...@bugs.python.org
Roundup Robot added the comment:
New changeset 25eef0ecb9c1 by Larry Hastings in branch 'default':
Issue #23500: Argument Clinic is now smarter about generating the #ifndef
https://hg.python.org/cpython/rev/25eef0ecb9c1
--
nosy: +python-dev
___
Peter added the comment:
Test 1
Python 3.4.3 built by GCC 4.9.2 is:
str(memoryview(b'abcdefghijklmnopqrstuvwxyz')[1:], 'ascii')
'bcdefghijklmnopqrstuvwxyz'
Test 2
Python 3.4.3 built by GCC 4.6.2 is (no patches applied)
This build will core dump if I run -m test test_hash.
Terry J. Reedy added the comment:
The relevant code in CallTips.py itself
if isinstance(ob_call, types.MethodType):
doc = ob_call.__doc__
else:
doc = getattr(ob, __doc__, )
if doc: add more to calltip
equally ignores both None and '', but I forgot the None
Larry Hastings added the comment:
Does this really need a backport to 3.4?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23500
___
___
Roundup Robot added the comment:
New changeset 157b7055bb9d by Serhiy Storchaka in branch 'default':
Issue #15582: inspect.getdoc() now follows inheritance chains.
https://hg.python.org/cpython/rev/157b7055bb9d
--
nosy: +python-dev
___
Python tracker
New submission from rengine:
Using Python 2.7.9
Noticed when I run a subprocess Popen with an argument containing double
quotes, it will have a different affect depending on my operating system.
In Linux, if I run ./runme.py, it will call runme.sh which will append
someargs.txt correctly
Serhiy Storchaka added the comment:
Unfortunately this enhancement breaks test_enum.
==
FAIL: test_pydoc (test.test_enum.TestStdLib)
--
Traceback (most recent
Terry J. Reedy added the comment:
This is a fairly common newbie bug. random.py seems to be favorite name.
--
nosy: +terry.reedy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23809
___
Larry Hastings added the comment:
Removing 3.4 from the version list as I close the bug, then. If we decide we
need it backported please reopen (or create a new bug, either is fine).
--
resolution: - fixed
stage: commit review - resolved
status: open - closed
versions: -Python 3.4
Larry Hastings added the comment:
Thanks! I've been meaning to follow up on this. I think CPython should be
consistent, one way or another. So I support this change.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23501
Changes by Serhiy Storchaka storch...@gmail.com:
--
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23501
___
Changes by Serhiy Storchaka storch...@gmail.com:
--
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23492
___
Changes by Michael Schurter m...@schmichael.com:
--
nosy: -schmichael
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20718
___
___
Changes by Ned Deily n...@acm.org:
--
nosy: +haypo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23863
___
___
Python-bugs-list mailing list
Changes by Mark Lawrence breamore...@yahoo.co.uk:
--
nosy: +BreamoreBoy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23861
___
___
Jeff McNeil added the comment:
mcjeff@mcjeff:~/cpython_clean$ hg summary
parent: 95416:fe34dfea16b0
Escaped backslashes in docstrings.
branch: 2.7
commit: 3 modified, 3 unknown
update: (current)
--
keywords: +patch
nosy: +gregory.p.smith
Added file:
Donald Stufft added the comment:
I'd really rather not add this to Python itself. If downstream wants to patch
their Pythons to do it that is their prerogative. There's some legacy at play
here of course, however I don't think that Python upstream is the right place
to deal with that.
One
New submission from Jeff McNeil:
There are a collection of places in the socket module that do not correctly
retry on EINTR. Updated to wrap those calls in a retry loop. However, when
fixing connect calls, I noticed that when EINTR is retried on a socket with a
timeout specified, the retry
R. David Murray added the comment:
Changing the title to be specific to the proposed patch.
--
title: [RFE] Make default HTTPS certificate verification setting configurable
- Make default HTTPS certificate verification setting configurable via global
ini file
Barry A. Warsaw added the comment:
+1 for keyed by site
There have been a number of issues over the years for which a configuration
file (or files) would have been useful. I think a discussion over on
python-ideas is the right way to move forward on this point.
--
New submission from Simon Ye:
Based off of https://github.com/Homebrew/linuxbrew/pull/330.
Currently building python on linux only looks for sqlite include paths in a
hardcoded set of system paths, but if the user specifies -I/-L options during
compilation, python setup.py looks there for
1 - 100 of 108 matches
Mail list logo
