Changes by Serhiy Storchaka storch...@gmail.com:
--
nosy: +benjamin.peterson, pitrou, stutzbach
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24358
___
Mike Frysinger added the comment:
also, it looks like this bug is in python-3.3. not sure what the status of
that branch is, but maybe the backport from 3.4 would be easy ?
--
___
Python tracker rep...@bugs.python.org
Changes by Nick Coghlan ncogh...@gmail.com:
--
assignee: - ncoghlan
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24267
___
___
Python-bugs-list
Changes by Berker Peksag berker.pek...@gmail.com:
--
nosy: +berker.peksag
stage: - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24360
___
Mike Frysinger added the comment:
the original report on our side w/bunches of tracebacks: http://crbug.com/481223
with that traceback in hand, it's pretty trivial to write a reproduction :).
attached!
i couldn't figure out how to make it work w/out completely execing a new python
instance.
sping added the comment:
I guess supporting older upstream versions would be nice in this case.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24266
___
Petr Viktorin added the comment:
I meant stable ABI, of course
--
title: Conditionalize 3.5 additions to the stable API - Conditionalize 3.5
additions to the stable ABI
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24365
Changes by Ned Deily n...@acm.org:
--
nosy: +ezio.melotti, michael.foord, rbcollins
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24355
___
___
Changes by Yury Selivanov yseliva...@gmail.com:
--
nosy: +ncoghlan
stage: - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24365
___
R. David Murray added the comment:
It looks to me like this is complete, so closing.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7559
___
___
Changes by Ned Deily n...@acm.org:
--
nosy: +ezio.melotti, michael.foord, rbcollins
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24352
___
___
Changes by Yury Selivanov yseliva...@gmail.com:
--
nosy: +yselivanov
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24362
___
___
Python-bugs-list
R. David Murray added the comment:
Terry: the slowdown might be IPV6 handling, which was a bit broken on windows.
In any case, I think the slowdown should be treated as a separate issue if you
care about it, so I'm going to close this. (I think it would be great if
someone would do a review
New submission from Petr Viktorin:
I have sent patches to 3.5 that add new stable API, and later I learned [0]
that additions should be conditional on the value of Py_LIMITED_API.
This patch adds #ifdef blocks for what was added in issues #24268 and #24345.
[0]
R. David Murray added the comment:
Per Raymond's last message, closing this as rejected.
--
assignee: rhettinger - docs@python
stage: needs patch - resolved
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22725
R. David Murray added the comment:
Looks like Serhiy forgot to close this, so closing it.
--
assignee: serhiy.storchaka -
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23171
___
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com:
--
nosy: +Arfrever
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24266
___
R. David Murray added the comment:
No, I just had a stale tab :( :(
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23171
___
___
Changes by Barry A. Warsaw ba...@python.org:
--
nosy: +barry
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19699
___
___
Python-bugs-list mailing
Changes by R. David Murray rdmur...@bitdance.com:
--
stage: patch review - commit review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23440
___
New submission from Eric Snow:
While the dict/OrderedDict iterators already check for additions and deletions,
using the OrderedDict.move_to_end during iteration can lead to surprising
results.
The following results in an infinite loop:
od = OrderedDict.fromkeys('abc')
last = None
Michael Del Monte added the comment:
I don't want to speak out of school and you guys certainly know what you're
doing, but it seems a shame to go through these gyrations -- lookahead plus
unreading lines -- only to preserve the ability to parse email headers, when
HTTP really does follow a
Eric Snow added the comment:
Here's a patch with tests.
--
keywords: +patch
stage: needs patch - patch review
Added file: http://bugs.python.org/file39601/issue24368-kwargs.diff
___
Python tracker rep...@bugs.python.org
New submission from Eric Snow:
Several methods were implemented using PyArg_UnpackTuple and need to use
PyArg_ParseTupleAndKeywords instead.
--
assignee: eric.snow
components: Library (Lib)
messages: 244716
nosy: eric.snow
priority: release blocker
severity: normal
stage: needs patch
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com:
--
nosy: +Arfrever
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24320
___
Eric Snow added the comment:
FYI, this doesn't crash when I have the patch from issue24362 applied.
--
assignee: - eric.snow
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24361
___
Yury Selivanov added the comment:
Can this issue be closed now?
--
nosy: +yselivanov
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24270
___
___
Terry J. Reedy added the comment:
Your message arrived as I was just starting on this issue, wondering whether
the exclusion of threading and queue blocks is proper and wishing for an easy
test example, such as you provided. It verifies the issue in 3.x. It also
answers the question:
Terry J. Reedy added the comment:
Previous issue has a patch that needs independent review.
--
resolution: - duplicate
stage: - resolved
status: open - closed
superseder: - IDLE - shell becomes unresponsive if debugger windows is closed
while active.
R. David Murray added the comment:
No, the point is to do best practical error recovery when faced with dirty
data that may be dirty in various ways, and it doesn't really matter whether it
is http headers or email headers. A line with leading whitespace is treated as
part of the preceding
Martin Panter added the comment:
Regarding the suggested fix for Python 2, make sure it does not prematurely end
the parsing on empty folded lines (having only tabs and spaces in them). E.g.
according to RFC 7230 this should be a single header field:
bHeader: obsolete but\r\n
b\r\n
b
R. David Murray added the comment:
Yes, this is fixed, as the issue resolution says. If you are curious about the
fix, follow the links to the commits starting in msg197116.
--
nosy: +r.david.murray
___
Python tracker rep...@bugs.python.org
David Bolen added the comment:
Oops, sorry, I had just followed the commit comment to this issue. For the
record here, it looks like Benjamin has committed an update (5e8fa1b13516) that
resolves the problem.
--
___
Python tracker
Larry Hastings added the comment:
Then you may fire when ready.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24320
___
___
Python-bugs-list
Antoine Pitrou added the comment:
Nous disions que tu aurais probablement à valider ce changement, mais que nous
pourrions peut-être aussi le faufiler discrètement dans la base de code, vu que
tu ne lis pas ces message.
--
___
Python tracker
Changes by Daniel danielciugur...@yahoo.com:
--
files: indent.patch
keywords: patch
nosy: li4ick
priority: normal
severity: normal
status: open
title: Simple indentation
versions: Python 3.6
Added file: http://bugs.python.org/file39597/indent.patch
Eric Snow added the comment:
Hmm. Looks like the fix in setuptools/pkg_resources is 17.0. [1] The bundled
pip to which we just updated is 7.0.3, which appears to bundle pkg_resources
15.0. [2] So unless I've misunderstood, the hack will have to linger for a bit
longer.
Here's a patch for
Roundup Robot added the comment:
New changeset c835dd16539a by Yury Selivanov in branch '3.5':
Issue 24365: Conditionalize PEP 489 additions to the stable ABI
https://hg.python.org/cpython/rev/c835dd16539a
New changeset fd265fa89c36 by Yury Selivanov in branch 'default':
Issue 24365: Merge 3.5
ppperry added the comment:
This problem also occurs in other situati, such as when trying to get items
from an empty queue
import Queue
Q = Queue.Queue()
q.get_nowait()
Traceback (most recent call last):
File pyshell#16, line 1, in module
q.get_nowait()
Empty
In that case, it doesn't
Changes by Yury Selivanov yseliva...@gmail.com:
--
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24342
___
Eric Snow added the comment:
Here's a patch that adds stores the hash on each node. This eliminates the
need to call PyObject_Hash when rebuilding the fast nodes table during a
resize. The patch also drops a superfluous while loop.
--
keywords: +patch
stage: needs patch - patch
Larry Hastings added the comment:
Quoi? Je comprends que le français.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18003
___
___
Etienne Le Sueur added the comment:
Thanks, I had missed that message.
On 6/2/15 4:39 PM, R. David Murray wrote:
R. David Murray added the comment:
Yes, this is fixed, as the issue resolution says. If you are curious about
the fix, follow the links to the commits starting in msg197116.
Larry Hastings added the comment:
If I understand this correctly, I can ignore everything up to May 2015, as it
has to do with line-reading a compressed binary file (!) being slow.
Then, Martin Panter proposes a new optimization in May 2015, which is to simply
add __iter__ methods to
R. David Murray added the comment:
I think there may be a way to accomplish this in a reasonably straightforward
fashion in python3 given that feedparser has an 'unreadline' function. The
python2 case is probably going to be a more complicated change. And I agree
that multiple lines should
New submission from ppperry:
[DEBUG ON]
some_code
(debugger closed before pressing any buttons)
[DEBUG OFF]
more_code
(no response)
--
components: IDLE
messages: 244707
nosy: kbk, ppperry, roger.serwy, terry.reedy
priority: normal
severity: normal
status: open
title: Idle hangs when
Antoine Pitrou added the comment:
This looks good to me. Larry would probably have to validate it for 3.5,
although we may try to sneak it in (he isn't reading :-D).
--
nosy: +larry
___
Python tracker rep...@bugs.python.org
Larry Hastings added the comment:
Sounds okay in theory. Is the bug in question now tested in our regression
suite?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24320
___
Cory Benfield added the comment:
This is one of those bugs that's actually super tricky to correctly fix.
The correct path is to have the goal of conservatively accepting as many
headers as possible. Probably this means looking ahead to the next few lines
and seeing if they appear to roughly
Changes by Demian Brecht demianbre...@gmail.com:
--
nosy: +demian.brecht
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24363
___
___
Nick Coghlan added the comment:
Looks good to me.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24365
___
___
Python-bugs-list mailing list
Roundup Robot added the comment:
New changeset 19d613c2cd5f by Yury Selivanov in branch '3.5':
Issue 24342: Let wrapper set by sys.set_coroutine_wrapper fail gracefully
https://hg.python.org/cpython/rev/19d613c2cd5f
New changeset 8a6db1679a23 by Yury Selivanov in branch 'default':
Issue 24342:
New submission from Roundup Robot:
New changeset 035aa81c2ba8 by Yury Selivanov in branch '3.3':
Issue 24366: Indent code (thanks to li4ick for reporting).
https://hg.python.org/cpython/rev/035aa81c2ba8
New changeset 95d1f38e540e by Yury Selivanov in branch '3.4':
Issue 24366: Merge 3.3
Changes by Yury Selivanov yseliva...@gmail.com:
--
resolution: - fixed
stage: - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24366
___
Changes by Yury Selivanov yseliva...@gmail.com:
--
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24365
___
Raymond Hettinger added the comment:
The C version should defend itself against any key-changes during iteration
(see the state counter used in deque objects for an example of how to do this).
The pure python version of OrderedDict has only minimal defenses against
mutating during
Roundup Robot added the comment:
New changeset 38ffea158630 by Eric Snow in branch '3.5':
Issue #24368: Support keyword arguments in OrderedDict methods.
https://hg.python.org/cpython/rev/38ffea158630
--
nosy: +python-dev
___
Python tracker
Changes by Eric Snow ericsnowcurren...@gmail.com:
--
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24368
___
R. David Murray added the comment:
Since the email package has the correct logic for handling the blank
continuation line case (even in Python2) (because, again, that derives from the
original email standard), it might be reasonable to use feedparser's
headersonly mode. If necessary we can
Eric Snow added the comment:
Sounds good. Thanks, Raymond.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24369
___
___
Python-bugs-list
Roundup Robot added the comment:
New changeset d11cb1218489 by Yury Selivanov in branch '3.5':
Issue 24342: No need to use PyAPI_FUNC for _PyEval_ApplyCoroutineWrapper
https://hg.python.org/cpython/rev/d11cb1218489
New changeset b83fbc13ae1e by Yury Selivanov in branch 'default':
Issue 24342:
New submission from Eric Snow:
How well does OrderedDict need to behave in the face of keys with unstable
hashes (e.g. define __hash__ with varying results across calls)? I would
expect the behavior to be undefined (though non-crashing). Here's an example
of a misbehaving key:
class
Antoine Pitrou added the comment:
I don't know how acceptable it is to add a return value to Py_Finalize(). Can
it break the stable ABI?
--
nosy: +loewis, steve.dower
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5319
New submission from Stefan Krah:
I tried to disprove my own claim of unreachable code in resize()/get_index()
using a convoluted threaded test case.
The code still fails to be reached, but another segfault turned up.
--
components: Extension Modules
files: crash-th.py
messages: 244661
Josh Rosenberg added the comment:
Blech, typo earlier since they produce the *compressed* data (likely useless)
when read as subprocess stdin. Context should make it obvious, but trying to
be clear.
--
___
Python tracker rep...@bugs.python.org
Christian Heimes added the comment:
The patch has a couple of issues
1) match_hostname()'s doc string needs to be updated. It still contains but IP
addresses are not accepted for *hostname*
2) The stdlib uses server_hostname for SNI and matching. An IP address in the
SNI TLS extension
Nick Coghlan added the comment:
Adding the --disable-pip-version-check option doesn't make the warning go
away, and apparently the already passed --no-index flag is supposed to imply
that one anyway:
==
--disable-pip-version-check
Don't periodically check PyPI to
Stefan Krah added the comment:
It's fine to open other issues, but I'm not happy with the resize()/get_index()
situation. Currently I can't come up even with an informal proof that it'll
always work (and see #24361).
I think these functions really *need* 100% code coverage.
--
Roundup Robot added the comment:
New changeset f39e9bcd789b by Donald Stufft in branch '3.5':
Merge the fix for #24267
https://hg.python.org/cpython/rev/f39e9bcd789b
New changeset 6dffea6134ad by Donald Stufft in branch 'default':
Merge the fix for #24267
Roundup Robot added the comment:
New changeset aaa015dde686 by Donald Stufft in branch '3.4':
Closes #24267 - Does not check version on ensurepip uninstall
https://hg.python.org/cpython/rev/aaa015dde686
--
nosy: +python-dev
resolution: - fixed
stage: - resolved
status: open - closed
Eric Snow added the comment:
Addressing the concerns with resize()/get_index() is next on my list. I had
meant to open up an issue on it last night but it was getting pretty late for
me and it slipped my mind. I've opened issue24362 to track that work.
--
New submission from Eric Snow:
Between comments on issue16991 and review comments there, it's clear that the
implementation of _odict_resize and _odict_get_index in Objects/odictobject.c
are too complicated to be a long-term solution. simplifying the approach to
avoid recursion should help
Steve Dower added the comment:
Going from void to int is fine for when the return value is ignored. However,
those who check the return value will see garbage on earlier versions.
As always, safest to add a new function here. Or make the stable version
continue to be void - it won't affect
Ian Cordasco added the comment:
Also I'm marking this as affecting 3.3, 3.4, and 3.5. I haven't tested against
3.5, but it definitely fails on 3.4. I hope to be able to test against 3.5.0b2
tonight
--
versions: +Python 3.3, Python 3.4, Python 3.5
Roundup Robot added the comment:
New changeset 02d214716367 by Donald Stufft in branch '2.7':
Issue #24267 - Ensure that pip version check is disabled on uninstall
https://hg.python.org/cpython/rev/02d214716367
--
___
Python tracker
Ian Cordasco added the comment:
FWIW, the proper section to reference now is 3.2 in RFC 7230
(https://tools.ietf.org/html/rfc7230#section-3.2)
--
nosy: +icordasc
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24363
New submission from Michael Del Monte:
Initially reported at https://github.com/kennethreitz/requests/issues/2622
Closely related to http://bugs.python.org/issue19996
An HTTP response with an invalid header line that contains non-blank characters
but *no* colon (contrast
R. David Murray added the comment:
The current behavior probably comes out of the RFC822 world, where when seeing
a line that doesn't look like a header the error recovery is to treat that line
as the beginning of the body (ie: assume the blank line is missing).
Is there in fact any guidance
New submission from R. David Murray:
This is a note to myself. While looking at another issue I noticed that I
never completed the work to make sure that all message defects discovered by
feedparser are passed through the policy defect handler. The fix is simple,
the time consuming part is
Michael Del Monte added the comment:
Thanks. Also I meant to have said, ...to terminate only on a *blank*
non-header non-comment line, in accordance with RFC 2616 (and 7230).
I note that the RFCs require CRLF to terminate but in my experience you can get
all manner of blank lines, so
Felipe added the comment:
Regarding Claudiu's comment about `staticmethod(x)` or `classmethod(x)` not
being callable, would it suffice to add a specific check of the form
`(isinstance(x, (classmethod, staticmethod)) and _callable(x.__func__))`?
Separately, would it be better to include the
Changes by R. David Murray rdmur...@bitdance.com:
--
components: +email
keywords: +easy
nosy: +barry
stage: - needs patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24363
___
R. David Murray added the comment:
Ah, in fact that's exactly where it comes from, since httplib uses the email
header parsing code. In python3 we are actually using the email package to
parse the headers (which is sensible) (in 2.7 it is a copy of code from the old
mimelib with some
Terry J. Reedy added the comment:
The patch is two lines, but I do not know our general policy for working around
bugs in external modules. I do know that Idle has workarounds for tk bugs (or
'os-dependencies').
--
___
Python tracker
Eric Snow added the comment:
https://hg.python.org/cpython/rev/5c4ba50f6a57
I'll see if that does it.
@Larry, would you be opposed to dropping the hack for beta 3? That would mean
just deleting the last 2 lines in Lib/importlib/_bootstrap_external.py.
--
R. David Murray added the comment:
I believe that in general we do do workarounds if they don't make the code too
complicated and upstream hasn't solved the problem (or we need to support older
upstream versions).
--
nosy: +r.david.murray
___
New submission from Matthias Bussonnier:
The argparse Namespace can be missleading in case where the args names are not
valid identifiers, eg thinks like a closing bracket:
In [5]: Namespace(a=1, **{')':3})
Out[5]: Namespace()=3, a=1)
more funny:
In [3]: Namespace(a=1, **{s:3})
Out[3]:
Ned Deily added the comment:
All of the 3.x buildbots are broken again due to the pip 7.0.3 update.
==
FAIL: test_with_pip (test.test_venv.EnsurePipTest)
--
Ned Deily added the comment:
This is covered by Issue24267; let's track it there.
--
nosy: +ned.deily
resolution: - duplicate
stage: - resolved
status: open - closed
superseder: - test_venv.EnsurePipTest.test_with_pip triggers version check
over network
89 matches
Mail list logo
