[issue12885] distutils.filelist.findall() fails on broken symlink in Py2.x

Éric Araujo added the comment: Patch looks good and would fix the reported problem. Being a backport from setuptools also gives confidence. Does the patch change the behaviour for the handling of the MANIFEST file (not MANIFEST.in)? My previous message mentions that the docs say that one

[issue23639] Not documented special names

Raymond Hettinger added the comment: > I think most of these are either implementation details > or "private" names, so there is no need to document them. Also, we want to be careful to not guarantee implementation details that are subject to change. Most of these are not intended for users

[issue24934] django_v2 benchmark not working in Python 3.6

Florin Papa added the comment: The Django 1.8 archive that I attached is not patched, it is downloaded from the django github page without modifications. I have tested and Django 1.8 works with the latest Python version pulled from hg.python.org/cpython. --

[issue24966] shutil.get_terminal_size() throws ValueError if stdout is detached, no fallback

Roberto Sánchez added the comment: In my case, I modify the stdout but the error was thrown by a third party (click lib), I need to overwrite the stdout because the program has a CLI and the locale env in the terminal seems to be wrong: codecs.lookup(locale.getpreferredencoding()).name ==

[issue24912] The type of cached objects is mutable

Nathaniel Smith added the comment: On further thought, here's a slightly improved version of the patch I posted above. The difference is that the first version allowed through attempted __class__ assignments where either the old or new class was a subclass of ModuleType; the new version only

[issue24975] Python 3.5 can't compile AST involving PEP 448 unpacking

Yury Selivanov added the comment: Good find, David. Thanks! Please review the attached patch. -- keywords: +patch nosy: +benjamin.peterson, larry, ncoghlan, serhiy.storchaka, yselivanov priority: normal -> release blocker stage: -> patch review versions: +Python 3.6 Added file:

[issue24931] _asdict breaks when inheriting from a namedtuple

Eric Snow added the comment: Doesn't the fix mean that `vars(MyNamedtuple)` will no longer work? While I personally don't mind (though I prefer that spelling) and appreciate the benefit of simpler code, isn't there a backward-compatibility issue here? I do concede that fixing this bug

[issue24968] Python 3 raises Unicode errors with the xxx.UTF-8 locale

R. David Murray added the comment: I believe there is at least one open issue about Python adopting utf8 as the default instead of ASCII, and in any case, several conversations about how to deal with all this better. This is just one example of a class of issues caused by the ASCII/C posix

[issue24966] shutil.get_terminal_size() throws ValueError if stdout is detached, no fallback

R. David Murray added the comment: So, the problem is needing to compensate for a broken (according to posix) locale setup. I don't think quieting get_terminal_size is necessarily the answer here. See issue 19846 for more than you want to know about the ASCII locale issue. See also issue

[issue24969] functools.lru_cache: a way to set decorator arguments at runtime

New submission from Marek Otahal: I'd like to use @lru_cache in a library. The problem is I can't know the optimal values for 'maxsize', I need to set them at runtime. I came with 2 possibilities: 1/ set cache's size from a hardcoded argument of the decorated method: @lru_cache def

[issue24969] functools.lru_cache: a way to set decorator arguments at runtime

R. David Murray added the comment: How is (1) different from: @lru_cache(maxsize=1000) def foo_long(self, arg1...) As for computing it at runtime: if you need to compute it, you can compute it and *then* define the decorator wrapped function. -- nosy: +r.david.murray

[issue24969] functools.lru_cache: a way to set decorator arguments at runtime

Marek Otahal added the comment: Hope this example is not too confusing, it's a patch to my code and lru_cache (backport for python 2.7 from ActiveState) It implements both approaches as highlighted above, and in the test both of them are used (that does not make much sense, normally one would

[issue24969] functools.lru_cache: a way to set decorator arguments at runtime

Marek Otahal added the comment: Hi David, > How is (1) different from: @lru_cache(maxsize=1000) def foo_long(self, arg1...) As I mentioned, for use in a library that is called by end-users. They can call functions and modify params, but do not edit the code. It's up to me (lib devs) to

[issue24969] functools.lru_cache: a way to set decorator arguments at runtime

Marek Otahal added the comment: EDIT: > i.foo_long(1337) ofc, this should be: i.foo_long('hi', cacheSize=1337) or for (2): class MyLib(): def __init__(arg1, arg2): self._cacheSize = someComputation(arg1, arg2) # returns a number @lru_cache def foo_long(self, arg1, **kwds):

[issue24966] shutil.get_terminal_size() throws ValueError if stdout is detached, no fallback

Roberto Sánchez added the comment: Thank you for the references, changing the encoding of an open stream sounds interesting, but It's targeted for v. 3.6 so It seems a bit far away. Anyway, as I said I fixed on my side with monkey-patching on the third-party lib, the broken locale is just the

[issue22798] time.mktime doesn't update time.tzname

Akira Li added the comment: The C code produces correct values according to the tz database. If TZ=Europe/Moscow then tzname={"MSK", "MSD"} at 2010-07-01 and tzname={"MSK", "MSK"} at 2015-07-01. Notice the difference! The code calls C mktime() with corresponding time tuples and checks that

[issue24934] django_v2 benchmark not working in Python 3.6

Brett Cannon added the comment: Hmm, strange. I downloaded Django 1.8.latest myself and placed it and I still got the getargspec() failure using the default branch. I'll try again and verify that it wasn't something odd on my end. -- ___ Python

[issue24967] add errors='ignore' to print kwargs

Brett Cannon added the comment: I agree with Serhiy that this isn't print's job to worry about. It's better to be explicit than implicit and trying to cram worrying about decoding errors conflates what print does. I'm closing as "rejected". Thanks for the suggestion, though, Lukáš.

[issue24970] Make distutils.Command an ABC

New submission from Antony Lee: Currently, distutils.Command is a "hand-written" ABC; i.e. direct instantiaion or calling the "abstract" methods initialize_options, run and finalize_options raises a RuntimeError saying that the method (not named in the error message, which is thus a little

[issue24971] os.environ.get() does not return the Environment Value in Linux

New submission from Francis Greaves: I am running an up to date Gentoo Linux x86_64. using Python 2.7 I have an environment variable defined, so from the command line 'echo $XRIT_DECOMPRESS_PATH' gives '/usr/local/bin/xRITDecompress' however, in a Python script, 'cmd =

[issue22798] time.mktime doesn't update time.tzname

Alexander Belopolsky added the comment: > C tzname changes on my machine after the corresponding C mktime() calls Did you run the code that I posted? If not - please do and report the results. (I think there is a valid issue behind all this, but you are not helping to reveal it. I suspect

[issue24971] os.environ.get() does not return the Environment Value in Linux

eryksun added the comment: Did you mark the variable for export in your shell? For example: $ v=1 $ python -c 'import os;print os.environ.get("v")' None $ export v $ python -c 'import os;print os.environ.get("v")' 1 -- nosy: +eryksun

[issue24971] os.environ.get() does not return the Environment Value in Linux

Francis Greaves added the comment: I have the environment variable in my .bashrc file. Interestingly if I do 'os.environ.get("PATH")' it returns the correct value for $PATH. This is also defined in my .bashrc file, so it should be exported. I have exported it manually from the command line, but

[issue24971] os.environ.get() does not return the Environment Value in Linux

Francis Greaves added the comment: Sorry my error I should have said cmd = os.environ.get('XRIT_DECOMPRESS_PATH')' gives 'None' as the output -- ___ Python tracker

[issue24969] functools.lru_cache: a way to set decorator arguments at runtime

R. David Murray added the comment: There is no patch/example attached. It seems like what you really want is an API on lru_cache for updating the cache size. What I'm saying is that the cache size can be passed in on the MyLib call, and the decorator/function constructed as part of MyLib's

[issue24972] IDLE: revisit text highlighting for inactive windows on win32

New submission from Mark Roseman: This is a followup to #14146 I don't think this is actually a Tk bug. The text widget supports an "inactiveselectbackground" option which controls the background color of the selection when the window is not active. On Win32, this is defined as empty (i.e.

[issue24966] shutil.get_terminal_size() throws ValueError if stdout is detached, no fallback

R. David Murray added the comment: Yeah, I think I was thinking of issue 19846, which was fixed by using surrogateescape on the standard streams instead of "guessing" utf-8. I'm not utterly opposed to turning the ValueError into a default return value, but as you can see, the fact that the

[issue24971] os.environ.get() does not return the Environment Value in Linux

R. David Murray added the comment: Well, it works fine for us (I'm on Gentoo as well). os.environ is a pretty thin wrapper around the os functions, so I'm not sure what to suggest as far as debugging why it isn't working for you. Did you try exactly eryksun's example yourself? --

[issue24971] os.environ.get() does not return the Environment Value in Linux

Francis Greaves added the comment: erykson's example works perfectly. I have a script as follows #!/bin/python # import os cmd = os.environ.get('XRIT_DECOMPRESS_PATH') print cmd resulting in 'None' and if I substitute this line cmd = os.environ.get('PATH') resulting in

[issue24971] os.environ.get() does not return the Environment Value in Linux

R. David Murray added the comment: That means you just haven't exported it properly. There is nothing wrong with Python here, as demonstrated by the fact that you were able to run eryksun's example (which is equivalent to your script). -- resolution: -> not a bug stage: -> resolved

[issue24973] CFLAGS for Visual Studio

New submission from Chris Hogan: This Visual Studio project change appends to the compiler flags any values in the CFLAGS environment variable. -- components: Build, Windows files: addcflags3_5.patch keywords: patch messages: 249427 nosy: christopher.hogan, paul.moore, r.david.murray,

[issue24973] CFLAGS for Visual Studio

Changes by Chris Hogan : Added file: http://bugs.python.org/file40309/addcflags2_7.patch ___ Python tracker ___

[issue24974] ICC on Windows 8.1: _decimal fails to compile without /fp:strict

New submission from Zachary Ware: When building on Windows 8.1 with ICC 15.0 (backed by VS 2015 Community), the _decimal module fails to compile: ClCompile: mpdecimal.c ..\Modules\_decimal\libmpdec\mpdecimal.c(46): error : fenv_access cannot be enabled except in precise, source, double, and

[issue24973] CFLAGS for Visual Studio

Steve Dower added the comment: The patch should just set it once in pyproject.props, not in each project. Why is this necessary? Is there an option we should be exposing in some other way? -- ___ Python tracker

[issue24973] CFLAGS for Visual Studio

Zachary Ware added the comment: The real driver for this is having a nice easy way to pass '/fp:strict' to icl.exe (ICC's cl.exe). There may be other things that would be nice to be able to pass easily for customization. -- ___ Python tracker

[issue24973] CFLAGS for Visual Studio

Changes by Zachary Ware : -- stage: -> patch review type: -> enhancement versions: +Python 3.6 ___ Python tracker ___

[issue24949] Identifier lookup in a multi-level package is flakey

Bob Hossley added the comment: msg<249269> Thank you David Murray. I should have asked myself, what is reasonable behavior? In the case of email.mime.nonmultipart an explicit import is clearly needed. I was misled by my experience with the os library. As a "package" it is very different

[issue24949] Identifier lookup in a multi-level package is flakey

Bob Hossley added the comment: msg249272 Thank you Martin Panter for the documentation URL's. The import machinery is so complicated that I have given up trying to understand what is "correct" behavior.Depending on the code in the relevant __init__.py and/or explicitly referenced Python

[issue24973] CFLAGS for Visual Studio

Steve Dower added the comment: I assume you're referring to #24974? The default (for MSVC) is /fp:precise, which should allow fenv_access, but maybe ICL uses /fp:fast by default for the extra speed? It's not a safe 3.5 change now, but compiling with /fp:fast by default and using #pragma

[issue24974] ICC on Windows 8.1: _decimal fails to compile without /fp:strict

Steve Dower added the comment: It should be defaulting to precise mode, but maybe ICC has a different default? I wrote on #24973: It's not a safe 3.5 change now, but compiling with /fp:fast by default and using #pragma float_control(precise, push)/#pragma float_control(pop) around that

[issue24966] shutil.get_terminal_size() throws ValueError if stdout is detached, no fallback

Roberto Sánchez added the comment: I totally agree, on the other hand, if the detach() method can cause that some core methods like shutil.get_termina_size() raise an exception then I think that should be warned in the doc of detach(). In all places that I've seen, the detach() method is used

[issue23406] interning and list comprehension leads to unexpected behavior

Matheus Vieira Portela added the comment: Does anyone else think the note should be expanded? For me, it seems to be pretty accurate although it may indeed be confusing to beginners. If anything, I can work on rewriting it to be more explanatory. -- nosy: +matheus.v.portela

[issue18697] Unify arguments names in Unicode object C API documentation

Matheus Vieira Portela added the comment: Just checking, it would be required to update Objects/unicodeobject.c, Include/unicodeobject.h, and Doc/c-api/unicode.rst, right? As far as I saw, "unicode" means a Python object with unicode string, "u" is a UTF-8 encoded C string, "str" and "s" are

[issue24912] The type of cached objects is mutable

Nathaniel Smith added the comment: Actually, I fail at grep, and actually there are already tons of good tests for __bases__ assignment in test_descr.py. So, patch attached, and analysis follows. Background on __class__ assignment -- While it's certainly

[issue22555] Tracking issue for adjustments to binary/text boundary handling

Nick Coghlan added the comment: For historical purposes, also linking the change in issue #19977 to enable surrogateescape by default on stdin and stdout when the OS claims the locale encoding is ASCII. -- dependencies: +Use "surrogateescape" error handler for sys.stdin and sys.stdout

[issue23993] Use surrogateescape error handler by default in open() if the LC_CTYPE locale is C at startup

Nick Coghlan added the comment: I found this discussion again while looking for issue #19977 to reference from issue #24968. "fixed" wasn't the right resolution, so I've moved it to "postponed" - the SSH locale forwarding problem highlighted again in #24968 means I think there's a discussion

[issue24968] Python 3 raises Unicode errors with the xxx.UTF-8 locale

Nick Coghlan added the comment: Looking again at the *specific* bug report here, I'm moving the resolution to "out of date", as it's actually the one we addressed in 3.5 by enabling surrogateescape by default on all of the standard streams when the OS claims the locale encoding is ASCII, not

[issue24975] Python 3.5 can't compile AST involving PEP 448 unpacking

New submission from David Beazley: The compile() function is not able to compile an AST created from code that uses some of the new unpacking generalizations in PEP 448. Example: code = ''' a = { 'x':1, 'y':2 } b = { **a,

[issue24966] shutil.get_terminal_size() throws ValueError if stdout is detached, no fallback

R. David Murray added the comment: "After the raw stream is detached, the buffer is in an unusable state" pretty much says everything that needs to be said, doesn't it? It certainly seems like anything more does not belong in the detach docs. A mention could possibly be added to the

[issue23406] interning and list comprehension leads to unexpected behavior

R. David Murray added the comment: Interesting. I usually start with a project's FAQ because I find they usually give me an overview of the project and an indication of its quality :) The footnote looks very explanatory to me already (complete with examples). The 'confusing to beginners'

[issue24968] Python 3 raises Unicode errors with the xxx.UTF-8 locale

New submission from Roberto Sánchez: System: Python 3.4.2 on Linux Fedora 22 This issues is strongly related with: http://bugs.python.org/issue19846 But It isn't exactly the same case. When I connect from my Mac OSX (using Terminal.app) to a Linux host with Fedora through ssh, the terminal

[issue24968] Python 3 raises Unicode errors with the xxx.UTF-8 locale

STINNER Victor added the comment: It's not a bug on Python, but a bug on your system. > New submission from Roberto Sánchez: >     [rob@fedora22 ~]$ locale >     locale: Cannot set LC_CTYPE to default locale: No such file or directory This message means that the chosen locale doesn't exist. >

[issue24912] The type of cached objects is mutable

Marc-Andre Lemburg added the comment: On 31.08.2015 10:44, Nathaniel Smith wrote: > Before anyone panics about security issues, do keep in mind that the patch > you're talking about reverting fixed a buffer overflow which I strongly suspect could be used to accomplish arbitrary code execution.

[issue24912] The type of cached objects is mutable

Marc-Andre Lemburg added the comment: On 31.08.2015 11:55, Antoine Pitrou wrote: > > __class__ assignment can definitely be useful for monkey-patching, or other, > purposes. The feature certainly has its place for user defined types (see the unpickle example), but I don't think we should

[issue24968] Python 3 raises Unicode errors with the xxx.UTF-8 locale

Changes by Serhiy Storchaka : -- nosy: +lemburg, loewis, ncoghlan, serhiy.storchaka ___ Python tracker ___

[issue24912] The type of cached objects is mutable

Serhiy Storchaka added the comment: I agree with Nathaniel, that this bug is not so critical to be release blocker. While it definitely should be fixed, it may wait for 3.5.1. Bug reproducing is not data driven, it needs executing special Python code, and when arbitrary Python code execution

[issue24912] The type of cached objects is mutable

Marc-Andre Lemburg added the comment: I agree with Mark. This feature opens up a security hole large enough to drive a train through. Looking at the python-dev thread, the only motivation appears to be making module look more like classes. I'd suggest to propose a PEP for making changes to

[issue24912] The type of cached objects is mutable

Nathaniel Smith added the comment: I need to get to bed so I'll finish up tomorrow, but FYI I have a working patch -- I just want to add some __bases__ assignment test cases to make Larry happy. (Apparently there are no test cases for __bases__ assignment at all currently... :-(.) Before

[issue24966] shutil.get_terminal_size() throws ValueError if stdout is detached, no fallback

Roberto Sánchez added the comment: I've added a new issue: http://bugs.python.org/issue24968 that is related with this one, because is the root cause to modify the stdin/stdout streams. -- ___ Python tracker

[issue22798] time.mktime doesn't update time.tzname

Akira Li added the comment: > C mktime itself should not change timezone globals, but it may indirectly if > it calls tzset() and TZ changed between calls. You should have run the attached test_mktime_changes_tzname.c which demonstrates that (at least on some systems) C mktime *does* change

[issue24912] The type of cached objects is mutable

Antoine Pitrou added the comment: __class__ assignment can definitely be useful for monkey-patching, or other, purposes. -- ___ Python tracker ___

[issue24967] add errors='ignore' to print kwargs

Serhiy Storchaka added the comment: print() doesn't encode characters. It just writes string representation of arguments to output text file (sys.stdout by default). It is the output file is responsible for encoding (or is not, if it saves or passes further a text directly, as StringIO).

[issue24967] add errors='ignore' to print kwargs

New submission from Lukáš Němec: Please add errors='...' to print's kwargs and pass it to codecs that are called from print. Sometimes you have undecodable/unencodable characters that you want to remove from the printed text. Now you need to call 'mytext'.encode('enc',

[issue24974] ICC on Windows 8.1: _decimal fails to compile with default fp model

Changes by Zachary Ware : -- nosy: +christopher.hogan title: ICC on Windows 8.1: _decimal fails to compile without /fp:strict -> ICC on Windows 8.1: _decimal fails to compile with default fp model ___ Python tracker

[issue23406] interning and list comprehension leads to unexpected behavior

Steven D'Aprano added the comment: Which note are you referring to? There are at least two mentioned in this thread, the FAQ and a footnote in the docs for stdtypes. If you're referring to the table of operations just below these:

[issue24969] functools.lru_cache: a way to set decorator arguments at runtime

Changes by Raymond Hettinger : -- assignee: -> rhettinger nosy: +rhettinger versions: +Python 3.6 ___ Python tracker ___

[issue24912] The type of cached objects is mutable

Nathaniel Smith added the comment: Mark Shannon wrote: > So, just make sure that you insert the new object into sys.modules *before* > doing any imports or calls to code that could import your module and it will > all work fine. The problem with doing this is that you're now stuck managing

[issue24969] functools.lru_cache: a way to set decorator arguments at runtime

Raymond Hettinger added the comment: > The problem is I can't know the optimal values for 'maxsize', > I need to set them at runtime. The easiest way to go is to wait to start caching until you know the cache size you want: def foo(a, b, c): pass size = get_user_request()

[issue23406] interning and list comprehension leads to unexpected behavior

Matheus Vieira Portela added the comment: I was referring to the table of operations. So, what if I replace "n shallow copies of s concatenated" by "repeat s n times and concatenate (to create a multidimensional list, refer to [link to FAQ])"? --

[issue24975] Python 3.5 can't compile AST involving PEP 448 unpacking

Nick Coghlan added the comment: Patch looks good to me. I was initially going to query the changes to the break/continue AST tests, but then realised they were needed to avoid a compile error for break/continue outside a loop now that we ensure the resulting AST can be used to generate code.

[issue24912] The type of cached objects is mutable

Serhiy Storchaka added the comment: What if just add settable __class__ property in ModuleType? -- ___ Python tracker ___

[issue24975] Python 3.5 can't compile AST involving PEP 448 unpacking

Larry Hastings added the comment: Good catch! Please file a pull request via bitbucket. -- ___ Python tracker ___

[issue24912] The type of cached objects is mutable

Serhiy Storchaka added the comment: The first time this bug was discovered in issue23726. -- ___ Python tracker ___

[issue24973] CFLAGS for Visual Studio

Zachary Ware added the comment: Steve Dower wrote: > I assume you're referring to #24974? It's somewhat related, yes, but I didn't intend for the two issues to be tightly coupled. Both should be dealt with independently of each other. > The default (for MSVC) is /fp:precise, which should

[issue24829] Use interactive input even if stdout is redirected

Raymond Hettinger added the comment: I recommend this feature request be rejected. The current behavior has been in place for a long time. Changing it may cause more harm than good (especially if the behavior between operating systems becomes more divergent). -- nosy: +rhettinger

[issue24912] The type of cached objects is mutable

Changes by Serhiy Storchaka : -- nosy: +eltoder ___ Python tracker ___ ___

[issue22798] time.mktime doesn't update time.tzname

Alexander Belopolsky added the comment: > You should have run the attached test_mktime_changes_tzname.c ... I did run it and tried several times to understand what it does. It did not help. If you claim that calling mktime() changes the value of the global tzname variable, you should be

[issue24968] Python 3 raises Unicode errors with the xxx.UTF-8 locale

Roberto Sánchez added the comment: OK, I already knew that "It is not a bug", but the scenario seems quite common, connection to a Linux host from a Mac with Terminal.app and different locales (default behavior), so a bit of "magic" when the locale's encoding part is correct would help to

[issue24968] Python 3 raises Unicode errors with the xxx.UTF-8 locale

Nick Coghlan added the comment: CPython inherits this behaviour from glibc's locale handling, so it's potentially worth raising the question further upstream. If anyone wanted to pursue that, looking at http://www.gnu.org/software/libc/development.html suggests to me that the appropriate

[issue22798] time.mktime doesn't update time.tzname

Changes by Alexander Belopolsky : -- nosy: +pitrou ___ Python tracker ___ ___