[issue26637] importlib: better error message when import fail during Python shutdown

2016-03-25 Thread Roundup Robot
Roundup Robot added the comment: New changeset e2c482b60776 by Victor Stinner in branch 'default': Issue #26637: Fix test_io https://hg.python.org/cpython/rev/e2c482b60776 -- ___ Python tracker

[issue25654] test_multiprocessing_spawn ResourceWarning with -Werror

2016-03-25 Thread Roundup Robot
Roundup Robot added the comment: New changeset 9faa03e9cea8 by Victor Stinner in branch 'default': Issue #25654: https://hg.python.org/cpython/rev/9faa03e9cea8 -- nosy: +python-dev ___ Python tracker __

[issue25654] test_multiprocessing_spawn ResourceWarning with -Werror

2016-03-25 Thread STINNER Victor
STINNER Victor added the comment: I pushed a change based on multiprocessing_no_close_fd.patch. I changed multiprocessing.util._close_stdin() to try to replace sys.stdin with os.devnull even if stdin.close() raised an exception. Since stdin is read-only, I don't expect an exception on stdin.cl

[issue21925] ResourceWarning sometimes doesn't display

2016-03-25 Thread Roundup Robot
Roundup Robot added the comment: New changeset 307ba4afd0a6 by Victor Stinner in branch 'default': Issue #21925: Fix test_warnings for release mode https://hg.python.org/cpython/rev/307ba4afd0a6 -- ___ Python tracker

[issue25951] SSLSocket.sendall() does not return None on success like socket.sendall()

2016-03-25 Thread Aviv Palivoda
Aviv Palivoda added the comment: Thanks for the review. I don't have any use cases for this change. I just saw this issue while looking for something else and thought I will give it a try. -- Added file: http://bugs.python.org/file42285/25951-2.patch ___

[issue21925] ResourceWarning sometimes doesn't display

2016-03-25 Thread Roundup Robot
Roundup Robot added the comment: New changeset f474898ef6de by Victor Stinner in branch '3.5': Issue #21925: Fix test_warnings for release mode https://hg.python.org/cpython/rev/f474898ef6de -- ___ Python tracker _

[issue26161] Use Py_uintptr_t instead of void* for atomic pointers

2016-03-25 Thread Roundup Robot
Roundup Robot added the comment: New changeset b1666037c97e by Victor Stinner in branch '3.5': Use Py_uintptr_t for atomic pointers https://hg.python.org/cpython/rev/b1666037c97e -- ___ Python tracker _

[issue25654] test_multiprocessing_spawn ResourceWarning with -Werror

2016-03-25 Thread Roundup Robot
Roundup Robot added the comment: New changeset 357d1ed928fe by Victor Stinner in branch '3.5': Issue #25654: https://hg.python.org/cpython/rev/357d1ed928fe -- ___ Python tracker

[issue25654] test_multiprocessing_spawn ResourceWarning with -Werror

2016-03-25 Thread STINNER Victor
STINNER Victor added the comment: > The change should be backported to Python 3.5. I'm waiting for buildbots and > I have to read again the change later. Oh, I didn't notice that 3.5 buildbots were also all red. So I backported the fix immediatly. -- __

[issue25654] test_multiprocessing_spawn ResourceWarning with -Werror

2016-03-25 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: > What do you think? Is it better to keep stdin if stdin.close() raises an > exception? I don't know. I don't know why OSError and ValueError are caught at all. What are you think about deterministic closing standard streams in leanup_std_streams.patch? The

[issue25654] test_multiprocessing_spawn ResourceWarning with -Werror

2016-03-25 Thread STINNER Victor
STINNER Victor added the comment: > I don't know. I don't know why OSError and ValueError are caught at all. Ha ha, me neither. Maybe it's time to remove them an wait for user feedback :-) > What are you think about deterministic closing standard streams in > cleanup_std_streams.patch? There i

[issue25654] test_multiprocessing_spawn ResourceWarning with -Werror

2016-03-25 Thread STINNER Victor
STINNER Victor added the comment: By the way, I'm not sure that using UTF-8/backslashescape is the encoding :-/ It's common to use Latin1 on a terminal. UTF-8 is very rare on Windows for the console for example. -- ___ Python tracker

[issue25654] test_multiprocessing_spawn ResourceWarning with -Werror

2016-03-25 Thread STINNER Victor
STINNER Victor added the comment: ASCII/backslashescape is maybe a better encoding for this printer. -- ___ Python tracker ___ ___ Pyt

[issue25654] test_multiprocessing_spawn ResourceWarning with -Werror

2016-03-25 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Lets open new issue for this. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscr

[issue25654] test_multiprocessing_spawn ResourceWarning with -Werror

2016-03-25 Thread STINNER Victor
STINNER Victor added the comment: Serhiy: > Lets open new issue for this. I agree with PyImport_Cleanup() deserves a dedicated issue. Myself: > This change has two parts. Oops, I forgot to discuss the second part :-) You also added "sys.__stderr__ = sys.stderr" in multiprocessing. I don't un

[issue26639] Tools/i18n/pygettext.py: replace deprecated imp module with importlib

2016-03-25 Thread STINNER Victor
New submission from STINNER Victor: Attached patch replaces the imp module with importlib in Tools/i18n/pygettext.py. Please review carefully, it looks like the code getting the filename of a Python module is not tested by Lib/test/test_tools.py :-/ -- files: pygettext_imp.patch keywo

[issue25654] test_multiprocessing_spawn ResourceWarning with -Werror

2016-03-25 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: > Oops, I forgot to discuss the second part :-) You also added "sys.__stderr__ > = sys.stderr" in multiprocessing. At the start of PyImport_Cleanup() sys.stdXXX is set to sys.__stdXXX__. If sys.stdXXX is not sys.__stdXXX__ and here is the last reference to t

[issue26610] test_venv.test_with_pip() fails when ctypes is missing

2016-03-25 Thread STINNER Victor
STINNER Victor added the comment: I pushed a workaround to limit the number of failures on the OpenIndiana buildbot. Feel free once pip runs without ctypes and pip is updated in CPython. -- ___ Python tracker ___

[issue26610] test_venv.test_with_pip() fails when ctypes is missing

2016-03-25 Thread Roundup Robot
Roundup Robot added the comment: New changeset cd7cb503ab67 by Victor Stinner in branch 'default': Skip test_venv.test_with_pip() if ctypes miss https://hg.python.org/cpython/rev/cd7cb503ab67 -- nosy: +python-dev ___ Python tracker

[issue23551] IDLE to provide menu link to PIP gui.

2016-03-25 Thread Upendra Kumar
Upendra Kumar added the comment: @Terry, I have tried to implement the treeview (as suggested by Alexander) and separate out the functions for retrieving data and displaying data. But, I have doubt on how to separate out the functions for getting data and displaying data. Further, I have chang

[issue20021] "modernize" makeopcodetargets.py

2016-03-25 Thread Berker Peksag
Berker Peksag added the comment: Victor went with a different solution in f682b620c64d. -- nosy: +haypo resolution: -> out of date stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue23551] IDLE to provide menu link to PIP gui.

2016-03-25 Thread Upendra Kumar
Upendra Kumar added the comment: I had just one more idea after carefully going through all the options provided by pip. Other than the features suggested by Raymond, we should also provide option for installing using proxy settings. Sometimes, configuring proxy can also be tricky while downlo

[issue20021] "modernize" makeopcodetargets.py

2016-03-25 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: f682b620c64d looks incorrect to me. It makes makeopcodetargets.py to use the opcode module of Python that executes the script. Instead the script should use the opcode module from the same source tree as the script. I think f682b620c64d should be reverted.

[issue26640] xmlrpc.server imports xmlrpc.client

2016-03-25 Thread ProgVal
New submission from ProgVal: from xmlrpc.client import Fault, dumps, loads, gzip_encode, gzip_decode Shouldn't these class/functions be moved to a new module, with a name like xmlrpc.common? -- components: Library (Lib) messages: 262428 nosy: Valentin.Lorentz priority: normal severity:

[issue26641] doctest doesn't support packages

2016-03-25 Thread STINNER Victor
New submission from STINNER Victor: The PEP 420 -- Implicit Namespace Packages introduces packages which have no __init__.py file and can be made of multiple packages. It looks like doctest doesn't support them. I would like to convert the Lib/test/ of the Python standard library into such pa

[issue26641] doctest doesn't support packages

2016-03-25 Thread STINNER Victor
Changes by STINNER Victor : -- components: +Library (Lib) ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https

[issue26295] Random failures when running test suite in parallel (-m test -j0) caused by test_regrtest

2016-03-25 Thread STINNER Victor
STINNER Victor added the comment: I created the issue #26641 for doctest (test_doctest). -- ___ Python tracker ___ ___ Python-bugs-lis

[issue20021] "modernize" makeopcodetargets.py

2016-03-25 Thread STINNER Victor
STINNER Victor added the comment: > Victor went with a different solution in f682b620c64d. Oh sorry, I wasn't aware of this old issue. My motivation was to get ride of the deprecated imp module, this script looks to be the latest part of the Python which uses the imp module (except of delibera

[issue20021] "modernize" makeopcodetargets.py

2016-03-25 Thread STINNER Victor
STINNER Victor added the comment: issue20021_2.diff looks good to me. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsu

[issue26640] xmlrpc.server imports xmlrpc.client

2016-03-25 Thread SilentGhost
Changes by SilentGhost : -- nosy: +loewis versions: +Python 3.6 -Python 3.4 ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue26588] _tracemalloc: add support for multiple address spaces (domains)

2016-03-25 Thread STINNER Victor
STINNER Victor added the comment: Okay, it looks like all issues have been fixed. The optimization for compact keys has been implemented. I didn't see any crash on buildbots recently, test_tracemalloc pass on all platforms. Nathaniel asked how domains will be "allocated" or "registered", b

[issue26530] tracemalloc: add C API to manually track/untrack memory allocations

2016-03-25 Thread STINNER Victor
STINNER Victor added the comment: tracemalloc_track_fd.py: Proof-of-concept to track file descriptors using monkey-patching on os.open() and os.close(). It's just to show to the API can be used in Python, I don't think that it's very useful to track where file descriptors are allocated. -

[issue26640] xmlrpc.server imports xmlrpc.client

2016-03-25 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Moving public classes and functions to other module can break pickle compatibility. -- nosy: +serhiy.storchaka ___ Python tracker ___ ___

[issue23551] IDLE to provide menu link to PIP gui.

2016-03-25 Thread Aivar Annamaa
Changes by Aivar Annamaa : -- nosy: -Aivar.Annamaa ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue26642] Replace stdout and stderr with simple standard printers at Python exit

2016-03-25 Thread STINNER Victor
New submission from STINNER Victor: The Python shutdown process is complex and fragile. It was discussed in the issue #25654 to replace stdout and stderr with simple "standard printers" (implemented in C, don't depend on other Python objects or modules). Attached patch implements this idea. T

[issue26642] Replace stdout and stderr with simple standard printers at Python exit

2016-03-25 Thread STINNER Victor
Changes by STINNER Victor : -- nosy: +serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue25654] test_multiprocessing_spawn ResourceWarning with -Werror

2016-03-25 Thread STINNER Victor
STINNER Victor added the comment: > Lets open new issue for this. I opened the issue #26642 "Replace stdout and stderr with simple standard printers at Python exit". -- ___ Python tracker

[issue19829] _pyio.BufferedReader and _pyio.TextIOWrapper destructor don't emit ResourceWarning if the file is not closed

2016-03-25 Thread STINNER Victor
STINNER Victor added the comment: > I think we should use one of Martin's option. If there are any issues with > garbage collecting, we should fix the garbage collector. Ok, here is a new simpler proposition: remove all _dealloc_warn() method, and simply emit the ResourceWarning in IOBase fina

[issue19829] _pyio.BufferedReader and _pyio.TextIOWrapper destructor don't emit ResourceWarning if the file is not closed

2016-03-25 Thread STINNER Victor
STINNER Victor added the comment: > For io.BytesIO, I fixed the code to inherit correctly IOBase finalizer. Oh, I forgot to include it in my patch. But it's maybe better to have it in a different patch: see attached bytesio_stringio.patch which changes also io.StringIO to inherit the IOBase fi

[issue19829] _pyio.BufferedReader and _pyio.TextIOWrapper destructor don't emit ResourceWarning if the file is not closed

2016-03-25 Thread STINNER Victor
STINNER Victor added the comment: Ok, I now understand the problem better. They are two kinds of io objects: (1) object which directly or indirectly owns a limited resource like file descriptor => must emit a ResourceWarning (2) object which don't own a limited resource => no ResourceWarning mu

[issue26636] SystemError while running tests: extra exception raised

2016-03-25 Thread Denis
Denis added the comment: Thank you! The error was that some calls in pycrypto code were aggregated and exceptions in those calls were ignored. Here is the patch for pycrypto that fixed the build. @@ -1427,7 +1429,9 @@ getStrongPrime (PyObject *self, PyObject *args, PyObject *kwargs)

[issue26636] SystemError while running tests: extra exception raised

2016-03-25 Thread STINNER Victor
STINNER Victor added the comment: I hope that the exception will help you to write better software (don't loose exceptions) ;-) -- status: open -> closed ___ Python tracker ___

[issue26543] imaplib noop Debug

2016-03-25 Thread Maciej Szulik
Changes by Maciej Szulik : -- nosy: +maciej.szulik ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue26640] xmlrpc.server imports xmlrpc.client

2016-03-25 Thread ProgVal
ProgVal added the comment: Even if xmlrpc.client imported them in its namespace? -- ___ Python tracker ___ ___ Python-bugs-list mailin

[issue26640] xmlrpc.server imports xmlrpc.client

2016-03-25 Thread Brett Cannon
Brett Cannon added the comment: Yes because the location of the object is based on where it's defined, not where you got it from. While I get the motivation to be a little cleaner in the xmlrpc package, "practicality beats purity" here in that the reorg isn't worth it at this point in the fac

[issue26631] Unable to install Python 3.5.1 on Windows 10 - Error 0x80070643: Failed to install MSI package.

2016-03-25 Thread Steve Dower
Steve Dower added the comment: Thanks for the report You should have another log file near the one you attached (in your %LocalAppData%\Temp directory) with "core_JustForMe" in the name. Could you put that one up as well? -- ___ Python tracker

[issue26629] Need an ability to build standard DLLs with distutils

2016-03-25 Thread Steve Dower
Steve Dower added the comment: (Obligatory recommendation that you use Cython rather than ctypes, especially if you're going to require your users to have a compiler handy - in general this isn't recommended on Windows at all; make sure you distribute wheels if you want to make your users' liv

[issue26629] Need an ability to build standard DLLs with distutils

2016-03-25 Thread Steve Dower
Steve Dower added the comment: Oh, and just saw that you're apparently asking about 2.7. I was referring to the 3.5 sources for distutils, so some things may be different in 2.7. But I doubt distutils has changed that much since then. -- ___ Python

[issue26591] datetime datetime.time to datetime.time comparison does nothing

2016-03-25 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: Python 3.6.0a0 (default:245a16f33c4b, Mar 25 2016, 14:11:43) [GCC 4.2.1 Compatible Apple LLVM 7.0.2 (clang-700.1.81)] on darwin Type "help", "copyright", "credits" or "license" for more information. >>> import datetime >>> if datetime.time(22, 15) > datetim

[issue26643] regrtest: rework libregrtest.save_env submodule

2016-03-25 Thread STINNER Victor
New submission from STINNER Victor: (I pushed the change 245a16f33c4b, but Serhiy asked me to review it and discuss it. So I reverted my change and created this issue.) I noticed many times that buildbots log "test xxx changed yyy" but this line is not enough to debug the issue. I propose to a

[issue26616] A bug in datetime.astimezone() method

2016-03-25 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: > When you made your first astimezone() call, (t = u.astimezone()), > it was made without a tzinfo parameter, and should result in t's > timezeone being EST by the documentation. No, u in my test case was selected to be right before the "fall-back" time.

[issue26616] A bug in datetime.astimezone() method

2016-03-25 Thread Alexander Belopolsky
Changes by Alexander Belopolsky : -- stage: patch review -> commit review ___ Python tracker ___ ___ Python-bugs-list mailing list Uns

[issue26616] A bug in datetime.astimezone() method

2016-03-25 Thread Alexander Belopolsky
Changes by Alexander Belopolsky : -- versions: -Python 3.3, Python 3.4 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsub

[issue26643] regrtest: rework libregrtest.save_env submodule

2016-03-25 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Old code looks much clearer to me. Consider your example with the 'sys.path' resource. With current code I need to understand only 3 simple lines of the code in two close methods. With the patch I need to research 4 classes with 16 complicated methods! This

[issue26616] A bug in datetime.astimezone() method

2016-03-25 Thread Roundup Robot
Roundup Robot added the comment: New changeset 361a92204d4a by Alexander Belopolsky in branch '3.5': Issue#26616:Fixed a bug in datetime.astimezone() method. https://hg.python.org/cpython/rev/361a92204d4a -- nosy: +python-dev ___ Python tracker

[issue26616] A bug in datetime.astimezone() method

2016-03-25 Thread Alexander Belopolsky
Changes by Alexander Belopolsky : -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker ___

[issue26616] A bug in datetime.astimezone() method

2016-03-25 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: The fix was applied to default in c9bc6614a652 but I got the commit message wrong. I will not attempt to fix it (not sure it is even possible in hg.) -- ___ Python tracker

[issue19829] _pyio.BufferedReader and _pyio.TextIOWrapper destructor don't emit ResourceWarning if the file is not closed

2016-03-25 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: 1. What if only object which directly owns a limited resource will emit a ResourceWarning? This can break some tests, but may be these tests are too strong? Current GC may be better than when io classes were implemented. 2. An object which indirectly owns a

[issue26642] Replace stdout and stderr with simple standard printers at Python exit

2016-03-25 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: There are some questions. 1. Is there a reason only name is closed, not dunder_name? (Josh's question, but I'm interesting too). 2. Is it worth to first replace standard streams with "standard printers", and then close original streams? This allows to log w

[issue26642] Replace stdout and stderr with simple standard printers at Python exit

2016-03-25 Thread STINNER Victor
STINNER Victor added the comment: Serhiy Storchaka added the comment: > 1. Is there a reason only name is closed, not dunder_name? (Josh's question, > but I'm interesting too). By default, sys.__stdout__ is sys.stdout. Is it ok to close the same file twice? > 2. Is it worth to first replace st

[issue26627] IDLE incorrectly labeling error as internal

2016-03-25 Thread Terry J. Reedy
Terry J. Reedy added the comment: The goal is to match the traceback that Python itself produces with the same code, but it is perhaps an impossible process. The current list goes back to 2003 without tracker issue numbers, so I don't know the reason for each. I worry a bit about the suppress

[issue25654] test_multiprocessing_spawn ResourceWarning with -Werror

2016-03-25 Thread STINNER Victor
STINNER Victor added the comment: I'm not sure why Python 2.7 was in the Versions. I just ran "python2.7 -Werror -m test.regrtest -v test_multiprocessing" => no error. ResourceWarning doesn't exist in Python 2. Is it still something to do on multiprocessing about ResourceWarning? I didn't und

[issue26612] test_ssl: use context manager (with) to fix ResourceWarning

2016-03-25 Thread STINNER Victor
STINNER Victor added the comment: "try: ... finally: s.close()" are "with s: ..." do the same thing, but I prefer "with" (context-manager). IMO it's more "pythonic". I prefer to see the "cleanup block" at the beginning, rather than at the end. > My point about Python 2 was that this might add

[issue26643] regrtest: rework libregrtest.save_env submodule

2016-03-25 Thread STINNER Victor
STINNER Victor added the comment: > Consider your example with the 'sys.path' resource. With current code I need > to understand only 3 simple lines of the code in two close methods. With the > patch I need to research 4 classes with 16 complicated methods! This is awful! I replaced get_sys_pa

[issue25289] test_strptime hangs sometimes on AMD64 Windows7 SP1 3.x buildbot

2016-03-25 Thread STINNER Victor
STINNER Victor added the comment: It looks like the issue was a bug in setlocale() and that it was fixed in Windows! See the issue #26624. -- resolution: -> duplicate status: open -> closed superseder: -> Windows hangs in call to CRT setlocale() __

[issue26624] Windows hangs in call to CRT setlocale()

2016-03-25 Thread STINNER Victor
STINNER Victor added the comment: The issue #25289 has marked as a duplicate of this issue. -- ___ Python tracker ___ ___ Python-bugs-

[issue26624] Windows hangs in call to CRT setlocale()

2016-03-25 Thread STINNER Victor
STINNER Victor added the comment: > It's been fixed, just figuring out when the update will be available, or how > to get it if it already is. Can you elaborate? What was the bug? How was it fixed? Is it a bug in Windows, in Visual Studio or in the C library? -- _

[issue25276] Intermittent segfaults on PPC64 AIX 3.x

2016-03-25 Thread STINNER Victor
STINNER Victor added the comment: The origin of the crash is unknown. Since I didn't see the crash recently, I close the issue. -- resolution: -> out of date status: open -> closed ___ Python tracker

[issue25256] Add sys.debug_build public variable to check if Python was compiled in debug mode

2016-03-25 Thread STINNER Victor
STINNER Victor added the comment: I lost interest in this issue. It really looks like a corner case, so I prefer to keep the current code. I'm not interested to work on the abiflags on Windows. -- resolution: -> out of date status: open -> closed __

[issue26631] Unable to install Python 3.5.1 on Windows 10 - Error 0x80070643: Failed to install MSI package.

2016-03-25 Thread J Osell
Changes by J Osell : Added file: http://bugs.python.org/file42294/Python 3.5.1 (64-bit)_20160323181333_000_core_JustForMe.log ___ Python tracker ___

[issue26631] Unable to install Python 3.5.1 on Windows 10 - Error 0x80070643: Failed to install MSI package.

2016-03-25 Thread J Osell
J Osell added the comment: Done -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mail

[issue25160] Stop using deprecated imp module; imp should now emit a real DeprecationWarning

2016-03-25 Thread STINNER Victor
STINNER Victor added the comment: > Tools/i18n/pygettext.py:159:import imp I opened the issue #26639 for it. >> Python/makeopcodetargets.py:9:import imp > See issue 20021. I pushed the change f682b620c64d but I forgot about the issue #20021. Let's discuss there about this script. > Tools/i

[issue25160] Stop using deprecated imp module; imp should now emit a real DeprecationWarning

2016-03-25 Thread STINNER Victor
Changes by STINNER Victor : -- nosy: +eric.snow ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue22218] Fix more compiler warnings "comparison between signed and unsigned integers"

2016-03-25 Thread STINNER Victor
STINNER Victor added the comment: fix_warning_unicodeobject.diff and issue22218-2.patch don't seem to be needed anymore. The code is now: if (PY_SSIZE_T_MAX / (Py_ssize_t)sizeof(wchar_t) < (size + 1)) return NULL; I close the issue. More specific issues must be opened if you still

[issue26391] typing: Specialized sub-classes of Generic never call __init__

2016-03-25 Thread STINNER Victor
Changes by STINNER Victor : -- title: Specialized sub-classes of Generic never call __init__ -> typing: Specialized sub-classes of Generic never call __init__ ___ Python tracker ___

[issue23886] faulthandler_user should use _PyThreadState_Current

2016-03-25 Thread STINNER Victor
STINNER Victor added the comment: > I want that it marks the current Python thread correctly, and not the current > sighandler thread. Oook, I finally understood your use case. You want to know which threads hold the GIL. You don't care which thread got the signal. -- ___

[issue19829] _pyio.BufferedReader and _pyio.TextIOWrapper destructor don't emit ResourceWarning if the file is not closed

2016-03-25 Thread Martin Panter
Martin Panter added the comment: In the long term, I prefer not calling close() in __del__(), like del-flush.patch, although I admit it is an API change and should probably be limited to 3.6+. If people want to improve things in 3.5, privately implementing _dealloc_warn() like Victor’s pyio_re

[issue20021] "modernize" makeopcodetargets.py

2016-03-25 Thread Roundup Robot
Roundup Robot added the comment: New changeset 6ceceb052394 by Victor Stinner in branch 'default': makeopcodetargets.py: we need to import Lib/opcode.py https://hg.python.org/cpython/rev/6ceceb052394 -- nosy: +python-dev ___ Python tracker

[issue20021] "modernize" makeopcodetargets.py

2016-03-25 Thread STINNER Victor
STINNER Victor added the comment: > Or does it matter to be able to use an external python program? Oh wait, I misunderstood how the script is used. I understood that the script must be run manually only when a new opcode is added and so is rarely used and only used with the built Python progr

[issue22898] segfault during shutdown attempting to log ResourceWarning

2016-03-25 Thread STINNER Victor
STINNER Victor added the comment: warn_5.patch: The patch cannot be reviewed on Rietveld :-( You must not use the git format for diff. warn_5.patch: "if (globals == NULL) { (...) return 0; }" It looks like filename is not initialized. I suggest to use: *filename = f->f_code->co_filename;

[issue25911] Regression: os.walk now using os.scandir() breaks bytes filenames on windows

2016-03-25 Thread Roundup Robot
Roundup Robot added the comment: New changeset 82da02b5bf22 by Victor Stinner in branch 'default': Issue #25911: more info on test_os failure https://hg.python.org/cpython/rev/82da02b5bf22 -- ___ Python tracker ___

[issue25911] Regression: os.walk now using os.scandir() breaks bytes filenames on windows

2016-03-25 Thread STINNER Victor
STINNER Victor added the comment: Update: test_os pass on all Windows buildbots except one! I don't understand why the test fails on this buildbot. http://buildbot.python.org/all/builders/AMD64%20Windows8%203.x/builds/1906/steps/test/logs/stdio =

[issue23886] faulthandler_user should use _PyThreadState_Current

2016-03-25 Thread Albert Zeyer
Albert Zeyer added the comment: Yes exactly. Sorry if I was unclear before. :) I mentioned SIGUSR1/2 because for a segfault, the signal handler will usually be executed in the same thread (although I'm not sure if that is guaranteed), so that was usually not a problem. But I used SIGUSR1 when

[issue26391] typing: Specialized sub-classes of Generic never call __init__

2016-03-25 Thread Guido van Rossum
Guido van Rossum added the comment: Actually, I just realized why this is. Generic.__new__() calls next_in_mro.__new__(_gorg(cls)). Here next_in_mro is just object, but _gorg(cls) is Foo, in the case where cls is Bar (i.e. Foo[str]). The _gorg() call strips the [str] part of the type. So far

[issue26612] test_ssl: use context manager (with) to fix ResourceWarning

2016-03-25 Thread Martin Panter
Martin Panter added the comment: In many cases I prefer “with” over “try / finally”. But Python 2’s sockets do not support “with” statements, so choice (2) is not possible for 2.7. I found one potential technical problem, and maybe some redundant close() calls in the review. -- _

[issue25951] SSLSocket.sendall() does not return None on success like socket.sendall()

2016-03-25 Thread Martin Panter
Martin Panter added the comment: Thanks for your work Aviv. This version looks good to me. -- versions: -Python 3.5 ___ Python tracker ___ __

[issue25654] test_multiprocessing_spawn ResourceWarning with -Werror

2016-03-25 Thread Martin Panter
Martin Panter added the comment: Sorry, but I don’t think I have the time/motivation/expertise to look into the fix in detail. But there are no warnings or failures anymore when I use -Werror, so I am happy! BTW the spurious background processes are still there (visible if you run “ps” or “ps

[issue25987] collections.abc.Reversible

2016-03-25 Thread Guido van Rossum
Guido van Rossum added the comment: Andrew, did you lose interest in this? We now have a PR for typing.py that expects this to be resolved: https://github.com/python/typing/pull/194 -- ___ Python tracker _

[issue23735] Readline not adjusting width after resize with 6.3

2016-03-25 Thread Martin Panter
Martin Panter added the comment: Unfortunately, yes I think another test might be needed in configure.ac, unless you can piggy-back on one of the existing flags. One more thing that I thought of: Looking at the main Python signal handler, it reinstalls itself, see

[issue23551] IDLE to provide menu link to PIP gui.

2016-03-25 Thread Terry J. Reedy
Terry J. Reedy added the comment: gohlke/pythonlibs/: Search will have to use a custom function. If direct download from url by pip does not work, then we write a custom function to download to a temp file and pip install from local file. (This is suggestion on site.) runpip: It would be ni

[issue26624] Windows hangs in call to CRT setlocale()

2016-03-25 Thread Steve Dower
Steve Dower added the comment: Locking inversion I think, I don't have the bug details handy. The fix went out over Windows Update recently, but that's only for the release version of the runtime. The fixed debug version should have been installed with VS 2015 Update 1. However, since it's st

[issue25911] Regression: os.walk now using os.scandir() breaks bytes filenames on windows

2016-03-25 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Some tests were failed on Windows 8 even in 3.4 (issue23808). -- ___ Python tracker ___ ___ Python

[issue20021] "modernize" makeopcodetargets.py

2016-03-25 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thank you Victor. -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker ___ _