[issue26876] Extend MSVCCompiler class to respect environment variables

2016-06-02 Thread Zachary Ware
Zachary Ware added the comment: The patch looks fine to me, but frankly I'm a bit scared to commit anything to distutils :). It would be nice to have tests for this. I'm also not sure if we can backport this to 2.7 and 3.5: this is pretty clearly a new feature, but dips its toes into the

[issue27185] Clarify Test Coverage for the String Module (test_pep292 is not easily discoverable)

2016-06-02 Thread Benjamin Peterson
Benjamin Peterson added the comment: I'm not too concerned about that. git can handle it well, which we will have soon. On Thu, Jun 2, 2016, at 12:50, Serhiy Storchaka wrote: > > Serhiy Storchaka added the comment: > > This is not so easy. After adding all the tests from test_pep292.py into >

[issue27181] Add geometric mean to `statistics` module

2016-06-02 Thread Raymond Hettinger
New submission from Raymond Hettinger: Steven, this seems like a reasonable suggestion (though I would expect someone else will immediately suggest a harmonic mean as well). Is this within the scope of what you were trying to do with the statistics module? -- assignee: ->

[issue27113] sqlite3 connect parameter "check_same_thread" not documented

2016-06-02 Thread Dave Sawyer
Dave Sawyer added the comment: The user probably has a recent enough version. This is guaranteed on Windows since Python bundles 3.6 or later. On mac or Linux it will use the version installed on the machine. I'll make a separate patch to check the version in sqlite3.py so it will give an

[issue19611] inspect.getcallargs doesn't properly interpret set comprehension code objects.

2016-06-02 Thread Nick Coghlan
Changes by Nick Coghlan : -- assignee: -> ncoghlan nosy: +ncoghlan ___ Python tracker ___

[issue26829] update docs: when creating classes a new dict is created for the final class object

2016-06-02 Thread Emily Morehouse
Emily Morehouse added the comment: Second version of patch for this -- more clearly states the process and outcome for class creation. Also adds to https://docs.python.org/3.6/library/functions.html#type to clarify that the dictionary object is copied to a standard dict. -- Added

[issue19611] inspect.getcallargs doesn't properly interpret set comprehension code objects.

2016-06-02 Thread R. David Murray
R. David Murray added the comment: Yes, it feels ugly. I'd rather "fix" the source of the problem (the weird positional attribute name). I have no idea if argument clinic would be of any help here, I haven't looked at how these things come to be. --

[issue27113] sqlite3 connect parameter "check_same_thread" not documented

2016-06-02 Thread Senthil Kumaran
Senthil Kumaran added the comment: Dave, your patch looks good to me. Did you see the comment from Trevor on your first patch? >> According to the sqlite docs (http://www.sqlite.org/threadsafe.html), the default mode is 'serialized', which does the necessary locking for threads to share a

[issue27136] sock_connect fails for bluetooth (and probably others)

2016-06-02 Thread A. Jesse Jiryu Davis
A. Jesse Jiryu Davis added the comment: I can reproduce this. On Ubuntu 14.04 I installed "libbluetooth-dev" and then built Python 3.5.1 from source, confirmed the socket module has AF_BLUETOOTH and BTPROTO_RFCOMM. Running pyptr2's script gives the traceback pyptr2 reported. Yury and I

[issue18751] A manager's server never joins its threads

2016-06-02 Thread Gregory P. Smith
Gregory P. Smith added the comment: Capturing some notes from looking at this after Dan Sully asked me questions about the issue during today's pycon sprints: within multiprocessing/managers.py serve_forever(): the accepter thread is an infinite loop. i think this issue also wants to join()

[issue19611] inspect.getcallargs doesn't properly interpret set comprehension code objects.

2016-06-02 Thread Nick Coghlan
Nick Coghlan added the comment: The origin of the ".0" parameter name is the compiler's implicit symbol definition - we use the "." prefix for those to ensure we don't accidentally collide with actual identifiers used in the code. We can see that via dis.dis: >>> def make_set(): ...

[issue16192] ctypes - documentation example

2016-06-02 Thread Eryk Sun
Eryk Sun added the comment: > ``sizeof(long double) == sizeof(double)`` it is an alias to > :class:`c_double`. This should be "``sizeof(long) == sizeof(int)`` ... :class:`c_long`". -- resolution: fixed -> stage: resolved -> status: closed -> open

[issue25160] Stop using deprecated imp module; imp should now emit a real DeprecationWarning

2016-06-02 Thread Jelle Zijlstra
Jelle Zijlstra added the comment: One more: - lib/pkgutil.py in _import_imp (amusingly) uses importlib with silenced warnings to import imp. -- ___ Python tracker

[issue21776] distutils.upload uses the wrong order of exceptions

2016-06-02 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the patch, Claudiu. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue19611] inspect.getcallargs doesn't properly interpret set comprehension code objects.

2016-06-02 Thread Jelle Zijlstra
Jelle Zijlstra added the comment: Since this only comes up with manually created functions (through calling types.FunctionType), I think it wouldn't be unreasonable to just not handle this case in the inspect module and close this as wontfix. Ned, is there a use case for converting

[issue25548] Show the address in the repr for class objects

2016-06-02 Thread Kushal Das
Kushal Das added the comment: Attaching the patch for the same. Had to update the test cases for the following tests to have this behavior as expected. test_functools test_cmd_line_script test_ctypes test_defaultdict test_descr test_descrtut test_doctest test_generators test_genexps

[issue13784] Documentation of xml.sax.xmlreader: Locator.getLineNumber() and Locator.getColumnNumber()

2016-06-02 Thread Roundup Robot
Roundup Robot added the comment: New changeset 97b76fe183f4 by R David Murray in branch '2.7': #13784: fix xml.sax.reader getColumn/LineNumber docs. https://hg.python.org/cpython/rev/97b76fe183f4 New changeset 9d6a9e2ae18b by R David Murray in branch '3.5': #13784: fix xml.sax.reader

[issue21776] distutils.upload uses the wrong order of exceptions

2016-06-02 Thread Roundup Robot
Roundup Robot added the comment: New changeset 17e7d6c4f082 by Berker Peksag in branch '3.5': Issue #21776: distutils.upload now correctly handles HTTPError https://hg.python.org/cpython/rev/17e7d6c4f082 New changeset 421bc6ae9b6f by Berker Peksag in branch 'default': Issue #21776: Merge from

[issue27113] sqlite3 connect parameter "check_same_thread" not documented

2016-06-02 Thread Thomas Kluyver
Thomas Kluyver added the comment: Having watched the video of Dave's PyCon talk (thanks Dave), I think he's talking about using locking to control transactions, which presumably the sqlite bindings don't handle by themselves. But I don't *think* you need manual locking just to maintain

[issue27188] sqlite3 execute* methods return value not documented

2016-06-02 Thread Dave Sawyer
New submission from Dave Sawyer: The three execute methods of the connection object return the created cursor. The term "intermediate" implies the cursor is totally handled by the execute method, not that the user will get ownership of the object. When the user doesn't call close() on the

[issue16484] pydoc generates invalid docs.python.org link for xml.etree.ElementTree and other modules

2016-06-02 Thread Kaushik N
Kaushik N added the comment: Applied patch from sean.rodman. Created a test. -- nosy: +Kaushik N Added file: http://bugs.python.org/file43121/Issue16484_python3.6.patch ___ Python tracker

[issue13784] Documentation of xml.sax.xmlreader: Locator.getLineNumber() and Locator.getColumnNumber()

2016-06-02 Thread R. David Murray
R. David Murray added the comment: Thanks Emily. For some reason the auto update of the tracker doesn't seem to have worked. Maybe it is just delayed, but in case, the commit hashes are 2.7 97b76fe183f4, 3.5 9d6a9e2ae18b, and 3.6 cce04851d2e2. -- nosy: +r.david.murray resolution:

[issue26829] update docs: when creating classes a new dict is created for the final class object

2016-06-02 Thread Emily Morehouse
Emily Morehouse added the comment: Super straight-forward -- this simply adds to the docs on creating the class object that the values used in creation are copied to the final object (including the namespace). -- keywords: +patch nosy: +emilyemorehouse Added file:

[issue19611] inspect.getcallargs doesn't properly interpret set comprehension code objects.

2016-06-02 Thread R. David Murray
R. David Murray added the comment: I wonder if we should do the mention of .0 as a footnote, since it won't matter to most users. What do you think, Yuri? -- ___ Python tracker

[issue20973] Implement proper comparison operations for in _TotalOrderingMixin in ipaddress module.

2016-06-02 Thread Roundup Robot
Roundup Robot added the comment: New changeset ffaefb20dd06 by R David Murray in branch '3.5': #20973: add total ordering tests for ipaddress https://hg.python.org/cpython/rev/ffaefb20dd06 New changeset 503168ec3d4f by R David Murray in branch 'default': Merge: #20973: add total ordering tests

[issue27185] Clarify Test Coverage for the String Module (test_pep292 is not easily discoverable)

2016-06-02 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: This is not so easy. After adding all the tests from test_pep292.py into test_string.py and removing test_pep292.py we will lost all the history of test_pep292.py. Merging two files in Mercurial is not easy. I already did this and can do again if it is

[issue24254] Make class definition namespace ordered by default

2016-06-02 Thread Nick Coghlan
Nick Coghlan added the comment: Patch review sent. The motivation for the change is relatively weak without __definition_order__, though :) -- ___ Python tracker

[issue27172] Add skip_bound_arg argument to inspect.Signature.from_callable()

2016-06-02 Thread Yury Selivanov
Yury Selivanov added the comment: Nick, what do you think about this one? I'm +1 to add this, but I'm not sure about the name for the argument. Do you have better ideas, or "skip_bound_arg" is good enough? -- nosy: +ncoghlan ___ Python tracker

[issue27186] add os.fspath()

2016-06-02 Thread Roundup Robot
New submission from Roundup Robot: New changeset 59a52a9dd0dc by Ethan Furman in branch 'default': issue27186 -- initial docs, tests, and python version of os.fspath https://hg.python.org/cpython/rev/59a52a9dd0dc -- nosy: +python-dev ___ Python

[issue25160] Stop using deprecated imp module; imp should now emit a real DeprecationWarning

2016-06-02 Thread Jelle Zijlstra
Changes by Jelle Zijlstra : -- keywords: +patch Added file: http://bugs.python.org/file43113/issue25160-2to3.patch ___ Python tracker

[issue24291] Many servers (wsgiref, http.server, etc) can truncate large output blobs

2016-06-02 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: It looks to me that there is two opposite ways to resolve this issue. 1. Document the requirement for write() and raise an exception if write() returned not the size of full data. But I think it would be more user-friendly first emit a warning and continue

[issue27185] Clarify Test Coverage for the String Module (test_pep292 is not easily discoverable)

2016-06-02 Thread Erin Braswell
Erin Braswell added the comment: Here is an updated patch adding all the tests from test_pep292.py into test_string.py. After this happens test_pep292.py can be removed! -- Added file: http://bugs.python.org/file43114/stringtests.patch ___ Python

[issue24617] os.makedirs()'s [mode] not correct

2016-06-02 Thread Tommy Beadle
Changes by Tommy Beadle : -- keywords: +patch Added file: http://bugs.python.org/file43115/0001-Issue-24617-Add-comment-for-os.makedirs-about-certai.patch ___ Python tracker

[issue20973] Implement proper comparison operations for in _TotalOrderingMixin in ipaddress module.

2016-06-02 Thread R. David Murray
R. David Murray added the comment: Thanks, Tommy. -- resolution: -> fixed stage: -> resolved status: open -> closed versions: +Python 3.6 ___ Python tracker

[issue21864] Error in documentation of point 9.8 'Exceptions are classes too'

2016-06-02 Thread Berker Peksag
Berker Peksag added the comment: I think the "Exceptions Are Classes Too" section can be removed now. Users already learned that exceptions are classes in the previous chapter: https://docs.python.org/3/tutorial/errors.html I'm attaching a patch that removes the "Exceptions Are Classes Too"

[issue27025] More human readable generated widget names

2016-06-02 Thread Terry J. Reedy
Terry J. Reedy added the comment: While a widget tree could be constructed using tk's introspection functions, I believe there are other good uses for monkey patching. The attached .py file defines a monkeypatch context manager (does one exist already?). The file uses the c.m. twice to

[issue19611] inspect.getcallargs doesn't properly interpret set comprehension code objects.

2016-06-02 Thread Yury Selivanov
Yury Selivanov added the comment: Jelle, regarding your patch: it would probably be a good idea to only accept ".0"-like names for POSITIONAL_ONLY parameters. Since functions with positional-only parameters can only be created in C, that should make inspect.Parameter less error prone.

[issue19234] socket.fileno() documentation

2016-06-02 Thread Zachary Ware
Zachary Ware added the comment: I think the additions are redundant; pick one or the other. The first should be sufficient. -- nosy: +zach.ware stage: -> patch review versions: +Python 2.7, Python 3.5, Python 3.6 ___ Python tracker

[issue26829] update docs: when creating classes a new dict is created for the final class object

2016-06-02 Thread R. David Murray
R. David Murray added the comment: Your suggested wording isn't correct, I'm afraid. This subject is complex and somewhat obscure...I checked with Ethan to make sure my interpretation was correct. The problem this issue is addressing is the fact that when type.__new__ is called (as in the

[issue27185] Clarify Test Coverage for the String Module (test_pep292 is not easily discoverable)

2016-06-02 Thread R. David Murray
R. David Murray added the comment: Benjamin: meaning we should wait for git to merge it, or git will automatically handle the history after conversion? -- ___ Python tracker

[issue27185] Clarify Test Coverage for the String Module (test_pep292 is not easily discoverable)

2016-06-02 Thread Benjamin Peterson
Benjamin Peterson added the comment: We should be able to commit it now. git blame can usually figure out this stuff post facto. On Thu, Jun 2, 2016, at 13:54, R. David Murray wrote: > > R. David Murray added the comment: > > Benjamin: meaning we should wait for git to merge it, or git will >

[issue27187] Relax __all__ location requirement in PEP 8

2016-06-02 Thread Barry A. Warsaw
New submission from Barry A. Warsaw: PEP 8 says: Put any relevant __all__ specification after the imports. I don't remember why we wanted __all__ to go after imports. I think we should relax that since other dunders can go before imports. See related PYCQA issue:

[issue26589] Add HTTP Response code 451

2016-06-02 Thread Raymond Hettinger
Raymond Hettinger added the comment: Thanks Nathan, I'll apply this shortly. -- assignee: -> rhettinger ___ Python tracker ___

[issue27187] Relax __all__ location requirement in PEP 8

2016-06-02 Thread Barry A. Warsaw
Changes by Barry A. Warsaw : -- assignee: -> docs@python components: +Documentation nosy: +docs@python ___ Python tracker ___

[issue27182] PEP 519 support in the stdlib

2016-06-02 Thread Ethan Furman
Ethan Furman added the comment: Nope. There is a posixpath.py and an ntpath.py, and they are not the same. -- ___ Python tracker ___

[issue25160] Stop using deprecated imp module; imp should now emit a real DeprecationWarning

2016-06-02 Thread Berker Peksag
Berker Peksag added the comment: > - 2to3 replaces reload() calls with imp.reload There is an already open issue for this: Issue 21446. -- ___ Python tracker

[issue21446] Update reload fixer to use importlib instead of imp

2016-06-02 Thread Jelle Zijlstra
Jelle Zijlstra added the comment: I couldn't find references in the docs to clarify what version of 3.x 2to3 targets, but it seems reasonable to me that it produces code targeted to the version of CPython it was bundled with. imp is deprecated and presumably will be removed later in 3.x, so

[issue27113] sqlite3 connect parameter "check_same_thread" not documented

2016-06-02 Thread Thomas Kluyver
Thomas Kluyver added the comment: That comment contained far too much 'probably'. Time for me to sleep... -- ___ Python tracker ___

[issue27185] Clarify Test Coverage for the String Module (test_pep292 is not easily discoverable)

2016-06-02 Thread R. David Murray
R. David Murray added the comment: All right, I'll go ahead and commit it, then. -- ___ Python tracker ___

[issue19611] inspect.getcallargs doesn't properly interpret set comprehension code objects.

2016-06-02 Thread Yury Selivanov
Yury Selivanov added the comment: > I chatted to Brett Cannon about it, and we agree inspect should handle the > implicit functions generated by the compiler, even if those signatures can't > be expressed in normal Python code. Can we make ".0" parameters positional-only then? And rename

[issue27181] Add geometric mean to `statistics` module

2016-06-02 Thread Steven D'Aprano
Steven D'Aprano added the comment: On Thu, Jun 02, 2016 at 09:04:54PM +, Raymond Hettinger wrote: > Steven, this seems like a reasonable suggestion (though I would expect > someone else will immediately suggest a harmonic mean as well). Is > this within the scope of what you were trying

[issue16113] Add SHA-3 and SHAKE (Keccak) support

2016-06-02 Thread Gregory P. Smith
Gregory P. Smith added the comment: comments added to the code review. -- ___ Python tracker ___ ___

[issue16192] ctypes - documentation example

2016-06-02 Thread Berker Peksag
Changes by Berker Peksag : -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker ___

[issue16192] ctypes - documentation example

2016-06-02 Thread Roundup Robot
Roundup Robot added the comment: New changeset dfde53cf07e6 by Berker Peksag in branch '3.5': Issue #16192: Fix copy and paste mistake noticed by Eryk Sun https://hg.python.org/cpython/rev/dfde53cf07e6 New changeset 7f3ebd86464b by Berker Peksag in branch 'default': Issue #16192: Merge from 3.5

[issue27185] Clarify Test Coverage for the String Module (test_pep292 is not easily discoverable)

2016-06-02 Thread R. David Murray
R. David Murray added the comment: Reopening and retitling. -- nosy: +r.david.murray resolution: duplicate -> status: closed -> open title: Increase Test Coverage for the String Module -> Clarify Test Coverage for the String Module (test_pep292 is not easily discoverable)

[issue19611] inspect.getcallargs doesn't properly interpret set comprehension code objects.

2016-06-02 Thread Yury Selivanov
Yury Selivanov added the comment: > Yes, it feels ugly. I'd rather "fix" the source of the problem (the weird > positional attribute name). +1. > I have no idea if argument clinic would be of any help here, I haven't looked > at how these things come to be. Me neither. Serhiy, what do you

[issue27187] Relax __all__ location requirement in PEP 8

2016-06-02 Thread Ian Lee
Changes by Ian Lee : -- nosy: +IanLee1521 ___ Python tracker ___ ___ Python-bugs-list

[issue27113] sqlite3 connect parameter "check_same_thread" not documented

2016-06-02 Thread Dave Sawyer
Dave Sawyer added the comment: Changed doc to note that not only must it be used on 1 thread if true, but that thread must be the thread that created it. -- ___ Python tracker

[issue19611] inspect.getcallargs doesn't properly interpret set comprehension code objects.

2016-06-02 Thread Nick Coghlan
Nick Coghlan added the comment: We definitely can't use a valid identifier in the code generator, since any valid identifier we used might shadow a nonlocal, global or builtin name (and the latter two cases aren't visible to the compiler at compile time). They're also genuinely not positional

[issue15476] Index "code object" and link to code object definition

2016-06-02 Thread Tommy Beadle
Tommy Beadle added the comment: The attached patch makes it so that 'code object' is its own 'top-level' entry in the index instead of being 'code' with an 'object' sub-item. It also makes the links from the index go to the location in the documents just before the header instead of having

[issue26589] Add HTTP Response code 451

2016-06-02 Thread Martin Panter
Martin Panter added the comment: Don’t forget to fix the RFC number (see review) :) -- ___ Python tracker ___

[issue25931] os.fork() command distributed in windows Python27 (in SocketServer module)

2016-06-02 Thread Roundup Robot
Roundup Robot added the comment: New changeset d772400a1211 by Gregory P. Smith in branch 'default': Issue #25931: Don't defining socketserver.Forking* names on platforms such https://hg.python.org/cpython/rev/d772400a1211 -- nosy: +python-dev ___

[issue25702] Link Time Optimizations support for GCC and CLANG

2016-06-02 Thread Gregory P. Smith
Gregory P. Smith added the comment: the main part of this issue is done but it can't be closed until the dependencies listed are also dealt with. un-assigning myself. -- assignee: gregory.p.smith -> resolution: -> fixed ___ Python tracker

[issue27187] Relax __all__ location requirement in PEP 8

2016-06-02 Thread Ian Lee
Changes by Ian Lee : Added file: http://bugs.python.org/file43134/issue-27187-patch2.txt ___ Python tracker ___

[issue27185] Clarify Test Coverage for the String Module (test_pep292 is not easily discoverable)

2016-06-02 Thread Erin Braswell
Erin Braswell added the comment: Hooray thank you everyone! -- ___ Python tracker ___ ___ Python-bugs-list

[issue27186] add os.fspath()

2016-06-02 Thread Jelle Zijlstra
Changes by Jelle Zijlstra : Added file: http://bugs.python.org/file43128/issue27186-DirEntry-fspath.patch ___ Python tracker ___

[issue25931] os.fork() command distributed in windows Python27 (in SocketServer module)

2016-06-02 Thread R. David Murray
R. David Murray added the comment: Your news entry says "don't defining". The doc note can say that the classes are only defined if the platform supports fork. -- ___ Python tracker

[issue27137] Python implementation of `functools.partial` is not a class

2016-06-02 Thread Nick Coghlan
Nick Coghlan added the comment: As Raymond notes, the main downside here is in terms of code complexity. However, the concrete gain is that APIs that rely on callable pickling, such as concurrent.futures with a ProcessPoolExecutor, would be consistently compatible with functools.partial: >>>

[issue27186] add os.fspath()

2016-06-02 Thread Dusty Phillips
Dusty Phillips added the comment: This patch adds fspath protocol and constructor initialization to pathlib.Path. -- Added file: http://bugs.python.org/file43133/issue27186-pathlib.buchuki.patch ___ Python tracker

[issue22890] StringIO.StringIO pickled in 2.7 is not unpickleable on 3.x

2016-06-02 Thread Jelle Zijlstra
Jelle Zijlstra added the comment: Unless I'm missing something, StringIO doesn't exist as a module in Python 3, as mentioned in https://docs.python.org/3.0/whatsnew/3.0.html#text-vs-data-instead-of-unicode-vs-8-bit. If you're trying to unpickle in 3.x an object pickled by 2.7.x, I'm not sure

[issue25812] locale.nl_langinfo() can't decode value

2016-06-02 Thread Nina Zakharenko
Nina Zakharenko added the comment: Adding the test below to test__locale.py will reproduce the issue under the following conditions: - The locale `uk_UA` is installed on your system. - 'uk_UA': (',', '\xa0') is added to the `known_numerics` dictionary in this test file

[issue27190] Check sqlite3_version before allowing check_same_thread = False

2016-06-02 Thread Berker Peksag
Changes by Berker Peksag : -- components: +Extension Modules ___ Python tracker ___

[issue27190] Check sqlite3_version before allowing check_same_thread = False

2016-06-02 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the patch. I'm not sure we can apply the patch to bugfix branches. You can use SQLITE_VERSION_NUMBER to check sqlite3 version. -- nosy: +berker.peksag stage: -> patch review versions: +Python 3.6 ___

[issue15476] Index "code object" and link to code object definition

2016-06-02 Thread Tommy Beadle
Tommy Beadle added the comment: This restores the original code -> object items. -- Added file: http://bugs.python.org/file43137/0001-Issue-15476-Make-code-object-its-own-entry-in-the-do.patch ___ Python tracker

[issue23670] Modifications to support iOS as a cross-compilation target

2016-06-02 Thread Luke Taylor
Luke Taylor added the comment: Are you aware of Pythonista? I have no affiliation, but I'm a fan of the app and the community surrounding it. See http://omz-software.com/pythonista/ for details. I'm sure communication with the developer of the app could yield some useful insights. --

[issue27189] configure --with-lto with clang should find the appropriate llvm-profdata tool

2016-06-02 Thread Gregory P. Smith
New submission from Gregory P. Smith: The --with-lto support added in issue25702 can work with clang, but on a Linux distribution such as ubuntu 16.04 with clang installed you get: $ CC=clang ./configure --with-lto ... $ make profile-opt Error: Cannot perform PGO build because llvm-profdata

[issue27186] add os.fspath()

2016-06-02 Thread Dusty Phillips
Dusty Phillips added the comment: Make os.fsencode and os.fsdecode able to accept a PathLike by calling into fspath. Additionally adds test for PathLike objects. -- keywords: +patch nosy: +buchuki Added file: http://bugs.python.org/file43123/issue27186.buchuki.patch

[issue24254] Make class definition namespace ordered by default

2016-06-02 Thread Eric Snow
Eric Snow added the comment: Thanks. Yeah, I wanted to keep the patches separate for the sake of code review. I'll fold the changes into a single commit once everything's ready. -- ___ Python tracker

[issue27186] add os.fspath()

2016-06-02 Thread Jelle Zijlstra
Jelle Zijlstra added the comment: This patch adds the C implementation (copied from the PEP). Some notes: - I added a new .h file in Include/ because there didn't seem to be an obvious existing place to put it. - There was some uncertainty about whether we should Py_INCREF the string or bytes

[issue25931] os.fork() command distributed in windows Python27 (in SocketServer module)

2016-06-02 Thread R. David Murray
R. David Murray added the comment: Well, defined for 3.6, and "functional" for 2.7 and 3.5 docs. -- ___ Python tracker ___

[issue27186] add os.fspath()

2016-06-02 Thread Dusty Phillips
Changes by Dusty Phillips : Removed file: http://bugs.python.org/file43123/issue27186.buchuki.patch ___ Python tracker ___

[issue27167] subprocess reports signal as negative exit status, not documented

2016-06-02 Thread Gregory P. Smith
Gregory P. Smith added the comment: docs updated (7b12180481da and 19d77132f38d). working on the error message update. -- ___ Python tracker ___

[issue27187] Relax __all__ location requirement in PEP 8

2016-06-02 Thread Ian Lee
Ian Lee added the comment: I added a comment on a pull request related to this that shows some of the cases that we probably don't want to allow: https://github.com/PyCQA/pycodestyle/pull/523#issuecomment-223464775 -- ___ Python tracker

[issue22890] StringIO.StringIO pickled in 2.7 is not unpickleable on 3.x

2016-06-02 Thread Mark Lawrence
Changes by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___

[issue27187] Relax __all__ location requirement in PEP 8

2016-06-02 Thread John Mark Vandenberg
Changes by John Mark Vandenberg : -- nosy: +jayvdb ___ Python tracker ___ ___

[issue25931] os.fork() command distributed in windows Python27 (in SocketServer module)

2016-06-02 Thread Martin Panter
Martin Panter added the comment: This broke test_socketserver: http://buildbot.python.org/all/builders/AMD64%20Windows7%20SP1%203.x/builds/7709/steps/test/logs/stdio 0:08:57 [193/400/1] test_socketserver failed test test_socketserver crashed -- Traceback (most recent call last): File

[issue17352] Be clear that __prepare__ must be declared as a class method

2016-06-02 Thread Berker Peksag
Berker Peksag added the comment: This is a duplicate of issue 15243. -- nosy: +berker.peksag resolution: -> duplicate stage: -> resolved status: open -> closed superseder: -> Misleading documentation for __prepare__ ___ Python tracker

[issue27186] add os.fspath()

2016-06-02 Thread Dusty Phillips
Dusty Phillips added the comment: Test __fspath__ returning bytes as well. -- Added file: http://bugs.python.org/file43124/issue27186.buchuki.patch ___ Python tracker

[issue26266] add classattribute to enum to handle non-Enum attributes

2016-06-02 Thread Ethan Furman
Ethan Furman added the comment: One possible downside to the `classattribute` route is that we have a descriptor whose only purpose is to shield the item from becoming a member; the up-side is that it's simple to implement. Another possibility is `skip`: class skip: """ Protects item

[issue24291] Many servers (wsgiref, http.server, etc) can truncate large output blobs

2016-06-02 Thread Martin Panter
Martin Panter added the comment: I prefer your first solution because it seems to fit in better with how things were intended. I can add in handling of partial writes with a deprecation warning when I get a chance. I guess the documentation would be something like “Since 3.5.2, partial

[issue26829] update docs: when creating classes a new dict is created for the final class object

2016-06-02 Thread R. David Murray
R. David Murray added the comment: I can't get the rietveld review tool to work from this network, so I'll do this in a comment. This looks pretty good to me, but in the following: +It is important to note that during the creation of the class, a copy of the +namespace object is used in

[issue27185] Clarify Test Coverage for the String Module (test_pep292 is not easily discoverable)

2016-06-02 Thread Roundup Robot
Roundup Robot added the comment: New changeset 89abefdebf4d by R David Murray in branch '3.5': #27185: move test_pep292 into test_string. https://hg.python.org/cpython/rev/89abefdebf4d New changeset c2d3d8c3e0bf by R David Murray in branch 'default': Merge: #27185: move test_pep292 into

[issue25738] http.server doesn't handle RESET CONTENT status correctly

2016-06-02 Thread Susumu Koshiba
Susumu Koshiba added the comment: Patched the behaviors when NO_CONTENT and RESET_CONTENT are sent via send_error(). According to RFCs, they aren't actually errors so sending them through send_response() seems to make the most sense, however. send_error()'s behavior changes in this patch are:

[issue27113] sqlite3 connect parameter "check_same_thread" not documented

2016-06-02 Thread Dave Sawyer
Dave Sawyer added the comment: Hi Thomas and Senthil, for the serialized setting I mentioned earlier "The serialized mode is default on both Mac and Windows so we can probably skip validating that. I did like mentioning the user needs to serialize the writes. They could use one thread for

[issue15476] Index "code object" and link to code object definition

2016-06-02 Thread R. David Murray
R. David Murray added the comment: Since the main object of the issue is to have a canonical reference to use for linking 'code object' from elsewhere in the text, I think that can be satisfied by existing _bltin-code-objects 'ref' link as Terry suggests, even though it is a bit awkward to

[issue27130] zlib: OverflowError while trying to compress 2^32 bytes or more

2016-06-02 Thread Xiang Zhang
Xiang Zhang added the comment: I'd like to help but it'll need some time. And I'd like to start after issue27164 is solved. zdict now also checks for 4GB limit. -- ___ Python tracker

[issue25702] Link Time Optimizations support for GCC and CLANG

2016-06-02 Thread Roundup Robot
Roundup Robot added the comment: New changeset f710dac07312 by Gregory P. Smith in branch '2.7': Issue #25702: A --with-lto configure option has been added that will https://hg.python.org/cpython/rev/f710dac07312 -- ___ Python tracker

[issue26829] update docs: when creating classes a new dict is created for the final class object

2016-06-02 Thread Roundup Robot
Roundup Robot added the comment: New changeset 754118f8b3ce by R David Murray in branch '3.5': #26829: Clarify that namespace is copied to a new __dict__ in instance creation. https://hg.python.org/cpython/rev/754118f8b3ce New changeset 5a4ace14b350 by R David Murray in branch 'default': Merge:

[issue26829] update docs: when creating classes a new dict is created for the final class object

2016-06-02 Thread R. David Murray
R. David Murray added the comment: Thanks, Emily. -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker ___

[issue27187] Relax __all__ location requirement in PEP 8

2016-06-02 Thread Ian Lee
Ian Lee added the comment: I think that it should be updated to specify that all dunders ('__all__', '__version__', '__author__', etc) should be placed after the module docstring and before any imports. See issue-27187-patch1.txt for a possible update. -- Added file:

  1   2   3   >