[issue27025] More human readable generated widget names

2016-06-02 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I have experimented with different naming schemes. Original output with Terry's example (actually names are longer in IDLE, since the configuration dialog is created as a child of other toplevel widget): label .3070117292.3069168812.3069169068.3069251628.30

[issue18085] Verifying refcounts.dat

2016-06-02 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: No, I hadn't verified all names. I'm sure there are API functions not mentioned in refcounts.dat. See also issue23903. It would be nice to have a tool that parses Python source headers and produce lists of all public names in different formats for manual up

[issue27165] Skip callables when displaying exception fields in cgitb

2016-06-02 Thread Adam Bielański
Changes by Adam Bielański : Added file: http://bugs.python.org/file43097/cgitb.patch ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue27165] Skip callables when displaying exception fields in cgitb

2016-06-02 Thread Adam Bielański
Changes by Adam Bielański : Removed file: http://bugs.python.org/file43065/cgitb.diff ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue26582] asyncio documentation links to wrong CancelledError

2016-06-02 Thread STINNER Victor
STINNER Victor added the comment: > do agree that asyncio.CancelledError should be documented? Yes, I would prefer to get the exception from asyncio, even if it is officially an alias to an exception of a different module. It would be surprising to have to import concurrent.futures in a module

[issue16182] readline: Wrong tab completion scope indices in Unicode terminals

2016-06-02 Thread Martin Panter
Martin Panter added the comment: V3 finishes what I started in v2: * Changed unchecked PyBytes_AsString() → PyBytes_AS_STRING() * Testing more functions for non-ASCII characters I tried to test it with Editline on Linux (using my patch for Issue 13501). There seem to be many quirks with my ver

[issue27171] Fix various typos

2016-06-02 Thread Roundup Robot
Roundup Robot added the comment: New changeset ce31ee3b1e69 by Martin Panter in branch '3.5': Issue #27171: Fix typos in documentation, comments, and test function names https://hg.python.org/cpython/rev/ce31ee3b1e69 New changeset c67f1f4ebb32 by Martin Panter in branch 'default': Issue #27171:

[issue27180] Doc/pathlib: Please describe the behaviour of Path().rename() is depends on the platform (same as os.rename())

2016-06-02 Thread Masato HASHIMOTO
New submission from Masato HASHIMOTO: The behavior of Path().rename() is same as os.rename() (replaces silently if dest file is already existent on Unix) but it's difficult to catch from current pathlib documentation (I found it from source of pathlib) from comparing with replace(). IMHO, it

[issue27171] Fix various typos

2016-06-02 Thread Martin Panter
Changes by Martin Panter : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue27181] Add geometric mean to `statistics` module

2016-06-02 Thread Ram Rachum
Changes by Ram Rachum : -- components: Library (Lib) nosy: cool-RR priority: normal severity: normal status: open title: Add geometric mean to `statistics` module type: enhancement versions: Python 3.6 ___ Python tracker

[issue27177] re match.group should support __index__

2016-06-02 Thread Jeroen Demeyer
Jeroen Demeyer added the comment: I would still argue that it's a bug. The intention of PEP 357 is that __index__ should be used whenever some object needs to be converted to a Py_ssize_t, which is exactly what you do here. -- ___ Python tracker

[issue27181] Add geometric mean to `statistics` module

2016-06-02 Thread Xiang Zhang
Changes by Xiang Zhang : -- nosy: +steven.daprano ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue27177] re match.group should support __index__

2016-06-02 Thread Matthew Barnett
Matthew Barnett added the comment: It would be a bug if it was supported but gave the wrong result. It has never been supported (the re module predates PEP 357), so it's a new feature. -- ___ Python tracker _

[issue27130] zlib: OverflowError while trying to compress 2^32 bytes or more

2016-06-02 Thread Klamann
Klamann added the comment: > You should be able to use a compression (or decompression) object as a > workaround. OK, let's see >>> import zlib >>> zc = zlib.compressobj() >>> c1 = zc.compress(b'a' * 2**31) >>> c2 = zc.compress(b'a' * 2**31) >>> c3 = zc.flush() >>> c = c1 + c2 + c3 >>> zd = zl

[issue27179] subprocess uses wrong encoding on Windows

2016-06-02 Thread Dāvis
Changes by Dāvis : Removed file: http://bugs.python.org/file43094/subprocess_fix_encoding.patch ___ Python tracker ___ ___ Python-bugs-list ma

[issue27180] Doc/pathlib: Please describe the behaviour of Path().rename() is depends on the platform (same as os.rename())

2016-06-02 Thread Berker Peksag
Changes by Berker Peksag : -- keywords: +easy stage: -> needs patch versions: -Python 3.4 ___ Python tracker ___ ___ Python-bugs-lis

[issue24500] provide context manager to redirect C output

2016-06-02 Thread Zahari Dim
Zahari Dim added the comment: Considering Python is used often to interact with lower level languages, it seems interesting to have the ability to control the "real" standard output and error that those languages use. Note that redirecting to /dev/null is only one possible application of this fea

[issue23116] Python Tutorial 4.7.1: Improve ask_ok() to cover more input values

2016-06-02 Thread Benjamin Peterson
Benjamin Peterson added the comment: I think the patch is okay except for the use of "-=" instead of the more verbose version. -- nosy: +benjamin.peterson ___ Python tracker ___

[issue22558] Missing doc links to source code for Python-coded modules.

2016-06-02 Thread Nathan Harold
Changes by Nathan Harold : -- nosy: +nharold ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

[issue27179] subprocess uses wrong encoding on Windows

2016-06-02 Thread Dāvis
Changes by Dāvis : Added file: http://bugs.python.org/file43101/subprocess_fix_encoding_v2_b.patch ___ Python tracker ___ ___ Python-bugs-list

[issue13548] Invalid 'line' tracer event on pass within else clause

2016-06-02 Thread Jelle Zijlstra
Jelle Zijlstra added the comment: The reason for this behavior is that the trace function is called whenever execution in the bytecode jumps to a new source line. See ceval.c line 4440 or so: /* If the last instruction falls at the start of a line or if it represents a jump backward

[issue22570] Better stdlib support for Path objects using .path attribute

2016-06-02 Thread Ethan Furman
Changes by Ethan Furman : -- nosy: +ethan.furman title: Better stdlib support for Path objects -> Better stdlib support for Path objects using .path attribute ___ Python tracker ___

[issue26027] Support Path objects in the posix module

2016-06-02 Thread Ethan Furman
Changes by Ethan Furman : -- nosy: +ethan.furman ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue27179] subprocess uses wrong encoding on Windows

2016-06-02 Thread Dāvis
Dāvis added the comment: There is right encoding, it's encoding that's actually used. Here we're inside subprocess.Popen which does the actual winapi.CreateProcess call and thus we can check for any creationflags and adjust encoding logic accordingly. I would say almost all Windows console pro

[issue27182] PEP 519 support in the stdlib

2016-06-02 Thread Ethan Furman
New submission from Ethan Furman: Meta issue to track adding PEP 519 support in the various stdlib modules. -- messages: 266891 nosy: brett.cannon, ethan.furman, serhiy.storchaka priority: normal severity: normal status: open title: PEP 519 support in the stdlib

[issue27182] PEP 519 support in the stdlib

2016-06-02 Thread Ethan Furman
Ethan Furman added the comment: posix module: issue26027 -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: htt

[issue27182] PEP 519 support in the stdlib

2016-06-02 Thread Ethan Furman
Ethan Furman added the comment: importlib: issue26667 -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:

[issue27183] Clarify that Py_VISIT(NULL) does nothing

2016-06-02 Thread Petr Viktorin
New submission from Petr Viktorin: The Py_VISIT macro (in Include/objimpl.h) does nothing if passed NULL (and did this since its introduction). It would be nice to have this formally documented. -- assignee: docs@python components: Documentation files: 0001-Doc-c-api-Clarify-that-Py_VIS

[issue21271] reset_mock needs parameters to also reset return_value and side_effect

2016-06-02 Thread Kushal Das
Kushal Das added the comment: Fixed in https://hg.python.org/cpython/rev/b110dd3d6cea -- status: open -> closed ___ Python tracker ___ ___

[issue21271] reset_mock needs parameters to also reset return_value and side_effect

2016-06-02 Thread Emanuel Barry
Changes by Emanuel Barry : -- resolution: -> fixed stage: patch review -> resolved ___ Python tracker ___ ___ Python-bugs-list mailin

[issue21271] reset_mock needs parameters to also reset return_value and side_effect

2016-06-02 Thread Roundup Robot
Roundup Robot added the comment: New changeset b110dd3d6cea by Kushal Das in branch 'default': Issue #21271: Adds new keyword only parameters in reset_mock call https://hg.python.org/cpython/rev/b110dd3d6cea -- nosy: +python-dev ___ Python tracker

[issue27184] Support path objects in the nt module

2016-06-02 Thread Ethan Furman
Changes by Ethan Furman : -- nosy: brett.cannon, ethan.furman, serhiy.storchaka priority: normal severity: normal stage: test needed status: open title: Support path objects in the nt module type: behavior versions: Python 3.6 ___ Python tracker

[issue27182] PEP 519 support in the stdlib

2016-06-02 Thread Ethan Furman
Ethan Furman added the comment: nt module: issue27184 -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:

[issue27182] PEP 519 support in the stdlib

2016-06-02 Thread Ethan Furman
Changes by Ethan Furman : -- dependencies: +Support Path objects in the posix module, Support path objects in the nt module, Update importlib to accept pathlib.Path objects type: -> behavior versions: +Python 3.6 ___ Python tracker

[issue27182] PEP 519 support in the stdlib

2016-06-02 Thread Ethan Furman
Changes by Ethan Furman : -- type: behavior -> enhancement ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http

[issue27184] Support path objects in the nt module

2016-06-02 Thread Ethan Furman
Changes by Ethan Furman : -- type: behavior -> enhancement ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http

[issue19234] socket.fileno() documentation

2016-06-02 Thread Kushal Das
Kushal Das added the comment: Adds more lines to explain the behavior of socket.fileno() in case of error. -- keywords: +patch nosy: +kushal.das Added file: http://bugs.python.org/file43103/issue19234.patch ___ Python tracker

[issue27185] Increase Test Coverage for the String Module

2016-06-02 Thread Erin Braswell
Changes by Erin Braswell : -- components: Tests files: stringtests.patch keywords: patch nosy: erinspace priority: normal severity: normal status: open title: Increase Test Coverage for the String Module type: enhancement Added file: http://bugs.python.org/file43104/stringtests.patch __

[issue26359] CPython build options for out-of-the box performance

2016-06-02 Thread Brett Cannon
Changes by Brett Cannon : -- assignee: -> brett.cannon ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:/

[issue23116] Python Tutorial 4.7.1: Improve ask_ok() to cover more input values

2016-06-02 Thread Roundup Robot
Roundup Robot added the comment: New changeset ef800c30e28c by Berker Peksag in branch '3.5': Issue #23116: Improve ask_ok() example in the Python tutorial https://hg.python.org/cpython/rev/ef800c30e28c New changeset 174eae50b664 by Berker Peksag in branch 'default': Issue #23116: Merge from 3.5

[issue27182] PEP 519 support in the stdlib

2016-06-02 Thread Ethan Furman
Ethan Furman added the comment: os.fspath(): issue27186 -- dependencies: +add os.fspath() ___ Python tracker ___ ___ Python-bugs-list

[issue23116] Python Tutorial 4.7.1: Improve ask_ok() to cover more input values

2016-06-02 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the review. I removed the "-=" part from the patch. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue27186] add os.fspath()

2016-06-02 Thread Ethan Furman
Changes by Ethan Furman : -- nosy: brett.cannon, ethan.furman, serhiy.storchaka priority: normal severity: normal stage: test needed status: open title: add os.fspath() type: enhancement versions: Python 3.6 ___ Python tracker

[issue27185] Increase Test Coverage for the String Module

2016-06-02 Thread Gregory P. Smith
New submission from Gregory P. Smith: Can you sign the Python contributor form - https://www.python.org/psf/contrib/contrib-form/? (If you already have, just say so.) -- nosy: +gregory.p.smith ___ Python tracker

[issue26526] In parsermodule.c, replace over 2KLOC of hand-crafted validation code, with a DFA

2016-06-02 Thread Brett Cannon
Brett Cannon added the comment: Are you up for trying to commit this while at the sprints, Fred? If not then assign it back to me and I can eventually commit it (busy w/ a ton of stuff so I can't promise when I will get to it). -- assignee: -> fdrake stage: patch review -> commit revi

[issue26526] In parsermodule.c, replace over 2KLOC of hand-crafted validation code, with a DFA

2016-06-02 Thread Roundup Robot
Roundup Robot added the comment: New changeset 4a9159ea2536 by Benjamin Peterson in branch 'default': replace custom validation logic in the parse module with a simple DFA validator (closes #26526) https://hg.python.org/cpython/rev/4a9159ea2536 -- nosy: +python-dev resolution: -> fixed

[issue27185] Increase Test Coverage for the String Module

2016-06-02 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: string.Template is tested in Lib/test/test_pep292.py. -- nosy: +serhiy.storchaka ___ Python tracker ___ __

[issue27185] Increase Test Coverage for the String Module

2016-06-02 Thread Gregory P. Smith
Gregory P. Smith added the comment: Thanks Serhiy. Given that, I suggest checking if the new tests this adds are already covered in test_pep292.py or not to decide if we should move forward with this patch or not. -- ___ Python tracker

[issue27183] Clarify that Py_VISIT(NULL) does nothing

2016-06-02 Thread Roundup Robot
Roundup Robot added the comment: New changeset 7c67cb3b54b4 by Benjamin Peterson in branch '3.5': note that Py_VISIT handles NULL (closes #27183) https://hg.python.org/cpython/rev/7c67cb3b54b4 New changeset 42356e44af23 by Benjamin Peterson in branch '2.7': note that Py_VISIT handles NULL (close

[issue27182] PEP 519 support in the stdlib

2016-06-02 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Isn't the nt module just an alias of the posix module? -- ___ Python tracker ___ ___ Python-bugs-l

[issue19611] inspect.getcallargs doesn't properly interpret set comprehension code objects.

2016-06-02 Thread Jelle Zijlstra
Jelle Zijlstra added the comment: This doesn't work in Python 3.6 (current dev version) either. Using Ned's example, I get (snipping some of the ipython stack trace): /home/jelle/cpython-dev/cpython/Lib/inspect.py in __init__(self, name, kind, default, annotation) 2399 if not name.i

[issue26798] add BLAKE2 to hashlib

2016-06-02 Thread Christian Heimes
Christian Heimes added the comment: New patch: - I moved the test vectors out of the repos. They are currently hosted on github. I'll move them to pythontest infra later. - I dropped special case for systems w/o uint64. Python 3.6+ requires 64 bit int types to compile. -- Added file:

[issue27164] zlib can't decompress DEFLATE using shared dictionary

2016-06-02 Thread Gregory P. Smith
Changes by Gregory P. Smith : -- assignee: gregory.p.smith -> ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue16113] Add SHA-3 and SHAKE (Keccak) support

2016-06-02 Thread Christian Heimes
Christian Heimes added the comment: New patch: - I moved the test vectors out of the repos. They are currently hosted on github. I'll move them to pythontest infra later. -- Added file: http://bugs.python.org/file43107/SHA3-and-SHAKE-support-for-Python-2.patch ___

[issue21196] Name mangling example in Python tutorial

2016-06-02 Thread Berker Peksag
Berker Peksag added the comment: I think the text is fine, but the example is not needed. I've updated Chandan's patch to remove the example and tweak the text a bit. -- nosy: +berker.peksag versions: +Python 3.6 -Python 3.4 Added file: http://bugs.python.org/file43108/issue21196.diff

[issue13784] Documentation of xml.sax.xmlreader: Locator.getLineNumber() and Locator.getColumnNumber()

2016-06-02 Thread Emily Morehouse
Emily Morehouse added the comment: The reported behavior has been verified -- the documented behavior is indeed incorrect for both Locator.getColumnNumber() and Locator.getLineNumber(). The beginning line and column numbers are returned, not the end. This has been tested and verified for Pytho

[issue25160] Stop using deprecated imp module; imp should now emit a real DeprecationWarning

2016-06-02 Thread Jelle Zijlstra
Jelle Zijlstra added the comment: Current status: - 2to3 replaces reload() calls with imp.reload - Lib/modulefinder.py imports imp and uses it 10 or so times, mostly for constants - Lib/xml/sax/__init__.py uses imp on Jython only - Python/makeopcodetargets.py falls back to imp if importlib is n

[issue27185] Increase Test Coverage for the String Module

2016-06-02 Thread Erin Braswell
Erin Braswell added the comment: Just checked! Apologies for this totally unnecessary patch, didn't know to look elsewhere but now I absolutely do -- looks like all the tests are there and more. Thank you! -- resolution: -> duplicate status: open -> closed __

[issue27185] Increase Test Coverage for the String Module

2016-06-02 Thread Benjamin Peterson
Benjamin Peterson added the comment: It probably makes sense to move test_pep292.py tests into test_string.py. Test files named after peps are not very helpful. -- nosy: +benjamin.peterson ___ Python tracker _

[issue19611] inspect.getcallargs doesn't properly interpret set comprehension code objects.

2016-06-02 Thread R. David Murray
R. David Murray added the comment: The patch looks reasonable to me. I've added Yuri to nosy since he's responsible for the signature code in inspect, and he might have an opinion on the appriateness of the fix. I think this special case needs to be documented, since currently the name is do

[issue19611] inspect.getcallargs doesn't properly interpret set comprehension code objects.

2016-06-02 Thread Jelle Zijlstra
Jelle Zijlstra added the comment: Thanks for the comment! It is fragile in the sense that I think there is a good chance that a fix (which is going to rely on details of generated bytecode) will have bugs and break someone's working 2.7 code. The patch's tests have a bug, which I'll fix toget

[issue27185] Increase Test Coverage for the String Module

2016-06-02 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Or at least add a reference in test_string.py. -- ___ Python tracker ___ ___ Python-bugs-list mail

[issue27185] Increase Test Coverage for the String Module

2016-06-02 Thread Erin Braswell
Erin Braswell added the comment: Oh! I can do that, and resubmit the patch! Good suggestion. Thank you again. -- ___ Python tracker ___ __

[issue20973] Implement proper comparison operations for in _TotalOrderingMixin in ipaddress module.

2016-06-02 Thread Tommy Beadle
Changes by Tommy Beadle : -- keywords: +patch Added file: http://bugs.python.org/file43110/0001-Issue-20973-Add-total-ordering-unit-tests-for-ipaddr.patch ___ Python tracker ___

[issue16192] ctypes - documentation example

2016-06-02 Thread Roundup Robot
Roundup Robot added the comment: New changeset 1775abf47061 by Berker Peksag in branch '3.5': Issue #16192: Clarify when c_int is an alias to c_long in ctypes documentation https://hg.python.org/cpython/rev/1775abf47061 New changeset 9954e29b8678 by Berker Peksag in branch 'default': Issue #1619

[issue16192] ctypes - documentation example

2016-06-02 Thread Berker Peksag
Changes by Berker Peksag : -- resolution: -> fixed stage: needs patch -> resolved status: open -> closed versions: +Python 3.6 -Python 3.4 ___ Python tracker ___ ___

[issue22374] Replace contextmanager example and improve explanation

2016-06-02 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: swap_attr() looks too general. I think something more concrete would be better. But the documentation already contain other examples for contextmanager. closing() is good example, and redirect_stdout() would be good example. -- nosy: +serhiy.storchak

[issue19611] inspect.getcallargs doesn't properly interpret set comprehension code objects.

2016-06-02 Thread Jelle Zijlstra
Jelle Zijlstra added the comment: Fixed patch, added documentation -- Added file: http://bugs.python.org/file43111/issue19611.patch ___ Python tracker ___ ___

[issue13784] Documentation of xml.sax.xmlreader: Locator.getLineNumber() and Locator.getColumnNumber()

2016-06-02 Thread R. David Murray
R. David Murray added the comment: Thanks Emily. For some reason the auto update of the tracker doesn't seem to have worked. Maybe it is just delayed, but in case, the commit hashes are 2.7 97b76fe183f4, 3.5 9d6a9e2ae18b, and 3.6 cce04851d2e2. -- nosy: +r.david.murray resolution: ->

[issue26829] update docs: when creating classes a new dict is created for the final class object

2016-06-02 Thread Emily Morehouse
Emily Morehouse added the comment: Super straight-forward -- this simply adds to the docs on creating the class object that the values used in creation are copied to the final object (including the namespace). -- keywords: +patch nosy: +emilyemorehouse Added file: http://bugs.python.or

[issue24291] Many servers (wsgiref, http.server, etc) can truncate large output blobs

2016-06-02 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: It looks to me that there is two opposite ways to resolve this issue. 1. Document the requirement for write() and raise an exception if write() returned not the size of full data. But I think it would be more user-friendly first emit a warning and continue c

[issue25160] Stop using deprecated imp module; imp should now emit a real DeprecationWarning

2016-06-02 Thread Jelle Zijlstra
Changes by Jelle Zijlstra : -- keywords: +patch Added file: http://bugs.python.org/file43113/issue25160-2to3.patch ___ Python tracker ___

[issue13784] Documentation of xml.sax.xmlreader: Locator.getLineNumber() and Locator.getColumnNumber()

2016-06-02 Thread Roundup Robot
Roundup Robot added the comment: New changeset 97b76fe183f4 by R David Murray in branch '2.7': #13784: fix xml.sax.reader getColumn/LineNumber docs. https://hg.python.org/cpython/rev/97b76fe183f4 New changeset 9d6a9e2ae18b by R David Murray in branch '3.5': #13784: fix xml.sax.reader getColumn/L

[issue26876] Extend MSVCCompiler class to respect environment variables

2016-06-02 Thread Zachary Ware
Zachary Ware added the comment: The patch looks fine to me, but frankly I'm a bit scared to commit anything to distutils :). It would be nice to have tests for this. I'm also not sure if we can backport this to 2.7 and 3.5: this is pretty clearly a new feature, but dips its toes into the grey

[issue25160] Stop using deprecated imp module; imp should now emit a real DeprecationWarning

2016-06-02 Thread Jelle Zijlstra
Jelle Zijlstra added the comment: One more: - lib/pkgutil.py in _import_imp (amusingly) uses importlib with silenced warnings to import imp. -- ___ Python tracker ___ _

[issue27185] Clarify Test Coverage for the String Module (test_pep292 is not easily discoverable)

2016-06-02 Thread R. David Murray
R. David Murray added the comment: Reopening and retitling. -- nosy: +r.david.murray resolution: duplicate -> status: closed -> open title: Increase Test Coverage for the String Module -> Clarify Test Coverage for the String Module (test_pep292 is not easily discoverable)

[issue25160] Stop using deprecated imp module; imp should now emit a real DeprecationWarning

2016-06-02 Thread Berker Peksag
Berker Peksag added the comment: > - 2to3 replaces reload() calls with imp.reload There is an already open issue for this: Issue 21446. -- ___ Python tracker ___ ___

[issue19611] inspect.getcallargs doesn't properly interpret set comprehension code objects.

2016-06-02 Thread R. David Murray
R. David Murray added the comment: I wonder if we should do the mention of .0 as a footnote, since it won't matter to most users. What do you think, Yuri? -- ___ Python tracker ___

[issue27185] Clarify Test Coverage for the String Module (test_pep292 is not easily discoverable)

2016-06-02 Thread Erin Braswell
Erin Braswell added the comment: Here is an updated patch adding all the tests from test_pep292.py into test_string.py. After this happens test_pep292.py can be removed! -- Added file: http://bugs.python.org/file43114/stringtests.patch ___ Python tra

[issue24617] os.makedirs()'s [mode] not correct

2016-06-02 Thread Tommy Beadle
Changes by Tommy Beadle : -- keywords: +patch Added file: http://bugs.python.org/file43115/0001-Issue-24617-Add-comment-for-os.makedirs-about-certai.patch ___ Python tracker ___

[issue19611] inspect.getcallargs doesn't properly interpret set comprehension code objects.

2016-06-02 Thread Yury Selivanov
Yury Selivanov added the comment: Jelle, regarding your patch: it would probably be a good idea to only accept ".0"-like names for POSITIONAL_ONLY parameters. Since functions with positional-only parameters can only be created in C, that should make inspect.Parameter less error prone. David,

[issue27185] Clarify Test Coverage for the String Module (test_pep292 is not easily discoverable)

2016-06-02 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: This is not so easy. After adding all the tests from test_pep292.py into test_string.py and removing test_pep292.py we will lost all the history of test_pep292.py. Merging two files in Mercurial is not easy. I already did this and can do again if it is worth

[issue20973] Implement proper comparison operations for in _TotalOrderingMixin in ipaddress module.

2016-06-02 Thread Roundup Robot
Roundup Robot added the comment: New changeset ffaefb20dd06 by R David Murray in branch '3.5': #20973: add total ordering tests for ipaddress https://hg.python.org/cpython/rev/ffaefb20dd06 New changeset 503168ec3d4f by R David Murray in branch 'default': Merge: #20973: add total ordering tests f

[issue20973] Implement proper comparison operations for in _TotalOrderingMixin in ipaddress module.

2016-06-02 Thread R. David Murray
R. David Murray added the comment: Thanks, Tommy. -- resolution: -> fixed stage: -> resolved status: open -> closed versions: +Python 3.6 ___ Python tracker ___ ___

[issue27185] Clarify Test Coverage for the String Module (test_pep292 is not easily discoverable)

2016-06-02 Thread Benjamin Peterson
Benjamin Peterson added the comment: I'm not too concerned about that. git can handle it well, which we will have soon. On Thu, Jun 2, 2016, at 12:50, Serhiy Storchaka wrote: > > Serhiy Storchaka added the comment: > > This is not so easy. After adding all the tests from test_pep292.py into >

[issue19234] socket.fileno() documentation

2016-06-02 Thread Zachary Ware
Zachary Ware added the comment: I think the additions are redundant; pick one or the other. The first should be sufficient. -- nosy: +zach.ware stage: -> patch review versions: +Python 2.7, Python 3.5, Python 3.6 ___ Python tracker

[issue26829] update docs: when creating classes a new dict is created for the final class object

2016-06-02 Thread R. David Murray
R. David Murray added the comment: Your suggested wording isn't correct, I'm afraid. This subject is complex and somewhat obscure...I checked with Ethan to make sure my interpretation was correct. The problem this issue is addressing is the fact that when type.__new__ is called (as in the me

[issue21776] distutils.upload uses the wrong order of exceptions

2016-06-02 Thread Roundup Robot
Roundup Robot added the comment: New changeset 17e7d6c4f082 by Berker Peksag in branch '3.5': Issue #21776: distutils.upload now correctly handles HTTPError https://hg.python.org/cpython/rev/17e7d6c4f082 New changeset 421bc6ae9b6f by Berker Peksag in branch 'default': Issue #21776: Merge from 3.

[issue21776] distutils.upload uses the wrong order of exceptions

2016-06-02 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the patch, Claudiu. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue19611] inspect.getcallargs doesn't properly interpret set comprehension code objects.

2016-06-02 Thread R. David Murray
R. David Murray added the comment: Yes, it feels ugly. I'd rather "fix" the source of the problem (the weird positional attribute name). I have no idea if argument clinic would be of any help here, I haven't looked at how these things come to be. -- _

[issue27185] Clarify Test Coverage for the String Module (test_pep292 is not easily discoverable)

2016-06-02 Thread R. David Murray
R. David Murray added the comment: Benjamin: meaning we should wait for git to merge it, or git will automatically handle the history after conversion? -- ___ Python tracker ___

[issue19611] inspect.getcallargs doesn't properly interpret set comprehension code objects.

2016-06-02 Thread Yury Selivanov
Yury Selivanov added the comment: > Yes, it feels ugly. I'd rather "fix" the source of the problem (the weird > positional attribute name). +1. > I have no idea if argument clinic would be of any help here, I haven't looked > at how these things come to be. Me neither. Serhiy, what do you

[issue27185] Clarify Test Coverage for the String Module (test_pep292 is not easily discoverable)

2016-06-02 Thread Benjamin Peterson
Benjamin Peterson added the comment: We should be able to commit it now. git blame can usually figure out this stuff post facto. On Thu, Jun 2, 2016, at 13:54, R. David Murray wrote: > > R. David Murray added the comment: > > Benjamin: meaning we should wait for git to merge it, or git will >

[issue19611] inspect.getcallargs doesn't properly interpret set comprehension code objects.

2016-06-02 Thread Jelle Zijlstra
Jelle Zijlstra added the comment: Since this only comes up with manually created functions (through calling types.FunctionType), I think it wouldn't be unreasonable to just not handle this case in the inspect module and close this as wontfix. Ned, is there a use case for converting comprehensi

[issue27181] Add geometric mean to `statistics` module

2016-06-02 Thread Raymond Hettinger
New submission from Raymond Hettinger: Steven, this seems like a reasonable suggestion (though I would expect someone else will immediately suggest a harmonic mean as well). Is this within the scope of what you were trying to do with the statistics module? -- assignee: -> steven.dap

[issue27187] Relax __all__ location requirement in PEP 8

2016-06-02 Thread Barry A. Warsaw
New submission from Barry A. Warsaw: PEP 8 says: Put any relevant __all__ specification after the imports. I don't remember why we wanted __all__ to go after imports. I think we should relax that since other dunders can go before imports. See related PYCQA issue: https://github.com/PyCQA/pyc

[issue27187] Relax __all__ location requirement in PEP 8

2016-06-02 Thread Barry A. Warsaw
Changes by Barry A. Warsaw : -- assignee: -> docs@python components: +Documentation nosy: +docs@python ___ Python tracker ___ ___ Pyt

[issue26589] Add HTTP Response code 451

2016-06-02 Thread Raymond Hettinger
Raymond Hettinger added the comment: Thanks Nathan, I'll apply this shortly. -- assignee: -> rhettinger ___ Python tracker ___ ___ Py

[issue21446] Update reload fixer to use importlib instead of imp

2016-06-02 Thread Jelle Zijlstra
Jelle Zijlstra added the comment: I couldn't find references in the docs to clarify what version of 3.x 2to3 targets, but it seems reasonable to me that it produces code targeted to the version of CPython it was bundled with. imp is deprecated and presumably will be removed later in 3.x, so it

[issue27113] sqlite3 connect parameter "check_same_thread" not documented

2016-06-02 Thread Dave Sawyer
Dave Sawyer added the comment: The user probably has a recent enough version. This is guaranteed on Windows since Python bundles 3.6 or later. On mac or Linux it will use the version installed on the machine. I'll make a separate patch to check the version in sqlite3.py so it will give an erro

  1   2   3   >