[issue30876] SystemError on importing module from unloaded package

Changes by Serhiy Storchaka : -- pull_requests: +2743 ___ Python tracker ___ ___

[issue10438] list an example for calling static methods from WITHIN classes

Raymond Hettinger added the comment: Ian, the docs mostly serve to tell what a tool does. Best practices then emerge from actual practices and are determined by users. I don't see any bug here that needs to be solved and think it is time to close this tracker item. It has been consuming

[issue30876] SystemError on importing module from unloaded package

Serhiy Storchaka added the comment: New changeset 8a9cd20edca7d01b68292036029ae3735ce65edd by Serhiy Storchaka in branch 'master': bpo-30876: Relative import from unloaded package now reimports the package (#2639)

[issue30876] SystemError on importing module from unloaded package

Serhiy Storchaka added the comment: What about other branches? Should we backport this change to them? I think that even if not backport this change we should change SystemError to more appropriate exception. -- ___ Python tracker

[issue30876] SystemError on importing module from unloaded package

Nick Coghlan added the comment: The fix is unintrusive enough that I'm +1 for also fixing it in 3.6 and 3.5. Trying to fix it in 2.7 would likely be more trouble than it's worth, but I also wouldn't be opposed to fixing it there if you or anyone else wanted to do it. --

[issue30730] [security] Injecting environment variable in subprocess on Windows

Larry Hastings added the comment: Serhiy, I don't see where you got a full review of this change. Eryksun reviewed the code and asked for changes; you made the he asked for changes but didn't get any further review. Nor did you get a full review / "looks good to me" from anybody. As a

[issue28812] Deadlock between GIL and pystate head_mutex.

INADA Naoki added the comment: #30395 is about forking, but this is about multi threading. -- ___ Python tracker ___

[issue30903] IPv4Network's hostmask attribute doesn't returns string value as mentioned in Documentation.

New submission from Abhijit Mamarde: documentation mentions hostmask attribute of IPv4Network class returns a `string`, but in actual it is returning the object of class IPv4Address URL to official doc: https://docs.python.org/3/library/ipaddress.html#ipaddress.IPv4Network.hostmask PFA program

[issue26657] Directory traversal with http.server and SimpleHTTPServer on windows

Larry Hastings added the comment: Will this be backported to 3.3 or 3.6? I don't see a PR or checkin for either of those versions on this issue, and both those versions are open for security fixes.b -- nosy: +larry ___ Python tracker

[issue30730] [security] Injecting environment variable in subprocess on Windows

Larry Hastings added the comment: (never-mind, 3.6.1 still permits this, but I see that it's been fixed in trunk) -- ___ Python tracker ___

[issue30801] shoutdown process error with python 3.4 and pyqt/PySide

Larry Hastings added the comment: Python 3.4 no longer accepts bug fixes; it is in "security fixes only" mode. Since this is not a security fix, it will not be accepted into Python 3.4. If this bug affects other versions of Python, please file a new bug. Although, unless you move *very*

[issue30779] IDLE: configdialog -- factor out Changes class

Changes by Cheryl Sabella : -- pull_requests: +2733 ___ Python tracker ___ ___

[issue30730] [security] Injecting environment variable in subprocess on Windows

Larry Hastings added the comment: It seems that os.execve() still permits this, even on Windows. Shouldn't we solve it there too? (Thanks to Steve Dower for realizing this.) -- import os cmdline=["/usr/bin/printenv"] env={'a=b': 'c'} os.execve(cmdline[0], cmdline, env) # this prints a=b=c

[issue30902] Python-Redmine plugin not seeing python install MacOS

Berker Peksag added the comment: python-redmine is not part of the Python standard library. https://github.com/maxtepkeev/python-redmine/issues is a better place to ask usage questions like this, thank you! -- nosy: +berker.peksag resolution: -> third party stage: -> resolved

[issue30730] [security] Injecting environment variable in subprocess on Windows

Serhiy Storchaka added the comment: Sorry, actually the patch fixed two bugs. The one of them is a security issue, the other is much more severe. They look similar, are related to the same code (on Windows) and are tested with similar tests. os.execve() was not vulnerable to the first issue,

[issue29591] expat 2.2.0: Various security vulnerabilities in bundled expat (CVE-2016-0718 and CVE-2016-4472)

Larry Hastings added the comment: I don't quite understand what's happening on this issue. I see that master, 3.6, 3.6, and 2.7 have been upgraded to expat 2.2.0. This issue was created to upgrade CPython to 2.2.0. But the PR against 3.3 and 3.4 upgrade expat to 2.2.1?! I'm not against

[issue30779] IDLE: configdialog -- factor out Changes class

Cheryl Sabella added the comment: I had an error when trying to delete a custom theme. Sorry for not catching this before. -- ___ Python tracker ___

[issue30905] Embedding should have public API for interactive mode

New submission from Stephen Kelly: Consider the following three snippets: 1) const char* sourceCode = "a = 9\n" "a"; // This is OK! Python runs both lines. // BUT: The value of 'a' is not printed PyRun_StringFlags(sourceCode, Py_file_input, localDictionary, localDictionary, 0);

[issue30730] [security] Injecting environment variable in subprocess on Windows

Larry Hastings added the comment: New changeset fe82c46327effc124ff166e1fa1e611579e1176b by larryhastings (Serhiy Storchaka) in branch '3.4': [security][3.4] bpo-30730: Prevent environment variables injection in subprocess on Windows. (GH-2325) (#2362)

[issue30902] Python-Redmine plugin not seeing python install MacOS

New submission from Joshua: trying to install the following on macos sierra 10.12.5. I am trying to install the python-redmine module. i ran the following: sudo easy_install pip pip install python-redmine i get the following output when trying to run a python script: Joshuas-MacBook-Pro:~

[issue30904] Python 3 logging HTTPHandler sends duplicate Host header

New submission from Leon Helwerda: The logging HTTPHandler sends two Host headers which confuses certain servers. Tested versions: Python 3.6.1 lighttpd/1.4.45 Steps to reproduce (MWE): 1) Set up a lighttpd server which is to act as the logging host (we do not actually implement anything

[issue30484] Garbage Collector can cause Segfault whilst iterating dictionary items

Larry Hastings added the comment: Yes, and thank you for submitting the PR to backport it to 3.4! (And thank you for backporting it to 3.3, too!) -- ___ Python tracker

[issue27945] Various segfaults with dict

Larry Hastings added the comment: New changeset f7344798e57da6b9c4ed9372e8eaecde80989c86 by larryhastings (Serhiy Storchaka) in branch '3.4': [3.4] [3.5] bpo-27945: Fixed various segfaults with dict. (GH-1657) (GH-1678) (#2248)

[issue27099] IDLE: turn builting extensions into regular modules

Charles Wohlganger added the comment: Pull request won't pass build test, but passes the full idle test on my workstation. Primary cause seems to be: ImportError: cannot import name 'EditorWindow' from 'idlelib.editor' I can also import EditorWindow by itself on my workstation. None of the

[issue30797] ./pyconfig.h:1438:0: warning: "_GNU_SOURCE" redefined [enabled by default]

Changes by Segev Finer : -- pull_requests: +2736 ___ Python tracker ___ ___

[issue27584] New addition of vSockets to the python socket module

Gregory P. Smith added the comment: yep, linux/vm_sockets.h exists. I believe it's kernel headers are from 4.9. -- ___ Python tracker ___

[issue27584] New addition of vSockets to the python socket module

Cathy Avery added the comment: OK thanks! -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue27584] New addition of vSockets to the python socket module

Gregory P. Smith added the comment: I updated my PGO buildbot to Debian 9 which should have them. http://buildbot.python.org/all/builders/AMD64%20Debian%20PGO%203.x ~$ grep AF_VSOCK /usr/include/*/*/* /usr/include/x86_64-linux-gnu/bits/socket.h:#define AF_VSOCKPF_VSOCK --

[issue27584] New addition of vSockets to the python socket module

Cathy Avery added the comment: You will also need linux/vm_sockets.h in order to build. -- ___ Python tracker ___

[issue10438] list an example for calling static methods from WITHIN classes

Ian added the comment: I would hope that the docs would cater to people who aren't sure how the language works (and who want to confirm that they are using proper patterns). If people already know how the language works, they won't need the docs. Whether or not you refer to Java and C++, you

[issue27364] Deprecate invalid escape sequences in str/bytes

R. David Murray added the comment: Also note that we have fixed a number of bugs in the stdlib code where a raw string was not used for a docstring when it should have been. And when I say bugs, I mean both formatting problems in pydoc, and doctest bugs. There may even have been a case

[issue30901] "503 HTTP ERROR" on attempt to access some points of python library documentation

Brett Cannon added the comment: Those pages all work for me. May have been transient. -- nosy: +brett.cannon resolution: -> out of date stage: -> resolved status: open -> closed ___ Python tracker

[issue30897] Add a is_mount() to pathlib

Changes by Cooper Lees : -- pull_requests: +2735 ___ Python tracker ___ ___

[issue30891] importlib: _find_and_load() race condition on sys.modules[name] check

Changes by Cooper Lees : -- pull_requests: +2734 ___ Python tracker ___ ___

[issue30901] "503 HTTP ERROR" on attempt to access some points of python library documentation

Mariatta Wijaya added the comment: There was partial outage. See post mortem report: https://status.python.org/incidents/cc622spyl26l -- nosy: +Mariatta ___ Python tracker

[issue10438] list an example for calling static methods from WITHIN classes

R. David Murray added the comment: I'm not sure there's a "best practice" choice between the two calling forms that are documented. Although obviously when you don't have an instance you can't use the instance calling form. I think it is *common* practice to use the instance form when you

[issue27099] IDLE: turn builting extensions into regular modules

Cheryl Sabella added the comment: When I download the patch and run the tests, I get a lot of warnings (mostly on custom themes and custom keysets). I also get errors in test_parenmatch like this one: ERROR: test_paren_styles (idlelib.idle_test.test_parenmatch.ParenMatchTest)

[issue30821] unittest.mock.Mocks with specs aren't aware of default arguments

Michael Foord added the comment: Generally the called with asserts can only be used to match the *actual call*, and they don't determine "equivalence". To do it cleanly would be tricky, and adding complex code is a maintenance burden. I'm not convinced there's a massive use case - generally

[issue29591] expat 2.2.0: Various security vulnerabilities in bundled expat (CVE-2016-0718 and CVE-2016-4472)

Larry Hastings added the comment: Please instead choose to use bpo-30694 for the upgrades of 3.3 and 3.4 to expat 2.2.1. I guess there are historical reasons why the PRs are here, but bpo stands as a historical record; let's not confuse posterity by upgrading to 2.2.1 using a bpo issue

[issue27584] New addition of vSockets to the python socket module

Gregory P. Smith added the comment: Everything compiles successfully on this host - configure detects the header has HAVE_LINUX_VM_SOCKETS_H set to 1. test_socket passes on this host. However since i'm not running with a /dev/vsock, the unittests (correctly) skip the new tests.

[issue29591] expat 2.2.0: Various security vulnerabilities in bundled expat (CVE-2016-0718 and CVE-2016-4472)

STINNER Victor added the comment: > I don't quite understand what's happening on this issue. I see that master, > 3.6, 3.6, and 2.7 have been upgraded to expat 2.2.0. This issue was created > to upgrade CPython to 2.2.0. But the PR against 3.3 and 3.4 upgrade expat to > 2.2.1?! > > I'm not

[issue27584] New addition of vSockets to the python socket module

Cathy Avery added the comment: That should do it. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue30891] importlib: _find_and_load() race condition on sys.modules[name] check

Changes by STINNER Victor : -- pull_requests: -2734 ___ Python tracker ___ ___

[issue30797] ./pyconfig.h:1438:0: warning: "_GNU_SOURCE" redefined [enabled by default]

STINNER Victor added the comment: New changeset 884c4ca33ab84b9fc57338cf59f79e0436d3da43 by Victor Stinner (Segev Finer) in branch '2.7': [2.7] bpo-30797: Avoid _GNU_SOURCE redefined warning in xmlparse.c (GH-2670) (#2672)

[issue30906] os.path.join misjoins paths

Eryk Sun added the comment: This differs slightly from WinAPI PathCchCombineEx, which fails the example case as an invalid parameter. If the second path is rooted but without a drive or UNC share, then if the first path is relative it must be at least drive relative (e.g. "C:dir1"). Should

[issue30876] SystemError on importing module from unloaded package

Changes by STINNER Victor : -- pull_requests: +2731 ___ Python tracker ___ ___

[issue30870] IDLE: configdialog/fonts: change font when select by key up/down

Changes by Louie Lu : -- pull_requests: +2732 ___ Python tracker ___ ___ Python-bugs-list

[issue29591] expat 2.2.0: Various security vulnerabilities in bundled expat (CVE-2016-0718 and CVE-2016-4472)

STINNER Victor added the comment: Larry: "Please instead choose to use bpo-30694 for the upgrades of 3.3 and 3.4 to expat 2.2.1. I guess there are historical reasons why the PRs are here, but bpo stands as a historical record; let's not confuse posterity by upgrading to 2.2.1 using a bpo

[issue30906] os.path.join misjoins paths

New submission from mesheb82: I'm trying to join paths on Windows with data taken from a user generated file. In doing so, I came across: >>> os.path.join('dir1', '/dir2') '/dir2' I'd expect an error or: 'dir1\\dir2' This has been tested and is consistent with Python 2.7.13 and

[issue27099] IDLE: turn builting extensions into regular modules

Charles Wohlganger added the comment: Thank you, Cheryl Sabella. I think I've found which tests I've missed running. Now to fix all the bugs... -- ___ Python tracker

[issue30694] Update embedded copy of expat to 2.2.1

Changes by STINNER Victor : -- pull_requests: +2737 ___ Python tracker ___ ___

[issue30694] Update embedded copy of expat to 2.2.1

Changes by STINNER Victor : -- pull_requests: +2738 ___ Python tracker ___ ___

[issue29591] expat 2.2.0: Various security vulnerabilities in bundled expat (CVE-2016-0718 and CVE-2016-4472)

STINNER Victor added the comment: I changed the PR title to mention the two bpo. -- ___ Python tracker ___

[issue28812] Deadlock between GIL and pystate head_mutex.

Pádraig Brady added the comment: This can probably closed as a dupe of #30395 -- nosy: +pixelbeat ___ Python tracker ___

[issue30898] SSL cert failure running make test during Python 3.6 install

New submission from Ben Johnston: Installing Python 3.6.1 from Python-3.6.1.tar.xz on Ubuntu 16.04.2 LTS, the following tests are failing: ERROR: test_logincapa_with_client_certfile (test.test_imaplib.RemoteIMAP_SSLTest) ERROR: test_logincapa_with_client_ssl_context

[issue30899] IDLE: Add idle config parser unittest

Changes by Louie Lu : -- pull_requests: +2727 ___ Python tracker ___ ___ Python-bugs-list

[issue30899] IDLE: Add idle config parser unittest

New submission from Louie Lu: Add IdleConfParser and IdleUserConfParser unittest. -- assignee: terry.reedy components: IDLE messages: 298126 nosy: louielu, terry.reedy priority: normal severity: normal status: open title: IDLE: Add idle config parser unittest versions: Python 3.7

[issue30870] IDLE: configdialog/fonts: change font when select by key up/down

Changes by Terry J. Reedy : -- pull_requests: +2726 ___ Python tracker ___ ___

[issue30870] IDLE: configdialog/fonts: change font when select by key up/down

Terry J. Reedy added the comment: New changeset 953e527763f5af293668135acdf5f0a20c3f6f4f by terryjreedy in branch '3.6': [3.6] bpo-30870: IDLE -- fix logic error in eae2537. (GH-2660) (#2661) https://github.com/python/cpython/commit/953e527763f5af293668135acdf5f0a20c3f6f4f --

[issue30899] IDLE: Add idle config parser unittest

Terry J. Reedy added the comment: I plan to review tomorrow afternoon. -- nosy: +csabella ___ Python tracker ___

[issue30870] IDLE: configdialog/fonts: change font when select by key up/down

Louie Lu added the comment: It seem setUpModule will smash out the test, I've add a trust-will-work test inside the test_configdialog.py: class Test(unittest.TestCase): def setUp(self): self.root = tkinter.Tk() def test_test(self): self.root.bind('', lambda x:

[issue30900] IDLE: Fix configdialog should use wm_withdraw

New submission from Louie Lu: Introduce in #30728, commit bac7d3363b099d, `self.wm_withdraw` has been changed into `self.withdraw`. This make #30870 un-testable since it using `self.withdraw` will block out `event_generate`. This issue revert `self.widthdraw` to `self.wm_withdraw`.

[issue30891] importlib: _find_and_load() race condition on sys.modules[name] check

Changes by STINNER Victor : -- pull_requests: +2730 ___ Python tracker ___ ___

[issue22607] find by dichotomy the failing test

STINNER Victor added the comment: > See message 228968 for the rationale: http://bugs.python.org/issue22588#msg228968 Ok, this use case is now well supported by the new test.bisect tool. Yes, this issue is a duplicate of the issue #29512. I forgot this old issue! -- resolution: ->

[issue30881] IDLE: add docstrings to browser.py

Terry J. Reedy added the comment: New changeset ba352270b724d67fc938c335c605acdee7474308 by terryjreedy (csabella) in branch 'master': bpo-30881: IDLE: add docstrings to browser.py (#2638) https://github.com/python/cpython/commit/ba352270b724d67fc938c335c605acdee7474308 --

[issue30870] IDLE: configdialog/fonts: change font when select by key up/down

Louie Lu added the comment: It just get wierd, I can't do event_generate with Terry, too. Attach poc.py that should print out a 'testing', but it didn't. -- Added file: http://bugs.python.org/file47006/tests.py ___ Python tracker

[issue30881] IDLE: add docstrings to browser.py

Changes by Terry J. Reedy : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.6 ___ Python tracker

[issue30881] IDLE: add docstrings to browser.py

Terry J. Reedy added the comment: New changeset 675c1adfe5c87573e81fb295ccad7b6cfa03a3ee by terryjreedy in branch '3.6': [3.6] bpo-30881: IDLE: add docstrings to browser.py (GH-2638) (#2663) https://github.com/python/cpython/commit/675c1adfe5c87573e81fb295ccad7b6cfa03a3ee --

[issue25746] test_unittest failure in leaks searching mode

Serhiy Storchaka added the comment: Fixed in duplicate issue30813. -- resolution: -> fixed stage: needs patch -> resolved status: open -> closed superseder: -> test_unittest fails when hunting reference leaks ___ Python tracker

[issue30901] "503 HTTP ERROR" on attempt to access some points of python library documentation

Louie Lu added the comment: Can reproduce this problem in Chromium 59.0.3071, it seems affect every selectable version in docs.python.org. Also, devguide has some page down, too. * devguide: https://docs.python.org/devguide/triaging.html -- nosy: +louielu type: resource usage ->

[issue30900] IDLE: Fix configdialog should use wm_withdraw

Louie Lu added the comment: Hmmm, I think it is a mistake of my test, it is something inside configdialog __init__ make unittest can't do event_generate, but not this one `self.withdraw`. -- resolution: -> not a bug stage: -> resolved status: open -> closed

[issue30899] IDLE: Add idle config parser unittest

Changes by Terry J. Reedy : -- stage: -> patch review type: -> enhancement versions: +Python 3.6 ___ Python tracker ___

[issue30881] IDLE: add docstrings to browser.py

Changes by Terry J. Reedy : -- pull_requests: +2728 ___ Python tracker ___ ___

[issue30813] test_unittest fails when hunting reference leaks

Serhiy Storchaka added the comment: Ah, this fixed issue25746! -- nosy: +serhiy.storchaka ___ Python tracker ___

[issue30870] IDLE: configdialog/fonts: change font when select by key up/down

Louie Lu added the comment: configdialog misuse `self.withdraw` at init, it should be `self.wm_withdraw`, #30900 fix this problem. After that, it should be a success to use event_generate in configdialog unittest with no `self.withdraw`. -- ___

[issue30900] IDLE: Fix configdialog should use wm_withdraw

Changes by Louie Lu : -- pull_requests: +2729 ___ Python tracker ___ ___ Python-bugs-list

[issue22607] find by dichotomy the failing test

Serhiy Storchaka added the comment: Wasn't the similar feature implemented in issue29512? -- nosy: +serhiy.storchaka ___ Python tracker ___

[issue30901] "503 HTTP ERROR" on attempt to access some points of python library documentation

New submission from Alexander Kamyanskiy: I found that some points in Python Library reference documentation are not accessible, I got 503 http error. The problem starts from this link and some points below the 29.14 point of doc list: https://docs.python.org/3/library/fpectl.html Also now

[issue30900] IDLE: Fix configdialog should use wm_withdraw

Terry J. Reedy added the comment: Color me dubious ;-). The change was made because tkinter.__init__, line 1990 has this line withdraw = wm_withdraw There is a similar line for all of the around 30 wm_xyz functions. Prefixing the names of methods of class Wm is an unusual redundancy. I

[issue30900] IDLE: Fix configdialog should use wm_withdraw

Terry J. Reedy added the comment: I first beat my head against event_generate two or three years ago. So I appreciate you taking a whack at it. It is nice that Variable.set and invoke can be used for tests, but it would really be nice to have e_v work too. --

[issue30897] Add a is_mount() to pathlib

Changes by Łukasz Langa : -- nosy: +lukasz.langa ___ Python tracker ___ ___ Python-bugs-list

[issue27584] New addition of vSockets to the python socket module

R. David Murray added the comment: I think we are waiting on confirmation that we have a buildbot that has the necessary headers. -- ___ Python tracker

[issue10438] list an example for calling static methods from WITHIN classes

R. David Murray added the comment: Given a choice between catering for Python programmers and catering for Java/C++ programmers, the Python docs obviously ought to chose to cater to Python programmers. To a python programmer, calling C.f() is intuitive. I would myself definitely *not*

[issue29812] test for token.py, and consistency tests for tokenize.py

Ammar Askar added the comment: No problem, closing this in favor of issue 30455. -- resolution: -> out of date stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue30797] ./pyconfig.h:1438:0: warning: "_GNU_SOURCE" redefined [enabled by default]

Changes by Segev Finer : -- pull_requests: +2739 ___ Python tracker ___ ___

[issue30797] ./pyconfig.h:1438:0: warning: "_GNU_SOURCE" redefined [enabled by default]

Changes by Segev Finer : -- pull_requests: +2740 ___ Python tracker ___ ___

[issue30906] os.path.join misjoins paths

Paul Moore added the comment: This is as documented - see https://docs.python.org/3.6/library/os.path.html#os.path.join (" If a component is an absolute path, all previous components are thrown away and joining continues from the absolute path component"). In this case, "/dir2" is an

[issue30779] IDLE: configdialog -- factor out Changes class

Terry J. Reedy added the comment: Eventually, we will have tests that would have caught this. I took the opportunity to improve the test for the call. -- ___ Python tracker

[issue30779] IDLE: configdialog -- factor out Changes class

Terry J. Reedy added the comment: New changeset 6d13b22e3ab262c6b1f068259aebd705e7da316c by terryjreedy (csabella) in branch 'master': bpo-30779: IDLE: fix changes.delete_section calls in configdialog (#2667) https://github.com/python/cpython/commit/6d13b22e3ab262c6b1f068259aebd705e7da316c

[issue30779] IDLE: configdialog -- factor out Changes class

Terry J. Reedy added the comment: New changeset c0179483f13be81910ed73889dcad92528e20ef2 by terryjreedy in branch '3.6': [3.6] bpo-30779: IDLE: fix changes.delete_section calls in configdialog (GH-2667) (#2674) https://github.com/python/cpython/commit/c0179483f13be81910ed73889dcad92528e20ef2

[issue30717] str.center() is not unicode aware

Changes by Roundup Robot : -- pull_requests: +2741 ___ Python tracker ___

[issue30779] IDLE: configdialog -- factor out Changes class

Changes by Terry J. Reedy : -- pull_requests: +2742 ___ Python tracker ___ ___

[issue30890] IDLE: Input method error in comment with Korean language

Terry J. Reedy added the comment: I am thinking that this is a artifact of the combination of monitor pixel and subpixel type, size, and arrangement; font type and size; particular character; and character generation software. When I load the file in IDLE, the Korean comment chars are a nice

[issue30717] str.center() is not unicode aware

Guillaume Sanchez added the comment: Hello to all of you, sorry for the delay. Been busy. I added the base code needed to built the grapheme cluster break algorithm. We now have the GraphemeBreakProperty available via unicodedata.grapheme_cluster_break() Can you check that the implementation