[issue31452] asyncio.gather does not cancel tasks if one fails

Yury Selivanov added the comment: I looked at the PR, and I'm not so sure about this change. In short, it can be viewed as a backwards incompatible change to asyncio.gather. Guido, what do you think? -- nosy: +gvanrossum ___ Python tracker

[issue31539] asyncio.sleep may sleep less time then it should

Antoine Pitrou added the comment: I don't think the bug is about real time here, rather about minimal sleep time expectations; i.e. it's expected that the sleep time may be *more* than asked for, but not less than. (and I would share that expectation myself) --

[issue31539] asyncio.sleep may sleep less time then it should

Changes by Antoine Pitrou : -- versions: +Python 3.7 ___ Python tracker ___ ___

[issue31539] asyncio.sleep may sleep less time then it should

STINNER Victor added the comment: IMHO we should either just close the issue, ir document the bad clock resolution on Windows in the asyncio doc. Yury: asyncio can trigger events earlier than scheduled for performance reasons. See end_time in asyncio core loop. --

[issue31549] test_strptime and test_time fail on non-English Windows

New submission from Serhiy Storchaka: test_strptime and test_time fail on non-English Windows. For example: == FAIL: test_localtime_timezone (test.test_time.TestPytime)

[issue31539] asyncio.sleep may sleep less time then it should

Antoine Pitrou added the comment: Le 21/09/2017 à 23:31, STINNER Victor a écrit : > > Yury: asyncio can trigger events earlier than scheduled for performance > reasons. If that's true, then it sounds like a bug. If there is a rationale for a "fast and imprecise" API, then it would seem ok to

[issue31539] asyncio.sleep may sleep less time then it should

Changes by Antoine Pitrou : -- nosy: +gvanrossum ___ Python tracker ___ ___ Python-bugs-list

[issue26103] Contradiction in definition of "data descriptor" between (dotted lookup behavior/datamodel documentation) and (inspect lib/descriptor how-to)

Serhiy Storchaka added the comment: The only question is remained -- should *data descriptors* be *descriptors*? I.e. is the __get__ method required for data descriptors? -- ___ Python tracker

[issue31548] test_os fails on Windows if current directory contains spaces

New submission from Serhiy Storchaka: I just have built Python on Windows first time and ran tests. test_os fails because the current directory path contains spaces. test_spawnl (test.test_os.SpawnTests) ... C:\Users\Serhiy: can't open file 'Storchaka\py\cpython\PCBuild\win32\python.exe':

[issue30346] Odd behavior when unpacking `itertools.groupby`

Serhiy Storchaka added the comment: Ping. Can you make your decision Raymond? This issue is a stopper for issue30347 which fixes a crash. I don't want to merge the fix for issue30347 until this issue be solved, because both proposed PRs solve issue30347 too, and I don't want to make unneeded

[issue31544] gettext.Catalog title is not flagged as a class

Éric Araujo added the comment: Are you talking about https://docs.python.org/3/library/gettext.html#the-catalog-constructor ? I think the lack of markup is on purpose, since the text explains that this is a compatibility measure (mostly obsolete nowadays). For future bug reports, please

[issue31092] multiprocessing.Manager() race condition

Changes by Prof Plum : -- title: Potential multiprocessing.Manager() race condition -> multiprocessing.Manager() race condition ___ Python tracker

[issue31153] Update docstrings of itertools functions

Serhiy Storchaka added the comment: For groupby() see also issue27385. -- ___ Python tracker ___ ___

[issue31543] Optimize wrapper descriptors using FASTCALL

STINNER Victor added the comment: The most complex slots are __new__, __init__ and __call__ because they accept keywords. It's hard to design a calling convention which optimize all cases because of the backward compatibility. The risk is to convert a dict to args + kwnames (tuple) and then back

[issue31539] asyncio.sleep may sleep less time then it should

STINNER Victor added the comment: Issues: - bpo-20320 - bpo-20452 - bpo-20505 - bpo-20311 The performance issue was that the asyncio core loop was running in a loop but did nothing because of time rounding. When the next event was in a few nanoseconds, the e event burnt the CPU during seconds.

[issue31543] Optimize wrapper descriptors using FASTCALL

Serhiy Storchaka added the comment: These slots are the only slots that accept keyword arguments and arbitrary number of positional parameters. Other slots can use fast calls. -- ___ Python tracker

[issue31539] asyncio.sleep may sleep less time then it should

Yury Selivanov added the comment: > it's expected that the sleep time may be *more* than asked for, but not less > than. Exactly, and asyncio tries to ensure that. It looks like "time.get_clock_info('monotonic').resolution" lies about monotonic clock resolution on Windows so that might be

[issue31539] asyncio.sleep may sleep less time then it should

Yury Selivanov added the comment: So here's the relevant piece of code: end_time = self.time() + self._clock_resolution while self._scheduled: handle = self._scheduled[0] if handle._when >= end_time: break handle =

[issue31539] asyncio.sleep may sleep less time then it should

Yury Selivanov added the comment: > The performance issue was that the asyncio core loop was running in a loop but did nothing because of time rounding. When the next event was in a few nanoseconds, the e event burnt the CPU during seconds. It can be 15 ms on Windows or 1 ms when using poll()

[issue31452] asyncio.gather does not cancel tasks if one fails

Guido van Rossum added the comment: I'm afraid I no longer have all the details of this design in my head, and I have no idea what the fix does (and no time to read up on everything). The OP says "If you do not await gather" -- what happens if you *do* await it? Do the tasks then get killed?

[issue31550] Inconsistent error message for TypeError with subscripting

New submission from Anthony Sottile: There's a bit of history I don't understand and couldn't find the appropriate trail for. The original error message from the 2.6 era: $ python2.6 -c 0[0] Traceback (most recent call last): File "", line 1, in TypeError: 'int' object is unsubscriptable

[issue31539] asyncio.sleep may sleep less time then it should

STINNER Victor added the comment: Technically, asyncii cannot wait exactly 100 ms on Windows. It will be more likely a sleep between 100-15 ms and 100+15 ms. Real time is really a complex topic. CPython with its stop-the-world garbage collector are not designed for real time. --

[issue27541] Repr of collection's subclasses

STINNER Victor added the comment: Why using type.__name__ rather than type.__qualname__? -- nosy: +haypo ___ Python tracker ___

[issue31543] Optimize wrapper descriptors using FASTCALL

Changes by STINNER Victor : -- keywords: +patch pull_requests: +3674 stage: -> patch review ___ Python tracker ___

[issue5885] uuid.uuid1() is too slow

Changes by Roundup Robot : -- pull_requests: +3673 ___ Python tracker ___

[issue31510] test_many_processes() of test_multiprocessing_spawn failed on x86-64 Sierra 3.x

STINNER Victor added the comment: test_many_processes() is made in two steps. The bug occurs at the second step which calls proc.terminate() on processes. Code of the test: @classmethod def _sleep_some(cls): time.sleep(100) @classmethod def _test_sleep(cls, delay):

[issue31376] test_multiprocessing_spawn randomly hangs AMD64 FreeBSD 10.x Shared 3.x

Changes by STINNER Victor : -- stage: -> resolved status: open -> closed ___ Python tracker ___

[issue31510] test_many_processes() of test_multiprocessing_spawn failed on x86-64 Sierra 3.x

Changes by STINNER Victor : -- nosy: +pitrou ___ Python tracker ___ ___

[issue27541] Repr of collection's subclasses

STINNER Victor added the comment: > Because reprs of Python implementations of collection use a bare __name__. Ah, maybe this module should be updated to use qualified name with the name in repr()? > __qualname__ is used only in combination with __module__. I was thinking at module.qualname,

[issue31544] gettext.Catalog title is not flagged as a class

New submission from linkid: In the ``gettext`` documentatino, in the title about the ``Catalog`` constructor, ``Catalog`` is not flagged as a class. -- assignee: docs@python components: Documentation messages: 302696 nosy: docs@python, linkid priority: normal severity: normal status:

[issue31543] Optimize wrapper descriptors using FASTCALL

Antoine Pitrou added the comment: > First I would like to know if it's worth it I don't know. What's the point of optimizing `array.array.__len__(obj)`? People usually call `len(obj)` for that... -- nosy: +pitrou ___ Python tracker

[issue31529] IDLE: Add docstrings and tests for editor.py reload functions

Terry J. Reedy added the comment: A good start, and big enough as it is, for the next big revision project ;-). -- versions: +Python 3.6 ___ Python tracker

[issue31546] PyOS_InputHook is not called when waiting for input() in Windows

Steve Dower added the comment: You're right, we're missing this section of code: if (PyOS_InputHook != NULL) (void)(PyOS_InputHook)(); Since we just call it and ignore anything it does, it should be safe enough to add it immediately before the ReadConsoleW call (inside the

[issue31539] asyncio.sleep may sleep less time then it should

R. David Murray added the comment: I can't reproduce this on a linux VM with 3.7 tip. I don't currently have a windows instance to test against. -- nosy: +r.david.murray ___ Python tracker

[issue27867] various issues due to misuse of PySlice_GetIndicesEx

Henk-Jaap Wagenaar added the comment: @serhiy.storchaka: review done. -- nosy: +Henk-Jaap Wagenaar ___ Python tracker ___

[issue31539] asyncio.sleep may sleep less time then it should

Antoine Pitrou added the comment: AFAIR the Windows clock has a 15ms granularity, so I'm not really surprised. In other words, I don't think `asyncio.sleep` sleeps less than expected, but that it's the imprecision of time.time() which gives you that impression. What happens if you replace

[issue31539] asyncio.sleep may sleep less time then it should

STINNER Victor added the comment: Clocks is a very complex topic, especially when you care of portability. See my PEP 418. asyncio uses time.monotonic() clock to not be impacted when the system clock ("wall clock") is updated by the administrator or automatically by NTP. On Windows,

[issue31546] PyOS_InputHook is not called when waiting for input() in Windows

Lam Yuen Hei added the comment: Attach python 3.5 call stack of the test script -- Added file: https://bugs.python.org/file47161/py35_call_stack.png ___ Python tracker

[issue31500] IDLE: Tiny font on HiDPI display

Changes by Terry J. Reedy : -- pull_requests: +3675 ___ Python tracker ___ ___

[issue31500] IDLE: Tiny font on HiDPI display

Terry J. Reedy added the comment: New changeset 0c4997f1919d8583353b12537a63dcbe7b9d280f by Terry Jan Reedy in branch '3.6': [3.6] bpo-31500: IDLE: Scale default fonts on HiDPI displays. (GH-3639) (#3686) https://github.com/python/cpython/commit/0c4997f1919d8583353b12537a63dcbe7b9d280f

[issue31546] PyOS_InputHook is not called when waiting for input() in Windows

New submission from Lam Yuen Hei: Since python 3.6, PyOS_InputHook is not called when waiting for IO in Windows. This causes issues with GUI framework like tkinter that relys on PyOS_InputHook to handle user interaction. I attached a test script. When running the script with python 3.5, the

[issue30302] Improve .__repr__ implementation for datetime.timedelta

Changes by Utkarsh Upadhyay : -- keywords: +patch pull_requests: +3677 stage: -> patch review ___ Python tracker ___

[issue31545] Fixing documentation for timedelta.

Changes by Utkarsh Upadhyay : -- keywords: +patch pull_requests: +3676 stage: -> patch review ___ Python tracker ___

[issue31545] Fixing documentation for timedelta.

New submission from Utkarsh Upadhyay: There are some instances in the documentation of datetime where the repr of timedelta is mentioned, which was changed in bpo-30302. Am making a PR shortly to address them. -- assignee: docs@python components: Documentation messages: 302700 nosy:

[issue31546] PyOS_InputHook is not called when waiting for input() in Windows

Lam Yuen Hei added the comment: Attach python 3.6 call stack of the test script -- Added file: https://bugs.python.org/file47162/py36_call_stack.png ___ Python tracker

[issue31539] asyncio.sleep may sleep less time then it should

Mikhail Gerasimov added the comment: STINNER Victor, thanks for explanation! I don't know if this issue has practical disadvantages, but such behavior seems to be confusing, especially, since it can be reproduced with event_loop.time() and asyncio doc says nothing about resolution -

[issue31510] test_many_processes() of test_multiprocessing_spawn failed on x86-64 Sierra 3.x

STINNER Victor added the comment: test_many_processes() test was added by Antoine Pitrou in bpo-30589. This test was mentionned in bpo-30703. -- ___ Python tracker

[issue31180] test_multiprocessing_spawn hangs randomly

STINNER Victor added the comment: Same issue on PPC64LE Fedora 3.x: http://buildbot.python.org/all/builders/PPC64LE%20Fedora%203.x/builds/1406/steps/test/logs/stdio -- title: test_multiprocessing_spawn hangs randomly on x86 Windows7 3.6 and AMD64 FreeBSD 10.x Shared 3.x ->

[issue31410] int.__repr__() is slower than repr()

Serhiy Storchaka added the comment: New changeset 5e02c7826f9797fb3add79b608ef51f7a62b3e5a by Serhiy Storchaka in branch 'master': bpo-31410: Optimized calling wrapper and classmethod descriptors. (#3481) https://github.com/python/cpython/commit/5e02c7826f9797fb3add79b608ef51f7a62b3e5a

[issue27541] Repr of collection's subclasses

Serhiy Storchaka added the comment: New changeset b3a77964ea89a488fc0e920e3db6d8477279f19b by Serhiy Storchaka in branch 'master': bpo-27541: Reprs of subclasses of some classes now contain actual type name. (#3631)

[issue31410] int.__repr__() is slower than repr()

STINNER Victor added the comment: Oh, nice optimization! I see that you reused the _PyMethodDef_RawFastCallDict() function that I added exactly for the same reason: prevent the creation of a temporary C function only created for a single call and then destroyed. -- nosy: +inada.naoki

[issue31538] mailbox does not treat external factories the same

Henk-Jaap Wagenaar added the comment: To me the documentation doesn't quite look right, in the case of no factory being passed, it runs: def __getitem__(self, key): """Return the keyed message; raise KeyError if it doesn't exist.""" if not self._factory: return

[issue31410] int.__repr__() is slower than repr()

Changes by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue27867] various issues due to misuse of PySlice_GetIndicesEx

Serhiy Storchaka added the comment: Could anyone please make review of the documentation? -- ___ Python tracker ___

[issue27541] Repr of collection's subclasses

Serhiy Storchaka added the comment: Thanks Raymond. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue27541] Repr of collection's subclasses

Serhiy Storchaka added the comment: Because reprs of Python implementations of collection use a bare __name__. __qualname__ is used only in combination with __module__. Using a single __qualname__ can be confused: foo.bar looks as a name bar in the module foo. Whether in reprs and error

[issue31543] Optimize wrapper descriptors using FASTCALL

New submission from STINNER Victor: Attached pull request adds a fastpath for wrapper descriptors to use the FASTCALL calling convention. It's a follow up of bpo-31410 and all my work on FASTCALL during Python 3.6 and 3.7 development cycles. Microbenchmark: ./python -m perf timeit -s 'import

[issue31532] Py_GetPath, Py_SetPath memory corruption due to mixed PyMem_New micex with PyMem_Raw_Free

Benjamin Peterson added the comment: New changeset 3d1e2ab584ed0175592b5be2a0bc98dc1723776a by Benjamin Peterson (nurelin) in branch 'master': bpo-31532: Fix memory corruption due to allocator mix (#3679) https://github.com/python/cpython/commit/3d1e2ab584ed0175592b5be2a0bc98dc1723776a

[issue31532] Py_GetPath, Py_SetPath memory corruption due to mixed PyMem_New micex with PyMem_Raw_Free

Changes by Roundup Robot : -- pull_requests: +3670 ___ Python tracker ___

[issue31536] `make regen-all` triggers wholesale rebuild

STINNER Victor added the comment: I may do the backport, or ask the bot to do it. Right now I prefer to check if everything is fine on all CI. -- resolution: fixed -> status: closed -> open ___ Python tracker

[issue31536] `make regen-all` triggers wholesale rebuild

Changes by STINNER Victor : -- nosy: +zach.ware ___ Python tracker ___ ___

[issue31532] Py_GetPath, Py_SetPath memory corruption due to mixed PyMem_New micex with PyMem_Raw_Free

Benjamin Peterson added the comment: New changeset 88d0663005d258526496d1f8ee0acb7103c69e80 by Benjamin Peterson (Miss Islington (bot)) in branch '3.6': [3.6] closes bpo-31532: Fix memory corruption due to allocator mix (GH-3679) (#3681)

[issue31493] IDLE cond context: fix code update and font update timers

Terry J. Reedy added the comment: The underlying issue is trying to coordinate two somewhat independent object systems (Python and Tcl). I don't know why the after loops were (apparently) stopped before #27099 and not after. The only difference I know of is the dropping of the reference to

[issue31546] PyOS_InputHook is not called when waiting for input() in Windows

Steve Dower added the comment: (Belongs inside Parser/myreadline.c in the _PyOS_WindowsConsoleReadline function) -- ___ Python tracker ___

[issue31550] Inconsistent error message for TypeError with subscripting

Changes by Anthony Sottile : -- keywords: +patch pull_requests: +3679 stage: -> patch review ___ Python tracker ___

[issue31452] asyncio.gather does not cancel tasks if one fails

Yury Selivanov added the comment: > I'm afraid I no longer have all the details of this design in my head, and I > have no idea what the fix does (and no time to read up on everything). Let's say we have three tasks: t1, t2, t3. Then we use gather on them: await gather(t1, t2, t3) Let's

[issue31543] Optimize wrapper descriptors using FASTCALL

Raymond Hettinger added the comment: This seems like a straight-forward win. I don't think we really need to see microbenchmarks before going forward with this one. -- nosy: +rhettinger ___ Python tracker

[issue1612262] Class Browser doesn't show internal classes

Terry J. Reedy added the comment: I am revising the codecontext patch to use comprehensions and the sort key option. I will rename the new function 'collect_objects' (GPolo) / '_traverse_node' (CSabella) as 'list_children' and have it return the name-object list, ordered by line number,

[issue31443] Possibly out of date C extension documentation

Changes by Stefan Krah : -- keywords: +patch pull_requests: +3678 stage: -> patch review ___ Python tracker ___

[issue31547] IDLE: Save definitions added to user keysets

New submission from Terry J. Reedy: User keysets are saved as a complete keyset, but users could edit the file and delete event-sequence pairs or add an incomplete set. When a keyset is used, default pairs are added for any that are missing, if the pair does not conflict with existing pairs.

[issue31443] Possibly out of date C extension documentation

Stefan Krah added the comment: Erik, if you are interested in Cygwin, could you please check that xxmodule.c builds on Cygwin with the patch? You need to uncomment a couple of lines in setup.py to build 'xx'. -- ___ Python tracker

[issue31543] Optimize wrapper descriptors using FASTCALL

STINNER Victor added the comment: > I don't know. What's the point of optimizing `array.array.__len__(obj)`? > People usually call `len(obj)` for that... Right, type.method(self) is less than common than self.method(). I looked at the stdlib. I found that the following method are called using

[issue31543] Optimize wrapper descriptors using FASTCALL

Serhiy Storchaka added the comment: It optimizes the same cases as bpo-31410. bpo-31410 removed a half of the overhead for wrapper descriptors, Victor's patch removes the remaining half. Actually it makes calling the descriptor faster than calling the corresponding builtin! But bpo-31410

[issue31288] IDLE tests: don't modify tkinter.messagebox.

Terry J. Reedy added the comment: Make sure to return result of messagebox calls, as did in #31287, fixed in #31502. -- ___ Python tracker ___

[issue31443] Possibly out of date C extension documentation

Stefan Krah added the comment: In fact, building _decimal should also fail on Cygwin if this were still an issue. -- ___ Python tracker ___

[issue27099] IDLE: turn built-in extensions into regular modules

Terry J. Reedy added the comment: Two of the TODOs already listed, and 2 more found in review, have been done. With these additions, I felt IDLE was ready for the 3.6.3rc1 and 3.7.0a1 releases last Monday. #31502 Fix problem with deleting user themes and keysets. #31480 Disable ZzDummy by

[issue31532] Py_GetPath, Py_SetPath memory corruption due to mixed PyMem_New micex with PyMem_Raw_Free

STINNER Victor added the comment: I'm curious. Would you mind to try to run your frozen application using PYTHONMALLOC=debug environment variable on a Python without the fix, to see if you get an error? I'm not sure that the debug hooks on memory allocators are set early enough to detect your

[issue31532] Py_GetPath, Py_SetPath memory corruption due to mixed PyMem_New micex with PyMem_Raw_Free

Vincent Gatine added the comment: Tried your suggestion. Nothing is printed and program still crash. -- ___ Python tracker ___

[issue31541] Mock called_with does not ensure self/cls argument is used

New submission from JonathanHuot: Mock "assert_called_with" does not contain a possibility to verify if "self" or "cls" is used when mock is called. So, in unittests, all tests are passing but code is broken. Example : Steps to reproduce: == class Something(object): def

[issue31542] pth files in site-packages of venvs are executed twice

New submission from Antony Lee: All's in the title: "pth files in site-packages of venvs are executed twice". For example, the following code sample prints "1" twice. python -mvenv /tmp/tmpenv echo 'import os; print(1)' >/tmp/tmpenv/lib/python3.6/site-packages/foo.pth source activate

[issue31512] Add non-elevated symlink support for dev mode Windows 10

Vidar Fauske added the comment: Thanks for the informative comments. I opened a PR based on this feedback. Would you mind checking if it conforms to what you had in mind? -- ___ Python tracker

[issue31540] Adding context in concurrent.futures.ProcessPoolExecutor

New submission from Thomas Moreau: The `ProcessPoolExecutor` processes start method can only be change by changing the global default context with `set_start_method` at the beginning of a script. We propose to allow passing a context argument in the constructor to allow more flexible control

[issue31500] IDLE: Tiny font on HiDPI display

Serhiy Storchaka added the comment: New changeset a96c96f5dab68d4e611af4b8caefd7268533fd9a by Serhiy Storchaka in branch 'master': bpo-31500: IDLE: Scale default fonts on HiDPI displays. (#3639) https://github.com/python/cpython/commit/a96c96f5dab68d4e611af4b8caefd7268533fd9a --

[issue31539] asyncio.sleep may sleep less time then it should

New submission from Mikhail: Originally faced here: https://stackoverflow.com/q/46306660/1113207 Simple code to reproduce: import asyncio import time async def main(): while True: asyncio.ensure_future(asyncio.sleep(1)) t0 = time.time()

[issue31351] ensurepip discards pip's return code which leads to broken venvs

Nick Coghlan added the comment: New changeset 9adda0cdf89432386b7a0a6199b580d287a1 by Nick Coghlan (Igor Filatov) in branch 'master': bpo-31351: Set return code in ensurepip when pip fails (GH-3626) https://github.com/python/cpython/commit/9adda0cdf89432386b7a0a6199b580d287a1

[issue31351] ensurepip discards pip's return code which leads to broken venvs

Changes by Roundup Robot : -- pull_requests: +3672 stage: commit review -> patch review ___ Python tracker ___