[issue32018] inspect.signature does not respect PEP 8

2017-11-15 Thread Dong-hee Na
Dong-hee Na added the comment: I've submitted a patch. :) -- ___ Python tracker ___

[issue32034] Error when unpickling IncompleteReadError

2017-11-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: There is the same issue with LimitOverrunError. I'm not sure that we should keep args the same. It affects __str__ and __repr__. badouxn overrides __str__. And the result of __repr__ currently looks like the exception

[issue32033] The pwd module implementation incorrectly sets some attributes to None

2017-11-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I disagree. This is an old API, a thin wrapper around standard POSIX API, and returning an empty string instead of None will make impossible to distinguish NULL from "". It is easy to convert None in an empty string in Python:

[issue32018] inspect.signature does not respect PEP 8

2017-11-15 Thread Yury Selivanov
Yury Selivanov added the comment: New changeset 762b9571c9c8c6b036f1bf90140a1d030b3f9a01 by Yury Selivanov (Dong-hee Na) in branch 'master': bpo-32018: Fix inspect.signature repr to follow PEP 8 (#4408)

[issue32018] inspect.signature does not respect PEP 8

2017-11-15 Thread Yury Selivanov
Change by Yury Selivanov : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue32038] Add API to intercept socket.close()

2017-11-15 Thread Antoine Pitrou
Antoine Pitrou added the comment: Ok, that sounds reasonable to me. Also cc'ing Ben Darnell (maintainer of Tornado) in case he wants to chime in. -- nosy: +Ben.Darnell ___ Python tracker

[issue32036] error mixing positional and non-positional arguments with `argparse`

2017-11-15 Thread Stefan Seefeld
Stefan Seefeld added the comment: It looks like https://bugs.python.org/issue14191 is a conversation about the same inconsistent behaviour. It is set to "fixed". Can you comment on this ? Should I follow the advice mentioned there about how to work around the issue ?

[issue32038] Add API to intercept socket.close()

2017-11-15 Thread Yury Selivanov
Yury Selivanov added the comment: > Why not instead add `loop.sock_close()`? It wouldn't help if the program calls `socket.close()` somewhere. This can happen easily in big code bases. Ideally (at least I think so) we need to provide a guarantee that the socket object

[issue32040] Sorting pahtlib.Paths does give the same order as sorting the (string) filenames of that pathlib.Paths

2017-11-15 Thread QbLearningPython
New submission from QbLearningPython : While testing a module, I have found a weird behaviour of pathlib package. I have a list of pathlib.Paths and I sorted() it. I assumed that the order retrieved by sorting a list of Paths would be the same as the order retrieved by

[issue32018] inspect.signature does not respect PEP 8

2017-11-15 Thread Dong-hee Na
Change by Dong-hee Na : -- nosy: +corona10 ___ Python tracker ___ ___

[issue32034] Error when unpickling IncompleteReadError

2017-11-15 Thread Yury Selivanov
Yury Selivanov added the comment: > Does such a fix looks correct to you ? No, this fix won't restore exception.args properly. I made a PR with a fix. -- ___ Python tracker

[issue32034] Error when unpickling IncompleteReadError

2017-11-15 Thread badouxn
badouxn added the comment: Typo in the last comment. The code should be: ''' def __init__(self, partial, expected): super().__init__(partial, expected) self.partial = partial self.expected = expected def __str__(self): return ("%d

[issue32036] error mixing positional and non-positional arguments with `argparse`

2017-11-15 Thread Stefan Seefeld
Stefan Seefeld added the comment: On 15.11.2017 12:54, R. David Murray wrote: > Can you reproduce this without your PosArgsParser? I can indeed (by simply commenting out the `action` argument to the `add_argument()` calls). That obviously results in all positional arguments

[issue32034] Error when unpickling IncompleteReadError

2017-11-15 Thread Yury Selivanov
Change by Yury Selivanov : -- pull_requests: +4358 ___ Python tracker ___ ___

[issue32038] Add API to intercept socket.close()

2017-11-15 Thread Yury Selivanov
New submission from Yury Selivanov : asyncio has a few APIs that accept a Python socket object: loop.sock_recv(), loop.sock_accept() etc. asyncio (and event loops such as uvloop) expect that it controls the socket for the duration of the call. However, it cannot prevent

[issue32039] timeit documentation should describe caveats

2017-11-15 Thread Barry A. Warsaw
New submission from Barry A. Warsaw : timeit is cool, but it's not appropriate for all performance testing. For example, since it uses only a single Python process, anything that's cached is not a good candidate for timeit profiling. The classic example is timing imports.

[issue32036] error mixing positional and non-positional arguments with `argparse`

2017-11-15 Thread R. David Murray
R. David Murray added the comment: Can you reproduce this without your PosArgsParser? -- nosy: +r.david.murray ___ Python tracker

[issue32021] Brotli encoding is not recognized by mimetypes

2017-11-15 Thread R. David Murray
R. David Murray added the comment: OK, bouncing around from those URL I finally found this: https://github.com/google/ngx_brotli/issues/28 That indicates unambiguously that someone does expect files to be pre-compressed on the server and that the main brotli package

[issue32038] Add API to intercept socket.close()

2017-11-15 Thread Antoine Pitrou
Antoine Pitrou added the comment: Why not instead add `loop.sock_close()`? -- ___ Python tracker ___

[issue32025] Add time.thread_time()

2017-11-15 Thread Antoine Pitrou
Change by Antoine Pitrou : -- keywords: +patch pull_requests: +4359 stage: -> patch review ___ Python tracker ___

[issue32040] Sorting pahtlib.Paths does give the same order as sorting the (string) filenames of that pathlib.Paths

2017-11-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Paths are ordered by lexicographical order of their corresponding components. Paths are not strings, and this this order is more natural for them. The alphabetical order of Path strings: SPAMS.txt SPAM\file.txt

[issue32025] Add time.thread_time()

2017-11-15 Thread Antoine Pitrou
Antoine Pitrou added the comment: Le 15/11/2017 à 22:06, STINNER Victor a écrit : > > I can work on the macOS implementation, once your PR will be merged. Great! -- ___ Python tracker

[issue32039] timeit documentation should describe caveats

2017-11-15 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- nosy: +haypo ___ Python tracker ___ ___

[issue26579] Support pickling slots in subclasses of common classes

2017-11-15 Thread Yury Selivanov
Change by Yury Selivanov : -- pull_requests: +4360 ___ Python tracker ___ ___

[issue31701] faulthandler dumps 'Windows fatal exception: code 0xe06d7363'

2017-11-15 Thread Ilya Kulakov
Ilya Kulakov added the comment: Victor, Does this change imply that no python-traceback-for-every-thread will be printed upon both handled and unhandled C++ exception? -- nosy: +Ilya.Kulakov ___ Python tracker

[issue32039] timeit documentation should describe caveats

2017-11-15 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: On Nov 15, 2017, at 17:00, Serhiy Storchaka wrote: > > +1 to all said by Raymond. But this is rather the matter of a special article > or blog post than a note in the documentation. Maybe a HOWTO on performance

[issue32042] Option for comparing values instead of reprs in doctest

2017-11-15 Thread Tomáš Petříček
Tomáš Petříček added the comment: Related to https://bugs.python.org/issue3332 -- ___ Python tracker ___

[issue32025] Add time.thread_time()

2017-11-15 Thread STINNER Victor
STINNER Victor added the comment: I can work on the macOS implementation, once your PR will be merged. -- ___ Python tracker

[issue32042] Option for comparing values instead of reprs in doctest

2017-11-15 Thread Tomáš Petříček
New submission from Tomáš Petříček : Would there be an interest and possibility to add an option to the doctest module to compare values instead of reprs? The idea is that the expected value would be eval'ed prior to comparison if this option was enabled. Motivation for

[issue32039] timeit documentation should describe caveats

2017-11-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: +1 to all said by Raymond. But this is rather the matter of a special article or blog post than a note in the documentation. Other example of caching is regular expressions. Mistakes: python3 -m timeit -s "it =

[issue26579] Support pickling slots in subclasses of common classes

2017-11-15 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- pull_requests: -4360 ___ Python tracker ___

[issue32025] Add time.thread_time()

2017-11-15 Thread Antoine Pitrou
Antoine Pitrou added the comment: New changeset 4bd41c9b52ea0c730e9e294caaf003e54c088c6e by Antoine Pitrou in branch 'master': bpo-32025: Add time.thread_time() (#4410) https://github.com/python/cpython/commit/4bd41c9b52ea0c730e9e294caaf003e54c088c6e --

[issue32034] Error when unpickling IncompleteReadError

2017-11-15 Thread Yury Selivanov
Yury Selivanov added the comment: New changeset 43605e6bfa8d49612df4a38460d063d6ba781906 by Yury Selivanov in branch 'master': bpo-32034: Make IncompleteReadError & LimitOverrunError pickleable #4409

[issue32034] Error when unpickling IncompleteReadError

2017-11-15 Thread Yury Selivanov
Change by Yury Selivanov : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue32034] Error when unpickling IncompleteReadError

2017-11-15 Thread Roundup Robot
Change by Roundup Robot : -- pull_requests: +4361 ___ Python tracker ___

[issue32036] error mixing positional and non-positional arguments with `argparse`

2017-11-15 Thread R. David Murray
R. David Murray added the comment: Ah, yes, I'd managed to forget about that issue, even though I was the one that finally committed the fix. So, the alternate parser will be in 3.7. In the meantime you can grab the code from the commit and put it in a local file, I

[issue32041] Cannot cast '\0' to c_void_p

2017-11-15 Thread Ilya Kulakov
New submission from Ilya Kulakov : Happens on 3.6.3 only: >>> import ctypes >>> ctypes.cast('\0', ctypes.c_void_p) ctypes.ArgumentError: argument 1: : embedded null character -- components: ctypes messages: 306307 nosy: Ilya.Kulakov priority: normal severity:

[issue32039] timeit documentation should describe caveats

2017-11-15 Thread Raymond Hettinger
Raymond Hettinger added the comment: Other caveats: * The tight, repeated loops tend to have perfect branch prediction rates and 100% L1 cache hit rates that are rarely present in real code. There should be links to why this matters: -

[issue32023] Always require parentheses for genexps in base class lists

2017-11-15 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +4349 stage: -> patch review ___ Python tracker ___

[issue31983] Officially add Py_SETREF and Py_XSETREF

2017-11-15 Thread Stefan Krah
Change by Stefan Krah : -- nosy: -skrah ___ Python tracker ___ ___ Python-bugs-list

[issue32031] Do not use the canonical path in pydoc test_mixed_case_module_names_are_lower_cased

2017-11-15 Thread Xavier de Gaye
New submission from Xavier de Gaye : test_mixed_case_module_names_are_lower_cased fails when there is a symlink in the directory path of the installed standard library. -- components: Tests messages: 306259 nosy: xdegaye priority: normal severity: normal stage: needs

[issue32012] Disallow ambiguous syntax f(x for x in [1],)

2017-11-15 Thread Nick Coghlan
Nick Coghlan added the comment: With issue 32023 (base class lists) and 32034 (fixing the documentation for decorator factory function calls) covering the other refinements, this particular issue is done now. The most recent PR is the one for issue 32023. --

[issue31801] vars() manipulation encounters problems with Enum

2017-11-15 Thread Eric Wieser
Eric Wieser added the comment: Not necessarily an argument against this feature, but two workarounds exist for this already: 1. Use `nonlocal` to prevent `value` going into the class namespace: value = None class BaudRate(enum.Enum):

[issue32024] Nominal decorator function call syntax is inconsistent with regular function calls

2017-11-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Since this change is approved, this is a documentation issue, and I left it on to Nick. -- ___ Python tracker

[issue32041] Cannot cast '\0' to c_void_p

2017-11-15 Thread Ilya Kulakov
Ilya Kulakov added the comment: That's the change that introduced the bug: https://github.com/python/cpython/pull/2285 -- ___ Python tracker

[issue32042] Option for comparing values instead of reprs in doctest

2017-11-15 Thread Tomáš Petříček
Tomáš Petříček added the comment: This option can be seen as a more general case of the options already available which lift the requirement of exact representation match (True for 1, normalize whitespace etc.). It would enable easier testing of relevant behavior instead

[issue32030] PEP 432: Rewrite Py_Main()

2017-11-15 Thread STINNER Victor
STINNER Victor added the comment: Nick: """ I noticed the other day that the interaction between PYTHONWARNINGS, the `-W` option, sys.warnoptions, and _warnings.filters is a bit confusing: $ PYTHONWARNINGS=always,default python3 -Wignore -Wonce (...) >>>

[issue32026] Memory leaks in Python on Windows

2017-11-15 Thread STINNER Victor
STINNER Victor added the comment: Python doesn't clean everything at exit: see bpo-29881. I just modified Py_Main() in bpo-32030 to clean a few more bytes (like program_name): see pymain_free() in Modules/main.c. -- ___

[issue32043] Add a new -X dev option: "developer mode"

2017-11-15 Thread STINNER Victor
New submission from STINNER Victor : I propose to add a new "developer mode": a new "-X dev" command line option. In short: python3 -X dev script.py behaves as: PYTHONMALLOC=debug python3 -W default -X faulthandler script.py For the rationale, please see:

[issue32030] PEP 432: Rewrite Py_Main()

2017-11-15 Thread STINNER Victor
STINNER Victor added the comment: I rewrote Py_Main() in two large commits. The code isn't perfect yet, for example, init_sys_streams() still reads the PYTHONIOENCODING environment variable. IMHO it should be read earlier. But as soon, my changes should allow to fix

[issue31701] faulthandler dumps 'Windows fatal exception: code 0xe06d7363'

2017-11-15 Thread STINNER Victor
STINNER Victor added the comment: > Does this change imply that no python-traceback-for-every-thread will be > printed upon both handled and unhandled C++ exception? Right if I understood correctly. The best is to test yourself ;-) --

[issue32042] Option for comparing values instead of reprs in doctest

2017-11-15 Thread Tomáš Petříček
Tomáš Petříček added the comment: The following tests then succeed: def str_fun(): """ >>> str_fun() 'foo' >>> str_fun() "foo" >>> str_fun() '''foo''' """ return 'foo' def dict_fun(): """ >>> dict_fun() {'foo': 1, 'bar': 2}

[issue32034] Error when unpickling IncompleteReadError

2017-11-15 Thread Yury Selivanov
Yury Selivanov added the comment: New changeset f35076a002b958f991d180d6f945344cc5ab3900 by Yury Selivanov (Miss Islington (bot)) in branch '3.6': bpo-32034: Make IncompleteReadError & LimitOverrunError pickleable GH-4409 (#4411)

[issue32030] PEP 432: Rewrite Py_Main()

2017-11-15 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +4362 ___ Python tracker ___ ___

[issue32030] PEP 432: Rewrite Py_Main()

2017-11-15 Thread STINNER Victor
STINNER Victor added the comment: New changeset f7e5b56c37eb859e225e886c79c5d742c567ee95 by Victor Stinner in branch 'master': bpo-32030: Split Py_Main() into subfunctions (#4399) https://github.com/python/cpython/commit/f7e5b56c37eb859e225e886c79c5d742c567ee95

[issue32042] Option for comparing values instead of reprs in doctest

2017-11-15 Thread R. David Murray
R. David Murray added the comment: I think it is an interesting idea. Let see what other people think. -- nosy: +r.david.murray ___ Python tracker

[issue32041] Cannot cast '\0' to c_void_p

2017-11-15 Thread Ilya Kulakov
Ilya Kulakov added the comment: I have fixed that problem by ensuring that ctypes-facing code passes bytes, not strings. -- ___ Python tracker

[issue31415] Add -X option to show import time

2017-11-15 Thread STINNER Victor
STINNER Victor added the comment: FYI I'm working on the Py_Main() function in bpo-32030. My latest PR (PR 4412) moves the code to parse -X importtime and PYTHONPROFILEIMPORTTIME into Py_Main(), to group all functions parsing the command line arguments and

[issue32039] timeit documentation should describe caveats

2017-11-15 Thread STINNER Victor
STINNER Victor added the comment: Barry: "... possibly point to both cProfile and the 3rd party perf package as alternative ways to gather performance information." FYI the timeit module of PyPy now emits a warning and points to the perf module:

[issue32030] PEP 432: Rewrite Py_Main()

2017-11-15 Thread STINNER Victor
STINNER Victor added the comment: New changeset a7368ac6360246b1ef7f8f152963c2362d272183 by Victor Stinner in branch 'master': bpo-32030: Enhance Py_Main() (#4412) https://github.com/python/cpython/commit/a7368ac6360246b1ef7f8f152963c2362d272183 --

[issue32037] Pickle 32-bit integers with protocol 0 as INT instead of LONG

2017-11-15 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue32037] Pickle 32-bit integers with protocol 0 as INT instead of LONG

2017-11-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 3daaafb700df45716bb55f3a293f88773baf3463 by Serhiy Storchaka in branch 'master': bpo-32037: Use the INT opcode for 32-bit integers in protocol 0 pickles. (#4407)

[issue32044] pip3 install 3.6.3 crashes on startup; 3.5.4 works; on OS X 10.13.1

2017-11-15 Thread Daniel E Platt
New submission from Daniel E Platt : pip3 installed with 3.6.3 crashes on startup. pip3 installed with 3.5.4 works. Appears on OS X 10.13.1 -- components: Installation messages: 306336 nosy: DanPlatt priority: normal severity: normal status: open title: pip3

[issue32044] pip3 install 3.6.3 crashes on startup; 3.5.4 works; on OS X 10.13.1

2017-11-15 Thread Daniel E Platt
Daniel E Platt added the comment: platt@MacBook-Pro.local:/Users/platt $ pip3 Traceback (most recent call last): File "/Library/Frameworks/Python.framework/Versions/3.6/bin/pip3", line 7, in from pip import main File

[issue32038] Add API to intercept socket.close()

2017-11-15 Thread Ben Darnell
Ben Darnell added the comment: It's worse than a resource leak - the same file descriptor number could be reused for a different file/socket, and then depending on the selector in use, you could see the data from a completely different connection. I did see a bug like

[issue31701] faulthandler dumps 'Windows fatal exception: code 0xe06d7363'

2017-11-15 Thread Ilya Kulakov
Ilya Kulakov added the comment: May I ask why AddVectoredExceptionHandler is used instead of SetUnhandledExceptionFilter? -- ___ Python tracker

[issue32044] pip3 install 3.6.3 crashes on startup; 3.5.4 works; on OS X 10.13.1

2017-11-15 Thread Daniel E Platt
Daniel E Platt added the comment: platt@MacBook-Pro.local:/Users/platt $ pip install -U setuptools pip Collecting setuptools Downloading setuptools-36.7.2-py2.py3-none-any.whl (482kB) 100% || 491kB 2.6MB/s Requirement already

[issue32044] pip3 install 3.6.3 crashes on startup; 3.5.4 works; on OS X 10.13.1

2017-11-15 Thread Berker Peksag
Berker Peksag added the comment: Thank you for your report. This is a problem with setuptools: https://github.com/pypa/setuptools/issues/885 I suggest upgrading both setuptools and pip: $ pip install -U setuptools pip -- nosy: +berker.peksag resolution:

[issue30143] Using collections ABC from collections.abc rather than collections in 2to3 converted code

2017-11-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 0a2abdfca2495291809855cf7dfc6721c9c962e3 by Serhiy Storchaka in branch 'master': bpo-30143: 2to3 now generates a code that uses abstract collection classes (#1262)

[issue30143] Using collections ABC from collections.abc rather than collections in 2to3 converted code

2017-11-15 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue32043] Add a new -X dev option: "developer mode"

2017-11-15 Thread STINNER Victor
Change by STINNER Victor : -- keywords: +patch pull_requests: +4363 stage: -> patch review ___ Python tracker ___

[issue32043] Add a new -X dev option: "developer mode"

2017-11-15 Thread Barry A. Warsaw
Change by Barry A. Warsaw : -- nosy: +barry ___ Python tracker ___ ___ Python-bugs-list

[issue32043] Add a new -X dev option: "developer mode"

2017-11-15 Thread STINNER Victor
STINNER Victor added the comment: I rewrote Py_Main() in bpo-32030 to make it very easy to implement this new feature. I wrote PR 4413 to implement -X dev. -- ___ Python tracker

[issue32032] Module-level pickle tests test only default implementation

2017-11-15 Thread Serhiy Storchaka
New submission from Serhiy Storchaka : In Python 2 tests for module-level API test both implementations, pickle and cPickle. In Python 3 they test only the default implementation. If _pickle is available, the Python implementation of module-level functions is not

[issue32033] The pwd test test_values fails on Android

2017-11-15 Thread Xavier de Gaye
New submission from Xavier de Gaye : On Android API 24: $ python -c "import pwd; print(pwd.getpwuid(0))" pwd.struct_passwd(pw_name='root', pw_passwd='', pw_uid=0, pw_gid=0, pw_gecos=None, pw_dir='/', pw_shell='/system/bin/sh') The pw_gecos member is None and the test_values

[issue32033] The pwd test test_values fails on Android

2017-11-15 Thread STINNER Victor
STINNER Victor added the comment: Hum, I changed my mind a little bit :-) > (2) to modify the sets() function in Modules/pwdmodule.c to set an empty > string instead of None when the member of the passwd structure is a NULL > pointer. I checked the doc: pwd doesn't

[issue32032] Module-level pickle tests test only default implementation

2017-11-15 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +4350 stage: needs patch -> patch review ___ Python tracker

[issue32033] The pwd test test_values fails on Android

2017-11-15 Thread STINNER Victor
STINNER Victor added the comment: > self.assertIsInstance(e.pw_gecos, str) This test is wrong: it's perfectly fine to get None here. Python must not test the OS itself, but only test our own code: make sure that Python converts properly C types to nice Python types,

[issue29406] asyncio SSL contexts leak sockets after calling close with certain Apache servers

2017-11-15 Thread Andrew Svetlov
Change by Andrew Svetlov : -- pull_requests: +4351 ___ Python tracker ___ ___

[issue30950] Convert round() to Arument Clinic

2017-11-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset aca7f574b06c72c85a5e3e4b16a8a5e384a7c4a8 by Serhiy Storchaka in branch 'master': bpo-30950: Convert round() to Argument Clinic. (#2740)

[issue30950] Convert round() to Arument Clinic

2017-11-15 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- dependencies: -Documentation for round() is incorrect. resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue30399] Get rid of trailing comma in the repr() of BaseException

2017-11-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset f8a4c03ede6048022f60a58d5a21b278b78a8a16 by Serhiy Storchaka in branch 'master': bpo-30399: Get rid of trailing comma in the repr of BaseException. (#1650)

[issue30399] Get rid of trailing comma in the repr() of BaseException

2017-11-15 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue32023] Always require parentheses for genexps in base class lists

2017-11-15 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue30143] Using collections ABC from collections.abc rather than collections in 2to3 converted code

2017-11-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: What are your thoughts about this Benjamin? -- ___ Python tracker ___

[issue32011] Restore loading of TYPE_INT64 in marshal

2017-11-15 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue31949] Bugs in PyTraceBack_Print()

2017-11-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 3864248866d6224336c7be49670447cb4d125cd6 by Serhiy Storchaka in branch '3.6': [3.6] bpo-31949: Fixed several issues in printing tracebacks (PyTraceBack_Print()). (GH-4289) (#4406)

[issue31949] Bugs in PyTraceBack_Print()

2017-11-15 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.6 ___ Python tracker

[issue32011] Restore loading of TYPE_INT64 in marshal

2017-11-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset d15bb5fcad584e113836486d17c6abcbf2168a86 by Serhiy Storchaka (Miss Islington (bot)) in branch '3.6': bpo-32011: Revert "Issue GH-15480: Remove the deprecated and unused TYPE_INT64 code from marshal." (GH-4381)

[issue27494] 2to3 parser failure caused by a comma after a generator expression

2017-11-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Since this syntax never was valid according to the Python language specification, and it causes SyntaxError in 3.7 (see issue32012), I think that this change should be reverted. -- resolution: fixed -> stage: resolved

[issue32035] Documentation of zipfile.ZipFile().writestr() fails to mention that 'data' may also be bytes

2017-11-15 Thread Daniel
New submission from Daniel : The documentation for "ZipFile.writestr(zinfo_or_arcname, data[, compress_type])" says: "Write the string data to the archive; [...]" --> https://docs.python.org/3/library/zipfile.html I fails to mention that data could also be bytes. The

[issue32032] Module-level pickle tests test only default implementation

2017-11-15 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue32034] Error when unpickling IncompleteReadError

2017-11-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: This isn't so simple. >>> from asyncio.streams import IncompleteReadError >>> import pickle >>> e1 = IncompleteReadError(b'abc', 10) >>> e2 = pickle.loads(pickle.dumps(e1)) >>> print(e1) 3 bytes read on a total of 10 expected

[issue32032] Module-level pickle tests test only default implementation

2017-11-15 Thread Roundup Robot
Change by Roundup Robot : -- pull_requests: +4352 ___ Python tracker ___

[issue10049] Add a "no-op" (null) context manager to contextlib

2017-11-15 Thread Hrvoje Nikšić
Hrvoje Nikšić added the comment: I am of course willing to sign the CLA (please send further instructions via email), although I don't know how useful my original patch is, given that it caches the null context manager. -- ___

[issue32034] Error when unpickling IncompleteReadError

2017-11-15 Thread badouxn
Change by badouxn : -- keywords: +patch pull_requests: +4353 stage: -> patch review ___ Python tracker ___

[issue32032] Module-level pickle tests test only default implementation

2017-11-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 6545256df93ba54f811206107274cfa5a6d76b86 by Serhiy Storchaka in branch 'master': bpo-32032: Test both implementations of module-level pickle API. (#4401)

[issue32025] Add time.thread_time()

2017-11-15 Thread Antoine Pitrou
Antoine Pitrou added the comment: Le 15/11/2017 à 02:48, STINNER Victor a écrit : > > Would it be possible to not provide the function if it's not supported by a > platform? Probably, yes. > Do you know platforms which don't support time.thread_time()? Any POSIX platform

[issue32032] Module-level pickle tests test only default implementation

2017-11-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset eb38367f20b05f2ad04a4833bceb369b5e78b1a3 by Serhiy Storchaka (Miss Islington (bot)) in branch '3.6': bpo-32032: Test both implementations of module-level pickle API. (GH-4401) (#4403)

[issue32034] Impossible to unpickle IncompleteReadError

2017-11-15 Thread badouxn
New submission from badouxn : When using asyncio in combination with multiprocessing, a TypeError occur when readuntil() encounter an EOF instead of the delimiter. readuntil return a IncompleteReadError exception which is pickled by the multiprocessing package. The unpickling

  1   2   >