[issue32292] Building fails on Windows

Steve Dower added the comment: I changed the default Windows SDK version at some point, because it was falling back to v8.1 and we really ought to use v10. It auto-detects all the v10 versions, so I'm guessing you haven't got any of them installed right now. The dev

[issue22671] Typo in class io.BufferedIOBase docs

Change by Sanyam Khurana : -- pull_requests: +4708 ___ Python tracker ___ ___

[issue32292] Building fails on Windows

New submission from Antoine Pitrou : Sorry if this looks more like a support request. There's probably something wrong in my setup (I do have Visual Studio 2015 installed, though). I am trying to build on Windows using "Tools\buildbot\build.bat -p x64". It worked a few

[issue29970] Severe open file leakage running asyncio SSL server

Neil Aspinall added the comment: I think there's been some confusion about what PR 480 was meant to fix - it helps in cases where connections are closed during handshake, but if a server connection is waiting for a handshake but never receives any data at all then it

[issue32293] macos pkg fails 10.13.2

Change by Lloyd Vancil : -- resolution: -> rejected stage: -> resolved status: open -> closed ___ Python tracker ___

[issue32268] quopri.decode(): string argument expected, got 'bytes'

R. David Murray added the comment: We generally don't do advance type checking (look before you leap) in Python. This allows a type the programmer hadn't planned for to be used as long as it "quacks like" the expected type (this is called duck typing). So the error

[issue32291] Value error for string shared memory in multiprocessing

New submission from Marc Guetg : It seems like sharing a string over processes is not possible. #!/usr/bin/env python3 import multiprocessing import threading import ctypes def fun(share_c, share_s, set_c,

[issue32293] macos pkg fails 10.13.2

New submission from Lloyd Vancil : the downloadble pkg file fails on attempt to install on 10.13.2 "no software to install" -- components: macOS messages: 308147 nosy: Lloyd Vancil, ned.deily, ronaldoussoren priority: normal severity: normal status: open title:

[issue32280] Expose `_PyRuntime` through a section name

Eric Snow added the comment: Note that in the long term we are considering support for embedding multiple runtimes in a single process. So anything that assumes there is only a single runtime in each process is problematic. --

[issue31901] atexit callbacks should be run at subinterpreter shutdown

Change by Xavier G. Domingo : -- nosy: +xgdomingo ___ Python tracker ___ ___

[issue32226] Implement PEP 560: Core support for typing module and generic types

Change by Xavier G. Domingo : -- nosy: +xgdomingo ___ Python tracker ___ ___

[issue32292] Building fails on Windows

Change by Xavier G. Domingo : -- nosy: +xgdomingo ___ Python tracker ___ ___

[issue30256] Adding a SyncManager Queue proxy to a SyncManager dict or Namespace proxy raises an exception

Change by Jordan Speicher : -- keywords: +patch pull_requests: +4709 stage: -> patch review ___ Python tracker ___

[issue32226] Implement PEP 560: Core support for typing module and generic types

Ivan Levkivskyi added the comment: Guido, what is your preference for the implementation of ``__class_getitem__``: ``PyObject_GetItem`` (current one) or ``type.__getitem__`` (old one)? Can we just go ahead with the version you like and then re-consider if some objections

[issue31643] test_uuid: test_getnode and test_windll_getnode fail if connected to the Internet via an Android phone

Ivan Pozdeev added the comment: > Xavier de Gaye added the comment: > > On a Samsung device with Android 5.1 and tethering enabled, only one network > device has a MAC address and it is not an all-zero MAC address. > > Ivan can you please provide more

[issue20361] -W command line options and PYTHONWARNINGS environmental variable should not override -b / -bb command line options

Change by STINNER Victor : -- pull_requests: +4711 ___ Python tracker ___ ___

[issue32230] -X dev doesn't set sys.warnoptions

Change by STINNER Victor : -- pull_requests: +4710 ___ Python tracker ___ ___

[issue32280] Expose `_PyRuntime` through a section name

Maxime Belanger added the comment: Interesting, would this imply potentially multiple GILs? The major thing we need out of the structure is the (`Py_tss_t`) `autoTSSKey` in order to associate a native thread with its `PyThreadState`. --

[issue32101] Add PYTHONDEVMODE=1 to enable the developer mode

Change by STINNER Victor : -- pull_requests: +4712 ___ Python tracker ___ ___

[issue1410680] Add 'surgical editing' to ConfigParser

Fipaddict added the comment: I would have liked for configparser to keep comments when my program re-write configuration file too. Thanks -- ___ Python tracker

[issue32282] When using a Windows XP compatible toolset, `socketmodule.c` fails to build

Maxime Belanger added the comment: Works for me. We no longer rely on the `_xp` toolset so no objections. -- ___ Python tracker ___

[issue32280] Expose `_PyRuntime` through a section name

Change by STINNER Victor : -- nosy: +vstinner ___ Python tracker ___ ___

[issue32230] -X dev doesn't set sys.warnoptions

STINNER Victor added the comment: New changeset 747f48e2e92390c44c72f52a1239959601cde157 by Victor Stinner in branch 'master': bpo-32230: Set sys.warnoptions with -X dev (#4820) https://github.com/python/cpython/commit/747f48e2e92390c44c72f52a1239959601cde157

[issue20361] -W command line options and PYTHONWARNINGS environmental variable should not override -b / -bb command line options

STINNER Victor added the comment: New changeset 747f48e2e92390c44c72f52a1239959601cde157 by Victor Stinner in branch 'master': bpo-32230: Set sys.warnoptions with -X dev (#4820) https://github.com/python/cpython/commit/747f48e2e92390c44c72f52a1239959601cde157

[issue20361] -W command line options and PYTHONWARNINGS environmental variable should not override -b / -bb command line options

STINNER Victor added the comment: Ok, I merged Nick's PR: -b and -bb options now have the highest priority. I close the issue. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python

[issue32230] -X dev doesn't set sys.warnoptions

STINNER Victor added the comment: We found an agreement with Nick :-) I applied Nick's PR. The issue is now fixed: vstinner@apu$ ./python -X dev -c 'import sys; print(sys.warnoptions)' ['default'] This PR also fix bpo-20361: -b and -bb options now have the highest

[issue32292] Building fails on Windows

Antoine Pitrou added the comment: Thank you. Though now I get the following issue: "c:\t\cpython\PCbuild\pcbuild.proj" (Build target) (1) -> "c:\t\cpython\PCbuild\pythoncore.vcxproj" (Build target) (2) -> (ResourceCompile target) -> TRACKER :

[issue32294] test_semaphore_tracker() of test_multiprocessing_spawn fails with -W error

New submission from STINNER Victor : vstinner@apu$ PYTHONWARNINGS=error ./python -W error -m test test_multiprocessing_spawn -v -m test_semaphore_tracker == CPython 3.7.0a3+ (heads/master:747f48e2e9, Dec 12 2017, 23:12:36) [GCC 7.2.1 20170915 (Red Hat 7.2.1-2)] ==

[issue32101] Add PYTHONDEVMODE=1 to enable the developer mode

STINNER Victor added the comment: New changeset 721e25c6535d08bd3d4d891fb2b540472e19f899 by Victor Stinner in branch 'master': bpo-32101: Fix tests for PYTHONDEVMODE=1 (#4821) https://github.com/python/cpython/commit/721e25c6535d08bd3d4d891fb2b540472e19f899

[issue18533] Avoid error from repr() of recursive dictview

Change by Roundup Robot : -- pull_requests: +4713 stage: test needed -> patch review ___ Python tracker ___

[issue18533] Avoid error from repr() of recursive dictview

Ben North added the comment: PR4823 created as per msg308086. -- ___ Python tracker ___

[issue32292] Building fails on Windows

Change by STINNER Victor : -- nosy: +vstinner ___ Python tracker ___ ___

[issue32295] User friendly message when invoking bdist_wheel sans wheel package

New submission from Ernest W. Durbin III : Wheels are a well-known part of the Python packaging ecosystem at this point! Many tutorials, gists, and other tools suggest to build wheels using setuptools and distutils, but may not remind users to install the wheel package. In

[issue32137] Stack overflow in repr of deeply nested dicts

Change by Ben North : -- pull_requests: +4716 ___ Python tracker ___ ___

[issue32295] User friendly message when invoking bdist_wheel sans wheel package

Éric Araujo added the comment: I don’t know that bdist_wheel integrates with pure distutils without setuptools. I think this PR should target setuptools (it will also make it propagate to users faster and regardless of Python version). --

[issue29970] Severe open file leakage running asyncio SSL server

Change by Neil Aspinall : -- keywords: +patch pull_requests: +4717 stage: -> patch review ___ Python tracker ___

[issue32295] User friendly message when invoking bdist_wheel sans wheel package

Ernest W. Durbin III added the comment: bdist_wheel is implemented as a distutils.core.Command, see https://github.com/pypa/wheel/blob/3a87ecebaba765475392ae2cdfa2a51cb78360e0/wheel/bdist_wheel.py I was unable to find a good place to transparently hook in and catch the

[issue32295] User friendly message when invoking bdist_wheel sans wheel package

Éric Araujo added the comment: The devs probably choose to use distutils.Command as base class for maximum compatibility, but I suspect 99.99% of users use the setuptools integration (entry points

[issue32296] Implement asyncio._get_running_loop() and get_event_loop() in C

New submission from Yury Selivanov : asyncio.get_event_loop(), and, subsequently asyncio._get_running_loop() are one of the most frequently executed functions in asyncio. They also can't be sped up by third-party event loops like uvloop. When implemented in C they

[issue17852] Built-in module _io can lose data from buffered files at exit

Change by Antoine Pitrou : -- pull_requests: +4718 ___ Python tracker ___ ___

[issue32296] Implement asyncio._get_running_loop() and get_event_loop() in C

Change by Yury Selivanov : -- keywords: +patch pull_requests: +4719 stage: -> patch review ___ Python tracker ___

[issue17852] Built-in module _io can lose data from buffered files at exit

Antoine Pitrou added the comment: I just discovered that the fix is incorrect. See PR #4826 for reversion and a quick explanation. -- resolution: fixed -> stage: resolved -> needs patch status: closed -> open ___ Python tracker

[issue27126] Apple-supplied libsqlite3 on OS X is not fork safe; can cause crashes

Change by Eitan Adler : -- nosy: +eadler ___ Python tracker ___ ___ Python-bugs-list

[issue13829] exception error in _scproxy.so when called after fork

Change by Eitan Adler : -- nosy: +eadler ___ Python tracker ___ ___ Python-bugs-list

[issue20353] Hanging bug with multiprocessing + sqlite3 + tkinter (OS X 10.9 only)

Change by Eitan Adler : -- nosy: +eadler ___ Python tracker ___ ___ Python-bugs-list

[issue32226] Implement PEP 560: Core support for typing module and generic types

Guido van Rossum added the comment: I like the current approach (PyObject_GetItem). I agree with both of your reasons to prefer it. -- ___ Python tracker

[issue32270] subprocess closes redirected fds even if they are in pass_fds

Antoine Pitrou added the comment: > Regarding fixing (1), I'm worrying about backward compatibility a bit. Well, people shouldn't rely on bugs. Otherwise we would never be able to fix bugs, lest someone relies on it. -- ___ Python

[issue32287] Import of _pyio module failed on cygwin

Masayuki Yamamoto added the comment: This issue seems to duplicate #28459. #28459 has a patch (implement _setmode() by ctypes on _pyio). I'm not sure _setmode() will be used in other places in the future, but the patch just works at the moment. In addition, I have

[issue28459] _pyio module broken on Cygwin / setmode not usable

Masayuki Yamamoto added the comment: FYI, cygwin-pyio-setmode.patch includes two extra parts for running on Cygwin. First, fix import error for ctypes (unopened issue). Second, fix building _ctypes module (#4032 - PR 4153). --

[issue32297] Few misspellings found in Python source code comments.

New submission from Mikhail Afanasev : I have noticed few misspellings in Python source code comments while doing some research with the help of spelling and grammatic tools. I double checked all of them and corrected. There is just one docstring affected. All the other

[issue32292] Building fails on Windows

Steve Dower added the comment: Strange, that should have been installed. Do you see rc.exe anywhere in "C:\Program Files (x86)\Windows Kits\10"? If not, might need to repair the SDK you just installed. It shouldn't be a separate option from anything else in there.

[issue17852] Built-in module _io can lose data from buffered files at exit

STINNER Victor added the comment: New changeset 317def9fdb29893df1ab380d396fcdd2eafe0588 by Victor Stinner (Antoine Pitrou) in branch 'master': bpo-17852: Revert incorrect fix based on misunderstanding of _Py_PyAtExit() semantics (#4826)

[issue32297] Few misspellings found in Python source code comments.

Change by Eric V. Smith : -- nosy: +eric.smith ___ Python tracker ___ ___

[issue32292] Building fails on Windows

Antoine Pitrou added the comment: Le 13/12/2017 à 01:14, Steve Dower a écrit : > > Strange, that should have been installed. > > Do you see rc.exe anywhere in "C:\Program Files (x86)\Windows Kits\10"? Yes, it's in "C:\Program Files (x86)\Windows Kits\10\bin\10.0.16299.0\x64"

[issue32292] Building fails on Windows

Steve Dower added the comment: Is there one in x86 as well? Perhaps it isn't finding x64 tools properly (I've seen this once or twice in the past with VS 2015, but I think it was fixed at some point) -- ___ Python tracker

[issue32292] Building fails on Windows

Antoine Pitrou added the comment: Yes, both in x86 and x64. And `tools\buildbot\build.bat` fails regardless of whether I pass `-p x64` or not. -- ___ Python tracker

[issue32298] Email.quopriprime over-encodes characters

New submission from Geoff Kuenning : Email.quopriprime creates a map of header and body bytes that need no encoding: for c in b'-!*+/' + ascii_letters.encode('ascii') + digits.encode('ascii'): _QUOPRI_HEADER_MAP[c] = chr(c) This map is overly restrictive; in fact only two

[issue29240] PEP 540: Add a new UTF-8 mode

STINNER Victor added the comment: The PEP 538 has two open issues: bpo-30672 and bpo-32238. I recently refactored the Py_Main() code so it should be simpler to implement the PEP 540: see bpo-32030. -- ___ Python tracker

[issue29240] PEP 540: Add a new UTF-8 mode

STINNER Victor added the comment: Oh, PYTHONCOERCECLOCALE env var is read very early in main() by _Py_CoerceLegacyLocale(), it ignores -E command line option. * Ignoring -E and -I is safe from a security perspective, as we only use * the setting to turn

[issue32298] Email.quopriprime over-encodes characters

Geoff Kuenning added the comment: Oops, that loop is a bit too generous. Here's a better one: for c in list(range(33, 61)) + [62] + list(range(64, 95)) + list(range(96,127)): -- ___ Python tracker

[issue32292] Building fails on Windows

Steve Dower added the comment: It shouldn't be any different, but what about PCBuild/build.bat? -- ___ Python tracker ___

[issue32267] strptime misparses offsets with microsecond format

Change by Alexander Belopolsky : -- nosy: +p-ganssle ___ Python tracker ___

[issue5288] tzinfo objects with sub-minute offsets are not supported (e.g. UTC+05:53:28)

Change by Paul Ganssle : -- pull_requests: +4721 ___ Python tracker ___ ___

[issue32298] Email.quopriprime over-encodes characters

R. David Murray added the comment: >From RFC 2047: (3) As a replacement for a 'word' entity within a 'phrase', for example, one that precedes an address in a From, To, or Cc header. The ABNF definition for 'phrase' from RFC 822 thus becomes: phrase = 1*(

[issue32298] Email.quopriprime over-encodes characters

R. David Murray added the comment: And of course tools can grep for "f...@bar.com": you can't use encoded words in an address, only in the display name. However, it occurs to me that in fact the restriction applies only to phrases, so one could use a less restrictive

[issue32299] unittest.mock.patch.dict.__enter__ should return the dict

Change by Allen Li : -- type: -> enhancement ___ Python tracker ___ ___

[issue32299] unittest.mock.patch.dict.__enter__ should return the dict

New submission from Allen Li : mock.patch.dict.__enter__ should return the patched dict/mapping object. Currently it returns nothing (None). This would make setting up fixtures more convenient: with mock.patch.dict(some.thing): some.thing['foo'] = 'bar' with

[issue32264] move pygetopt.h into internal/

Change by Benjamin Peterson : -- keywords: +patch pull_requests: +4722 stage: -> patch review ___ Python tracker ___

[issue32289] Glossary does not define "extended slicing"

New submission from Steven D'Aprano : Looking at issue 32288, I realised that the glossary doesn't define "extended slicing" or "extended slice", even though they are common terms. Although I thought I know what they meant, on closer reflection I realised I wasn't

[issue32288] Inconsistent behavior with slice assignment?

Stefan Krah added the comment: I see the first issue now and I agree that Python behaves strangely. Numpy = >>> x = array([1,2,3]) >>> x[1:2] = [1,2,3,4,5] Traceback (most recent call last): File "", line 1, in ValueError: cannot copy sequence with size 5 to array

[issue32285] In `unicodedata`, it should be possible to check a unistr's normal form without necessarily copying it

STINNER Victor added the comment: > However, I'm concerned by your comment that you fall back on creating a > normalized copy and comparing. The purpose of the function is to be faster than str == unicodedata.normalize(form, str). So yeah, any optimization is

[issue19431] Document PyFrame_FastToLocals() and PyFrame_FastToLocalsWithError()

STINNER Victor added the comment: > Currently you should call PyFrame_FastToLocalsWithError(), modify directly > f_locals, and call PyFrame_LocalsToFast(). When happens if PyFrame_LocalsToFast() isn't called? Does it crash or is it just slower? --

[issue19431] Document PyFrame_FastToLocals() and PyFrame_FastToLocalsWithError()

Serhiy Storchaka added the comment: frameobject.h is not included in any header file. Some effort was spent for avoiding including it in ceval.h, genobject.h, pystate.h and traceback.h. The whole content of frameobject.h is not available in the limited API. I'm

[issue32288] Inconsistent behavior with slice assignment?

New submission from Massimiliano Culpo : I am not really sure if what I am reporting is to be considered a bug in the interpreter (slice built-in), a lack in documentation or if it is just me not finding the proper references (in which case feel free to close

[issue32226] Implement PEP 560: Core support for typing module and generic types

Ivan Levkivskyi added the comment: > As for __class_getitem__, why not implement type.__getitem__ instead of > hacking PyObject_GetItem()? This question was raised by Mark Shannon on python-dev. Actually, my initial implementation did exactly this, but I didn't like it

[issue32285] In `unicodedata`, it should be possible to check a unistr's normal form without necessarily copying it

Steven D'Aprano added the comment: Python 2.7 is in feature freeze, so this can only go into 3.7. I would find this useful, and would like this feature. However, I'm concerned by your comment that you fall back on creating a normalized copy and comparing. That

[issue32288] Inconsistent behavior with slice assignment?

Steven D'Aprano added the comment: Please don't report three issues under one ticket, unless they are so closely related that they cannot be separated. I don't understand what your second issue actually is. You refer to the docs that specify extended syntax as

[issue32288] Inconsistent behavior with slice assignment?

Stefan Krah added the comment: Python lists don't implement extended slices, try numpy arrays: >>> import numpy as np >>> x = array([[1,2,3], [4,5,6]]) >>> x[:, 2] array([3, 6]) >>> >>> lst = [[1,2,3], [4,5,6]] >>> lst[:, 2] Traceback (most recent call last): File "",

[issue32241] Add the const qualifier for char and wchar_t pointers to unmodifiable strings

Serhiy Storchaka added the comment: New changeset 4ae06c5337e01bdde28bce57b6b9166ad50947e3 by Serhiy Storchaka in branch 'master': bpo-32241: Add the const qualifire to declarations of umodifiable strings. (#4748)

[issue32241] Add the const qualifier for char and wchar_t pointers to unmodifiable strings

Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue32288] Inconsistent behavior with slice assignment?

Stefan Krah added the comment: Okay, the different meanings of "extended slicing" seem to be an old problem: https://mail.python.org/pipermail/tutor/2007-July/055838.html I assumed it referred to numpy's tuple indexing syntax, but it is apparently also used for referring

[issue32287] Import of _pyio module failed on cygwin

Change by R. David Murray : -- nosy: +erik.bray ___ Python tracker ___ ___

[issue32288] Inconsistent behavior with slice assignment?

R. David Murray added the comment: It actually makes sense that a slice assignment with a different length replacement list with a step of 1 works but any other step doesn't. Logically you can see that you can cut out a chunk and replace it with a different sized

[issue32276] there is no way to make tempfile reproducible (i.e. seed the used RNG)

Yaroslav Halchenko added the comment: I have spent too much time in Python to be able to compare to other languages ;) but anywhere I saw RNG being used, there was a way to seed it or to provide a state. tempfile provides no such API my usecase -- comparison of logs

[issue32286] python 2.7 cannot parse ''

New submission from wangtie : I have a txt file,use code UTF-8,and include char ''(ASCII code?), when use f.readlines() to get a list, the program exit without any exception,then I got a list without data after line which include char ''. -- components: Unicode

[issue32286] python 2.7 cannot parse ''

STINNER Victor added the comment: Your file is not properly encoded to UTF-8: the Python 2 UTF-8 raises UnicodeDecodeError. Sorry but this is not a bug in Python, but a bug on your side. Please ask such question on the forum to ask Python questions like

[issue30491] Add a lightweight mechanism for detecting un-awaited coroutine objects

Change by STINNER Victor : -- nosy: -vstinner ___ Python tracker ___ ___

[issue32276] there is no way to make tempfile reproducible (i.e. seed the used RNG)

Raymond Hettinger added the comment: I'm suspect this not would be wise thing to do. Have you seen any precedent for this in other languages? -- nosy: +rhettinger ___ Python tracker

[issue31643] test_uuid: test_getnode and test_windll_getnode fail if connected to the Internet via an Android phone

Serhiy Storchaka added the comment: I'm not sure that is better than a random address. Even if an all-zero MAC address is not explicitly prohibited it is used in a multiple independent devices. A random address looks more appropriate fore the purpose

[issue32226] Implement PEP 560: Core support for typing module and generic types

Serhiy Storchaka added the comment: For reference: PEP 560. -- ___ Python tracker ___

[issue32255] csv.writer converts None to '""\n' when it is first line, otherwise '\n'

Serhiy Storchaka added the comment: New changeset 2001900b0c02a397d8cf1d776a7cc7fcb2a463e3 by Serhiy Storchaka (Licht Takeuchi) in branch 'master': bpo-32255: Always quote a single empty field when write into a CSV file. (#4769)

[issue32255] csv.writer converts None to '""\n' when it is first line, otherwise '\n'

Change by Roundup Robot : -- pull_requests: +4705 stage: needs patch -> patch review ___ Python tracker ___

[issue32255] csv.writer converts None to '""\n' when it is first line, otherwise '\n'

Serhiy Storchaka added the comment: Thank you for your contribution Licht! -- ___ Python tracker ___

[issue32286] python 2.7 cannot parse ''

wangtie added the comment: My ENV: Python 2.7.12 (v2.7.12:d33e0cf91556, Jun 27 2016, 15:24:40) [MSC v.1500 64 bit ( AMD64)] on win32 -- type: -> behavior ___ Python tracker

[issue32226] Implement PEP 560: Core support for typing module and generic types

Serhiy Storchaka added the comment: As for __class_getitem__, why not implement type.__getitem__ instead of hacking PyObject_GetItem()? -- nosy: +serhiy.storchaka ___ Python tracker

[issue32288] Inconsistent behavior with slice assignment?

Stefan Krah added the comment: Thanks, David, you are of course right! -- I've worked so much with fixed arrays in the past year that Python's behavior seemed odd and unfathomable. :-) [Numpy arrays can't adopt that behavior, because growing them would be too

[issue32268] quopri.decode(): string argument expected, got 'bytes'

Alexey Luchko added the comment: Yes. With io.BytesIO() output, it works. However, this kind of error messages is quite very confusing. It better be possible to distinguish binary and text streams, so one (including quopri module) could tell it won't work in advance %)

[issue32287] Import of _pyio module failed on cygwin

Zachary Ware added the comment: Presumably this issue does prevent us from testing _pyio on Cygwin, which is not ideal. The outside usage of _pyio is definitely not supported, as Christian said, but this may be worth fixing anyway. -- nosy: +masamoto,

[issue32287] Import of _pyio module failed on cygwin

Matúš Valo added the comment: I am using not using _pyio module directly but I am using cherrypy server which is using this module (more precisely its component cheroot):

[issue30386] Add a build infrastructure for Android

STINNER Victor added the comment: See also https://github.com/python/buildmaster-config/pull/26 : "Add the Android build factory". -- ___ Python tracker

  1   2   >