[issue32872] backport of #32305 causes regressions in various packages

Matthias Klose added the comment: reopening. Lib/test/libregrtest/setup.py still needs fixing at least on 3.6, I didn't check the trunk. libregrtest/setup.py: 60c60 < if hasattr(module, '__file__'): --- > if getattr(module, '__file__', None): --

[issue33034] urllib.parse.urlparse and urlsplit not raising ValueError for bad port

Berker Peksag added the comment: New changeset 2cb4661707818cfd92556e7fdf9068a993577002 by Berker Peksag (Matt Eaton) in branch 'master': bpo-33034: Improve exception message when cast fails for {Parse,Split}Result.port (GH-6078)

[issue33041] Issues with "async for"

Change by Serhiy Storchaka : -- pull_requests: +5912 ___ Python tracker ___ ___

[issue33041] Issues with "async for"

Serhiy Storchaka added the comment: I'm surprised, but seems PR 6154 fixes the whole issue 3 in 3.7. It keeps only one POP_BLOCK corresponding to SETUP_LOOP. It also make the generated bytecode a tiny bit more efficient (less jumps). --

[issue19417] Bdb: add a unittest file (test.test_bdb)

Change by Xavier de Gaye : -- pull_requests: +5913 ___ Python tracker ___ ___

[issue33069] Maintainer information discarded when writing PKG-INFO

Nick Coghlan added the comment: Donald made an interesting suggestion over on https://github.com/pypa/packaging-problems/issues/127#issuecomment-374401331, which was to have distutils stop overwriting the Author metadata with the Maintainer metadata when both are

[issue33034] urllib.parse.urlparse and urlsplit not raising ValueError for bad port

Matt Eaton added the comment: Berker and Eric, thank you very much. I really like the idea of introducing a new API with more strict parsing rules for this situation. I would be willing to put some ideas down on a first pass at this. --

[issue33069] Maintainer information discarded when writing PKG-INFO

Paul Ganssle added the comment: > Donald made an interesting suggestion over on > https://github.com/pypa/packaging-problems/issues/127#issuecomment-374401331, > which was to have distutils stop overwriting the Author metadata with the > Maintainer metadata when both are

[issue33034] urllib.parse.urlparse and urlsplit not raising ValueError for bad port

Berker Peksag added the comment: The problem with adding a port_validation argument is that the port attribute is not the only thing that is computed lazily. There is also hostname, username, password attributes etc. I think the best way would be introducing a new

[issue33107] Feature request: more typing.SupportsXXX

New submission from Siyuan Ren : Currently in module `typing` we have the following classes * SupportsInt * SupportsFloat * SupportsComplex * SupportsBytes * SupportsRound There is no reason that people only need these classes. They may need, say, `SupportsIndex` to

[issue33108] Unicode char 304 in lowercase has len = 2

INADA Naoki added the comment: Another example: >>> s = "ß" >>> len(s) 1 >>> len(s.upper()) 2 >>> s.upper() 'SS' >>> ord(s) 223 > This breaks unicode text matching. What do you talking about? re module? -- nosy: +inada.naoki

[issue33109] argparse: make new 'required' argument to add_subparsers default to False instead of True

New submission from Wolfgang Maier : I find the True default for 'required' quite cumbersome introduced as a result of issue 26510. With existing parsers it can unnecessarily break compatibility between Python3.x versions only to make porting a bit

[issue33042] New 3.7 startup sequence crashes PyInstaller

Change by Nick Coghlan : -- pull_requests: +5914 stage: -> patch review ___ Python tracker ___

[issue33042] New 3.7 startup sequence crashes PyInstaller

Nick Coghlan added the comment: The linked PR has the draft test case for this - it goes beyond the ones I used to find the cause of the problem by actually checking that sys.warnoptions and sys._xoptions have been populated as expected. --

[issue33108] Unicode char 304 in lowercase has len 2

New submission from Kiril Dimitrov : >>> chr(304) 'İ' >>> chr(304).lower() 'i̇' >>> len(chr(304).lower()) 2 This breaks unicode text matching. There is no other unicode character with the same behaviour (in 3.6.2 and 3.6.4). -- components: Unicode messages:

[issue33108] Unicode char 304 in lowercase has len = 2

Change by Kiril Dimitrov : -- title: Unicode char 304 in lowercase has len 2 -> Unicode char 304 in lowercase has len = 2 ___ Python tracker

[issue33084] Computing median, median_high an median_low in statistics library

Change by Eric V. Smith : -- nosy: +eric.smith ___ Python tracker ___ ___

[issue28247] Add an option to zipapp to produce a Windows executable

Cheryl Sabella added the comment: Hi Paul, Were you interested in moving forward with this doc change? -- nosy: +csabella ___ Python tracker

[issue28247] Add an option to zipapp to produce a Windows executable

Paul Moore added the comment: Hi Cheryl, Looks like I dropped the ball on this one :-( I think it just needs to be applied to the main branch (3.7/3.8) - I don't think it's worth backporting. I'll try to get to it when I can, but it may not be for a few weeks, as I have

[issue11566] hypot define in pyconfig.h clashes with g++'s cmath

Change by Jeroen Demeyer : -- nosy: +jdemeyer ___ Python tracker ___ ___

[issue33108] Unicode char 304 in lowercase has len = 2

Kiril Dimitrov added the comment: This is roughly my use case: zip( "ßx", [0.5, 0.3]) is [('ß', 0.5), ('x', 0.3)] zip("ßx".upper(), [0.5, 0.3]) will be [('S', 0.5), ('S', 0.3)] in later case you never get to see the value for 'x'. At least my expectation was that

[issue33107] Feature request: more typing.SupportsXXX

Change by Ned Deily : -- nosy: +gvanrossum, levkivskyi ___ Python tracker ___ ___

[issue33036] test_selectors.PollSelectorTestCase failing on macOS 10.13.3

Nathan Henrie added the comment: I've continued looking into this. If you have your limits configured higher than default, as I did (and which seems to be working fine): ``` sudo launchctl limit maxfiles 64000 524288 ulimit -Sn 64000 ``` then you'll find that having a

[issue33110] Adding a done callback to a concurrent.futures Future once it has already completed, may raise an exception, contrary to docs

New submission from Sam Martin : Whilst working with concurrent.futures and ThreadPoolExecutors, my colleague and I have noted some undocumented behaviour. When adding a done_callback to a future that has already completed, we note that that callback is executed directly,

[issue33108] Unicode char 304 in lowercase has len = 2

Steven D'Aprano added the comment: It has never been the case that upper() or lower() are guaranteed to preserve string length in Unicode. For example, some characters decompose into a base plus combining characters. Ligatures are another example. See here for more

[issue33109] argparse: make new 'required' argument to add_subparsers default to False instead of True

Anthony Sottile added the comment: The intention of the change in issue 26510 was to pick the least surprising behaviour for the default value of subparsers -- the compatiblity with the behaviour before the regression was introduced in 3.3 was a nice side-effect. As with

[issue33109] argparse: make new 'required' argument to add_subparsers default to False instead of True

Anthony Sottile added the comment: Grabbed the wrong SO link, I believe this is the one I meant to link to: https://stackoverflow.com/a/18283730/812183 -- ___ Python tracker

[issue33021] Some fstat() calls do not release the GIL, possibly hanging all threads

Antoine Pitrou added the comment: Reopening for 3.x backports, as per Robert's advice. -- status: closed -> open versions: +Python 3.6, Python 3.7 ___ Python tracker

[issue33021] Some fstat() calls do not release the GIL, possibly hanging all threads

Change by miss-islington : -- pull_requests: +5916 stage: resolved -> patch review ___ Python tracker ___

[issue33021] Some fstat() calls do not release the GIL, possibly hanging all threads

Change by miss-islington : -- pull_requests: +5917 ___ Python tracker ___

[issue27212] Doc for itertools, 'islice()' implementation have unwanted behavior for recipe 'consume()'

Cheryl Sabella added the comment: Hi Nofar, Are you still interested in working on this issue? Thanks! -- nosy: +csabella ___ Python tracker

[issue28247] Add an option to zipapp to produce a Windows executable

miss-islington added the comment: New changeset 47a0e64ccf711e8d6d0c497d565ca7e2e82de7d4 by Miss Islington (bot) in branch '3.6': bpo-28247: Document Windows executable creation in zipapp (GH-6158)

[issue33061] NoReturn missing from __all__ in typing.py

Ivan Levkivskyi added the comment: I think it makes sense to also fix this in 3.7. I will prepare a backport now. -- ___ Python tracker

[issue28247] Add an option to zipapp to produce a Windows executable

Change by miss-islington : -- pull_requests: +5920 ___ Python tracker ___

[issue28247] Add an option to zipapp to produce a Windows executable

Change by miss-islington : -- pull_requests: +5919 ___ Python tracker ___

[issue33112] SequenceMatcher bug

New submission from Martin : difflib.SequenceMatcher fails to make a proper alignment between 2 sequences with only 3 single letter changes. Its performance is completely off with a similarity ratio of 0.16, in stead of the more accurate 0.99. Here is a snippet to replicate the

[issue33061] NoReturn missing from __all__ in typing.py

Change by Ivan Levkivskyi : -- pull_requests: +5918 ___ Python tracker ___ ___

[issue33112] SequenceMatcher bug

Tim Peters added the comment: Please see the response to issue31889. Short course: you need to pass `autojunk=False` to the SequenceMatcher constructor. -- nosy: +tim.peters resolution: -> duplicate stage: -> resolved status: open -> closed

[issue33094] dataclasses: ClassVar attributes are not working properly

Change by Eric V. Smith : -- resolution: -> not a bug stage: -> resolved status: open -> closed ___ Python tracker ___

[issue28247] Add an option to zipapp to produce a Windows executable

Paul Moore added the comment: New changeset 4be79f29463f632cd8b48486feadc2ed308fb520 by Paul Moore (Cheryl Sabella) in branch 'master': bpo-28247: Document Windows executable creation in zipapp (GH-6158)

[issue33094] dataclasses: ClassVar attributes are not working properly

Adrian Stachlewski added the comment: There's nothing to do, thanks for help one more again. -- status: pending -> open ___ Python tracker

[issue33018] Improve issubclass() error checking and message

Ivan Levkivskyi added the comment: I am still -1 on changing this in Python 3.7, unless Guido wants this in 3.7, if yes, then we can go ahead. Otherwise, I think we can consider just merging this into master, in this case I would switch to the PR to discuss the details.

[issue33077] typing: Unexpected result with value of instance of class inherited from typing.NamedTuple

Ivan Levkivskyi added the comment: > Would it be worthwhile to show an example of a subclass that overrides or > extends __new__? I think yes. I would actually add few examples what could (and maybe also couldn't) be done with named tuples. --

[issue33111] Merely importing tkinter breaks parallel code (multiprocessing, sharedmem)

Ned Deily added the comment: Are you by any chance trying to run this under IDLE? -- nosy: +ned.deily ___ Python tracker ___

[issue28247] Add an option to zipapp to produce a Windows executable

miss-islington added the comment: New changeset a70b8f593657f563116001f654587620271eb9ae by Miss Islington (bot) in branch '3.7': bpo-28247: Document Windows executable creation in zipapp (GH-6158)

[issue18802] ipaddress documentation errors

Xiang Zhang added the comment: New changeset 5609b78392d59c7362ef8aa5c4a4529325f01f27 by Xiang Zhang (Cheryl Sabella) in branch 'master': bpo-18802: Add more details to ipaddress documentation (GH-6083)

[issue27683] ipaddress subnet slicing iterator malfunction

miss-islington added the comment: New changeset 3326c9267f9df15fa77094b8a740be4eaa4b9374 by Miss Islington (bot) in branch '3.7': bpo-27683: Fix a regression for host() of ipaddress network objects (GH-6016)

[issue33018] Improve issubclass() error checking and message

Guido van Rossum added the comment: While we're in feature freeze mode, we're not in release candidate mode yet. I presume the code that would be patched in 3.7 is no different from master? What's the concern? It doesn't seem anyone thinks it's risky? --

[issue28577] ipaddress.ip_network(...).hosts() returns nothing for an IPv4 /32

Xiang Zhang added the comment: I fixed #27683 since it looks more like an oversight and regression to me instead of a deliberate change. I'd like the behaviour to be consistent across versions. As for "/32", it needs discussion or some expert makes a choice. --

[issue33093] Fatal error on SSL transport

kyuupichan added the comment: Looks like https://bugs.python.org/issue33037 -- nosy: +kyuupichan ___ Python tracker ___

[issue32941] mmap should expose madvise()

Change by Zackery Spytz : -- keywords: +patch pull_requests: +5927 stage: -> patch review ___ Python tracker ___

[issue27683] ipaddress subnet slicing iterator malfunction

Change by miss-islington : -- pull_requests: +5923 ___ Python tracker ___

[issue27683] ipaddress subnet slicing iterator malfunction

Xiang Zhang added the comment: New changeset 10b134a07c898c2fbc5fd3582503680a54ed80a2 by Xiang Zhang in branch 'master': bpo-27683: Fix a regression for host() of ipaddress network objects (GH-6016)

[issue27683] ipaddress subnet slicing iterator malfunction

miss-islington added the comment: New changeset ae2feb32e7eff328199ce7d527593b3c2aa1fcab by Miss Islington (bot) in branch '3.6': bpo-27683: Fix a regression for host() of ipaddress network objects (GH-6016)

[issue32896] Error when subclassing a dataclass with a field that uses a defaultfactory

Change by miss-islington : -- pull_requests: +5926 ___ Python tracker ___

[issue33018] Improve issubclass() error checking and message

INADA Naoki added the comment: If there are some code which depend on ABC.__subclasscheck__() allow class-like object, we'll have to revert it in 3.7b4 or rc. I think it's the only risk. -- ___ Python tracker

[issue33018] Improve issubclass() error checking and message

Guido van Rossum added the comment: Hmm... That is actually a not entirely imaginary risk, right? Can you come up with a test program that would fail that way? -- ___ Python tracker

[issue18802] ipaddress documentation errors

Change by miss-islington : -- pull_requests: +5921 ___ Python tracker ___

[issue18802] ipaddress documentation errors

Change by miss-islington : -- pull_requests: +5922 ___ Python tracker ___

[issue27683] ipaddress subnet slicing iterator malfunction

Change by Xiang Zhang : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.8 -Python 3.5 ___ Python tracker

[issue18802] ipaddress documentation errors

Change by Xiang Zhang : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue18802] ipaddress documentation errors

miss-islington added the comment: New changeset a323eee4c481c88f2b4030bbb224d9bc6bc14c9c by Miss Islington (bot) in branch '3.7': bpo-18802: Add more details to ipaddress documentation (GH-6083)

[issue32896] Error when subclassing a dataclass with a field that uses a defaultfactory

Change by Eric V. Smith : -- priority: deferred blocker -> release blocker versions: +Python 3.8 ___ Python tracker ___

[issue32896] Error when subclassing a dataclass with a field that uses a defaultfactory

Change by Eric V. Smith : -- keywords: +patch pull_requests: +5925 stage: -> patch review ___ Python tracker ___

[issue33083] math.factorial accepts non-integral Decimal instances

Tim Peters added the comment: factorial(float) was obviously intended to work the way it does, so I'd leave it alone in whatever changes are made to resolve _this_ issue. I view it as a harmless-enough quirk, but, regardless, if people want to deprecate it that should be a

[issue27683] ipaddress subnet slicing iterator malfunction

Change by miss-islington : -- pull_requests: +5924 ___ Python tracker ___

[issue18802] ipaddress documentation errors

miss-islington added the comment: New changeset 481cbe8d6202658a7908d97f19f7e9e6061e3df3 by Miss Islington (bot) in branch '3.6': bpo-18802: Add more details to ipaddress documentation (GH-6083)

[issue32896] Error when subclassing a dataclass with a field that uses a defaultfactory

Eric V. Smith added the comment: New changeset 8f6eccdc64cab735c47620fea948e64b19f83684 by Eric V. Smith in branch 'master': bpo-32896: Fix error when subclassing a dataclass with a field that uses a default_factory (GH-6170)

[issue28247] Add an option to zipapp to produce a Windows executable

Cheryl Sabella added the comment: Hi Paul, Thanks for your response. I've made the pull request from your patch, so it would great if you could review it. Thanks! -- ___ Python tracker

[issue28247] Add an option to zipapp to produce a Windows executable

Change by Cheryl Sabella : -- pull_requests: +5915 ___ Python tracker ___ ___

[issue33109] argparse: make new 'required' argument to add_subparsers default to False instead of True

Anthony Sottile added the comment: Yeah, I picked the default value `True` because I couldn't actually find a user of subparsers that _wanted_ optional subparsers. ¯\_(ツ)_/¯ -- ___ Python tracker

[issue33107] Feature request: more typing.SupportsXXX

Guido van Rossum added the comment: Such a mechanism exists, and is called Protocols. See PEP 544 (https://www.python.org/dev/peps/pep-0544/). While the PEP is still in draft, it is supported by mypy. You need to import the 'Protocol' base class from typing_extensions

[issue25345] Unable to install Python 3.5 on Windows 10

Steve Dower added the comment: Yeah, very strange that only some MSIs are being affected by this error. They no doubt have something in common. If by clean boot you mean reinstalling Windows, then yes, that fixes most issues, but it is pretty drastic :) I don't

[issue33109] argparse: make new 'required' argument to add_subparsers default to False instead of True

Wolfgang Maier added the comment: On 03/20/2018 04:38 PM, Anthony Sottile wrote: > > Anthony Sottile added the comment: > > The intention of the change in issue 26510 was to pick the least surprising > behaviour for the default

[issue33109] argparse: make new 'required' argument to add_subparsers default to False instead of True

Wolfgang Maier added the comment: _wants_ is a bit a strong word, but, at least, you can do a bit a nicer job than the default error, like printing a nicely formatted list of subcommands as you would get it with the main parsers help. In fact, in my

[issue33021] Some fstat() calls do not release the GIL, possibly hanging all threads

Antoine Pitrou added the comment: New changeset 56cce1ca84344f519f7ed01024434c083031d354 by Antoine Pitrou (Miss Islington (bot)) in branch '3.7': [3.7] bpo-33021: Release the GIL during fstat() calls (GH-6019) (GH-6159)

[issue33111] Merely importing tkinter breaks parallel code (multiprocessing, sharedmem)

New submission from Ethan Welty : Merely importing tkinter breaks the use of parallel code on my system (Mac OSX 10.11.6, tested on Python 2.7.13 / 2.7.14 / 3.5.0 / 3.6.4, all barebones distributions installed with pyenv). I've tested this with both multiprocessing and

[issue33111] Merely importing tkinter breaks parallel code (multiprocessing, sharedmem)

Change by Ethan Welty : -- versions: -Python 3.8 ___ Python tracker ___ ___

[issue33021] Some fstat() calls do not release the GIL, possibly hanging all threads

Antoine Pitrou added the comment: New changeset f3e6eadbcf4f3e0fe53f4784485b1c8464c7d282 by Antoine Pitrou (Miss Islington (bot)) in branch '3.6': [3.6] bpo-33021: Release the GIL during fstat() calls (GH-6019) (GH-6160)

[issue33021] Some fstat() calls do not release the GIL, possibly hanging all threads

Change by Antoine Pitrou : -- stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue33082] multiprocessing docs bury very important 'callback=' args

Antoine Pitrou added the comment: I don't really agree that "callbacks are really important in multiprocessing" (I think I've hardly ever used them). I agree with the other doc changes in the PR. -- ___ Python tracker