[issue33213] crypt function not hashing properly

Ron Reiter added the comment: Python 3.6.4 (default, Mar 22 2018, 23:35:12) [GCC 4.2.1 Compatible Apple LLVM 9.0.0 (clang-900.0.39.2)] on darwin Type "help", "copyright", "credits" or "license" for more information. >>> import crypt >>> crypt.crypt("test",

[issue33213] crypt function not hashing properly

Ron Reiter added the comment: Also: >>> crypt.crypt("test", "$5") '$5yVOkTkyRzn.' >>> crypt.crypt("test", "$6") '$6asQOJRqB1i2' >>> crypt.crypt("test", "$7") '$7tSOkvDyiL6U' So the salt is "$6" -- ___ Python tracker

[issue33034] urllib.parse.urlparse and urlsplit not raising ValueError for bad port

Matt Eaton added the comment: Wanted to check in on this to see if there was any feedback on this topic? -- ___ Python tracker

[issue33181] SimpleHTTPRequestHandler shouldn't redirect to directories with code 301

Matt Eaton added the comment: Wanted to check in on this to see if there was any feedback by any community or core members? -- ___ Python tracker

[issue33203] random.choice: raise IndexError on empty sequence even when not using getrandbits internally

Wolfgang Maier added the comment: @selik: it's true _randbelow doesn't work for negative numbers, but the difference is that both branches are affected, the docstring does not make any guarantees about it, and no public part of the random module is

[issue33213] crypt function not hashing properly

Ron Reiter added the comment: Apparently it's a Mac issue. My crypt.methods only contains [] which is probably why this fails. It's a silent failure of some sort that is causing this. -- ___ Python tracker

[issue33189] pygettext doesn't work with f-strings

Riccardo Polignieri added the comment: > the error should be better Yes, that's what I maeant - sorry I should have phrased better. I marked by mistake a couple of f-strings for translation and totally forgot about it for a while... it took me some time to

[issue33213] crypt function not hashing properly

Christian Heimes added the comment: The crypt module is a thin wrapper around the OS' crypt(3) function. The function should return NULL for unsupported salt types. The module turns NULL into None. What's the return value of crypt.crypt("test", crypt.METHOD_SHA512) ?

[issue33213] crypt function not hashing properly on Mac (uses a specific salt)

Change by Ron Reiter : -- title: crypt function not hashing properly -> crypt function not hashing properly on Mac (uses a specific salt) ___ Python tracker

[issue33203] random.choice: raise IndexError on empty sequence even when not using getrandbits internally

Wolfgang Maier added the comment: @rhettinger: the reason the ValueError gets raised correctly in the getrandbits-dependent branch is because getrandbits itself does a n<=0 check (in C for random.Random, in Python for random.SystemRandom). So I thought

[issue33213] crypt function not hashing properly

Serhiy Storchaka added the comment: I can't reproduce this result. Does your os.urandom() broken and return a short repeated sequence? -- nosy: +mark.dickinson, rhettinger, serhiy.storchaka ___ Python tracker

[issue33209] Repeated Pickler.dump() doesn't reset the state in the C implementation of pickle

Change by Serhiy Storchaka : -- pull_requests: +6073 ___ Python tracker ___ ___

[issue33211] lineno and col_offset are wrong on function definitions with decorators

Serhiy Storchaka added the comment: See how similar issue was solved in Pyflakes: https://github.com/PyCQA/pyflakes/pull/273. Python tests also needed special workaround, see Lib/test/test_sys_settrace.py and issue17288. -- nosy: +serhiy.storchaka

[issue32360] Save OrderedDict imports in various stdlibs.

Change by INADA Naoki : -- dependencies: -Dict order is now guaranteed, so add tests and doc for it stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue33212] add several options to msgfmt.py

New submission from umedoblock : = Why do I add several options ? I'd like to effectively know a progress of translate about some po files when KiCad dev team announce to public KiCad 5.0 major. Because KiCad dev team separates PCB design tools to exe files. And I used the

[issue33212] add several options to msgfmt.py

umedoblock added the comment: Sorry, I forgot to add a patch file. -- keywords: +patch Added file: https://bugs.python.org/file47518/a.patch ___ Python tracker

[issue33214] join method for list and tuple

Javier Dehesa added the comment: Thanks Christian. I thought of join precisely because it performs conceptually the same function as with str, so the parallel between ''.join(), [].join() and ().join() looked more obvious. Also there is os.path.join and PurePath.joinpath,

[issue33213] crypt function not hashing properly on Mac (uses a specific salt)

Raymond Hettinger added the comment: > What's the return value of crypt.crypt("test", crypt.METHOD_SHA512) This is from my Mac (10.13.3): $ python3.6 Python 3.6.4 (v3.6.4:d48ecebad5, Dec 18 2017, 21:07:28) [GCC 4.2.1 (Apple Inc. build 5666) (dot 3)] on darwin

[issue33189] pygettext doesn't work with f-strings

Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +6074 stage: -> patch review ___ Python tracker ___

[issue30891] importlib: _find_and_load() race condition on sys.modules[name] check

Steve Dower added the comment: I recommend and use it without trouble, but then I rarely defer imports to worker threads. Barry may have some ideas, but I think this really shouldn't be difficult to do. importlib is pretty extensible, and it's not difficult to read

[issue33214] join method for list and tuple

New submission from Javier Dehesa : It is pretty trivial to concatenate a sequence of strings: ''.join([str1, str2, ...]) Concatenating a sequence of lists is for some reason significantly more convoluted. Some current options include: sum([lst1, lst2, ...], [])

[issue31201] make test: module test that failed doesn't exist

Change by Steven Downum : -- nosy: +steven.downum ___ Python tracker ___ ___

[issue33193] Cannot create a venv on Windows when directory path contains dollar character

Wolfgang Maier added the comment: An exotic case, but it also affects Linux: python3.7 -m venv 'at$test' Error: Command '['/home/maier/at$test/bin/python3.7', '-Im', 'ensurepip', '--upgrade', '--default-pip']' returned non-zero exit status 2.

[issue33214] join method for list and tuple

Christian Heimes added the comment: join() is a bad choice, because new developers will confusing list.join with str.join. We could turn list.extend(iterable) into list.extend(*iterable). Or you could just use extend with a chain iterator: >>> l = [] >>>

[issue33214] join method for list and tuple

Serhiy Storchaka added the comment: String concatenation: f'{a}{b}{c}' List concatenation: [*a, *b, *c] Tuple concatenation: (*a, *b, *c) Set union: {*a, *b, *c} Dict merging: {**a, **b, **c} -- nosy: +serhiy.storchaka

[issue33215] PyPI API wiki pages could link to Warehous docs please

Change by Sumana Harihareswara : -- nosy: +sumanah ___ Python tracker ___ ___

[issue30891] importlib: _find_and_load() race condition on sys.modules[name] check

Brett Cannon added the comment: The other problem is zipimport is written in C and no one wants to deal with that headache if possible. ;) We actually tweaked the importlib.resources API specifically to avoid having to muck with zipimport's C code as it would have required

[issue33215] PyPI API wiki pages could link to Warehous docs please

New submission from Marius Gedminas : Now that Warehouse is preparing to replace the old PyPI codebase I think it would be a good idea if the old PyPI API documentation pages on the Python wiki would link to the new Warehouse API documentation. Specifically, -

[issue33216] CALL_FUNCTION_VAR

Change by Manuel Vazquez Acosta : -- nosy: mvaled priority: normal severity: normal status: open title: CALL_FUNCTION_VAR ___ Python tracker

[issue33216] Wrong order of stack for CALL_FUNCTION_VAR and CALL_FUNCTION_VAR_KW

New submission from Manuel Vazquez Acosta : The documentation of the dis module says that: CALL_FUNCTION_VAR (argc) Calls a function. *argc* is interpreted as in CALL_FUNCTION. The top elements on the stack are the keyword arguments, followed by the variable

[issue33216] Wrong order of stack for CALL_FUNCTION_VAR and CALL_FUNCTION_VAR_KW

Change by Manuel Vazquez Acosta : -- keywords: +patch pull_requests: +6075 stage: -> patch review ___ Python tracker ___

[issue33216] Wrong order of stack for CALL_FUNCTION_VAR and CALL_FUNCTION_VAR_KW

Manuel Vazquez Acosta added the comment: Correction, the documentation for CALL_FUNCTION_VAR said: Calls a function. *argc* is interpreted as in :opcode:`CALL_FUNCTION`. The top element on the stack contains the variable argument list, followed by keyword and positional

[issue33219] x in IntFlag() should test int x's inclusion in IntFlag

New submission from Dutcho : While `enum.IntFlag.__and__` accepts an int arg `other` and converts it to `IntFlag` before masking, `enum.IntFlag.__contains__` handles an int arg `other` no different from a different type arg `other` (i.e. returns `True` in Python 3.6 due to

[issue33219] x in IntFlag() should test int x's inclusion in IntFlag

Change by Ethan Furman : -- assignee: -> ethan.furman nosy: +barry, eli.bendersky, ethan.furman versions: +Python 3.8 -Python 3.6 ___ Python tracker

[issue33216] Wrong order of stack for CALL_FUNCTION_VAR and CALL_FUNCTION_VAR_KW

Change by Serhiy Storchaka : -- nosy: +larry, ned.deily ___ Python tracker ___

[issue33209] Repeated Pickler.dump() doesn't reset the state in the C implementation of pickle

Łukasz Langa added the comment: New changeset 74735e2a404949b2a0c17ac13a2de0e0cac6fc41 by Łukasz Langa (Miss Islington (bot)) in branch '3.7': bpo-33209: End framing at the end of C implementation of pickle.Pickler.dump(). (GH-6366)

[issue33217] x in enum.Flag() is True when x is no Flag

Dutcho added the comment: Fully agree that Flag.__contains__ must RETURN False or True; that's why I suggested it RAISES TypeError The exception was to be consistent with e.g. Flag.__and__, which by returning NotImplemented transfers to type(other).__rand__, and assuming

[issue33217] x in enum.Flag() is True when x is no Flag

Dutcho added the comment: Ah, the mixin logic mentioned in 33219 solves most of my objections to returning False; agree that would make sense Only remaining inconsistency would be with 1 in 'hello' -- ___ Python tracker

[issue30891] importlib: _find_and_load() race condition on sys.modules[name] check

Barry A. Warsaw added the comment: Take a look at https://bugs.python.org/issue25711 which wants to rewrite zipimport from scratch. I took Serhiy's C->Python patch and turned it into a PR, but it would need a lot of love to get it into shape. (Let's not even talk about

[issue33217] x in enum.Flag() is True when x is no Flag

Change by Ethan Furman : -- assignee: -> ethan.furman nosy: +barry, eli.bendersky, ethan.furman versions: +Python 3.7, Python 3.8 ___ Python tracker

[issue33217] x in enum.Flag() is True when x is no Flag

Ethan Furman added the comment: Thanks for finding this! However, TypeError, an exception, is not the correct type of answer -- the correct type of answer for a yes/no question is either True or False. So the code should be changed from returning NotImplemented to

[issue24960] Can't use lib2to3 with embeddable zip file.

Lukasz added the comment: I have simmilar problem but im using python 2.7 on android. So I think I cant use this solution My problem: https://bugs.python.org/issue33208 -- nosy: +Lukasz00500 ___ Python tracker

[issue33209] Repeated Pickler.dump() doesn't reset the state in the C implementation of pickle

Łukasz Langa added the comment: New changeset c869529ea9fbed574d34cf7ac139ca3f81b62ef0 by Łukasz Langa (Serhiy Storchaka) in branch 'master': bpo-33209: End framing at the end of C implementation of pickle.Pickler.dump(). (GH-6363)

[issue33209] Repeated Pickler.dump() doesn't reset the state in the C implementation of pickle

Change by miss-islington : -- pull_requests: +6077 ___ Python tracker ___

[issue33219] x in IntFlag() should test int x's inclusion in IntFlag

Ethan Furman added the comment: issue33217 will not be "fixed" with a TypeError, but incorrect Falses are also bad. Rather than add __contains__ to IntFlag (and every other Flag mixin), I think the best answer is to adjust Flag.__contains__ a little bit more to check if

[issue33217] x in enum.Flag() is True when x is no Flag

New submission from Dutcho : While `Flag() in Flag()` and `Flag() | Flag()` result in the expected outcomes, e.g. `str() in Flag()` unexpectedly returns `True`, whereas `Flag() | str()` as expected raises a TypeError. >>> import enum >>> ABC = enum.Flag('ABC', 'a, b,

[issue33218] Fix instances in documentation where dictionaries are referenced as unordered

New submission from arjun v : In python 3.6 (and above hopefully), dictionary keys are going to be ordered, while their documentation still reference them as being unordered. https://docs.python.org/3/tutorial/datastructures.html#dictionaries 1: `It is best to think of a

[issue30891] importlib: _find_and_load() race condition on sys.modules[name] check

Guido van Rossum added the comment: OK, this sounds much better: zipimport has problems and we should fix them, presumably by getting Thomas's fixes (sans Google-isms, which may require some effort). I don't believe Łukasz's recommendation "don't use it" is the right attitude

[issue33209] Repeated Pickler.dump() doesn't reset the state in the C implementation of pickle

Change by miss-islington : -- pull_requests: +6078 ___ Python tracker ___

[issue33209] Repeated Pickler.dump() doesn't reset the state in the C implementation of pickle

miss-islington added the comment: New changeset a5c8830637cde632ab3bcf5475698dcf0fb0546d by Miss Islington (bot) in branch '3.6': bpo-33209: End framing at the end of C implementation of pickle.Pickler.dump(). (GH-6363)

[issue33221] Add stats for asyncio task usage.

Andrew Svetlov added the comment: Well, event based solution is more powerful than just statistic collection. Please keep me in the loop. -- ___ Python tracker

[issue33217] x in enum.Flag() is True when x is no Flag

Ethan Furman added the comment: Strings are actually the odd-man out -- dicts, sets, lists, tuples, etc., all return False instead of raising TypeError. The reason str raises an error is because `in`, for str, is a substring check, not a membership check. --

[issue33221] Add stats for asyncio task usage.

Change by Joongi Kim : -- nosy: +achimnol ___ Python tracker ___ ___ Python-bugs-list

[issue33220] Antivirus hits on python-2.7.14.amd64.msi file

New submission from Brett Rasmussen : The antivirus program 'AVG Business Edition' reported that the file python-2.7.14.amd64.msi contained "Trojan horse SCGeneric_c6.HJQ". The virustotal.com web site reported a match on MD5 370014d73c3059f610c27365def62058 for file

[issue33221] Add stats for asyncio task usage.

Alexander Mohr added the comment: another idea would be neat to somehow plug into the stats so people can trace (ex: via datadog tracing) "slow" tasks, similarly to things that are outputted via PYTHONASYNCIODEBUG, however in this case be able to trace slow steps and

[issue15088] PyGen_NeedsFinalizing is public, but undocumented

Cheryl Sabella added the comment: Thanks again, Antoine. I'll see what I can come up with. :-) -- ___ Python tracker ___

[issue33211] lineno and col_offset are wrong on function definitions with decorators

Ethan Smith added the comment: There is also a relevant mypy bug report https://github.com/python/mypy/issues/3871. This seems like a common problem for tools working on the AST. The relevant code seems to be https://github.com/python/cpython/blob/master/Python/ast.c#L1695.

[issue33221] Add stats for asyncio task usage.

Yury Selivanov added the comment: > Yuri, what do you think about? I plan to use contextvars module to introduce a full-blown tracing API to asyncio to selectively log events like tacks creations, event loop switching, IO done by transports etc. The plan is to

[issue33221] Add stats for asyncio task usage.

New submission from Andrew Svetlov : I suggest adding a `Task.stats()` method. The method should return a dict with the task usage statistics. Dict keys: - total_time: a time between task creation and a moment of the call (or task finishing timestamp if the task has

[issue33221] Add stats for asyncio task usage.

Nathaniel Smith added the comment: FYI, here's how trio handles such things – I'm sure it's not perfect, but might be useful for inspiration: https://trio.readthedocs.io/en/latest/reference-hazmat.html#instrument-api -- nosy: +njs

[issue33195] PyArg_Parse* should deprecate 'u' and 'z' family.

INADA Naoki added the comment: OK, I replaced Py_UNICODE with wchar_t in Py_BuildValue document. -- ___ Python tracker ___

[issue33213] crypt function not hashing properly

New submission from Ron Reiter : import crypt Expected result: >>> crypt.crypt("test") == crypt.crypt("test") False >>> crypt.crypt("test", crypt.mksalt()) == crypt.crypt("test", crypt.mksalt()) False Unexpected results: >>> crypt.crypt("test", crypt.METHOD_SHA512) ==

[issue33213] crypt function not hashing properly

Ron Reiter added the comment: import crypt Expected result: >>> crypt.crypt("test") == crypt.crypt("test") False >>> crypt.crypt("test", crypt.mksalt()) == crypt.crypt("test", crypt.mksalt()) False Unexpected results: >>> crypt.crypt("test", crypt.METHOD_SHA512) ==

[issue33213] crypt function not hashing properly

Ron Reiter added the comment: You guessed it, the salt is "$6" -- ___ Python tracker ___

[issue33218] Fix instances in documentation where dictionaries are referenced as unordered

Change by INADA Naoki : -- resolution: -> duplicate stage: -> resolved status: open -> closed superseder: -> Dict order is now guaranteed, so add tests and doc for it ___ Python tracker

[issue33218] Fix instances in documentation where dictionaries are referenced as unordered

Raymond Hettinger added the comment: Also check the 3.7 docs to see if this work has already been done. It's unlikely that the 3.6 docs will change because it is considered a non-guaranteed implementation detail for 3.6. --

[issue33218] Fix instances in documentation where dictionaries are referenced as unordered

Raymond Hettinger added the comment: Would you like to make a pull request or do you prefer for me to assign it to someone else? -- nosy: +rhettinger versions: -Python 3.6 ___ Python tracker

[issue32337] Dict order is now guaranteed, so add tests and doc for it

Steven D'Aprano added the comment: I started to add this comment to #33218 but Raymond closed that ticket while I was editing it. In 3.6, dicts preserving insertion order remains an implementation detail that cannot be relied on. It only becomes a guarantee in

[issue32337] Dict order is now guaranteed, so add tests and doc for it

INADA Naoki added the comment: > I started to add this comment to #33218 but Raymond closed that ticket while > I was editing it. Sorry, I closed it, not Raymond. -- ___ Python tracker

[issue32337] Dict order is now guaranteed, so add tests and doc for it

INADA Naoki added the comment: New changeset dfbbbf16f9aab82330c634913441b5ac73267d9c by INADA Naoki (hui shang) in branch 'master': bpo-32337: Update documentats about dict order (GH-4973)

[issue32337] Dict order is now guaranteed, so add tests and doc for it

Change by miss-islington : -- pull_requests: +6079 ___ Python tracker ___

[issue33195] PyArg_Parse* should deprecate 'u' and 'z' family.

INADA Naoki added the comment: New changeset 42ec190761a2e8503aaa06f0bfaaabe98749179b by INADA Naoki in branch 'master': bpo-33195: Doc: Deprecate Py_UNICODE in c-api/arg (GH-6329) https://github.com/python/cpython/commit/42ec190761a2e8503aaa06f0bfaaabe98749179b

[issue33195] PyArg_Parse* should deprecate 'u' and 'z' family.

Change by miss-islington : -- pull_requests: +6080 ___ Python tracker ___

[issue32337] Dict order is now guaranteed, so add tests and doc for it

miss-islington added the comment: New changeset 9216dffbc8a2aa62789f81f51f64bc1ec7bf6883 by Miss Islington (bot) in branch '3.7': bpo-32337: Update documentats about dict order (GH-4973)

[issue33221] Add stats for asyncio task usage.

Joongi Kim added the comment: I like trio-style instrumentation API because it could be used for more generic purposes, not only for statistics. This stats or instrumentation API will greatly help me to utilize external monitoring services such as Datadog in my

[issue33219] x in IntFlag() should test int x's inclusion in IntFlag

Nitish added the comment: @Ethan Furman how can Flag do that? IntFlag can deal with int values too. Would it be possible to deal with int values in this case in Flag.__contains__? -- nosy: +nitishch ___ Python tracker

[issue33209] Repeated Pickler.dump() doesn't reset the state in the C implementation of pickle

Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue33216] Wrong order of stack for CALL_FUNCTION_VAR and CALL_FUNCTION_VAR_KW

Change by Ned Deily : -- assignee: docs@python -> larry nosy: -ned.deily ___ Python tracker ___

[issue33220] Antivirus hits on python-2.7.14.amd64.msi file

Change by Ned Deily : -- nosy: +paul.moore, steve.dower, tim.golden, zach.ware ___ Python tracker ___

[issue33195] PyArg_Parse* should deprecate 'u' and 'z' family.

miss-islington added the comment: New changeset b8fc2d658094941250116a48577f54d1f6300362 by Miss Islington (bot) in branch '3.7': bpo-33195: Doc: Deprecate Py_UNICODE in c-api/arg (GH-6329)

[issue33216] Wrong order of stack for CALL_FUNCTION_VAR and CALL_FUNCTION_VAR_KW

Serhiy Storchaka added the comment: I confirm that this issue is 3.5-only. Before 3.5 the order matched the documentation. After 3.5 these opcodes were completely rewritten and they use now other way of passing arguments. -- nosy: +serhiy.storchaka

[issue33215] PyPI API wiki pages could link to Warehous docs please

Ned Deily added the comment: You should probably bring this up on the packaging mailing list: https://mail.python.org/mailman/listinfo/distutils-sig or on the Warehouse issue tracker: https://github.com/pypa/warehouse/issues -- nosy: +ned.deily resolution: -> third

[issue33215] PyPI API wiki pages should be mutable

Sumana Harihareswara added the comment: The problem mgedmin is experiencing is that these particular wiki.python.org pages are immutable, which is not a problem Warehouse maintainers (like me) can solve, and I believe it's also not a problem people on distutils-sig can

[issue33215] PyPI API wiki pages should be mutable

Ned Deily added the comment: wiki.python.org pages aren't immutable. Anyone can ask for Wiki editing permission. See https://wiki.python.org/moin/: If you want to edit a page and have just signed up, or you find that you can no longer edit a page that you could edit