[issue32638] distutils test errors with AIX and xlc

2018-08-09 Thread Michael Felt
Michael Felt added the comment: this can be closed. Discussion, if any, at https://github.com/python/cpython/pull/8709 or issue11191 -- stage: -> resolved status: open -> closed ___ Python tracker

[issue34360] urllib.parse doesn't fail with multiple unmatching square brackets

2018-08-09 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +xtreak ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue29036] logging module: Add `full_module_name` to LogRecord details

2018-08-09 Thread Vinay Sajip
Vinay Sajip added the comment: The full module name isn't readily available. The value that sets the LogRecord's pathname attribute [which is obtained from the Python code object for the caller] is used to derive the filename attribute (by taking the basename of the pathname) and the

[issue34366] _uuid module fails to compile on FreeBSD when libuuid is installed

2018-08-09 Thread Michał Górny
Change by Michał Górny : -- keywords: +patch pull_requests: +8198 stage: -> patch review ___ Python tracker ___ ___

[issue34366] _uuid module fails to compile on FreeBSD when libuuid is installed

2018-08-09 Thread Michał Górny
implementations will not be present simultaneously. However, some software supports libuuid only, so we're forced to have both. Attaching the complete build log. I will submit a PR soonish. -- components: Extension Modules files: dev-lang:python-3.7.0:20180809-062928.log messages: 323317 nosy

[issue27494] 2to3 parser failure caused by a comma after a generator expression

2018-08-09 Thread Łukasz Langa
Łukasz Langa added the comment: This is one of those issues where it's clear that the parser and 2to3 should be separate. -- nosy: +lukasz.langa ___ Python tracker ___

[issue34212] Cygwin link failure with builtin modules since issue30860

2018-08-09 Thread Erik Bray
Erik Bray added the comment: I added a new PR modifying makesetup and adding a new variable to Makefile.pre.in, PY_BUILTIN_MODULE_CFLAGS, explicitly for building built-in modules. I think this, or some version of it, is a cleaner solution than my previous brute-force approach. --

[issue34347] AIX: test_utf8_mode.test_cmd_line fails

2018-08-09 Thread Michael Felt
Michael Felt added the comment: Starting this discussion again. Please take time to read. I have spent hours trying to understand what is failing. Please spend a few minutes reading. Sadly, there is a lot of text - but I do not know what I could leave out without damaging the process of

[issue34363] dataclasses.asdict() mishandles dataclass instance attributes that are instances of subclassed typing.NamedTuple

2018-08-09 Thread Ivan Levkivskyi
Ivan Levkivskyi added the comment: The problem with this solution is that it may brea (relatively common) use case of tuple valued fields, e.g.: >>> tuple(*[x for x in a]) Traceback (most recent call last): File "", line 1, in TypeError: tuple expected at most 1 arguments, got 2

[issue34212] Cygwin link failure with builtin modules since issue30860

2018-08-09 Thread Erik Bray
Change by Erik Bray : -- pull_requests: +8199 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34270] Add names to asyncio tasks

2018-08-09 Thread Alex Grönholm
Alex Grönholm added the comment: Yury, I have no objections. Furthermore, it would be nice to expose the coroutine object publicly, like curio and trio do. It would make life simpler for me in some cases. -- ___ Python tracker

[issue34270] Add names to asyncio tasks

2018-08-09 Thread Yury Selivanov
Yury Selivanov added the comment: > Ok, I understand. But is the conversion a bad thing then? It's not a bad thing, it's just that we don't do it in C Task and we do it in pure Python Task. Eric wants us to synchronize them so that in a very unlikely scenario where someone uses subclasses

[issue34324] Doc README wrong directory name for venv

2018-08-09 Thread miss-islington
miss-islington added the comment: New changeset 0ee2a29585e3c17e38eb6e6a2515405e40be22b5 by Miss Islington (bot) in branch '3.6': bpo-34324: Doc README wrong directory name for venv (GH-8650) https://github.com/python/cpython/commit/0ee2a29585e3c17e38eb6e6a2515405e40be22b5 --

[issue34270] Add names to asyncio tasks

2018-08-09 Thread Yury Selivanov
Yury Selivanov added the comment: As a side note, Alex, what do you think about appending coroutine's name to Task's name if the latter is autogenerated? -- ___ Python tracker

[issue34270] Add names to asyncio tasks

2018-08-09 Thread Yury Selivanov
Yury Selivanov added the comment: > I also couldn't figure out yet why PyUnicode_Check() was necessary in the > first place. Doesn't PyObject_Str() just increment the refcount if the > argument is already a string? `str()` returns its argument if it's exactly a `builtins.str` instance. If

[issue34324] Doc README wrong directory name for venv

2018-08-09 Thread miss-islington
Change by miss-islington : -- pull_requests: +8201 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34324] Doc README wrong directory name for venv

2018-08-09 Thread miss-islington
Change by miss-islington : -- pull_requests: +8200 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34324] Doc README wrong directory name for venv

2018-08-09 Thread miss-islington
miss-islington added the comment: New changeset fe8f90aa3ca3f277cac634cdb96b829039225c6b by Miss Islington (bot) in branch '3.7': bpo-34324: Doc README wrong directory name for venv (GH-8650) https://github.com/python/cpython/commit/fe8f90aa3ca3f277cac634cdb96b829039225c6b -- nosy:

[issue34270] Add names to asyncio tasks

2018-08-09 Thread Alex Grönholm
Alex Grönholm added the comment: > On the other had, the matter is made moot by using PyUnicode_CheckExact() Then, in order to keep the pure Python implementation in sync, we'd have to change it to something like this: if name is None: self._name = f'Task-{_task_name_counter()}' elif

[issue34270] Add names to asyncio tasks

2018-08-09 Thread Alex Grönholm
Alex Grönholm added the comment: I also couldn't figure out yet why PyUnicode_Check() was necessary in the first place. Doesn't PyObject_Str() just increment the refcount if the argument is already a string? Eric, please explain why these changes should be done. --

[issue34270] Add names to asyncio tasks

2018-08-09 Thread Alex Grönholm
Alex Grönholm added the comment: Ok, I understand. But is the conversion a bad thing then? -- ___ Python tracker ___ ___

[issue34324] Doc README wrong directory name for venv

2018-08-09 Thread Mariatta Wijaya
Mariatta Wijaya added the comment: New changeset 599bfa18f8ebcb23af300b6855934048c3c64e7d by Mariatta (Stéphane Wirtel) in branch 'master': bpo-34324: Doc README wrong directory name for venv (GH-8650) https://github.com/python/cpython/commit/599bfa18f8ebcb23af300b6855934048c3c64e7d

[issue34362] User-created types with wrong __new__ can be instantiated

2018-08-09 Thread Eric Snow
Eric Snow added the comment: I'm not sure that this is a duplicate of #5322. That one's about a warning when arguments are passed to object.__new__(). Yours is about using an incompatible __new__ when creating a new class in Python. I agree that behavior you're seeing is unexpected and

[issue34367] AsyncResult.get() only notifies one thread

2018-08-09 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +xtreak ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34270] Add names to asyncio tasks

2018-08-09 Thread Alex Grönholm
Alex Grönholm added the comment: > It's not a bad thing, it's just that we don't do it in C Task and we do it in > pure Python Task. Eric wants us to synchronize them so that in a very > unlikely scenario where someone uses subclasses of str for names they will > have exact same behaviour

[issue34270] Add names to asyncio tasks

2018-08-09 Thread Eric Snow
Eric Snow added the comment: I'm not too invested in any changes happening at this point, actually. :) Mostly I happened to be reading through the commit and noticed the inconsistency. If I had reviewed the PR then I would have asked that it be fixed. So I figured I'd mention it. FWIW,

[issue34270] Add names to asyncio tasks

2018-08-09 Thread Yury Selivanov
Yury Selivanov added the comment: > 2. change the check to PyUnicode_CheckExact() I'd be OK with this, but why is this important? -- ___ Python tracker ___

[issue34324] Doc README wrong directory name for venv

2018-08-09 Thread Mariatta Wijaya
Mariatta Wijaya added the comment: Thanks! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.6, Python 3.7 ___ Python tracker

[issue34270] Add names to asyncio tasks

2018-08-09 Thread Yury Selivanov
Yury Selivanov added the comment: Let's just reuse this issue, it's just a small fix. -- resolution: fixed -> ___ Python tracker ___

[issue34367] AsyncResult.get() only notifies one thread

2018-08-09 Thread Alexander Tsvetkov
New submission from Alexander Tsvetkov : If more than one thread is waiting for the multiprocessing.pool.AsyncResult (aka ApplyResult) returned from apply_async, only one thread will be notified once the result arrives. It happens because AsyncResult._set calls notify upon the result

[issue34270] Add names to asyncio tasks

2018-08-09 Thread Eric Snow
Eric Snow added the comment: FWIW, the C implementation of Task.__init__ is not exactly equivalent to the Python implementation (nor to both the C and Python implementation of Task.set_name). In the C impl of Task.__init__ the provided name is used as-is if it's an instance of str:

[issue34270] Add names to asyncio tasks

2018-08-09 Thread Alex Grönholm
Alex Grönholm added the comment: Which way do we want to change this? Do we want to convert to pure strings or retain the original object? In the latter case both the C and Python implementations (including set_name()) have to be changed. -- ___

[issue5322] object.__new__ argument calling autodetection faulty

2018-08-09 Thread ppperry
Change by ppperry : -- nosy: +ppperry ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34270] Add names to asyncio tasks

2018-08-09 Thread Alex Grönholm
Change by Alex Grönholm : -- pull_requests: +8202 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34270] Add names to asyncio tasks

2018-08-09 Thread Alex Grönholm
Alex Grönholm added the comment: > I'll do that if you say so, but I'm just saying that the C and Python implementations will still remain different in semantics then. Never mind, that was a brain fart. I keep ignoring the "!" in my mind. -- ___

[issue34270] Add names to asyncio tasks

2018-08-09 Thread Yury Selivanov
Yury Selivanov added the comment: > I'll do that if you say so, but I'm just saying that the C and Python > implementations will still remain different in semantics then. Probably I'm missing something here. How would they be different? -- ___

[issue32102] Add "capture_output=True" option to subprocess.run

2018-08-09 Thread Andriy Maletsky
Change by Andriy Maletsky : -- pull_requests: +8204 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34270] Add names to asyncio tasks

2018-08-09 Thread Yury Selivanov
Yury Selivanov added the comment: Please just change PyUnicode_Check to PyUnicode_CheckExact in C Task.__init__ and use the same if check in C Task.set_name. -- ___ Python tracker

[issue34362] User-created types with wrong __new__ can be instantiated

2018-08-09 Thread ppperry
ppperry added the comment: issue5322, despite its confusing title, mentions this exact bug in one of the comments below. It looks like there is one bug in the logic for assigning `__new__`, which causes `__new__` and `tp_new` to point to different things, confusing the error-handling

[issue34270] Add names to asyncio tasks

2018-08-09 Thread Alex Grönholm
Alex Grönholm added the comment: > Please just change PyUnicode_Check to PyUnicode_CheckExact in C Task.__init__ > and use the same if check in C Task.set_name. I'll do that if you say so, but I'm just saying that the C and Python implementations will still remain different in semantics

[issue34368] ftplib __init__ function can't handle 120 or 4xy reply when connect to the server

2018-08-09 Thread H-ZeX
Change by H-ZeX : -- components: +Library (Lib) -XML ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34353] stat's python implementation of filemode (fallback) doesn't behave like the C implementation

2018-08-09 Thread Benjamin Peterson
Benjamin Peterson added the comment: New changeset b92c526ed5da474694f89e29d82565f2a654c29b by Benjamin Peterson (GPery) in branch 'master': closes bpo-34353: Add sockets to stat.filemode fallback python implementation. (GH-8703)

[issue34363] dataclasses.asdict() mishandles dataclass instance attributes that are instances of subclassed typing.NamedTuple

2018-08-09 Thread Neil Girdhar
Neil Girdhar added the comment: Sorry if I'm intruding here, but I really dislike that we are doing isinstance versus list, tuple, and dict. And I dislike even more type(x) in (list, tuple). I think the ideal thing to do would have been to check versus abstract base classes like

[issue34368] ftplib __init__ function can't handle 120 or 4xy reply when connect to the server

2018-08-09 Thread H-ZeX
New submission from H-ZeX : in the __init__ function, call getresp, however, the getresp don't handle the 120 reply which indicate the request should be delay or 421 reply in the rfc 959 page 50, there are all reply that may return Connection Establishment 120 220 220 421 --

[issue32745] ctypes string pointer fields should accept embedded null characters

2018-08-09 Thread Zackery Spytz
Change by Zackery Spytz : -- keywords: +patch pull_requests: +8206 stage: test needed -> patch review ___ Python tracker ___ ___

[issue32745] ctypes string pointer fields should accept embedded null characters

2018-08-09 Thread Zackery Spytz
Change by Zackery Spytz : -- nosy: +ZackerySpytz ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34047] IDLE: on macOS, scroll slider 'sticks' at bottom of file

2018-08-09 Thread Terry J. Reedy
Terry J. Reedy added the comment: Vlad, can you test the current patch on PR 8678 on Mac? -- ___ Python tracker ___ ___

[issue34363] dataclasses.asdict() mishandles dataclass instance attributes that are instances of subclassed typing.NamedTuple

2018-08-09 Thread Eric V. Smith
Eric V. Smith added the comment: Maybe do both, then. Also, it's probably better for performance reasons (I know: premature optimization and all that ...): @@ -1018,8 +1018,10 @@ def _asdict_inner(obj, dict_factory): value = _asdict_inner(getattr(obj, f.name), dict_factory)

[issue34368] ftplib __init__ function can't handle 120 or 4xy reply when connect to the server

2018-08-09 Thread H-ZeX
Change by H-ZeX : -- components: XML nosy: H-ZeX priority: normal severity: normal status: open title: ftplib __init__ function can't handle 120 or 4xy reply when connect to the server type: behavior versions: Python 3.5 ___ Python tracker

[issue32102] Add "capture_output=True" option to subprocess.run

2018-08-09 Thread miss-islington
Change by miss-islington : -- pull_requests: +8205 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34270] Add names to asyncio tasks

2018-08-09 Thread Yury Selivanov
Change by Yury Selivanov : -- resolution: -> fixed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34047] IDLE: on macOS, scroll slider 'sticks' at bottom of file

2018-08-09 Thread Vlad Tudorache
Vlad Tudorache added the comment: I've tried to check the source code of IDLE in search of chained comparisons without parenthesis (like the example I showed and the bug with the mouse wheel). I couldn't find something important. Then I wrote in a file the following code: import tkinter

[issue34047] IDLE: on macOS, scroll slider 'sticks' at bottom of file

2018-08-09 Thread Vlad Tudorache
Vlad Tudorache added the comment: Edit: The code is: import tkinter root = tkinter.Tk() text = tkinter.Text(root) vbar = tkinter.Scrollbar(root) vbar.pack(side=tkinter.RIGHT, fill=tkinter.Y) text.pack(side=tkinter.LEFT, fill=tkinter.BOTH, expand=1) text.config(yscrollcommand=vbar.set)

[issue34047] IDLE: on macOS, scroll slider 'sticks' at bottom of file

2018-08-09 Thread Vlad Tudorache
Vlad Tudorache added the comment: And the result (video) of my script is attached to this post. -- Added file: https://bugs.python.org/file47738/tkinter_scroll_issues.mov ___ Python tracker