[issue24165] Free list for single-digits ints

2020-10-24 Thread Inada Naoki
Inada Naoki added the comment: I close this issue for now. Please reopen or create a new issue if you came up with better idea. -- resolution: -> rejected stage: patch review -> resolved status: open -> closed versions: +Python 3.10 -Python 3.7

[issue41835] Speed up dict vectorcall creation using keywords

2020-10-24 Thread Inada Naoki
Inada Naoki added the comment: @Marco Sulla > @methane: well, to be honest, I don't see much difference between the two > pulls. The major difference is that you merged insertdict_init in > dict_merge_init. Not only it but also some simplification which make 10% faster than GH-22346. >

[issue42140] asyncio.wait function creates futures set two times

2020-10-24 Thread Denis S. Otkidach
Change by Denis S. Otkidach : -- nosy: +ods ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue42140] asyncio.wait function creates futures set two times

2020-10-24 Thread Diogo Dutra
New submission from Diogo Dutra : The python3.9 code creates the futures set two times. We can create this set before, avoiding the second creation. This python3.9 behaviour breaks the aiokafka library, because it gives an iterator to that function, so the second iteration become empty.

[issue41835] Speed up dict vectorcall creation using keywords

2020-10-24 Thread Inada Naoki
Inada Naoki added the comment: @Mark.Shannon I had seen some speedup on tornado benchmark when I didn't use PGO+LTO. but it was noise. Now I use PGO+LTO. master vs PR-22909: $ ./python -m pyperf compare_to master-opt.json speedup_kw-opt.json -G --min-speed=1 Slower (11): - spectral_norm:

[issue42130] AsyncIO's wait_for can hide cancellation in a rare race condition

2020-10-24 Thread Chris Jerdonek
Change by Chris Jerdonek : -- nosy: +chris.jerdonek ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35823] Use vfork() in subprocess on Linux

2020-10-24 Thread Ronald Oussoren
Ronald Oussoren added the comment: > From what I can tell, vfork probably also works on macOS (darwin). > > Lets let this run for a bit on Linux and it can be a separate issue to > open vfork usage up to other platforms. I'd prefer to not use vfork on macOS. For one I don't particularly

[issue24165] Free list for single-digits ints

2020-10-24 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I agree that it is not worth to add this optimization. -- ___ Python tracker ___ ___

[issue41835] Speed up dict vectorcall creation using keywords

2020-10-24 Thread Inada Naoki
Inada Naoki added the comment: I confirmed _PyDict_FromItems() can be used to optimize _PyStack_AsDict() too. See https://github.com/methane/cpython/pull/25 But I can not confirm significant performance gain from it too. -- ___ Python tracker

[issue42096] zipfile.is_zipfile incorrectly identifying a gzipped file as a zip archive

2020-10-24 Thread Irit Katriel
Change by Irit Katriel : -- nosy: +gregory.p.smith, vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue41835] Speed up dict vectorcall creation using keywords

2020-10-24 Thread Marco Sulla
Marco Sulla added the comment: I commented out sqlalchemy in the requirements.txt in the pyperformance source code, and it worked. I had also to skip tornado: pyperformance run -r -b,-sqlalchemy_declarative,-sqlalchemy_imperative,-tornado_http -o ../perf_master.json This is my result:

[issue42141] Speedup various dict inits

2020-10-24 Thread Marco Sulla
New submission from Marco Sulla : The PR #22948 is an augmented version of #22346. It speeds up also the creation of: 1. dicts from other dicts that are not "perfect" (combined and without holes) 2. fromkeys 3. copies of dicts with many holes 4. dict from keywords, as in #22346 A sample

[issue42130] AsyncIO's wait_for can hide cancellation in a rare race condition

2020-10-24 Thread Chris Jerdonek
Chris Jerdonek added the comment: It looks like issue 37658 might be the relevant change rather. Here is the new logic it introduced: https://github.com/python/cpython/blob/db455296be5f792b8c12b7cd7f3962b52e4f44ee/Lib/asyncio/tasks.py#L483-L488 (via

[issue42143] Corruptions in func_dealloc() with partially-created function object

2020-10-24 Thread Yonatan Goldschmidt
Change by Yonatan Goldschmidt : -- keywords: +patch pull_requests: +21871 stage: -> patch review pull_request: https://github.com/python/cpython/pull/22953 ___ Python tracker

[issue29981] Update Index for set, dict, and generator 'comprehensions'

2020-10-24 Thread Inada Naoki
Change by Inada Naoki : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: -Python 3.7 ___ Python tracker ___

[issue33987] IDLE: use ttk.Frame for ttk widgets

2020-10-24 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset e53e54425d9b7b9b7b082817da104d60bb25e3a2 by Mark Roseman in branch 'master': bpo-33987: Use ttk Label on IDLE statusbar (GH-22941) https://github.com/python/cpython/commit/e53e54425d9b7b9b7b082817da104d60bb25e3a2 --

[issue33987] IDLE: use ttk.Frame for ttk widgets

2020-10-24 Thread miss-islington
Change by miss-islington : -- pull_requests: +21868 pull_request: https://github.com/python/cpython/pull/22950 ___ Python tracker ___

[issue33987] IDLE: use ttk.Frame for ttk widgets

2020-10-24 Thread miss-islington
Change by miss-islington : -- pull_requests: +21867 pull_request: https://github.com/python/cpython/pull/22949 ___ Python tracker ___

[issue33987] IDLE: use ttk.Frame for ttk widgets

2020-10-24 Thread miss-islington
miss-islington added the comment: New changeset 253c8eb40ec5a87aa539f913fcd83d1759069981 by Miss Skeleton (bot) in branch '3.8': bpo-33987: Use master ttk Frame for IDLE config dialog (GH-22943) https://github.com/python/cpython/commit/253c8eb40ec5a87aa539f913fcd83d1759069981 --

[issue42127] functools.cached_property possibly disables key-sharing instance dictionaries

2020-10-24 Thread Raymond Hettinger
Change by Raymond Hettinger : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.9 ___ Python tracker ___

[issue42127] functools.cached_property possibly disables key-sharing instance dictionaries

2020-10-24 Thread miss-islington
Change by miss-islington : -- nosy: +miss-islington nosy_count: 3.0 -> 4.0 pull_requests: +21873 pull_request: https://github.com/python/cpython/pull/22955 ___ Python tracker

[issue42127] functools.cached_property possibly disables key-sharing instance dictionaries

2020-10-24 Thread Raymond Hettinger
Raymond Hettinger added the comment: New changeset 48be6b1ef7a6201e13c87a317361cdb60bd5faa8 by Raymond Hettinger in branch 'master': bpo-42127: Document effect of cached_property on key-sharing dictionaries (GH-22930)

[issue29981] Update Index for set, dict, and generator 'comprehensions'

2020-10-24 Thread miss-islington
miss-islington added the comment: New changeset 229eaf20694006c03af0f4740abdf8ae5579 by Miss Skeleton (bot) in branch '3.9': bpo-29981: Add examples and update index for set, dict, and generator comprehensions'(GH-20272)

[issue29981] Update Index for set, dict, and generator 'comprehensions'

2020-10-24 Thread miss-islington
miss-islington added the comment: New changeset 60bef61f717dde915058b03159b2c2e97d765858 by Miss Skeleton (bot) in branch '3.8': bpo-29981: Add examples and update index for set, dict, and generator comprehensions'(GH-20272)

[issue33987] IDLE: use ttk.Frame for ttk widgets

2020-10-24 Thread miss-islington
miss-islington added the comment: New changeset 8485d3b911c3cb73ed6217a47c7720f9277efc01 by Miss Skeleton (bot) in branch '3.8': bpo-33987: Add master ttk Frame to IDLE search dialogs (GH-22942) https://github.com/python/cpython/commit/8485d3b911c3cb73ed6217a47c7720f9277efc01 --

[issue42144] A missing "goto" in the _ssl module!

2020-10-24 Thread Zackery Spytz
Change by Zackery Spytz : -- keywords: +patch pull_requests: +21876 stage: -> patch review pull_request: https://github.com/python/cpython/pull/22959 ___ Python tracker ___

[issue42144] A missing "goto" in the _ssl module!

2020-10-24 Thread Zackery Spytz
New submission from Zackery Spytz : In the _ssl_configure_hostname() function, there's a missing "goto error;" if SSL_set_tlsext_host_name() fails. -- assignee: christian.heimes components: Extension Modules, SSL messages: 379562 nosy: ZackerySpytz, christian.heimes priority: normal

[issue42145] test_io is leaking references

2020-10-24 Thread Pablo Galindo Salgado
New submission from Pablo Galindo Salgado : ❯ ./python -m test test_io -m test.test_io.CTextIOWrapperTest.test_read_one_by_one -R : 0:00:00 load avg: 1.59 Run tests sequentially 0:00:00 load avg: 1.59 [1/1] test_io beginning 9 repetitions 123456789 . test_io leaked [3, 3, 3, 3]

[issue37658] In some cases asyncio.wait_for can lead to socket leak.

2020-10-24 Thread Chris Jerdonek
Chris Jerdonek added the comment: Issue #42130 that was recently filed appears related to this change. -- nosy: +chris.jerdonek ___ Python tracker ___

[issue33962] IDLE: use ttk.spinbox with configdialog

2020-10-24 Thread Mark Roseman
Change by Mark Roseman : -- keywords: +patch pull_requests: +21872 stage: test needed -> patch review pull_request: https://github.com/python/cpython/pull/22954 ___ Python tracker

[issue33987] IDLE: use ttk.Frame for ttk widgets

2020-10-24 Thread miss-islington
Change by miss-islington : -- pull_requests: +21874 pull_request: https://github.com/python/cpython/pull/22956 ___ Python tracker ___

[issue33987] IDLE: use ttk.Frame for ttk widgets

2020-10-24 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset 5df6c99cb450fe2f30be681dbf68cd1d34d3bbe4 by Mark Roseman in branch 'master': bpo-33987: Add master ttk Frame to IDLE search dialogs (GH-22942) https://github.com/python/cpython/commit/5df6c99cb450fe2f30be681dbf68cd1d34d3bbe4 --

[issue33987] IDLE: use ttk.Frame for ttk widgets

2020-10-24 Thread miss-islington
Change by miss-islington : -- pull_requests: +21875 pull_request: https://github.com/python/cpython/pull/22957 ___ Python tracker ___

[issue14556] telnetlib Telnet.expect fails with timeout=0

2020-10-24 Thread Zackery Spytz
Zackery Spytz added the comment: Python 2.7 is no longer supported, so I think this issue should be closed. -- nosy: +ZackerySpytz ___ Python tracker ___

[issue42143] Corruptions in func_dealloc() with partially-created function object

2020-10-24 Thread Yonatan Goldschmidt
New submission from Yonatan Goldschmidt : While reading funcobject.c, I noticed that PyFunction_NewWithQualName() may exit early if it fails retrieving __name__ from the globals dict. It will destroy the partially-created PyFunction object. However, this is done before ever initializing

[issue33987] IDLE: use ttk.Frame for ttk widgets

2020-10-24 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset c579ad14d3b5bb9a45d7b9cc708eaf0bf4884c50 by Mark Roseman in branch 'master': bpo-33987: Use master ttk Frame for IDLE config dialog (GH-22943) https://github.com/python/cpython/commit/c579ad14d3b5bb9a45d7b9cc708eaf0bf4884c50 --

[issue33987] IDLE: use ttk.Frame for ttk widgets

2020-10-24 Thread miss-islington
Change by miss-islington : -- pull_requests: +21870 pull_request: https://github.com/python/cpython/pull/22952 ___ Python tracker ___

[issue33987] IDLE: use ttk.Frame for ttk widgets

2020-10-24 Thread Terry J. Reedy
Terry J. Reedy added the comment: Thanks for hopefully finishing this issue. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue33987] IDLE: use ttk.Frame for ttk widgets

2020-10-24 Thread miss-islington
Change by miss-islington : -- pull_requests: +21869 pull_request: https://github.com/python/cpython/pull/22951 ___ Python tracker ___

[issue33987] IDLE: use ttk.Frame for ttk widgets

2020-10-24 Thread miss-islington
miss-islington added the comment: New changeset 4efd2defb899c5c45334814234c842f8f513879e by Miss Skeleton (bot) in branch '3.9': bpo-33987: Use ttk Label on IDLE statusbar (GH-22941) https://github.com/python/cpython/commit/4efd2defb899c5c45334814234c842f8f513879e --

[issue33987] IDLE: use ttk.Frame for ttk widgets

2020-10-24 Thread miss-islington
miss-islington added the comment: New changeset c1b620eecc2ca0f9ae9d5ee2d973e823db295ad2 by Miss Skeleton (bot) in branch '3.8': bpo-33987: Use ttk Label on IDLE statusbar (GH-22941) https://github.com/python/cpython/commit/c1b620eecc2ca0f9ae9d5ee2d973e823db295ad2 --

[issue42141] Speedup various dict inits

2020-10-24 Thread Inada Naoki
Inada Naoki added the comment: > 1. dicts from other dicts that are not "perfect" (combined and without holes) > 3. copies of dicts with many holes Note that I have optimized and rejected it by myself already. See https://github.com/python/cpython/pull/21669 and

[issue42142] FAIL tkinter ttk LabeledScale test_resize, and more

2020-10-24 Thread Terry J. Reedy
Terry J. Reedy added the comment: Azure Pipelines Ubuntu, as before, but Combobox test_virtual_event. test_virtual_event (tkinter.test.test_ttk.test_widgets.ComboboxTest) ... Timeout (0:20:00)! Thread 0x7fb09e3f3080 (most recent call first): File

[issue42142] FAIL tkinter ttk LabeledScale test_resize

2020-10-24 Thread Terry J. Reedy
New submission from Terry J. Reedy : This appears to have timed out as there was no other error indication. Azure Pipelines, retested gave 2nd failure. Passed on another PR. test_resize (tkinter.test.test_ttk.test_extensions.LabeledScaleTest) ... Timeout (0:20:00)! Thread 0x7f787182e080

[issue42127] functools.cached_property possibly disables key-sharing instance dictionaries

2020-10-24 Thread Raymond Hettinger
Raymond Hettinger added the comment: New changeset 427cb0aa78813b89a3f100073bf7d70a53510f57 by Miss Skeleton (bot) in branch '3.9': bpo-42127: Document effect of cached_property on key-sharing dictionaries (GH-22930) (GH-22955)

[issue33987] IDLE: use ttk.Frame for ttk widgets

2020-10-24 Thread miss-islington
miss-islington added the comment: New changeset 9cf26b00e42787bc668c62f1b5dde814f8307259 by Miss Skeleton (bot) in branch '3.9': bpo-33987: Add master ttk Frame to IDLE search dialogs (GH-22942) https://github.com/python/cpython/commit/9cf26b00e42787bc668c62f1b5dde814f8307259 --

[issue37203] Correct classmethod emulation in Descriptor HowTo Guide

2020-10-24 Thread Géry
Change by Géry : -- versions: +Python 3.9 -Python 3.7 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue37203] Correct classmethod emulation in Descriptor HowTo Guide

2020-10-24 Thread Géry
Change by Géry : -- resolution: not a bug -> fixed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue37203] Correct classmethod emulation in Descriptor HowTo Guide

2020-10-24 Thread Géry
Change by Géry : -- pull_requests: +21866 pull_request: https://github.com/python/cpython/pull/22934 ___ Python tracker ___ ___

[issue33987] IDLE: use ttk.Frame for ttk widgets

2020-10-24 Thread miss-islington
miss-islington added the comment: New changeset 2d493893c7aa9af633c4ebeb56ecce42e3a82e9f by Miss Skeleton (bot) in branch '3.9': bpo-33987: Use master ttk Frame for IDLE config dialog (GH-22943) https://github.com/python/cpython/commit/2d493893c7aa9af633c4ebeb56ecce42e3a82e9f --

[issue33962] IDLE: use ttk.spinbox with configdialog

2020-10-24 Thread Terry J. Reedy
Terry J. Reedy added the comment: #27755 was about replacing uses of our custom DynOptionMenu with ttk.Combobox, which I believe we can do now, wherever we don't replace it with something else. One use is for font size choice; Spinbox was suggested as an alternative replacement. Spinbox

[issue33987] IDLE: use ttk.Frame for ttk widgets

2020-10-24 Thread Mark Roseman
Change by Mark Roseman : -- pull_requests: +21859 pull_request: https://github.com/python/cpython/pull/22941 ___ Python tracker ___

[issue33987] IDLE: use ttk.Frame for ttk widgets

2020-10-24 Thread Mark Roseman
Change by Mark Roseman : -- pull_requests: +21860 pull_request: https://github.com/python/cpython/pull/22942 ___ Python tracker ___

[issue33987] IDLE: use ttk.Frame for ttk widgets

2020-10-24 Thread Mark Roseman
Change by Mark Roseman : -- pull_requests: +21861 pull_request: https://github.com/python/cpython/pull/22943 ___ Python tracker ___

[issue42132] Use specs instead of just __loader__ in C code

2020-10-24 Thread Dong-hee Na
Change by Dong-hee Na : -- nosy: +corona10 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35823] Use vfork() in subprocess on Linux

2020-10-24 Thread Gregory P. Smith
Gregory P. Smith added the comment: Nice links. LOL, yes, musl source was going to be my next stop if the larger libc sources proved impossible for a mere mortal to reason about. :) regarding macOS, agreed. If someone needs vfork() to work there, I believe it could be made to. Options

[issue17942] IDLE Debugger: Improve GUI

2020-10-24 Thread Mark Roseman
Change by Mark Roseman : -- pull_requests: +21864 pull_request: https://github.com/python/cpython/pull/22947 ___ Python tracker ___

[issue17942] IDLE Debugger: Improve GUI

2020-10-24 Thread Mark Roseman
Change by Mark Roseman : -- versions: +Python 3.10, Python 3.8, Python 3.9 -Python 3.6, Python 3.7 ___ Python tracker ___ ___

[issue17942] IDLE Debugger: Improve GUI

2020-10-24 Thread Mark Roseman
Mark Roseman added the comment: have updated/cleaned up the previous patch, and there's a new PR. i realize this is unfortunately a somewhat monolithic change which might make reviewing it a bit tough... -- ___ Python tracker

[issue35823] Use vfork() in subprocess on Linux

2020-10-24 Thread Alexey Izbyshev
Change by Alexey Izbyshev : -- pull_requests: +21862 pull_request: https://github.com/python/cpython/pull/22944 ___ Python tracker ___

[issue35823] Use vfork() in subprocess on Linux

2020-10-24 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset 473db47747bb8bc986d88ad81799bcbd88153ac5 by Alexey Izbyshev in branch 'master': bpo-35823: subprocess: Fix handling of pthread_sigmask() errors (GH-22944) https://github.com/python/cpython/commit/473db47747bb8bc986d88ad81799bcbd88153ac5

[issue35823] Use vfork() in subprocess on Linux

2020-10-24 Thread Gregory P. Smith
Gregory P. Smith added the comment: regarding excluding the setsid() case: I was being conservative as I couldn't find a reference of what was and wasn't allowed after vfork. I found one thing suggesting that on macOS setsid() was not safe after vfork(). But that appeared to be a

[issue31484] Cache single-character strings outside of the Latin1 range

2020-10-24 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- resolution: -> rejected stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue35823] Use vfork() in subprocess on Linux

2020-10-24 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset be3c3a0e468237430ad7d19a33c60d306199a7f2 by Gregory P. Smith in branch 'master': bpo-35823: Allow setsid() after vfork() on Linux. (GH-22945) https://github.com/python/cpython/commit/be3c3a0e468237430ad7d19a33c60d306199a7f2 --

[issue35823] Use vfork() in subprocess on Linux

2020-10-24 Thread Alexey Izbyshev
Alexey Izbyshev added the comment: > regarding excluding the setsid() case: I was being conservative as I couldn't > find a reference of what was and wasn't allowed after vfork. Yes, there is no list of functions allowed after vfork(), except for the conservative POSIX.1 list consisting

[issue35823] Use vfork() in subprocess on Linux

2020-10-24 Thread Alexey Izbyshev
Alexey Izbyshev added the comment: > Thank you for taking this on! I'm calling it fixed for now as the buildbots > are looking happy with it. If issues with it arise we can address them. Thank you for reviewing and merging! Using POSIX_CALL for pthread_sigmask() is incorrect, however,

[issue41052] Opt out serialization/deserialization for heap type

2020-10-24 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 8cd1dbae32d9303caac3a473d3332f17bc98c921 by Serhiy Storchaka in branch 'master': bpo-41052: Fix pickling heap types implemented in C with protocols 0 and 1 (GH-22870)

[issue40001] ignore errors in SimpleCookie

2020-10-24 Thread Aviram
Aviram added the comment: Hi all, still waiting for review. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue35823] Use vfork() in subprocess on Linux

2020-10-24 Thread Gregory P. Smith
Change by Gregory P. Smith : -- pull_requests: +21863 pull_request: https://github.com/python/cpython/pull/22945 ___ Python tracker ___

[issue42096] zipfile.is_zipfile incorrectly identifying a gzipped file as a zip archive

2020-10-24 Thread Gregory P. Smith
Gregory P. Smith added the comment: for what it's worth: false positives are always going to be possible in any such "magic" check as is_zipfile is. we don't check the start of the file because zip files are defined by their end of file central directory which contains length information to

[issue35823] Use vfork() in subprocess on Linux

2020-10-24 Thread Alexey Izbyshev
Alexey Izbyshev added the comment: @ronaldoussoren > I'd prefer to not use vfork on macOS. For one I don't particularly trust that > vfork would work reliably when using higher level APIs, but more importantly > posix_spawn on macOS has some options that are hard to achieve otherwise and >