[issue44562] types.GenericAlias should decref instead of using delete in tp_new

2021-07-04 Thread miss-islington
Change by miss-islington : -- nosy: +miss-islington nosy_count: 2.0 -> 3.0 pull_requests: +25577 pull_request: https://github.com/python/cpython/pull/27018 ___ Python tracker

[issue44562] types.GenericAlias should decref instead of using delete in tp_new

2021-07-04 Thread miss-islington
Change by miss-islington : -- pull_requests: +25578 pull_request: https://github.com/python/cpython/pull/27019 ___ Python tracker ___

[issue44562] types.GenericAlias should decref instead of using delete in tp_new

2021-07-04 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > And is is correct to call deallocator for not initialized GenericAlias object? The correct thing to do is to call Py_DECREF so the object is properly unlinked and the other potential cleanups work. Calling the deallocator directly is almost always

[issue44563] Failed tee.fromiterable() corrupts the linked list of all GC objects in debug build

2021-07-04 Thread Serhiy Storchaka
New submission from Serhiy Storchaka : In tee.fromiterable() the non-initialized tee object can be deleted by without calling _Py_ForgetReference() in debug build. See also issue44553 and issue44562. The proposed PR rewrites the code so that it no longer need to delete not completely

[issue43950] Include column offsets for bytecode instructions

2021-07-04 Thread miss-islington
miss-islington added the comment: New changeset 693cec0e2dcafa393ed5cdaa606f8dc8e3876adf by Batuhan Taskaya in branch 'main': bpo-43950: include position in dis.Instruction (GH-27015) https://github.com/python/cpython/commit/693cec0e2dcafa393ed5cdaa606f8dc8e3876adf --

[issue43950] Include column offsets for bytecode instructions

2021-07-04 Thread Ammar Askar
Change by Ammar Askar : -- pull_requests: +25582, 25583, 25584 pull_request: https://github.com/python/cpython/pull/27023 ___ Python tracker ___

[issue43950] Include column offsets for bytecode instructions

2021-07-04 Thread Ammar Askar
Change by Ammar Askar : -- pull_requests: +25582, 25583 pull_request: https://github.com/python/cpython/pull/27023 ___ Python tracker ___

[issue43950] Include column offsets for bytecode instructions

2021-07-04 Thread Ammar Askar
Change by Ammar Askar : -- pull_requests: +25582 pull_request: https://github.com/python/cpython/pull/27023 ___ Python tracker ___

[issue44561] Some expired hyperlinks in Python documentation

2021-07-04 Thread Irit Katriel
Irit Katriel added the comment: Thanks, do you mind creating a github PR to fix this? -- nosy: +iritkatriel ___ Python tracker ___

[issue44562] types.GenericAlias should decref instead of using delete in tp_new

2021-07-04 Thread Ken Jin
New submission from Ken Jin : Ref: comment chain at https://github.com/python/cpython/pull/27008#discussion_r663450441. setup_ga fails only if PyTuple_Pack fails, which usually happens when Python is out of memory. The cleanup code for setup_ga shouldn't use PyObject_GC_DEL as mentioned in

[issue41249] TypedDict inheritance doesn't work with get_type_hints and postponed evaluation of annotations across modules

2021-07-04 Thread Germán Méndez Bravo
Change by Germán Méndez Bravo : -- keywords: +patch pull_requests: +25576 stage: -> patch review pull_request: https://github.com/python/cpython/pull/27017 ___ Python tracker

[issue41249] TypedDict inheritance doesn't work with get_type_hints and postponed evaluation of annotations across modules

2021-07-04 Thread Germán Méndez Bravo
Germán Méndez Bravo added the comment: I added a pull request with my fix here: https://github.com/python/cpython/pull/27017 -- ___ Python tracker ___

[issue44562] types.GenericAlias should decref instead of using delete in tp_new

2021-07-04 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: There is the same bug in ga_new(): tp_free is called directly. And is is correct to call deallocator for not initialized GenericAlias object? -- nosy: +serhiy.storchaka ___ Python tracker

[issue44562] types.GenericAlias should decref instead of using delete in tp_new

2021-07-04 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: But is alias->origin initialized to safely call Py_XDECREF(alias->origin)? -- ___ Python tracker ___

[issue36521] Consider removing docstrings from co_consts in code objects

2021-07-04 Thread Irit Katriel
Change by Irit Katriel : -- nosy: +gvanrossum, iritkatriel ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36521] Consider removing docstrings from co_consts in code objects

2021-07-04 Thread Guido van Rossum
Guido van Rossum added the comment: In 3.11 the code object will definitely change. We may well put the docstring in a dedicated attribute. -- nosy: +Guido.van.Rossum versions: +Python 3.11 -Python 3.8 ___ Python tracker

[issue44563] Failed tee.fromiterable() corrupts the linked list of all GC objects in debug build

2021-07-04 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +25579 stage: -> patch review pull_request: https://github.com/python/cpython/pull/27020 ___ Python tracker

[issue43950] Include column offsets for bytecode instructions

2021-07-04 Thread Batuhan Taskaya
Change by Batuhan Taskaya : -- pull_requests: +25574 pull_request: https://github.com/python/cpython/pull/27015 ___ Python tracker ___

[issue44562] types.GenericAlias should decref instead of using delete in tp_new

2021-07-04 Thread Ken Jin
Change by Ken Jin : -- keywords: +patch pull_requests: +25575 stage: -> patch review pull_request: https://github.com/python/cpython/pull/27016 ___ Python tracker ___

[issue43950] Include column offsets for bytecode instructions

2021-07-04 Thread miss-islington
miss-islington added the comment: New changeset 44f91fc802a2b71312e9abd9e8e9dcbf02e8216d by Batuhan Taskaya in branch 'main': bpo-43950: use 0-indexed column offsets for bytecode positions (GH-27011) https://github.com/python/cpython/commit/44f91fc802a2b71312e9abd9e8e9dcbf02e8216d

[issue44562] types.GenericAlias should decref instead of using delete in tp_new

2021-07-04 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > AFAIK PyType_GenericAlloc is used indirectly in ga_new(), but not in > Py_GenericAlias(). Oh, I see what you mean, that's a good point. -- ___ Python tracker

[issue13788] os.closerange optimization

2021-07-04 Thread Gregory P. Smith
Gregory P. Smith added the comment: Code needed in a modern patch: 1) Use the system call if compile time configure detected it may be available. (if we just use syscall() rather than a libc wrapper, a configure check may not be necessary, but various #ifdefs likely are) 2) If (1) produces

[issue41486] Add _BlocksOutputBuffer for bz2/lzma/zlib module

2021-07-04 Thread miss-islington
miss-islington added the comment: New changeset 22bcc0768e0f7eda2ae4de63aef113b1ddb4ddef by Miss Islington (bot) in branch '3.10': bpo-41486: zlib uses an UINT32_MAX sliding window for the output buffer (GH-26143)

[issue44561] Some expired hyperlinks in Python documentation

2021-07-04 Thread Steven Hsu
Change by Steven Hsu : -- keywords: +patch pull_requests: +25586 stage: -> patch review pull_request: https://github.com/python/cpython/pull/27027 ___ Python tracker ___

[issue35277] Upgrade bundled pip/setuptools

2021-07-04 Thread Jacob Walls
Jacob Walls added the comment: Presumably this can be closed. -- nosy: +jacobtylerwalls ___ Python tracker ___ ___

[issue44558] operator.countOf `is` / `==` inconsistency

2021-07-04 Thread Dong-hee Na
Change by Dong-hee Na : -- versions: -Python 3.6, Python 3.7, Python 3.8 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue44562] types.GenericAlias should decref instead of using delete in tp_new

2021-07-04 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset d33943a6c368c2184e238019c63ac7a267da5594 by Ken Jin in branch 'main': bpo-44562: Remove invalid PyObject_GC_Del from error path of types.GenericAlias … (GH-27016)

[issue44562] types.GenericAlias should decref instead of using delete in tp_new

2021-07-04 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 4684a34c8d2a2ffac7b779edb4ba57f043783478 by Miss Islington (bot) in branch '3.9': bpo-44562: Remove invalid PyObject_GC_Del from error path of types.GenericAlias … (GH-27016) (GH-27018)

[issue44562] types.GenericAlias should decref instead of using delete in tp_new

2021-07-04 Thread miss-islington
miss-islington added the comment: New changeset 68330b681a4b63cedad58fcfd1d9573209bad21d by Miss Islington (bot) in branch '3.10': bpo-44562: Remove invalid PyObject_GC_Del from error path of types.GenericAlias … (GH-27016)

[issue36663] pdb: store whole exception information in locals (via user_exception)

2021-07-04 Thread Irit Katriel
Irit Katriel added the comment: As mentioned above, I think this is redundant because the traceback is on exc_value.__traceback__. Closing as there was not reply to my question, but correct me if I misunderstood the issue. -- stage: -> resolved status: open -> closed

[issue44562] types.GenericAlias should decref instead of using delete in tp_new

2021-07-04 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- pull_requests: +25581 pull_request: https://github.com/python/cpython/pull/27022 ___ Python tracker ___

[issue41486] Add _BlocksOutputBuffer for bz2/lzma/zlib module

2021-07-04 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset a9a69bb3ea1e6cf54513717212aaeae0d61b24ee by Ma Lin in branch 'main': bpo-41486: zlib uses an UINT32_MAX sliding window for the output buffer (GH-26143) https://github.com/python/cpython/commit/a9a69bb3ea1e6cf54513717212aaeae0d61b24ee

[issue41486] Add _BlocksOutputBuffer for bz2/lzma/zlib module

2021-07-04 Thread miss-islington
Change by miss-islington : -- nosy: +miss-islington nosy_count: 3.0 -> 4.0 pull_requests: +25585 pull_request: https://github.com/python/cpython/pull/27025 ___ Python tracker

[issue43077] Update bundled pip to 21.0.1 and setuptools to 52.0.0

2021-07-04 Thread Jacob Walls
Jacob Walls added the comment: Presumably this can be closed. -- nosy: +jacobtylerwalls ___ Python tracker ___ ___

[issue43077] Update bundled pip to 21.0.1 and setuptools to 52.0.0

2021-07-04 Thread Paul Moore
Change by Paul Moore : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue44562] types.GenericAlias should decref instead of using delete in tp_new

2021-07-04 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > But is alias->origin initialized to safely call Py_XDECREF(alias->origin)? Why would that be unsafe? PyType_GenericAlloc sets all fields to NULL so that is going to either be NULL or have an object, no? setup_ga only sets alias->origin if there has

[issue44562] types.GenericAlias should decref instead of using delete in tp_new

2021-07-04 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- pull_requests: +25580 pull_request: https://github.com/python/cpython/pull/27021 ___ Python tracker ___

[issue44562] types.GenericAlias should decref instead of using delete in tp_new

2021-07-04 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: AFAIK PyType_GenericAlloc is used indirectly in ga_new(), but not in Py_GenericAlias(). -- ___ Python tracker ___

[issue44562] types.GenericAlias should decref instead of using delete in tp_new

2021-07-04 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset fe847a62852c3baaec6c97a5e2e7b2e66732bdb8 by Pablo Galindo in branch '3.9': Revert "bpo-44562: Remove invalid PyObject_GC_Del from error path of types.GenericAlias … (GH-27016) (GH-27018)" (GH-27022)

[issue43950] Include column offsets for bytecode instructions

2021-07-04 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 5644c7b3ffd49bed58dc095be6e6148e0bb4431e by Ammar Askar in branch 'main': bpo-43950: Print columns in tracebacks (PEP 657) (GH-26958) https://github.com/python/cpython/commit/5644c7b3ffd49bed58dc095be6e6148e0bb4431e --

[issue44549] BZip 1.0.6 Critical Vulnerability

2021-07-04 Thread Ma Lin
Ma Lin added the comment: If you update python/cpython-source-deps, I can submit a simple PR to python/cpython. I want to submit a PR to python/cpython-source-deps, but I think it’s better for a credible person to do this. -- nosy: +malin ___

[issue42889] Incorrect behavior after ast node visits

2021-07-04 Thread Xinmeng Xia
Xinmeng Xia added the comment: This crash cannot be reproduced again on the master branch of CPython. It seems that this bug has been fixed. Should we close this issue and mark it as "fixed"? -- ___ Python tracker

[issue44564] DeprecationWarning in test_enum over formatting

2021-07-04 Thread Karthikeyan Singaravelan
New submission from Karthikeyan Singaravelan : It seems the line above this is wrapped under a block to check for deprecation warning but this line got missed out. PYTHONWARNINGS=always ./python.exe -Wall -m test test_enum 0:00:00 load avg: 3.91 Run tests sequentially 0:00:00 load avg: 3.91

[issue38291] Deprecate the typing.io and typing.re pseudo-modules

2021-07-04 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: This change seems to emit deprecation warnings in test_pydoc. PYTHONWARNINGS=always ./python.exe -Wall -m test test_pydoc 0:00:00 load avg: 2.57 Run tests sequentially 0:00:00 load avg: 2.57 [1/1] test_pydoc

[issue42813] Extra spaces cause unexpected EOF error in "compile" function with mode "single"

2021-07-04 Thread Xinmeng Xia
Xinmeng Xia added the comment: Program like following reports error on CPython(master branch), however this program can work well on PyPy. I think this is a bug in CPython == string =""" if 1: print("hello") """ compile(string, "", "single")

[issue44560] Unrecognized charset "eucgb2312_cn" in email header for many MUA

2021-07-04 Thread Dong-hee Na
Change by Dong-hee Na : -- nosy: +corona10 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue44558] operator.countOf `is` / `==` inconsistency

2021-07-04 Thread Dong-hee Na
Change by Dong-hee Na : -- nosy: +corona10, serhiy.storchaka, vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue44558] operator.countOf `is` / `==` inconsistency

2021-07-04 Thread Dong-hee Na
Change by Dong-hee Na : -- pull_requests: +25572 pull_request: https://github.com/python/cpython/pull/27012 ___ Python tracker ___

[issue44561] Some expired hyperlinks in Python documentation

2021-07-04 Thread Steven Hsu
New submission from Steven Hsu : In https://github.com/python/cpython/blob/main/Doc/distributing/index.rst, there are three expired hyperlinks: .. _Project structure: \ https://packaging.python.org/tutorials/distributing-packages/ .. _Building and packaging the project: \

[issue43453] docs: runtime_checkable example refers to changed behavior in 3.10

2021-07-04 Thread Andrei Kulakov
Change by Andrei Kulakov : -- keywords: +patch nosy: +andrei.avk nosy_count: 2.0 -> 3.0 pull_requests: +25573 stage: -> patch review pull_request: https://github.com/python/cpython/pull/27013 ___ Python tracker

[issue26724] Serialize dict with non-string keys to JSON — unexpected result

2021-07-04 Thread Irit Katriel
Change by Irit Katriel : -- stage: -> resolved status: pending -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue44473] logging.handlers.QueueHandler acts unexpected

2021-07-04 Thread Irit Katriel
Change by Irit Katriel : -- nosy: +vinay.sajip ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue44530] Propagate qualname from the compiler unit to code objects for finer grained profiling data

2021-07-04 Thread Gabriele N Tornetta
Gabriele N Tornetta added the comment: With commit 7a12d31a8c22cae7a9c1a2239a1bb54adee33622 the new figures are # main (7569c0fe91): 25_059_438 bytes # bpo-445303-code-qualname (7a12d31a8c): 25_089_917 bytes which is a 0.1% relative increase :). This is likely due to the fact that with the

[issue44560] Unrecognized charset "eucgb2312_cn" in email header for many MUA

2021-07-04 Thread TommyLike Hu
New submission from TommyLike Hu : Email module is used for email message decode and encode, if the header content is gb2312 encoded for example "中文", by design we would finally have a rfc-2047 encoded header as below: ``` =?eucgb2312_cn?b?1tDOxA==?= ``` the test script is as below: ``` from

[issue43950] Include column offsets for bytecode instructions

2021-07-04 Thread Batuhan Taskaya
Change by Batuhan Taskaya : -- pull_requests: +25571 pull_request: https://github.com/python/cpython/pull/27011 ___ Python tracker ___