[issue10391] obj2ast's error handling can lead to python crashing with a C-level assertion failure

2010-11-19 Thread Benjamin Peterson
Benjamin Peterson benja...@python.org added the comment: r86538 -- resolution: - fixed status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10391

[issue10467] io.BytesIO.readinto() segfaults when used on BytesIO object seeked beyond end.

2010-11-20 Thread Benjamin Peterson
Benjamin Peterson benja...@python.org added the comment: r86587 -- nosy: +benjamin.peterson resolution: - fixed status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10467

[issue4925] Improve error message of subprocess when cannot open

2010-11-20 Thread Benjamin Peterson
Benjamin Peterson benja...@python.org added the comment: r86593 -- nosy: +benjamin.peterson resolution: - fixed status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4925

[issue10474] range.count returns boolean

2010-11-20 Thread Benjamin Peterson
Benjamin Peterson benja...@python.org added the comment: r86618 -- nosy: +benjamin.peterson resolution: - fixed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10474

[issue10474] range.count returns boolean

2010-11-20 Thread Benjamin Peterson
Changes by Benjamin Peterson benja...@python.org: -- status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10474 ___ ___ Python-bugs

[issue10474] range.count returns boolean

2010-11-20 Thread Benjamin Peterson
Benjamin Peterson benja...@python.org added the comment: 2010/11/20 SilentGhost rep...@bugs.python.org: SilentGhost michael.mischurow+...@gmail.com added the comment: Benjamin, the docs say that it's possible to have count more than 1, depending on comparison rules. If that's the case, I'm

[issue10476] __iter__ on a byte file object using a method to return an iterator

2010-11-20 Thread Benjamin Peterson
Benjamin Peterson benja...@python.org added the comment: BufferedIOBase readline and __iter__ has to stay for backwards compatibility (especially with python 2). As for by_bytes(), I suggest you post it to python-ideas. -- nosy: +benjamin.peterson resolution: - rejected status: open

[issue10518] Bring back callable()

2010-11-24 Thread Benjamin Peterson
Benjamin Peterson benja...@python.org added the comment: I think we should lift the py3k warning after 3.2 is released, but leave the 2to3 fixer in for the time being. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10518

[issue10299] Add index with links section for built-in functions

2010-11-24 Thread Benjamin Peterson
Benjamin Peterson benja...@python.org added the comment: Okay. 2010/11/24 Ezio Melotti rep...@bugs.python.org: Ezio Melotti ezio.melo...@gmail.com added the comment: Committed in r86732 on py3k, will backport on 3.1/2.7 if Benjamin is OK with that. -- nosy: +benjamin.peterson

[issue10518] Bring back callable()

2010-11-27 Thread Benjamin Peterson
Benjamin Peterson benja...@python.org added the comment: 2010/11/27 SilentGhost rep...@bugs.python.org: SilentGhost michael.mischurow+...@gmail.com added the comment: I thought that moratorium meant Guido dis/approval is not applicable to the 3.2 Another listed change was help ease

[issue10268] Add --enable-loadable-sqlite-extensions option to `configure`

2010-11-27 Thread Benjamin Peterson
Benjamin Peterson benja...@python.org added the comment: r86844 -- status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10268

[issue10544] yield expression inside generator expression does nothing

2010-11-28 Thread Benjamin Peterson
Benjamin Peterson benja...@python.org added the comment: I think I can probably fix it, but it's debatable whether it should be done, since it'd make list comps more of quasi functions. -- nosy: +benjamin.peterson ___ Python tracker rep

[issue10569] abc: `issubclass([], my_abstract_type)` raises exception

2010-11-28 Thread Benjamin Peterson
Benjamin Peterson benja...@python.org added the comment: Tell python-ideas about it. -- nosy: +benjamin.peterson status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10569

[issue10618] regression in subprocess.call() command quoting

2010-12-03 Thread Benjamin Peterson
Benjamin Peterson benja...@python.org added the comment: 2010/12/3 Georg Brandl rep...@bugs.python.org: Georg Brandl ge...@python.org added the comment: In util.system(), Mercurial adds its own pair of quotes:    if os.name == 'nt':        cmd = '%s' % cmd That will result in one level

[issue6101] SETUP_WITH

2010-12-04 Thread Benjamin Peterson
Benjamin Peterson benja...@python.org added the comment: 2010/12/4 Thomas Vander Stichele rep...@bugs.python.org: Thomas Vander Stichele thoma...@users.sourceforge.net added the comment: Maybe I am missing something, but why was it ok for this patch to move EXTENDED_ARGS from 143 to 145

[issue10630] dict_proxy.keys() / values() / items() are lists

2010-12-06 Thread Benjamin Peterson
Benjamin Peterson benja...@python.org added the comment: r87107 -- nosy: +benjamin.peterson resolution: - fixed status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10630

[issue10675] unittest should have an assertChanges context manager

2010-12-10 Thread Benjamin Peterson
Changes by Benjamin Peterson benja...@python.org: -- status: pending - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10675 ___ ___ Python

[issue10674] Unused dictmaker symbol in 2.* grammar

2010-12-10 Thread Benjamin Peterson
Benjamin Peterson benja...@python.org added the comment: r87167 -- resolution: - fixed status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10674

[issue10750] raw attribute of buffered IO objects is assignable

2010-12-21 Thread Benjamin Peterson
Benjamin Peterson benja...@python.org added the comment: 2010/12/21 Antoine Pitrou rep...@bugs.python.org: Antoine Pitrou pit...@free.fr added the comment: Here is a patch. I assume you can put test_readonly_attributes in CommonBufferTests

[issue10750] raw attribute of buffered IO objects is assignable

2010-12-21 Thread Benjamin Peterson
Benjamin Peterson benja...@python.org added the comment: Ah, I see. LGTM then. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10750

[issue4761] create Python wrappers for openat() and others

2010-12-21 Thread Benjamin Peterson
Benjamin Peterson benja...@python.org added the comment: The docs shouldn't use [ to denote optional args. Rather, optional arguments can just be shown by their defaults. -- nosy: +benjamin.peterson ___ Python tracker rep...@bugs.python.org http

[issue10769] ast: provide more useful range information

2010-12-24 Thread Benjamin Peterson
Benjamin Peterson benja...@python.org added the comment: 2010/12/24 Raymond Hettinger rep...@bugs.python.org: Raymond Hettinger rhettin...@users.sourceforge.net added the comment: ISTM the whole point of an Abstract Syntax Tree is to express semantics while throwing away the syntax details

[issue10769] ast: provide more useful range information

2010-12-24 Thread Benjamin Peterson
Benjamin Peterson benja...@python.org added the comment: 2010/12/24 Sven Brauch rep...@bugs.python.org: Sven Brauch svenbra...@googlemail.com added the comment: Hi, I found the reason for this behavior in the code now, it's in Python/ast.c, lines 1745 and 1746 in ast_for_power

[issue10769] ast: provide more useful range information

2010-12-25 Thread Benjamin Peterson
Benjamin Peterson benja...@python.org added the comment: 2010/12/25 Sven Brauch rep...@bugs.python.org: Sven Brauch svenbra...@googlemail.com added the comment: Hi, I agree that the current behavior is not wrong or such. It's just entirely useless. For all the other types of subscripts

[issue10769] ast: provide more useful range information

2010-12-25 Thread Benjamin Peterson
Benjamin Peterson benja...@python.org added the comment: 2010/12/25 Sven Brauch rep...@bugs.python.org: Sven Brauch svenbra...@googlemail.com added the comment: Well, weather it's supposed to or not, it *does* contain the line number information: ExprAst lineno=1 col_offset=0 For your

[issue10769] ast: provide more useful range information

2010-12-26 Thread Benjamin Peterson
Benjamin Peterson benja...@python.org added the comment: I suggest you mail python-dev or python-ideas. I find it more consistent as it stands now. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10769

[issue4662] posix module lacks several DeprecationWarning's

2011-01-01 Thread Benjamin Peterson
Benjamin Peterson benja...@python.org added the comment: Some of these warnings are incorrect, too; os.popen() and fdopen() remain in Python 3. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4662

[issue10849] Backport test/__main__

2011-01-07 Thread Benjamin Peterson
Benjamin Peterson benja...@python.org added the comment: +0. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10849 ___ ___ Python-bugs-list

[issue10849] Backport test/__main__

2011-01-07 Thread Benjamin Peterson
Benjamin Peterson benja...@python.org added the comment: 2011/1/7 Raymond Hettinger rep...@bugs.python.org: Raymond Hettinger rhettin...@users.sourceforge.net added the comment: His +0 isn't a decision.  I would like Martin, the longest term active developer, to make the call about waiving

[issue10858] Make source code links less prominent

2011-01-08 Thread Benjamin Peterson
Benjamin Peterson benja...@python.org added the comment: I'm curious as to how the experiment is being carried out and how conclusions will be drawn. -- nosy: +benjamin.peterson ___ Python tracker rep...@bugs.python.org http://bugs.python.org

[issue10892] segfault with del X.__abstractmethods__

2011-01-12 Thread Benjamin Peterson
Benjamin Peterson benja...@python.org added the comment: r87954 -- nosy: +benjamin.peterson resolution: - fixed status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10892

[issue10894] Making stdlib APIs private

2011-01-12 Thread Benjamin Peterson
Changes by Benjamin Peterson benja...@python.org: -- dependencies: +Private stdlib API: getopt, getpass, glob, gzip, genericpath, gettext ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10894

[issue10917] PEP 333 link to CGI specification is broken

2011-01-16 Thread Benjamin Peterson
Benjamin Peterson benja...@python.org added the comment: Well, that really grates on the eyes. -- nosy: +benjamin.peterson ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10917

[issue10917] PEP 333 link to CGI specification is broken

2011-01-16 Thread Benjamin Peterson
Benjamin Peterson benja...@python.org added the comment: 2011/1/16 anatoly techtonik rep...@bugs.python.org: anatoly techtonik techto...@gmail.com added the comment: Nevermind. It's just another word for gr8. Well, it really grates on the eyes

[issue10914] Python sub-interpreter test

2011-01-16 Thread Benjamin Peterson
Benjamin Peterson benja...@python.org added the comment: There's already precedent for test modules in Modules/ what with xxmodule.c and _testcapimodule.c. -- nosy: +benjamin.peterson ___ Python tracker rep...@bugs.python.org http://bugs.python.org

[issue10986] traceback's rendering behavior while throwing custom exception

2011-01-22 Thread Benjamin Peterson
Benjamin Peterson benja...@python.org added the comment: Please see python-ideas list. -- nosy: +benjamin.peterson resolution: - rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10986

[issue11032] _string: formatter_field_name_split() and formatter_parser() don't check input type

2011-01-28 Thread Benjamin Peterson
Benjamin Peterson benja...@python.org added the comment: 2011/1/28 Eric Smith rep...@bugs.python.org: Eric Smith e...@trueblade.com added the comment: Release manager: You can decide if this fix should go in before 3.2. It's a trivial fix to a crasher, but it's extremely unlikely anyone

[issue11086] add lib2to3/__main__.py

2011-01-31 Thread Benjamin Peterson
Benjamin Peterson benja...@python.org added the comment: Uh, I must say I find typing lib2to3 quite ugly. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11086

[issue11105] Compiling evil ast crashes interpreter

2011-02-02 Thread Benjamin Peterson
New submission from Benjamin Peterson benja...@python.org: You don't want to know why I was thinking about this... $ ./python Python 3.2rc2+ (py3k:88302, Feb 1 2011, 19:02:10) [GCC 4.4.4] on linux2 Type help, copyright, credits or license for more information. import ast e = ast.UnaryOp(op

[issue11105] Compiling evil ast crashes interpreter

2011-02-03 Thread Benjamin Peterson
Benjamin Peterson benja...@python.org added the comment: 2011/2/3 Alexander Belopolsky rep...@bugs.python.org: Alexander Belopolsky belopol...@users.sourceforge.net added the comment: Looks like a stack overflow caused by an infinite recursion.  I am not sure if it is possible to add cycle

[issue11105] Compiling evil ast crashes interpreter

2011-02-03 Thread Benjamin Peterson
Benjamin Peterson benja...@python.org added the comment: 2011/2/3 Alexander Belopolsky rep...@bugs.python.org: Alexander Belopolsky belopol...@users.sourceforge.net added the comment: On Thu, Feb 3, 2011 at 12:08 PM, Benjamin Peterson rep...@bugs.python.org wrote: .. I wonder: Why ast

[issue11145] '%o' % user-defined instance

2011-02-09 Thread Benjamin Peterson
Benjamin Peterson benja...@python.org added the comment: It's a magic method in 2.7 but not 3.x. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11145

[issue11180] More efficient nlargest()/nsmallest()

2011-02-10 Thread Benjamin Peterson
Benjamin Peterson benja...@python.org added the comment: I think you should implement and benchmark one of them. I'm dubious that the better asymptotic values will really translate into better performance. For example, the O(n) median selection algorithm has a large constant factor associated

[issue11302] Add more tests to test_ast.py

2011-02-23 Thread Benjamin Peterson
Benjamin Peterson benja...@python.org added the comment: Please upload to Rietveld. I have a few comments to make. -- nosy: +benjamin.peterson ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11302

[issue11276] 2to3: imports fixer doesn't update references to modules specified without attributes

2011-02-23 Thread Benjamin Peterson
Benjamin Peterson benja...@python.org added the comment: I'm trying to remember if this was intentional or not... -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11276

[issue11305] TextIOWrapper.readline and str.splitlines have different behavior

2011-02-23 Thread Benjamin Peterson
New submission from Benjamin Peterson benja...@python.org: For example: 'print 1\n\x0cprint 2\n\n'.splitlines() ['print 1\n', '\x0cprint 2\n', '\n'] list(io.StringIO('print 1\n\x0cprint 2\n\n')) I'm not sure which is preferable. -- components: IO, Interpreter Core messages: 129240

[issue11305] TextIOWrapper.readline and str.splitlines have different behavior

2011-02-23 Thread Benjamin Peterson
Benjamin Peterson benja...@python.org added the comment: I don't see that, but the chances of changing either of these is quite low, so I suppose we should just document. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11305

[issue11335] Memory leak after key function failure in sort

2011-02-26 Thread Benjamin Peterson
Benjamin Peterson benja...@python.org added the comment: LGTM -- nosy: +benjamin.peterson ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11335

[issue11339] annotation for class being defined

2011-02-26 Thread Benjamin Peterson
Benjamin Peterson benja...@python.org added the comment: This has been true forever. I suggest you try python-ideas. -- nosy: +benjamin.peterson resolution: - rejected status: open - closed ___ Python tracker rep...@bugs.python.org http

[issue11250] 2to3 truncates files at formfeed character

2011-02-26 Thread Benjamin Peterson
Benjamin Peterson benja...@python.org added the comment: r88661 -- resolution: - fixed status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11250

[issue11345] Fix a link in library/json docs

2011-02-27 Thread Benjamin Peterson
Benjamin Peterson benja...@python.org added the comment: r88668 -- nosy: +benjamin.peterson resolution: - fixed status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11345

[issue4600] __class__ assignment: new-style? heap? == confusing

2011-02-27 Thread Benjamin Peterson
Benjamin Peterson benja...@python.org added the comment: This is not really accurate: class x(int): pass ... class y(object): pass ... x().__class__ = y Traceback (most recent call last): File stdin, line 1, in module TypeError: __class__ assignment: 'x' object layout differs from 'y' y

[issue11349] _pickle should implement the module finalisation protocol

2011-02-27 Thread Benjamin Peterson
Benjamin Peterson benja...@python.org added the comment: Unfortunately proper module finalization is an invitation to more segfaults because modules can be finalized before objects in them are, resulting in segfaults when its attempted to access modules. -- nosy: +benjamin.peterson

[issue11349] _pickle should implement the module finalisation protocol

2011-02-28 Thread Benjamin Peterson
Benjamin Peterson benja...@python.org added the comment: It's a chicken and egg problem because proper module finalization techniques like #812369 are bogged down by static globals in extension modules, and proper state storage in modules is prevented by proper module finalization

[issue1828] Renaming platform path modules

2008-01-14 Thread Benjamin Peterson
Benjamin Peterson added the comment: Well, yes but I think that it's rare enough that in the name of keeping the stdlib clean, it's reasonable to say: import _posixpath and posixpath This also occurs when somone wants to modify __builtin__. __ Tracker [EMAIL

[issue1829] Renaming platform path modules

2008-01-14 Thread Benjamin Peterson
Benjamin Peterson added the comment: Sorry for the double. __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1829 __ ___ Python-bugs-list mailing list Unsubscribe: http

[issue1828] Renaming platform path modules

2008-01-14 Thread Benjamin Peterson
New submission from Benjamin Peterson: Currently, all the platform-specific path modules (ntpath, macpath, etc) have normal module names. Since they are implementation details, they should have a _ prepended to their names. I doubt this would break much code: I've never written witnessed any

[issue1829] Renaming platform path modules

2008-01-14 Thread Benjamin Peterson
New submission from Benjamin Peterson: Currently, all the platform-specific path modules (ntpath, macpath, etc) have normal module names. Since they are implementation details, they should have a _ prepended to their names as is the custom for private objects. I doubt this would break much code

[issue1828] Renaming platform path modules

2008-01-14 Thread Benjamin Peterson
Benjamin Peterson added the comment: On Jan 14, 2008 7:44 PM, Guido van Rossum [EMAIL PROTECTED] wrote: Guido van Rossum added the comment: And guess what, in 3.0 __builtin__ is renamed to builtin. point taken -- resolution: - rejected

[issue1910] _threading_local should use with

2008-01-22 Thread Benjamin Peterson
New submission from Benjamin Peterson: I was reading _threading_local and noticed it didn't use the with statment, yet. So, I cooked up this trivial patch. I hope this isn't to small. Thanks for your time. -- components: Library (Lib) files: _threading_local-with-stmt.diff messages

[issue1910] Document that with is slower than try/finally

2008-01-23 Thread Benjamin Peterson
Benjamin Peterson added the comment: Most platforms use the faster thread.LockType. Correct? Perhaps, since this module is more a reference implementation and it is pointed to by the threading docs (http://docs.python.org/lib/module-threading.html), we should elect to take the more pythonic

[issue1910] Document that with is slower than try/finally

2008-01-24 Thread Benjamin Peterson
Benjamin Peterson added the comment: Ok, I see your reasoning. I'm going to start going to through the rest of the library for places with should be used. __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1910

[issue1941] 2.6 stdlib using with statement

2008-01-26 Thread Benjamin Peterson
New submission from Benjamin Peterson: This patch modernizes many modules in the stdlib by making them using the with statement. They affected modules are modulefinder, ftplib, cookielib, shutil, pydoc, platform, _LWPCookieJar, mailbox, _MozillaCookieJar, and zipfile. -- components

[issue1941] 2.6 stdlib using with statement

2008-01-26 Thread Benjamin Peterson
Benjamin Peterson added the comment: This new patch removes the modulefinder changes. I was the one you submitted #1910 which probably sparked the performance debate. In this patch, I tried to avoid these touchy places. Added file: http://bugs.python.org/file9295/stdlib-with-stmt2.diff

[issue1941] 2.6 stdlib using with statement

2008-01-26 Thread Benjamin Peterson
Benjamin Peterson added the comment: Sorry, but what does that mean? All tests are passing with the changes. __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1941 __ ___ Python

[issue1941] 2.6 stdlib using with statement

2008-01-27 Thread Benjamin Peterson
Benjamin Peterson added the comment: Today, I carefully looked through every change in my patching. I asked myself Does this do the same things in the same order as the original? and Could exceptions cause the code to function differently? They only changes were when the block which used

[issue1941] 2.6 stdlib using with statement

2008-01-31 Thread Benjamin Peterson
Benjamin Peterson added the comment: Comments? __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1941 __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org

[issue1941] 2.6 stdlib using with statement

2008-01-31 Thread Benjamin Peterson
Benjamin Peterson added the comment: This new patch removes changes to the platform module. Added file: http://bugs.python.org/file9342/stdlib-with-stmt2-no-platform.diff __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1941

[issue1941] 2.6 stdlib using with statement

2008-02-03 Thread Benjamin Peterson
Benjamin Peterson added the comment: I could break this patch into per-module patches. Then as authors approved them, they could gradually be committed. __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1941

[issue2055] test_fcntl.py converted to unittest

2008-02-09 Thread Benjamin Peterson
Benjamin Peterson added the comment: I converted this for GHOP: http://code.google.com/p/google-highly-open-participation-psf/issues/detail?id=292can=1q=completedcolspec=ID%20Status%20ClaimedBy%20Due%20NeedsReview%20Summarystart=100 -- nosy: +gutworth

[issue2060] python2.6 -3 gives warning: callable() not supported in 3.x on startup

2008-02-10 Thread Benjamin Peterson
Benjamin Peterson added the comment: On my Mac, I also get about 30 warnings about dict.has_key. By the way, what are you supposed you use in py3k instead of callable? -- nosy: +gutworth __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue2060

[issue2144] os.environ should inherit dict

2008-02-19 Thread Benjamin Peterson
New submission from Benjamin Peterson: This patch changes os.environ to inherit builtin dict rather than UserDict. -- files: environ-modern.diff messages: 62571 nosy: gutworth severity: normal status: open title: os.environ should inherit dict type: rfe versions: Python 2.6 Added file

[issue2144] os.environ should inherit dict

2008-02-19 Thread Benjamin Peterson
Benjamin Peterson added the comment: Forgive me. I meant 290. __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue2144 __ ___ Python-bugs-list mailing list Unsubscribe: http

[issue2144] os.environ should inherit dict

2008-02-20 Thread Benjamin Peterson
Benjamin Peterson added the comment: I know that it doesn't mention inheriting dict specifically, but you asked why, so I was referring to the Rationale: Modernization options arise when new versions of Python add features that allow improved clarity or higher performance than previously

[issue2149] Queue.maxsize, __init__() accepts any value as maxsize

2008-02-20 Thread Benjamin Peterson
Benjamin Peterson added the comment: Is there a problem with a dynamic object that changes the maxsize? I think it might be better to ignore it, and let the client get exceptions when their maxsize is compared. -- nosy: +gutworth __ Tracker [EMAIL

[issue2149] Queue.maxsize, __init__() accepts any value as maxsize

2008-02-20 Thread Benjamin Peterson
Benjamin Peterson added the comment: Rafael, I agree that it's awkward, and I'm not against restricting the maxsize to just something sane. However, I'm worried this (Raymond's patch) will be too restrictive by not allowing dynamic changing of maxsize. (Of course, you could just change

[issue2127] sqlite3 docs should mention utf8 requirement

2008-02-20 Thread Benjamin Peterson
Changes by Benjamin Peterson: -- nosy: +georg.brandl __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue2127 __ ___ Python-bugs-list mailing list Unsubscribe: http

[issue2149] Queue.maxsize, __init__() accepts any value as maxsize

2008-02-21 Thread Benjamin Peterson
Benjamin Peterson added the comment: I like it. __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue2149 __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org

[issue2149] Queue.maxsize, __init__() accepts any value as maxsize

2008-02-21 Thread Benjamin Peterson
Benjamin Peterson added the comment: Maybe, we should change change the constructor to use self.maxsize = int(maxsize). Then we can provide a set_maxsize method that will acquire the mutex and preform the change. This is will restrict the type of maxsize and allow for easy dynamic changing

[issue2149] Queue.maxsize, __init__() accepts any value as maxsize

2008-02-21 Thread Benjamin Peterson
Benjamin Peterson added the comment: Raymond, are you referring to the int checking, my new method, or both? __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue2149 __ ___ Python

[issue2149] Queue.maxsize, __init__() accepts any value as maxsize

2008-02-21 Thread Benjamin Peterson
Benjamin Peterson added the comment: Ok. I agree that we shouldn't muddy the waters of Queue by checking for int. (set_maxsize would be unneeded) Go ahead and close. __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue2149

[issue2153] unittest.py modernization

2008-02-21 Thread Benjamin Peterson
Changes by Benjamin Peterson: -- nosy: +purcell __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue2153 __ ___ Python-bugs-list mailing list Unsubscribe: http

[issue2158] confusing exception when opening a filename with nonprintable characters

2008-02-21 Thread Benjamin Peterson
Benjamin Peterson added the comment: I can confirm on the trunk with Mac OSX 10.4. -- nosy: +benjamin.peterson __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue2158

[issue2158] confusing exception when opening a filename with nonprintable characters

2008-02-21 Thread Benjamin Peterson
Changes by Benjamin Peterson: -- versions: +Python 2.6 __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue2158 __ ___ Python-bugs-list mailing list Unsubscribe: http

[issue2158] confusing exception when opening a filename with nonprintable characters

2008-02-21 Thread Benjamin Peterson
Benjamin Peterson added the comment: The problem appears to be that Mac's strerror doesn't return a good error message. We could try to detect this sort of thing, but I'm not sure how. __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue2158

[issue2156] TestCase.tmpdir(), TestCase.mock()

2008-02-21 Thread Benjamin Peterson
Benjamin Peterson added the comment: The Path class of hs.path is, I assume, a nice wrapper around a file or directory. However, Python does not have something like this, so it's probably more useful to just return the raw path. __ Tracker [EMAIL PROTECTED] http

[issue2156] TestCase.tmpdir(), TestCase.mock()

2008-02-21 Thread Benjamin Peterson
Benjamin Peterson added the comment: First, is hs a company package? You'll most likely want to remove it. Otherwise, this looks useful. I wonder if this is something we could use in test.test_support. I'd like it for some of Python's regression tests. Brett, what do you think about

[issue2149] Queue.maxsize, __init__() accepts any value as maxsize

2008-02-23 Thread Benjamin Peterson
Benjamin Peterson added the comment: Many places in the stdlib accept values which are not valid. I believe this is because the library trusts you to do the right thing in the name of performance and cleaner, simpler code. IMO, adding a set_maxsize method wouldn't be a sin, but Raymond (who

[issue1746071] class mutex doesn't do anything atomically

2008-02-23 Thread Benjamin Peterson
Benjamin Peterson added the comment: Is this module still of any use to anyone? It seems if you wanted a fake mutex, you could just import LockType from dummy_thread. -- nosy: +benjamin.peterson _ Tracker [EMAIL PROTECTED] http://bugs.python.org

[issue2149] Queue.maxsize, __init__() accepts any value as maxsize

2008-02-23 Thread Benjamin Peterson
Benjamin Peterson added the comment: The only possible problem I'm able to see is someone passing an object wich has __int__() and expecting it to be used. They should be explicit and say Queue(int(object_with__int__)). __ Tracker [EMAIL PROTECTED] http

[issue1746071] class mutex doesn't do anything atomically

2008-02-23 Thread Benjamin Peterson
Benjamin Peterson added the comment: For what it's worth, here's a test case against the trunk. -- keywords: +patch Added file: http://bugs.python.org/file9521/test_mutex.diff _ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1746071

[issue2144] os.environ should inherit dict

2008-02-23 Thread Benjamin Peterson
Benjamin Peterson added the comment: Here's a corrected version. -- keywords: +patch Added file: http://bugs.python.org/file9524/environ-modern2.diff __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue2144

[issue2144] os.environ should inherit dict

2008-02-23 Thread Benjamin Peterson
Benjamin Peterson added the comment: And another. Added file: http://bugs.python.org/file9525/environ-modern3.diff __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue2144

[issue1394] simple patch, improving unreachable bytecode removing

2008-02-25 Thread Benjamin Peterson
Benjamin Peterson added the comment: Yes, help with unit tests would be appreciated. Especially since it is not supposed to fix anything, so I'm not sure what unit tests should be like... Unit tests are just for bugfixes. They let us make sure Python is doing what we want it to do in a given

[issue1394] simple patch, improving unreachable bytecode removing

2008-02-25 Thread Benjamin Peterson
Benjamin Peterson added the comment: I presume you meant are *not* just for bugfixes. (Sigh) Yes, of course. __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1394 __ ___ Python

[issue2189] urllib.quote() throws KeyError when passed an iterator

2008-02-25 Thread Benjamin Peterson
Benjamin Peterson added the comment: Does something in the docs lead you to believe urllib.quote should accept a list of strings? The stdlib tends to shun type-checking to make cleaner and faster code, and let the client get exceptions like these. -- nosy: +benjamin.peterson

[issue2196] Fix hasattr's exception problems

2008-02-26 Thread Benjamin Peterson
New submission from Benjamin Peterson: hasattr currently returns False when any exception happens in getattr. I see that this tracker I previous patches trying to fix this issue, but they were rejected because they only tried to catch attribute errors. My patch only propagates SystemExit

[issue2196] Fix hasattr's exception problems

2008-02-28 Thread Benjamin Peterson
Benjamin Peterson added the comment: Here's a documentation change that explains hasattr's exception issues top accompany my patch. -- components: +Documentation Added file: http://bugs.python.org/file9567/hasattr_docs.diff __ Tracker [EMAIL PROTECTED

[issue2206] critical memory leak in hashlib.md5

2008-02-28 Thread Benjamin Peterson
Benjamin Peterson added the comment: This is not a hashlib problem (or a bug at all.) range returns an list of numbers. The allocation of this list is the part taking up all the memory. Try replacing range with xrange. -- nosy: +benjamin.peterson

[issue2206] critical memory leak in hashlib.md5

2008-02-28 Thread Benjamin Peterson
Changes by Benjamin Peterson: -- severity: normal - minor __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue2206 __ ___ Python-bugs-list mailing list Unsubscribe: http

  1   2   3   4   5   6   7   8   9   10   >