Changes by Brett Cannon br...@python.org:
--
nosy: +brett.cannon
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23389
___
___
Python-bugs-list
Brett Cannon added the comment:
If it was created by a fuzzer then this isn't a bug as we do no validation of
bytecode formatting as we assume it was generated by Python and not an
external, malicious source.
--
nosy: +brett.cannon
resolution: - not a bug
status: open - closed
Changes by Brett Cannon br...@python.org:
--
resolution: - third party
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23240
Brett Cannon added the comment:
That leading underscore in the method name means it is not a public API and
thus changes are allowed without any backwards-compatibility guarantees.
Mercurial will need to update their code to handle this if they want to
continue to use the method
Brett Cannon added the comment:
If you want a robust measurement of startup impact, the benchmark suite has two
benchmarks specifically for startup (w/ and w/o site.py).
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23253
Changes by Brett Cannon br...@python.org:
--
nosy: +brett.cannon
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23257
___
___
Python-bugs-list
Changes by Brett Cannon br...@python.org:
--
nosy: +brett.cannon
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23253
___
___
Python-bugs-list
Brett Cannon added the comment:
Change went in through making create_module() required.
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23013
Brett Cannon added the comment:
create_module() is now slated to be required in Python 3.6.
--
resolution: - out of date
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21581
Brett Cannon added the comment:
Thanks for the hard work, Demian! I don't remember how often the devguide is
updated online, but it should hopefully be no longer than a day (probably more
like an hour).
--
resolution: - fixed
stage: patch review - resolved
status: open - closed
Changes by Brett Cannon br...@python.org:
--
resolution: - duplicate
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23483
___
___
Python-bugs-list
Brett Cannon added the comment:
That seems reasonable. I guess first step is a patch and then seeing if it
passes the test suite.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23203
Changes by Brett Cannon br...@python.org:
--
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23014
Brett Cannon added the comment:
I think I would need to see exactly how you want the bytecode to change and
then think over any backwards-compatibility issues since this is doesn't come
up very often.
--
___
Python tracker rep...@bugs.python.org
Brett Cannon added the comment:
If Antoine or Ezio don't make any more comments or commit this themselves then
I will take the patch as-is and commit it next Friday.
Sorry for the delay, Demian, but December is always a slow month due to
holidays
Brett Cannon added the comment:
Because stat results are cached for performance reasons, it's possible to write
to the file system and then try to read/import from it before the modification
time for the directory even picks up that there was a change. For this reason
New submission from Brett Cannon:
* Link to the function from importlib.__import__()
* Link to importlib.invalidate_caches()
* Linkify mention in docs for importlib.util.find_spec()
--
assignee: brett.cannon
components: Documentation
messages: 235616
nosy: brett.cannon
priority: low
Brett Cannon added the comment:
Dead code deletion should be a separate issue, so I'm going to close this as
fixed.
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15914
Brett Cannon added the comment:
If you want to take a stab at it, Steven, go for it and I will review the
patch, but as you pointed out this is such an edge case that I'm personally not
going to worry about fixing it and still don't consider it a bug.
--
title: Relative imports
Brett Cannon added the comment:
If you put a print call after your `from . import *` call you will notice it
never gets executed. Basically import is still in the middle of finishing
imports when that import * is reached, including setting the module attributes
on the package. Basically you
Brett Cannon added the comment:
I'm adding Nick to see if he has anything to add since he was the one that
worked on the change that Richard said caused the problem. But in my opinion
this is in the same realm as importing as a side-effect of spawning a thread;
don't do it.
--
nosy
Changes by Brett Cannon br...@python.org:
--
nosy: +twouters
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23696
___
___
Python-bugs-list mailing
Brett Cannon added the comment:
Will probably want to see http://bugs.python.org/issue17232 resolved as part of
this as well.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23731
Changes by Brett Cannon br...@python.org:
--
nosy: +brett.cannon
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23738
___
___
Python-bugs-list
Brett Cannon added the comment:
I haven't thought about how to implement it, let alone document it. As I said,
I might simply refactor importlib so that others can at least implement a
loader which can do this without having to directly muck with importlib itself.
It really depends on how far
Changes by Brett Cannon br...@python.org:
--
priority: deferred blocker - release blocker
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23681
New submission from Brett Cannon:
To help writing Python 2/3 code the -b flag should switch on a warning when
comparing an int to a bytes object in Python 2. This will help when someone
writes something like `b'abcd'[2] == b'c'` and it always returns False thanks
to the indexing returning 99
Changes by Brett Cannon br...@python.org:
--
priority: normal - deferred blocker
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23681
Changes by Brett Cannon br...@python.org:
--
versions: +Python 3.5 -Python 2.7
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23681
___
___
Python
Changes by Brett Cannon br...@python.org:
--
priority: normal - release blocker
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2292
___
___
Python
New submission from Brett Cannon:
devinabox has instructions on how to get the best test coverage for Python
possible: https://hg.python.org/devinabox/file/1eeb96fe98f1/README#l124 . It
would probably be good to get a test report at least daily to help keep an eye
on general test coverage
Changes by Brett Cannon br...@python.org:
--
assignee: docs@python - serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22832
New submission from Brett Cannon:
The porting HOWTO for Python 3.5 doesn't mention that bytes interpolation will
exist.
--
assignee: brett.cannon
components: Documentation
messages: 238804
nosy: brett.cannon
priority: normal
severity: normal
status: open
title: Update porting HOWTO
New submission from Brett Cannon:
Thanks to http://bugs.python.org/issue23681 we now have a better story about
helping people find int/bytes comparison issues. The docs for Python 3.5 -- but
not Python 3.4! -- should get updated to point out this change.
--
assignee: brett.cannon
New submission from Brett Cannon:
https://www.python.org/dev/peps/pep-0488/
--
assignee: brett.cannon
components: Interpreter Core
messages: 238799
nosy: brett.cannon
priority: release blocker
severity: normal
stage: test needed
status: open
title: Implement PEP 488
type: enhancement
Brett Cannon added the comment:
What Greg said. =) Basically it would allow those who know what they are doing
to cut out a stat call per load. I suspect anyone deploying to a server is in a
similar situation where they are not actively editing the code once deployed,
and so saving
Brett Cannon added the comment:
I did one final pass on the patch and only had wording comments, so tweak those
and it LGTM. Assigned to Serhiy since it's obviously his patch. =)
Only other thing is to either open up a separate bug or at least apply the
fixes to the stdlib in Python 3.4
New submission from Brett Cannon:
In environments where bytecode generation is thoroughly controlled, it would be
nice if there was a way to specify that the bytecode file is externally
guaranteed to be up-to-date, and thus skip any stat call involving bytecode
verification. Could
Brett Cannon added the comment:
Egg files are not a part of the Python stdlib and so I don't understand why you
expected them to be supported by imp? Anyway, because egg files are not from
Python itself but a third-party project they shouldn't be referenced from the
official docs as it would
Brett Cannon added the comment:
LGTM as well. You want to commit, Serhiy? If not assign to me and I will get to
it on Friday.
--
assignee: - serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23615
New submission from Brett Cannon:
With os.scandir() now committed and implemented in C, it would be interesting
to see if os.scandir() could provide any performance benefit to importlib. If
finders can pass the DirEntry to loaders then some stat calls could potentially
be saved at the expense
Brett Cannon added the comment:
I interpret Guido's email as vetoing the skipping of the C implementation of
PEP 485, not on outright banning a PEP 399 math.py if someone like Victor
wanted to put the work into implementing some things on top of the C code in
Python. So as long as everything
Brett Cannon added the comment:
There is a proposed PEP on the import-sig:
https://mail.python.org/pipermail/import-sig/2015-March/000904.html . I'm
hoping to add it for the author to the PEP index on Friday.
Basically we punted on extension modules as we ran out of time in Python 3.4
Brett Cannon added the comment:
I understood what you asked. My point is that mentioning eggs in the imp
doesn't make sense since the imp module nor import supports them natively. Eggs
are a setuptools thing, not a Python standard library thing
Brett Cannon added the comment:
The answer is no.
--
resolution: - rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23628
Brett Cannon added the comment:
The PEP is now live: https://www.python.org/dev/peps/pep-0489/ . If you want to
participate in the discussion it will probably happen on the import-sig.
--
___
Python tracker rep...@bugs.python.org
http
Brett Cannon added the comment:
Depends on whether you want to support pathlib.Path objects explicitly. =) If
so then yes, we should add tests.
Which reminds me, it might be time for you to request commit privileges so you
can commit patches like this yourself
Brett Cannon added the comment:
Thanks for the patch, Paul! I touched up the formatting to be more PEP 8
compliant and fixed the tests as they initially failed for me (TESTFN didn't
exist prior to you trying to make a directory, so it just failed; switched to
tempfile.TemporaryDirectory
New submission from Brett Cannon:
As it stand, zipapp's code checks for str and then otherwise assumes an object
is a file-like object. It might work out better to do some duck typing and
simply check if an object has 'read' and 'readline' attributes then it's a
file-like object and otherwise
Brett Cannon added the comment:
Here is a proposed patch that does what I was thinking. What do you think?
As for updating zipfile, it's possible but slightly risky because of
backwards-compatibility. Since this is all-new code there is no worry about
breaking someone's pre-existing code
Changes by Brett Cannon br...@python.org:
--
nosy: +brett.cannon
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23643
___
___
Python-bugs-list
Changes by Brett Cannon br...@python.org:
--
assignee: - brett.cannon
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23773
___
___
Python-bugs
Brett Cannon added the comment:
Probably need to introduce a new keyword argument just for deprecated imports
or some helper function in importlib to get the stack depth right (else there
is a risk of breaking the stack depth in any minor release whenever importlib's
depth shifts). Something
Changes by Brett Cannon br...@python.org:
--
nosy: +brett.cannon
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23807
___
___
Python-bugs-list
New submission from Brett Cannon:
test test_enum failed -- Traceback (most recent call last):
File /Users/bcannon/Repositories/cpython/default/Lib/test/test_enum.py,
line 580, in test_class_nested_enum_and_pickle_protocol_four
protocol=(0, 3))
File /Users/bcannon/Repositories/cpython
Changes by Brett Cannon br...@python.org:
--
components: IDLE
nosy: brett.cannon
priority: normal
severity: normal
stage: needs patch
status: open
title: test_idle fails under -OO
versions: Python 3.5
___
Python tracker rep...@bugs.python.org
http
New submission from Brett Cannon:
==
FAIL: test_pydoc (__main__.TestStdLib)
--
Traceback (most recent call last):
File /Users/bcannon/Repositories/cpython
New submission from Brett Cannon:
==
ERROR: test_warning_classes (__main__.CWarnTests)
--
Traceback (most recent call last):
File /Users/bcannon/Repositories
New submission from Brett Cannon:
==
FAIL: test_sys_exit (__main__.WithProcessesTestSubclassingProcess)
--
Traceback (most recent call last):
File
/Users
New submission from Brett Cannon:
==
ERROR: testCmsgTruncLen0 (__main__.RecvmsgSCMRightsStreamTest)
--
Traceback (most recent call last):
File /Users/bcannon
New submission from Brett Cannon:
Ton of failures along the lines of:
==
ERROR: test_ctor (test.test_asyncio.test_unix_events.UnixReadPipeTransportTests
New submission from Brett Cannon:
==
FAIL: test_cached_sourceless
(test.test_importlib.test_spec.Frozen_ModuleSpecTests)
--
Traceback (most recent call last
Changes by Brett Cannon br...@python.org:
--
components: Tests
nosy: brett.cannon
priority: normal
severity: normal
stage: needs patch
status: open
title: test_pdb fails under -O
versions: Python 3.5
___
Python tracker rep...@bugs.python.org
http
New submission from Brett Cannon:
==
FAIL: test_double_dot_no_clobber (__main__.PyCompileTests)
--
Traceback (most recent call last):
File
/Users/bcannon
Changes by Brett Cannon br...@python.org:
--
nosy: +brett.cannon
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23794
___
___
Python-bugs-list
Brett Cannon added the comment:
The closing of this issue inspired me to think of a better way to do this, and
I think providing something in importlib.util that accepted a NodeTransformer
as an argument to a function that compiled source files to bytecode files would
fill this issue thanks
Brett Cannon added the comment:
I say switch to what Argument Clinic uses, else there's a disconnect
syntactically between help() and the docs.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23738
Changes by Brett Cannon br...@python.org:
--
assignee: - brett.cannon
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21062
___
___
Python-bugs
Changes by Brett Cannon br...@python.org:
Removed file: http://bugs.python.org/file38785/be7d966b660a.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23731
Changes by Brett Cannon br...@python.org:
--
hgrepos: +303
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23731
___
___
Python-bugs-list mailing
Changes by Brett Cannon br...@python.org:
--
keywords: +patch
Added file: http://bugs.python.org/file38785/be7d966b660a.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23731
Brett Cannon added the comment:
Here is a patch that implements PEP 488 **except** for Windows installer stuff.
I don't think the Windows changes need to block this patch going in, but I will
need someone on Windows to help fix up PC/, PCbuild/, Tools/msi,
Lib/distutils/command/bdist_msi.py
Changes by Brett Cannon br...@python.org:
Added file: http://bugs.python.org/file38786/8ce8e9b1f3e7.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23731
Brett Cannon added the comment:
Thanks for catches the mistakes, guys!
--
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22834
Brett Cannon added the comment:
The patch LGTM. Serhiy, you have anything to add?
--
stage: needs patch - commit review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22832
Brett Cannon added the comment:
Thanks for the suggestion, Martin. Went with a variant of what you proposed.
--
resolution: - fixed
stage: - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22834
Changes by Brett Cannon br...@python.org:
--
resolution: - fixed
stage: - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23422
Changes by Brett Cannon br...@python.org:
--
status: closed - open
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22834
___
___
Python-bugs-list
Brett Cannon added the comment:
Python's startup performance is very sensitive to what modules get imported for
all Python programs. The tests that are failing for you make sure that a core
developer doesn't accidentally introduce a new startup dependency and thus slow
startup times without
Changes by Brett Cannon br...@python.org:
--
resolution: - fixed
stage: - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23732
Brett Cannon added the comment:
Thanks for the patch, Serhiy, but my PEP 488 patch invalidated yours. I just
skipped it under -O rather than weakening the test to also work under -O.
--
resolution: - fixed
stage: patch review - resolved
status: open - closed
Changes by Brett Cannon br...@python.org:
--
resolution: - fixed
stage: - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23733
Brett Cannon added the comment:
The PEP 488 change actually fixed this.
--
resolution: - out of date
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23820
Brett Cannon added the comment:
Did you happen to run the test suite with this change, Shiz? There's actually a
test to make sure that the part of the traceback you're avoiding isn't lost in
case there's a bug in importlib itself.
Can you show that your change won't actually affect finding
Brett Cannon added the comment:
Thanks to Paul and Eric for the review and everyone who provided input!
--
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Brett Cannon added the comment:
LGTM
--
stage: patch review - commit review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23917
___
___
Python
Brett Cannon added the comment:
I don't know if Larry is planning to do tarball releases for 3.5 (added him to
the nosy to see).
As for the install step, it would be best to suggest people install to a temp
directory so they don't accidentally end up with a beta release stuck
Changes by Brett Cannon br...@python.org:
--
assignee: brett.cannon -
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14019
___
___
Python-bugs
Changes by Brett Cannon br...@python.org:
--
status: open - pending
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24050
___
___
Python-bugs-list
Changes by Brett Cannon br...@python.org:
--
nosy: +brett.cannon
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24049
___
___
Python-bugs-list
Changes by Brett Cannon br...@python.org:
--
nosy: +brett.cannon, eric.snow, ncoghlan
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24048
Brett Cannon added the comment:
Here is a private function in warnings for calculating the stack depth to the
first frame not referencing some key string. Can someone look at it to make
sure it looks reasonable?
I'm starting with it being private since it uses sys._getframe() and I don't
Brett Cannon added the comment:
I've decided that having the module exist in Python 2.7 and 3.5 but not 3.0 -
3.4 is just asking for trouble.
--
resolution: - rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http
Brett Cannon added the comment:
OK, I'll look at making it more general for multiple names to skip.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23810
Brett Cannon added the comment:
Just FYI, http://bugs.python.org/issue11549 can act as a tracking issue for an
AST optimization path that runs prior to the peepholer.
--
nosy: +brett.cannon
___
Python tracker rep...@bugs.python.org
http
Brett Cannon added the comment:
Skipping the source stat makes no difference in startup time even if you import
django.http as part of the work. This would definitely be mostly for people who
launch so many processes that they actually gain from collecting microseconds
worth of benefit from
Brett Cannon added the comment:
All of the exception code is written in C. My hypothesis is that it isn't
necessary to define *all* exceptions in C. Using a technique similar to
importlib, I suspect we could write a bunch of the exceptions that are not
critical to interpreter startup
Changes by Brett Cannon br...@python.org:
--
versions: +Python 3.5 -Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24069
___
___
Python
Brett Cannon added the comment:
Normally I would agree comments don't belong there, but if we are going to
start giving them semantic meaning then I don't think it's not so clear to me
anymore.
As to where to attach, simple place is off of the Module node. Another is to
have
Brett Cannon added the comment:
The issue is still valid and waiting for someone to submit a patch to the
devguide.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10965
1 - 100 of 5624 matches
Mail list logo
