[issue8200] logging module errors out if log called when multiprocessing module not finished loading

2010-03-22 Thread Chris Jerdonek
New submission from Chris Jerdonek chris.jerdo...@gmail.com: The logging module errors out if the multiprocessing module is not finished loading when logging.log() is called. This can happen, for example, if a custom import hook is defined that causes third-party code to execute when

[issue8200] logging module errors out if log called when multiprocessing module not finished loading

2010-03-22 Thread Chris Jerdonek
Changes by Chris Jerdonek chris.jerdo...@gmail.com: -- nosy: +vinay.sajip ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8200 ___ ___ Python-bugs

[issue8200] logging module errors out if log called when multiprocessing module not finished loading

2010-03-22 Thread Chris Jerdonek
Chris Jerdonek chris.jerdo...@gmail.com added the comment: Reversing the if-else in Florent's suggestion seems to address points (1) and (2). Is there a reason to set and check an mp variable rather than simply having the try-except block? if not logMultiprocessing: self.processName

[issue8200] logging module errors out if log called when multiprocessing module not finished loading

2010-03-22 Thread Chris Jerdonek
Chris Jerdonek chris.jerdo...@gmail.com added the comment: I agree. Thanks! -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8200 ___ ___ Python

[issue8200] logging module errors out if log called when multiprocessing module not finished loading

2010-03-22 Thread Chris Jerdonek
Chris Jerdonek chris.jerdo...@gmail.com added the comment: FYI, I verified the fix in my local environment. Thanks again. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8200

[issue7559] TestLoader.loadTestsFromName swallows import errors

2010-03-28 Thread Chris Jerdonek
Chris Jerdonek chris.jerdo...@gmail.com added the comment: I was also hit by this today. For the sake of clarity, I will restate two of the scenarios that have been mentioned in this discussion: (1) An ImportError raised whilst importing a module (original issue) (2) A sub-module not existing

[issue8297] AttributeError message text should include module name

2010-04-02 Thread Chris Jerdonek
New submission from Chris Jerdonek chris.jerdo...@gmail.com: It would be nice if the error message for an AttributeError could include the module name when getting from a module -- just like it does for getting from a class. This would make the message more helpful. For example, it would

[issue7559] TestLoader.loadTestsFromName swallows import errors

2010-04-03 Thread Chris Jerdonek
Chris Jerdonek chris.jerdo...@gmail.com added the comment: I think in both cases the error text should state not just what module was being imported but also what module was being imported from FYI, I filed the following report partly in response to some of the comments I made above: http

[issue7559] TestLoader.loadTestsFromName swallows import errors

2010-04-04 Thread Chris Jerdonek
Chris Jerdonek chris.jerdo...@gmail.com added the comment: This patch implements Michael's suggestion (but not the ErrorHolder part): http://bugs.python.org/issue7559#msg97462 The unit tests all pass with no change. If this approach looks good to you, I can add a unit test to the patch

[issue8297] AttributeError message text should include module name

2010-04-06 Thread Chris Jerdonek
Chris Jerdonek chris.jerdo...@gmail.com added the comment: Great -- thanks a lot for taking a stab at this! -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8297

[issue8297] AttributeError message text should include module name

2010-04-06 Thread Chris Jerdonek
Changes by Chris Jerdonek chris.jerdo...@gmail.com: -- versions: +Python 2.6 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8297 ___ ___ Python

[issue7559] TestLoader.loadTestsFromName swallows import errors

2010-04-07 Thread Chris Jerdonek
Chris Jerdonek chris.jerdo...@gmail.com added the comment: Rietveld link: http://codereview.appspot.com/810044/show This patch changes unittest.TestLoader.loadTestsFromName() so that ImportErrors will bubble up when importing from a module with a bad import statement. Before the method

[issue7559] TestLoader.loadTestsFromName swallows import errors

2010-04-07 Thread Chris Jerdonek
Chris Jerdonek chris.jerdo...@gmail.com added the comment: Thanks, David. Sorry about that. The test probably requires one additional level of nesting so that parts_copy is not False: +if not parts_copy or not module_not_found: raise

[issue7559] TestLoader.loadTestsFromName swallows import errors

2010-04-08 Thread Chris Jerdonek
Chris Jerdonek chris.jerdo...@gmail.com added the comment: FYI, there seems to be a bug in the code cited above: http://twistedmatrix.com/trac/browser/trunk/twisted/python/reflect.py#L382 For example, _importAndCheckStack('package.subpackage.module') raises _NoModuleFound in the following

[issue7559] TestLoader.loadTestsFromName swallows import errors

2010-04-08 Thread Chris Jerdonek
Chris Jerdonek chris.jerdo...@gmail.com added the comment: Four failing unit tests (context code can use clean-up). -- Added file: http://bugs.python.org/file16819/_patch-7559-4-unittests.diff ___ Python tracker rep...@bugs.python.org http

[issue7559] TestLoader.loadTestsFromName swallows import errors

2010-04-08 Thread Chris Jerdonek
Chris Jerdonek chris.jerdo...@gmail.com added the comment: The new unit tests pass with this patch (minor clean-up still needed). -- Added file: http://bugs.python.org/file16822/_patch-7559-5.diff ___ Python tracker rep...@bugs.python.org http

[issue7559] TestLoader.loadTestsFromName swallows import errors

2010-04-09 Thread Chris Jerdonek
Chris Jerdonek chris.jerdo...@gmail.com added the comment: Thanks for your suggestions on the test code. I will do that. It seems like the hard-coded approach would be more brittle. For example, if someone wants to replace __import__ with their own, e.g. old__import__ = __builtins__

[issue7559] TestLoader.loadTestsFromName swallows import errors

2010-04-09 Thread Chris Jerdonek
Chris Jerdonek chris.jerdo...@gmail.com added the comment: I think you can simplify them a bit. For example, you can use assertRaises. Actually, assertRaises doesn't seem to permit checking error text. That may be one reason why try-except-else is being used instead throughout

[issue7559] TestLoader.loadTestsFromName swallows import errors

2010-04-10 Thread Chris Jerdonek
Chris Jerdonek chris.jerdo...@gmail.com added the comment: Patch update: added unit test to cover replacing __import__, incorporated R. David Murray's suggestion to use test_support.test_cwd(), and overall code clean-up. Also uploaded as Patch 3 to-- http://codereview.appspot.com/810044/show

[issue8370] change module builtins to __builtin__ in __import__ documentation

2010-04-11 Thread Chris Jerdonek
New submission from Chris Jerdonek chris.jerdo...@gmail.com: The builtins module referenced in the Python 2.6 __import__ documentation does not seem to exist in Python 2.6: http://docs.python.org/library/functions.html#__import__ These should probably be changed to __builtin__: http

[issue8370] change module builtins to __builtin__ in __import__ documentation

2010-04-11 Thread Chris Jerdonek
Changes by Chris Jerdonek chris.jerdo...@gmail.com: -- assignee: - georg.brandl components: +Documentation nosy: +georg.brandl ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8370

[issue8370] change module builtins to __builtin__ in __import__ documentation

2010-04-11 Thread Chris Jerdonek
Chris Jerdonek chris.jerdo...@gmail.com added the comment: Replaced builtins with __builtin__. Also inserted a missing the. -- keywords: +patch Added file: http://bugs.python.org/file16870/_issue-8370-1.diff ___ Python tracker rep...@bugs.python.org

[issue8370] change module builtins to __builtin__ in __import__ documentation

2010-04-11 Thread Chris Jerdonek
Chris Jerdonek chris.jerdo...@gmail.com added the comment: Thanks for the info and quick response. Then this should probably also be applied to trunk (Python 2.7). -- versions: +Python 2.7 ___ Python tracker rep...@bugs.python.org http

[issue8370] change module builtins to __builtin__ in __import__ documentation

2010-04-11 Thread Chris Jerdonek
Chris Jerdonek chris.jerdo...@gmail.com added the comment: Would it make sense to put a New in version 3.1 at the top of this page: http://docs.python.org/py3k/library/builtins.html (perhaps also with a note explaining that the module replaces __builtin__). I actually wasn't able to confirm

[issue7559] TestLoader.loadTestsFromName swallows import errors

2010-04-13 Thread Chris Jerdonek
Changes by Chris Jerdonek chris.jerdo...@gmail.com: -- assignee: michael.foord - cjerdonek ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7559

[issue16629] IDLE: Calltips test fails due to int docstring change

2012-12-07 Thread Chris Jerdonek
Chris Jerdonek added the comment: Here is a patch, which adds multiline calltips support. Serhiy, it looks like this issue/patch is just to fix the test and not to add support. Also, it looks like the test only checks the first line, so that the second line shouldn't be added

[issue16629] IDLE: Calltips test fails due to int docstring change

2012-12-07 Thread Chris Jerdonek
Chris Jerdonek added the comment: Sorry, I see that you changed the logic of get_argspec(). In that case, you should probably update the docstring of get_argspec() as well as the code comment I referenced (so that both say which lines are checked rather than the first line

[issue16629] IDLE: Calltips test fails due to int docstring change

2012-12-07 Thread Chris Jerdonek
Chris Jerdonek added the comment: I would separate the issue of fixing the test (behavior) from adding support for multi-line tool tips (enhancement). Unless the policy for IDLE is different, it seems the latter should be limited to 3.4

[issue16629] IDLE: Calltips test fails due to int docstring change

2012-12-07 Thread Chris Jerdonek
Chris Jerdonek added the comment: I don't think it was ever a requirement of docstrings that their signature fit on one line or that they render fully in IDLE. Other built-in functions have multi-line signatures going back 10+ years (e.g. 32e7d0898eab). I still think that the rendering

[issue16638] support multi-line docstring signatures in IDLE calltips

2012-12-07 Thread Chris Jerdonek
New submission from Chris Jerdonek: This issue is to add support for rendering multi-line docstring signatures in IDLE calltips (e.g. iter(), min(), int(), etc). This was suggested by Serhiy in the comments to issue 16629. -- components: IDLE messages: 177118 nosy: chris.jerdonek

[issue16629] IDLE: Calltips test fails due to int docstring change

2012-12-07 Thread Chris Jerdonek
Chris Jerdonek added the comment: I created issue 16638 to add support for multi-line signatures. Then what about this issue? This issue is to fix the failing test. The test that is failing is to check that fetch_tip correctly returns the first line of a built-in's docstring

[issue16638] support multi-line docstring signatures in IDLE calltips

2012-12-07 Thread Chris Jerdonek
Chris Jerdonek added the comment: [Continuing a discussion/question from the issue 16629 comments] For example, why not be smarter about detecting the end of the signature (e.g. first line not having -)? The objection is that there are such signatures: foo(a, b, c, e, f, g

[issue16629] IDLE: Calltips test fails due to int docstring change

2012-12-07 Thread Chris Jerdonek
Chris Jerdonek added the comment: Yes, I think so. I should be able to get to it in the next few days unless someone else beats me to it. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16629

[issue16495] bytes_decode() unnecessarily examines encoding

2012-12-07 Thread Chris Jerdonek
Changes by Chris Jerdonek chris.jerdo...@gmail.com: -- resolution: - fixed stage: needs patch - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16495

[issue4395] Document auto __ne__ generation; provide a use case for non-trivial __ne__

2012-12-08 Thread Chris Jerdonek
Changes by Chris Jerdonek chris.jerdo...@gmail.com: -- nosy: +chris.jerdonek ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4395 ___ ___ Python

[issue16612] Integrate Argument Clinic specialized preprocessor into CPython trunk

2012-12-08 Thread Chris Jerdonek
Chris Jerdonek added the comment: It seems the clinic.txt DSL document should be proofread for proper/consistent use of argument/parameter (e.g. as described in the recently added http://docs.python.org/dev/glossary.html#term-parameter ). To choose a couple random examples-- +Argument

[issue16612] Integrate Argument Clinic specialized preprocessor into CPython trunk

2012-12-08 Thread Chris Jerdonek
Changes by Chris Jerdonek chris.jerdo...@gmail.com: -- nosy: +ezio.melotti ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16612 ___ ___ Python-bugs

[issue16406] move the Uploading Packages section to distutils/packageindex.rst

2012-12-08 Thread Chris Jerdonek
Chris Jerdonek added the comment: I've been meaning to ask Georg or anyone else knowledgeable about what options we have for redirects, etc. -- specifically for this issue. Maybe something similar can even be done using Sphinx. If we can't redirect, I was thinking even a stub page

[issue16651] Find out what stdlib modules lack a pure Python implementation

2012-12-09 Thread Chris Jerdonek
Chris Jerdonek added the comment: Would it make sense for this list to be somehow reflected in or be reconstructible from the documentation? -- nosy: +chris.jerdonek ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16651

[issue16629] IDLE: Calltips test fails due to int docstring change

2012-12-09 Thread Chris Jerdonek
Chris Jerdonek added the comment: FYI, in the 3.2 branch I get 4 failures rather than just the one due to int: $ ./python.exe Lib/idlelib/CallTips.py int - expected 'int(x[, base]) - integer' - but got 'int(x=0) - integer' list.append - expected 'L.append(object) - None -- append object to end

[issue16629] IDLE: Calltips test fails due to int docstring change

2012-12-09 Thread Chris Jerdonek
Chris Jerdonek added the comment: Thanks a lot, Roger! -- resolution: - fixed stage: patch review - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16629

[issue16655] IDLE list.append calltips test failures

2012-12-09 Thread Chris Jerdonek
New submission from Chris Jerdonek: There are three IDLE test failures in the 3.2 branch: $ ./python.exe Lib/idlelib/CallTips.py list.append - expected 'L.append(object) - None -- append object to end' - but got 'L.append(object) -- append object to end' [].append - expected 'L.append(object

[issue16629] IDLE: Calltips test fails due to int docstring change

2012-12-09 Thread Chris Jerdonek
Chris Jerdonek added the comment: I created issue 16655 for the three test failures I observed above. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16629

[issue16612] Integrate Argument Clinic specialized preprocessor into CPython trunk

2012-12-09 Thread Chris Jerdonek
Chris Jerdonek added the comment: What lines end with a colon? He probably means semicolon, for example: +int dir_fd = DEFAULT_DIR_FD; +default=None -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16612

[issue16662] load_tests not invoked in package/__init__.py

2012-12-11 Thread Chris Jerdonek
Chris Jerdonek added the comment: I think he's saying that a test package will never be discovered by default, because the default value of discover()'s pattern argument is test*.py: http://hg.python.org/cpython/file/bc322469a7a8/Lib/unittest/loader.py#l152 So I think he wants package

[issue16666] docs wrongly imply socket.getaddrinfo takes keyword arguments in 2.x

2012-12-11 Thread Chris Jerdonek
Chris Jerdonek added the comment: This might be a good place to use the newly-documented positional-only nomenclature: http://docs.python.org/2.7/glossary.html#term-parameter -- nosy: +chris.jerdonek ___ Python tracker rep...@bugs.python.org http

[issue16666] docs wrongly imply socket.getaddrinfo takes keyword arguments in 2.x

2012-12-13 Thread Chris Jerdonek
Chris Jerdonek added the comment: Is issue 13386 one of the issues you had in mind, √Čric? I don't know the current best practices for all of the signature edge cases, but Ezio might. Personally, I think explicitly stating in the text that the parameters are positional-only can't hurt

[issue16666] docs wrongly imply socket.getaddrinfo takes keyword arguments in 2.x

2012-12-13 Thread Chris Jerdonek
Chris Jerdonek added the comment: This issue only applies to 2.7. Keyword arguments are accepted in 3.x. See the interactive example here, for example: http://docs.python.org/3.2/library/socket.html#socket.getaddrinfo -- versions: -Python 2.6

[issue16655] IDLE list.append calltips test failures

2012-12-16 Thread Chris Jerdonek
Chris Jerdonek added the comment: Could you mock or monkey-patch what you are getting a tool tip for (i.e. set the external string you are checking for)? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16655

[issue11176] give more meaningful argument names in argparse documentation

2012-12-17 Thread Chris Jerdonek
Chris Jerdonek added the comment: Also see this e-mail to docs@: http://mail.python.org/pipermail/docs/2012-December/012028.html Subject: [docs] FOO and BAR Do you think it would be possible to write your documentation avoiding the silly usage of FOO and BAR everywhere? This is a very

[issue15533] subprocess.Popen(cwd) documentation

2012-12-18 Thread Chris Jerdonek
Chris Jerdonek added the comment: Hi Jan, yes, the documentation now describes the non-Windows behavior, which is different from the Windows behavior. See the comment just before yours on what still needs to be done to resolve this issue. I was in the middle of creating a bunch of test

[issue16714] Raise exceptions, don't throw

2012-12-18 Thread Chris Jerdonek
Changes by Chris Jerdonek chris.jerdo...@gmail.com: -- nosy: +chris.jerdonek ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16714 ___ ___ Python

[issue16724] Define `binary data` representation in Python

2012-12-19 Thread Chris Jerdonek
Chris Jerdonek added the comment: It will help if Python docs contained a definition of what can be considered 'binary data' and link this term from hexlify description to this definition. I believe this is part of the goal of issue 16518, where bytes-like object is being proposed as one

[issue16518] add buffer protocol to glossary

2012-12-19 Thread Chris Jerdonek
Chris Jerdonek added the comment: After this issue is resolved, the binascii docs can be updated as suggested in issue 16724. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16518

[issue16746] clarify what should be sent to peps@

2012-12-21 Thread Chris Jerdonek
New submission from Chris Jerdonek: Currently, PEP 1 can be read to mean that p...@python.org should be CC'ed on all e-mails related to PEPs. However, this isn't the intent because, for example, it is okay to have discussions about PEPs on python-dev or python-ideas without involving p

[issue16746] clarify what should be sent to peps@

2012-12-21 Thread Chris Jerdonek
Changes by Chris Jerdonek chris.jerdo...@gmail.com: -- keywords: +patch Added file: http://bugs.python.org/file28389/issue-16746-1.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16746

[issue16581] define PEP editor in PEP 1

2012-12-22 Thread Chris Jerdonek
Chris Jerdonek added the comment: Thanks a lot, Nick. It looks like you also went ahead and took care of issue 16746. :) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16581

[issue16746] clarify what should be sent to peps@

2012-12-22 Thread Chris Jerdonek
Chris Jerdonek added the comment: This issue was just addressed by Nick's fix for issue 16581, specifically the following parts of http://hg.python.org/peps/rev/24d5623ab21e : +p...@python.org is a mailing list consisting of PEP editors. All +email related to PEP administration

[issue16746] clarify what should be sent to peps@

2012-12-22 Thread Chris Jerdonek
Chris Jerdonek added the comment: By the way, thanks for the clarifying info, David. Also, I thought I was the one that was going to be accused of reading the original text like a computer. :) -- ___ Python tracker rep...@bugs.python.org http

[issue16747] Remove 'file' type reference from 'iterable' glossary entry

2012-12-22 Thread Chris Jerdonek
Chris Jerdonek added the comment: If you are changing just a few minor things, can you resubmit the patch without reflowing? It will be easier to see what minor things have changed. (It is okay to have the occasional short line to avoid having long lines. Reflowing can be done as part

[issue15302] Use argparse instead of getopt in test.regrtest

2012-12-23 Thread Chris Jerdonek
Chris Jerdonek added the comment: The reason in part is because of the lack of unit tests of regrtest (as commenters above have noted). By preserving the getopt interface, we can keep almost all of the untested code as is. You should view the patch as a first step in refactoring to use

[issue15302] Use argparse instead of getopt in test.regrtest

2012-12-23 Thread Chris Jerdonek
Chris Jerdonek added the comment: Yes, I agree with all of that but thought it would be easier to review if done incrementally as separate steps. In any case, I will look for Anton's patch on the review tool in case I have any comments

[issue15302] Use argparse instead of getopt in test.regrtest

2012-12-24 Thread Chris Jerdonek
Chris Jerdonek added the comment: Do you like to apply Chris patch and wait for next step appear? Just to clarify, I think this should read apply Chris patch after updating/reviewing. A couple file renames are needed, and I noticed a typo in a docstring. Other changes may be needed since 5

[issue15302] Use argparse instead of getopt in test.regrtest

2012-12-24 Thread Chris Jerdonek
Chris Jerdonek added the comment: why regrlib.py at all? Why isn't the code in regrtest.py? It was for a few related reasons. It was primarily to make it easier to reason about testing regrtest, and to avoid at the outset any pitfalls that might arise from the circularity of regrtest

[issue15302] Use argparse instead of getopt in test.regrtest

2012-12-24 Thread Chris Jerdonek
Chris Jerdonek added the comment: By the way, I am in the process of cleaning up the patch a bit. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15302

[issue15302] Use argparse instead of getopt in test.regrtest

2012-12-24 Thread Chris Jerdonek
Chris Jerdonek added the comment: Here is an updated, improved patch. -- Added file: http://bugs.python.org/file28422/issue-15302-3.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15302

[issue16772] int() accepts float number base

2012-12-24 Thread Chris Jerdonek
Changes by Chris Jerdonek chris.jerdo...@gmail.com: -- nosy: +chris.jerdonek ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16772 ___ ___ Python

[issue16773] int() half-accepts UserString

2012-12-24 Thread Chris Jerdonek
Changes by Chris Jerdonek chris.jerdo...@gmail.com: -- nosy: +chris.jerdonek ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16773 ___ ___ Python

[issue16761] Fix int(base=X)

2012-12-24 Thread Chris Jerdonek
Chris Jerdonek added the comment: This is good work. Thanks. I think merging test_int and test_long is hard task and should be done in separated issue. I meant share rather than merge. For the tests you're adding, isn't it simply a matter of putting the test cases into a separate mixin

[issue16772] int() accepts float number base

2012-12-25 Thread Chris Jerdonek
Chris Jerdonek added the comment: A test also needs to be added, though I'm sure one will be added as part of issue 16761. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16772

[issue14468] Update cloning guidelines in devguide

2012-12-25 Thread Chris Jerdonek
Chris Jerdonek added the comment: Note that hg graft is already mentioned/discussed in the devguide here: http://docs.python.org/devguide/committing.html#porting-between-major-versions -- ___ Python tracker rep...@bugs.python.org http

[issue16761] Fix int(base=X)

2012-12-25 Thread Chris Jerdonek
Chris Jerdonek added the comment: See this thread: http://mail.python.org/pipermail/python-dev/2012-December/123283.html -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16761

[issue16761] Fix int(base=X)

2012-12-26 Thread Chris Jerdonek
Chris Jerdonek added the comment: It's enough not to make the problem worse, which is why I suggested it and what I wanted to avoid. If you copy-paste the tests you're adding now, it worsens the problem and makes it that much more tedious to fix later on (and to maintain in the meantime

[issue16761] Fix int(base=X)

2012-12-26 Thread Chris Jerdonek
Chris Jerdonek added the comment: Yes, it is a better approach. At first glance, the patches look okay to me. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16761

[issue16784] Int tests enhancement and refactoring

2012-12-26 Thread Chris Jerdonek
Chris Jerdonek added the comment: Other things that should be done include porting the more comprehensive tests in a recent changeset from 2.7 to 3.x and refactoring the try-except of one of the tests as necessary (see the Rietveld comments of issue 16761 for details on both). The various

[issue15302] Use argparse instead of getopt in test.regrtest

2012-12-26 Thread Chris Jerdonek
Chris Jerdonek added the comment: BTW, maybe someone should create an issue for full tests coverage of regrtest? I think such an issue would need to be a meta-issue because it is a very large task (involving many patches) and may never be truly finished. Chris, would you commit it? Sure, I

[issue15302] Use argparse instead of getopt in test.regrtest

2012-12-26 Thread Chris Jerdonek
Chris Jerdonek added the comment: Benjamin, do you not want a new file at all, or are you just asking for a different name? regrlib was the previous name unless you have another suggestion. -- ___ Python tracker rep...@bugs.python.org http

[issue15302] Use argparse instead of getopt in test.regrtest

2012-12-26 Thread Chris Jerdonek
Chris Jerdonek added the comment: I'm attaching an updated patch incorporating David and Benjamin's suggestion. (Thanks a lot for the feedback, by the way.) I also added a test for the help option and refactored to avoid having to use context managers to check sys.argv, sys.stderr, etc

[issue15302] Use argparse instead of getopt in test.regrtest

2012-12-26 Thread Chris Jerdonek
Chris Jerdonek added the comment: Here is an alternative patch with a cleaner diff (keeping the help-related strings at the top before the import statements). -- Added file: http://bugs.python.org/file28449/issue-15302-5.patch ___ Python tracker rep

[issue15302] Use argparse instead of getopt in test.regrtest

2012-12-26 Thread Chris Jerdonek
Chris Jerdonek added the comment: Thanks. I replied. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15302 ___ ___ Python-bugs-list mailing list

[issue16790] provide ability to share tests between int and long tests

2012-12-26 Thread Chris Jerdonek
New submission from Chris Jerdonek: Currently, adding new int() and long() tests that are common to both requires duplicating the tests in both test_int and test_long, which makes the tests harder to review and maintain and keep in synch. Providing a simple way to share tests between test_int

[issue16790] provide ability to share tests between int and long tests

2012-12-26 Thread Chris Jerdonek
Chris Jerdonek added the comment: Attaching patch. The tests moved to SharedTestCaseMixin in this patch are tests that were very recently added (as part of issue 16045) and that are planned on being added to test_long as part of issue 16784. -- keywords: +patch Added file: http

[issue16784] Int tests enhancement and refactoring

2012-12-26 Thread Chris Jerdonek
Chris Jerdonek added the comment: I created issue 16790 to allow the sharing of tests between test_int and test_long in 2.7. I don't think issue 16761 and issue 16772 should be prerequisites to this issue though because both issues could benefit from issue 16790 being committed first (since

[issue16784] Int tests enhancement and refactoring

2012-12-26 Thread Chris Jerdonek
Chris Jerdonek added the comment: Agreed. I just didn't want it to be a requirement of beginning shared tests in case anyone objects to refactoring existing tests in 2.7 -- as opposed to using it for the addition of new tests. -- ___ Python

[issue16790] provide ability to share tests between int and long tests

2012-12-26 Thread Chris Jerdonek
Chris Jerdonek added the comment: Good point. New patch coming shortly. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16790 ___ ___ Python

[issue16772] int() accepts float number base

2012-12-26 Thread Chris Jerdonek
Chris Jerdonek added the comment: In any case the final version of those changes should be applied to 3.2 and 3.3 too (if no one objects). +1 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16772

[issue16790] provide ability to share tests between int and long tests

2012-12-26 Thread Chris Jerdonek
Chris Jerdonek added the comment: Note that we need to be more careful about checking for duplicate test names now. -- Added file: http://bugs.python.org/file28451/issue-16790-2-27.patch ___ Python tracker rep...@bugs.python.org http

[issue16790] provide ability to share tests between int and long tests

2012-12-26 Thread Chris Jerdonek
Chris Jerdonek added the comment: After this issue, the ordering of new test_int test cases in 3.x should preferably match the ordering in 2.7 for easier back-porting when the tests are new in both. For example, test_no_args() and test_keyword_args() could go at the top of 3.x's IntTestCases

[issue15302] Use argparse instead of getopt in test.regrtest

2012-12-27 Thread Chris Jerdonek
Chris Jerdonek added the comment: Updating patch after Benjamin's review. In this new patch, in test_regrtest I now use the current, actual getopt code to test and demonstrate backwards compatibility. Note that when I pasted the code, I also fixed the three typos in the current getopt code

[issue15324] --match does not work for regrtest

2012-12-27 Thread Chris Jerdonek
Chris Jerdonek added the comment: The attached patch will fix this issue as well as issue 15325 and issue 15326. Also, I'm removing issue 15302 as a superseder because that issue is limited to 3.4. The attached patch is for prior versions. (Also, it doesn't hurt to apply this to 3.4

[issue15302] Use argparse instead of getopt in test.regrtest

2012-12-27 Thread Chris Jerdonek
Chris Jerdonek added the comment: Rietveld is erroring out on me again whenever I try to reply to a comment, so I'm posting my comment here. On 2012/12/27 18:29:22, Benjamin Peterson wrote: On 2012/12/27 04:44:33, Benjamin Peterson wrote: if val: Again, we need this to match getopt

[issue16790] provide ability to share tests between int and long tests

2012-12-27 Thread Chris Jerdonek
Chris Jerdonek added the comment: Thanks for the reviews, Serhiy. -- resolution: - fixed stage: patch review - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16790

[issue16793] Get rid of deprecated assertEquals etc in tests

2012-12-27 Thread Chris Jerdonek
Changes by Chris Jerdonek chris.jerdo...@gmail.com: -- nosy: +chris.jerdonek ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16793 ___ ___ Python

[issue16792] Mark small ints test as CPython-only

2012-12-27 Thread Chris Jerdonek
Changes by Chris Jerdonek chris.jerdo...@gmail.com: -- nosy: +chris.jerdonek ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16792 ___ ___ Python

[issue16793] Get rid of deprecated assertEquals etc in tests

2012-12-27 Thread Chris Jerdonek
Chris Jerdonek added the comment: LGTM. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16793 ___ ___ Python-bugs-list mailing list Unsubscribe

[issue16761] Fix int(base=X)

2012-12-27 Thread Chris Jerdonek
Chris Jerdonek added the comment: When this patch is updated because of the commit for issue 16790, in 3.x can the edited test cases be moved to the top of the test class per the following comment (as appropriate)? http://bugs.python.org/issue16790#msg178282 As stated there, this will make

[issue15324] --fromfile, --match, and --randomize don't work in regrtest

2012-12-27 Thread Chris Jerdonek
Changes by Chris Jerdonek chris.jerdo...@gmail.com: -- title: --match does not work for regrtest - --fromfile, --match, and --randomize don't work in regrtest ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15324

[issue15325] --fromfile does not work for regrtest

2012-12-27 Thread Chris Jerdonek
Changes by Chris Jerdonek chris.jerdo...@gmail.com: -- resolution: - duplicate stage: patch review - committed/rejected status: open - closed superseder: Use argparse instead of getopt in test.regrtest - --fromfile, --match, and --randomize don't work in regrtest

[issue15326] --random does not work for regrtest

2012-12-27 Thread Chris Jerdonek
Changes by Chris Jerdonek chris.jerdo...@gmail.com: -- resolution: - duplicate stage: patch review - committed/rejected status: open - closed superseder: Use argparse instead of getopt in test.regrtest - --fromfile, --match, and --randomize don't work in regrtest versions: +Python 2.7

[issue16599] unittest: Access test result from tearDown

2012-12-27 Thread Chris Jerdonek
Chris Jerdonek added the comment: I agree with Serhiy here. This use case seems too specialized, and there are easy ways to achieve the same thing in code. -- nosy: +chris.jerdonek ___ Python tracker rep...@bugs.python.org http://bugs.python.org

  1   2   3   4   5   6   7   8   9   10   >