[issue32275] SSL socket methods don't retry on EINTR?

2021-06-11 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- nosy: +erlendaasland ___ Python tracker <https://bugs.python.org/issue32275> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue44389] Modules/_ssl.c, repeated 'SSL_OP_NO_TLSv1_2'

2021-06-11 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- keywords: +patch nosy: +erlendaasland nosy_count: 1.0 -> 2.0 pull_requests: +25266 stage: -> patch review pull_request: https://github.com/python/cpython/pull/26680 ___ Python tracker <https://bugs.p

[issue44418] unicodedata.ucnhash_CAPI removed from Python 3.10 without deprecation

2021-06-14 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: It's not removed, it's renamed (by 84f7382215b9e024a5590454726b6ae4b0ca70a0, GH-22994, bpo-42157). You can access it using the '_ucnhash_CAPI' attribute. -- nosy: +erlendaasland ___ Python tracker <ht

[issue44430] [sqlite3] refactor threading tests

2021-06-15 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- keywords: +patch pull_requests: +25333 stage: -> patch review pull_request: https://github.com/python/cpython/pull/26748 ___ Python tracker <https://bugs.python.org/issu

[issue44418] unicodedata.ucnhash_CAPI removed from Python 3.10 without deprecation

2021-06-14 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: Sounds like an easy solution is to open an issue/PR against rust-cpython to update the doctest, IMO. -- ___ Python tracker <https://bugs.python.org/issue44

[issue44430] [sqlite3] refactor threading tests

2021-06-15 Thread Erlend E. Aasland
New submission from Erlend E. Aasland : The threading tests (ThreadTests) in Lib/sqlite3/test/dbapi.py has a lot of code duplication, and none of the test methods use the test.support.threading_helper.reap_threads helper. Also, some branches are not covered by this test class. Suggesting

[issue42064] Convert sqlite3 to multi-phase initialisation (PEP 489)

2021-06-15 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- pull_requests: +25330 pull_request: https://github.com/python/cpython/pull/26745 ___ Python tracker <https://bugs.python.org/issue42

[issue41930] Wrap sqlite3_serialize API in sqlite3 module

2021-06-14 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: > What would be the use case for this? Quoting D. Richard Hipp, from the sqlite-users mailing list, 2018-03-18, FWIW: These APIs support the concept of using small databases (small enough to fit in memory) as a container for passing information aro

[issue41930] Wrap sqlite3_serialize API in sqlite3 module

2021-06-14 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- keywords: +patch pull_requests: +25318 stage: -> patch review pull_request: https://github.com/python/cpython/pull/26728 ___ Python tracker <https://bugs.python.org/issu

[issue44430] [sqlite3] refactor threading tests

2021-06-16 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: The current code duplication has several negative impacts, IMO: - Readability Currently the ThreadTests class spans 173 lines. Refactored, it spans 51 lines (should fit in a screenful), making it easy to see what's actually being tested. Currently

[issue44434] _thread module: Remove redundant PyThread_exit_thread() call to avoid glibc fatal error: libgcc_s.so.1 must be installed for pthread_cancel to work

2021-06-16 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- nosy: +erlendaasland ___ Python tracker <https://bugs.python.org/issue44434> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue44360] test_compile segfault on AMD64 Ubuntu 3.x

2021-06-09 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- nosy: +erlendaasland ___ Python tracker <https://bugs.python.org/issue44360> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue44361] test_smtpnet failed with SMTPServerDisconnected on x86 Gentoo Non-Debug with X 3.10

2021-06-09 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- nosy: +erlendaasland ___ Python tracker <https://bugs.python.org/issue44361> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue44359] test_ftplib fails as "env changes" if a socket operation times out in a thread: TimeoutError is not catched

2021-06-09 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- nosy: +erlendaasland ___ Python tracker <https://bugs.python.org/issue44359> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue39573] [C API] Make PyObject an opaque structure in the limited C API

2021-06-07 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- nosy: +erlendaasland ___ Python tracker <https://bugs.python.org/issue39573> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue44360] test_compile segfault on AMD64 Ubuntu 3.x

2021-06-09 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: Isn't this just an (explicit) SIGKILL? The _exit code_ seems to be -9, not the signal number. -- ___ Python tracker <https://bugs.python.org/issue44

[issue42213] Get rid of cyclic GC hack in sqlite3.Connection and sqlite3.Cache

2021-06-07 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: Thanks, Victor :) -- ___ Python tracker <https://bugs.python.org/issue42213> ___ ___ Python-bugs-list mailing list Unsub

[issue33450] unexpected EPROTOTYPE returned by sendto on MAC OSX

2021-06-12 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- nosy: +erlendaasland ___ Python tracker <https://bugs.python.org/issue33450> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue44389] Modules/_ssl.c, repeated 'SSL_OP_NO_TLSv1_2'

2021-06-12 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: Ah, I see now that it's deprecated in the docs as well: https://docs.python.org/3/library/ssl.html#ssl.OP_NO_TLSv1_3 -- ___ Python tracker <https://bugs.python.org/issue44

[issue44389] Modules/_ssl.c, repeated 'SSL_OP_NO_TLSv1_2'

2021-06-12 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue44389] Modules/_ssl.c, repeated 'SSL_OP_NO_TLSv1_2'

2021-06-12 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: Thanks for the report, Brother Beer. -- ___ Python tracker <https://bugs.python.org/issue44389> ___ ___ Python-bugs-list m

[issue44389] Modules/_ssl.c, repeated 'SSL_OP_NO_TLSv1_2'

2021-06-12 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- pull_requests: +25284 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/26699 ___ Python tracker <https://bugs.python.org/issu

[issue44389] Modules/_ssl.c, repeated 'SSL_OP_NO_TLSv1_2'

2021-06-12 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: But TLSv1.3 is included in openssl 1.1.1, no? -- ___ Python tracker <https://bugs.python.org/issue44389> ___ ___ Python-bug

[issue44389] Modules/_ssl.c, repeated 'SSL_OP_NO_TLSv1_2'

2021-06-12 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: Yes, and judging from PEP 644, I figured the TLSv1.3 flag was _not_ deprecated. Sorry for the misunderstanding/noise. -- ___ Python tracker <https://bugs.python.org/issue44

[issue44389] Modules/_ssl.c, repeated 'SSL_OP_NO_TLSv1_2'

2021-06-12 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: Let me know if you want me to open a PR that adds the correct flag and adds deprecation wrappers to the tests. -- ___ Python tracker <https://bugs.python.org/issue44

[issue44389] Modules/_ssl.c, repeated 'SSL_OP_NO_TLSv1_2'

2021-06-13 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: Thanks, Christian. -- ___ Python tracker <https://bugs.python.org/issue44389> ___ ___ Python-bugs-list mailing list Unsub

[issue44444] How can track and trace your parcel live?

2021-06-17 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- resolution: -> not a bug stage: -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue40956] Use Argument Clinic in sqlite3

2021-06-20 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: > Erlend, is anything left in this issue? Nothing left; thank you for your guidance and reviews, Dong-hee, Berker, Serhiy, and Pablo. -- resolution: -> fixed stage: patch review -> resolved status: open

[issue44087] [sqlite3] consider adding Py_TPFLAGS_DISALLOW_INSTANTIATION to sqlite3.Statement

2021-06-20 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- pull_requests: +25397 pull_request: https://github.com/python/cpython/pull/26816 ___ Python tracker <https://bugs.python.org/issue44

[issue43916] Mark static types newly converted to heap types as immutable: add Py_TPFLAGS_DISALLOW_INSTANTIATION type flag

2021-06-20 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: FYI, bpo-44087 added the Py_TPFLAGS_DISALLOW_INSTANTIATION flag to sqlite3.Statement. (Side note: I find the issue title a little bit confusing.) -- ___ Python tracker <https://bugs.python.org/issue43

[issue44087] [sqlite3] consider adding Py_TPFLAGS_DISALLOW_INSTANTIATION to sqlite3.Statement

2021-06-20 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue20178] Derby #9: Convert 52 sites to Argument Clinic across 11 files

2021-06-22 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: FYI, sqlite3 was converted to Argument Clinic in bpo-40956. -- ___ Python tracker <https://bugs.python.org/issue20

[issue44491] [sqlite3] allow clearing the authoriser callback

2021-06-22 Thread Erlend E. Aasland
New submission from Erlend E. Aasland : Currently, it is possible to clear both the sqlite3 trace callback and progress handler by passing 'None' as the callback/handler, however it is not possible to clear the authoriser callback. Suggesting to allow clearing the authoriser callback

[issue44491] [sqlite3] allow clearing the authoriser callback

2021-06-22 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- keywords: +patch pull_requests: +25438 stage: -> patch review pull_request: https://github.com/python/cpython/pull/26863 ___ Python tracker <https://bugs.python.org/issu

[issue44499] [sqlite3] make sqlite3.Connection exception refs strong

2021-06-23 Thread Erlend E. Aasland
New submission from Erlend E. Aasland : Currently, pysqlite_Connection keeps borrowed references to all the sqlite3 exception types. Suggesting to convert these to strong refs. See comments on GH-26745: https://github.com/python/cpython/pull/26745#issuecomment-866810269 -- assignee

[issue42862] Use functools.lru_cache iso. _sqlite.Cache in sqlite3 module

2021-06-23 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- pull_requests: +25452 pull_request: https://github.com/python/cpython/pull/26876 ___ Python tracker <https://bugs.python.org/issue42

[issue44229] test_ssl: test_get_server_certificate() and test_msg_callback_deadlock_bpo43577() fail randomly on the macOS CI

2021-06-23 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: Has these issues (ConnectionRefusedError/ConnectionResetError during handshake) been reported on other systems than macOS? AFAICS, they've only been reported for the macOS CI. -- ___ Python tracker <ht

[issue44229] test_ssl: test_get_server_certificate() and test_msg_callback_deadlock_bpo43577() fail randomly on the macOS CI

2021-06-23 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: See also bpo-33450. -- ___ Python tracker <https://bugs.python.org/issue44229> ___ ___ Python-bugs-list mailing list Unsub

[issue42064] Convert sqlite3 to multi-phase initialisation (PEP 489)

2021-06-23 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- pull_requests: +25462 pull_request: https://github.com/python/cpython/pull/26884 ___ Python tracker <https://bugs.python.org/issue42

[issue43988] Add test.support.check_disallow_instantiation()

2021-06-23 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- pull_requests: +25463 pull_request: https://github.com/python/cpython/pull/26885 ___ Python tracker <https://bugs.python.org/issue43

[issue43988] Add test.support.check_disallow_instantiation()

2021-06-23 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- resolution: fixed -> status: closed -> open versions: +Python 3.10 ___ Python tracker <https://bugs.python.org/i

[issue43553] [sqlite3] Improve test coverage

2021-06-23 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- pull_requests: +25464 stage: -> patch review pull_request: https://github.com/python/cpython/pull/26886 ___ Python tracker <https://bugs.python.org/issu

[issue42064] Convert sqlite3 to multi-phase initialisation (PEP 489)

2021-06-21 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- pull_requests: +25421 pull_request: https://github.com/python/cpython/pull/26840 ___ Python tracker <https://bugs.python.org/issue42

[issue44484] test_concurrent_futures: failure on Windows (x64)

2021-06-22 Thread Erlend E. Aasland
New submission from Erlend E. Aasland : https://github.com/python/cpython/pull/26840/checks?check_run_id=2879802998 2021-06-21T22:34:41.2973359Z Current runner version: '2.278.0' 2021-06-21T22:34:41.3112811Z ##[group]Operating System 2021-06-21T22:34:41.3113619Z Microsoft Windows Server 2019

[issue41682] [Windows] test_asyncio: Proactor test_sendfile_close_peer_in_the_middle_of_receiving failure

2021-06-24 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: Two new failures today: https://github.com/python/cpython/runs/2905621215: 2021-06-24T14:18:23.3772681Z == 2021-06-24T14:18:23.3773622Z FAIL

[issue44506] test_asyncio: test_sendfile_close_peer_in_the_middle_of_receiving fails on Windows x64 and x86

2021-06-24 Thread Erlend E. Aasland
New submission from Erlend E. Aasland : https://github.com/python/cpython/runs/2905621215: 2021-06-24T14:18:23.3772681Z == 2021-06-24T14:18:23.3773622Z FAIL: test_sendfile_close_peer_in_the_middle_of_receiving

[issue44506] test_asyncio: test_sendfile_close_peer_in_the_middle_of_receiving fails on Windows x64 and x86

2021-06-24 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- resolution: -> duplicate stage: -> resolved status: open -> closed superseder: -> [Windows] test_asyncio: Proactor test_sendfile_close_peer_in_the_middle_of_receiving failure ___ Python tra

[issue44229] test_ssl: test_get_server_certificate() and test_msg_callback_deadlock_bpo43577() fail randomly on the macOS CI

2021-06-24 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: I can reproduce these issues easily on 3.7, 3.8, and 3.9: $ python3.7 -m test test_ssl -u all -F -m test_get_server_certificate -v [...] test_get_server_certificate (test.test_ssl.SimpleBackgroundTests) ... server: new connection from ('127.0.0.1

[issue44229] test_ssl: test_get_server_certificate() and test_msg_callback_deadlock_bpo43577() fail randomly on the macOS CI

2021-06-24 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: Marking bpo-44237 as a duplicate of this issue. -- ___ Python tracker <https://bugs.python.org/issue44229> ___ ___ Pytho

[issue44229] test_ssl: test_get_server_certificate() and test_msg_callback_deadlock_bpo43577() fail randomly on the macOS CI

2021-06-24 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: Marking bpo-43855 as a duplicate of this issue. -- ___ Python tracker <https://bugs.python.org/issue44229> ___ ___ Pytho

[issue44237] test_ssl randomly fails on macOS GH Action: test_get_server_certificate_sni() and test_get_server_certificate_timeout()

2021-06-24 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: Marking this as a duplicate of bpo-44229. Please revert if you disagree. -- dependencies: -test_ssl: test_get_server_certificate() and test_msg_callback_deadlock_bpo43577() fail randomly on the macOS CI resolution: -> duplicate st

[issue43855] test_ssl: test_msg_callback_deadlock_bpo43577() failed on macOS of GitHub Action

2021-06-24 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: Closing as a duplicate of bpo-44229. Please revert if you disagree. -- resolution: -> duplicate stage: -> resolved status: open -> closed superseder: -> test_ssl: test_get_server_certificate() and test_msg_callback_deadlock_bpo

[issue43553] [sqlite3] Improve test coverage

2021-06-24 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue44229] test_ssl: test_get_server_certificate() and test_msg_callback_deadlock_bpo43577() fail randomly on the macOS CI

2021-06-24 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: FYI, here's a CI failure against 3.9: https://github.com/python/cpython/runs/2894813367?check_suite_focus=true -- ___ Python tracker <https://bugs.python.org/issue44

[issue44229] test_ssl: test_get_server_certificate() and test_msg_callback_deadlock_bpo43577() fail randomly on the macOS CI

2021-06-24 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- keywords: +patch pull_requests: +25469 stage: -> patch review pull_request: https://github.com/python/cpython/pull/26893 ___ Python tracker <https://bugs.python.org/issu

[issue33450] unexpected EPROTOTYPE returned by sendto on MAC OSX

2021-06-24 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: See also bpo-44229. -- ___ Python tracker <https://bugs.python.org/issue33450> ___ ___ Python-bugs-list mailing list Unsub

[issue44360] test_compile killed by SIGKILL on AMD64 Ubuntu 3.x

2021-06-09 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: Oh, right, there is of course a connection between the exit code and the signal number. Thanks for the reminder :) -- ___ Python tracker <https://bugs.python.org/issue44

[issue44431] Add command-line functionality to uuid module

2021-06-16 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- nosy: +erlendaasland ___ Python tracker <https://bugs.python.org/issue44431> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue38211] clean up type_init()

2021-06-17 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: I'm marking this as closed/fixed. Mark, please reopen if you disagree :) -- nosy: +erlendaasland resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracke

[issue44329] [sqlite3] refactor pysqlite_statement_create

2021-06-08 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue44106] [sqlite3] don't use politicians in examples/docs

2021-05-10 Thread Erlend E. Aasland
New submission from Erlend E. Aasland : In GH-25003, we rewrote one of the database examples to use programming languages iso. political persons. However, there are still some politicians lurking in the sqlite3 docs. Suggesting to get rid of those as well. See also Berker's comment: https

[issue44092] [sqlite3] consider removing special rollback handling

2021-05-10 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- pull_requests: +24676 stage: -> patch review pull_request: https://github.com/python/cpython/pull/26026 ___ Python tracker <https://bugs.python.org/issu

[issue33376] [pysqlite] Duplicate rows can be returned after rolling back a transaction

2021-05-10 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: I believe the former proposed solution is the correct solution. I'm digging though the pysqlite git history (both in the original repo and in CPython), the SQLite changelogs, and different test suites to prove me wrong :) I'm using bpo-44092 to track my

[issue44106] [sqlite3] don't use politicians in examples/docs

2021-05-10 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- keywords: +patch pull_requests: +24677 stage: -> patch review pull_request: https://github.com/python/cpython/pull/26027 ___ Python tracker <https://bugs.python.org/issu

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

2021-05-13 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- pull_requests: +24746 pull_request: https://github.com/python/cpython/pull/26104 ___ Python tracker <https://bugs.python.org/issue42

[issue28528] Pdb.checkline() attribute error when 'curframe' is None

2021-05-12 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: Yes, test.os_helper was introduced in 3.10. I've manually cherry-picked 8563a7052ccd98e6a381d361664ce567afd5eb6e to 3.9 (GH-26053). -- ___ Python tracker <https://bugs.python.org/issue28

[issue28528] Pdb.checkline() attribute error when 'curframe' is None

2021-05-12 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- pull_requests: +24693 pull_request: https://github.com/python/cpython/pull/26053 ___ Python tracker <https://bugs.python.org/issue28

[issue44108] [sqlite3] normalise SQL quoted literals in sqlite3 test suite

2021-05-11 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- keywords: +patch pull_requests: +24680 stage: -> patch review pull_request: https://github.com/python/cpython/pull/26032 ___ Python tracker <https://bugs.python.org/issu

[issue44108] [sqlite3] normalise SQL quoted literals in sqlite3 test suite

2021-05-11 Thread Erlend E. Aasland
New submission from Erlend E. Aasland : Most of the SQL statements in the sqlite3 test suite correctly uses single quote literals, except test_unicode_content in Lib/sqlite3/test/hooks.py, which uses double quote literals (not ANSI SQL compatible, IIRC). Adapting this test to also use single

[issue44108] [sqlite3] normalise SQL quoted literals in sqlite3 test suite

2021-05-11 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: Digression: test_unicode_content should be named test_trace_unicode_content, in order to express the purpose of the test more clearly, should it fail. -- ___ Python tracker <https://bugs.python.org/issue44

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

2021-05-13 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- pull_requests: +24759 pull_request: https://github.com/python/cpython/pull/26114 ___ Python tracker <https://bugs.python.org/issue42

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

2021-05-13 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: I've added a checkbox for types that fully implement the GC protocol to https://discuss.python.org/t/list-of-built-in-types-converted-to-heap-types/8403/1. Heap types that fully implement the GC protocol: * _abc._abc_data * _bz2.BZ2Compressor * _bz2

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

2021-05-13 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- pull_requests: -23226 ___ Python tracker <https://bugs.python.org/issue42972> ___ ___ Python-bugs-list mailing list Unsub

[issue44106] [sqlite3] don't use politicians in examples/docs

2021-05-11 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: Ditto for Doc/includes/sqlite3/insert_more_people.py -- ___ Python tracker <https://bugs.python.org/issue44106> ___ ___

[issue44106] [sqlite3] don't use politicians in examples/docs

2021-05-11 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: Berker, the following files are not included by Doc/library/sqlite3.rst: - Doc/includes/sqlite3/countcursors.py - Doc/includes/sqlite3/createdb.py # never referenced by docs - Doc/includes/sqlite3/execsql_fetchonerow.py - Doc/includes/sqlite3

[issue42862] Use functools.lru_cache iso. _sqlite.Cache in sqlite3 module

2021-05-14 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- versions: +Python 3.11 -Python 3.10 ___ Python tracker <https://bugs.python.org/issue42862> ___ ___ Python-bugs-list mailin

[issue44147] [WinError 193] %1 is not a valid Win32 application

2021-05-18 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: Eryk, Steve, can we close this? AFAICT, this belongs to a user forum. Shreyan: it seems like a bpo bug to me. I have a feeling closing the issue will help. -- ___ Python tracker <https://bugs.python.

[issue35889] sqlite3.Row doesn't have useful repr

2021-05-18 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: > What about a __repr__ that includes the primary key value(s) (for tables > where that is defined)? I’d rather have that as a Row method, or read-only property. It should be straight-forward to implement. SQLite provides an API for such pu

[issue35889] sqlite3.Row doesn't have useful repr

2021-05-18 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: See: - https://www.sqlite.org/c3ref/column_database_name.html - https://www.sqlite.org/c3ref/table_column_metadata.html Notice that the former is only available if SQLITE_ENABLE_COLUMN_METADATA was defined at compile time

[issue44147] [WinError 193] %1 is not a valid Win32 application

2021-05-18 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: Setting status to pending again. (Seems like bpo likes this dance) -- nosy: +erlendaasland status: open -> pending ___ Python tracker <https://bugs.python.org/issu

[issue30593] sqlite3 executescript does not respect isolation_level?

2021-05-18 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: Mentioning this behaviour in the documentation should be sufficient. -- assignee: -> docs@python components: +Documentation -Library (Lib) nosy: +berker.peksag, docs@python, erlendaasland versions: +Python 3.10, Python 3.11, Python 3.9 -Python

[issue30593] Document that sqlite3.Cursor.executescript disregards isolation_level

2021-05-18 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- title: sqlite3 executescript does not respect isolation_level? -> Document that sqlite3.Cursor.executescript disregards isolation_level ___ Python tracker <https://bugs.python.org/issu

[issue30593] sqlite3 executescript does not respect isolation_level?

2021-05-18 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- pull_requests: +24837 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/26220 ___ Python tracker <https://bugs.python.org/issu

[issue27334] [sqlite3] context manager leaves db locked if commit fails in __exit__

2021-05-18 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: > I believe the reason for this problem is that the exception happened in the > implicit `commit` that is run on exiting the context manager, rather than > inside it. In fact the exception is in the `pass` line rather than in the > `e

[issue44079] [sqlite3] remove superfluous statement weak ref list from connection object

2021-05-19 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: Yes, that seems to be the intention. But, I don't think there is a need to maintain the second list: 1. Resetting statements was historically needed both for commit and rollback; pending statements would block such operations. That's no longer the case

[issue44092] [sqlite3] consider removing special rollback handling

2021-05-19 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- Removed message: https://bugs.python.org/msg393339 ___ Python tracker <https://bugs.python.org/issue44092> ___ ___ Python-bug

[issue44092] [sqlite3] consider removing special rollback handling

2021-05-19 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- Removed message: https://bugs.python.org/msg393367 ___ Python tracker <https://bugs.python.org/issue44092> ___ ___ Python-bug

[issue44092] [sqlite3] consider removing special rollback handling

2021-05-19 Thread Erlend E. Aasland
Change by Erlend E. Aasland : Removed file: https://bugs.python.org/file50029/patch.diff ___ Python tracker <https://bugs.python.org/issue44092> ___ ___ Python-bug

[issue44106] [sqlite3] don't use politicians in examples/docs

2021-05-19 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- pull_requests: +24851 pull_request: https://github.com/python/cpython/pull/26234 ___ Python tracker <https://bugs.python.org/issue44

[issue21465] sqlite3 Row can return duplicate keys when using adapters

2021-05-19 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: AFAICS, this has nothing to do with adapters; you'll get duplicate keys just by executing 'select 1 as "token", 2 as "token"'. If you want the columns to have unique names, you should assign them unique names. At most, there could

[issue44106] [sqlite3] don't use politicians in examples/docs

2021-05-19 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue10513] sqlite3.InterfaceError after commit

2021-05-07 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: I cannot reproduce this with Python 3.8, 3.9, nor 3.10 (macOS builds from python.org). Suggesting to close this. -- nosy: +erlendaasland status: open -> pending ___ Python tracker <https://bugs.pyth

[issue44079] [sqlite3] optimisation: remove statement weak ref list from connection object

2021-05-08 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: Berker/Serhiy, weak ref. list question: Could also the pysqlite_Statement.in_weakreflist member go? Seems to be ok: $ git diff --shortstat 3 files changed, 13 insertions(+), 72 deletions(-) $ ./python.exe -m test -R : test_sqlite 0:00:00 load avg: 0.83

[issue43992] Unable to get external dependencies for CPython on Ubuntu Linux 20.04.1

2021-05-08 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: Here's a trick I often recommend: Do as the CI; use the posix-deps-apt.sh script! You'll find it in your CPython git repo: $ cd cpython.git # change working dir to the CPython git repo $ cat .github/workflows/posix-deps-apt.sh #!/bin/sh apt-get update

[issue44079] [sqlite3] optimisation: remove statement weak ref list from connection object

2021-05-08 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- keywords: +patch pull_requests: +24651 stage: -> patch review pull_request: https://github.com/python/cpython/pull/25998 ___ Python tracker <https://bugs.python.org/issu

[issue44079] [sqlite3] remove superfluous statement weak ref list from connection object

2021-05-08 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- title: [sqlite3] optimisation: remove statement weak ref list from connection object -> [sqlite3] remove superfluous statement weak ref list from connection object ___ Python tracker <https://bugs.pyth

[issue44079] [sqlite3] optimisation: remove statement weak ref list from connection object

2021-05-08 Thread Erlend E. Aasland
New submission from Erlend E. Aasland : Today, the sqlite3 extension module keeps two[1] lists of statements: 1. The statement cache[2], stored in pysqlite_Connection.statement_cache 2. A weak ref. list (hard coded limited to 200 statements in _pysqlite_drop_unused_statement_references

[issue44087] [sqlite3] consider adding Py_TPFLAGS_DISALLOW_INSTANTIATION to sqlite3.Statement

2021-05-09 Thread Erlend E. Aasland
New submission from Erlend E. Aasland : Currently, the sqlite3.Statement type is not exposed in the module dict: >>> import sqlite3 >>> sqlite3.Statement Traceback (most recent call last): File "", line 1, in File "/Library/Frameworks/Python.framework/Ver

[issue41930] Wrap sqlite3_serialize API in sqlite3 module

2021-05-09 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: What would be the use case for this? -- nosy: +erlendaasland ___ Python tracker <https://bugs.python.org/issue41

[issue22956] Improved support for prepared SQL statements

2021-05-09 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: As Gerhard said in msg233384, there is already a statement cache. sqlite3_prepare_v2() is only called if the statement is not found in the cache. Current behaviour: >>> import sqlite3 >>> cx = sqlite3.connect(":memor

  1   2   3   4   5   6   >