Change by Erlend Egeberg Aasland :
--
pull_requests: +14686
pull_request: https://github.com/python/cpython/pull/14911
___
Python tracker
<https://bugs.python.org/issue37
Change by Erlend Egeberg Aasland :
--
components: +macOS
nosy: +ned.deily, ronaldoussoren
___
Python tracker
<https://bugs.python.org/issue37653>
___
___
Pytho
New submission from Erlend Egeberg Aasland :
Make install is broken in subtarget libinstall. This was introduced with commit
e8692818afd731c1b7e925c626ac8200b1f1c31e.
Fix in attached patch.
--
components: Build
files: fix.patch
keywords: patch
messages: 348300
nosy: Erlend Egeberg
Erlend Egeberg Aasland added the comment:
Update: Tested on macOS 10.14.6 with make test on 2.7.17rc1, 3.7.5rc1+,
3.8.0rc1+.
--
___
Python tracker
<https://bugs.python.org/issue38
Erlend Egeberg Aasland added the comment:
I've prepared a PR for https://github.com/python/cpython-source-deps at
https://github.com/erlend-aasland/cpython-source-deps/tree/upgrade-sqlite.
Patches for Windows and macOS installer builds on 3.9 prepared at
https://github.com/erlend-aasland
Erlend Egeberg Aasland added the comment:
bpo-38380: Update macOS installer to use SQLite 3.30.0
https://github.com/erlend-aasland/cpython/commit/aa7d7b1a3bed9a6a73f0611d0542a3442e85b0b6
--
keywords: +patch
Added file:
https://bugs.python.org/file48651/0001-bpo-38380-Update-macOS
Erlend Egeberg Aasland added the comment:
bpo-38380: Update Windows builds to use SQLite 3.30.0
https://github.com/erlend-aasland/cpython/commit/e25214e6fa7a64353d9c3e16b139c41f5d62eb31
--
Added file:
https://bugs.python.org/file48652/0002-bpo-38380-Update-Windows-builds-to-use
Erlend Egeberg Aasland added the comment:
FYI: Compiled cpython 3.9 with sqlite-3.30 on macOS 10.14.6. Make test
completes without errors.
--
___
Python tracker
<https://bugs.python.org/issue38
Erlend Egeberg Aasland added the comment:
I agree. I've updated the branches for source deps and cpython. I'll wait for
Steve's approval before I open a new PR over at cpython-source-deps and update
GH-18678.
--
___
Python tracker
<ht
Change by Erlend Egeberg Aasland :
Removed file:
https://bugs.python.org/file48932/0001-bpo-38780-Harden-socket-use-in-logging.handlers.patch
___
Python tracker
<https://bugs.python.org/issue38
Erlend Egeberg Aasland added the comment:
You're welcome. If you are ok with that, I'd be happy to prepare a PR for the
source deps for sqlite3 v3.31.1, and update GH-18678 as soon as it is tagged.
--
___
Python tracker
<https://bugs.python.
Change by Erlend Egeberg Aasland :
Added file:
https://bugs.python.org/file48933/0001-bpo-38780-Harden-socket-use-in-logging.handlers.patch
___
Python tracker
<https://bugs.python.org/issue38
Erlend Egeberg Aasland added the comment:
Yes, we need the tag for the Windows build, so the PR currently fails the
Windows checks. (Tagging must be done explicitly by the maintainers, IIRC.) I
also forgot to add a NEWS entry, so I'll do another push to add those (and kick
off the CI) when
Erlend Egeberg Aasland added the comment:
Attached patch is based on Ronald Oussoren's and Alan Robertson's comments:
Initialise self.socket to None early in __init()__, and then check for None in
close() and emit(). Passes make test on 3.9, 3.8 and 3.7.
If this solution is ok I'll add
Erlend Egeberg Aasland added the comment:
I'm a bit uncertain if the previous patch can handle the emit() case correctly.
Proposed improvement in attached patch (0002-Improve-emit.patch).
--
Added file: https://bugs.python.org/file48934/0002-Improve-emit.patch
Erlend Egeberg Aasland added the comment:
Understood; I’ll remember it for future PRs. Thanks for clarifying.
--
___
Python tracker
<https://bugs.python.org/issue38
Erlend Egeberg Aasland added the comment:
Great, thanks folks! I've pushed an update to GH-18678.
(BTW, is it kosher to force push to PRs like this?)
--
___
Python tracker
<https://bugs.python.org/issue38
Change by Erlend Egeberg Aasland :
--
title: Update SQLite to 3.30 in Windows and macOS installer builds -> Update
SQLite to 3.31.1 in Windows and macOS installer builds
___
Python tracker
<https://bugs.python.org/issu
Erlend Egeberg Aasland added the comment:
I've rebased Catherine Devlin's patch onto 3.9 (and adjusted the docs a tiny
bit). If anyone still is interested, I can create a PR (for 3.9) for this.
--
nosy: +erlendaasland
Added file:
https://bugs.python.org/file48936/0001-bpo-24518
Change by Erlend Egeberg Aasland :
--
nosy: +erlendaasland
___
Python tracker
<https://bugs.python.org/issue35569>
___
___
Python-bugs-list mailing list
Unsub
Erlend Egeberg Aasland added the comment:
> I wrote a whole new page for -X dev:
> https://docs.python.org/dev/library/devmode.html#devmode
That's nice, but references for PYTHONFAULTHANDLER and PYTHONTRACEMALLOC are
still missing. If you think the cross refs for -X dev and PYTHOND
Erlend Egeberg Aasland added the comment:
Proposed patch attached.
--
keywords: +patch
Added file:
https://bugs.python.org/file48937/0001-bpo-35569-Expose-RFC-3542-socket-options-on-macOS.patch
___
Python tracker
<https://bugs.python.
Change by Erlend Egeberg Aasland :
--
nosy: +erlendaasland
___
Python tracker
<https://bugs.python.org/issue39851>
___
___
Python-bugs-list mailing list
Unsub
Change by Erlend Egeberg Aasland :
--
nosy: +erlendaasland
___
Python tracker
<https://bugs.python.org/issue39844>
___
___
Python-bugs-list mailing list
Unsub
Erlend Egeberg Aasland added the comment:
Cool. Should I remove Python-3.* from the Versions label, so it doesn't show up
in searches for 3.* issues?
--
___
Python tracker
<https://bugs.python.org/issue38
Erlend Egeberg Aasland added the comment:
Ah, but you're all set @steve.dower, someone at cpython-source-deps already
pulled my tags: https://github.com/python/cpython-source-deps/tags :)
But I guess that if I were to do the same maneouver again, it would probably be
preferable if I made
Erlend Egeberg Aasland added the comment:
Would you prefer that I close GH_18678 and split it up in separate RPs for
macOS and Windows?
--
___
Python tracker
<https://bugs.python.org/issue38
Erlend Egeberg Aasland added the comment:
Ok, thanks for your patience and time. I'll fix the NEWS entries right away.
--
___
Python tracker
<https://bugs.python.org/issue38
Erlend Egeberg Aasland added the comment:
I've created a patch that applies fine to 3.7, 3.8 and 3.9, if anyone still is
interested.
(Backporting to 3.6 and 2.7 is probably not going to happen, but at least the
patch applies fine to both of them.)
The "Versions" label list shoul
Erlend Egeberg Aasland added the comment:
I've updated these patches to sqlite3-3.30.1
(https://www.sqlite.org/releaselog/3_30_1.html).
cpython-source-deps is updated
(https://github.com/python/cpython-source-deps/pull/17).
CPython commits are updated and rebased onto current 3.9 master
Change by Erlend Egeberg Aasland :
--
pull_requests: +18038
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/18678
___
Python tracker
<https://bugs.python.org/issu
Change by Erlend Egeberg Aasland :
Added file:
https://bugs.python.org/file48921/0001-bpo-38380-Update-macOS-installer-to-use-SQLite-3.30.1.patch
___
Python tracker
<https://bugs.python.org/issue38
Change by Erlend Egeberg Aasland :
Added file:
https://bugs.python.org/file48922/0002-bpo-38380-Update-Windows-builds-to-use-SQLite-3.30.1.patch
___
Python tracker
<https://bugs.python.org/issue38
Change by Erlend Egeberg Aasland :
--
nosy: +erlendaasland
nosy_count: 9.0 -> 10.0
pull_requests: +18045
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/18685
___
Python tracker
<https://bugs.p
Change by Erlend Egeberg Aasland :
Added file: https://bugs.python.org/file48928/0001-3.7-bpo-39712.patch
___
Python tracker
<https://bugs.python.org/issue39712>
___
___
Change by Erlend Egeberg Aasland :
--
keywords: +patch
Added file: https://bugs.python.org/file48926/0001-bpo-39712.patch
___
Python tracker
<https://bugs.python.org/issue39
Change by Erlend Egeberg Aasland :
Added file: https://bugs.python.org/file48927/0001-3.8-bpo-39712.patch
___
Python tracker
<https://bugs.python.org/issue39712>
___
___
Erlend Egeberg Aasland added the comment:
I might have missed something, but I thought .pyw files were a Windows specific
thing.
--
nosy: +erlendaasland
___
Python tracker
<https://bugs.python.org/issue36
Erlend Egeberg Aasland added the comment:
Thanks for testing @chrysn. I guess I should add unit tests if this is to be
applied to master.
--
___
Python tracker
<https://bugs.python.org/issue35
Change by Erlend Egeberg Aasland :
--
pull_requests: +18876
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/19526
___
Python tracker
<https://bugs.python.org/issu
Change by Erlend Egeberg Aasland :
--
type: -> enhancement
___
Python tracker
<https://bugs.python.org/issue40318>
___
___
Python-bugs-list mailing list
Un
New submission from Erlend Egeberg Aasland :
Currently, we're using the sqlite3_trace() for tracing statements. This API was
been superseded by sqlite3_trace_v2() in SQLite3 v3.14 back in August 2016.
Proposing to migrate to the new API, which allows more fine grained control
over what
Change by Erlend Egeberg Aasland :
--
pull_requests: +18919
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/19581
___
Python tracker
<https://bugs.python.org/issu
Change by Erlend Egeberg Aasland :
--
nosy: +ghaering
___
Python tracker
<https://bugs.python.org/issue40318>
___
___
Python-bugs-list mailing list
Unsubscribe:
Erlend Egeberg Aasland added the comment:
Added (Mac OS specific) unit tests.
--
Added file:
https://bugs.python.org/file49059/0002-bpo-35569-Add-unit-tests.patch
___
Python tracker
<https://bugs.python.org/issue35
Change by Erlend Egeberg Aasland :
--
versions: +Python 3.9
___
Python tracker
<https://bugs.python.org/issue35569>
___
___
Python-bugs-list mailing list
Unsub
Change by Erlend Egeberg Aasland :
Added file:
https://bugs.python.org/file49163/0001-bpo-40656-Clean-up-detect_socket.patch
___
Python tracker
<https://bugs.python.org/issue40
Change by Erlend Egeberg Aasland :
Removed file:
https://bugs.python.org/file49161/0001-Clean-up-detect_socket.patch
___
Python tracker
<https://bugs.python.org/issue40
New submission from Erlend Egeberg Aasland :
Rewrite to use `if cond`, iso. `if not cond`
--
components: Build
files: 0001-Clean-up-detect_socket.patch
keywords: patch
messages: 369101
nosy: erlendaasland
priority: normal
severity: normal
status: open
title: Clean up detect_socket
Change by Erlend Egeberg Aasland :
--
nosy: +berker.peksag
___
Python tracker
<https://bugs.python.org/issue40318>
___
___
Python-bugs-list mailing list
Unsub
Change by Erlend Egeberg Aasland :
Removed file:
https://bugs.python.org/file49163/0001-bpo-40656-Clean-up-detect_socket.patch
___
Python tracker
<https://bugs.python.org/issue40
Change by Erlend Egeberg Aasland :
--
pull_requests: +19453
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/20148
___
Python tracker
<https://bugs.python.org/issu
New submission from Erlend Egeberg Aasland :
SQLite 3.32.0 is out: https://www.sqlite.org/releaselog/3_32_0.html
I'll preparing a PR for cpython-source-deps and cpython.
--
components: Windows, macOS
messages: 369711
nosy: erlendaasland, ned.deily, paul.moore, ronaldoussoren
Erlend Egeberg Aasland added the comment:
This issue could probably be expanded to the whole Modules directory. A lot of
the modules fail to clean up properly on PyModule_AddObject() error.
--
___
Python tracker
<https://bugs.python.
Change by Erlend Egeberg Aasland :
--
pull_requests: +19598
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/20330
___
Python tracker
<https://bugs.python.org/issu
New submission from Erlend Egeberg Aasland :
Currently, we use sqlite3_create_function_v2() without wrapping it in any
#ifdefs, so in practise the sqlite3 module will not build against sqlite3 pre
3.7.3. Despite this, we still wrap parts of the code in #ifdefs for versions
3.6.x and older
Erlend Egeberg Aasland added the comment:
The SQLite docs clearly states that using sqlite3_enable_shared_cache() is not
recommended:
"Shared cache is disabled by default. It is recommended that it stay that way.
In other words, do not use this routine. This interface cont
Erlend Egeberg Aasland added the comment:
>From the SQLite docs https://sqlite.org/c3ref/enable_shared_cache.html:
"Note: This method is disabled on MacOS X 10.7 and iOS version 5.0 and will
always return SQLITE_MISUSE. On those systems, shared cache mode should be
enabled per-
Erlend Egeberg Aasland added the comment:
A little bit too fast with my previous comment; just disregard that suggestion.
Maybe we should just disable the sqlite3.enable_shared_cache() method if we are
running on macOS, since it will only result in a misuse error anyway
Erlend Egeberg Aasland added the comment:
By the way, what's the preferred way to benchmark performance?
--
___
Python tracker
<https://bugs.python.org/issue40
Erlend Egeberg Aasland added the comment:
Also, see the comment from Victor here:
https://github.com/python/cpython/pull/22478#issuecomment-702201260
--
___
Python tracker
<https://bugs.python.org/issue40
Change by Erlend Egeberg Aasland :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
New submission from Erlend Egeberg Aasland :
The 'defining_class' AC converter is not documented.
https://www.python.org/dev/peps/pep-0573/#argument-clinic
https://docs.python.org/3.10/howto/clinic.html
--
components: Argument Clinic
messages: 378696
nosy: erlendaasland, larry
Change by Erlend Egeberg Aasland :
--
keywords: +patch
pull_requests: +21647
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/22673
___
Python tracker
<https://bugs.python.org/issu
New submission from Erlend Egeberg Aasland :
Handle PyDict_SetItemString() errors in _sqlite3 init by dereferencing the item
object and then goto error.
--
components: Library (Lib)
messages: 378516
nosy: erlendaasland
priority: normal
severity: normal
status: open
title: Fix possible
Change by Erlend Egeberg Aasland :
--
nosy: +berker.peksag
___
Python tracker
<https://bugs.python.org/issue42021>
___
___
Python-bugs-list mailing list
Unsub
Change by Erlend Egeberg Aasland :
--
type: -> behavior
___
Python tracker
<https://bugs.python.org/issue42021>
___
___
Python-bugs-list mailing list
Un
Change by Erlend Egeberg Aasland :
--
pull_requests: +21654
pull_request: https://github.com/python/cpython/pull/22478
___
Python tracker
<https://bugs.python.org/issue40
Change by Erlend Egeberg Aasland :
--
nosy: +berker.peksag, vstinner
___
Python tracker
<https://bugs.python.org/issue40956>
___
___
Python-bugs-list mailin
New submission from Erlend Egeberg Aasland :
Fixed in GH-22417 / bpo-41861
--
resolution: -> out of date
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
New submission from Erlend Egeberg Aasland :
Porting sqlite3 to multi-phase initialisation is non-trivial and must be broken
into smaller bpo's, often with multiple PR's per bpo. As far as I can see, this
is the task list:
1) Heap types (PEP 384): bpo-41861
2) Argument Clinic: bpo-40956
3
Erlend Egeberg Aasland added the comment:
Instead of using a custom context struct for sqlite3_create_funcion_v2(), we
may just use sqlite3_context_db_handle() to get `self`, and then fetch the
state using PyType_GetModuleState(Py_TYPE(self
Erlend Egeberg Aasland added the comment:
No, unless we can add `self` as a private context to a sqlite3 database handle,
we can't use that shortcut. However, using a custom context struct works, and
it's a minor code change.
Proof-of-concept implementation diffstat:
2 files changed, 54
Erlend Egeberg Aasland added the comment:
FYI, WIP branch for this bpo is here:
https://github.com/erlend-aasland/cpython/commits/bpo-42064/all
This currently includes items 1 though 6. I'll update the WIP branch with a
draft of items 7 and 8, hopefully tomorrow
Change by Erlend Egeberg Aasland :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Erlend Egeberg Aasland added the comment:
Merged to 3.10, 3.9, 3.8 on both builds. Closing this.
--
___
Python tracker
<https://bugs.python.org/issue41
Change by Erlend Egeberg Aasland :
--
nosy: +steve.dower
___
Python tracker
<https://bugs.python.org/issue41557>
___
___
Python-bugs-list mailing list
Unsub
Erlend Egeberg Aasland added the comment:
The primary reason is that it will be provide easy access to module state.
The first step in making sqlite3 support multiphase init was to create heap
types. The second step is argument clinic. The third will be to use AC for
module state. The last
Erlend Egeberg Aasland added the comment:
Work with item 7 is progressing; see WIP branch for details. Current
showstopper is how to fetch module state from Connection.__init__ when it has
been overloaded (for example in /Lib/sqlite3/test/factory.py). Guessing that
Py_TYPE(self) does
Change by Erlend Egeberg Aasland :
--
pull_requests: +21070
pull_request: https://github.com/python/cpython/pull/21960
___
Python tracker
<https://bugs.python.org/issue41
Change by Erlend Egeberg Aasland :
--
keywords: +patch
pull_requests: +21069
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/21959
___
Python tracker
<https://bugs.python.org/issu
New submission from Erlend Egeberg Aasland :
SQLite 3.33.0 was just released: https://www.sqlite.org/releaselog/3_33_0.html
Suggesting to wait one week before updating, to see if a patch version appears.
Python 3.9 and 3.10 both build fine against SQLite 3.33.0, and make test
completes
Change by Erlend Egeberg Aasland :
--
pull_requests: +21462
pull_request: https://github.com/python/cpython/pull/22428
___
Python tracker
<https://bugs.python.org/issue41
New submission from Erlend Egeberg Aasland :
https://www.python.org/dev/peps/pep-0384/
--
components: Library (Lib)
messages: 377488
nosy: erlendaasland
priority: normal
severity: normal
status: open
title: Convert sqlite3 to PEP 384
___
Python
Change by Erlend Egeberg Aasland :
--
keywords: +patch
pull_requests: +21448
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/22409
___
Python tracker
<https://bugs.python.org/issu
Change by Erlend Egeberg Aasland :
--
pull_requests: +21454
pull_request: https://github.com/python/cpython/pull/22417
___
Python tracker
<https://bugs.python.org/issue41
Change by Erlend Egeberg Aasland :
--
pull_requests: +21456
pull_request: https://github.com/python/cpython/pull/22419
___
Python tracker
<https://bugs.python.org/issue41
Change by Erlend Egeberg Aasland :
--
nosy: +erlendaasland
nosy_count: 14.0 -> 15.0
pull_requests: +21457
pull_request: https://github.com/python/cpython/pull/22419
___
Python tracker
<https://bugs.python.org/iss
Change by Erlend Egeberg Aasland :
--
pull_requests: +21495
pull_request: https://github.com/python/cpython/pull/22478
___
Python tracker
<https://bugs.python.org/issue41
Change by Erlend Egeberg Aasland :
--
nosy: +erlendaasland
nosy_count: 17.0 -> 18.0
pull_requests: +21497
pull_request: https://github.com/python/cpython/pull/22478
___
Python tracker
<https://bugs.python.org/issue1
Change by Erlend Egeberg Aasland :
--
pull_requests: +21501
pull_request: https://github.com/python/cpython/pull/22484
___
Python tracker
<https://bugs.python.org/issue40
Change by Erlend Egeberg Aasland :
--
pull_requests: +21474
pull_request: https://github.com/python/cpython/pull/22444
___
Python tracker
<https://bugs.python.org/issue41
Change by Erlend Egeberg Aasland :
--
nosy: +vstinner
___
Python tracker
<https://bugs.python.org/issue40741>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Erlend Egeberg Aasland :
--
keywords: +patch
pull_requests: +19702
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/20448
___
Python tracker
<https://bugs.python.org/issu
Erlend Egeberg Aasland added the comment:
Hi, folks. I took the liberty to create a PR for this; hope you don't mind.
I've used partial indices to test deterministic behaviour.
https://www.sqlite.org/partialindex.html
--
___
Python tracker
Erlend Egeberg Aasland added the comment:
Ready with PR as soon as GH-20448 is merged and cpython-source-deps
(https://github.com/python/cpython-source-deps/pull/19) is merged and tagged.
--
___
Python tracker
<https://bugs.python.org/issue40
Erlend Egeberg Aasland added the comment:
I think this is a good idea. Proof-of-concept implementation added (invoke REPL
with `python -m sqlite3`).
Possible improvements:
- Use sqlite3.complete_statement()
- Support Python syntax as well. For example:
>>> select * from
Change by Erlend Egeberg Aasland :
--
nosy: +erlendaasland
___
Python tracker
<https://bugs.python.org/issue36859>
___
___
Python-bugs-list mailing list
Unsub
Erlend Egeberg Aasland added the comment:
Another possibility (instead of adding `sqlite3.create_window_function`) is to
add a "windowed" parameter to `sqlite3.create_aggregate()`:
`sqlite3.create_aggregate(name, narg, aggregate, windowed=True`
Maybe that's a little bit cleaner
Change by Erlend Egeberg Aasland :
--
nosy: +erlendaasland
___
Python tracker
<https://bugs.python.org/issue36073>
___
___
Python-bugs-list mailing list
Unsub
1 - 100 of 656 matches
Mail list logo
