[issue1007] [py3k] Fix dumbdbm, which fixes test_shelve (for me); instrument other tests so we catch this sooner (and more directly)

2007-08-23 Thread Gregory P. Smith
Changes by Gregory P. Smith: -- title: Fix dumbdbm, which fixes test_shelve (for me); instrument other tests so we catch this sooner (and more directly) - [py3k] Fix dumbdbm, which fixes test_shelve (for me); instrument other tests so we catch this sooner (and more directly

[issue1007] [py3k] Fix dumbdbm, which fixes test_shelve (for me); instrument other tests so we catch this sooner (and more directly)

2007-08-23 Thread Gregory P. Smith
Changes by Gregory P. Smith: -- assignee: - greg __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1007 __ ___ Python-bugs-list mailing list Unsubscribe: http

[issue1771381] bsddb can't use unicode keys

2007-08-23 Thread Gregory P. Smith
Gregory P. Smith added the comment: The BerkeleyDB library operates on bytes only. Unicode doesn't make sense as a key without converting it to a particular encoding first. Use the unicode object's encode() method if you need to use it as a database key or create a wrapper object or subclass

[issue1725856] bsddb.btopen . del of record doesn't update index

2007-08-23 Thread Gregory P. Smith
Changes by Gregory P. Smith: -- assignee: - greg _ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1725856 _ ___ Python-bugs-list mailing list Unsubscribe: http

[issue533281] bsddb module needs iterators

2007-08-23 Thread Gregory P. Smith
Gregory P. Smith added the comment: this was marked 'open' and 'fixed' at the same time. that should be an invalid state. it was indeed fixed eons ago. -- nosy: +greg status: open - closed Tracker [EMAIL PROTECTED] http://bugs.python.org

[issue1725856] bsddb.btopen . del of record doesn't update index

2007-08-23 Thread Gregory P. Smith
Gregory P. Smith added the comment: This code deletes the item that the internal database cursor created by the db.first() call is pointing at. Then when db.first() is called again it tries to reuse the same cursor. Now to decide if thats the expected behavior or a real problem and how to fix

[issue1725856] bsddb.btopen . del of record doesn't update index

2007-08-23 Thread Gregory P. Smith
Gregory P. Smith added the comment: My first description wasn't quite accurate. What was happening is that the __delitem__(i) call by del was closing the existing cursor and saving the key it was pointing to and the first() and last() methods were creating a new cursor and trying to restore

[issue1725856] bsddb.btopen . del of record doesn't update index

2007-08-23 Thread Gregory P. Smith
Gregory P. Smith added the comment: Committed to HEAD as r57378 Committed to release25-maint as r57379 Committed to py3k as r57380 -- resolution: - fixed status: pending - closed _ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1725856

[issue1007] [py3k] Fix dumbdbm, which fixes test_shelve (for me); instrument other tests so we catch this sooner (and more directly)

2007-08-24 Thread Gregory P. Smith
Gregory P. Smith added the comment: looks like someone already committed the one liner dumbdbm latin-1 fix. But the meat of this patch is the unit test improvements. I had to fix test_whichdb to exclude dumbdbm as that has no file for whichdb to test. committed to py3k as r57419

[issue1583946] SSL issuer and server names cannot be parsed

2007-08-25 Thread Gregory P. Smith
Changes by Gregory P. Smith: -- nosy: -greg _ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1583946 _ ___ Python-bugs-list mailing list Unsubscribe: http

[issue1706815] socket.error exceptions not subclass of StandardError

2007-08-25 Thread Gregory P. Smith
Gregory P. Smith added the comment: Does the existing python SSL implementation allow it to be used over something other than a socket? If so then yes that makes sense, but otherwise its best to leave its inheritance from socket.error so that code that works when handed a regular socket can

[issue1035] bytes buffer API needs to support PyBUF_LOCKDATA

2007-08-27 Thread Gregory P. Smith
New submission from Gregory P. Smith: I've converted _bsddb.c to use the py3k buffer API for all data and keys it takes as input. All tests now fail with this error: BufferError: Cannot make this object read-only. This presumably results from this call: PyObject_GetBuffer(obj, view

[issue1036] py3k _bsddb.c patch to use the new buffer API

2007-08-27 Thread Gregory P. Smith
New submission from Gregory P. Smith: This is my svn diff of a py3k Modules/_bsddb.c converted to use the buffer API. I'm submitting it here as so it doesn't get misplaced as it currently won't work until bytes objects support PyBUF_LOCKDATA (a separate bug) -- assignee

[issue1035] bytes buffer API needs to support PyBUF_LOCKDATA

2007-08-27 Thread Gregory P. Smith
Changes by Gregory P. Smith: -- priority: normal - __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1035 __ ___ Python-bugs-list mailing list Unsubscribe: http

[issue1038] [py3k] pdb does not work in python 3000

2007-08-27 Thread Gregory P. Smith
New submission from Gregory P. Smith: The Lib/pdb.py debugger fails in the py3k branch. Traceback (most recent call last): File /usr/local/gps/python/py3k/Lib/pdb.py, line 1247, in main pdb._runscript(mainpyfile) File /usr/local/gps/python/py3k/Lib/pdb.py, line 1173, in _runscript

[issue1036] py3k _bsddb.c patch to use the new buffer API

2007-08-28 Thread Gregory P. Smith
Gregory P. Smith added the comment: committed to py3k branch using SIMPLE instead of LOCKDATA: r57610 -- resolution: - accepted status: open - closed __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1036

[issue1035] bytes buffer API needs to support PyBUF_LOCKDATA

2007-08-29 Thread Gregory P. Smith
Gregory P. Smith added the comment: I sent an initial patch to the mailing list. Its too late to be ready for 3.0a1; I'll fix it up next week. -- assignee: - gregory.p.smith __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1035

[issue1189216] zipfile module and 2G boundary

2007-08-29 Thread Gregory P. Smith
Gregory P. Smith added the comment: i'll take care of this. -- assignee: - gregory.p.smith nosy: +gregory.p.smith _ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1189216

[issue1060] zipfile cannot handle files larger than 2GB (inside archive)

2007-08-29 Thread Gregory P. Smith
Gregory P. Smith added the comment: i'll take care of it. any more info in the interim will be appreciated. -- assignee: - gregory.p.smith nosy: +gregory.p.smith __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1060

[issue1003] zipfile password fails validation

2007-08-29 Thread Gregory P. Smith
Gregory P. Smith added the comment: can you provide a test zip file demonstrating the problem? -- assignee: - gregory.p.smith nosy: +gregory.p.smith type: crash - behavior __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1003

[issue1112] Test debug assertion in bsddb test_1413192.py

2007-09-06 Thread Gregory P. Smith
Gregory P. Smith added the comment: that looks good to me. fixed in: 2.6 trunk r58023 release25-maint r58024 py3k r58025 -- resolution: - fixed status: open - closed __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1112

[issue1706815] socket.error exceptions not subclass of StandardError

2007-09-09 Thread Gregory P. Smith
Gregory P. Smith added the comment: socket.error now inherits from IOError as of trunk r58067: Change socket.error to inherit from IOError rather than being a stand alone class. This addresses the primary concern in http://bugs.python.org/issue1706815 python-dev discussion here: http

[issue1035] bytes buffer API needs to support read locking and/or PyBUF_LOCKDATA

2007-09-12 Thread Gregory P. Smith
Gregory P. Smith added the comment: Attaching the most recent patch (minor update from the second one i sent to the python-3000 mailing list to initialize ob_readonly_exports = 0 in the appropriate places). Current mailing list discussion is pointing out that the name LOCKDATA means something

[issue6559] [PATCH]add pass_fds paramter to subprocess.Popen()

2010-12-04 Thread Gregory P. Smith
Gregory P. Smith g...@krypto.org added the comment: I've committed this feature just in time for 3.2beta1 (so it can't be said i'm adding a feature after the beta ;). r87026 It still needs tests and documentation. It doesn't break any existing tests. I'll take care of that after some sleep

[issue10622] WebKit browsers show superfluous scrollbars in html docs

2010-12-04 Thread Gregory P. Smith
Gregory P. Smith g...@krypto.org added the comment: r87027 has it for py3k / 3.2. needs backporting to the other branches. -- nosy: +gregory.p.smith versions: -Python 3.2 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10622

[issue10242] unittest's assertItemsEqual() method makes too many assumptions about its input

2010-12-09 Thread Gregory P. Smith
Gregory P. Smith g...@krypto.org added the comment: I have to agree that the name assertCountEqual does not work well for me as something I can read and really comprehend what it is going to do without searching for the docs or implementation to double check. (not that assertItemsEqual did

[issue10273] Clean-up Unittest API

2010-12-09 Thread Gregory P. Smith
Gregory P. Smith g...@krypto.org added the comment: fyi - since I didn't chime in earlier on this: I think you made the right choice with what was decided in msg122413 and implemented in the renaming done in r86910 and the work done in issue10242

[issue7213] subprocess leaks open file descriptors between Popen instances causing hangs

2010-12-11 Thread Gregory P. Smith
Gregory P. Smith g...@krypto.org added the comment: Paul Giovanni: yes I hadn't given the windows side of things any thought when I made the change for beta1. Milko: The DISREGARD_FDS approach is basically what I was intending to do. Also, there really wasn't any objection to going ahead

[issue7213] subprocess leaks open file descriptors between Popen instances causing hangs

2010-12-12 Thread Gregory P. Smith
Gregory P. Smith g...@krypto.org added the comment: The close_fds default has been fixed in r87206 to remove the DeprecationWarning and remain False on Windows. It changes to True on POSIX. -- ___ Python tracker rep...@bugs.python.org http

[issue7213] subprocess leaks open file descriptors between Popen instances causing hangs

2010-12-13 Thread Gregory P. Smith
Gregory P. Smith g...@krypto.org added the comment: Milko's subprocess-00/01/02 patch set have been committed with minor modifications in r87207 r87208. Thanks, especially for the test cases! Is there anything else left that we know about for this bug

[issue6559] add pass_fds paramter to subprocess.Popen()

2010-12-14 Thread Gregory P. Smith
Gregory P. Smith g...@krypto.org added the comment: Bug fix, unittest and documentation added in r87229. Thanks! -- resolution: - accepted status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6559

[issue7213] subprocess leaks open file descriptors between Popen instances causing hangs

2010-12-14 Thread Gregory P. Smith
Gregory P. Smith g...@krypto.org added the comment: I updated the documentation and changed the close_fds default on Windows to be True when possible per Giovanni's suggestion in r87229. That keeps the API and defaults as consistent as possible across all platforms. -- resolution

[issue7213] subprocess leaks open file descriptors between Popen instances causing hangs

2010-12-14 Thread Gregory P. Smith
Gregory P. Smith g...@krypto.org added the comment: P.S. Yes I will be backporting all of this to subprocess32. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7213

[issue1731717] race condition in subprocess module

2010-12-14 Thread Gregory P. Smith
Gregory P. Smith g...@krypto.org added the comment: r87233 fixes the OSError escaping from wait() issue when SIGCLD is set to be ignored. (to appear in 3.2beta1; it is a candidate for backporting to 3.1 and 2.7) -- ___ Python tracker rep

[issue1731717] race condition in subprocess module

2010-12-14 Thread Gregory P. Smith
Gregory P. Smith g...@krypto.org added the comment: sorry, i meant 3.2beta2 above. release27-maint: r87234 targeting 2.7.2 release31-maint: r87235 targeting 3.1.4 -- resolution: - fixed status: open - closed ___ Python tracker rep...@bugs.python.org

[issue10667] collections.Counter object in C

2010-12-14 Thread Gregory P. Smith
Gregory P. Smith g...@krypto.org added the comment: rhettinger's fastcount.patch looks good to me. a couple style nits but they're minor. no space between if and (? yuck. short variable names like it? yuck. but the code looks good otherwise. i'm all for it. -- nosy

[issue10711] Rip out HTTP 0.9 support

2010-12-15 Thread Gregory P. Smith
Gregory P. Smith g...@krypto.org added the comment: Ripping HTTP 0.9 support _out_ flys directly in the face of be lenient in what you accept and strict in what you produce. I do not mind removing support from http.server. But http.client needs to be able to communicate with any random

[issue10711] Rip out HTTP 0.9 support

2010-12-15 Thread Gregory P. Smith
Gregory P. Smith g...@krypto.org added the comment: Given the 6961 issue I'm happy to change my position and say we nuke the 0.9 client support. Anyone who _needs_ that can grab this old code or write trivial code for their poor server's needs

[issue8073] Test fail for sha512 -

2010-12-19 Thread Gregory P. Smith
Gregory P. Smith g...@krypto.org added the comment: In your back traces notice that the size= argument is clearly nonsensical. Regardless, i can't reproduce this on any of my systems (I don't have a suse system of any sort). If that is the only place you are seeing this I strongly suspect

[issue3566] httplib persistent connections violate MUST in RFC2616 sec 8.1.4.

2010-12-19 Thread Gregory P. Smith
Gregory P. Smith g...@krypto.org added the comment: unassigning, i don't had time to look at this one. -- assignee: gregory.p.smith - ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue3566

[issue2636] Regexp 2.7 (modifications to current re 2.2.2)

2010-12-29 Thread Gregory P. Smith
Gregory P. Smith g...@krypto.org added the comment: As belopolsky said... *please* move this development into version control. Put it up in an Hg repo on code.google.com. or put it on github. *anything* other than repeatedly posting entire zip file source code drops to a bugtracker

[issue10794] Infinite recursion while garbage collecting loops indefinitely

2010-12-30 Thread Gregory P. Smith
Gregory P. Smith g...@krypto.org added the comment: FWIW, the example pasted in the bug was the smallest one he could come up with. in reality we were never calling .__del__() explicitly. We ran into the problem due to a __del__ method triggering a __getattr__ call and the __getattr__ ending up

[issue10794] Infinite recursion while garbage collecting loops indefinitely

2010-12-31 Thread Gregory P. Smith
Gregory P. Smith g...@krypto.org added the comment: it happens on 3.2 (py3k head). -- Added file: http://bugs.python.org/file20208/unnamed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10794

[issue10802] python3.2 AFTER b2 release has subprocess.Popen broken under colinux/windows

2011-01-01 Thread Gregory P. Smith
Gregory P. Smith g...@krypto.org added the comment: The only thing that could cause this error is if the Modules/_posixsubprocess.c subprocess_cloexec_pipe function fails either in the pipe2() call or if HAVE_PIPE2 is not defined one of the fcntl() calls. Can you look to see if HAVE_PIPE2

[issue10802] python3.2 AFTER b2 release has subprocess.Popen broken under colinux/windows

2011-01-02 Thread Gregory P. Smith
Gregory P. Smith g...@krypto.org added the comment: This bug has brought up a broader issue. the pipe2 syscall on Linux is very new. It is perfectly reasonable to expect a Python binary will be compiled against a C library that has a pipe2() function but run on a system with an older (pre

[issue10802] python3.2 AFTER b2 release has subprocess.Popen broken under colinux/windows

2011-01-02 Thread Gregory P. Smith
Gregory P. Smith g...@krypto.org added the comment: This bug has brought up a broader issue. the pipe2 syscall on Linux is very new. It is perfectly reasonable to expect a Python binary will be compiled against a C library that has a pipe2() function but run on a system with an older (pre

[issue7978] SocketServer doesn't handle syscall interruption

2011-01-03 Thread Gregory P. Smith
Gregory P. Smith g...@krypto.org added the comment: I've added some code comments on http://bugs.python.org/review/7978/show overall I think the patch is right, I pointed out one thing to clean up and I think the unittest can be greatly simplified by using stubbed out mock select.select

[issue6643] Throw away more radioactive locks that could be held across a fork in threading.py

2011-01-03 Thread Gregory P. Smith
Gregory P. Smith g...@krypto.org added the comment: fwiw a unified fork-and-exec API implemented in C is what I added in Modules/_posixsubprocess.c to at least avoid this issue as much as possible when using subprocess. -- ___ Python tracker rep

[issue6643] Throw away more radioactive locks that could be held across a fork in threading.py

2011-01-03 Thread Gregory P. Smith
Gregory P. Smith g...@krypto.org added the comment: patch looks good. committed in r87710 for 3.2. needs back porting to 3.1 and 2.7 and optionally 2.6. -- assignee: rnk - gregory.p.smith resolution: - accepted ___ Python tracker rep

[issue9535] Pending signals are inherited by child processes

2011-01-03 Thread Gregory P. Smith
Gregory P. Smith g...@krypto.org added the comment: Doing this makes sense, i'm taking to closer look to see where it should be done. -- assignee: - gregory.p.smith ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9535

[issue4188] test_threading hang when running as verbose

2011-01-03 Thread Gregory P. Smith
Changes by Gregory P. Smith g...@krypto.org: -- assignee: - gregory.p.smith nosy: +gregory.p.smith ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4188

[issue4188] test_threading hang when running as verbose

2011-01-03 Thread Gregory P. Smith
Changes by Gregory P. Smith g...@krypto.org: -- resolution: - fixed status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4188

[issue8458] buildbot: test_cmd_line failure on Tiger: [Errno 9] Bad file descriptor

2011-01-03 Thread Gregory P. Smith
Gregory P. Smith g...@krypto.org added the comment: The code surrounding the p2c file descriptors in subprocess has changed a bit recently since this issue was filed. someone still needs to come up with a way to reproduce it. -- assignee: gregory.p.smith

[issue6643] Throw away more radioactive locks that could be held across a fork in threading.py

2011-01-03 Thread Gregory P. Smith
Gregory P. Smith g...@krypto.org added the comment: r87726 for release31-maint r87727 for release27-maint - this required a bit more fiddling as _block and _started and _cond were __ private. -- versions: -Python 3.1, Python 3.2 ___ Python tracker

[issue6643] Throw away more radioactive locks that could be held across a fork in threading.py

2011-01-03 Thread Gregory P. Smith
Gregory P. Smith g...@krypto.org added the comment: Attached is a patch for Python 2.6 release26_maint for reference incase someone wants it. That branch is closed - security fixes only. -- keywords: +patch status: open - closed versions: -Python 2.7 Added file: http

[issue8458] buildbot: test_cmd_line failure on Tiger: [Errno 9] Bad file descriptor

2011-01-03 Thread Gregory P. Smith
Gregory P. Smith g...@krypto.org added the comment: that race condition, if thats what this is, is likely not OS X specific. the child process could complete or close its fds before we reach that code on any OS. We either need to guard these io.open(p2c*...) lines against EBADF OSError's

[issue8052] subprocess close_fds behavior should only close open fds

2011-01-03 Thread Gregory P. Smith
Gregory P. Smith g...@krypto.org added the comment: its still a problem, even the C path has to call close() a million times in that case. thats a huge number of wasted syscalls. fixing this is blocking on a good way to get the list of open fds. I have seen other subprocess code do it using

[issue4188] test_threading hang when running as verbose

2011-01-03 Thread Gregory P. Smith
Gregory P. Smith g...@krypto.org added the comment: sorry, i saw the patches committed and thought that had fixed it. oops. still more to be done. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4188

[issue1054041] Python doesn't exit with proper resultcode on SIGINT

2011-01-03 Thread Gregory P. Smith
Gregory P. Smith g...@krypto.org added the comment: Here's a patch that implements this behavior. It is too late in the 3.2 beta/rc cycle to get this into 3.2. Consider it for 3.3. I'd like a review. -- keywords: +needs review, patch Added file: http://bugs.python.org/file20251

[issue9535] Pending signals are inherited by child processes

2011-01-03 Thread Gregory P. Smith
Gregory P. Smith g...@krypto.org added the comment: Yes I'd do it in PyOS_AfterFork. Simpler patch based on gdb's attached. This could also use a test but as it involves signals and race conditions, making a deterministic test for this is difficult as it. If we added testing hooks

[issue6643] Throw away more radioactive locks that could be held across a fork in threading.py

2011-01-04 Thread Gregory P. Smith
Gregory P. Smith g...@krypto.org added the comment: eek, thanks for noticing that! r87740 fixes this in py3k. backporting to 3.1 and 2.7 now. -- nosy: +barry priority: normal - release blocker ___ Python tracker rep...@bugs.python.org http

[issue6643] Throw away more radioactive locks that could be held across a fork in threading.py

2011-01-04 Thread Gregory P. Smith
Gregory P. Smith g...@krypto.org added the comment: r87741 3.1 r87742 2.7 -- resolution: accepted - fixed status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6643

[issue8458] buildbot: test_cmd_line failure on Tiger: [Errno 9] Bad file descriptor

2011-01-04 Thread Gregory P. Smith
Gregory P. Smith g...@krypto.org added the comment: Off the top of my head I don't _think_ so.. at least for posix. I'm not sure about the implications of the if mswindows: code in there though. -- ___ Python tracker rep...@bugs.python.org http

[issue2320] Race condition in subprocess using stdin

2011-01-05 Thread Gregory P. Smith
Gregory P. Smith g...@krypto.org added the comment: This is likely solved in py3k 3.2 with the C _posixsubprocess.c module. The pipe creation and cloexec flag setting is all done atomically when possible, and at least with the GIL held when not. close_fds also now defaults to True

[issue1054041] Python doesn't exit with proper resultcode on SIGINT

2011-01-06 Thread Gregory P. Smith
Gregory P. Smith g...@krypto.org added the comment: IMO, if we give the illusion that the interpreter was actually killed, we should equate KeyboardInterrupt with SIGINT; any uncaught KeyboardInterrupt should consequently always lead to raising SIGINT. Agreed. Plus that is easier

[issue2320] Race condition in subprocess using stdin

2011-01-10 Thread Gregory P. Smith
Gregory P. Smith g...@krypto.org added the comment: btw, I will be backporting all recent subprocess changes to http://code.google.com/p/python-subprocess32/ there have been a lot of changes recently, i was waiting for that to settle down before bring it up to current. 3.2rc1 sounds like

[issue7322] Socket timeout can cause file-like readline() method to lose data

2011-01-13 Thread Gregory P. Smith
Gregory P. Smith g...@krypto.org added the comment: Generally there is no guarantee that a buffered object works properly when the raw IO object raises some exception intermittently I disagree. EINTR is a classic case of this and is something that buffering IO layers deal with all the time

[issue6926] socket module missing IPPROTO_IPV6, IPPROTO_IPV4

2011-01-25 Thread Gregory P. Smith
Gregory P. Smith g...@krypto.org added the comment: IMNSHO it should but that would violate our release practices to do it this late in the cycle. I expect the release manager to decline. It isn't a critical issue, the end result is that people will hard code the constants into their own

[issue11109] socketserver.ForkingMixIn leaves zombies

2011-02-05 Thread Gregory P. Smith
Gregory P. Smith g...@krypto.org added the comment: Rather than depending on the internal details of ForkingMixIn in your BaseServer.serve_forever modification I'd prefer to see that simply call self._cleanup() Define a do-nothing _periodic_cleanup method in BaseServer. ForkingMixIn should

[issue7678] subprocess.Popen pipeline example code in the documentation is lacking

2011-02-05 Thread Gregory P. Smith
Gregory P. Smith g...@krypto.org added the comment: documentation updated in r88352. thanks! -- assignee: docs@python - gregory.p.smith resolution: - fixed status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org

[issue1615376] subprocess doesn\'t handle SIGPIPE

2011-02-05 Thread Gregory P. Smith
Gregory P. Smith g...@krypto.org added the comment: The need to call p1.stdout.close() has now been documented as part of issue7678. Python 3.2's subprocess also has restore_signals=True as its default behavior so SIGPIPE is restored by default. I do not think it is appropriate to to add

[issue10826] pass_fds sometimes fails

2011-02-05 Thread Gregory P. Smith
Gregory P. Smith g...@krypto.org added the comment: Your patch makes sense to me. I'll commit it after the 3.2 release for 3.2.1. The elease manager can feel free to commit it earlier if it is bothering an important buildbot. -- assignee: - gregory.p.smith

[issue11109] socketserver.ForkingMixIn leaves zombies, also fails to reap all zombies in one pass

2011-02-05 Thread Gregory P. Smith
Gregory P. Smith g...@krypto.org added the comment: I believe that is good. I'll commit it after the 3.2 release has been cut (we're in release candidate release blocker only lockdown right now). Looking at ForkingMixIn.collect_children() there appears to be another buglet: it loops over

[issue11109] socketserver.ForkingMixIn leaves zombies, also fails to reap all zombies in one pass

2011-02-05 Thread Gregory P. Smith
Changes by Gregory P. Smith g...@krypto.org: -- assignee: - gregory.p.smith ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11109 ___ ___ Python

[issue6721] Locks in python standard library should be sanitized on fork

2011-02-10 Thread Gregory P. Smith
Gregory P. Smith g...@krypto.org added the comment: fwiw http://bugs.python.org/issue6643 recently fixed on issue where a mutex was being closed instead of reinitialized after a fork. more are likely needed. Are you suggesting to use pthread_atfork to call pthread_mutex_init on all mutexes

[issue6721] Locks in python standard library should be sanitized on fork

2011-02-10 Thread Gregory P. Smith
Gregory P. Smith g...@krypto.org added the comment: Yeah, I'm trying to figure out what I was thinking then or if I was just plain wrong. :) I was clearly wrong about a release being done in the child being the right thing to do (issue6643 proved that, the state held by a lock is not usable

[issue11197] information leakage with SimpleHTTPServer

2011-02-11 Thread Gregory P. Smith
Changes by Gregory P. Smith g...@krypto.org: -- assignee: - gregory.p.smith nosy: +gregory.p.smith ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11197

[issue11197] information leakage with SimpleHTTPServer

2011-02-12 Thread Gregory P. Smith
Gregory P. Smith g...@krypto.org added the comment: Agreed, fixing this is going to be too complex for 3.2.0, it'll be done for 3.2.1. Reading over the http.server Simple and CGI HTTPRequestHandler code I see there many problems with the way this code does things today. General: * I'm

[issue11314] Subprocess suffers 40% process creation overhead penalty

2011-02-25 Thread Gregory P. Smith
Gregory P. Smith g...@krypto.org added the comment: fyi - while I still need to update it now that 3.2 final has been released, the http://code.google.com/p/python-subprocess32/ project has a backport of the _posixsubprocess stuff from python 3.2 for use on Python 2.x

[issue1035] bytes buffer API needs to support read locking and/or PyBUF_LOCKDATA

2007-10-07 Thread Gregory P. Smith
Gregory P. Smith added the comment: This bug will be taken care of by PEP 3137 http://python.org/dev/peps/pep-3137/ being implemented. Anyways, no the _bsddb.c changes that I checked in do not cause a problem because I checked them in using PyBUF_SIMPLE. Until PEP 3137 is implemented

[issue1261] PEP 3137: make bytesobject.c methods use PEP 3118 buffer API

2007-10-11 Thread Gregory P. Smith
New submission from Gregory P. Smith: This makes all existing bytesobject.c methods use the buffer API rather than explicitly requiring bytes objects as input. It also fixes input to append() and remove() that was not strict enough and improves a few unit tests in that area. NOTE: this patch

[issue1261] PEP 3137: make bytesobject.c methods

2007-10-11 Thread Gregory P. Smith
Changes by Gregory P. Smith: __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1261 __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options

[issue1261] PEP 3137: make bytesobject.c methods

2007-10-11 Thread Gregory P. Smith
Gregory P. Smith added the comment: Patch updated. It now implements the is*() methods for PyBytes. It moves common code into a shared bytes_ctype.c and .h file so that stringobject.c and bytesobject.c can share as much as possible. Did you move this into the stringlib subdirectory

[issue1261] PEP 3137: make bytesobject.c methods

2007-10-11 Thread Gregory P. Smith
Changes by Gregory P. Smith: __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1261 __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options

[issue1261] PEP 3137: make bytesobject.c methods

2007-10-11 Thread Gregory P. Smith
Changes by Gregory P. Smith: -- nosy: -gps __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1261 __ ___ Python-bugs-list mailing list Unsubscribe: http

[issue1233] bsddb.dbshelve.DbShelf.append doesn't work

2007-10-12 Thread Gregory P. Smith
Gregory P. Smith added the comment: heh yep that does look like a bug. Laughing at that one goes well with this comment currently in test_dbshelve.py: # TODO: Add test cases for a DBShelf in a RECNO DB. i'll fix it. :) __ Tracker [EMAIL PROTECTED] http

[issue1275] bsddb closing a DB object before all DBCursors using it are closed crashes

2007-10-12 Thread Gregory P. Smith
New submission from Gregory P. Smith: If a bsddb.db.DB object is closed before any DBCursor objects referencing it are closed, python will crash when the cursors are closed or deleted. Workaround: never close a database with open cursors. this is annoying in unittest code where a tearDown

[issue1233] bsddb.dbshelve.DbShelf.append doesn't work

2007-10-12 Thread Gregory P. Smith
Gregory P. Smith added the comment: Fixed in python trunk r58434, release25-maint r58435, py3k r58438 -- resolution: - fixed status: open - closed versions: +Python 2.6, Python 3.0 __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1233

[issue1261] PEP 3137: make bytesobject.c methods

2007-10-15 Thread Gregory P. Smith
Changes by Gregory P. Smith: __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1261 __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options

[issue1283] PyBytes (buffer) .extend method needs to accept any iterable of ints

2007-10-15 Thread Gregory P. Smith
New submission from Gregory P. Smith: The PyBytes (pep3137 buffer) .extend() method currently only accepts as input something supporting the pep3118 buffer API. It also needs to accept an iterable of ints in the 0..255 range. -- keywords: py3k messages: 56478 nosy: gregory.p.smith

[issue1261] PEP 3137: make bytesobject.c methods

2007-10-15 Thread Gregory P. Smith
Changes by Gregory P. Smith: __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1261 __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options

[issue1261] PEP 3137: make bytesobject.c methods

2007-10-15 Thread Gregory P. Smith
Changes by Gregory P. Smith: __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1261 __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options

[issue1261] PEP 3137: make bytesobject.c methods

2007-10-16 Thread Gregory P. Smith
Gregory P. Smith added the comment: Committed revision 58493 -- resolution: - accepted status: open - closed __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1261

[issue1261] PEP 3137: make bytesobject.c methods

2007-10-16 Thread Gregory P. Smith
Changes by Gregory P. Smith: __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1261 __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options

[issue1247] PEP 3137 patch (repr, names, parser)

2007-10-28 Thread Gregory P. Smith
Changes by Gregory P. Smith: -- nosy: +gregory.p.smith __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1247 __ ___ Python-bugs-list mailing list Unsubscribe: http

[issue1371] Two bsddb tests temporarily commented out in py3k branch

2007-11-01 Thread Gregory P. Smith
Gregory P. Smith added the comment: This should be fixed in py3k revision 58761. -- keywords: +py3k resolution: - fixed status: open - closed __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1371

[issue1391] Adds the .compact() method to bsddb db.DB objects

2007-11-04 Thread Gregory P. Smith
New submission from Gregory P. Smith: I'm attaching the patch to add this method here just as a place to track it for now. It compiles and it looks right, but it causes a crash within BerkeleyDB when the test case runs using BerkeleyDB 4.6.21. It passes as expected when using 4.4.20 or 4.5.20

[issue1385] hmac module violates RFC for some hash functions, e.g. sha512

2007-11-05 Thread Gregory P. Smith
Gregory P. Smith added the comment: option 1 sounds best. i'll take care of this. thanks for noticing this and providing suggestions and a patch. __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1385

[issue1385] hmac module violates RFC for some hash functions, e.g. sha512

2007-11-05 Thread Gregory P. Smith
Changes by Gregory P. Smith: -- components: +Library (Lib) -None versions: +Python 2.5, Python 2.6 __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1385 __ ___ Python

[issue1385] hmac module violates RFC for some hash functions, e.g. sha512

2007-11-05 Thread Gregory P. Smith
Gregory P. Smith added the comment: Fixed in trunk (2.6) svn revision 58868 with rfc 4231 unit tests and tests for the new warnings. The fix parts of that diff should be backported to 2.5. I'm leaving the Python 2.5 flag on the bug until that happens. I'm leaving Python 3.0 and py3k tags

  1   2   3   4   5   6   7   8   9   10   >