[issue30102] improve performance of libSSL usage on hashing

2017-04-19 Thread Gustavo Serra Scalet
New submission from Gustavo Serra Scalet: To correctly pick the best algorithm for the current architecture, libssl needs to have OPENSSL_config(NULL) called as described on: https://wiki.openssl.org/index.php/Libcrypto_API This short change lead to a speedup of 50% on POWER8 when using

[issue30102] improve performance of libSSL usage on hashing

2017-04-19 Thread Gustavo Serra Scalet
Changes by Gustavo Serra Scalet <gustavo.sca...@eldorado.org.br>: -- pull_requests: +1309 ___ Python tracker <rep...@bugs.python.org> <http://bugs.python

[issue30102] improve performance of libSSL usage on hashing

2017-04-19 Thread Gustavo Serra Scalet
Gustavo Serra Scalet added the comment: > Christian Heimes added the comment: > > This small change also changes behavior of OpenSSL dramatically. What > are your Python and OpenSSL versions? I tested by compiling my own python3 (8aaf499) against its parent (d6d344d) For pyt

[issue30102] improve performance of libSSL usage on hashing

2017-04-20 Thread Gustavo Serra Scalet
Gustavo Serra Scalet added the comment: > Since OPENSSL_config() accepts a filename, maybe a first step would be > to expose the function as ssl.OPENSSL_config(filename) to allow user to > load *explicitly* a configuration file? ssl.OPENSSL_config() would call > OPENSSL_config(

[issue30910] Add -fexception to ppc64le build

2017-08-16 Thread Gustavo Serra Scalet
Changes by Gustavo Serra Scalet <gustavo.sca...@eldorado.org.br>: -- nosy: +gut ___ Python tracker <rep...@bugs.python.org> <http://bugs.python

[issue30910] Add -fexception to ppc64le build

2017-08-16 Thread Gustavo Serra Scalet
Gustavo Serra Scalet added the comment: -fexceptions documentation: https://gcc.gnu.org/onlinedocs/gcc/Code-Gen-Options.html#index-fexceptions Highlight to: "you may need to enable this option when compiling C code that needs to interoperate properly with exception handlers written

[issue30910] Add -fexception to ppc64le build

2017-08-16 Thread Gustavo Serra Scalet
Gustavo Serra Scalet added the comment: > Why doesn't gcc make it the default behaviour? Because it "can produce significant data size overhead, although it does not affect execution" for C code. However it'd improves interoperability with C++, which I think it makes sense fo

[issue30910] Add -fexception to ppc64le build

2017-08-17 Thread Gustavo Serra Scalet
Gustavo Serra Scalet added the comment: Sorry, I didn't take a deeper analysis on what you said, I guess you wanted to point out this problem: .-. | A C++ code | <= Designed to be the catcher :-: | cpython | <= Malloc'd som

[issue30910] Add -fexception to ppc64le build

2017-08-17 Thread Gustavo Serra Scalet
Gustavo Serra Scalet added the comment: > Throwing exceptions through CPython is totally unsupported, -fexceptions or > not. Like C++ code that's not exception-aware, CPython lacks any of the catch > handlers to properly clean up resources on unwind. wait wait. It's not expected tha

[issue30910] Add -fexception to ppc64le build

2017-08-16 Thread Gustavo Serra Scalet
Gustavo Serra Scalet added the comment: well, now I'm confused: what should we do with this change? Do we need to ask any other expert? -- ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/i

[issue30102] improve performance of libSSL usage on hashing

2017-09-05 Thread Gustavo Serra Scalet
Gustavo Serra Scalet added the comment: No worries. I thank you also for reviewing all these changesets. I'm glad it worked in the end. -- ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/i

[issue30102] improve performance of libSSL usage on hashing

2017-09-01 Thread Gustavo Serra Scalet
Gustavo Serra Scalet added the comment: Is there any news on this issue? The PR 3112 also seems to be frozen at the moment. Is there some kind of code freeze happening at the moment that no reviews are taking place? -- ___ Python tracker <