[issue10789] Lock.acquire documentation is misleading

2010-12-29 Thread Jyrki Pulliainen
New submission from Jyrki Pulliainen jy...@dywypi.org: In threading module, the Lock.acquire documentation is misleading. The signature suggests that the blocking can be given as a keyword argument but that would lead to an TypeError, as thread.lock.acquire does not accept keyword arguments

[issue12296] Minor clarification in devguide

2011-10-18 Thread Jyrki Pulliainen
Jyrki Pulliainen jy...@dywypi.org added the comment: Updated the existing patch with the new wording -- nosy: +Jyrki.Pulliainen Added file: http://bugs.python.org/file23437/clarify-bwcompat-devguide_v2.diff ___ Python tracker rep...@bugs.python.org

[issue3067] setlocale error message is confusing

2011-10-18 Thread Jyrki Pulliainen
Jyrki Pulliainen jy...@dywypi.org added the comment: Added a patch that implements two things: setlocale now raises locale.Error('Locale must be None, a string, or an iterable of two strings -- language code, encoding.'). I decided to remove the proposed .format(locale), as it wasa a bit

[issue10817] urllib.request.urlretrieve never raises ContentTooShortError if no reporthook

2011-10-18 Thread Jyrki Pulliainen
Jyrki Pulliainen jy...@dywypi.org added the comment: Changed the code so that the content length is set as size if reporthook is not set and wrote two tests for it. Note: I moved fakehttp behavior to a mixin, so that it's more reusable. -- keywords: +patch nosy: +nailor Added file

[issue10817] urllib.request.urlretrieve never raises ContentTooShortError if no reporthook

2011-10-18 Thread Jyrki Pulliainen
Jyrki Pulliainen jy...@dywypi.org added the comment: I had a bad patch, containing changes to locale.py, so I've uploaded a new patch for this. -- Added file: http://bugs.python.org/file23446/issue10817.patch ___ Python tracker rep

[issue3067] setlocale error message is confusing

2011-10-18 Thread Jyrki Pulliainen
Jyrki Pulliainen jy...@dywypi.org added the comment: I modified the patch not to contain the tests against exception messages -- Added file: http://bugs.python.org/file23447/issue3067_v2.patch ___ Python tracker rep...@bugs.python.org http

[issue10817] urllib.request.urlretrieve never raises ContentTooShortError if no reporthook

2011-10-18 Thread Jyrki Pulliainen
Changes by Jyrki Pulliainen jy...@dywypi.org: Removed file: http://bugs.python.org/file23444/issue10817.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10817

[issue3067] setlocale error message is confusing

2011-10-18 Thread Jyrki Pulliainen
Jyrki Pulliainen jy...@dywypi.org added the comment: Maybe we should return TypeError with the same message then? That would require some modification of documentation though, as it states: If the modification of the locale fails, the exception Error is raised.. I don't really understand

[issue3067] setlocale error message is confusing

2011-10-18 Thread Jyrki Pulliainen
Jyrki Pulliainen jy...@dywypi.org added the comment: Thanks for clarification! I see the problem now. So if I get this correctly we should change the _build_localename to raise TypeError? If the given locale is in wrong format, we'll get TypeError, but if it's valid type but otherwise invalid

[issue3067] setlocale error message is confusing

2011-10-18 Thread Jyrki Pulliainen
Jyrki Pulliainen jy...@dywypi.org added the comment: Uploaded a new patch that raises TypeError -- Added file: http://bugs.python.org/file23452/issue3067_v3.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue3067

[issue13244] WebSocket schemes in urlparse

2011-10-22 Thread Jyrki Pulliainen
Jyrki Pulliainen jy...@dywypi.org added the comment: I added a patch that adds support for WebSocket URL protocol. However, a few pointers (and questions): - The patch is now implemented according to Draft 17[1] of WebSocket protocol - Draft 17 does not support fragments, it states

[issue13244] WebSocket schemes in urlparse

2011-10-22 Thread Jyrki Pulliainen
Jyrki Pulliainen jy...@dywypi.org added the comment: Actually, if I get it right, it means that following url is valid: ws://example.com/something#somewhere/ and the # should be considered as being a part of the path. The spec does not say a thing should the # in path component be encoded

[issue13244] WebSocket schemes in urlparse

2011-10-22 Thread Jyrki Pulliainen
Jyrki Pulliainen jy...@dywypi.org added the comment: I'd take only 4. as invalid, as the WebSocket (to my interpretation) do not have fragments, so it is assumed to be a part of the path in that case. But yeah, a confirmation from HyBi would be great. Can you link to the discussion from here

[issue13244] WebSocket schemes in urllib.parse

2011-10-27 Thread Jyrki Pulliainen
Jyrki Pulliainen jy...@dywypi.org added the comment: Alternative: make this bug dependent on fixing urlparse for fragment rules in generic URI RFC and don't do anything until then? I'd go with this, even though it probably would be a lot bigger work than this. What's √Čric's take

[issue10817] urllib.request.urlretrieve never raises ContentTooShortError if no reporthook

2011-10-31 Thread Jyrki Pulliainen
Jyrki Pulliainen jy...@dywypi.org added the comment: Cheers, thank you for commiting! -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10817

[issue13147] Multiprocessing Pool.map_async() does not have an error_callback parameter

2011-11-02 Thread Jyrki Pulliainen
Jyrki Pulliainen jy...@dywypi.org added the comment: Python 3.x seems to have the error_callback parameter on all *_async operations. However, 2.7 lacks it. I think adding the actual error_callback would be deemed as a new feature, so the right thing would just be removing the documentation

[issue13147] Multiprocessing Pool.map_async() does not have an error_callback parameter

2011-11-02 Thread Jyrki Pulliainen
Jyrki Pulliainen jy...@dywypi.org added the comment: Patch attached. This patch removes the error_callback from 2.7's documentation. -- keywords: +patch Added file: http://bugs.python.org/file23589/issue13147.patch ___ Python tracker rep

[issue13147] Multiprocessing Pool.map_async() does not have an error_callback parameter

2011-11-02 Thread Jyrki Pulliainen
Jyrki Pulliainen jy...@dywypi.org added the comment: Also: note that 2.6 does not document this error_callback, so the issue is present only in 2.7 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13147

[issue16695] Clarify fnmatch glob docs about the handling of leading .s

2013-02-23 Thread Jyrki Pulliainen
Jyrki Pulliainen added the comment: I modified the docstring for the glob and iglob to note that the match does not work exactly like fnmatch. Should this be extended to the documentation too? -- keywords: +patch nosy: +nailor Added file: http://bugs.python.org/file29172/issue16695

[issue16403] update distutils docs to say that maintainer replaces author

2013-02-23 Thread Jyrki Pulliainen
Jyrki Pulliainen added the comment: Added a patch with documentation change -- keywords: +patch nosy: +nailor Added file: http://bugs.python.org/file29174/issue16403.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16403

[issue16695] Clarify fnmatch glob docs about the handling of leading .s

2013-02-23 Thread Jyrki Pulliainen
Jyrki Pulliainen added the comment: Added documentation changes to the glob documentation too, not only docstring. -- Added file: http://bugs.python.org/file29176/issue16695_2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org

[issue11063] uuid.py module import has heavy side effects

2013-02-23 Thread Jyrki Pulliainen
Jyrki Pulliainen added the comment: The implementation does not actually end up in infinite loop, just repeating the loading of the CDLL is slow. I added caching to that and fixed the ctypes imports too. -- nosy: +nailor Added file: http://bugs.python.org/file29189/issue11063_2.patch

[issue16041] poplib: unlimited readline() from connection

2013-02-23 Thread Jyrki Pulliainen
Jyrki Pulliainen added the comment: Added a functionality that raises error_proto('line too long') if we read over _MAXLINE characters. Defaults _MAXLINE to 2048. The patch is written on top of 2.7 -- keywords: +patch nosy: +nailor Added file: http://bugs.python.org/file29198

[issue16037] httplib: header parsing is not delimited

2013-02-23 Thread Jyrki Pulliainen
Jyrki Pulliainen added the comment: Here's a patch that limits the headers to 100. If more than _MAXHEADERS headers are read, this raises exception TooMuchHeaders. The patch is for 2.7, I'll cook one for 3.2 too. -- keywords: +patch nosy: +nailor Added file: http://bugs.python.org

[issue16037] httplib: header parsing is not delimited

2013-02-23 Thread Jyrki Pulliainen
Jyrki Pulliainen added the comment: ...and here's the patch for 3.2 -- Added file: http://bugs.python.org/file29203/issue16037_py32.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16037

[issue16446] pdb raises BdbQuit on 'quit' when started with set_trace

2013-02-23 Thread Jyrki Pulliainen
Jyrki Pulliainen added the comment: I took Xavier's patch and ported in on the 2.7. It'll probably go as is for 3.2. The functionality seems to be working and tests pass. -- keywords: +patch nosy: +nailor Added file: http://bugs.python.org/file29208/issue16446.patch

[issue11063] uuid.py module import has heavy side effects

2013-02-24 Thread Jyrki Pulliainen
Changes by Jyrki Pulliainen jy...@dywypi.org: Removed file: http://bugs.python.org/file29189/issue11063_2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11063

[issue11063] uuid.py module import has heavy side effects

2013-02-24 Thread Jyrki Pulliainen
Jyrki Pulliainen added the comment: Here's a second take on the patch -- Added file: http://bugs.python.org/file29220/issue11063_2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11063

[issue15128] inspect raises exception when frames are misleading about source line numbers

2013-02-24 Thread Jyrki Pulliainen
Jyrki Pulliainen added the comment: Use of IOError might be a bit problematic. The find get return IOError if they can't find the source, but for mismatch if the line is not found is not to me an IOError. Btw, to be able to merge your patch, you need to sign the contributor agreement

[issue11480] Cannot copy a class with a metaclass other than type

2013-02-24 Thread Jyrki Pulliainen
Jyrki Pulliainen added the comment: Hi, to be able to include your patch, could you sign the contributor form, please: http://www.python.org/psf/contrib/ ? -- nosy: +nailor ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11480

[issue11480] Cannot copy a class with a metaclass other than type

2013-02-24 Thread Jyrki Pulliainen
Jyrki Pulliainen added the comment: Oh, my bad. The * was not just showing next to your name. Maybe someone with more access rights can help? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11480

[issue16037] httplib: header parsing is not delimited

2013-09-04 Thread Jyrki Pulliainen
Jyrki Pulliainen added the comment: Reworded TooMuch to TooMany and made a patch for 2.6 too (2.7 didn't apply cleanly there) -- Added file: http://bugs.python.org/file31581/issue16037_py26.patch ___ Python tracker rep...@bugs.python.org http

[issue16037] httplib: header parsing is not delimited

2013-09-04 Thread Jyrki Pulliainen
Changes by Jyrki Pulliainen jy...@dywypi.org: Added file: http://bugs.python.org/file31582/issue16037_py27_v2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16037

[issue16037] httplib: header parsing is not delimited

2013-09-04 Thread Jyrki Pulliainen
Changes by Jyrki Pulliainen jy...@dywypi.org: Added file: http://bugs.python.org/file31583/issue16037_py32_v2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16037

[issue16037] httplib: header parsing is not unlimited

2013-09-29 Thread Jyrki Pulliainen
Jyrki Pulliainen added the comment: I'm fine with not introducing a new exception for 2.6 (or any other version for that matter), so go for it :) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16037

[issue16041] poplib: unlimited readline() from connection

2013-09-29 Thread Jyrki Pulliainen
Jyrki Pulliainen added the comment: Attached a patch for 2.6. Due to how tests are in 2.6, this adds one more test case with evil server, which basically just returns too long lines. -- Added file: http://bugs.python.org/file31913/issue16041_py26.patch

[issue16041] poplib: unlimited readline() from connection

2013-09-30 Thread Jyrki Pulliainen
Jyrki Pulliainen added the comment: Added a test for SSL, if SSL is available -- Added file: http://bugs.python.org/file31923/issue16041_py26_with_ssl.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16041

[issue16040] nntplib: unlimited readline() from connection

2013-09-30 Thread Jyrki Pulliainen
Jyrki Pulliainen added the comment: Regarding the implementation: all commands (even those returning multiple lines), use the same readline method. I've attached a patch for 2.6, working on the 2.7+ too. -- keywords: +patch nosy: +nailor Added file: http://bugs.python.org/file31927

[issue16040] nntplib: unlimited readline() from connection

2013-09-30 Thread Jyrki Pulliainen
Jyrki Pulliainen added the comment: The patch for 2.6 applies cleanly on 2.7 too and the tests pass there -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16040

[issue16040] nntplib: unlimited readline() from connection

2013-09-30 Thread Jyrki Pulliainen
Jyrki Pulliainen added the comment: Did a slight change to the patch, making the too long line to look like a valid line so that it does not raise a NNTPProtocolError otherwise. Thanks to Barry for catching this :) I also wonder if there should be data error risen instead? Current docstrings

[issue16037] httplib: header parsing is unlimited

2013-10-24 Thread Jyrki Pulliainen
Jyrki Pulliainen added the comment: Patch for py32 applies cleanly on 3.4 too, this should be good to go -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16037

[issue16041] poplib: unlimited readline() from connection

2013-10-24 Thread Jyrki Pulliainen
Jyrki Pulliainen added the comment: Here's a max line lenght fix for 3.2 (applies on 3.4 too). I wonder if _getlongresp should have some max length detection too for max length of a multiline response -- Added file: http://bugs.python.org/file32335/issue16041_py32.patch

[issue16040] nntplib: unlimited readline() from connection

2013-10-24 Thread Jyrki Pulliainen
Jyrki Pulliainen added the comment: ...and here's a patch for 3.2 -- Added file: http://bugs.python.org/file32339/issue16040_py32.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16040

[issue16037] httplib: header parsing is unlimited

2013-10-25 Thread Jyrki Pulliainen
Jyrki Pulliainen added the comment: Third version of the 3.2 patch, this time with documentation of the exception TooManyHeaders -- Added file: http://bugs.python.org/file32358/issue16037_py32_v3.patch ___ Python tracker rep...@bugs.python.org http

[issue9351] argparse set_defaults on subcommands should override top level set_defaults

2012-10-23 Thread Jyrki Pulliainen
Jyrki Pulliainen added the comment: I've attached a proposed fix where the subparser parses to an empty namespace and that namespace is then merged with the parent namespace -- keywords: +patch nosy: +nailor, petri.lehtinen Added file: http://bugs.python.org/file27677/issue9351.patch

[issue15132] Let unittest.TestProgram()'s defaultTest argument be a list

2012-10-23 Thread Jyrki Pulliainen
Jyrki Pulliainen added the comment: Added a patch for passing everything of not type basestring to tuple constructor and assigns that to testnames. -- keywords: +patch nosy: +nailor Added file: http://bugs.python.org/file27681/issue15132_py2.patch

[issue15132] Let unittest.TestProgram()'s defaultTest argument be a list

2012-10-23 Thread Jyrki Pulliainen
Changes by Jyrki Pulliainen jy...@dywypi.org: Added file: http://bugs.python.org/file27682/issue15132_py3.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15132

[issue9351] argparse set_defaults on subcommands should override top level set_defaults

2012-10-30 Thread Jyrki Pulliainen
Jyrki Pulliainen added the comment: Yeah, I tried figuring out something more clever, as this, in the current form, has a bit too hackish feeling in it, but I couldn't find a proper tool for the job. Anyway, attached a patch with the getattr removed. -- Added file: http

[issue9351] argparse set_defaults on subcommands should override top level set_defaults

2012-10-30 Thread Jyrki Pulliainen
Changes by Jyrki Pulliainen jy...@dywypi.org: Removed file: http://bugs.python.org/file27793/issue9351.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9351

[issue9351] argparse set_defaults on subcommands should override top level set_defaults

2012-10-30 Thread Jyrki Pulliainen
Changes by Jyrki Pulliainen jy...@dywypi.org: Added file: http://bugs.python.org/file27795/issue9351.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9351

[issue9351] argparse set_defaults on subcommands should override top level set_defaults

2012-10-30 Thread Jyrki Pulliainen
Changes by Jyrki Pulliainen jy...@dywypi.org: Added file: http://bugs.python.org/file27794/issue9351.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9351

[issue9351] argparse set_defaults on subcommands should override top level set_defaults

2012-10-30 Thread Jyrki Pulliainen
Changes by Jyrki Pulliainen jy...@dywypi.org: Removed file: http://bugs.python.org/file27677/issue9351.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9351

[issue9351] argparse set_defaults on subcommands should override top level set_defaults

2012-10-30 Thread Jyrki Pulliainen
Changes by Jyrki Pulliainen jy...@dywypi.org: Removed file: http://bugs.python.org/file27794/issue9351.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9351

[issue15132] Let unittest.TestProgram()'s defaultTest argument be a list

2012-11-25 Thread Jyrki Pulliainen
Jyrki Pulliainen added the comment: I rebased this change on top of 3.4 and in case of an iterable argument it now uses the _convert_names function to convert it to a list of test names. -- Added file: http://bugs.python.org/file28112/issue15132_py3_v2.patch

[issue15132] Let unittest.TestProgram()'s defaultTest argument be a list

2012-11-25 Thread Jyrki Pulliainen
Changes by Jyrki Pulliainen jy...@dywypi.org: Removed file: http://bugs.python.org/file27681/issue15132_py2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15132

[issue15132] Let unittest.TestProgram()'s defaultTest argument be a list

2012-11-25 Thread Jyrki Pulliainen
Jyrki Pulliainen added the comment: Yeah, I added the convert names call mostly to make the behavior the same as with passing things from command line. However, then we should probably wrap the case of str argument to _convert_name and the conversion behavior might be bit too implicit. I

[issue15132] Let unittest.TestProgram()'s defaultTest argument be a list

2012-11-25 Thread Jyrki Pulliainen
Changes by Jyrki Pulliainen jy...@dywypi.org: Added file: http://bugs.python.org/file28126/issue15132_py3_no_convert.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15132

[issue21143] Copy-paste error in documentation of __builtin__.max

2014-04-03 Thread Jyrki Pulliainen
New submission from Jyrki Pulliainen: Looks like the documentation of the __builtin__.max() got copied over from the __builtin__.min. Instead of the smallest of the positional arguments it should say the largest of the positional arguments. This was introduced in 3.4. Patch attached. Thanks

[issue11406] There is no os.listdir() equivalent returning generator instead of list

2014-06-26 Thread Jyrki Pulliainen
Changes by Jyrki Pulliainen jy...@dywypi.org: -- nosy: +nailor ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11406 ___ ___ Python-bugs-list