[issue19662] smtpd.py should not decode utf-8

2013-11-20 Thread Leslie P. Polzer
New submission from Leslie P. Polzer: http://hg.python.org/cpython/file/3.3/Lib/smtpd.py#l289 as of now decodes incoming bytes as UTF-8. An SMTP server must not attempt to interpret characters beyond ASCII, however. Originally mail servers were not 8-bit clean, meaning they would only

[issue12816] smtpd uses library outside of the standard libraries

2013-11-20 Thread Leslie P. Polzer
Changes by Leslie P. Polzer pol...@port-zero.com: -- nosy: +lpolzer ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12816 ___ ___ Python-bugs-list

[issue16462] smtpd should return greeting

2013-11-20 Thread Leslie P. Polzer
Changes by Leslie P. Polzer pol...@port-zero.com: -- nosy: +lpolzer ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16462 ___ ___ Python-bugs-list

[issue8503] smtpd SMTPServer does not allow domain filtering

2013-11-20 Thread Leslie P. Polzer
Changes by Leslie P. Polzer pol...@port-zero.com: -- nosy: +lpolzer ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8503 ___ ___ Python-bugs-list

[issue3802] smtpd.py __getaddr insufficient handling

2013-11-20 Thread Leslie P. Polzer
Changes by Leslie P. Polzer pol...@port-zero.com: -- nosy: +lpolzer ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue3802 ___ ___ Python-bugs-list

[issue19662] smtpd.py should not decode utf-8

2013-11-20 Thread Leslie P. Polzer
Leslie P. Polzer added the comment: Patch attached. This also adds some more charset clarification to the docs and corrects a minor spelling issue. It is also conceivable that we add a charset attribute to the class. This should have the safe default of latin1, and some notes in the docs

[issue19662] smtpd.py should not decode utf-8

2013-11-20 Thread Leslie P. Polzer
Leslie P. Polzer added the comment: Since this is my first contribution I'm not entirely sure about the fine details of backwards compatibility in Python, so please forgive me if I'm totally missing the mark here. There are facilities in smtpd's parent class asynchat that perform

[issue19678] smtpd.py: channel should be passed to process_message

2013-11-21 Thread Leslie P. Polzer
New submission from Leslie P. Polzer: process_message needs to have access to the channel state since it needs to make decisions based on the authentication or transport associated with the channel. It should be either the first or the last arg. I can provide a patch for this. Should

[issue19679] smtpd.py: implement ESMTP status messages

2013-11-21 Thread Leslie P. Polzer
New submission from Leslie P. Polzer: ESMTP status messages (of the form xab x.y.z test) can be added easily to the current status message strings emitted by the SMTP server and channel classes. They are not harmful if the user's server only intends to support plain HELO-SMTP I will provide

[issue19679] smtpd.py (SMTPChannel): get rid of conn attribute

2013-11-21 Thread Leslie P. Polzer
Leslie P. Polzer added the comment: The contents of conn are already stored by asyncore's socket attribute, so there doesn't seem to be a need to keep it around. We should deprecate its usage and refer the user to the socket attribute. Furthermore I suggest renaming the conn argument

[issue19679] smtpd.py (SMTPChannel): implement enhanced status codes

2013-11-25 Thread Leslie P. Polzer
Leslie P. Polzer added the comment: Sorry for the confusion, the second comment (#msg203622) should actually have been a separate ticket. Since you'd like to preserve conn I will just change the title of this ticket. -- title: smtpd.py (SMTPChannel): get rid of conn attribute

[issue19679] smtpd.py (SMTPChannel): implement enhanced status codes

2013-11-25 Thread Leslie P. Polzer
Leslie P. Polzer added the comment: I am indeed referring to the enhanced status codes proposed in RFC 3463. This would just entail adding information to the status codes, converting them from the format simple status code human-readable string to simple status code enhanced status code human

[issue19679] smtpd.py (SMTPChannel): implement enhanced status codes

2013-11-26 Thread Leslie P. Polzer
Leslie P. Polzer added the comment: Sounds reasonable, I will propose a patch soon. Thanks! -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19679