Michael McFadden added the comment:
I'm having no luck reproducing this issue.
Regarding pygettext.py generating .po files:
I've used the messages.po file provided by the OP, and also using a generated
.po file from pygettext.py with the offending header PO-Revision-Date:
As a side note, I'm
Michael McFadden added the comment:
Yes, I did miss that.
(Root cause: `git diff` instead of `git diff --staging`)
Sorry. I'm learning, and decided to take the git path - might not have been
the best choice.
I'll submit a new patch shortly
Michael McFadden added the comment:
I have a patch for moving script_helper as R. David suggested.
Here it is.
--
nosy: +flipmcf
Added file:
http://bugs.python.org/file39003/iss9517_move_script_helpers_py.patch
___
Python tracker rep
Michael McFadden added the comment:
I'm thinking also, maybe instead of putting script_helper into the
test.support namespace, we could move the individual methods and
helpers from script_helper into test.support, e.g.:
test.support.run_python_until_end
vs
Michael McFadden added the comment:
Uploading new patch that includes the creation of
Lib/test/support/script_helper.py
--
Added file:
http://bugs.python.org/file39038/iss9517_move_script_helpers_py.patch
___
Python tracker rep...@bugs.python.org
Michael McFadden added the comment:
This might be fixed by issue17156, which would explain why I can't recreate it.
https://github.com/python/cpython/commit/f4273cfd16fa502f0eb8a0a8fd1c537ec63e47db
--
___
Python tracker rep...@bugs.python.org
http
Michael McFadden added the comment:
issue18128 is not related methinks.
This ticket: POT-Creation-Date
issue18128: PO-Revision-Date
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19907
Michael McFadden added the comment:
Also fixes 19907?
--
nosy: +flipmcf
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17156
___
___
Python-bugs
Michael McFadden added the comment:
Post-review - new patch
--
Added file: http://bugs.python.org/file39050/issue18128.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18128
Michael McFadden added the comment:
@Christie - Nope. This patch can stand on it's own, simply moving the
package to where it belongs.
In fact, I'd recommend applying the patch first.
--
___
Python tracker rep...@bugs.python.org
http
Michael McFadden added the comment:
namespaces are a honkin' great idea
I don't have enough information to say that 'script_helper' is the right name
for the namespace, tho.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Michael McFadden added the comment:
bobcatfish: Sorry, I didn't refresh and see your comment before submitting my
patch. It only moves script_helpers, but doesn't address the original OP.
Hopefully I made your life easier, not harder
Michael McFadden added the comment:
re: test.test_tools.py - should this also move into test.support ?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9517
Michael McFadden added the comment:
I'm going to be adding some tests around pygettext tool and then tackling this.
--
nosy: +flipmcf
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18128
Michael McFadden added the comment:
Patch File iss18128.patch adds test_i18n to start testing the entire Tools/i18n
package, and has a very simple fix.
--
keywords: +patch
Added file: http://bugs.python.org/file39024/iss18128.patch
___
Python
15 matches
Mail list logo
