[issue11438] 2to3 does not fix izip_longest

2011-03-07 Thread Steve Dower
New submission from Steve Dower s.j.do...@gmail.com: Running 2to3 on the attached file makes no modifications, which then causes an error (since itertools.izip_longest is now itertools.zip_longest) -- components: 2to3 (2.x to 3.0 conversion tool) files: test.py messages: 130304 nosy

[issue7511] msvc9compiler.py: ValueError when trying to compile with VC Express

2013-03-22 Thread Steve Dower
Steve Dower added the comment: This becomes more of an issue since VC++ 2008 Express is no longer available for download (unless you're an MSDN subscriber), though the compiler itself is still available as part of http://www.microsoft.com/en-us/download/details.aspx?id=3138 (for VC9) I'll

[issue7511] msvc9compiler.py: ValueError when trying to compile with VC Express

2013-03-22 Thread Steve Dower
Steve Dower added the comment: ('ignore extra arguments' meaning they could be returned from find_vcvarsall() and nobody will notice. Though it doesn't bother me if the fallback is handled at a higher level.) -- ___ Python tracker rep

[issue7511] msvc9compiler.py: ValueError when trying to compile with VC Express

2013-03-22 Thread Steve Dower
Steve Dower added the comment: I've dug deeper into VC10 and things are even worse there - without VS installed I don't think there's any way for distutils to work without completely replacing query_vcvarsall() (or msvc9compiler, for that matter). I'm willing to write such a replacement

[issue7511] msvc9compiler.py: ValueError when trying to compile with VC Express

2013-03-23 Thread Steve Dower
Steve Dower added the comment: This becomes more of an issue since VC++ 2008 Express is no longer available for download (unless you're an MSDN subscriber) Here: http://www.microsoft.com/en-us/download/details.aspx?id=13276 That's just the service pack and it won't install unless you

[issue7511] msvc9compiler.py: ValueError when trying to compile with VC Express

2013-03-23 Thread Steve Dower
Steve Dower added the comment: That's just the service pack and it won't install unless you already have VS installed. There is no way (other than being an MSDN subscriber) to get VS 2008 at this point - I've checked. There is, but you have to know what to look for :-) Fair enough, but I

[issue7511] msvc9compiler.py: ValueError when trying to compile with VC Express

2013-09-06 Thread Steve Dower
Steve Dower added the comment: I believe that is all that is missing from the patches I posted, though I'd have thought that having Visual C++ 2010 Express installed would be sufficient without the patch (though you didn't mention C++, so maybe you have a different one

[issue7511] msvc9compiler.py: ValueError when trying to compile with VC Express

2013-04-09 Thread Steve Dower
Steve Dower added the comment: I've added a patch that replaces query_vcvarsall() with an implementation that does not try and use the batch file. Instead, the functionality of the batch file (effectively, reading the base path from the registry and appending constants) is reproduced

[issue7511] msvc9compiler.py: ValueError when trying to compile with VC Express

2013-04-09 Thread Steve Dower
Steve Dower added the comment: Adding patch for 2.7. -- Added file: http://bugs.python.org/file29755/msvccompiler9_27.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7511

[issue7511] msvc9compiler.py: ValueError when trying to compile with VC Express

2013-07-08 Thread Steve Dower
Steve Dower added the comment: I must have missed something when I merged files to create the diffs. In any case, you'll still require VC9 or VC10 to be able to build something compatible with a CPython release (though maybe that doesn't matter for Cython? I don't know). When I get a chance

[issue19715] test_touch_common failure under Windows

2013-11-22 Thread Steve Dower
Steve Dower added the comment: I don't have any extra insight into this. The documented resolution for mtime on NTFS is 100ns (2s on FAT32), so without delaying by at least that long you're not going to see an official change. The noise is probably from floating-point conversions

[issue19715] test_touch_common failure under Windows

2013-11-22 Thread Steve Dower
Steve Dower added the comment: 7. verify original_mtime - 0.001 p.stat().st_mtime original_mtime + 0.001 Actually, don't check the upper-bound here... that's a bad idea :) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org

[issue19715] test_touch_common failure under Windows

2013-11-22 Thread Steve Dower
Steve Dower added the comment: The 000 or 500 still smells of floating point rounding to me. Windows appears to round-trip the values provided perfectly: import ctypes def do_test(t): h = ctypes.windll.kernel32.CreateFileW(test.txt, 0xC000, 7, None, 2, 0, 0) assert h != -1 try

[issue19715] test_touch_common failure under Windows

2013-11-22 Thread Steve Dower
Steve Dower added the comment: Or as Martin suggested earlier, time.time() could be returning different values to what the system uses when it creates the file (which I assume is GetSystemTimeAsFileTime/SetFileTime or the kernel-mode equivalent). I only looked briefly at the touch

[issue20621] Issue with zipimport in 3.3.4

2014-02-13 Thread Steve Dower
Steve Dower added the comment: It fails for me on 3.4.0rc1 and 3.3.4: PS D:\ $env:PYTHONPATH D:\Python33_x64\Lib\site-packages\virtualenv_support\pip-1.5.2-py2.py3-none-any.whl PS D:\ py32 -V Python 3.2.3 PS D:\ py32 -c import pip; print(pip.__file__) D:\Python33_x64\Lib\site-packages

[issue20621] Issue with zipimport in 3.3.4 and 3.4.0rc1

2014-02-14 Thread Steve Dower
Steve Dower added the comment: I found that using zipimporter('...whl').load_module(pip) directly works fine, so you may be able to use that as a workaround. (Forgot to mention it in my initial comment, but that's what prompted me to check against the ABC.) I also backed out that change from

[issue20621] Issue with zipimport in 3.3.4 and 3.4.0rc1

2014-02-14 Thread Steve Dower
Steve Dower added the comment: Oddly enough, this works with 3.3.4 as released: import sys, zipfile with zipfile.ZipFile('test.zip', 'w') as f: ... f.writestr('test/__init__.py', b'print(Success!)') ... sys.path[:] = ['test.zip'] import test Success! Maybe wheel is creating archives

[issue7511] msvc9compiler.py: ValueError when trying to compile with VC Express

2014-02-23 Thread Steve Dower
Steve Dower added the comment: My patches (which I've backed away from now - between wheels and monkey patching Distutils from a setup.py, there are enough workarounds) also handled the fact that VS 2008 is no longer freely/officially available, and presumably VS 2010 will eventually go

[issue20883] Windows 'for current user' installation - 32/64-bit registrations overwrite each other

2014-03-10 Thread Steve Dower
Steve Dower added the comment: I would be in favour of having separate keys for 32-bit and 64-bit installs (in addition to the current one, if dropping it completely is not an option). We use the registry keys in PTVS (http://pytools.codeplex.com/) to detect installed interpreters, so

[issue20891] PyGILState_Ensure on non-Python thread causes fatal error

2014-03-11 Thread Steve Dower
New submission from Steve Dower: In Python 3.4rc3, calling PyGILState_Ensure() from a thread that was not created by Python and without any calls to PyEval_InitThreads() will cause a fatal exit: Fatal Python error: take_gil: NULL tstate I believe this was added in http://hg.python.org

[issue20891] PyGILState_Ensure on non-Python thread causes fatal error

2014-03-11 Thread Steve Dower
Steve Dower added the comment: Should have linked to #19576 as well, which is the issue associated with that changeset. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20891

[issue20883] Windows 'for current user' installation - 32/64-bit registrations overwrite each other

2014-03-11 Thread Steve Dower
Steve Dower added the comment: UAC is still required for the installer - unfortunately MSI just doesn't support having a single package that can do both elevated and unelevated installs. Still, you can install once per-user and then copy the PythonXY folder onto another machine, which does

[issue1284316] Win32: Security problem with default installation directory

2014-04-28 Thread Steve Dower
Changes by Steve Dower steve.do...@microsoft.com: -- nosy: +steve.dower ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1284316 ___ ___ Python-bugs

[issue21462] PEP 466: upgrade OpenSSL in the Python 2.7 Windows builds

2014-05-09 Thread Steve Dower
Steve Dower added the comment: I just tried it and had no trouble building and running the ssl tests on Windows. python Lib\test\regrtest.py -u network -v test_ssl ... Ran 38 tests in 7.700s OK (skipped=2) -- ___ Python tracker rep

[issue21467] IDLE icon not included in Windows installer

2014-05-10 Thread Steve Dower
New submission from Steve Dower: #20406 changed the icon used by IDLE, but forgot to include the new file in the Windows installer. As a result, IDLE won't start. I've attached a patch. 3.4 is unaffected, probably because msi.py changed significantly at some point. (I don't have commit

[issue21467] IDLE icon not included in Windows installer

2014-05-10 Thread Steve Dower
Steve Dower added the comment: Martin - sent. I think I need some bits flipped on my account here too. Will/can you take care of that for me? Tim - thanks. My next task was to figure out who else has an interest in this area. I wasn't sure if the 'windows' tag was accurate, but sounds like

[issue21467] IDLE icon not included in Windows installer

2014-05-10 Thread Steve Dower
Steve Dower added the comment: Currently it's an entirely manual process, which is something I intend to work on for 3.5 and beyond. As far as post-mortem on this issue goes, Martin would have found it as well, since I was doing exactly what he said he normally does. The real fix seems

[issue21467] IDLE icon not included in Windows installer

2014-05-10 Thread Steve Dower
Steve Dower added the comment: Yes, by all means, commit it. Obviously I spent too long writing my last comment :) Pushed. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21467

[issue21467] IDLE icon not included in Windows installer

2014-05-10 Thread Steve Dower
Changes by Steve Dower steve.do...@microsoft.com: -- resolution: - fixed status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21467

[issue21506] Windows MSI installer should mklink (symlink) python.exe to python2.7.exe

2014-05-14 Thread Steve Dower
Steve Dower added the comment: As far as Python 2.7 is concerned, I will be avoiding making any changes to the installer at all. For Python 3.5 I'm trying to work out a few of the install issues, one of them being not installing into Program Files. I think symlinks may be the way to make

[issue21506] Windows MSI installer should mklink (symlink) python.exe to python2.7.exe

2014-05-14 Thread Steve Dower
Steve Dower added the comment: there's a bug in Explorer that breaks opening symbolic links to EXE, COM, CMD, and BAT files Do you know which versions of Windows this applies to? It works fine for me (though I'm up to date), and the file associations have not changed. I've seen some

[issue21506] Windows MSI installer should mklink (symlink) python.exe to python2.7.exe

2014-05-14 Thread Steve Dower
Steve Dower added the comment: Apparently there's a distinction between absolute and relative symlinks. Do you see a difference between: mklink python2.7.exe python.exe and mklink python2.7.exe C:\Python27\python.exe ? -- ___ Python tracker

[issue19866] tests aifc, sunau and wave failures on a fresh Win64 installation

2014-05-18 Thread Steve Dower
Steve Dower added the comment: I noticed the same thing testing the 2.7.7rc1 installer, so I've got a fix for 2.7.7. The same issue exists for imghdrdata (which was added quite recently, it seems). Patch attached - any concerns? -- keywords: +patch nosy: +benjamin.peterson

[issue19866] tests aifc, sunau and wave failures on a fresh Win64 installation

2014-05-18 Thread Steve Dower
Steve Dower added the comment: FWIW, the installers are about 130kb larger with the files included. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19866

[issue21532] 2.7.7rc1 msi is lacking libpython27.a

2014-05-19 Thread Steve Dower
Steve Dower added the comment: Thanks for catching this. Do I need a specific version of Cygwin or will the latest version suffice? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21532

[issue21532] 2.7.7rc1 msi is lacking libpython27.a

2014-05-19 Thread Steve Dower
Steve Dower added the comment: I installed mingw32-binutils and it seems to work fine. 2.7.7 will have the file again. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21532

[issue21462] PEP 466: upgrade OpenSSL in the Python 2.7 Windows builds

2014-05-30 Thread Steve Dower
Steve Dower added the comment: I can commit it, though I don't know how it'll affect Benjamin's release branch? (Obviously the build will be fine either way - I had the patch applied for 2.7.7rc1.) -- ___ Python tracker rep...@bugs.python.org http

[issue21623] build ssl failed use vs2010 express

2014-06-02 Thread Steve Dower
Steve Dower added the comment: Has the first log been abbreviated at all? It looks like it's trying to build the tests before building the library... (Nosied Martin, since he's managed to build this version of OpenSSL with VC10 and may have encountered this. I've only dealt with VC9 so far

[issue21427] installer not working

2014-06-03 Thread Steve Dower
Steve Dower added the comment: eryksun's analysis is correct. If the component is marked 64-bit then it will not install on a 32-bit OS. This needs to be switched for the 32-bit installer. (I also don't see why you'd want to set the 64-bit SharedDLLs key for a 32-bit DLL. Is there some reason

[issue21427] installer not working

2014-06-03 Thread Steve Dower
Steve Dower added the comment: That reasoning makes sense. I don't see any other way to achieve the same thing without requiring a newer version of Windows Installer on the machine (msidbComponentAttributesDisableRegistryReflection requires 4.0). Having a second component for 32-bit OS may

[issue21665] 2.7.7 ttk widgets not themed

2014-06-05 Thread Steve Dower
Steve Dower added the comment: I compiled with COMPILERFLAGS=-DWINVER=0x0500 OPTS=noxp DEBUG=0 for tcl and tix, and with just COMPILERFLAGS=-DWINVER=0x0500 DEBUG=0 for tk. These should have matched the buildbot scripts, and I'm fairly sure they haven't changed since 2.7.6, which means

[issue21665] 2.7.7 ttk widgets not themed

2014-06-06 Thread Steve Dower
Steve Dower added the comment: You're right, I had OPTS for tk and tix. I think I'm going to modify my build scripts to use the buildbot scripts wherever possible. I also need to parameterise msi.py a bit so I don't have to modify it for releases

[issue21665] 2.7.7 ttk widgets not themed

2014-06-06 Thread Steve Dower
Steve Dower added the comment: The buildbot scripts don't build tix and the build_tkinter.py script has a blatant error which prevents it from ever working (and old version numbers). I have no experience with the buildbots, but I don't see how they can possibly be producing correct builds

[issue21665] 2.7.7 ttk widgets not themed

2014-06-06 Thread Steve Dower
Steve Dower added the comment: That's fine for 2.7. I'm working on streamlining the project files for 3.5 to make my life easier dealing with both installers and the multiple compiler situation, so I'll no doubt poke that project at some point until my grand vision of single-click-install

[issue21671] CVE-2014-0224: OpenSSL upgrade to 1.0.1h on Windows required

2014-06-08 Thread Steve Dower
Steve Dower added the comment: The only reason to do it is to help out those who build from source, which I suspect is an incredibly small group on Windows. We'd also be signing up to keep doing it, and implying that it's been tested. I say don't bother. From

[issue19143] Finding the Windows version getting messier (detect windows 8.1?)

2014-06-10 Thread Steve Dower
Steve Dower added the comment: The two 'correct' options are adding the manifest or doing nothing (based on a number of very passionate internal discussions I was able to dig up). Without the manifest, various APIs may behave differently - it's the new way that Windows decides whether

[issue15993] Windows: 3.3.0-rc2.msi: test_buffer fails

2014-06-10 Thread Steve Dower
Steve Dower added the comment: test_memoryview_assign seems to be okay, but the two test_lzma tests still fail with the same message. Both pass without PGO. I'll get in touch with the PGO team and try and get it fixed. I haven't checked, but it looks consistent with Stefan's analysis

[issue19143] Finding the Windows version getting messier (detect windows 8.1?)

2014-06-10 Thread Steve Dower
Steve Dower added the comment: So have platform.win32_ver() return the true version is acceptable ? Note that the platform module is meant for identifying the platform, not the runtime compatibility environment, so it has a slightly different target audience Yes, and that's exactly

[issue19351] python msi installers - silent mode

2014-06-13 Thread Steve Dower
Steve Dower added the comment: I've noticed this as well. I'm hoping to do a significant rework of the installer for 3.5 and will keep this in mind, but I honestly have no idea how to diagnose this in the current setup. Windows Installer is responsible for the missing entries, and AFAIK

[issue19351] python msi installers - silent mode

2014-06-13 Thread Steve Dower
Steve Dower added the comment: This may actually be a Windows issue... the keys for uninstall are being written to the Wow6432Node of the registry (on a 64-bit machine), and apparently the Programs and Features panel does not read them from there. The 64-bit installers should be fine (testing

[issue19351] python msi installers - silent mode

2014-06-13 Thread Steve Dower
Steve Dower added the comment: Apparently keys in Wow6432Node are actually okay, so I'm not much closer to figuring this out. As far as I can tell, the entry I have for Python 2.6.6 (which doesn't appear) has identical information to IronPython 2.7.4 (which does appear

[issue19351] python msi installers - silent mode

2014-06-13 Thread Steve Dower
Steve Dower added the comment: Okay, now it looks to me like the install that 'works' ran under the SYSTEM account while the one that didn't work ran under my (admin) user account. This may be caused by running the installer from an elevated command prompt. If it detects that it needs

[issue15993] Windows: 3.3.0-rc2.msi: test_buffer fails

2014-06-14 Thread Steve Dower
Steve Dower added the comment: It's actually bad code generation for the switch statement in build_filter_spec() in _lzmamodule.c. I've filed a bug, so hopefully it will be fixed, but if not then it should be easy enough to exclude that function (or even the whole module - _lzmamodule.c

[issue15993] Windows: 3.3.0-rc2.msi: test_buffer fails

2014-06-14 Thread Steve Dower
Steve Dower added the comment: Isn't PyLong_FromUnsignedLongLong() still involved through spec_add_field()? The two issues were unrelated - the 'invalid filter ID' (4611686018427387905 == 0x4000_0001) is the correct value but the wrong branch in the switch was taken, leading

[issue2943] Distutils should generate a better error message when the SDK is not installed

2014-06-16 Thread Steve Dower
Steve Dower added the comment: I can certainly improve this for 3.5 as part of the move to VC14 (which will require changes to distutils anyway). The installer won't touch it. For earlier Python versions, I'd quite like to see setuptools take over detection from distutils and provide

[issue10009] Automated MSI installation does not work

2014-06-17 Thread Steve Dower
Steve Dower added the comment: If we wanted to migrate the instructions to 2.7/3.5 as suggested then there's some updating to do, but if there's no plan to update them then I agree, there's nothing to do here. FWIW, the 3.5 installer will accept the same command line options as previous

[issue10136] kill_python doesn't work with short path

2014-06-17 Thread Steve Dower
Steve Dower added the comment: My usual way of doing this is to use taskkill.exe, but that only uses process name and not the full path, which may hurt people who are building with other versions of Python open. I'd rather use GetFullPathName than the current patch, but if wontfix

[issue15993] Windows: 3.3.0-rc2.msi: test_buffer fails

2014-06-19 Thread Steve Dower
Steve Dower added the comment: I'd be fine to reconsider if a previously-demonstrated bug is now demonstrated-fixed. However, if the actual bug persists, optimization should be disabled for all code, not just for the code that allows to demonstrate the bug. I'm okay with that. I thought

[issue1602] windows console doesn't print or input Unicode

2014-06-21 Thread Steve Dower
Steve Dower added the comment: My understanding is that the best way to write Unicode to the console is through WriteConsoleW(), which seems to be where this discussion ended up. The only apparent sticking point is that this would cause an ordering incompatibility with `stdout.write

[issue17620] Python interactive console doesn't use sys.stdin for input

2014-06-21 Thread Steve Dower
Steve Dower added the comment: Thanks Nick, but this has a pretty clear scope that may help the Unicode situation in cmd but doesn't directly relate to it. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17620

[issue19351] python msi installers - silent mode

2014-06-23 Thread Steve Dower
Steve Dower added the comment: The difference may be the ALLUSERS=1 option. Windows Installer is supposed to auto-detect this when an installer is run as an admin, but maybe something in our authoring is preventing this detection? When I get a chance I'll try both and see if the logs show

[issue19351] python msi installers - silent mode

2014-06-23 Thread Steve Dower
Steve Dower added the comment: It's described at http://msdn.microsoft.com/en-us/library/aa367559(v=vs.85).aspx, and frankly it is incredibly confusing. It is possible to reset ALLUSERS on the command line by specifying ALLUSERS= -- ___ Python

[issue19351] python msi installers - silent mode

2014-06-23 Thread Steve Dower
Steve Dower added the comment: No idea, TBH, though I'd guess that the behaviour comes from the installed version of Windows Installer and the database schema comes from the authored version. Nonetheless, if the solution is to add ALLUSERS=1 to the command line when doing silent all-user

[issue15993] Windows: 3.3.0-rc2.msi: test_buffer fails

2014-06-23 Thread Steve Dower
Steve Dower added the comment: This has been confirmed as a bug in VC14 (and earlier) and there'll be a fix going in soon. For those interested, here's a brief rundown of the root cause: * the switch in build_filter_spec() switches on a 64-bit value * one case is 0x4001

[issue12653] Provide accelerators for all buttons in Windows installers

2014-06-24 Thread Steve Dower
Steve Dower added the comment: Should be there for 3.5 because I'm rewriting the installer. Up to Martin whether he wants to change it for 3.4. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12653

[issue9973] Sometimes buildbot fails to cleanup working copy

2014-06-27 Thread Steve Dower
Steve Dower added the comment: Probably, but that work is not going to be checked in for a while (until we have guarantees that we'll be able to use VC14 and there's a 'go-live' version available). If this is causing problems now, it should be fixed. The patch looks fine to me, but Zachary

[issue21907] Update Windows build batch scripts

2014-07-02 Thread Steve Dower
Steve Dower added the comment: Looks pretty good. I'm happy to see more move into PCBuild - ideally, people building a Python release should never have to look anywhere else. buildmsi.bat can probably go away completely if the buildbots aren't using it. 3.5 will eventually have a .wixproj

[issue20513] Python 2.7. Script interruption on logoff from 0 session under Win2003 and earlier

2014-07-08 Thread Steve Dower
Steve Dower added the comment: Looks like a legitimate issue to me, and the patch is fine. It's probably something that ought to be fixed in default too, since I don't see how it is restricted to session 0 - any Python service will incorrectly treat these notifications as interruptions. Sent

[issue16229] Demo *redemo.py* lacking in Windows installation

2014-07-10 Thread Steve Dower
Steve Dower added the comment: Looks like tools/demo just isn't included. I'm totally okay with including it - looks like a few nice examples in there that I've never seen before. If someone wants to do a patch for msi.py that's fine, but I'm intending to have a completely new installer

[issue14802] Python fails to compile with VC11 ARM configuration

2014-07-10 Thread Steve Dower
Steve Dower added the comment: The build environment won't help here, this requires some significant rewrites within Python to remove usage of Windows APIs that don't work under the WinRT sandbox (similar to the projects to embed Python in Chromium et al.) I'd still like to see it done

[issue21953] pythonrun.c does not check std streams the same as fileio.c

2014-07-10 Thread Steve Dower
New submission from Steve Dower: In pythonrun.c, the is_valid_fd() function checks whether fileno(std*) are valid before attempting to create IO objects for them. However, the class created also checks using fstat(). In pythonw.exe built with VS 2013 (or 14, maybe 2012), the fstat() check

[issue21958] Allow python 2.7 to compile with Visual Studio 2013

2014-07-11 Thread Steve Dower
Steve Dower added the comment: The fix is certainly needed in default, though I already have it in my fork for porting to VC14. I'm okay with the HAVE_ROUND change, but I think the VS2013 project files are better off kept separate. We won't be rebuilding 2.x with a newer compiler, so

[issue21959] msi product code for 2.7.8150 not in Tools/msi/uuids.py

2014-07-11 Thread Steve Dower
Steve Dower added the comment: Yeah, I patched my msi.py to get the build going but haven't checked it in (it was already after the tag...). I'll fill out the next few minor versions and check it in. -- ___ Python tracker rep...@bugs.python.org

[issue21953] pythonrun.c does not check std streams the same as fileio.c

2014-07-11 Thread Steve Dower
Steve Dower added the comment: This is definitely the same as #17797, so I'll close this as a dup. Over on that issue, it's confirmed as fixed in VC14 (and it is - I've checked). -- resolution: - duplicate status: open - closed ___ Python tracker

[issue16561] bdist_wininst installers don't use UAC, then crash

2014-07-14 Thread Steve Dower
Changes by Steve Dower steve.do...@microsoft.com: -- nosy: +steve.dower ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16561 ___ ___ Python-bugs

[issue17480] pyvenv should be installed someplace more obvious on Windows

2014-07-14 Thread Steve Dower
Steve Dower added the comment: Automatically quoting arguments is more complicated than simply concatenating quotes, unfortunately, and people are guaranteed to have come up with ways to make it work already. My vote is for leaving this alone and letting the higher level functions be more

[issue17480] pyvenv should be installed someplace more obvious on Windows

2014-07-14 Thread Steve Dower
Steve Dower added the comment: That last message should have been on #20451 :) My thoughts on pyvenv are that it should be in Scripts\ if anywhere, but I'm not desperate to have it on PATH. I would rather not start putting more files alongside python.exe

[issue20451] os.exec* mangles argv on windows (splits on spaces, etc)

2014-07-14 Thread Steve Dower
Steve Dower added the comment: Automatically quoting arguments is more complicated than simply concatenating quotes, unfortunately, and people are guaranteed to have come up with ways to make it work already. My vote is for leaving this alone and letting the higher level functions be more

[issue15883] Add Py_errno to work around multiple CRT issue

2014-07-14 Thread Steve Dower
Steve Dower added the comment: Also agreed with not exposing a side-channel to set errno. I'd expect this to no longer be an issue with the stable CRT, but I'm not 100% confident about saying that yet. In theory, there will only ever be one CRT loaded in the future, but there's probably going

[issue17056] Support Visual Studio 2012

2014-07-14 Thread Steve Dower
Steve Dower added the comment: msvc9compiler should not look for any versions of MSVC other than 9.0, since extensions built using other versions will be subtly (or dramatically) incompatible with Python unless you also rebuild Python itself with the same MSVC version. You can set

[issue18016] subprocess should open stdin in mode w+b on windows

2014-07-15 Thread Steve Dower
Steve Dower added the comment: With 2.7 and 3.4 (same for 32- and 64-bit): f = open('test.bin', 'wb') f.write(b' ' * (1024*1024*100)) 104857600 f.close() import os os.stat('test.bin').st_size 104857600 The linked KB only applies to VS 2003 and VS 2005 (VC7 and VC8), so I'm not entirely

[issue19450] Bug in sqlite in Windows binaries

2014-07-15 Thread Steve Dower
Steve Dower added the comment: I don't know enough about the SQLite API to determine whether we can safely upgrade from 3.6.21 in Python 2.7, but since this doesn't appear to be a security issue I don't see any solid justification for doing it anyway. If someone else does it, I'll build

[issue19450] Bug in sqlite in Windows binaries

2014-07-15 Thread Steve Dower
Changes by Steve Dower steve.do...@microsoft.com: -- nosy: +benjamin.peterson ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19450 ___ ___ Python

[issue21959] msi product code for 2.7.8150 not in Tools/msi/uuids.py

2014-07-17 Thread Steve Dower
Steve Dower added the comment: Yes. I don't have permission to close issues. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21959 ___ ___ Python

[issue22028] Python 3.4.1 Installer ended prematurely (Windows msi)

2014-07-22 Thread Steve Dower
Steve Dower added the comment: You can always deselect pip from the installation. Running it separately after installation will no doubt show what the actual problem is. -- nosy: +loewis ___ Python tracker rep...@bugs.python.org http

[issue18402] Finding perl64

2014-07-31 Thread Steve Dower
Steve Dower added the comment: At one point the version of OpenSSL on svn.python.org did not have the correct makefiles for a 64-bit Windows build, but this was resolved. You also don't need 64-bit Perl to generate these files, and the file has been renamed to prepare_ssl.py and appears

[issue19955] When adding .PY and .PYW to PATHEXT, it replaced string instead of appending

2014-08-04 Thread Steve Dower
Steve Dower added the comment: That installer doesn't even try and set PATHEXT, and the 3.4 installer appears to set it correctly (for .PY, but not .PYW). Are you sure it was an installer from python.org that overwrote your setting? -- ___ Python

[issue10071] Should not release GIL while running RegEnumValue

2014-08-04 Thread Steve Dower
Steve Dower added the comment: I don't think this is an appropriate fix, since in most cases there is no need to prevent other Python threads running while inside RegSetValue. There are also other ways that a context switch may occur during the enumeration which will put the program

[issue22028] Python 3.4.1 Installer ended prematurely (Windows msi)

2014-08-07 Thread Steve Dower
Steve Dower added the comment: Presumably the value for subkeyname being passed to OpenKey contains an embedded null, which I believe is legal for the registry in general, but doesn't make much sense in this context and is quite possibly a corruption issue on your machine. We can certainly

[issue22028] Python 3.4.1 Installer ended prematurely (Windows msi)

2014-08-07 Thread Steve Dower
Steve Dower added the comment: FWIW, on my machine I don't have embedded nulls in any of the values that enum_keys is looking for: import winreg hkcr=winreg.OpenKey(winreg.HKEY_CLASSES_ROOT, '') n = [] i = 0 while True: ... try: ... n.append(winreg.EnumKey(hkcr, i)) ... except

[issue22160] Windows installers need to be updated following OpenSSL security release

2014-08-07 Thread Steve Dower
Steve Dower added the comment: The 2.7 installer will be fine whenever the release manager asks for it -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22160

[issue22028] Python 3.4.1 Installer ended prematurely (Windows msi)

2014-08-07 Thread Steve Dower
Steve Dower added the comment: Agreed on both points, but we need to find someone willing to fix the 3.4 installer (I'm completely focused on the 3.5 installer, which won't suffer from the first point). There's a separate issue tracker for pip which would be the place to get their developers

[issue22177] Incorrect version reported after downgrade

2014-08-12 Thread Steve Dower
Steve Dower added the comment: Not in future 2.7 installers, certainly. As for 3.5 and later, I'm not a fan of the global install anyway. I'd much rather Python applications install a private copy of python##.dll, and I count python.exe as just another application that should have a private

[issue20042] Python Launcher, Windows, fails on scripts w/ non-latin names

2014-08-18 Thread Steve Dower
Steve Dower added the comment: It should be fixable. In general, Unicode in the console is fine, but the CRT doesn't handle it well (as shown by the _setmode extension being able to fix it). The 'correct' fix for Unicode in the console is at http://www.siao2.com/2010/04/07/9989346.aspx

[issue7511] msvc9compiler.py: ValueError when trying to compile with VC Express

2014-08-18 Thread Steve Dower
Steve Dower added the comment: There is other work going on that will make the patches unnecessary. One problem is that vcvarsall.bat isn't where msvc9compiler.py is looking, which can be fixed with monkey patching in setup.py or in setuptools. The other problem is that VC9 is hard to get

[issue22299] resolve() on Windows makes some pathological paths unusable

2014-08-29 Thread Steve Dower
Steve Dower added the comment: Is resolve() using an *A() API rather than *W()? The \\?\ prefix does not work with *A() APIs. Also, names that are all dots are not supported by Windows at all. I'd expect mkdir() to fail on that, but the \\?\ prefix disables some validation, so it's possible

[issue22299] resolve() on Windows makes some pathological paths unusable

2014-08-29 Thread Steve Dower
Steve Dower added the comment: Removing the _ext_to_normal() call in resolve() looks like the right fix to me. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22299

[issue22329] Windows installer can't recover partially installed state

2014-09-02 Thread Steve Dower
Steve Dower added the comment: I've been working on the rewrite for 3.5 already (progress at http://hg.python.org/sandbox/steve.dower) - redoing the installer completely was one of the conditions for when I signed on to own it. Martin is still responsible for 3.4, and I'm building 2.7

[issue22302] Windows os.path.isabs UNC path bug

2014-09-05 Thread Steve Dower
Steve Dower added the comment: Antoine almost certainly thought about this with pathlib and may know about the change, or at least have some decent context on it. I'm more inclined to think that os.path.isabs(r\\server) should also return False, since it's not a path that can be opened

[issue22299] resolve() on Windows makes some pathological paths unusable

2014-09-05 Thread Steve Dower
Steve Dower added the comment: Patch attached. (Kinda feel like this was too simple...) -- keywords: +patch Added file: http://bugs.python.org/file36549/22299_1.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22299

  1   2   3   4   5   6   7   8   9   10   >