Vidar Fauske added the comment:
Note that this is still an issue on Windows:
>>> import locale
>>> locale.getdefaultlocale()
('en_US', 'cp1252')
>>> locale.setlocale(locale.getdefaultlocale())
Error: unsupported locale setting
--
comp
Vidar Fauske added the comment:
Thanks. Note that the failing with `
locale.setlocale(locale.LC_ALL, locale.getdefaultlocale())` I mentioned above
is a different problem, that is tracked in a much older issue:
https://bugs.python.org/issue10466
Vidar Fauske added the comment:
Seems as if this was resolved by the linked PR in 3.8, or am I missing
something?
--
nosy: +vidartf
___
Python tracker
<https://bugs.python.org/issue26
Vidar Fauske added the comment:
On Python 3.8.5 on Windows using the code from the above patch I recently got a
stack overflow:
Thread 0x2054 (most recent call first):
File "...\lib\concurrent\futures\thread.py", line 78 in _worker
File "...\lib\threading.py", li
Vidar Fauske added the comment:
A somewhat easy repro:
Create the temporary directory, add a subdir (not sure if subdir truly
necessary at this point), use `os.chdir()` to set the cwd to that subdir. Clean
up the temp dir. The cwd should prevent the deletion because it will be "in
Vidar Fauske added the comment:
Thanks for the detailed explanation Eryk. While it is a little annoying that it
comes 2 years after the initial proposed solution, I'll happily take that if
the end result is a better fix :)
That being said, this fix seems quite a bit more involv
New submission from Vidar Fauske:
On Windows (Windows 10 in my case), given the following directory structure:
- rootfolder
- a
- b
- junc (directory junction to ../a)
a call to `shutil.rmtree('root')` will fail with an exception
`FileNotFoundError: [WinError 3]`, in a call to `
New submission from Vidar Fauske:
As explained in this Microsoft blogpost
(https://blogs.windows.com/buildingapps/2016/12/02/symlinks-windows-10/), it is
possible on newer versions of Windows 10 for non-privileged users to create
symlinks when the machine is in developer mode. However, to
Changes by Vidar Fauske :
--
pull_requests: +3645
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue31512>
___
___
Python-bugs-list mai
Vidar Fauske added the comment:
Thanks for the informative comments. I opened a PR based on this feedback.
Would you mind checking if it conforms to what you had in mind?
--
___
Python tracker
<https://bugs.python.org/issue31
Vidar Fauske added the comment:
The PR has been sitting for a while now with all previous concerns addressed.
There has been a few pings on the PR without anything new happening, so I
thought I would ping this issue as well: are there any other concerns about
this PR, or anything else that
Vidar Fauske added the comment:
Thanks! I addressed the comment, so hopefully this should be OK now.
--
___
Python tracker
<https://bugs.python.org/issue31
Vidar Fauske added the comment:
This issue can still be triggered for Python 3.7 by the following line (running
on a Windows machine with a Norwegian locale as default):
locale.setlocale(locale.LC_ALL, locale.getdefaultlocale())
--
versions: +Python 3.7
Vidar Fauske added the comment:
I think the submitted PR could need a pair of eyes now. I've sorted the merge
conflicts, and addressed the previous review points by eryksun.
--
___
Python tracker
<https://bugs.python.org/is
Vidar Fauske added the comment:
A PR that fixes the issue according to the feedback from Eryk Sun is available.
It does seem to have stranded a bit on the review side. That being said, would
a bugfix for shutil.rmtree be appropriate? It is very annoying when junction
points made by other
New submission from Vidar Fauske:
The Norwegian locale on Windows has the honor of having the only locale name
with a non-ASCII character ('Norwegian Bokmål_Norway', see e.g.
https://wiki.postgresql.org/wiki/Changes_To_Norwegian_Locale). It does not seem
like python 3 is able to h
Change by Vidar Fauske :
--
keywords: +patch
pull_requests: +5764
stage: test needed -> patch review
___
Python tracker
<https://bugs.python.org/issu
17 matches
Mail list logo
