[issue18819] tarfile fills devmajor and devminor fields even for non-devices

2020-02-01 Thread William Chargin
William Chargin added the comment: My pleasure. Is there anything else that you need from me to close this out? It looks like the PR is approved and in an “awaiting merge” state, but I don’t have access to merge it. -- ___ Python tracker <ht

[issue39389] gzip metadata fails to reflect compresslevel

2020-01-19 Thread William Chargin
New submission from William Chargin : The `gzip` module properly uses the user-specified compression level to control the underlying zlib stream compression level, but always writes metadata that indicates that the maximum compression level was used. Repro: ``` import gzip blob = b"The

[issue39389] gzip metadata fails to reflect compresslevel

2020-01-19 Thread William Chargin
William Chargin added the comment: (The commit reference above was meant to be git558f07891170, not a Mercurial reference. Pardon the churn; I'm new here. :-) ) -- ___ Python tracker <https://bugs.python.org/issue39

[issue39389] gzip metadata fails to reflect compresslevel

2020-01-19 Thread William Chargin
Change by William Chargin : -- type: -> behavior ___ Python tracker <https://bugs.python.org/issue39389> ___ ___ Python-bugs-list mailing list Unsubscrib

[issue39389] gzip metadata fails to reflect compresslevel

2020-01-20 Thread William Chargin
Change by William Chargin : -- keywords: +patch pull_requests: +17470 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/18077 ___ Python tracker <https://bugs.python.org/issu

[issue39389] gzip metadata fails to reflect compresslevel

2020-01-20 Thread William Chargin
William Chargin added the comment: PR URL, for reference: <https://github.com/python/cpython/pull/18077> -- ___ Python tracker <https://bugs.python.org/i

[issue39389] gzip metadata fails to reflect compresslevel

2020-01-20 Thread William Chargin
William Chargin added the comment: Sure, PR sent (pull_request17470). -- ___ Python tracker <https://bugs.python.org/issue39389> ___ ___ Python-bugs-list mailin

[issue39389] gzip metadata fails to reflect compresslevel

2020-01-22 Thread William Chargin
William Chargin added the comment: My pleasure; thanks for the triage and review! -- ___ Python tracker <https://bugs.python.org/issue39389> ___ ___ Python-bug

[issue18819] tarfile fills devmajor and devminor fields even for non-devices

2020-01-20 Thread William Chargin
William Chargin added the comment: I've just independently run into this and sent a patch as a pull request. Happily, once this is fixed, the output of `tarfile` is bit-for-bit compatible with the output of GNU `tar(1)`. PR: <https://github.com/python/cpython/pull/18080> -

[issue18819] tarfile fills devmajor and devminor fields even for non-devices

2020-01-20 Thread William Chargin
Change by William Chargin : -- versions: +Python 3.5, Python 3.6, Python 3.7, Python 3.8, Python 3.9 ___ Python tracker <https://bugs.python.org/issue18

[issue18819] tarfile fills devmajor and devminor fields even for non-devices

2020-01-20 Thread William Chargin
Change by William Chargin : -- pull_requests: +17472 stage: -> patch review pull_request: https://github.com/python/cpython/pull/18080 ___ Python tracker <https://bugs.python.org/issu

[issue41706] docs: operator dunder (`__add__`, et al.) invocations described incorrectly

2020-09-03 Thread William Chargin
New submission from William Chargin : The operator override dunder methods, like `__add__`, are described in the “Data model” docs here: <https://docs.python.org/3.10/reference/datamodel.html#object.__add__> Those docs say: > For instance, to evaluate the expression `x + y`,

[issue41706] docs: operator dunder (`__add__`, et al.) invocations described incorrectly

2020-09-03 Thread William Chargin
Change by William Chargin : -- keywords: +patch pull_requests: +21170 stage: -> patch review pull_request: https://github.com/python/cpython/pull/22084 ___ Python tracker <https://bugs.python.org/issu