[issue16651] Find out what stdlib modules lack a pure Python implementation

2012-12-13 Thread Zachary Ware
Changes by Zachary Ware zachary.w...@gmail.com: -- nosy: +zach.ware ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16651 ___ ___ Python-bugs-list

[issue16694] Add pure Python operator module

2012-12-15 Thread Zachary Ware
New submission from Zachary Ware: (Brett, I've made you nosy due to the relation to Issue16651.) Here is a pure Python implementation of the operator module, or at least a first draft thereof :). I'm attaching the module itself, as well as a patch to integrate it. Any and all review

[issue16694] Add pure Python operator module

2012-12-15 Thread Zachary Ware
Changes by Zachary Ware zachary.w...@gmail.com: -- keywords: +patch Added file: http://bugs.python.org/file28328/py_operator.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16694

[issue16694] Add pure Python operator module

2012-12-19 Thread Zachary Ware
Zachary Ware added the comment: Sorry to have disappeared on this, other things took priority... Thank you for the comments, Serhiy. v2 of the patch renames Modules/operator.c to Modules/_operator.c, and changes that name every place I could find it. I also tried to tidy up some of the error

[issue16694] Add pure Python operator module

2012-12-19 Thread Zachary Ware
Zachary Ware added the comment: Considering what a huge headache it was to get my own patch to apply at home on Linux rather than at work on Windows, here's a new version of the patch that straightens out the line ending nightmare present in v2. No other changes made. -- Added file

[issue16694] Add pure Python operator module

2012-12-19 Thread Zachary Ware
Changes by Zachary Ware zachary.w...@gmail.com: Removed file: http://bugs.python.org/file28373/py_operator.v2.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16694

[issue16694] Add pure Python operator module

2012-12-20 Thread Zachary Ware
Zachary Ware added the comment: Here's v4, addressing Serhiy's comments on Reitveld. -- Added file: http://bugs.python.org/file28383/py_operator.v4.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16694

[issue16694] Add pure Python operator module

2012-12-21 Thread Zachary Ware
Zachary Ware added the comment: Here's another new version. Changes include: - Address Serhiy's Rietveld comments - Fix length_hint() the way it was meant to be fixed last time. - Remove __getitem__ check on 'b' in concat and iconcat. More notes on this below. - Fix methodcaller as Serhiy

[issue16694] Add pure Python operator module

2012-12-21 Thread Zachary Ware
Zachary Ware added the comment: Nits are no fun; thank you for picking them, Serhiy ;) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16694

[issue16694] Add pure Python operator module

2012-12-21 Thread Zachary Ware
Zachary Ware added the comment: Did not know that about test discovery, thank you Éric. Fixed in v6. A few other test modules may need the same fix; I based my changes to Lib/test/test_operator.py on Lib/test/test_heapq.py which has the same issue. I'll open a new report for it and any

[issue16747] Remove 'file' type reference from 'iterable' glossary entry

2012-12-21 Thread Zachary Ware
New submission from Zachary Ware: Here's a patch that changes the reference to :class:`file` in the iterable entry in Doc/glossary.rst to :term:`file objects file object`, along with minor grammatical fixes to make it fit, and reflowing of the text. -- assignee: docs@python components

[issue16748] Ensure test discovery doesn't break for modules testing C and Python implementations

2012-12-21 Thread Zachary Ware
New submission from Zachary Ware: As pointed out by Éric Araujo in msg177908 of issue16694, tests using the idiom presented in PEP 399 are subject to breakage of test discovery. This issue's goal is to root out and fix all usages of this idiom. So far, only test_heapq is known to be affected

[issue16747] Remove 'file' type reference from 'iterable' glossary entry

2013-01-01 Thread Zachary Ware
Zachary Ware added the comment: Hi folks, Sorry it's taken me so long to get back to this, it's been a busy month :) Here's the non-reflowed diff. In retrospect, I should have just specifically mentioned the grammatical changes I made in the first place; they were merely to change

[issue16694] Add pure Python operator module

2013-01-01 Thread Zachary Ware
Zachary Ware added the comment: Sorry, I misunderstood Éric's suggestions regarding the tests; v6 is useless. v7 forthcoming. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16694

[issue16694] Add pure Python operator module

2013-01-01 Thread Zachary Ware
Changes by Zachary Ware zachary.w...@gmail.com: Removed file: http://bugs.python.org/file28391/py_operator.v6.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16694

[issue16694] Add pure Python operator module

2013-01-01 Thread Zachary Ware
Zachary Ware added the comment: Ok, I believe the attached v7 properly addresses Éric's concerns about test discovery, and has no other changes unrelated to that compared to v5. Thank you very much to Ezio for directing me towards the json tests for an example to work from. -- nosy

[issue16694] Add pure Python operator module

2013-01-01 Thread Zachary Ware
Changes by Zachary Ware zachary.w...@gmail.com: Added file: http://bugs.python.org/file28524/py_operator.v8.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16694

[issue16747] Remove 'file' type reference from 'iterable' glossary entry

2013-01-01 Thread Zachary Ware
Changes by Zachary Ware zachary.w...@gmail.com: Added file: http://bugs.python.org/file28525/issue16747.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16747

[issue16747] Remove 'file' type reference from 'iterable' glossary entry

2013-01-01 Thread Zachary Ware
Changes by Zachary Ware zachary.w...@gmail.com: Removed file: http://bugs.python.org/file28520/iterable_glossary_no-reflow.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16747

[issue16747] Remove 'file' type reference from 'iterable' glossary entry

2013-01-01 Thread Zachary Ware
Changes by Zachary Ware zachary.w...@gmail.com: Removed file: http://bugs.python.org/file28392/iterable_glossary.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16747

[issue16694] Add pure Python operator module

2013-01-02 Thread Zachary Ware
Zachary Ware added the comment: Note to self: learn to run patchcheck.py before posting. Whitespace issues fixed in v9. -- Added file: http://bugs.python.org/file28532/py_operator.v9.diff ___ Python tracker rep...@bugs.python.org http

[issue16748] Make CPython test package discoverable

2013-01-02 Thread Zachary Ware
Zachary Ware added the comment: Here's a patch that should clear up test_genericpath.py (and other path tests). -- resolution: fixed - title: Ensure test discovery doesn't break for modules testing C and Python implementations - Make CPython test package discoverable Added file: http

[issue16835] Update PEP 399 to allow for test discovery

2013-01-02 Thread Zachary Ware
Zachary Ware added the comment: A few minor grammatical and style nits in the prose added at the end of the diff: +The test module defines a base class with the tests methods that access the +``heapq`` module through a ``self.heapq`` class attribute, and two subclasses +that set

[issue16748] Make CPython test package discoverable

2013-01-03 Thread Zachary Ware
Zachary Ware added the comment: Here's version 2 of the genericpath patch. Should I try to fix everything in one patch, or one patch per test module (or group of test modules like test_(generic|mac|nt|posix)path.py)? And if separate, should each one get its own issue, or just keep them all

[issue16835] Update PEP 399 to allow for test discovery

2013-01-03 Thread Zachary Ware
Zachary Ware added the comment: Thanks for the review, new patch attached. You're quite welcome. Is there anything I've missed in the process of reviewing itself? This is the first time I've reviewed a patch here... I did miss another nit in the prose, though; the tests methods

[issue15067] Clean up the sqlite3 docs

2013-01-03 Thread Zachary Ware
Changes by Zachary Ware zachary.w...@gmail.com: Removed file: http://bugs.python.org/file27829/sqlite3_cleanup_2.7.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15067

[issue15067] Clean up the sqlite3 docs

2013-01-03 Thread Zachary Ware
Changes by Zachary Ware zachary.w...@gmail.com: Removed file: http://bugs.python.org/file27830/sqlite3_cleanup_3.2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15067

[issue16748] Make CPython test package discoverable

2013-01-03 Thread Zachary Ware
Zachary Ware added the comment: Sounds good to me. Shall I move the genericpath fix to a new issue, or leave that one here and begin starting new issues with the next one tackled? Any volunteers for being nosied on new issues to make the dependency link back to this one for me

[issue16852] Fix test discovery for test_genericpath.py

2013-01-03 Thread Zachary Ware
New submission from Zachary Ware: See Issue 16748 for previous discussion. This patch should fix test_genericpath.py, with changes to test_macpath.py, test_ntpath.py, and test_posixpath.py required by the fix to test_genericpath.py. This is version 2 of the patch after a review by Serhiy

[issue16852] Fix test discovery for test_genericpath.py

2013-01-03 Thread Zachary Ware
Changes by Zachary Ware zachary.w...@gmail.com: -- keywords: +patch Added file: http://bugs.python.org/file28543/issue16852.v2.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16852

[issue5066] IDLE documentation for Unix obsolete/incorrect

2013-01-04 Thread Zachary Ware
Zachary Ware added the comment: Hi Todd, I can't commit, but I have a review in the works for you. -- nosy: +zach.ware ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5066

[issue16835] Update PEP 399 to allow for test discovery

2013-01-04 Thread Zachary Ware
Zachary Ware added the comment: Looks good to me :) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16835 ___ ___ Python-bugs-list mailing list

[issue16852] Fix test discovery for test_genericpath.py

2013-01-04 Thread Zachary Ware
Zachary Ware added the comment: My apologies, I seem to have managed to rename the wrong file... Here's the real v2 as v3, with the TestGenericTest comment pointing to this issue instead of 16748. -- Added file: http://bugs.python.org/file28567/issue16852.v3.diff

[issue14187] add function annotation entry to Glossary

2013-01-04 Thread Zachary Ware
Changes by Zachary Ware zachary.w...@gmail.com: -- versions: +Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14187 ___ ___ Python-bugs

[issue5066] IDLE documentation for Unix obsolete/incorrect

2013-01-07 Thread Zachary Ware
Zachary Ware added the comment: I wonder, is there any really good reason to keep a separate Lib/idlelib/help.txt, or can Doc/library/idle.rst be used for its purpose (with or without a small amount of processing to, for instance, remove comments and extra backslashes)? Both have most

[issue5066] IDLE documentation for Unix obsolete/incorrect

2013-01-07 Thread Zachary Ware
Zachary Ware added the comment: Right you are, Todd; I'll get another issue opened for that soon. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5066

[issue16748] Make CPython test package discoverable

2013-01-07 Thread Zachary Ware
Zachary Ware added the comment: I've come up with a semi-comprehensive list of the tests that cause ugly failures with test discovery. Tests were run on 3.4 debug, on Windows 7 32bit without several of the 'external' projects built, using the command ``PCbuild\python_d.exe -m unittest

[issue16888] Fix test discovery for test_array.py

2013-01-07 Thread Zachary Ware
New submission from Zachary Ware: Here's a patch to fix test_array.py -- components: Tests files: test_array.diff keywords: patch messages: 179291 nosy: brett.cannon, ezio.melotti, zach.ware priority: normal severity: normal status: open title: Fix test discovery for test_array.py type

[issue5066] IDLE documentation for Unix obsolete/incorrect

2013-01-08 Thread Zachary Ware
Zachary Ware added the comment: I'd like to see Éric, Ezio, and my comments on v3 in Rietveld addressed, but after that I'm good with it :) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5066

[issue16893] Create IDLE help.txt from Doc/library/idle.rst

2013-01-08 Thread Zachary Ware
New submission from Zachary Ware: Lib/idlelib/help.txt and Doc/library/idle.rst contain almost exactly the same information, only formatted a bit differently. This issue is to suggest the merger of the two files, by way of creating help.txt from idle.rst as a part of the build or install

[issue5066] IDLE documentation for Unix obsolete/incorrect

2013-01-08 Thread Zachary Ware
Zachary Ware added the comment: Issue 16893 has been filed to deal with the idea of merging the files. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5066

[issue16896] Fix test discovery for test_asyncore.py

2013-01-08 Thread Zachary Ware
New submission from Zachary Ware: Here's the fix for test_asyncore.py. -- components: Tests files: test_asyncore_fix.diff keywords: patch messages: 179373 nosy: brett.cannon, ezio.melotti, zach.ware priority: normal severity: normal status: open title: Fix test discovery

[issue16897] Fix test discovery for test_bisect.py

2013-01-08 Thread Zachary Ware
New submission from Zachary Ware: Here's the fix for test_bisect.py. This one has an extra change, that of replacing the manual method of obtaining c_bisect and py_bisect with two calls to support.import_fresh_module. This one also has an extra wrench thrown in the gears by including a few

[issue16898] Fix test discovery for test_bufio.py

2013-01-08 Thread Zachary Ware
Changes by Zachary Ware zachary.w...@gmail.com: -- components: Tests files: test_bufio_fix.diff keywords: patch nosy: brett.cannon, ezio.melotti, zach.ware priority: normal severity: normal status: open title: Fix test discovery for test_bufio.py type: behavior versions: Python 3.3

[issue16897] Fix test discovery for test_bisect.py

2013-01-08 Thread Zachary Ware
Zachary Ware added the comment: A general comment about these patches: I think it would be better to remove test_main() (and related unnecessary code) with unittest.main(). One of the advantage of doing it now is that you can simply test discovery by doing ./python Lib/test/test_foo.py

[issue5066] IDLE documentation for Unix obsolete/incorrect

2013-01-09 Thread Zachary Ware
Zachary Ware added the comment: Version 4 looks good to me! -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5066 ___ ___ Python-bugs-list mailing

[issue16852] Fix test discovery for test_genericpath.py

2013-01-09 Thread Zachary Ware
Zachary Ware added the comment: Version 4 replaces test_main() with unittest.main() -- Added file: http://bugs.python.org/file28650/issue16852.v4.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16852

[issue16897] Fix test discovery for test_bisect.py

2013-01-09 Thread Zachary Ware
Zachary Ware added the comment: Here's version 2 of the patch, which converts the doctests to a standard testcase and removes test_main(). -- Added file: http://bugs.python.org/file28651/test_bisect_fix.v2.diff ___ Python tracker rep

[issue16896] Fix test discovery for test_asyncore.py

2013-01-09 Thread Zachary Ware
Zachary Ware added the comment: Patch v2, in which test_main() goes away. -- Added file: http://bugs.python.org/file28652/test_asyncore_fix.v2.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16896

[issue16888] Fix test discovery for test_array.py

2013-01-09 Thread Zachary Ware
Zachary Ware added the comment: Version 2 removes test_main() and associated ``tests`` list. -- Added file: http://bugs.python.org/file28654/test_array.v2.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16888

[issue16898] Fix test discovery for test_bufio.py

2013-01-09 Thread Zachary Ware
New submission from Zachary Ware: Version 2 replaces test_main() with unittest.main(). -- Added file: http://bugs.python.org/file28655/test_bufio_fix.v2.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16898

[issue16905] Fix test discovery for test_warnings

2013-01-09 Thread Zachary Ware
New submission from Zachary Ware: Patch looks good to me. Thank you, Berker! -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16905

[issue16910] Fix test discovery for bytes/string tests

2013-01-09 Thread Zachary Ware
New submission from Zachary Ware: This patch fixes discovery for test_bytes.py. That fix changes string_tests.py, which breaks test_unicode.py and test_userstring.py, so those two files have been changed as well. All three test files also use unittest.main() now instead of test_main

[issue16910] Fix test discovery for bytes/string tests

2013-01-09 Thread Zachary Ware
Changes by Zachary Ware zachary.w...@gmail.com: -- type: - behavior ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16910 ___ ___ Python-bugs-list

[issue16918] Fix test discovery for test_codecs.py

2013-01-10 Thread Zachary Ware
New submission from Zachary Ware: Here's the fix for test_codecs.py, I believe. I had a few headaches trying to get this patch created without changing some of the characters or adding a BOM to the file, and at one point the test was failing for no apparent reason. This version of the patch

[issue16919] Fix test discovery for test_crypt.py

2013-01-10 Thread Zachary Ware
New submission from Zachary Ware: Here's a fix for test_crypt.py, inspired by Ezio's mention of using setUpModule in issue 16905. I can't test this on a platform that actually has _crypt at the moment, but I should be able to later today if nobody else has before then. Some tinkering has

[issue16925] Fix test discovery for test_configparser.py

2013-01-10 Thread Zachary Ware
Changes by Zachary Ware zachary.w...@gmail.com: -- components: Tests files: test_configparser_discovery.diff keywords: patch nosy: brett.cannon, ezio.melotti, zach.ware priority: normal severity: normal status: open title: Fix test discovery for test_configparser.py type: behavior

[issue16919] Fix test discovery for test_crypt.py

2013-01-10 Thread Zachary Ware
Zachary Ware added the comment: I was just about to test it at home and couldn't find it in my list of open issues. Thanks, Ezio :) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16919

[issue16935] unittest should understand SkipTest at import time during test discovery

2013-01-11 Thread Zachary Ware
Changes by Zachary Ware zachary.w...@gmail.com: -- nosy: +zach.ware ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16935 ___ ___ Python-bugs-list

[issue16935] unittest should understand SkipTest at import time during test discovery

2013-01-14 Thread Zachary Ware
Zachary Ware added the comment: I agree that raising SkipTest (or subclasses thereof, such as ResourceDenied) at module level should be supported. That would mean no changes would be needed in most of the should-be-skipped-but-fail-instead tests listed in issue 16748 to make test discovery

[issue16893] Create IDLE help.txt from Doc/library/idle.rst

2013-01-14 Thread Zachary Ware
Zachary Ware added the comment: Georg: Note that Sphinx' make text output already should be suitable. We already update the pydoc topics with that on every release, so we could just as well do the same for the IDLE doc. No need for another separate script. I take it this would mean

[issue16748] Make CPython test package discoverable

2013-01-14 Thread Zachary Ware
Zachary Ware added the comment: Chris: There are lots of modules to change here. I wonder if some or most of this couldn't be automated. Possibly, but I don't mind going through individually if Ezio (or others) don't mind committing individually. From what I've seen, the test suite

[issue16893] Create IDLE help.txt from Doc/library/idle.rst

2013-01-14 Thread Zachary Ware
Zachary Ware added the comment: I don't think we have to worry about it getting out of date quickly. Fair point :) Automatically generating the IDLE help at run time from a documentation source file is not posssible anyway, since the doc sources are not available in a standard location

[issue16748] Make CPython test package discoverable

2013-01-14 Thread Zachary Ware
Zachary Ware added the comment: For the conversion from test_main() to unittest.main(), I could certainly see automation helping a lot; most cases are very simple. But really, that issue is somewhat tangential to this one and in my last message I was thinking from the perspective of just

[issue16968] Fix test discovery for test_concurrent_futures.py

2013-01-14 Thread Zachary Ware
New submission from Zachary Ware: Here's an incomplete patch to test_concurrent_futures.py that does not convert from test_main() to unittest.main(); the decorator on test_main has me unsure how to make the conversion. I've attempted moving various parts of the decorator's functions

[issue16968] Fix test discovery for test_concurrent_futures.py

2013-01-14 Thread Zachary Ware
Zachary Ware added the comment: That looks quite good, except for the fact that discovery (of the form `python -m unittest discover Lib/test/ 'test_*.py'`) won't hit reap_threads or reap_children. It does cover `python -m test.test_concurrent_futures` and standard regrtest, though; is 2 out

[issue16968] Fix test discovery for test_concurrent_futures.py

2013-01-14 Thread Zachary Ware
Zachary Ware added the comment: Ok then, I'll update the patch. Thanks, Brett! -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16968

[issue16968] Fix test discovery for test_concurrent_futures.py

2013-01-15 Thread Zachary Ware
Zachary Ware added the comment: Hmmm, actually, I was wrong; Brett's suggestion doesn't cover running as part of regrtest. It looks like Chris is right and some kind of load_tests magic will have to happen. I'm looking into it now. -- ___ Python

[issue16893] Create IDLE help.txt from Doc/library/idle.rst

2013-01-16 Thread Zachary Ware
Zachary Ware added the comment: Sorry, I wasn't as clear as I meant to be in my last message, I was suddenly rushed and didn't realize I'd left out what I meant to say, which was: Now that Andrew has committed Todd's fix to issue 5066, idle.rst and help.txt are very well-aligned. I believe

[issue16968] Fix test discovery for test_concurrent_futures.py

2013-01-24 Thread Zachary Ware
Zachary Ware added the comment: I'm at a loss on this one. I tried a few different methods of wrapping the tests in load_tests(), I tried doing support.threading_setup() in setUpModule and support.threading_cleanup() in tearDownModule, tried the same in each test class (following the example

[issue16968] Fix test discovery for test_concurrent_futures.py

2013-01-28 Thread Zachary Ware
Zachary Ware added the comment: Thank you, Chris. I'm rather ashamed of how long I've spent beating my head on this issue and missed the spare tests reference in runtest_inner. Simply removing the tests name entirely clears things up, if this isn't too ugly: diff -r 5f655369ef06 Lib/test

[issue16935] unittest should understand SkipTest at import time during test discovery

2013-01-28 Thread Zachary Ware
Zachary Ware added the comment: Here's a patch that I believe nicely handles the raising of unittest.SkipTest at module level while doing test discovery. It adds a _make_skipped_test function to unittest.loader, and an ``except case.SkipTest`` clause to TestLoader._find_tests. For our own

[issue17066] Fix test discovery for test_robotparser.py

2013-01-28 Thread Zachary Ware
New submission from Zachary Ware: Here's a fix for test_robotparser.py. With this patch, the command 'python -m unittest discover Lib/test/ test_*.py' can actually be run--before the patch, test_robotparser's unique TestCase subclass causes unexpected errors for discovery

[issue16968] Fix test discovery for test_concurrent_futures.py

2013-01-29 Thread Zachary Ware
Zachary Ware added the comment: Right you are, Chris. v4 has a comment added to regrtest.runtest_inner pointing back to this issue. Also in v4, ReapedSuite has been moved to test.support. At least one other test module (test_pydoc) uses the same idiom as test_concurrent_futures, and so

[issue16694] Add pure Python operator module

2013-01-29 Thread Zachary Ware
Zachary Ware added the comment: Since the older Windows project files were removed, v10 removes the patches to them. Everything else still applies cleanly. Also, in the spirit of what Brett said in 16651 about not re-implementing blindly, I did just look up what Jython, IronPython, and PyPy

[issue16968] Fix test discovery for test_concurrent_futures.py

2013-01-29 Thread Zachary Ware
Zachary Ware added the comment: I failed to mention; v4 also removes setUpModule() which was present in the first 3 patches. With 16935 fixed, setUpModule would be unnecessary. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org

[issue17079] Fix test discovery for test_ctypes.py

2013-01-29 Thread Zachary Ware
Changes by Zachary Ware zachary.w...@gmail.com: -- components: Tests files: test_ctypes_discovery.diff keywords: patch nosy: brett.cannon, ezio.melotti, zach.ware priority: normal severity: normal status: open title: Fix test discovery for test_ctypes.py type: behavior versions: Python

[issue17082] Fix test discovery for test_dbm*.py

2013-01-30 Thread Zachary Ware
New submission from Zachary Ware: This patch fixes discovery for test_dbm.py and removes test_main() from test_dbm, test_dbm_dumb, test_dbm_gnu, and test_dbm_ndbm. It also removes unnecessary __init__ methods from DumbDBMTestCase and WhichDBTestCase, which only called unittest.TestCase

[issue17163] Fix test discovery for test_file.py

2013-02-08 Thread Zachary Ware
Changes by Zachary Ware zachary.w...@gmail.com: -- components: Tests files: test_file_discovery.diff keywords: patch nosy: brett.cannon, ezio.melotti, zach.ware priority: normal severity: normal status: open title: Fix test discovery for test_file.py type: behavior versions: Python 3.3

[issue16935] unittest should understand SkipTest at import time during test discovery

2013-02-11 Thread Zachary Ware
Zachary Ware added the comment: Sure can. With a little luck, I'll have the patch ready later today; with less luck it'll be sometime later this week. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16935

[issue16935] unittest should understand SkipTest at import time during test discovery

2013-02-11 Thread Zachary Ware
Zachary Ware added the comment: I think this patch should cover the test and Doc changes necessary. Of course, let me know if it doesn't :) -- Added file: http://bugs.python.org/file29039/issue16935.v2.diff ___ Python tracker rep...@bugs.python.org

[issue9822] windows batch files are dependent on cmd current directory

2013-02-13 Thread Zachary Ware
Zachary Ware added the comment: I just stumbled across this issue in looking for another issue, and this turns out to be of interest to me as well. As such, I've updated sorin's patch to apply to the current default branch, added the same kind of change to the new-since-then clean-amd64.bat

[issue9822] windows batch files are dependent on cmd current directory

2013-02-13 Thread Zachary Ware
Zachary Ware added the comment: Here's the patch that moves external*.bat into PCbuild. I also took the opportunity to give the three files more descriptive names: external.bat - get_externals.bat, external-common.bat - get_common_externals.bat, and external-amd64.bat - get_externals-amd64

[issue17202] Add .bat line to .hgeol

2013-02-13 Thread Zachary Ware
New submission from Zachary Ware: Most times (though not all, for some reason) I try to use Doc\make.bat update, it fails with The system cannot find the batch label specified - update even though it is obviously there. The reason for this appears to be the fact that the file uses UNIX line

[issue16893] Create IDLE help.txt from Doc/library/idle.rst

2013-02-14 Thread Zachary Ware
Zachary Ware added the comment: Ping! If there are no objections, would anyone mind committing this? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16893

[issue17202] Add .bat line to .hgeol

2013-02-15 Thread Zachary Ware
Zachary Ware added the comment: This seems to suggest that CRLF shouldn't be necessary. It's not necessary on .bat files without labels, but those with labels are subject to the (Windows) bug described in my first message and link. Adding an entry specifically for Doc/make.bat and any other

[issue17217] Fix test discovery for test_format.py on Windows

2013-02-16 Thread Zachary Ware
New submission from Zachary Ware: test_format is an interesting case in the ongoing test discovery conversion. It already uses unittest.main(), but still has test_main(), and discovery seems to work fine on Linux. On Windows, however, test_format and test_non_ascii both fail

[issue16893] Create IDLE help.txt from Doc/library/idle.rst

2013-02-17 Thread Zachary Ware
Zachary Ware added the comment: Actually, I have an objection myself. In merging this patch with another I'm working on, I noticed that I failed to include the new 'idledoc' target in the Makefile usage message. The attached patch fixes that oversight. -- Added file: http

[issue16248] Security bug in tkinter allows for untrusted, arbitrary code execution.

2013-02-20 Thread Zachary Ware
Zachary Ware added the comment: I believe we're also waiting on input from Barry about whether to apply the patch to 2.6. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16248

[issue16248] Security bug in tkinter allows for untrusted, arbitrary code execution.

2013-02-20 Thread Zachary Ware
Zachary Ware added the comment: Does the 2.x patch apply cleanly to 2.6? It should, if I remember correctly, though I haven't checked since uploading it. I believe there were actually very few or no changes to the file the patch is for between 2.6 and 2.7

[issue16893] Create IDLE help.txt from Doc/library/idle.rst

2013-02-20 Thread Zachary Ware
Zachary Ware added the comment: Here's a new version of the patch, with the fixes that Ned pointed out. I also tried to address concerns about lost information; menu divisions have been added to Doc/library/idle.rst, along with the blurb about running without a subprocess being deprecated

[issue16893] Create IDLE help.txt from Doc/library/idle.rst

2013-02-20 Thread Zachary Ware
Changes by Zachary Ware zachary.w...@gmail.com: Removed file: http://bugs.python.org/file28725/issue16893.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16893

[issue17217] Fix test discovery for test_format.py on Windows

2013-02-22 Thread Zachary Ware
Zachary Ware added the comment: Your patch is certainly much simpler and more effective than mine; consider mine withdrawn. I didn't take the simple step of figuring out exactly where the problem was happening and was just trying to fix the issue without changing anything in the actual tests

[issue16935] unittest should understand SkipTest at import time during test discovery

2013-02-25 Thread Zachary Ware
Zachary Ware added the comment: Thanks for the review, Ezio. I've made some changes and here's the new patch. -- Added file: http://bugs.python.org/file29237/issue16935.v3.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org

[issue17220] Little enhancements of _bootstrap.py

2013-02-25 Thread Zachary Ware
Zachary Ware added the comment: 2528e4aea338 seems to have broken building on Windows: http://buildbot.python.org/all/builders/AMD64%20Windows7%20SP1%203.x/builds/1517 -- nosy: +zach.ware ___ Python tracker rep...@bugs.python.org http

[issue17303] Fix test discovery for test_future*

2013-02-26 Thread Zachary Ware
New submission from Zachary Ware: Here's the fix for test discovery of test_future* (particularly test_future3). Without the patch, running 'python -m unittest discover Lib/test/ test_future*' results in an error in test_future3.py, due to test_future.py's FutureTest.test_future3 removing

[issue17303] Fix test discovery for test_future*

2013-02-26 Thread Zachary Ware
Zachary Ware added the comment: Correction: ...all instances of support.unload *in test_future.py* with support.CleanImport... -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17303

[issue17304] Fix test discovery for test_hash.py

2013-02-26 Thread Zachary Ware
Changes by Zachary Ware zachary.w...@gmail.com: -- components: Tests files: test_hash_discovery.diff keywords: patch nosy: brett.cannon, ezio.melotti, zach.ware priority: normal severity: normal status: open title: Fix test discovery for test_hash.py type: behavior versions: Python 3.3

[issue17079] Fix test discovery for test_ctypes.py

2013-02-27 Thread Zachary Ware
New submission from Zachary Ware: Version 1 converts test_main() into load_tests(). Version 2 removes the now unnecessary import of run_unittest from support; thank you to Ezio for reminding me to look at imports in these patches. -- Added file: http://bugs.python.org/file29272

[issue17082] Fix test discovery for test_dbm*.py

2013-02-27 Thread Zachary Ware
Zachary Ware added the comment: Version 2 removes an unnecessary import in test_dbm_gnu.py -- Added file: http://bugs.python.org/file29273/test_dbm-s_discovery.v2.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17082

  1   2   3   4   5   6   7   8   9   10   >