New submission from anthony shaw:
This is related to issue26188,
Using await in a simple statement (outside of an async def method) raises
SyntaxError with the unhelpful message "invalid syntax".
It seems obvious once you've read PEP492 in detail, but I think that as more
and more
Changes by anthony shaw <anthonys...@apache.org>:
--
stage: -> resolved
status: open -> closed
___
Python tracker <rep...@bugs.python.org>
<http://bugs.
Changes by anthony shaw <anthonys...@apache.org>:
--
pull_requests: +1215
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30029>
___
anthony shaw added the comment:
yey! I figured it out!!
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30029>
___
___
Pyth
New submission from anthony shaw <anthony.p.s...@gmail.com>:
observing a behaviour on Python 3.7 b2 that doesn't match what's documented in
PEP 538
PEP 538 states that the locale coercion behaviour can be disabled through the
PYTHONCOERCECLOCALE environment variable.
I would then
anthony shaw added the comment:
thanks terry,
Some great pointers there, I'll review the exiting work and the README doc.
With regards to my experience, I have quite extensive experience with python
testing. Most of which would be open-source on my Github profile
https://github.com
New submission from anthony shaw :
idlelib is one of the lesser-tested libraries in cpython:
https://codecov.io/gh/python/cpython/tree/master/Lib/idlelib
Raising this issue and also volunteering to extend the test module to get
coverage across major behaviours and functions that are missing
anthony shaw added the comment:
I was looking at the debugger.py module as being a good place the start,
writing test cases for the Idb, Debugger, StackViewer and NamespaceViewer by
patching out the dependant components (bdb, Idb, etc.
I might start there, raise a PR against it and do
Change by anthony shaw :
--
keywords: +patch, patch
pull_requests: +10913, 10914
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issu
Change by anthony shaw :
--
keywords: +patch, patch, patch, patch
pull_requests: +10913, 10914, 10915, 10916
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issu
Change by anthony shaw :
--
keywords: +patch
pull_requests: +10913
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue35668>
___
___
Py
Change by anthony shaw :
--
keywords: +patch, patch, patch
pull_requests: +10913, 10914, 10916
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issu
anthony shaw added the comment:
thanks Cheryl,
here's my branch https://github.com/tonybaloney/cpython/tree/idlelib_tests
I've already seen some code which is 17 years old!
--
___
Python tracker
<https://bugs.python.org/issue35
New submission from anthony shaw :
The documentation for pathlib PurePath.match(needle) says it accepts
"glob-style pattern.".
For an absolute path with a recursive pattern (**) it doesn't match correct for
more than 1 directory level.
All of the assertions in the attached file s
anthony shaw added the comment:
Raised a PR for the test. Will look into doc PR
--
___
Python tracker
<https://bugs.python.org/issue35488>
___
___
Python-bug
Change by anthony shaw :
--
keywords: +patch
pull_requests: +10410
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue35488>
___
___
Py
anthony shaw added the comment:
Yes, this is similar to https://bugs.python.org/issue29249
In that issue, it suggests this feature is not supported, but that is neither
documented, nor tested.
--
nosy: -serhiy.storchaka
___
Python tracker
<ht
Change by anthony shaw :
--
pull_requests: +10972
___
Python tracker
<https://bugs.python.org/issue35668>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by anthony shaw :
--
pull_requests: +10972, 10973
___
Python tracker
<https://bugs.python.org/issue35668>
___
___
Python-bugs-list mailing list
Unsub
Change by anthony shaw :
--
keywords: +patch
pull_requests: +10971
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issu
Change by anthony shaw :
--
nosy: +pablogsal
___
Python tracker
<https://bugs.python.org/issue36500>
___
___
Python-bugs-list mailing list
Unsubscribe:
anthony shaw added the comment:
This applies to PyUnicode_EncodeFSDefault as well, it has the same issue
--
___
Python tracker
<https://bugs.python.org/issue36
anthony shaw added the comment:
I'm expecting a "this is not a bug, why would the interpreter not be
initialized", but it would be nice to get a friendly error message since this
is a public API.
IF so, am also happy to submit a PR
New submission from anthony shaw :
If for whatever reason, Py_Initialize() has not been run or failed to run, any
call to Py_CompileStringFlags will call PyUnicode_DecodeFSDefault and the
reference to interp will be NULL.
There is currently no null reference check
anthony shaw added the comment:
This is because PyUnicode_DecodeFSDefaultAndSize calls
_PyInterpreterState_GET_UNSAFE(), which already documents the potential NULL
return value.
/* Get the current interpreter state.
The macro is unsafe: it does not check for error and it can return
Change by anthony shaw :
--
resolution: -> not a bug
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue36420>
___
___
anthony shaw added the comment:
Took a while, but I worked out a solution:
import sys
import dis
import traceback
import io
def t(frame, event, args):
frame.f_trace_opcodes=True
stack = traceback.extract_stack(frame)
pad = " "*len(stack) + "|"
New submission from anthony shaw :
The f_trace_opcodes flag for sys.settrace in 3.7 are proving tricky.
I must be missing something but it's not clear how it helps in tracing the
opcode about to be executed because it runs before opcode and oparg variables
are set by NEXTOPARG(), so
New submission from anthony shaw :
Now that pgen is written in Python, it'd be useful for Windows users to be able
to rebuild grammar and tokens into the parser table.
The current hook (make regen-grammar) is built into the Makefile.
Add support for VS2017+ vcxproj files to call the script
Change by anthony shaw :
--
keywords: +patch
pull_requests: +12583
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue36500>
___
___
Py
Change by anthony shaw :
--
nosy: +brett.cannon, steve.dower
___
Python tracker
<https://bugs.python.org/issue36500>
___
___
Python-bugs-list mailing list
Unsub
anthony shaw added the comment:
Project now also does:
regen-symbol (regenerate Lib/symbol.py)
and regen-keyword (regenerate Lib/keyword.py)
--
___
Python tracker
<https://bugs.python.org/issue36
anthony shaw added the comment:
The opcode would not solely apply to this specific use case.
I could seek another way of implementing the same behaviour without an
additional opcode?
--
___
Python tracker
<https://bugs.python.org/issue36
Change by anthony shaw :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by anthony shaw :
--
keywords: +patch
pull_requests: +12644
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue36551>
___
___
Py
New submission from anthony shaw :
When calculating length of range() objects that have an r->length >
PY_SIZE_MAX, the underlying PyLong_AsSsize_t() function will raise an
OverflowError:
>>> a = list(range(2**256))
Traceback (most recent call last):
File "",
New submission from anthony shaw :
List comprehensions currently create a series of opcodes inside a code object,
the first of which is BUILD_LIST with an oparg of 0, effectively creating a
zero-length list with a preallocated size of 0.
If you're doing a simple list comprehension
Change by anthony shaw :
--
keywords: +patch
pull_requests: +12646
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue36552>
___
___
Py
Change by anthony shaw :
--
type: -> enhancement
___
Python tracker
<https://bugs.python.org/issue36551>
___
___
Python-bugs-list mailing list
Unsubscrib
anthony shaw added the comment:
> How about converting `[x for x in it]` to `[*it]` in AST?
I should have been more explicit, this patch improves the performance of all
list comprehensions that don’t have an if clause.
Not just
[x for x in y]
but:
d = {} # some sort of dictionary
[f
anthony shaw added the comment:
> This patch makes it slow for small iterators
That is a one-off cost for the __length_hint__ of the range object specifically.
Objects with a known length (lists, sets, tuples) would not have that overhead.
I can run a more useful set of benchmarks agai
anthony shaw added the comment:
> If your patch uses __length_hint__, it is bug.
iterator will return 2**1000 for __length_hint__, but produce no item
on iteration.
It raises an OverflowError because of the goto
https://github.com/python/cpython/pull/12718/files#d
anthony shaw added the comment:
> If your patch uses __length_hint__, it is bug.
I’m not sure I understand this comment,
PEP424 says “This is useful for presizing containers when building from an
iterable.“
This patch uses __length_hint__ to presize the list container for a l
anthony shaw added the comment:
> This might cause a MemoryError when the __length_hint__ of the source returns
> a too large value, even when the actual size of the comprehension is smaller,
> e.g.:
The current implementation of list comprehensions raise neither a memoryerror
or
anthony shaw added the comment:
> In such case, current behavior works. And your patch will raise
> OverflowError.
Try
[x for x in range(2**1000)]
in a REPL. It doesn’t raise anything, it tries to create a list that will
eventually exceed PY_SIZE_MAX, but it only crashes once it r
anthony shaw added the comment:
>I am -1 for this optimization because it affects only one particular case
>(neither other kinds of comprehensions, nor generator expressions, nor list
>comprehensions with
conditions) and even in this case it is small. It is possible to add a lot
anthony shaw added the comment:
Have just optimized some of the code and pushed another change as 69dce1c552.
ran both master and 69dce1c552 using pyperformance with PGO:
➜ ~ python3.8 -m perf compare_to master.json 69dce1c552.json --table
anthony shaw added the comment:
"When the C library is called in ctypes to return the c_char_p type, the
problem that only the string before \0 can be obtained when the string contains
\\0"
This function is specifically for null-terminated strings (\0), please could
you be mor
anthony shaw added the comment:
thanks, your code example zero-pads the socket address, and looking at the
socketmodule.c code it does some padding under certain circumstances.
https://github.com/python/cpython/blob/master/Modules/socketmodule.c#L1318-L1330
The Unix man page specify the same
anthony shaw added the comment:
The existing tests in place add the null-termination bytes in the test string:
def testLinuxAbstractNamespace(self):
address = b"\x00python-test-hello\x00\xff"
with socket.socket(socket.AF_UNIX, socket.SOCK_STREAM) as s1:
Change by anthony shaw :
--
versions: +Python 3.8 -Python 2.7, Python 3.4, Python 3.7
___
Python tracker
<https://bugs.python.org/issue25541>
___
___
Python-bug
anthony shaw added the comment:
>From lldb
(lldb) run ~/cpython/test_gc_ctypes.py
Process 20059 launched: '/Users/anthonyshaw/CLionProjects/cpython/python.exe'
(x86_64)
Fatal Python error: deallocating None
Current thread 0x0001005c85c0 (most recent call first):
File &quo
anthony shaw added the comment:
In the stack it's calling none_dealloc() which should never happen.
Assume this is being triggered by ctypes PyCFuncPtr_call.
The stacktrace I'm getting comes after the double decref so it's not showing
the root cause. Someone who knows ctypes better might
anthony shaw added the comment:
Closing as duplicate of 36882
--
nosy: +anthonypjshaw
___
Python tracker
<https://bugs.python.org/issue36883>
___
___
Python-bug
Change by anthony shaw :
--
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue36883>
___
___
Python-bugs-list
anthony shaw added the comment:
The documentation says:
>>
Note Make sure you keep references to CFUNCTYPE() objects as long as they are
used from C code. ctypes doesn’t, and if you don’t, they may be garbage
collected, crashing your program when a callback is made.
Also
anthony shaw added the comment:
Thanks, I'll check this out
--
assignee: -> anthonypjshaw
nosy: +anthonypjshaw
___
Python tracker
<https://bugs.python.org/issu
anthony shaw added the comment:
Thanks Eryk that saved a lot of debugging.
dgelessus - if you want to write a patch for CPython am happy to take you
through this and get it over the line.
Else: am Happy to write a test against the gc counter and a patch
anthony shaw added the comment:
If you can write a test similar to the AnotherLeak.test_callback test case, and
commit that first.
It will show in the CI/CD log as failed and verify the issue (incase it comes
up in PR review)
Then add another commit with the patch itself and we should see
anthony shaw added the comment:
thanks, will wait for a review from Serhiy, Rbcollins or ezio
--
___
Python tracker
<https://bugs.python.org/issue24263>
___
___
anthony shaw added the comment:
Hi,
This discussion came to a stop, but it doesn't seem conclusive.
PEP discussions are now in GitHub on https://github.com/python/peps/issues so
I'm going to close this BPO issue.
There is no additional section in PEP 7 for this level of detail
Change by anthony shaw :
--
assignee: -> anthonypjshaw
nosy: +anthonypjshaw
___
Python tracker
<https://bugs.python.org/issue36551>
___
___
Python-bugs-lis
Change by anthony shaw :
--
assignee: -> anthonypjshaw
nosy: +anthonypjshaw
___
Python tracker
<https://bugs.python.org/issue36552>
___
___
Python-bugs-lis
anthony shaw added the comment:
Full trace for reference:
(lldb) bt all
* thread #1, queue = 'com.apple.main-thread', stop reason = signal SIGABRT
* frame #0: 0x7fff5984f2c6 libsystem_kernel.dylib`__pthread_kill + 10
frame #1: 0x7fff59904bf1 libsystem_pthread.dylib`pthread_kill
Change by anthony shaw :
--
keywords: +patch
pull_requests: +13126
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue36862>
___
___
Py
New submission from anthony shaw :
The PCBuild tool should support VS2019 but default to 2017 as per documentation.
PR to follow.
--
assignee: anthonypjshaw
components: Build
messages: 341963
nosy: anthonypjshaw
priority: normal
severity: normal
status: open
title: Add Visual Studio
Change by anthony shaw :
--
nosy: +steve.dower
stage: patch review ->
___
Python tracker
<https://bugs.python.org/issue36862>
___
___
Python-bugs-list mai
Change by anthony shaw :
--
assignee: -> anthonypjshaw
nosy: +anthonypjshaw
___
Python tracker
<https://bugs.python.org/issue36500>
___
___
Python-bugs-lis
Change by anthony shaw :
--
nosy: +anthonypjshaw
___
Python tracker
<https://bugs.python.org/issue35668>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by anthony shaw :
--
resolution: -> rejected
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
anthony shaw added the comment:
Hi Nofar are you still interested on working on this request?
--
nosy: +anthonypjshaw
___
Python tracker
<https://bugs.python.org/issue28
anthony shaw added the comment:
Closing as 3rd party feature for setuptools
--
nosy: +anthonypjshaw
resolution: -> third party
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
anthony shaw added the comment:
The assertions in the attached test still fail on master (3.8a3), so this still
applies.
Michael, are you able to look at this, the code hasn't changed since the
original PEP417 implementation, which doesn't specify if this behaviour should
be supported
anthony shaw added the comment:
hi, which version of Python were you using to do this? Please could you provide
the full code snippet to reproduce the issue.
The following example binds to the correct namespace
from socket import *
sock = socket(AF_UNIX, SOCK_STREAM)
sock.bind(&qu
New submission from anthony shaw :
I noticed that the termios.c module is largely untested.
There is some coverage via test_pty, test_ioctl and test_getpass, but there is
nothing to cover regression and the behaviours in the module functions.
Tests are required for:
- termios.tcgetattr
anthony shaw added the comment:
This could be a good issue for the PyCon sprints, otherwise I'm happy to
implement it
--
___
Python tracker
<https://bugs.python.org/issue36
anthony shaw added the comment:
Raised a fix in GH-13144
--
stage: patch review ->
___
Python tracker
<https://bugs.python.org/issue36814>
___
___
Python-
anthony shaw added the comment:
Issue is in parse_file_actions
parse_file_actions(PyObject *file_actions,
posix_spawn_file_actions_t *file_actionsp,
PyObject *temp_buffer)
{
PyObject *seq;
PyObject *file_action = NULL;
PyObject *tag_obj
anthony shaw added the comment:
Submitted PR to add the deprecation warning, since this initial discussion,
some other functions also raise DeprecationWarning's in code.
--
nosy: +anthonypjshaw
___
Python tracker
<https://bugs.python.
Change by anthony shaw :
--
pull_requests: -9605
___
Python tracker
<https://bugs.python.org/issue32971>
___
___
Python-bugs-list mailing list
Unsubscribe:
anthony shaw added the comment:
Converted the original patch as a PR GH-13142 this seems like a good idea and
an easy change
--
nosy: +anthonypjshaw
___
Python tracker
<https://bugs.python.org/issue28
Change by anthony shaw :
--
keywords: +patch
pull_requests: +13040
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue34946>
___
___
Py
Change by anthony shaw :
--
keywords: +patch
pull_requests: +13050
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue24939>
___
___
Py
anthony shaw added the comment:
Eric, there have been further changes to Objects/stringlib/unicode_format.h
since this original note, I've raised a PR with the intent of your note from
2015.
There also hasn't been any change to the situation, unicode_format.h is only
used
anthony shaw added the comment:
> The things that are in this file but are unrelated to unicodeobject.c
are the support routines for implementing string.Formatter.
I'm not sure which functions that relates to, if you could let me know I'd be
happy to add those to the
Change by anthony shaw :
--
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue32971>
___
___
Pyth
anthony shaw added the comment:
After patch:
Python 3.8.0a3+ (heads/31968-dirty:c664b342a4, May 6 2019, 18:06:21)
[Clang 10.0.1 (clang-1001.0.46.4)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>>
anthony shaw added the comment:
This issue has been open for some time, looking at the install_lib in master,
there have been no changes to call 'build_clib' so the issue documented here
would still apply.
--
nosy: +anthonypjshaw
___
Python
Change by anthony shaw :
--
nosy: +dstufft, ncoghlan
___
Python tracker
<https://bugs.python.org/issue5243>
___
___
Python-bugs-list mailing list
Unsubscribe:
anthony shaw added the comment:
The discussion on python-ideas has some unresolved questions. Wren, did you get
a definitive answer on this idea?
--
nosy: +anthonypjshaw
___
Python tracker
<https://bugs.python.org/issue31
anthony shaw added the comment:
Francisco, I recommend converting the patch into a GitHub pull request to make
it easier to code review.
Mark, Raymond, please could you re-review this patch.
--
nosy: +anthonypjshaw, rhettinger
___
Python tracker
anthony shaw added the comment:
Revisiting this issue as it's still open. The original patch was for 3.3a0,
there have been many changes to both IDLE and the Windows build since,
including the recent IDLE entry point in the new Windows installer.
Steve, Terry, please could you review
Change by anthony shaw :
--
nosy: +giampaolo.rodola
___
Python tracker
<https://bugs.python.org/issue34368>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by anthony shaw :
--
pull_requests: +13055
___
Python tracker
<https://bugs.python.org/issue28367>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by anthony shaw :
--
keywords: +patch
pull_requests: +13057
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue36814>
___
___
Py
anthony shaw added the comment:
The code is mostly:
FieldNameIterator * related functions
FormatterIterator * related functions
MarkupIterator * related functions
There are a few other utility methods in there as well
--
___
Python tracker
anthony shaw added the comment:
Added a PR for the documentation clarification.
--
nosy: +anthonypjshaw
___
Python tracker
<https://bugs.python.org/issue31
Change by anthony shaw :
--
pull_requests: +13053
___
Python tracker
<https://bugs.python.org/issue31968>
___
___
Python-bugs-list mailing list
Unsubscribe:
anthony shaw added the comment:
It would be great for this issue to be revisited, there has been some further
interest from users.
--
nosy: +anthonypjshaw
___
Python tracker
<https://bugs.python.org/issue27
anthony shaw added the comment:
Easily reproduced on master, thanks
(lldb) run encode_crash.py
Process 14743 launched: '/Users/anthonyshaw/repo/cpython/python.exe' (x86_64)
Objects/unicodeobject.c:448: _PyUnicode_CheckConsistency: Assertion
"((PyObject*)(op))->ob_type))->tp_fl
1 - 100 of 162 matches
Mail list logo
