Roundup Robot added the comment:
New changeset 7708f80940b0 by Terry Jan Reedy in branch '3.4':
Issue #10291: Backport 004fe3449193 with a few changes due to 22095.
http://hg.python.org/cpython/rev/7708f80940b0
New changeset 68902ee48985 by Terry Jan Reedy in branch 'default':
Issue #10291:
Terry J. Reedy added the comment:
Is there any reason when turtledemo.__init__ and turtledemo.__main__ should not
get docstrings in earlier versions? And the turtledemo.__main__ get the same
changes in 3.4?
Not doing so introduced seeming gratuitous differences between the versions.
The help
Ned Deily added the comment:
Is there any reason when turtledemo.__init__ and turtledemo.__main__ should
not get docstrings in earlier versions? And the turtledemo.__main__ get the
same changes in 3.4?
I think my reasoning was that it was not a bug fix so it wasn't a strong
candidate
Terry J. Reedy added the comment:
Thanks for the explanation. I will re-delete the file after copying 3.4 version
to docstring and marking the original .txt as frozen.
I will do same with other files deleted in 3.5.
--
___
Python tracker
Jessica McKellar added the comment:
Thanks for the bug report and patch, belopolsky!
The original patch no longer applies cleanly, so attached is a regenerated
version.
* The new patch passes `make patchcheck`.
* The full test suite passes with this patch.
* I manually tested that before the
Roundup Robot added the comment:
New changeset 004fe3449193 by Ned Deily in branch 'default':
Issue #10291: Cleanup turtledemo to use docstrings for help.
http://hg.python.org/cpython/rev/004fe3449193
--
nosy: +python-dev
___
Python tracker
Ned Deily added the comment:
Thanks for the refresh, Jessica. I decided to separate out the turtle window
raise for OS X and apply that for 3.4.1 and 3.5.0 in Issue11571. The remainder
of the patch to use the docstrings, plus removal of the two other obsolete text
files, is spplied here for
Éric Araujo mer...@netwok.org added the comment:
Agreed. Which .py files would be appropriate?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10291
___
Alexander Belopolsky belopol...@users.sourceforge.net added the comment:
On Tue, Mar 22, 2011 at 2:55 PM, Éric Araujo rep...@bugs.python.org wrote:
..
Agreed. Which .py files would be appropriate?
Lib/turtledemo/about_turtle.txt - seems to belong to turtle.py
Alexander Belopolsky belopol...@users.sourceforge.net added the comment:
On Tue, Mar 22, 2011 at 3:14 PM, Alexander Belopolsky
belopol...@users.sourceforge.net wrote:
..
Lib/turtledemo/about_turtle.txt - seems to belong to turtle.py
In fact, it looks like turtle docstring is already a copy (or
Changes by Alexander Belopolsky belopol...@users.sourceforge.net:
--
type: - feature request
versions: +Python 3.3 -Python 3.2
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10291
___
Changes by Alexander Belopolsky belopol...@users.sourceforge.net:
--
keywords: +patch
Added file: http://bugs.python.org/file21340/issue10291.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10291
Éric Araujo mer...@netwok.org added the comment:
The patch contains one unrelated code change.
I think the docstrings should not go as is but be cleaned up to match
docstrings conventions. I’ve also spotted some phrasing issues.
--
___
Python
Alexander Belopolsky belopol...@users.sourceforge.net added the comment:
On Tue, Mar 22, 2011 at 5:15 PM, Éric Araujo rep...@bugs.python.org wrote:
..
The patch contains one unrelated code change.
Yes, I noticed that, but it may not be that unrelated. Of course the
two changes need to be
Éric Araujo mer...@netwok.org added the comment:
I would rather keep code and documentation changes separate.
I don’t follow; my comment about bad phrasing was about the text added to the
docstrings.
Not that we have any strict docstrings conventions. :-)
Not enforced, but still useful to
Alexander Belopolsky belopol...@users.sourceforge.net added the comment:
On Tue, Mar 22, 2011 at 5:29 PM, Éric Araujo rep...@bugs.python.org wrote:
..
I would rather keep code and documentation changes separate.
I don’t follow; my comment about bad phrasing was about the text added to the
New submission from Alexander Belopolsky belopol...@users.sourceforge.net:
Since after closing of issue #10199, docstrings in demo scripts are accessible
to pydoc, it is important to bring them up to date. For example,
turtledemo.wikipedia docstring contains a reference to nonexistent
17 matches
Mail list logo
