Ezio Melotti added the comment:
The two TODOs left are:
1) adding UnittestWarning;
2) improving the error message for deprecations;
Technically these are new features, so they can go in 3.4 only, but 2) might be
simple enough to be backported.
Regarding 1) it might be a bit too late, given
Brett Cannon added the comment:
I wouldn't backport; not worth it.
Anyway, since I consider this bug closed I'm taking myself off the nosy list.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10535
Ezio Melotti added the comment:
Agreed, closing.
--
resolution: - fixed
stage: patch review -
status: open - closed
versions: +Python 3.2 -Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10535
Brett Cannon added the comment:
Ezio, do you want to create separate issues for any of the TODOs you wanted in
http://bugs.python.org/issue10535#msg122779 so we can close this bug?
--
status: open - pending
___
Python tracker rep...@bugs.python.org
Changes by Brett Cannon br...@python.org:
--
status: pending - open
versions: +Python 3.4 -Python 3.2
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10535
___
Changes by Brett Cannon br...@python.org:
--
status: open - pending
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10535
___
___
Python-bugs-list
Brian Curtin br...@python.org added the comment:
I'm not seeing those warnings anymore, so I think the patch can be ignored.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10535
___
Michael Foord mich...@voidspace.org.uk added the comment:
Does Brian's patch still need applying? (Can this be closed?)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10535
___
Ezio Melotti ezio.melo...@gmail.com added the comment:
Brian's patch is not yet applied afaik, but I couldn't see the warnings here,
so it might be something specific to Windows. Brian, can you confirm if you
still see the problem?
Changing the warning type (to UnittestWarning) and the error
Brian Curtin cur...@acm.org added the comment:
Here's a patch for the ResourceWarnings that were introduced.
--
nosy: +brian.curtin
Added file: http://bugs.python.org/file19909/warnings.diff
___
Python tracker rep...@bugs.python.org
Ezio Melotti ezio.melo...@gmail.com added the comment:
Committed in r86908. I'll leave this open because there still a few things
(proposed in the previous message) that can be changed/improved.
--
___
Python tracker rep...@bugs.python.org
Ezio Melotti ezio.melo...@gmail.com added the comment:
Attached a new patch.
A few comments about it:
1) A new category for UnittestWarnings could still be added to make it easier
to filter warnings using the -W python flags and thus providing more control;
2) I didn't change the deprecation
Changes by Ezio Melotti ezio.melo...@gmail.com:
Removed file: http://bugs.python.org/file19867/issue10535-2.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10535
___
Changes by Ezio Melotti ezio.melo...@gmail.com:
Added file: http://bugs.python.org/file19868/issue10535-2.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10535
___
Changes by Davide Rizzo sor...@gmail.com:
--
nosy: +davide.rizzo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10535
___
___
Python-bugs-list
Michael Foord mich...@voidspace.org.uk added the comment:
I'm also thinking that it might be better to include the name of the
deprecated method in the message and use three filters for fail* methods,
assert* methods, and the assert*Regexp* methods that will be deprecated.
That sounds good,
New submission from Ezio Melotti ezio.melo...@gmail.com:
Warnings should be on by default in unittest so that developers can see them
while running the tests even if they are silenced by default in Python.
The plan is to add a warnings argument to TestProgram and the default
TextTestRunner:
Changes by Éric Araujo mer...@netwok.org:
--
components: +Library (Lib)
nosy: +eric.araujo
versions: +Python 3.2
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10535
___
Ezio Melotti ezio.melo...@gmail.com added the comment:
Here's a working patch (without docs and tests).
I managed to filter the warnings by message without introducing a new type of
warning. As it is, all the warnings related to deprecated unittest methods are
printed only once per module,
19 matches
Mail list logo
