[issue10535] Enable warnings by default in unittest
Ezio Melotti added the comment: The two TODOs left are: 1) adding UnittestWarning; 2) improving the error message for deprecations; Technically these are new features, so they can go in 3.4 only, but 2) might be simple enough to be backported. Regarding 1) it might be a bit too late, given that most deprecations have been around for 2-3 versions already. -- status: pending - open ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10535 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10535] Enable warnings by default in unittest
Brett Cannon added the comment: I wouldn't backport; not worth it. Anyway, since I consider this bug closed I'm taking myself off the nosy list. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10535 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10535] Enable warnings by default in unittest
Ezio Melotti added the comment: Agreed, closing. -- resolution: - fixed stage: patch review - status: open - closed versions: +Python 3.2 -Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10535 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10535] Enable warnings by default in unittest
Brett Cannon added the comment: Ezio, do you want to create separate issues for any of the TODOs you wanted in http://bugs.python.org/issue10535#msg122779 so we can close this bug? -- status: open - pending ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10535 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10535] Enable warnings by default in unittest
Changes by Brett Cannon br...@python.org: -- status: pending - open versions: +Python 3.4 -Python 3.2 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10535 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10535] Enable warnings by default in unittest
Changes by Brett Cannon br...@python.org: -- status: open - pending ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10535 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10535] Enable warnings by default in unittest
Brian Curtin br...@python.org added the comment: I'm not seeing those warnings anymore, so I think the patch can be ignored. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10535 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10535] Enable warnings by default in unittest
Michael Foord mich...@voidspace.org.uk added the comment: Does Brian's patch still need applying? (Can this be closed?) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10535 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10535] Enable warnings by default in unittest
Ezio Melotti ezio.melo...@gmail.com added the comment: Brian's patch is not yet applied afaik, but I couldn't see the warnings here, so it might be something specific to Windows. Brian, can you confirm if you still see the problem? Changing the warning type (to UnittestWarning) and the error message can still be done if you think it's a good idea. Since this fix didn't affect regrtest, another issue for it might be necessary too. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10535 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10535] Enable warnings by default in unittest
Brian Curtin cur...@acm.org added the comment: Here's a patch for the ResourceWarnings that were introduced. -- nosy: +brian.curtin Added file: http://bugs.python.org/file19909/warnings.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10535 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10535] Enable warnings by default in unittest
Ezio Melotti ezio.melo...@gmail.com added the comment: Committed in r86908. I'll leave this open because there still a few things (proposed in the previous message) that can be changed/improved. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10535 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10535] Enable warnings by default in unittest
Ezio Melotti ezio.melo...@gmail.com added the comment: Attached a new patch. A few comments about it: 1) A new category for UnittestWarnings could still be added to make it easier to filter warnings using the -W python flags and thus providing more control; 2) I didn't change the deprecation message in the patch -- I will probably do it in a separate commit; 3) The patch touches a few unrelated unittest/test/test_*.py files that were checking for the number of args explicitely; 4) In order to test the different combinations of flags/args I created a new _test_warnings.py file called from test_runner.py via subprocess; 5) unittest warnings are now printed only once even when 'always' is passed as an arg, but not when it's set with -W (this somehow addresses the limitation described in my previous message); -- Added file: http://bugs.python.org/file19867/issue10535-2.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10535 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10535] Enable warnings by default in unittest
Changes by Ezio Melotti ezio.melo...@gmail.com: Removed file: http://bugs.python.org/file19867/issue10535-2.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10535 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10535] Enable warnings by default in unittest
Changes by Ezio Melotti ezio.melo...@gmail.com: Added file: http://bugs.python.org/file19868/issue10535-2.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10535 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10535] Enable warnings by default in unittest
Changes by Davide Rizzo sor...@gmail.com: -- nosy: +davide.rizzo ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10535 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10535] Enable warnings by default in unittest
Michael Foord mich...@voidspace.org.uk added the comment: I'm also thinking that it might be better to include the name of the deprecated method in the message and use three filters for fail* methods, assert* methods, and the assert*Regexp* methods that will be deprecated. That sounds good, well - it sounds *essential*. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10535 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10535] Enable warnings by default in unittest
New submission from Ezio Melotti ezio.melo...@gmail.com: Warnings should be on by default in unittest so that developers can see them while running the tests even if they are silenced by default in Python. The plan is to add a warnings argument to TestProgram and the default TextTestRunner: * if the argument is passed always use it as a filter (e.g. default, ignore, all, ...) for warnings; * if the argument is not passed and sys.warnoptions is not [] (i.e. python has been called with -W something) don't do anything (i.e. use the warnings specified by -W); * if the argument is not passed and sys.warnoptions is [], use 'default' (i.e. show warnings). In order to prevent floods of warnings when the deprecated assertEquals, assert_, etc. are used (see #9424), a new type of warning could be created (e.g. _UnittestDeprecationWarning) and filtered so that these warnings are printed only once. -- assignee: ezio.melotti messages: 122411 nosy: brett.cannon, ezio.melotti, michael.foord priority: normal severity: normal stage: needs patch status: open title: Enable warnings by default in unittest type: feature request ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10535 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10535] Enable warnings by default in unittest
Changes by Éric Araujo mer...@netwok.org: -- components: +Library (Lib) nosy: +eric.araujo versions: +Python 3.2 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10535 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10535] Enable warnings by default in unittest
Ezio Melotti ezio.melo...@gmail.com added the comment: Here's a working patch (without docs and tests). I managed to filter the warnings by message without introducing a new type of warning. As it is, all the warnings related to deprecated unittest methods are printed only once per module, regardless of what methods are used and how many times. I'm also thinking that it might be better to include the name of the deprecated method in the message and use three filters for fail* methods, assert* methods, and the assert*Regexp* methods that will be deprecated. This will show at worst 3 warnings per module, but the assert*Regexp* and the fail* methods are not so common, so it shouldn't be too nosy. One limitation of the patch is that the per-module special-casing for unittest is not affect by the `warnings` argument, but it can be changed when -W is used and no `warnings` arg is passed. Regrtest doesn't seem to use unittest, so it should be fixed separately (probably needs another issue). -- keywords: +patch stage: needs patch - patch review Added file: http://bugs.python.org/file19821/issue10535.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10535 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
