[issue10817] urllib.request.urlretrieve never raises ContentTooShortError if no reporthook

[Jyrki Pulliainen]

Jyrki Pulliainen  added the comment:

Cheers, thank you for commiting!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10817] urllib.request.urlretrieve never raises ContentTooShortError if no reporthook

[Senthil Kumaran]

Senthil Kumaran  added the comment:

This is fixed in all codelines. Thanks for your contribution, Jyrki Pulliainen.

--
resolution:  -> fixed
status: open -> closed
versions: +Python 3.2, Python 3.3

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10817] urllib.request.urlretrieve never raises ContentTooShortError if no reporthook

[Roundup Robot]

Roundup Robot  added the comment:

New changeset 1ef30d6429db by Senthil Kumaran in branch '2.7':
Port to 2.7 - issue 10817 - Fix urlretrieve function to raise
http://hg.python.org/cpython/rev/1ef30d6429db

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10817] urllib.request.urlretrieve never raises ContentTooShortError if no reporthook

[Roundup Robot]

Roundup Robot  added the comment:

New changeset 2ca415cbf2ac by Senthil Kumaran in branch '3.2':
Fix issue 10817 - Fix urlretrieve function to raise ContentTooShortError
http://hg.python.org/cpython/rev/2ca415cbf2ac

New changeset e3e5b6f03f79 by Senthil Kumaran in branch 'default':
merge from 3.2 - Fix issue 10817 - Fix urlretrieve function to raise 
ContentTooShortError
http://hg.python.org/cpython/rev/e3e5b6f03f79

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10817] urllib.request.urlretrieve never raises ContentTooShortError if no reporthook

[Jyrki Pulliainen]

Changes by Jyrki Pulliainen :


Removed file: http://bugs.python.org/file23444/issue10817.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10817] urllib.request.urlretrieve never raises ContentTooShortError if no reporthook

[Jyrki Pulliainen]

Jyrki Pulliainen  added the comment:

I had a bad patch, containing changes to locale.py, so I've uploaded a new 
patch for this.

--
Added file: http://bugs.python.org/file23446/issue10817.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10817] urllib.request.urlretrieve never raises ContentTooShortError if no reporthook

[Jyrki Pulliainen]

Jyrki Pulliainen  added the comment:

Changed the code so that the content length is set as size if reporthook is not 
set and wrote two tests for it.

Note: I moved fakehttp behavior to a mixin, so that it's more reusable.

--
keywords: +patch
nosy: +nailor
Added file: http://bugs.python.org/file23444/issue10817.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10817] urllib.request.urlretrieve never raises ContentTooShortError if no reporthook

[Robert Siemer]

Changes by Robert Siemer :


--
nosy: +siemer

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10817] urllib.request.urlretrieve never raises ContentTooShortError if no reporthook

[Senthil Kumaran]

Changes by Senthil Kumaran :


--
assignee:  -> orsenthil
nosy: +orsenthil

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10817] urllib.request.urlretrieve never raises ContentTooShortError if no reporthook

[Robert Cheng]

New submission from Robert Cheng :

When reporthook is None, size variable is not computed and defaulted to -1. 
Thus, without reporthook, ContentTooShortError is not raised even when 
Content-Length header is supplied and download size is less than expected 
amount, contrary to the documentation.

--
components: Library (Lib)
messages: 125186
nosy: RC
priority: normal
severity: normal
status: open
title: urllib.request.urlretrieve never raises ContentTooShortError if no 
reporthook
type: behavior
versions: Python 2.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com