[issue1095] make install failed
Martin v. Löwis added the comment: I haven't tested it, but it looks fine to me. -- assignee: - georg.brandl resolution: - accepted __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1095 __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1095] make install failed
Georg Brandl added the comment: Committed as rev. 58043, 58044. -- resolution: accepted - fixed status: open - closed __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1095 __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1095] make install failed
Martin v. Löwis added the comment: The -f option to ln was not portable, traditionally. So the portable way to create a symlink if the target might exist is to remove the old symlink first. I've verified that 'ln -sf' indeed works as reported on Solaris 9. On Solaris 10, it seems Sun has finally given in and changed the implementation (but not the documentation). I'm not sure why we bother checking whether the old file exists before removing it, instead of just doing 'rm -f'; that has been there since r6352 with no explanation given. -- assignee: loewis - __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1095 __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1095] make install failed
Georg Brandl added the comment: [Martin] I'm not sure why we bother checking whether the old file exists before removing it, instead of just doing 'rm -f'; that has been there since r6352 with no explanation given. So would this patch be acceptable? Index: Makefile.pre.in === --- Makefile.pre.in (Revision 57865) +++ Makefile.pre.in (Arbeitskopie) @@ -655,7 +655,8 @@ else true; \ fi (cd $(DESTDIR)$(BINDIR); $(LN) python$(VERSION)$(EXE) $(PYTHON)) - (cd $(DESTDIR)$(BINDIR); $(LN) -sf python$(VERSION)-config python-config) + -rm -f $(DESTDIR)$(BINDIR)/python-config + (cd $(DESTDIR)$(BINDIR); $(LN) -s python$(VERSION)-config python-config) # Install the interpreter with $(VERSION) affixed # This goes into $(exec_prefix) __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1095 __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1095] make install failed
New submission from Aki: I thought this was already reported but I didn't see it in the list. If this issue is already addressed, please discard. The 'make install' failed if I re-run the installation again because python-config under /usr/local/bin was already there. Removing /usr/local/lib/python2.5/lib-dynload/Python-2.5.1-py2.5.egg-info Writing /usr/local/lib/python2.5/lib-dynload/Python-2.5.1-py2.5.egg-info if test -f /usr/local/bin/python -o -h /usr/local/bin/python; \ then rm -f /usr/local/bin/python; \ else true; \ fi (cd /usr/local/bin; ln python2.5 python) (cd /usr/local/bin; ln -sf python2.5-config python-config) ln: cannot create python-config: File exists make: *** [bininstall] Error 2 I didn't see such problem under 2.4. Aki- -- components: Installation messages: 55624 nosy: akineko severity: normal status: open title: make install failed versions: Python 2.5 __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1095 __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
