[issue11591] python -S should be robust against e.g. from site import addsitedir
Éric Araujo mer...@netwok.org added the comment: Now that site can be imported without side effects under -S, I think the tests could be updated: they don’t have to be all skipped under -S. See attached patch. -- Added file: http://bugs.python.org/file22293/test_site-11591.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11591 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11591] python -S should be robust against e.g. from site import addsitedir
Roundup Robot devnull@devnull added the comment: New changeset 6ee5443773cb by Éric Araujo in branch 'default': Also add versionchanged directive to the function doc (#11591) http://hg.python.org/cpython/rev/6ee5443773cb -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11591 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11591] python -S should be robust against e.g. from site import addsitedir
Roundup Robot devnull@devnull added the comment: New changeset 9a1ca0062950 by Éric Araujo in branch 'default': Add versionchanged for a364719e400a (#11591) http://hg.python.org/cpython/rev/9a1ca0062950 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11591 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11591] python -S should be robust against e.g. from site import addsitedir
Éric Araujo mer...@netwok.org added the comment: The Remote hg repo field was just empty when I made my latest comment Looks like this field is always empty: its goal is to add a repo, just like the File field is always empty unless you add a file. The existing files and repositories are however listed underneath the form, so your screen just probably did not go low enough for you to see that the repo was still listed. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11591 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11591] python -S should be robust against e.g. from site import addsitedir
Brett Cannon br...@python.org added the comment: Doc changes seem fine to me. -- assignee: brett.cannon - eric.araujo ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11591 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11591] python -S should be robust against e.g. from site import addsitedir
Changes by Terry J. Reedy tjre...@udel.edu: Added file: http://bugs.python.org/file21350/ebe5760afa08.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11591 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11591] python -S should be robust against e.g. from site import addsitedir
Changes by Terry J. Reedy tjre...@udel.edu: Removed file: http://bugs.python.org/file21350/ebe5760afa08.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11591 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11591] python -S should be robust against e.g. from site import addsitedir
Roundup Robot devnull@devnull added the comment: New changeset a364719e400a by Éric Araujo in branch 'default': Do not touch sys.path when site is imported and python was started with -S. http://hg.python.org/cpython/rev/a364719e400a -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11591 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11591] python -S should be robust against e.g. from site import addsitedir
Éric Araujo mer...@netwok.org added the comment: Committed with small wording changes and more docs. Thank you, and good luck for cpythonv! -- resolution: - fixed stage: - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11591 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11591] python -S should be robust against e.g. from site import addsitedir
Carl Meyer c...@dirtcircle.com added the comment: Added documentation to Doc/library/site.rst and Misc/NEWS. -- hgrepos: +5 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11591 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11591] python -S should be robust against e.g. from site import addsitedir
Changes by Carl Meyer c...@dirtcircle.com: Added file: http://bugs.python.org/file21327/ebe5760afa08.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11591 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11591] python -S should be robust against e.g. from site import addsitedir
Éric Araujo mer...@netwok.org added the comment: Looks great, thank you. I think I’ll also add a docstring to main before committing, now that the function is publicly documented. Did you have to manually click “Create Patch” to make roundup generate it? Did you try first to click on the button of the existing repo before adding a new repo entry? (Still learning how to use it, thanks for experimenting along :) Brett: Thanks for the review. If you don’t comment negatively on the doc change, I will commit this. (Side concern: the module does not define __all__, even though only 4 functions and 4 constants are officially documented. I’d like to define __all__, but the recentish huge thread on public/private APIs scared me.) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11591 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11591] python -S should be robust against e.g. from site import addsitedir
Carl Meyer c...@dirtcircle.com added the comment: Did you have to manually click “Create Patch” to make roundup generate it? Yes - the first time too. Did you try first to click on the button of the existing repo before adding a new repo entry? That would probably have worked fine. The Remote hg repo field was just empty when I made my latest comment, so I filled it in again. Wasn't sure if it would duplicate, or be smart enough to tell they were the same repo, or what. I guess it duplicated :/ -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11591 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11591] python -S should be robust against e.g. from site import addsitedir
Changes by Brett Cannon br...@python.org: -- assignee: eric.araujo - brett.cannon ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11591 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11591] python -S should be robust against e.g. from site import addsitedir
Brett Cannon br...@python.org added the comment: This is what I get for trying to clean up site.py years ago. =) I'm fine with the change as long as there is a very clear Misc/NEWS message that the semantics on import have changed (and obviously this is not backported). -- assignee: - eric.araujo ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11591 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11591] python -S should be robust against e.g. from site import addsitedir
Éric Araujo mer...@netwok.org added the comment: I think this requires a note in NEWS but also in Doc/library/site.rst. Carl, would you like to make a new changeset with that edition in your repo? (It will also provide a test for the Create Patch button after.) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11591 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11591] python -S should be robust against e.g. from site import addsitedir
Éric Araujo mer...@netwok.org added the comment: Fair argument. Brett is the author of recent changes in site, let him decide. Brett: Would you agree to 1)? -- nosy: +brett.cannon ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11591 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11591] python -S should be robust against e.g. from site import addsitedir
New submission from Carl Meyer c...@dirtcircle.com: If python is run with the -S flag, that declares the intent of the user to not have site-specific additions to sys.path. However, some code in that process may have a legitimate need for a function defined in site.py - for instance, addsitedir. But the act of importing site.py, as a side effect, adds the standard site-specific directories to sys.path. python -S would be more useful and reliable if it prevented importing site from automatically making the sys.path additions. There is no loss of flexibility here, as user code could still explicitly call site.main() to achieve all of the current side-effects of import site. The fix is a one-liner, and is in the linked hg repository. -- components: Library (Lib) hgrepos: 4 messages: 131281 nosy: carljm priority: normal severity: normal status: open title: python -S should be robust against e.g. from site import addsitedir type: behavior ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11591 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11591] python -S should be robust against e.g. from site import addsitedir
Changes by Carl Meyer c...@dirtcircle.com: -- keywords: +patch Added file: http://bugs.python.org/file21274/87df1d37c88e.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11591 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11591] python -S should be robust against e.g. from site import addsitedir
Éric Araujo mer...@netwok.org added the comment: Thanks. Would you mind adding tests in test_site? -- nosy: +eric.araujo versions: +Python 3.3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11591 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11591] python -S should be robust against e.g. from site import addsitedir
Carl Meyer c...@dirtcircle.com added the comment: Adding a test is easier said than done. The behavior change here depends on python being run with -S. Currently test_site skips itself if the test suite is run with -S, and if I remove that skip it crashes under -S. Options as I see it: 1. Declare this one-liner correct by inspection. It doesn't break any existing tests. 2. Add a new test file (test_no_site.py?) that only runs with -S and tests that importing something from site doesn't trigger sys.path additions. This seems like the most reasonable test, but I'm not sure how useful it is, since I doubt most people ever try running the test suite with -S. 3. Make the fix more complicated such that it uses an intermediary variable which can be mocked (unlike sys.flags.no_site, which is read-only), and then add a test which mocks this variable, temporarily removes site from sys.modules, tries importing it again, and checks whether main() is called. This creates a complex test which is highly coupled to the implementation in site.py, but would be run under normal conditions (without -S). Which option do you prefer? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11591 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
