Roundup Robot devnull@devnull added the comment:
New changeset f8ece8c93918 by R David Murray in branch '3.2':
#11873: fix test regex so it covers windows os.sep as well.
http://hg.python.org/cpython/rev/f8ece8c93918
New changeset e543c0ddec63 by R David Murray in branch 'default':
merge
R. David Murray rdmur...@bitdance.com added the comment:
Yeah, that's why I had reopened the issue...hopefully it is fixed now.
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11873
R. David Murray rdmur...@bitdance.com added the comment:
I guess I'm just really bad at regexes.
http://www.python.org/dev/buildbot/all/builders/x86%20XP-4%203.x/builds/4885/steps/test/logs/stdio
--
status: closed - open
___
Python tracker
Roundup Robot devnull@devnull added the comment:
New changeset 6fdb1f000d36 by R David Murray in branch '3.2':
#11873: another try at fixing the regex, courtesy of Victor Stinner
http://hg.python.org/cpython/rev/6fdb1f000d36
New changeset 775356b583d1 by R David Murray in branch 'default':
R. David Murray rdmur...@bitdance.com added the comment:
I'm going to be an optimist and close this again.
--
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11873
___
STINNER Victor victor.stin...@haypocalc.com added the comment:
What about Windows? tempfile.mkdtemp(prefix='bar') can generate
...\tmpxxbaxx\...
AH! The test failed on x86 XP-4 x86:
http://www.python.org/dev/buildbot/all/builders/x86%20XP-4%203.x/builds/4874/steps/test/logs/stdio
Changes by Thomas Holmes tho...@devminded.com:
--
nosy: +Thomas.Holmes
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11873
___
___
STINNER Victor victor.stin...@haypocalc.com added the comment:
What about Windows? tempfile.mkdtemp(prefix='bar') can generate
...\tmpxxbaxx\... Or compileall does first normalize the path?
@r.david.murray: You reopened the issue, but you didn't answer to this
question. And, is there a bug
R. David Murray rdmur...@bitdance.com added the comment:
I reopened the issue because I don't know the answer to your question but
suspect that it is an issue. So it needs to be checked. And the regex should
be cleaned up regardless, for clarity's sake.
--
Changes by R. David Murray rdmur...@bitdance.com:
--
status: - open
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11873
___
___
Python-bugs-list
Éric Araujo mer...@netwok.org added the comment:
You are right that I got the regex wrong (I'm bad at regexes), but in
fact it is fine the way it is. Since there's no r, the regex is
actually ba[^/]$, which is exactly what I meant.
I would edit the string to reflect your meaning, then,
Changes by STINNER Victor victor.stin...@haypocalc.com:
--
resolution: fixed -
status: closed -
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11873
___
STINNER Victor victor.stin...@haypocalc.com added the comment:
You are right that I got the regex wrong (I'm bad at regexes), but
in fact it is fine the way it is. Since there's no r, the regex
is actually ba[^/]$, which is exactly what I meant.
What about Windows?
STINNER Victor victor.stin...@haypocalc.com added the comment:
Ah ah, this bug is funny :-) test_regexp doesn't fail because of a race
condition or a file system issue, but because of the regex!
The regex ba.* is applied on the fullname, not only on the basename. If the
temporary contains ba,
STINNER Victor victor.stin...@haypocalc.com added the comment:
Ah ah, this bug is funny :-) test_regexp doesn't fail because of a race
condition or a file system issue, but because of the regex!
The regex ba.* is applied on the fullname, not only on the basename. If the
temporary contains ba,
STINNER Victor victor.stin...@haypocalc.com added the comment:
Ah ah, this bug is funny :-) test_regexp doesn't fail because of a race
condition or a file system issue, but because of the regex!
The regex ba.* is applied on the fullname, not only on the basename. If the
temporary contains ba,
Changes by STINNER Victor victor.stin...@haypocalc.com:
--
Removed message: http://bugs.python.org/msg135199
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11873
___
Roundup Robot devnull@devnull added the comment:
New changeset 76bd26565cc7 by R David Murray in branch '3.2':
#11873: Improve test regex so random directory names don't cause test to fail
http://hg.python.org/cpython/rev/76bd26565cc7
New changeset 83e069281810 by R David Murray in branch
R. David Murray rdmur...@bitdance.com added the comment:
I ran the patched version 2945 times without failure.
--
resolution: - fixed
stage: needs patch - committed/rejected
status: open - closed
type: - behavior
___
Python tracker
STINNER Victor victor.stin...@haypocalc.com added the comment:
+self.assertRunOK('-q', '-x', 'ba[^\/]*$', self.pkgdir)
This regex matchs 'ba(...)\'. I think that you wanted to write r'[^\\/]'.
--
___
Python tracker rep...@bugs.python.org
R. David Murray rdmur...@bitdance.com added the comment:
You are right that I got the regex wrong (I'm bad at regexes), but in fact it
is fine the way it is. Since there's no r, the regex is actually ba[^/]$,
which is exactly what I meant.
--
___
Nick Coghlan ncogh...@gmail.com added the comment:
A quick eyeball of the test doesn't reveal anything obvious:
- if the subprocess is failing, it is doing so in such a way that it is still
returning a 0 error code and isn't writing anything to stdout (as those
assertions are before the check
Nick Coghlan ncogh...@gmail.com added the comment:
Hmm, I probably should have revised the first half of my comment after I had
the thought about simple regex + random directory name being potentially
problematic. I don't think that theory really counts as obvious, though...
--
R. David Murray rdmur...@bitdance.com added the comment:
Running test_compileall with -F it failed on iteration 588 on my linux box. So
this isn't platform specific. No idea why that particular test should be
fragile, but I'll look in to it when I get some time if nobody beats me to it.
24 matches
Mail list logo
