[issue12378] smtplib.SMTP_SSL leaks socket connections on SSL error

Christian Heimes added the comment: Not a bug in the SSL module. -- assignee: christian.heimes -> components: -SSL versions: +Python 2.7 -Python 3.5 ___ Python tracker

[issue12378] smtplib.SMTP_SSL leaks socket connections on SSL error

Changes by Christian Heimes : -- assignee: -> christian.heimes components: +SSL nosy: +christian.heimes ___ Python tracker ___

[issue12378] smtplib.SMTP_SSL leaks socket connections on SSL error

Changes by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___

[issue12378] smtplib.SMTP_SSL leaks socket connections on SSL error

Changes by Christian Heimes : -- stage: needs patch -> patch review versions: +Python 3.5, Python 3.6, Python 3.7 -Python 2.7, Python 3.2, Python 3.3 ___ Python tracker

[issue12378] smtplib.SMTP_SSL leaks socket connections on SSL error

Milan Oberkirch added the comment: I agree that there is not much we can do on the server side (see issue 19806) and with the fix for issue 19662 the server won't recognize this error at all (patiently waiting for b'\r\n\' which is unlikely to appear in the first handshake-message from the

[issue12378] smtplib.SMTP_SSL leaks socket connections on SSL error

Giampaolo Rodola' added the comment: @Giampaolo can you add anything to this? As for smptd encoding error I think a reasonable thing to do would be to reply with 501 Can't decode command.. There's no way for the server to return a more specific error message (e.g. SSL is not supported).

[issue12378] smtplib.SMTP_SSL leaks socket connections on SSL error

Mark Lawrence added the comment: @Giampaolo can you add anything to this? -- nosy: +giampaolo.rodola ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12378 ___

[issue12378] smtplib.SMTP_SSL leaks socket connections on SSL error

brian morrow added the comment: Not sure if this is still relevant, but I've supplied a python2.7 patch for this issue. All regression tests still pass and the underlying socket connection is closed: bmorrow@xorange:~/cpython$ ./python -m smtpd -n -c DebuggingServer localhost:2525 import

[issue12378] smtplib.SMTP_SSL leaks socket connections on SSL error

Mark Lawrence added the comment: I don't know where we stand with this as it references asyncore which is deprecated in favour of asynio, can someone please advise. -- nosy: +BreamoreBoy ___ Python tracker rep...@bugs.python.org

[issue12378] smtplib.SMTP_SSL leaks socket connections on SSL error

Changes by Catalin Iacob iacobcata...@gmail.com: -- nosy: +catalin.iacob ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12378 ___ ___

[issue12378] smtplib.SMTP_SSL leaks socket connections on SSL error

Catalin Iacob iacobcata...@gmail.com added the comment: Just a note after running Joe's example. smtplib is affected by this issue in 3.x, but the example produces different results in 3.x: smtpd doesn't keep the connection open due to UnicodeDecodeError when the data from the ssl handshake

[issue12378] smtplib.SMTP_SSL leaks socket connections on SSL error

New submission from Joe Shaw js...@itasoftware.com: Start a non-SSL server on port 2525: $ python -m smtpd -n -c DebuggingServer localhost:2525 In another terminal, fire up a python interpreter and run the following code: import smtplib s = smtplib.SMTP_SSL(localhost, 2525) [...]

[issue12378] smtplib.SMTP_SSL leaks socket connections on SSL error

Joe Shaw js...@itasoftware.com added the comment: From some experimentation, closing the underlying socket isn't enough. You also need to close the SSL socket, so you'd need to do something like: new_socket = socket.create_connection((host, port), timeout) ssl_socket =

[issue12378] smtplib.SMTP_SSL leaks socket connections on SSL error

R. David Murray rdmur...@bitdance.com added the comment: 2.6 is in security-fix-only mode. By inspection the 2.7 and 3.x code have the same issue (though the 3.x code is very different, there still appears to be a lack of error recovery logic. Joe, do you have any interest in writing a unit