Roundup Robot added the comment:
New changeset 7648b7ed6d91 by R David Murray in branch '3.3':
#12890: fix test on windows
http://hg.python.org/cpython/rev/7648b7ed6d91
New changeset d24befb680d6 by R David Murray in branch 'default':
#12890: fix test on windows
R. David Murray added the comment:
Thanks everyone.
--
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12890
___
Stephen Tonkin added the comment:
Uploaded a patch which fixes the failing on Windows 7.
It was essentially an issue with the Windows path returned by temp_dir()
containing unescaped backslashes. A repr() fixed this.
--
nosy: +sptonkin
Added file:
Aaron Iles added the comment:
Patch successfully tested on Mac OSX 10.8. No regressions.
--
nosy: +aliles
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12890
___
Michael Dorman added the comment:
Patch (p12890-2.diff) successfully tested on Windows 7 64. No regressions.
--
nosy: +mjdorma
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12890
___
Roundup Robot added the comment:
New changeset 715e5b337c91 by R David Murray in branch '2.7':
#12890: don't emit p tags in text mode when logdir specified.
http://hg.python.org/cpython/rev/715e5b337c91
New changeset abbfb89055d3 by R David Murray in branch '3.2':
#12890: don't emit p tags in
R. David Murray added the comment:
Committed with Ezio's \p and with simplification of the tests by using
script_helper. Thanks, Jeff!
--
nosy: +r.david.murray
resolution: - fixed
status: open - closed
versions: +Python 3.4
___
Python tracker
R. David Murray added the comment:
The tests fail on Widows7 on the buildbots. (They work fine in my XP Windows
VM.)
--
assignee: eric.araujo -
status: closed - open
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12890
R. David Murray added the comment:
I put in a skip until we either fix the tests or rewrite them as suggested in
issue 15749.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12890
___
Roundup Robot added the comment:
New changeset 0e4574595674 by R David Murray in branch '3.3':
#12890: skip tests which fail on windows until fixed or rewritten.
http://hg.python.org/cpython/rev/0e4574595674
New changeset 57a33af85407 by R David Murray in branch 'default':
merge #12890: skip
Ezio Melotti added the comment:
What about closing the /p too (see attached patch)?
(I know the /p is not necessary, but I prefer to add it.)
--
Added file: http://bugs.python.org/file27005/issue12890.diff
___
Python tracker rep...@bugs.python.org
Jeff McNeil j...@jmcneil.net added the comment:
Did this ever get committed? Is there anything left for me to do here?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12890
___
Éric Araujo mer...@netwok.org added the comment:
I’ll apply it shortly.
--
assignee: - eric.araujo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12890
___
Changes by Éric Araujo mer...@netwok.org:
Removed file: http://bugs.python.org/file23091/head-cgitb-display.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12890
___
Changes by Éric Araujo mer...@netwok.org:
Removed file: http://bugs.python.org/file23731/head-cgitb-display-tests.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12890
___
Changes by Jeff McNeil j...@jmcneil.net:
Added file: http://bugs.python.org/file23743/head-cgitb-display.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12890
___
Changes by Éric Araujo mer...@netwok.org:
Removed file: http://bugs.python.org/file23737/head-cgitb-display.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12890
___
Éric Araujo mer...@netwok.org added the comment:
Latest patch is good to go.
--
versions: +Python 2.7, Python 3.2
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12890
___
Éric Araujo mer...@netwok.org added the comment:
Thanks for the updated patch. I made a review, you should have received an
email. When you make a new patch, it would be most helpful if you could make
one patch with code and tests changes, and then we’ll remove the old versions.
--
Jeff McNeil j...@jmcneil.net added the comment:
Added everything to one file. Updated tests to also include a logdir argument
as that is required to trigger the original bug. Weeded out a spurious write
that occurred when format was set to text.
--
Added file:
Jeff McNeil j...@jmcneil.net added the comment:
Is there anything else needed here?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12890
___
___
Ezio Melotti ezio.melo...@gmail.com added the comment:
A test?
--
stage: - test needed
type: - behavior
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12890
___
Jeff McNeil j...@jmcneil.net added the comment:
I didn't add one initially as I was just changing output format and not actual
behavior. I guess I could add something to ensure it doesn't regress? I'll
make sure there's coverage to begin with.
--
Jeff McNeil j...@jmcneil.net added the comment:
Test to ensure html isn't included when the formatting is text. I don't seem
to be able to update the stage.
--
Added file: http://bugs.python.org/file23731/head-cgitb-display-tests.patch
___
Python
Changes by Ezio Melotti ezio.melo...@gmail.com:
--
stage: test needed - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12890
___
___
Changes by Ezio Melotti ezio.melo...@gmail.com:
--
nosy: +ezio.melotti
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12890
___
___
New submission from Jeff McNeil j...@jmcneil.net:
If cgitb.enable is ran with a logdir set and a format='text' argument, then a
trailing message is printed that includes p tags. This should only happen if
the format requested is HTML.
The following tiny script shows the problem:
import
27 matches
Mail list logo
