Martin v. Löwis mar...@v.loewis.de added the comment:
Maybe we should change the build system to always regenerate the files
or add something to automation that regenerates the AST C file every
time.
Most definitely not. It is very deliberate that asdl_c.py is only
invoked when the ASDL
Meador Inge mead...@gmail.com added the comment:
Most definitely not. It is very deliberate that asdl_c.py is only
invoked when the ASDL sources change. Otherwise, having Python installed
would be a build requirement for Python, which it must be not.
OK, thanks for the background. To be
Martin v. Löwis mar...@v.loewis.de added the comment:
Am 23.10.2011 20:33, schrieb Meador Inge:
Meador Inge mead...@gmail.com added the comment:
Most definitely not. It is very deliberate that asdl_c.py is only
invoked when the ASDL sources change. Otherwise, having Python installed
New submission from Eric Snow ericsnowcurren...@gmail.com:
Looks like Parser/asdl_c.py did not get all the way updated when _Py_identifier
switched over to _Py_IDENTIFER. I've included a patch that fixes it (though
it's relatively trivial). With this fix I did not notice any further
Meador Inge mead...@gmail.com added the comment:
Good catch. I see what happened. 7109f31300fb updated
Python/Python-ast.c but not Parser/asdl_c.py. I will apply your patch
shortly. Thanks.
--
assignee: - meador.inge
nosy: +meador.inge
stage: - patch review
Meador Inge mead...@gmail.com added the comment:
Oh, and just to be clear I reproduced the build break by doing:
./Parser/asdl_c.py -c ./Python ./Parser/Python.asdl
make
in a built tree. The reason that this wasn't caught is that the make
rules have the ASDL files as dependencies on the AST C
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 941d015053c6 by Meador Inge in branch 'default':
Issue 13243: Rename _Py_identifier to _Py_IDENTIFIER in asdl_c.py
http://hg.python.org/cpython/rev/941d015053c6
--
nosy: +python-dev
Meador Inge mead...@gmail.com added the comment:
Committed. Thanks!
--
nosy: -python-dev
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13243