Roundup Robot added the comment:
New changeset 002d5f3b240d by Mark Dickinson in branch '2.7':
Issue #13863: fix incorrect .pyc timestamps on Windows / NTFS (apparently due
to buggy fstat)
http://hg.python.org/cpython/rev/002d5f3b240d
--
nosy: +python-dev
Mark Dickinson added the comment:
Fixed for 2.7. I don't think this is worth fixing to 3.2, given that it's not
an issue for 3.3.
Thanks Brian and Serhiy for reviewing!
--
resolution: - fixed
status: open - closed
___
Python tracker
Brian Curtin added the comment:
Latest patch looks ok to me and the tests pass.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13863
___
___
Mark Dickinson added the comment:
Whoops. int.from_bytes doesn't exist in Python 2.7.
--
Added file: http://bugs.python.org/file28387/pyc_mtime4.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13863
Changes by Mark Dickinson dicki...@gmail.com:
--
assignee: - mark.dickinson
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13863
___
___
Mark Dickinson added the comment:
Here's a possible fix for Python 2.7. Reviews from Windows experts would be
very much appreciated; I don't really know what I'm doing here.
I'm still trying to work out how to test this effectively.
--
___
Python
Changes by Mark Dickinson dicki...@gmail.com:
--
keywords: +patch
Added file: http://bugs.python.org/file28331/pyc_mtime.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13863
___
Mark Dickinson added the comment:
Updated patch, with a test.
--
Added file: http://bugs.python.org/file28337/pyc_mtime2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13863
___
Mark Dickinson added the comment:
Updated patch to address comments from Serhiy on Rietveld:
- use ' 0x' in the Python code that gets the mtime; only the
bottom 32 bits of the mtime are used.
- simplify line that reads mtime from .pyc file.
Also improved an error check in the C
Changes by Eric Snow ericsnowcurren...@gmail.com:
--
resolution: - works for me
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13863
___
Eric Snow added the comment:
actually still valid for previous to 3.3
--
nosy: +eric.snow
resolution: works for me -
status: closed - open
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13863
Peter Russell added the comment:
I can confirm that the current equivalent to Mark's original test case works as
expected on default.
I recommend closing this issue.
--
nosy: +qwertyface
___
Python tracker rep...@bugs.python.org
Antoine Pitrou pit...@free.fr added the comment:
It shouldn't affect 3.3 anymore (importlib using the os module rather than
direct C calls to msvcrt). Could someone check?
--
nosy: +mackeith
versions: -Python 3.3
___
Python tracker
Martin v. Löwis mar...@v.loewis.de added the comment:
For some reason that I'm unable to follow right now, fstat in the crt does this
dance to obtain st_mtime:
- obtain time stamps using GetFileInformationByHandle
- convert ftLastWriteTime using FileTimeToLocalFileTime to LocalFTime
- convert
Mark Dickinson dicki...@gmail.com added the comment:
Also seen on Windows Vista; seems to be a general Windows + NTFS problem.
Changing title to make it clearer that this is a core language issue.
It seems as though the correct fix would be to use something like
GetFileInformationByHandle in
Changes by Antoine Pitrou pit...@free.fr:
--
nosy: +haypo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13863
___
___
Python-bugs-list mailing
Antoine Pitrou pit...@free.fr added the comment:
Hmm, interesting. This is exactly what happened recently when debugging pyc
timestamp issues under Windows:
http://www.python.org/dev/buildbot/all/builders/x86%20Windows7%202.7/builds/1204/steps/test/logs/stdio
Some decoding of the above crash:
17 matches
Mail list logo
