[issue14094] ntpath.realpath() should use GetFinalPathNameByHandle()

[Steve Dower]

Steve Dower  added the comment:

As of 3.8, it (sort of) does.

--
resolution:  -> out of date
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14094] ntpath.realpath() should use GetFinalPathNameByHandle()

[Steve Dower]

Steve Dower  added the comment:

Posted a review. I suggest a few changes for the sake of tidying up, but I 
agree that I'd like to see more tests added.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14094] ntpath.realpath() should use GetFinalPathNameByHandle()

[Eryk Sun]

Eryk Sun  added the comment:

Ping on PR 11248. It would be nice to get this into 3.8.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14094] ntpath.realpath() should use GetFinalPathNameByHandle()

[Eryk Sun]

Change by Eryk Sun :


--
components: +Windows
nosy: +paul.moore, steve.dower, tim.golden, zach.ware

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14094] ntpath.realpath() should use GetFinalPathNameByHandle()

[Eryk Sun]

Change by Eryk Sun :


--
components:  -Windows

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14094] ntpath.realpath() should use GetFinalPathNameByHandle()

[Vladimir Matveev]

Change by Vladimir Matveev :


--
keywords: +patch
pull_requests: +10488
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14094] ntpath.realpath() should use GetFinalPathNameByHandle()

[Vladimir Matveev]

Vladimir Matveev  added the comment:

I can give it a try.

--
nosy: +v2m

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14094] ntpath.realpath() should use GetFinalPathNameByHandle()

[STINNER Victor]

STINNER Victor  added the comment:

Any update on this issue?

--
versions: +Python 3.8 -Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14094] ntpath.realpath() should use GetFinalPathNameByHandle()

[STINNER Victor]

STINNER Victor added the comment:

Oh, only os.stat() was patched to use GetFinalPathNameByHandle()? It seems like 
most of the code was already written, so it shouldn't be hard to add a 
nt.GetFinalPathName() function using the win32_xstat_impl() code (and 
get_target_path()), to implement a real ntpath.realpath(), no?

@Eryk: Are you interested to work on a patch?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14094] ntpath.realpath() should use GetFinalPathNameByHandle()

[Mark Lawrence]

Changes by Mark Lawrence :


--
nosy:  -BreamoreBoy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14094] ntpath.realpath() should use GetFinalPathNameByHandle()

[Eryk Sun]

Eryk Sun added the comment:

I assume by nt.realpath we're talking about ntpath.realpath. In that case 
nothing was done to fix this. It's still an alias for ntpath.abspath, which 
calls GetFullPathNameW.

--
nosy: +eryksun
resolution: fixed -> 
stage: resolved -> needs patch
status: closed -> open
title: nt.realpath() should use GetFinalPathNameByHandle() when available -> 
ntpath.realpath() should use GetFinalPathNameByHandle()
versions: +Python 3.7 -Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com