[issue1492704] distinct error type if shutil.copyfile() fails because of src and dst are the same file

2014-03-10 Thread Roundup Robot
Roundup Robot added the comment: New changeset 276227a93f6f by R David Murray in branch 'default': whatsnew: shutil copyfile SameFileError (#1492704) http://hg.python.org/cpython/rev/276227a93f6f -- ___ Python tracker rep...@bugs.python.org

[issue1492704] distinct error type if shutil.copyfile() fails because of src and dst are the same file

2012-10-29 Thread Hynek Schlawack
Hynek Schlawack added the comment: You're welcome. :) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1492704 ___ ___ Python-bugs-list mailing

[issue1492704] distinct error type if shutil.copyfile() fails because of src and dst are the same file

2012-10-28 Thread Roundup Robot
Roundup Robot added the comment: New changeset e59e274551e0 by Hynek Schlawack in branch 'default': #1492704: Ensure and document backward compatibility of the change http://hg.python.org/cpython/rev/e59e274551e0 -- ___ Python tracker

[issue1492704] distinct error type if shutil.copyfile() fails because of src and dst are the same file

2012-10-28 Thread Éric Araujo
Éric Araujo added the comment: Thank you! -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1492704 ___ ___ Python-bugs-list mailing list

[issue1492704] distinct error type if shutil.copyfile() fails because of src and dst are the same file

2012-10-27 Thread Éric Araujo
Éric Araujo added the comment: I think it should be documented and tested that this change is backward-compatible, as the new error class inherits from the one previously used. -- ___ Python tracker rep...@bugs.python.org

[issue1492704] distinct error type if shutil.copyfile() fails because of src and dst are the same file

2012-10-07 Thread Roundup Robot
Roundup Robot added the comment: New changeset e11642068f85 by Hynek Schlawack in branch 'default': Closes #1492704: Make shutil.copyfile() raise a distinct SameFileError http://hg.python.org/cpython/rev/e11642068f85 -- resolution: - fixed stage: - committed/rejected status: open -

[issue1492704] distinct error type if shutil.copyfile() fails because of src and dst are the same file

2012-07-19 Thread Roundup Robot
Roundup Robot devn...@psf.upfronthosting.co.za added the comment: New changeset 9e94eb39aaad by Hynek Schlawack in branch 'default': #1492704: Make shutil.copyfile() raise a distinct SameFileError http://hg.python.org/cpython/rev/9e94eb39aaad -- nosy: +python-dev

[issue1492704] distinct error type if shutil.copyfile() fails because of src and dst are the same file

2012-07-19 Thread Hynek Schlawack
Hynek Schlawack h...@ox.cx added the comment: As beta2 has been postponed I have already committed it with some slight modifications. Re: deriving from Error: It doesn't make any sense to do so but this way we're mostly backward compatible. Changing it to EnvironmentError uncovered the two

[issue1492704] distinct error type if shutil.copyfile() fails because of src and dst are the same file

2012-07-19 Thread Éric Araujo
Éric Araujo mer...@netwok.org added the comment: Did you get an exception from the release manager for this new feature? -- nosy: +georg.brandl ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1492704

[issue1492704] distinct error type if shutil.copyfile() fails because of src and dst are the same file

2012-07-19 Thread Hynek Schlawack
Hynek Schlawack h...@ox.cx added the comment: Oh my understanding was that it was pushed to 3.4 only because of the then imminent beta2. Georg, is it okay to keep it? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1492704

[issue1492704] distinct error type if shutil.copyfile() fails because of src and dst are the same file

2012-07-19 Thread Georg Brandl
Georg Brandl ge...@python.org added the comment: Sorry, looks like a feature to me. Please wait for 3.4 with it. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1492704 ___

[issue1492704] distinct error type if shutil.copyfile() fails because of src and dst are the same file

2012-07-19 Thread Hynek Schlawack
Hynek Schlawack h...@ox.cx added the comment: Ok sorry, backing out. -- resolution: fixed - stage: committed/rejected - status: closed - open versions: +Python 3.4 -Python 3.3 ___ Python tracker rep...@bugs.python.org

[issue1492704] distinct error type if shutil.copyfile() fails because of src and dst are the same file

2012-07-19 Thread Roundup Robot
Roundup Robot devn...@psf.upfronthosting.co.za added the comment: New changeset 3adb4ee4b794 by Hynek Schlawack in branch 'default': #1492704: Backout and wait for 3.4 http://hg.python.org/cpython/rev/3adb4ee4b794 -- ___ Python tracker

[issue1492704] distinct error type if shutil.copyfile() fails because of src and dst are the same file

2012-07-16 Thread Hynek Schlawack
Hynek Schlawack h...@ox.cx added the comment: Sorry, I didn’t look at zooko’s patch which was also just about copyfile. I presume it’s all about the copy fallback that happens when os.rename didn’t work out. Will look at your code more closely later. -- title: distinct error type

[issue1492704] distinct error type if shutil.copyfile() fails because of src and dst are the same file

2012-07-16 Thread Atsuo Ishimoto
Atsuo Ishimoto ishim...@gembook.org added the comment: Ooops, shutil.move() will raise SameFileError if destination is directory. I'll investigate the patch further more. -- ___ Python tracker rep...@bugs.python.org

[issue1492704] distinct error type if shutil.copyfile() fails because of src and dst are the same file

2012-07-16 Thread Atsuo Ishimoto
Atsuo Ishimoto ishim...@gembook.org added the comment: Patch updated. - SameFileError is now derived from EnvironmentError. - Fixed documentation. - Fixed test method name. I investigated this patch: - shutil.copyfile() and shutil.copy() raises SameFileError if source and destination are

[issue1492704] distinct error type if shutil.copyfile() fails because of src and dst are the same file

2012-07-16 Thread Hynek Schlawack
Hynek Schlawack h...@ox.cx added the comment: - SameFileError is now derived from EnvironmentError. Why? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1492704 ___

[issue1492704] distinct error type if shutil.copyfile() fails because of src and dst are the same file

2012-07-16 Thread Atsuo Ishimoto
Atsuo Ishimoto ishim...@gembook.org added the comment: - SameFileError is now derived from EnvironmentError. Why? oh, sorry, I misunderstood you suggested to do so. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1492704

[issue1492704] distinct error type if shutil.copyfile() fails because of src and dst are the same file

2012-07-16 Thread Hynek Schlawack
Hynek Schlawack h...@ox.cx added the comment: No, sorry if my ramblings confused you. I'm pondering about deriving Error from OSError in 3.4. That has nothing to do with this ticket. I just saw it while glancing over your patch. -- ___ Python

[issue1492704] distinct error type if shutil.copyfile() fails because of src and dst are the same file

2012-07-16 Thread Atsuo Ishimoto
Atsuo Ishimoto ishim...@gembook.org added the comment: Patch updated. - SameFileError is reverted to be derived from shutil.Error as original patch. -- Added file: http://bugs.python.org/file26406/issue1492704_new_3.patch ___ Python tracker