[issue14935] PEP 384 Refactoring applied to _csv module

Change by Terry J. Reedy : -- versions: +Python 3.10 -Python 3.4 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue14935] PEP 384 Refactoring applied to _csv module

Petr Viktorin added the comment: Thank you for working on this! It took several years and some new C-API to get it right (see PEP 630), but I believe this and the related issues bpo-18710 and bpo-34533 can now be closed. -- resolution: -> fixed stage: patch review -> resolved

[issue14935] PEP 384 Refactoring applied to _csv module

Petr Viktorin added the comment: New changeset 6a02b384751dbc13979efc1185f0a7c1670dc349 by Petr Viktorin in branch 'master': bpo-14935: Remove static state from the _csv module (GH-23224) https://github.com/python/cpython/commit/6a02b384751dbc13979efc1185f0a7c1670dc349 --

[issue14935] PEP 384 Refactoring applied to _csv module

Change by Petr Viktorin : -- nosy: +petr.viktorin nosy_count: 2.0 -> 3.0 pull_requests: +22122 pull_request: https://github.com/python/cpython/pull/23224 ___ Python tracker

[issue14935] PEP 384 Refactoring applied to _csv module

Robin Schreiber added the comment: Fixed the dealloc-methods of the types, for proper type dereferencing. -- Added file: http://bugs.python.org/file26797/csv_pep384_v2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14935

[issue14935] PEP 384 Refactoring applied to _csv module

Changes by Robin Schreiber robin.schrei...@me.com: -- versions: +Python 3.4 -Python 3.3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14935 ___

[issue14935] PEP 384 Refactoring applied to _csv module

Robin Schreiber robin.schrei...@me.com added the comment: Added missing INCREF and DECREF inside the dealloc, and new methods of the types. -- Added file: http://bugs.python.org/file26381/csv_pep384_v1.patch ___ Python tracker rep...@bugs.python.org

[issue14935] PEP 384 Refactoring applied to _csv module

Robin Schreiber robin.schrei...@me.com added the comment: I was of course referring to PEP 384. Sorry for the inconvenience. -- title: PEP 341 Refactoring applied to _csv module - PEP 384 Refactoring applied to _csv module ___ Python tracker